XhmikosR
551f37aff6
tests: comply to the new rules
...
Use `assert.strictEqual`/`assert.true`/`assert.false`
2021-09-15 15:44:20 +03:00
alpadev
b010a6f9f4
fix(modal): change the order we return from show() method ( #34087 )
...
In case of a modal with fading enabled, a prevented show event can cause show to not showing the modal anymore.
See #34055
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-25 20:36:11 +03:00
Rohit Sharma
bfb773d64b
Backport #32179 ( #32220 )
...
Don't hide modal when `config.keyboard` is false
2020-11-21 22:14:28 +02:00
Joakim Riedel
b0a0c56788
ensure hidePrevented.bs.modal can be prevented ( #31696 )
2020-09-21 14:41:40 +03:00
XhmikosR
3be585990c
Comply to the new rules
2020-09-10 12:06:30 +03:00
ysds
9a6cfeb36e
Backport #30326 (Unit test)
2020-07-06 16:40:27 +03:00
XhmikosR
8bc6dcd280
Backport #30936
...
Add role="dialog" in modals via JavaScript
2020-06-04 17:53:16 +03:00
XhmikosR
30e7df6cca
Backport d59de33 from #30772
...
Add a test about the scrollbar issue on non-integer width
2020-05-12 19:21:36 +03:00
XhmikosR
eb720f20ff
Minor lint tweaks and rules cleanup
2020-05-12 19:21:36 +03:00
XhmikosR
5f79b75ea8
tests: switch to strictEqual/notStrictEqual
2020-05-12 19:21:36 +03:00
Giovanni Mendoza
6daae47cc0
Backport #29886
...
Close modal with keyboard=true & backdrop=static
2020-02-17 21:33:54 +02:00
Johann-S
dd96b832f7
backport #29516 : added animation when modal backdrop is static
2019-11-02 10:02:07 +02:00
Johann-S
e4d4c5d0bc
Backport #29155
...
allow dynamic modal body for scrollable modals
2019-07-31 11:37:39 +03:00
Johann-S
c50c1e9d23
fix unit tests for chrome mobile
2019-04-29 17:41:28 +03:00
Johann-S
b54ddfda83
fix modal test to be sure we call getTransitionDurationFromElement
2019-02-06 15:01:13 +01:00
Shohei Yoshida
de0bb1e052
Scrollable modal ( #27769 )
2019-01-20 23:28:16 +02:00
Johann-S
3bd9fb3649
getSelectorFromElement return null on bad selectors ( #27912 )
2018-12-23 14:30:35 +02:00
Patrick H. Lauke
6c00dd08bc
Add aria-modal to modals ( #27780 )
...
Dynamically set/remove `aria-modal="true"` when a modal is shown/hidden
2018-12-05 20:58:09 +02:00
Johann-S
32ab52ba2e
Add test to make sure we enforce focus on modal ( #27723 )
2018-11-25 18:20:55 +02:00
Johann-S
cebdfb9090
fix dispose modal unit test
2018-10-30 16:59:24 +01:00
Andrew Luca
bd2851938a
test(Modal): check if modal is disposed
2018-10-30 16:28:32 +01:00
Johann-S
ffc8d507c7
calculate modal transition duration based on modal-dialog element
2018-10-28 23:59:17 +02:00
Andrew Luca
1f1308ba22
test(Modal): reuse _getScrollbarWidth in tests
2018-10-21 17:45:02 +02:00
Johann-S
a689120fd2
throw error when folks try to use a bad selector
2018-09-13 22:13:36 +02:00
Johann-S
283ab30164
fix(modal): fix unit test and resetting style
2018-07-11 11:05:38 +02:00
Catalin Zalog
cb82394fc8
fix(modal): removes .navbar-toggler margin
2018-07-11 11:05:38 +02:00
Johann-S
0338b61eb6
chore(deps): update qunit and karma-qunit
2018-05-22 17:26:21 +03:00
XhmikosR
80d0943b95
Comply to the new rules.
2018-01-11 18:48:46 +02:00
Johann-S
e8ba37139f
Allow us to run our unit test on differents jquery version
2017-11-23 10:41:56 +02:00
XhmikosR
be9e6f3638
Update modal.js
2017-10-04 15:03:06 +03:00
lucascono
47968c8126
Unit test for modal bug fix
...
Unit test for pull request #24240
2017-10-04 08:55:40 -03:00
Johann-S
e04e42d08c
Merge branch 'v4-dev' into fix-jumping-modal-on-resize
2017-09-03 12:56:04 +02:00
David Bailey
ce41d3fd15
Add failing test
2017-08-29 15:36:37 +01:00
David Bailey
2622a015f2
Fix unit tests in PhantomJS
...
Use a virtual scrollbar as this is simpler than having a real one (overflow: scroll doesn't seem to work in Phantom), and disable it for the new test.
One test has also been altered to prevent erroneous fails when other inline styles are added to the body (e.g. overflow).
2017-08-29 12:01:41 +01:00
David Bailey
487513ff03
Add failing test
...
When the body does not overflow (achieved by hiding the QUnit container), it should not be given a margin.
2017-08-28 16:21:04 +01:00
meeque
9612830701
Add unit test for xss in data target attribute
2017-08-25 23:20:14 +01:00
David Bailey
ba6a6f1369
Fix sticky margin when a modal is opened ( #23669 )
...
* Adjust margin for sticky elements on modal
Previously white space was visible to the right of sticky elements due to right padding being added to the body. This fixes #23661 .
* Add unit tests for margin of sticky elements on modal
2017-08-25 22:01:41 +01:00
XhmikosR
ef8c77d8dc
Tweak ESLint rules.
2017-08-23 00:05:38 +03:00
Ilias
e6e070b02a
Fix #22332 : Adjust tests for hidden scrollbar
2017-04-03 13:27:15 +02:00
Ilias
a14451deb3
Fix #18373 : properly adjust padding-right of body and fixed elements when opening or closing modal
2017-04-02 13:26:25 +02:00
Mark Otto
c61a0059ad
update seletors in js
2017-01-02 11:52:38 -08:00
Mark Otto
25d218b02d
Merge branch 'v4-dev-18796' of https://github.com/maxbeatty/bootstrap into maxbeatty-v4-dev-18796
2016-11-26 00:58:51 -08:00
Johann
ce18a66809
Add test unit to check logic of ignoreBackdropClick ( #18245 )
2016-11-25 22:57:20 -08:00
Bardi Harborow
c2616fb74e
Make JS compliant with the new ESLint rules.
2016-11-24 11:59:55 +11:00
Mark Otto
c01fa6b369
Merge pull request #17536 from Johann-S/testPadding
...
[Fix #17400 ] Add tests about padding restoration
2016-10-28 13:46:14 -07:00
Max Beatty
bfa714ae1e
prevent navigating to area href when modal target. fixes #18796
2016-08-04 13:47:30 -07:00
Patrick H. Lauke
b107e3342a
Handle aria-hidden on modal container when showing/hiding
...
Fixes #19878
2016-05-11 02:01:56 +01:00
Chris Rebert
96e9205009
js/tests/unit/modal.js: Fix typo
...
[ci skip]
2015-12-22 17:11:21 -07:00
Johann-S
21a65f181e
Add throw error for undefined method on plugins
2015-10-02 10:01:24 +02:00
Johann-S
8ece899ba8
Add tests about padding restoration
2015-09-10 08:19:59 +02:00
