0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-14 02:24:00 +01:00
Commit Graph

558 Commits

Author SHA1 Message Date
Patrick H. Lauke
b4c994d296
Remove confusing unnecessary id/aria-labelledby for dropdown menus (#36491)
v4 port of https://github.com/twbs/bootstrap/pull/36487
2022-06-03 17:28:18 +01:00
Louis-Maxime Piton
8274bf25d0
Fixing tabs' tests (#36485) 2022-06-02 12:58:43 +03:00
Patrick H. Lauke
7d57d9a68b
Dynamic tabs: use buttons rather than links (backport to v4) (#33163)
* Manually backport 32630

Dynamic tabs: use buttons rather than links

* Tweak unit test

* Tweak unit tests

* More tweakage

* show() should also bail if `disabled` attribute is set

* Tweak tests

* Simplify test for relatedTarget

* Temporarily remove problematic test

(as i can't get local tests to run just noww)

* Revert previous

* test: fix broken test cases for tab.js

* test: fix role=tablist invalid on nav element

* test: prefer <div/> over <div></div>

* Manually backport 32630

Dynamic tabs: use buttons rather than links

* test: fix broken test cases for tab.js

* Fixes

* Remove and ignore lock file

Co-authored-by: alpadev <alpa.muc@gmail.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
Co-authored-by: Mark Otto <markdotto@gmail.com>
2022-05-24 11:16:58 -07:00
XhmikosR
bdab948670 Remove unneeded conditional 2021-09-15 15:44:20 +03:00
XhmikosR
af52795501 Remove duplicate test. 2021-09-15 15:44:20 +03:00
XhmikosR
f6ff736a59 Change test description so that it's unique 2021-09-15 15:44:20 +03:00
XhmikosR
77e0855e5e Merge duplicate test. 2021-09-15 15:44:20 +03:00
XhmikosR
ed62ab6e41 Remove commented out test 2021-09-15 15:44:20 +03:00
XhmikosR
d4e162f4ac Skip tests if attachShadow is not present 2021-09-15 15:44:20 +03:00
XhmikosR
551f37aff6 tests: comply to the new rules
Use `assert.strictEqual`/`assert.true`/`assert.false`
2021-09-15 15:44:20 +03:00
XhmikosR
5391ecdfde Add eslint-plugin-qunit 2021-09-15 15:44:20 +03:00
XhmikosR
e202996a2b Update devDependencies
* @babel/cli                   ^7.14.8  →  ^7.15.5
* @babel/core                  ^7.14.8  →  ^7.15.4
* @babel/preset-env            ^7.14.8  →  ^7.15.6
* @rollup/plugin-commonjs      ^19.0.1  →  ^20.0.0
* @rollup/plugin-node-resolve  ^13.0.2  →  ^13.0.4
* autoprefixer                 ^10.3.1  →  ^10.3.4
* clean-css-cli                 ^5.3.0  →   ^5.3.3
* eslint                       ^7.31.0  →  ^7.32.0
* eslint-config-xo             ^0.37.0  →  ^0.38.0
* eslint-plugin-import         ^2.23.4  →  ^2.24.2
* eslint-plugin-unicorn        ^34.0.1  →  ^36.0.0
* hugo-bin                     ^0.74.0  →  ^0.76.1
* qunit                        ^2.16.0  →  ^2.17.1
* postcss                       ^8.3.5  →   ^8.3.6
* rollup                       ^2.53.3  →  ^2.56.3
* vnu-jar                      21.6.11  →   21.9.2
2021-09-15 15:31:00 +03:00
alpadev
b010a6f9f4
fix(modal): change the order we return from show() method (#34087)
In case of a modal with fading enabled, a prevented show event can cause show to not showing the modal anymore.

See #34055

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-25 20:36:11 +03:00
Carson Sievert
4b5eb3ca51
Backport #33634 (#33649)
Dropdown: support `.dropdown-item` wrapped in `<li>` tags
2021-04-28 07:02:22 +03:00
Patrick H. Lauke
d967553913
Remove aria-haspopup from dropdowns (#33624)
`aria-haspopup="true"` is really intended to signal that an ARIA `menu` will be opened on activation. as a result, some assistive technologies will announce controls with `aria-haspopup="true"` as a menu or menu item (e.g. JAWS and NVDA).
In addition, `aria-haspopup` seems to trigger a bug in Edge/Narrator where the `aria-expanded` state is not correctly announced at the moment when `aria-haspopup` is present.
This now makes the dropdown button more like a generic disclosure widget control - see also https://www.w3.org/TR/wai-aria-practices-1.2/examples/disclosure/disclosure-navigation.html01
2021-04-15 06:35:54 +03:00
Nikon the Third
7ad0625b8d
Adjust SAFE_URL_PATTERN regex for use with test method. (#33153)
The `test` method on regexes does not behave like `match` on strings
for checks if the regex matches when the global modifier (g) is present.

Also adds a unit test on tooltips for sanitizing the same template twice.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-03-02 17:16:09 +02:00
XhmikosR
17d8fba548
Update devDependencies (#32852)
Pin karma and linkinator due to failures
2021-01-27 18:37:18 +02:00
XhmikosR
57e045f0ab Backport #32224
Be consistent with Popper's name.
2020-11-24 08:40:11 +02:00
Rohit Sharma
bfb773d64b
Backport #32179 (#32220)
Don't hide modal when `config.keyboard` is false
2020-11-21 22:14:28 +02:00
James Remeika
2d8c02eb10
tooltip/popover: add a customClass option (#31834)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-20 11:56:16 +02:00
Mitchell Bryson
896e444895
Check for data-interval on the first slide of carousel - v4 (#31820)
When starting a cycle for a carousel, it only checks for a default interval, and not an interval defined on the slide element via data props. This adds a check in before creating the interval to move to the next slide.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-12 09:34:17 +02:00
XhmikosR
b3aa3958da Backport #32045
tests: fix sanitizer test.

The test template does not include a `script` tag so the test always returned true.
2020-11-05 11:22:05 +02:00
XhmikosR
1b48122641 Update .eslintrc.json
Enforce ES5 for tests
2020-10-13 15:24:40 +03:00
Laussel Loïc
24572b1577
buttons plugin : avoid multiple change event trigger (#31000)
- add unit test to count how many events are thrown when widget contains multiple tags inside label
- add a parameter to toggle, if click event is provided onto an input then don't trigger another change event already thrown by the browser
- simplify the case where toggle interface is called click provide from input itself OR it's a button without label. If label is present, then browser propagate click event from childrens through label and then cause multiple calls to toggle
- the test assumes that `.btn` class is always set onto the label if there's one, otherwise need to update this plugin and look for label around the input

Test with keyboard, mouse and js click call

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-10-02 17:40:20 +03:00
Joakim Riedel
b0a0c56788
ensure hidePrevented.bs.modal can be prevented (#31696) 2020-09-21 14:41:40 +03:00
XhmikosR
3be585990c Comply to the new rules 2020-09-10 12:06:30 +03:00
XhmikosR
1c37a2ba77 Switch to xo and remove babel-eslint 2020-09-10 12:06:30 +03:00
Rohit Sharma
1abe9264aa Add unit test for toast to check clearTimeout to have been called (#31298) 2020-08-03 19:06:36 +03:00
ysds
9a6cfeb36e Backport #30326 (Unit test) 2020-07-06 16:40:27 +03:00
XhmikosR
78a51cb12f Backport #30973
Remove the class `.nav-item` from `.nav-link` inside the non `ul` or `ol` based navs.
This makes the consistency for `.nav-item` (This class will not be required on the `.nav-link`).
`.nav-item` was only required when you use `.nav-fill` or `.nav-justified` on the `.nav`. In other cases, it was redundant. And the purpose of `.nav-item` on `.nav-link`s can be achieved via flexbox utilities as well (Mentioned in the docs also).
2020-06-24 15:16:58 +03:00
Laussel Loïc
e9f039d1fe
avoid preventing input event onclick (#30992)
* instead of stopping event if onclick is triggered on input, call toggle method only if its not on checkbox inside a label

* add unit test

* add a dedicated test to ensure click event is forward to label

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-06-10 15:45:31 +03:00
XhmikosR
8bc6dcd280 Backport #30936
Add role="dialog" in modals via JavaScript
2020-06-04 17:53:16 +03:00
XhmikosR
30e7df6cca Backport d59de33 from #30772
Add a test about the scrollbar issue on non-integer width
2020-05-12 19:21:36 +03:00
XhmikosR
eb720f20ff Minor lint tweaks and rules cleanup 2020-05-12 19:21:36 +03:00
XhmikosR
5f79b75ea8 tests: switch to strictEqual/notStrictEqual 2020-05-12 19:21:36 +03:00
XhmikosR
195585f5a6 scrollspy.js add more tests 2020-05-12 19:21:36 +03:00
Johann-S
22f75ca2e3 enforce element check on scrollspy target 2020-05-07 09:31:49 +03:00
Martijn Cuppens
7a678fc64f Backport #30633
Remove caret element
2020-04-28 20:59:30 +03:00
XhmikosR
d848c32297 Fix tests for jQuery v3.5.0. 2020-04-17 11:41:32 +03:00
Laussel Loïc
0cf29baf63
v4 tabs - accessibility issue when using ul/li semantic (#30381)
Add aria-role presentation on li element when ul element has role tablist and remove dropdown from visual tests as they've been removed from doc
2020-04-10 08:35:09 +03:00
luktom
8cc9defbc0
Fix event propagation from inactive and disabled dropdowns (#30510) (#30511) 2020-04-07 21:16:17 +03:00
Johann-S
dabd458b4b Backport (#30383)
fix: ensure totype always return stringified null when null passed
2020-03-31 21:11:29 +03:00
Laussel Loïc
8b6dd449d7
fix $().button('toggle') not working for checkbox inside label (#30388) 2020-03-16 14:28:33 +02:00
Giovanni Mendoza
6daae47cc0 Backport #29886
Close modal with keyboard=true & backdrop=static
2020-02-17 21:33:54 +02:00
Johann-S
dd96b832f7 backport #29516: added animation when modal backdrop is static 2019-11-02 10:02:07 +02:00
Johann-S
29f585365f backport #29523: skip hidden dropdowns while focusing 2019-11-02 10:02:07 +02:00
Johann-S
ef1c7aadbc Backport #29298
dropdown show method should do the same as toggle
2019-08-27 16:32:25 +03:00
Johann-S
bab999701c Backport #29277
dropdown - destroy old popper.js references
2019-08-27 16:32:25 +03:00
Johann-S
7652d326e4 Backport #29251
allow to pass popper.js configuration for tooltip/popover and dropdown
2019-08-27 16:32:25 +03:00
Johann-S
e4d4c5d0bc Backport #29155
allow dynamic modal body for scrollable modals
2019-07-31 11:37:39 +03:00