rooty/Bootstrap
0
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-12 00:08:59 +01:00
Code Issues Actions Packages Releases Activity
11,412 Commits 108 Branches 89 Tags 552 MiB
57a9a5c803
Commit Graph

213 Commits

Author SHA1 Message Date
Patrick H. Lauke
3d244537fb Slightly expand accessible modals callout 
to include a note about `role="document"`
 2015-06-11 12:47:52 +01:00
Patrick H. Lauke
e23868c9cf Add role="document" to modal itself 
Initial fix to generalise use of modals. Generally, true role="dialog"
containers would require only forms/controls as content, with all other
text correctly and explicitly associated via
aria-labelledby/aria-describedby and similar...but as authors use modals
also as generic overlays, this extra role is required to get AT
(particularly NVDA) out of "forms" mode and reenable reading keys
 2015-06-11 12:40:24 +01:00
Patrick H. Lauke
caca5d46d5 Merge pull request #16571 from patrickhlauke/generalize-dropdowns 
generalize dropdowns / drop role="menu"
 2015-06-02 11:21:26 +01:00
Patrick H. Lauke
5fd7bc1554 generalize dropdowns / drop role="menu" 
as role="menu" is a very specific (and strict) ARIA pattern for
desktop-like application menus, and our dropdowns are often used
as pure navigation dropdowns, this change abandons ARIA menus for
a more open-ended and light-weight approach
(see http://heydonworks.com/practical_aria_examples/#submenus and
http://www.w3.org/WAI/tutorials/menus/flyout/#improve-screen-reader-support-using-wai-aria)
note that in dropdown.js, switched to now target ``.dropdown-menu``
instead of ``role["menu"]`` - this also prevents bootstrap scripts
from "bleeding" into non-bootstrap components on the same page.
also removed the ``role=["listbox"]`` part, which appears to be
vestigial/unused (only place in bootstrap that uses that
role are carousels, and their key handling is done separately)
 2015-06-02 11:03:21 +01:00
Mark Otto
b5b4c9c701 Merge pull request #16484 from kkirsche/patch-13 
ScrollSpy requires non-body elements to have height and overflow…
 2015-05-30 17:32:20 -07:00
Kevin Kirsche
962ae5ac2f [Close #16441] ScrollSpy requires non-body elements to have height and padding 
[Close #16441] ScrollSpy requires non-body elements to have height and padding
 2015-05-30 18:24:23 -04:00
Patrick H. Lauke
3b59b97c62 ensure divider list items have role="separator" 
http://www.w3.org/TR/wai-aria/roles#separator
 2015-05-29 23:48:35 +01:00
Kevin Kirsche
97f8e5610d Clarify the bs-callout on multiple open modals 
[Close #16502] Clarify the bs-callout on multiple open modals

Currently it states overlapping modals, this isn't the only case as this truly applies to any instance when a user would want to open multiple modals at the same time. For this reason, I have modified the title of the callout to make this more clear.
 2015-05-18 18:30:58 -04:00
XhmikosR
315907c97c Use https when possible. 2015-05-17 12:43:20 +03:00
Julian Thilo
a3c480fd94 Closes #16249: Doc that nested tabs are not supported 2015-05-06 22:37:56 +02:00
Chris Rebert
89f2c5c5c0 Document that $(...).button('reset') is async. 
Closes #16362.
[skip sauce]
 2015-05-05 15:03:12 -07:00
Chris Rebert
fce30b57e2 Mark stateful button feature as deprecated 
Refs https://github.com/twbs/bootstrap/issues/16362#issuecomment-96268469
[skip sauce]
 2015-05-05 15:03:05 -07:00
Chris Rebert
a19441dd64 Merge pull request #16409 from twbs/fix-16361 
Document Affix plugin's `checkPosition` method
 2015-05-04 12:28:41 -07:00
Chris Rebert
75d6c14dc9 Document that 'manual' is mutually exclusive of other tooltip/popover triggers 
Closes #16122
[skip sauce]
 2015-05-02 18:24:12 -07:00
Chris Rebert
85235c55ac Document Affix plugin's checkPosition method 
Fixes #16361
Refs #16356
[skip sauce]
 2015-05-02 13:02:48 -07:00
Adrien Siami
e949505b89 Allow viewport option to be a function 
Closes #16151 by merging a rebased version of it that adds docs and 1 more assertion.
 2015-04-21 22:20:15 -07:00
Chris Rebert
c6b62f0cd9 Merge pull request #16147 from Johann-S/event_inserted 
Fixes #16124.
 2015-04-21 21:40:14 -07:00
Joshua Tauberer
20b5e24765 affix plugin does not work within a pulled/pushed column 
This documents the limitation discussed in https://github.com/twbs/bootstrap/issues/12126:

> When using column reordering and using the affix-plugin on an element positioned with push, the affix plugin doesn't work correctly - the element affected by the affix plugin is positioned to the left even when the element is in a column positioned on the right.

Seems to affect Safari (tested in version 8) only.

That issue has (unfortunately) been closed, so this at least documents the behavior.
 2015-04-14 16:37:07 -04:00
Johann-S
3d71eae301 Add event after template inserted 2015-04-08 13:10:53 +02:00
Chris Rebert
4cf748b017 Carousel docs: fix typo in holder.js color 2015-04-07 18:52:59 -07:00
fyquah95
4d153b9125 indented javascript/modal/using-grid-system sample code from 4 spaces to 2 spaces 2015-04-01 17:43:32 +08:00
Patrick H. Lauke
3b28b75cf3 Remove wrong role="tabpanel" from parent container 
As per discussion on https://github.com/w3c/wai-wcag-quickref/issues/2
and #13554
 2015-03-27 11:57:03 +00:00
Chris Rebert
caa84299ec Merge pull request #16158 from twbs/fix-16020 
remove redundant aria-hidden usage from Modals
 2015-03-25 18:40:44 -07:00
Chris Rebert
d6714d1383 Merge pull request #16157 from twbs/fix-16069 
Document how to disable transitions in jQuery plugins
 2015-03-25 18:14:15 -07:00
Chris Rebert
6c5e7dfce1 rm redundant aria-hidden usage from Modals; fixes #16020 2015-03-25 18:06:47 -07:00
Chris Rebert
e8a5112b31 Document how to disable transitions in jQuery plugins; fixes #16069 
[skip sauce]
 2015-03-25 17:56:59 -07:00
Chris Rebert
343827081f Properly document $(...).tab('show') method; fixes #16115 
[skip sauce]
 2015-03-25 17:47:56 -07:00
Chris Rebert
1bafd4c829 docs: #myTab => #myTabs, to slightly increase clarity 2015-03-25 17:39:44 -07:00
Chris Rebert
2f3076f20a add missing <code> within docs heading for .modal('handleUpdate') 2015-03-24 15:15:21 -07:00
Chris Rebert
d37bc2ae65 Merge pull request #15987 from twbs/fix-15972 
add role="button" to a[data-toggle="collapse"]
 2015-03-24 08:57:56 -07:00
Patrick H. Lauke
6c2548e031 Move all tooltip callouts into appropriate section 
Before, most callouts hierarchically came under Examples > Four
directions, which is not appropriate. Now they're under Markup
 2015-03-23 22:06:22 +00:00
Patrick H. Lauke
debcb1de59 Callout for tooltips and keyboard/AT accessibility 
Include callout explicitly mentioning tooltips should only be added to
focusable elements. Closes #16134
 2015-03-23 21:53:30 +00:00
Chris Rebert
66ceae7b75 Clarify that role="button" is required for dismiss-on-next-click popovers 
Refs #15947
 2015-03-16 00:57:23 -07:00
Chris Rebert
cc39f5c52d add role="button" to a[data-toggle="collapse"]; fixes #15972 2015-03-03 13:18:36 -08:00
Steven Black
457885075f Javascript docs: Accessibility and cosmetic changes to headings. 
Closes #15915 by merging it.
 2015-03-03 18:22:09 +02:00
Heinrich Fenkart
be68cdd4b8 Properly document Modal#handleUpdate 2015-03-03 06:45:38 +01:00
Kevin Kirsche
7b3e4d8423 Replace accidently removed text 
X-Ref #15742

cc: @mdo
 2015-03-01 16:24:12 -05:00
Mark Otto
8982de3482 Merge pull request #15914 from StevenBlack/docs.js.headings 
docs > js > headings
 2015-02-24 21:14:43 -08:00
Kevin Kirsche
769c27a19f Document how to properly handle modals with dynamic content height 
Fixes #15106.
Closes #15910.
 2015-02-25 03:23:02 +01:00
Steven Black
e9b29a3ef0 Accessibility changes to headings (transitions.html) 2015-02-24 20:19:00 -05:00
Steven Black
daccfc3c0f Accessibility changes to headings (overview.html) 2015-02-24 20:17:14 -05:00
Kevin Kirsche
ced312a90e [Docs—Fixes #15882]Use an ID as the example for Scrollspy 
Fixes #15882 — Use an ID as the example for Scrollspy so that it is more clear that this is for use with a single nav.
 2015-02-24 09:14:50 -05:00
Kevin Kirsche
504435e0b0 Fix #15712: Add example of how to use grid system within a modal 
Closes #15725 by merging a tweaked version of it.
 2015-02-19 16:14:06 -08:00
Chris Rebert
89455afe97 Affix docs: add MDN link for position: sticky 2015-02-19 15:55:33 -08:00
Chris Rebert
3748e44b2e Merge pull request #15773 from kkirsche/patch-16 
Fix #15766: Clarify Affix plugin docs
 2015-02-19 15:53:49 -08:00
Kevin Kirsche
744c3646f5 [Fixes #15766] Need Clearer Affix plugin documentation 
[Fixes #15766] Need Clearer Affix plugin documentation

Remove trailing whitespace

Update the documentation
 2015-02-19 16:38:03 -05:00
Chris Rebert
19a6406ec4 fix indentation of highlighted code in Modal docs 2015-02-12 10:36:15 -08:00
Chris Rebert
e7de01eeed Update Twitter handle: @twbootstrap => @getbootstrap 
Refs 1c94b7791f
CC: @mdo
 2015-02-06 11:54:07 -08:00
Kevin Kirsche
be2206edfc [Fix Issue #15701] Tooltip/popover destroy docs don't explain the delegation case 
[Fix Issue #15701] Tooltip/popover destroy docs don't explain the delegation case.

Add to popovers
 2015-02-03 15:49:03 -05:00
Chris Rebert
012af29efc Merge pull request #15740 from twbs/carousel-events-target 
Clarify target of carousel events
 2015-02-03 10:58:33 -08:00