Gaël Poupard
58ab1c2cd5
test(carousel): french word in the wild ( #32528 )
2020-12-18 17:22:16 +02:00
dependabot[bot]
66f323af70
Bump eslint-plugin-unicorn from 23.0.0 to 24.0.0 ( #32516 )
...
* Bump eslint-plugin-unicorn from 23.0.0 to 24.0.0
Bumps [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn ) from 23.0.0 to 24.0.0.
- [Release notes](https://github.com/sindresorhus/eslint-plugin-unicorn/releases )
- [Commits](https://github.com/sindresorhus/eslint-plugin-unicorn/compare/v23.0.0...v24.0.0 )
Signed-off-by: dependabot[bot] <support@github.com>
* Update karma.conf.js
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-18 15:11:07 +02:00
Rohit Sharma
f12657b39f
tests: replace deprecated jQuery method ( #32309 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-16 17:21:43 +02:00
XhmikosR
29e4eb91c1
BrowserStack: test on macOS Catalina instead of High Sierra ( #32486 )
2020-12-16 12:45:48 +02:00
Rohit Sharma
042a4a255f
Tooltip/popover - change the default value for fallbackPlacements
( #32437 )
...
The default Popper `fallbackPlacements` value is `[oppositePlacement]`.
- The default value was previously (in v4) `'flip'` that can be achieved by passing the single value in the array, like — `[oppositePlacement]`. Keeping `null` also sets the `fallbackPlacements` to `[oppositePlacement]` (Default value in Popper)
- It's better to have **clockwise** (`['top', 'right', 'bottom', 'left']`) fallback options so that tooltip/popover can be placed to another side even if the opposite placement doesn't fit.
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-14 20:51:14 +02:00
Rohit Sharma
ebce95dc60
Tooltip - Add missing callback in async spec ( #32465 )
2020-12-14 13:02:34 +02:00
Gaël Poupard
b85ca045e0
fix(carousel): switch prev/next directions in RTL
2020-12-14 11:11:47 +02:00
XhmikosR
93ab072027
carousel: switch to string constants ( #32393 )
2020-12-11 16:12:13 +02:00
XhmikosR
d154f0df7f
Use the ternary operator in a few more places ( #32303 )
2020-12-11 15:47:34 +02:00
Rohit Sharma
4535b09c46
Tooltip - check if tip and its parent node exist in dispose method ( #32420 )
2020-12-10 21:06:41 +02:00
XhmikosR
1edec546cb
Remove TRANSITION_END
from utils ( #32394 )
2020-12-10 16:54:50 +02:00
XhmikosR
6f9c38f65e
carousel: switch to if/else
( #32395 )
...
There are only two conditions, so `if/else` is shorter and has the same effect.
2020-12-10 00:38:24 +02:00
Martijn Cuppens
f132400865
Add fallback behaviour
2020-12-09 13:34:51 -08:00
XhmikosR
0ca5addea4
alert: rename variables for consistency ( #32392 )
2020-12-09 15:09:41 +02:00
XhmikosR
41bc0e26d2
SelectorEngine: drop variable used once ( #32391 )
2020-12-09 15:05:52 +02:00
alpadev
85208ae557
Refactor components to use a utility function to define jQuery plugins ( #32285 )
...
* refactor: use an utility function to define jQuery plugins
* test: add spec for defineJQueryPlugin utility function
* Update .bundlewatch.config.json
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-08 08:16:50 +02:00
XhmikosR
d15a0247ce
Remove SelectorEngine.matches()
. ( #32339 )
...
It's basically unused.
2020-12-07 19:10:20 +02:00
XhmikosR
63f3d939ea
Dist
2020-12-07 18:18:16 +02:00
XhmikosR
8dc85c657e
Prepare v5.0.0-beta1.
2020-12-07 18:18:16 +02:00
XhmikosR
4eea630d16
Be explicit with element.closest()
's return value
2020-12-06 18:42:40 +02:00
Martijn Cuppens
d8f247392d
Fix conflict with Bootstrap CSS
2020-12-06 18:42:40 +02:00
Johann-S
adfdf7160b
Update to popper.js v2.x
2020-12-06 18:42:40 +02:00
Gaël Poupard
0a141dae94
chore(dist): generate dist files
2020-12-04 07:52:03 +02:00
Gaël Poupard
9488978fb5
feat(RTL): implement RTL
...
Using RTLCSS directives, renaming things to use logical names and following best practices.
2020-12-04 07:52:03 +02:00
XhmikosR
cfe31592d7
Dist ( #32323 )
2020-12-03 16:18:59 +02:00
XhmikosR
cfd00b5eeb
Remove Polyfill leftovers ( #32310 )
...
Leftovers from #32057
2020-12-02 08:30:35 +02:00
XhmikosR
701c6c6e77
Unbreak lines. ( #32304 )
2020-12-02 06:45:15 +02:00
Rohit Sharma
c3689ac073
Remove the show
property from the modal plugin ( #32279 )
...
Drop the support of show property from the modal plugin.
When creating the new modal instance in v5, the `show` property does not work anymore, so instead of fixing the behavior just removing it permanently to keep the consistency between all the plugins. (All other plugins require the `show()` method to be called on the instances to be shown)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-30 12:12:40 +02:00
XhmikosR
03ed3e0b3b
tooltip.js: reuse existent variable
2020-11-30 12:07:51 +02:00
XhmikosR
dd992c7226
Add tests
2020-11-30 12:07:51 +02:00
Patrick H. Lauke
adc857f617
Extra check for existence of any aria-label
...
before overwriting it...
2020-11-30 12:07:51 +02:00
Matty Williams
b0372bb658
Accessibility update for tooltip.js
...
Update to the tooltip.js to add an aria-label attribute that contains the original title of the element, but only if the element doesn't have an existing aria-label attribute.
This is to address cases where screen readers are not capturing the aria-describedby attribute that is added when the tooltip is triggered. This should also avoid a race condition between the screen reader and the appearance of the tooltip.
2020-11-30 12:07:51 +02:00
Rohit Sharma
04674f88b0
Remove setData from construtors ( #32264 )
2020-11-29 20:58:26 +02:00
Johann-S
4999c3dbbc
remove data key in base component
2020-11-29 20:58:26 +02:00
Rohit Sharma
f6a8733741
Move VERSION
to BaseComponent ( #32254 )
2020-11-29 20:58:26 +02:00
Johann-S
9eb9d02084
add dispose in base component
2020-11-29 20:58:26 +02:00
XhmikosR
51a208f119
Switch to Jasmine's toBeInstanceOf
matcher
2020-11-29 20:58:26 +02:00
Johann-S
9f6b342dc7
create a base component
2020-11-29 20:58:26 +02:00
Rohit Sharma
c348ad4a94
Ability to add custom class in tooltip/popover ( #32217 )
...
Porting of #31834 to main.
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-25 09:16:22 +02:00
XhmikosR
767db7b746
tests/integration/index.html: revert accidental changes
2020-11-23 22:14:52 +02:00
Rohit Sharma
7c7f08b5e0
Update bundle.js in tests/integration ( #32233 )
...
* Use `[].concat` instead of direct spreading nodelist
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-23 21:35:46 +02:00
XhmikosR
3e823e0b75
Dist ( #32216 )
2020-11-23 15:17:16 +02:00
XhmikosR
f4457bca02
Be consistent with Popper's name. ( #32224 )
...
The npm package is named "popper.js" but the project is named "Popper", so use the latter consistently.
2020-11-21 16:22:08 +02:00
Rohit Sharma
358c36d4b5
Add missing tags in unit tests ( #32221 )
2020-11-20 20:10:15 +02:00
Rohit Sharma
0839cbf04d
Don't hide modal when keyboard is set to false in modal's configuration ( #32179 )
...
* Don't hide modal when config.keyboard is false
* Update unit test
- Modal should not be closed when pressing esc key if keyboard = false
and backdrop is 'static'
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-20 15:36:24 +02:00
Rohit Sharma
2630b05eb3
Make the attribute methods bs specific ( #32173 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-20 11:13:13 +02:00
XhmikosR
2d4f1b272c
Update karma.conf.js ( #32182 )
...
When we are on CI, this statement won't be reached.
2020-11-18 13:06:04 +02:00
Gaël Poupard
1955ffc01e
Handle Chromium to run Karma ( #32178 )
...
* chore(karma): handle Chromium to run tests
* Update karma.conf.js
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-17 21:42:55 +02:00
XhmikosR
60c79b28aa
BrowserStack: test both on iPhone 7 and iPhone X ( #32154 )
2020-11-16 14:31:03 +02:00
XhmikosR
eaf616c653
Use Array.find
instead of Array.filter
2020-11-14 15:54:50 +02:00