0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-01 13:24:25 +01:00
Commit Graph

2906 Commits

Author SHA1 Message Date
Patrick H. Lauke
32c457db4b
Rework button focus/active styling, with extra changes for checks/radios (#37026)
* Replace :focus styles with :focus-visible

* Remove :active / .active styles

* Don't apply :hover styles for `.btn` that follows a `.btn-check`

This removes a large part of the visual confusion of button checks/radios - that you currently have to move your mouse away from them to see what they actually changed to (checked or unchecked)

* Reintroduce :active, but *not* for button checks/radios

* Sort focus styling specifically for button checks/radios

don't change background on focus, just give it the border/outline. again, avoids confusion whether something is checked or not while focused

* Re-add `outline:0` which was lost when resolving last merge conflict

Co-authored-by: Mark Otto <markd.otto@gmail.com>
2022-09-04 09:59:14 -07:00
Geremia Taglialatela
b8880e5eec Add workarounds for postcss values parser error
postcss-values-parser returns a syntax error when a negative value is
provided in a `calc` function after a CSS variable.

This is not an issue with Bootstrap itself, but a workaround to allow
projects using postcss-values-parser to keep upgrading and compiling
bootstrap

Ref: shellscape/postcss-values-parser#138, twbs/bootstrap#35033

Fix: #36851
2022-09-04 09:45:40 -07:00
AmirHossein
8c380b2676
flush variant of accordion border radius (#36593)
* flush variant of accordion border radius

Fixed issues regarding to last accordion-item has rounded edges at the bottom left and right corners when focused and are in closed state

* Update _accordion.scss

Co-authored-by: Mark Otto <otto@github.com>
2022-09-01 12:55:45 -07:00
Giovanni Piller Cottrer
3ad8551f8b Fix accordion: use $accordion-color rather than computing it via color-contrast 2022-08-31 20:51:22 -07:00
Patrick H. Lauke
cda901f244
v5/docs: reintroduce outline for docs code samples, buttons when :not(:focus-visible) (#36507)
* Remove outline suppression for focused `<pre>`

Sighted keyboard users rely on knowing where their focus is. If the `<pre>` receives focus (so that it can be scrolled by keyboard users, for instance) then it's essential that they know this is the case

* Only suppress outline for buttons when `:not(:focus-visible)`

* Add right-hand margin to pre

avoids having the focus outline awkwardly clipped by the copy button
2022-08-31 18:30:23 -07:00
Florian Lacreuse
2f3aec819a Fix input group z-index focus + validation 2022-08-31 18:17:41 -07:00
louismaximepiton
ebbed79df7 Fix for horizontal list-group item 2022-08-31 18:16:11 -07:00
Julien Déramond
a138bc3fb9 More consistency for CSS/Sass vars doc for components with dark variants 2022-08-31 18:15:11 -07:00
Michael Geuchmann
bc2ec7c758 bugfix undefined border color variable for btn 2022-08-31 18:12:01 -07:00
louismaximepiton
a0238d126b Adding missing CSS variables for z-index 2022-08-31 18:04:09 -07:00
Kitty Giraudel
c3c6591166 Update an outdated name mentioned in a Sass comment 2022-08-10 21:23:41 +02:00
Hadouin
8730ef0f8e
fix #36662 List-group-item margin-top is offset when importing sass in a nested class (#36663)
* fix #36662 & + .list-group-item

* Ignore linter

Co-authored-by: Mark Otto <otto@github.com>
2022-08-03 11:27:51 -07:00
louismaximepiton
6c221aa043 Fix 2022-08-01 09:06:47 -07:00
louismaximepiton
c22dd50e1b Fix floating labels 2022-08-01 08:59:22 -07:00
Julien Déramond
85530309fa
Define correctly $popover-header-color (#36849) 2022-07-29 21:54:18 +02:00
Julien Déramond
17aa6732ab
Fix typos after #36762 (#36771) 2022-07-29 21:49:01 +02:00
Julien Déramond
a153f360ee Fix pagination page items border radius 2022-07-25 16:00:47 -06:00
なつき
04b5d099b3
Remove unused parameter of bsBanner mixin (#36791) 2022-07-22 10:35:38 +02:00
XhmikosR
edf9c40956
Release v5.2.0 (#36768)
* Bump version to 5.2.0

* Dist

* Update masthead.html
2022-07-19 18:43:58 +03:00
Marc Wrobel
705d6857ad Fix typos in code (#36763)
Shoutout is correct but has been replaced by its more common form : Shout-out (https://www.merriam-webster.com/dictionary/shout-out).
2022-07-18 13:30:29 -07:00
JWB
154916ca2e Fixing pagination compile issue
This was an issue with the tables as well, but that has been updated here - 4a3c004c34

This was also noted here - 36501#issuecomment-1153187062_

This effects the 5.2 beta1 that is released on the homepage.

Whats happening is with a fresh download and compile, with some compilers, I noticed not all of them run into this issue, we get the Sass variable showing up and not the actual value.

Steps to reproduce - 
 - Download the source code form the docs for beta 2 and extract
 - Open VSCode -> open folder to the bootstrap directory you just extracted
 - install the "Sass/Less/Stylus/Pug/Jade/Typescript/Javascript Compile Hero Pro" v2.3.53 by Eno Yao extension
 ---- might have to restart VSCode
 - go to that extensions settings, and set the directory to save the output / compiled version to `../dist`
 - tap that Compile Hero on the bottom to activate the extension
 - open `bootstrap.scss` add a space or a new line and save it
 - check the compiles version and you should see the errors
2022-07-17 21:18:55 -07:00
Julien Déramond
150b374933 Fix active/focused button link text color 2022-07-17 20:52:52 -07:00
Mark Otto
71cbb88f09
Support input groups in floating forms (#36759)
* Support input groups in floating forms

* Update bundlewatch

Co-authored-by: 719media <ben@719media.com>
2022-07-17 20:50:41 -07:00
GeoSot
54317bf7c8
Add a banner mixin, helping future releases and maintenance (#36178)
* Add a banner mixin, helping future releases and maintenance

* Update scss/bootstrap-reboot.scss

Co-authored-by: Julien Déramond <julien.deramond@orange.com>

* Apply suggestions from code review

Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
2022-07-11 16:36:12 -07:00
Julien Déramond
a1224482f2
Add $display-font-family and $display-font-style (#36711) 2022-07-11 23:16:33 +02:00
Neeraj Kumar Das
ac654a0f66 Add CSS custom property: --bs-btn-disabled-border-color to mixin: button-outline-variant 2022-07-11 01:38:05 -07:00
Mark Otto
270344a0d5 Remove headings-color CSS variable due to backward compatibility issues 2022-07-11 00:56:26 -07:00
Julien Déramond
2bf383c596 Add missing CSS vars for .navbar-nav 2022-07-07 14:32:35 -07:00
Julien Déramond
7d0b224df4
Revert db61cf3 for $text-muted default value (#36680) 2022-07-06 06:22:30 +02:00
Julien Déramond
9400b8f2f9 Fix tooltip/badge border radius when rounded disabled 2022-06-29 13:41:33 -07:00
Mark Otto
ac0b87b207
Don't style readonly inputs as disabled (#36499)
* Don't style readonly inputs as disabled

Also remove the Chrome-specific focus styling from readonly plaintext

* Update some docs comments
2022-06-14 07:25:49 -07:00
Mark Otto
5f75413735 Generate local CSS variables on utilities when using state option 2022-06-13 14:07:13 -07:00
Mark Otto
d16a16258c Manually set hover and active backgrounds and borders for dark and light buttons 2022-06-08 15:32:05 -07:00
Patrick H. Lauke
3102b4a3e9
Update some WCAG links, expand sass.md contrast explanation (#36489) 2022-06-03 10:42:49 +01:00
Mark Otto
824c5a077b Fix .dropdown-item border-radius when -padding-y is 0 2022-06-01 18:41:26 -07:00
mcoms
78c0ad8044 fix alert border radius 2022-05-30 09:26:41 -07:00
Mark Otto
4a3c004c34
Update Sass for computing .table-group-divider border (#36446)
* Update Sass for computing .table-group-divider border

* Remove stylelint rule
2022-05-26 14:23:54 -07:00
Mark Otto
427c089961 Stylelint: Disable custom-property-empty-line-before 2022-05-22 19:58:14 -07:00
HDPham
7ed1a5f821 Truncate text to prevent multiline floating label 2022-05-21 10:47:34 -07:00
Ryan Berliner
27261bd495 add back focus box shadow on btn link 2022-05-20 11:19:17 -07:00
Mark Otto
eaf760e4bc
Update form-control-color sizing and styles (#36156) 2022-05-20 11:02:32 -07:00
Louis-Maxime Piton
e2e107fc72
CSS: few proposals (#36406)
* Something to try about `!important` in color-bg helper

* Better understanding border utility `.border-*-0`

* Having rounded numbers of px
2022-05-20 10:28:31 -07:00
Justin Kruit
bb4f9d74fb
Offcanvas not showing with .showing (#36353)
The transform of .showing was being overridden by .offcanvas.offcanvas-start, while .show wasn't. This resulted in an illusion of the offcanvas waiting for the backdrop, reported in #36347. Moving the show classes below the position classes fixes this problem.
2022-05-14 21:36:01 +03:00
Mark Otto
f7e8ca91e0 Prepare v5.2.0-beta1 2022-05-13 19:44:01 +03:00
XhmikosR
6c10d60711 tooltip: ignore $tooltip-margin warning for core 2022-05-13 08:38:24 -07:00
GeoSot
b167420bdf
Revert backdrop utilization, handling clicks over modal (#36324)
* refactor(Modal.js): stop using backdrop class to handle clicks over modal

* Revert #35554 and backdrop callback usage
  Explanation: In order to bypass `.modal`, was applied a css rule `pointer-events:none` which caused the side effect, and user couldn't scroll "long content modals"

* Update .bundlewatch.config.json

Co-authored-by: Mark Otto <markd.otto@gmail.com>
2022-05-12 21:20:04 -07:00
Mark Otto
619a65c55a Remove leftover abbr styles in Reboot for tooltips
/cc @GeoSot
2022-05-08 20:01:25 -07:00
amirhossein-karimi
f82b2ba20d
Fix color-adjust with autoprefixer 10.4.6 (#36258)
Co-authored-by: Mark Otto <markd.otto@gmail.com>
2022-05-06 19:36:04 -07:00
Mark Otto
bca99232b8
Iterate on border utilities (#36239)
* Remove `--bs-border-opacity: 1` from `.border-*` utilities

We set `--bs-border-opacity: 1` globally at the `:root` level, so redeclaring it on every `.border-*` utility doesn't make much sense. I think we can drop this.

* Remove global border-opacity var, restore on .border-color classes, move .border-color utils down the list to fix some specificity issues

* Add some demos of border utils to the docs
2022-05-05 21:32:02 -07:00
Julien Déramond
5d9500bdfd
Handle disabled focused tabs with tab JavaScript plugin (#36169)
* Handle disabled tabs

* Fix after feedback

* Update js/src/tab.js

Co-authored-by: GeoSot <geo.sotis@gmail.com>

* Update js/src/tab.js

Co-authored-by: GeoSot <geo.sotis@gmail.com>

* Commit suggestions via GitHub broke the thing

* Add some unit tests

* Remove temp doc modification

* Add tests for left arrow

* Add disabled tabs in JavaScript Behavior section

* Compact 4 tests to 2 tests

* Compact 4 tests to 2 tests

* Add 'disabled' attribute for all buttons

* Change the disabled pane position only for the vertical version

* Change ids for the confusing first example in JavaScript behavior

* Use disabled attribute instead of the class for buttons in tabs

Co-authored-by: GeoSot <geo.sotis@gmail.com>
2022-05-05 19:26:15 -07:00
louismaxime.piton
cca801683d Fix proposal 2022-05-05 19:15:04 -07:00
Mark Otto
8cd3c3e3bc Add new text-bg-color utilities 2022-04-30 12:55:27 -07:00
Mark Otto
7745730e41
Revert border-color change (#36238)
* Revert `border-color` change

* Add new border-color-translucent for when we want optional alpha-transparency in our border-color

Apply to drodpowns, modals, offcanvas, popovers, and toasts

* bundlewatch
2022-04-29 13:59:41 -07:00
Mark Otto
544cf8df48 Add input-disabled-color Sass variable 2022-04-28 23:26:38 -07:00
Julien Déramond
54e0af0303 Clean up last $variable-prefix usages 2022-04-28 21:56:46 -07:00
Metadavid
9ccee925fb Update _breakpoints.scss 2022-04-20 11:24:43 -07:00
Mark Otto
195440f2fb
v5.2.0 design refresh, plus responsive offcanvas classes (#35736)
* Add responsive offcanvas classes

- Updates navbar-expand classes to de-dupe some styles—these shouldn't interfere now.
- Adds some JS to the offcanvas component to help with responsiveness

Co-Authored-By: GeoSot <geo.sotis@gmail.com>

* Redesign homepage, docs, and examples

Homepage:

- New Bootstrap purple navbar
- Redesigned masthead
- Rewrote and redesigned homepage content
- Replace Copy text with icons like Bootstrap Icons site across all ClipboardJS instances
- Fixed padding issues in site footer
- Match homepage button styles to examples page, use gap instead of tons of responsive margin utils

Docs:

- New navbar, no more subnav. Migrated search and version picker into the main navbar and refreshed the design of it all, including the responsive toggles.
- New sidebar navigation is always expanded, and now features Bootstrap Icons alongside section headings
- Sidebar navigation autoscrolls to active link for better usability
- Subnav and navbar padding issues ironed out
- Enhanced the version picker in anticipation of v5.2: we can now link right to the same page in the previous version.
- Redesign callouts to add more color to our pages
- Collapse table of contents on mobile
- Cleanup and redesign button styles with CSS variables
- Update design for subnav version dropdown
- Update highlight and example to be full-width until md
- Improve the Added In badges
- Turn the ToC into a well on mobile
- Redesign code snippets to better house two action buttons

Examples:

- Redesign Examples page layout
- Add new example for responsive offcanvases in navbars

* Convert offcanvas to CSS vars

* Feat: add resize handler to Offcanvas.js.

If we could use as default the `.offcanvas` class without modifiers, we then, could add a simplified selector
The selector itself, ignores the .offcanvas class as it doesn't have any responsive behavior
The `aria-modal` addon is to protect us, selection backdrop elements

* Separate examples code, Add some selectors, fix stackblitz btn

Co-authored-by: GeoSot <geo.sotis@gmail.com>
2022-04-17 22:17:50 -07:00
louismaxime.piton
fa0adc979d Minor fixes 2022-04-16 10:06:13 -07:00
Ryan Buckley
74be17edef Add black to colors map 2022-04-12 20:49:36 -07:00
Julien Déramond
7ff974b4ce
Fix space between popover's arrow and triggering element (#35976)
* Fix margin between popover arrow and triggering element

* Oups-use .25 increment for bundlewatch

Co-authored-by: Mark Otto <markd.otto@gmail.com>
2022-04-12 18:53:17 -07:00
louismaxime.piton
3984ebb407 Fix proposal 2022-04-12 18:36:50 -07:00
louismaxime.piton
36e75f6355 Changing the CSS var management 2022-04-12 18:25:04 -07:00
GeoSot
8aaeb3cb6b
Remove tooltip and popover styling as it is handled by Popper (#34627)
* Remove not needed css form tooltip & popover as it is made by popper
Remove tooltip margin variable, as popper needs margin to be zero

* Remove popover left/top initializers as they are handled by popper

* nullify `margin` variable and add deprecation message

* Document change in migration guide

* Update _variables.scss

Co-authored-by: Mark Otto <markdotto@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2022-04-12 18:16:18 -07:00
Julien Déramond
a58d894a5b Improve use of CSS vars in Toasts 2022-04-11 15:36:10 -07:00
Julien Déramond
10f2830805
Add CSS vars for accordions (#36148)
* Add CSS vars for accordions

* Fix Bundlewatch
2022-04-11 15:33:18 -07:00
XhmikosR
7648848e04
Update devDependencies (#36120)
* Update devDependencies

* @babel/core                ^7.17.8  →  ^7.17.9
* @popperjs/core             ^2.11.4  →  ^2.11.5
* clean-css-cli               ^5.5.2  →   ^5.6.0
* eslint-plugin-import       ^2.25.4  →  ^2.26.0
* find-unused-sass-variables  ^4.0.3  →   ^4.0.4
* karma-rollup-preprocessor   ^7.0.8  →   ^7.0.7
* sass                      ^1.49.11  →  ^1.50.0
* stylelint                   14.2.0  →  ^14.6.1

* Fix currentcolor case
2022-04-08 09:17:00 +03:00
Mark Otto
dab026fc2b Revert border-color utilities to use the CSS property instead of the variable 2022-04-07 09:37:04 -07:00
louismaxime.piton
238afd94b3 New CSS var 2022-04-06 13:27:56 -07:00
Mark Otto
0323fe99d2
Fix for missing CSS variables on .navbar-nav (#36105)
* Fix for missing CSS variables on .navbar-nav

* Document new CSS vars on .navbar-nav
2022-04-06 13:08:07 -07:00
Neeraj Kumar Das
a7153567e1
Bring back webkit calendar picker indicator for datalists (#35406)
* Bring back webkit calendar picker indicator for datalists

* Replace webkit datalist indicator with Bootstrap Icons

* Use default datalist icons on date or time inputs in Chrome
Remove the dropdown arrow from text type inputs

* Bundlewatch

Co-authored-by: Mark Otto <markdotto@gmail.com>
2022-04-06 10:37:54 -07:00
Louis-Maxime Piton
0ceaad3ab4
Use new CSS vars (#36098)
* Proposal to use new CSS var when it could be used.

* Bundlewatch

Co-authored-by: Mark Otto <markdotto@gmail.com>
2022-04-04 13:51:21 -07:00
louismaxime.piton
f789c2cc92 Adding CSS var to list-group-item-action 2022-04-04 10:37:42 -07:00
louismaxime.piton
00d028e646 Adding @include everytime it's not the case 2022-03-31 14:41:02 -07:00
Julien Déramond
53fe10716a Reuse all breadcrumb CSS vars available 2022-03-31 14:16:36 -07:00
Julien Déramond
d0714817f8 Fix duplicate border radius CSS var definition 2022-03-31 14:12:14 -07:00
Mark Otto
e342142b61
Train PR: CSS variables for accordion, cards, navs, and modals (#36071)
* Convert accordion to CSS vars

* Update accordion.md

* Convert navs to CSS variables

* Split up CSS vars

* bundlewatch

* fix vars

* Convert cards to CSS vars

* Convert modals to CSS variables

* Bundlewatch

Co-authored-by: Geremia Taglialatela <tagliala.dev@gmail.com>
2022-03-28 15:05:37 -07:00
Julien Déramond
7f35bc5b65
Define Pagination font size CSS var (#35917)
Co-authored-by: Mark Otto <markd.otto@gmail.com>
2022-03-24 21:14:42 -07:00
Mark Otto
0eb808015f
Convert list group to CSS variables (#35862)
* Convert list-group to CSS vars

* bundlewatch
2022-03-22 10:02:12 -07:00
Mark Otto
9e73b6a13c
v5.2.0 migration updates (#36038) 2022-03-19 11:58:22 -07:00
Mark Otto
88bd287b27
Convert progress bars to CSS variables (#35962)
* Convert progress bars to CSS variables

* bundlewatch
2022-03-18 09:02:03 -07:00
Mark Otto
a4841afa26
Convert toasts to CSS variables (#35961)
* Convert toasts to CSS variables

* bundlewatch
2022-03-17 14:48:36 -07:00
Mark Otto
71582eabff
Convert spinners to CSS variables (#35960)
* Convert spinners to CSS variables

* bundlewatch
2022-03-17 13:49:57 -07:00
Mark Otto
8182fd9430 Revert #35759, fixes #35869 2022-03-17 13:39:17 -07:00
Mark Otto
11751c613f Fixes #36015: Fix pagination link border-radius if statement 2022-03-17 13:39:17 -07:00
Mark Otto
91f6a01c69 Fixes #36016: Update .dropdown-item padding 2022-03-17 13:39:17 -07:00
Mark Otto
acf6ea74a7
Add additional root variables, rename $variable-prefix to $prefix (#35981)
* Add additional root variables, rename $variable-prefix to $prefix

- Adds new root CSS variables for border-radius, border-width, border-color, and border-style
- Adds new root CSS variables for heading-color, link-colors, code color, and highlight color
- Replaces most instances of Sass variables (for border-radius, border-color, border-style, and border-width) for CSS variables inside _variables.scss
- Updates $mark-padding to be an even pixel number
- Renames $variable-prefix to $prefix throughout

* Bundlewatch
2022-03-13 10:13:09 -07:00
Mark Otto
e567d511d4 Convert breadcrumb to CSS variables 2022-03-11 12:59:55 -08:00
A Web Artisan
ce655ee6f2
Allow to set active and disabled class also to .page-link (#35804)
Sometimes we can set `.active` class only to link tag and not parent.
Since active status style is applied only to `.page-link` and not `.page-item`, would also make more sense to just add the active class to `.page-link` itself.

The other way to set `.active` class to `.page-item` still remain, so there is not BC.

Allow to set also `.disabled` class to `.page-link`

Co-authored-by: Gaël Poupard <ffoodd@users.noreply.github.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
2022-03-11 21:25:41 +02:00
Mark Otto
58ac9a9a5c Set opacity on dropdown-divider for now 2022-03-11 09:46:03 -08:00
Mark Otto
e72a090aee Updates -color to use rgba() 2022-03-11 09:15:33 -08:00
Mark Otto
c73480c636 Adjust border-radius values and add some new utilities
- Updates global border-radius values for a more modern appearance
- New .fw-semibold
- New .rounded-4 and .rounded-5
2022-03-11 09:10:37 -08:00
Mark Otto
63145c8bc6 Fix some instances of lazy Sass math when multiplying new CSS var based border-width 2022-03-11 09:04:13 -08:00
XhmikosR
d21a51a2ea
Ignore warning for .navbar-light deprecation (#35995) 2022-03-10 20:32:48 +02:00
Mark Otto
2e75ec3c41 Convert popovers to CSS variables 2022-03-08 14:53:53 -08:00
Mark Otto
91312486b2 Deprecate the tooltip-arrow-bg color since we're using CSS variables to set tooltip colors 2022-03-08 14:53:53 -08:00
Mark Otto
a68e1af2d5 Document new CSS vars in tooltip docs 2022-03-08 14:53:53 -08:00
Mark Otto
fdcbbe3d92 Convert tooltips to CSS vars 2022-03-08 14:53:53 -08:00
louismaxime.piton
6c40476af9 Fix dropdowns 2022-03-08 14:37:44 -08:00
Julien Déramond
2d11c1c28a Add missing root border opacity CSS var 2022-03-07 16:24:53 -08:00
cccabinet
a9b3445060 fix:border-width 2022-03-02 15:19:21 -08:00