Gaël Poupard
9488978fb5
feat(RTL): implement RTL
...
Using RTLCSS directives, renaming things to use logical names and following best practices.
2020-12-04 07:52:03 +02:00
XhmikosR
dd992c7226
Add tests
2020-11-30 12:07:51 +02:00
XhmikosR
51a208f119
Switch to Jasmine's toBeInstanceOf
matcher
2020-11-29 20:58:26 +02:00
Johann-S
9f6b342dc7
create a base component
2020-11-29 20:58:26 +02:00
Rohit Sharma
c348ad4a94
Ability to add custom class in tooltip/popover ( #32217 )
...
Porting of #31834 to main.
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-25 09:16:22 +02:00
XhmikosR
f4457bca02
Be consistent with Popper's name. ( #32224 )
...
The npm package is named "popper.js" but the project is named "Popper", so use the latter consistently.
2020-11-21 16:22:08 +02:00
Rohit Sharma
358c36d4b5
Add missing tags in unit tests ( #32221 )
2020-11-20 20:10:15 +02:00
Rohit Sharma
0839cbf04d
Don't hide modal when keyboard is set to false in modal's configuration ( #32179 )
...
* Don't hide modal when config.keyboard is false
* Update unit test
- Modal should not be closed when pressing esc key if keyboard = false
and backdrop is 'static'
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-20 15:36:24 +02:00
Rohit Sharma
2630b05eb3
Make the attribute methods bs specific ( #32173 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-20 11:13:13 +02:00
XhmikosR
2e758f64cf
Switch to Number properties
2020-11-14 15:54:50 +02:00
XhmikosR
4f8b243ac1
Fix .close
instances ( #32152 )
2020-11-14 08:16:30 +02:00
Rohit Sharma
e530118117
Get only bs prefixed data attributes
2020-11-14 07:09:15 +02:00
Rohit Sharma
418f17ee2b
Add bs
in data attributes
...
- Add `bs` in data APIs everywhere
- Update unit tests
2020-11-14 07:09:15 +02:00
XhmikosR
c9f8fa45fb
tests: tweak Jasmine usage ( #32046 )
...
* jasmine/expect-matcher
* jasmine/prefer-jasmine-matcher
Found with `eslint-plugin-jasmine`
2020-11-02 16:13:24 +02:00
XhmikosR
e2697b0573
tests: fix sanitizer test. ( #32045 )
...
The test template does not include a `script` tag so the test always returned true.
2020-11-02 14:49:56 +02:00
XhmikosR
71010cb1e9
tests: switch to using toContain()
to check for substring presence ( #32043 )
2020-11-02 14:42:40 +02:00
Sascha
c21506d499
Fix TypeError when Bootstrap is included in head
( #32024 )
...
* extend jquery after domContentLoaded event is fired
* add unittest for util onDOMContentLoaded
* wait for trigger jquery event after domContentLoaded
* remove domcontentready from eventHandler
* move istanbul ignore statements to correct line
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-01 15:32:36 +02:00
Mitchell Bryson
3a5f9f5cf0
Check for data-interval on the first slide of carousel ( #31818 )
...
* check for data-interval on the first slide of carousel
* add updateInterval method for elements of a carousel
* add test for carousel interval being set during cycle
* update activeElement as soon as slide has finished (before transition end)
* only updateInterval before using it
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-01 14:36:50 +02:00
XhmikosR
b63066d630
toast.spec.js: fix typo ( #32026 )
2020-10-31 09:25:33 +02:00
XhmikosR
0c1651ee9d
Remove Manipulator.toggleClass
( #31842 )
...
It's only used in one place so it makes more sense to remove it for the time being.
2020-10-05 18:07:49 +03:00
Hiws
43b4252a34
fix tooltip hide method when already hidden ( #31115 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-09-24 14:55:38 +03:00
Rohit Sharma
f6348f6c89
Clear timeout before showing the toast ( #31155 )
...
* clear timeout before showing the toast
* Add unit test
* Remove the check for timeout
* Check for clearTimeout to have been called
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-07-11 11:51:04 -07:00
Shohei Yoshida
fb4efb49ea
Prevent overflowing static backdrop modal animation ( #30326 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-06-25 11:35:53 +03:00
Patrick H. Lauke
edbcc401c2
Change whitelist to allowlist ( #31066 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
2020-06-19 11:31:37 +03:00
Tanguy Krotoff
d80a9fc553
Fix tooltip when hovering a children element (delegateTarget) ( #30928 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-06-18 10:02:44 +03:00
Johann-S
088c727a31
data: reword storage key in dom
2020-06-17 15:45:36 +02:00
Martijn Cuppens
1a0a0858ef
Remove checkbox/radio toggle from button plugin in favor of a CSS only solution
2020-06-15 19:04:19 -07:00
Rohit Sharma
e140ff92ed
Remove .nav-item from .nav-link to make it consistent
...
- Closes #28423
2020-06-09 07:48:58 +03:00
Rohit Sharma
5faf41eb48
Add role="dialog" in modals via JavaScript ( #30936 )
2020-06-04 10:35:09 +03:00
Dominik Kremer
d59de33fc0
Add a test about the scrollbar issue on non-integer width
2020-05-12 07:51:09 +03:00
XhmikosR
94109cabf4
Add missing closing div
tags ( #30775 )
...
Missed those in 967e607
2020-05-11 16:54:56 +03:00
XhmikosR
967e6071ba
tests: streamline HTML end tags ( #30648 )
2020-05-06 09:20:08 +03:00
Johann-S
650a7a7b76
add unit tests to ensure our plugins works in jquery
2020-05-06 07:55:48 +02:00
XhmikosR
37f2c04c5f
Clean up lint rules ( #30721 )
...
* Remove unneeded rule suppression
* Format tests/unit/.eslintrc.json
* build/.eslintrc.json: add strict for consistency
2020-05-04 19:32:09 +03:00
Tanguy Krotoff
d2ed920b15
Remove caret element ( #30633 )
2020-04-24 21:53:31 +02:00
Tanguy Krotoff
7787f642b9
Fix crash when pressing ArrowUp the first time
2020-04-17 18:22:15 +03:00
Tanguy Krotoff
dcd99aa7d1
Replace event.which with event.key and event.button
2020-04-17 18:22:15 +03:00
ysds
dfa017adc3
Always modal scroll top to 0
2020-04-01 10:05:43 +03:00
XhmikosR
e1f5d819c7
Remove MSPointerEvent
and ms-touch-action
in tests ( #30463 )
2020-03-29 09:59:54 +03:00
XhmikosR
ed94976ea8
Use textContent
instead of innerText
. ( #30462 )
...
It's supported by all of our supported browsers.
2020-03-29 09:53:57 +03:00
Laussel Loïc
7ce29d75f3
v5 tabs - accessibility issue when using ul/li semantic
...
Add aria-role presentation on li element when ul element has role tablist and remove dropdown from visual tests as they've been removed from doc
2020-03-28 09:51:24 +02:00
Johann-S
26d86fce2a
fix: remove make array util function ( #30430 )
2020-03-25 16:35:02 +02:00
Martijn Cuppens
2e150e722a
Use next dropdown menu instead of first of the parent
2020-03-23 15:35:07 +01:00
XhmikosR
018a94c9c1
Remove Internet Explorer leftovers
2020-03-18 20:59:27 +02:00
Johann-S
aff115219e
fix: ensure totype
always returns stringified null/undefined when null/undefined is passed ( #30383 )
2020-03-18 13:10:55 +02:00
Martijn Cuppens
7d8c7c4ba8
prev()
function fails when non-element nodes are present (#30117 )
...
The `prev()` function doesn't take nodes other than elements into account. Also we could simplify things a lot using the `previousElementSibling` property. This property isn't fully supported in IE, it only works for elements, but since the `element` variable is an element, we can safely use it here.
I've also added an additional test.
I don't think we had this issue in v4, since we relied on jQuery back then.
Ref. https://developer.mozilla.org/en-US/docs/Web/API/NonDocumentTypeChildNode/nextElementSibling
2020-03-09 17:21:04 +02:00
yonikohen
7a60dcf9b0
Corrected grammatical error in test descriptions ( #30150 )
...
"without instantiate it" should be "without instantiating it"
2020-02-10 09:35:13 +02:00
Martijn Cuppens
ef6c13c534
tests: Remove button href
s ( #30119 )
2020-02-01 20:39:18 +02:00
Giovanni Mendoza
954a0b1e6a
Close modal with keyboard=true & backdrop=static ( #29986 )
...
* Close modal with keyboard=true & backdrop=static
2020-01-10 11:06:12 +02:00
Steffen Roßkamp
c62efc3ef6
Update normalizeDataKey to match the spec ( #29609 )
2019-10-31 07:58:09 +02:00