XhmikosR
0c3dfe104b
Remove a few unneeded variables
2022-01-29 13:25:30 +02:00
Ryan Berliner
14c7dc1e88
Fix: isVisible function behavior in case of a <details> element, on chrome 97 ( #35682 )
2022-01-13 10:55:05 +02:00
Patrick H. Lauke
0d054bb0f1
Remove explicit use of aria-hidden for offcanvas when closed ( #35589 )
...
Remove explicit use of aria-hidden & visibility for offcanvas when closed, handling it with css
Co-authored-by: GeoSot <geo.sotis@gmail.com>
Co-authored-by: Gaël Poupard <ffoodd@users.noreply.github.com>
2022-01-05 19:20:15 +02:00
GeoSot
0d4213bde3
Carousel: move repeated code to a method
2021-12-21 17:37:24 +02:00
GeoSot
b8ee68cfa0
Carousel: remove always true visibilityState check
...
According to https://developer.mozilla.org/en-US/docs/Web/API/Document/visibilityState `visibilityState` is always a string, so the check was always true
2021-12-21 17:37:24 +02:00
GeoSot
ff4bf4a458
Carousel: move carousel default interval to _getConfig() and simplify it
2021-12-21 17:37:24 +02:00
GeoSot
6f79721c82
Carousel: return early and drop a loop.
...
We can achieve the same thing by querying the specific selector directly
2021-12-21 17:37:24 +02:00
GeoSot
d60f146507
Carousel: add a helper to get the active element
2021-12-21 17:37:24 +02:00
GeoSot
65cf77ae3e
Popover/Tooltip: Fix vertical alignment on arrow of tip elements ( #35527 )
...
Regression of #32692
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-21 17:19:29 +02:00
Phil E. Taylor
c2db7108c2
Fix typo in comment ( #35564 )
...
s/moddal/modal
2021-12-18 07:58:31 +02:00
GeoSot
e0960b08e0
Tooltip: remove extraneous call to _getConfig() ( #35540 )
...
BaseClass already initializes the config
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-15 10:47:32 +02:00
GeoSot
d40fae456e
Popover.js: Accept empty content through data-bs-content ( #35514 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-15 10:41:31 +02:00
XhmikosR
cd04fe015f
Scrollspy: minor refactoring ( #35512 )
...
* reorder variables
* join lines
* use `filter(Boolean)` since it's clearer
* use `for...of`
2021-12-15 09:38:06 +02:00
GeoSot
886b940796
Extract Component config functionality to a separate class ( #33872 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-10 18:18:18 +02:00
XhmikosR
63d38b1974
Tab: minor refactoring ( #35511 )
...
* remove unneeded parentheses
* move variable
2021-12-10 07:51:57 +02:00
XhmikosR
871c8bdd3f
util/index.js: minor refactoring ( #35510 )
...
* rename variables
* remove an unused variable
* be more explicit
* reuse variable
2021-12-10 07:48:04 +02:00
XhmikosR
eaa801c899
Toast: join multiple classList calls ( #35507 )
2021-12-10 07:42:08 +02:00
XhmikosR
94d4fa3b10
Fix tests fixture type ( #35501 )
...
Previously we were adding an Array instead of a String
2021-12-09 16:01:29 +02:00
GeoSot
28a5a72ed5
Scrollbar - remove margin/padding properties properly ( #35388 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-09 15:49:28 +02:00
GeoSot
c376cb0763
Dropdown: fix toggle focus after dropdown is hidden using the ESC button ( #35500 )
2021-12-09 15:34:17 +02:00
GeoSot
4fd5539c75
ScrollBar.js. Minor refactoring and add test ( #35492 )
2021-12-09 15:05:50 +02:00
GeoSot
328f723008
Tooltip: remove title attribute before show & add tests ( #35456 )
2021-12-07 15:51:56 +02:00
Louis-Maxime Piton
d8999dd566
Tests: Minor fixes ( #35455 )
2021-12-02 12:01:11 +02:00
GeoSot
385fea49e8
Tooltip/Popover: add underscore prefix to protected functions
2021-12-01 18:00:36 +02:00
GeoSot
bd79d69a73
Tooltip: a simple code-block position change
2021-12-01 18:00:36 +02:00
GeoSot
1f7b83203d
Tooltip: simplify popper check
2021-12-01 18:00:36 +02:00
GeoSot
9b9372e8dd
Tooltip: refactor _hoverState to Boolean to achieve better control
2021-12-01 18:00:36 +02:00
GeoSot
8eacbaa08b
Tooltip: merge timeout functionality
2021-12-01 18:00:36 +02:00
GeoSot
c69ccba08c
Tooltip: Change _enter & _leave to work without arguments
2021-12-01 18:00:36 +02:00
GeoSot
a20e4203fe
Tooltip: Remove redundant config.delay check
...
`config.delay` is always an object after initialization
2021-12-01 18:00:36 +02:00
GeoSot
724663b3cd
Tooltip: Remove Data.set usage for dynamically created tip
...
This is not used any further, so we were just setting it.
2021-12-01 18:00:36 +02:00
GeoSot
3baeb0a5c1
Tooltip: merge isAnimated checks
2021-12-01 18:00:36 +02:00
GeoSot
53c77c0203
Tooltip: refactor jQueryInterface
2021-12-01 18:00:36 +02:00
GeoSot
dd07c1ff9e
Dropdown: clearMenus is always an event callback
2021-12-01 17:10:39 +02:00
GeoSot
f71640f048
Dropdown: Clean more
2021-12-01 17:10:39 +02:00
GeoSot
21e5618ba7
Dropdown: rename vars
2021-12-01 17:10:39 +02:00
GeoSot
0686fa00f0
Dropdown: Remove redundant Space check
2021-12-01 17:10:39 +02:00
GeoSot
a14a552d83
Dropdown: Deduplicate complex check
2021-12-01 17:10:39 +02:00
GeoSot
bff95d55af
Dropdown: Remove redundant check since the show method already does it
2021-12-01 17:10:39 +02:00
GeoSot
2d32802f53
Dropdown: Change constant to the way we use it
2021-12-01 17:10:39 +02:00
GeoSot
fb5921dec4
Dropdown: Merge display='static' & isNavbar functionality activating static popper with no styles attached
2021-12-01 17:10:39 +02:00
GeoSot
137b324930
Dropdown: Remove static method used once
2021-12-01 17:10:39 +02:00
GeoSot
8b308b76f0
Dropdown tests: Use a function to improve readability ( #35448 )
2021-12-01 16:49:02 +02:00
GeoSot
cab62af2e6
Fix popover arrow & tooltip template after the setContent addition ( #35441 )
2021-12-01 15:10:10 +02:00
GeoSot
44a6cd724c
Tooltip: remove leftover method ( #35440 )
...
Remove a leftover after #32692
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-01 14:53:56 +02:00
XhmikosR
e5d8256e42
tests/unit/util/scrollbar.spec.js: rename function
...
`parseInt` is a global one.
2021-12-01 14:30:49 +02:00
XhmikosR
11ce6c2dcd
tests: fix a few typos
2021-12-01 14:30:49 +02:00
XhmikosR
f8f9dc3b5c
tests: remove extra spaces, unneeded arrays and add missing newlines
2021-12-01 14:30:49 +02:00
XhmikosR
eb54e1a1ce
tests: tweak Jasmine's matchers usage
...
Use:
* toBeNull
* toEqual
* toBeTrue
* toBeFalse
* toHaveSize
* toHaveClass
2021-12-01 14:30:49 +02:00
XhmikosR
5739bf7637
tests/browsers.js: remove unneeded export
2021-12-01 14:30:49 +02:00
