0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-11-29 11:24:18 +01:00
Commit Graph

175 Commits

Author SHA1 Message Date
Mark Otto
dabc081f6f Fix selector for dark mode navbar toggler SVG change 2022-12-29 12:46:15 -08:00
Mark Otto
fc3f4b67d6
Add dark mode support (#35857)
* Add dark mode to docs

* Minor fix: missing space indentation

* Minor fix: revert utilities/z-index added-in modification

* Remove prev: and next: from doc because extracted to another PR

* Use .bg-body-tertiary in all Utilities > Overflow examples

* fix example

* Fix up spacing examples

* Update box-shadow Sass variables and utilities to auto-adjust to color modes

* Remove unused docs class

* Refactor form styles to use CSS variable for background images on .form-check and .form-switch

* Fix docs selector

* Rename shortcut for clarity

* Heading consistency

* Reintroduce missing 4th grid item in Utilities > Spacing example

* Fix bundlewatch

* .bd-callout* rendering is OK so removing comments in the code

* Update scss/_utilities.scss

Co-authored-by: Julien Déramond <julien.deramond@orange.com>

* Fix gutters example styling

* Fix text colors on background utils docs

* redesign and fix up position marker example, which doesn't show nicely in darkmode but at least isn't broken

* fix some color utils examples

* Deprecate mixin notice

* Deprecate notice for list-group-item-variant() mixin

* Revamp new link CSS vars

* Use map-keys in some each Sass files

* Remove list-group-item-variant mixin ref in sass loop desc

* Display CSS vars scoped to our built-in dark mode

* Revert previous commit

* Fix list group variant link

* Fix typo

* Remove imports of alert/list-group mixins in scss/_mixins.scss

* Small formatting + comments removal in scss/_content.scss

* Fix alert links colors

* fix dropdown border-radius mixin

* fix link color and underline again, this time using CSS var override for color var and fallback value for the underline

* fix colors on docs navbar for dark mode

* remove two changes

* missing ref

* another link underline fix, just use sass vars for link decoration for now

* missing color bg docs, plus move dropdown override to scss

* more changes from review

* fix some examples, drop unused docs navbar styles, update docs navbar color mode to use mixin

* Few fixes around type

- Restored CSS variable for color on headings, this time with a fallback value
- In conjunction, restored and wrapped the default CSS var with a null value check
- Split headings and paragraphs docs in Reboot, elaborated on them

* Restyle custom details > summary element in docs

* Rewrite some migration docs

* fix form checks

* Fix up some navbar styling, tweak docs callout

* Fix select images, mostly for validation styling

* Clean up some migration notes, document some new form control CSS vars, mention new variables-dark in sass docs

* Update site/content/docs/5.2/components/scrollspy.md

Co-authored-by: Julien Déramond <julien.deramond@orange.com>

* Apply suggestions from code review

Co-authored-by: Julien Déramond <julien.deramond@orange.com>

* mention form control css vars in migration guide

* Tweak grid and flex docs background examples

* clarify some docs

* fix some more things

Co-authored-by: Julien Déramond <juderamond@gmail.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
2022-11-28 22:30:26 -08:00
Julien Déramond
a138bc3fb9 More consistency for CSS/Sass vars doc for components with dark variants 2022-08-31 18:15:11 -07:00
Julien Déramond
2bf383c596 Add missing CSS vars for .navbar-nav 2022-07-07 14:32:35 -07:00
Mark Otto
195440f2fb
v5.2.0 design refresh, plus responsive offcanvas classes (#35736)
* Add responsive offcanvas classes

- Updates navbar-expand classes to de-dupe some styles—these shouldn't interfere now.
- Adds some JS to the offcanvas component to help with responsiveness

Co-Authored-By: GeoSot <geo.sotis@gmail.com>

* Redesign homepage, docs, and examples

Homepage:

- New Bootstrap purple navbar
- Redesigned masthead
- Rewrote and redesigned homepage content
- Replace Copy text with icons like Bootstrap Icons site across all ClipboardJS instances
- Fixed padding issues in site footer
- Match homepage button styles to examples page, use gap instead of tons of responsive margin utils

Docs:

- New navbar, no more subnav. Migrated search and version picker into the main navbar and refreshed the design of it all, including the responsive toggles.
- New sidebar navigation is always expanded, and now features Bootstrap Icons alongside section headings
- Sidebar navigation autoscrolls to active link for better usability
- Subnav and navbar padding issues ironed out
- Enhanced the version picker in anticipation of v5.2: we can now link right to the same page in the previous version.
- Redesign callouts to add more color to our pages
- Collapse table of contents on mobile
- Cleanup and redesign button styles with CSS variables
- Update design for subnav version dropdown
- Update highlight and example to be full-width until md
- Improve the Added In badges
- Turn the ToC into a well on mobile
- Redesign code snippets to better house two action buttons

Examples:

- Redesign Examples page layout
- Add new example for responsive offcanvases in navbars

* Convert offcanvas to CSS vars

* Feat: add resize handler to Offcanvas.js.

If we could use as default the `.offcanvas` class without modifiers, we then, could add a simplified selector
The selector itself, ignores the .offcanvas class as it doesn't have any responsive behavior
The `aria-modal` addon is to protect us, selection backdrop elements

* Separate examples code, Add some selectors, fix stackblitz btn

Co-authored-by: GeoSot <geo.sotis@gmail.com>
2022-04-17 22:17:50 -07:00
Mark Otto
0323fe99d2
Fix for missing CSS variables on .navbar-nav (#36105)
* Fix for missing CSS variables on .navbar-nav

* Document new CSS vars on .navbar-nav
2022-04-06 13:08:07 -07:00
Mark Otto
acf6ea74a7
Add additional root variables, rename $variable-prefix to $prefix (#35981)
* Add additional root variables, rename $variable-prefix to $prefix

- Adds new root CSS variables for border-radius, border-width, border-color, and border-style
- Adds new root CSS variables for heading-color, link-colors, code color, and highlight color
- Replaces most instances of Sass variables (for border-radius, border-color, border-style, and border-width) for CSS variables inside _variables.scss
- Updates $mark-padding to be an even pixel number
- Renames $variable-prefix to $prefix throughout

* Bundlewatch
2022-03-13 10:13:09 -07:00
XhmikosR
d21a51a2ea
Ignore warning for .navbar-light deprecation (#35995) 2022-03-10 20:32:48 +02:00
Mark Otto
efc5914667 Replace instances of Sass vars for CSS variable versions of border-color and border-width 2022-02-28 11:40:32 -08:00
Louis-Maxime Piton
d82602063a
New CSS variable for Navbars (#35829)
* Adding a brand new CSS var

* Update scss/_variables.scss

Co-authored-by: Gaël Poupard <ffoodd@users.noreply.github.com>
2022-02-17 11:25:01 -08:00
Mark Otto
27a0f40dc8 Add deprecation notice for .navbar-light 2022-02-08 10:39:58 -08:00
Mark Otto
c9cec89764 Convert navbar to CSS variables
Co-Authored-By: Gaël Poupard <ffoodd@users.noreply.github.com>
2022-02-08 10:39:58 -08:00
Mark Otto
b21c7ccbb7
Reset z-index on .navbar-expand .offcanvas, plus prevent box-shadow issues (#35153) 2021-10-10 14:56:35 +03:00
XhmikosR
7fcc2f4d52
_navbar.scss: switch comment (#34677) 2021-08-04 17:49:34 +03:00
craftwerk
06a1ca5623 Add new offcanvas support to navbars
Co-Authored-By: craftwerk <1193597+craftwerk@users.noreply.github.com>
2021-07-17 20:33:34 -07:00
Mark Otto
4c7a3e8adf
Add Sass docs (variables, mixins, and loops) to most pages (#32747)
* WIP: Mention variables, mixins, and loops in docs

* Add Sass sections to component pages

* add sass docs for forms and content

* Update buttons.md

* Remove empty mixins sections

* Massive update to utilities and some consistency changes

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-10 19:29:59 -08:00
Gaël Poupard
91d3da1f3d
fix(navbar): ensure .navbar-collapse behaves as intended (#33022) 2021-02-09 20:54:37 +02:00
Gaël Poupard
e4b249d02b
fix(navbar): hardcoded custom property (#32930) 2021-02-03 21:42:24 +02:00
Mark Otto
0fa16a5d45
Re-add flex-grow to .navbar-collapse (#32899)
Update .navbar-collapse to drop width 100 and use flex-grow, restoring it to v4's behavior

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-27 21:27:02 +02:00
Mark Otto
40b15de723
Add .navbar-nav-scroll for vertical scrolling of navbar content (#32037)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-19 07:32:18 +02:00
Gaël Poupard
9488978fb5 feat(RTL): implement RTL
Using RTLCSS directives, renaming things to use logical names and following best practices.
2020-12-04 07:52:03 +02:00
XhmikosR
4d6dd31379 Update Stylelint rules
Enable `scss/selector-no-union-class-name`
2020-09-15 11:57:36 +03:00
Mark Otto
c9cd3e4a08
v5: Make navbar active links consistent (#30831)
* Update navbar docs to put .active class on .nav-link

Fixes #30652 in v5.

* Remove two selectors from navbar nav that are either unused, or duplicative

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-05-20 15:56:42 +03:00
Martijn Cuppens
b531bda07c Improve gradients
- Use a semitransparent gradient from light to dark which works on any background-color
- Store the gradient as a custom property (--bs-gradient)
- Remove `.bg-gradient-*` variants in favour of `.bg-gradient` which works even when `$enable-gradients` are enabled
- Add gradients to navbar, active page links and badges when gradients are enabled
2020-05-15 15:03:12 +03:00
Martijn Cuppens
6dfe8e02d7
Fix text decorations (#30492)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-03-31 21:42:38 +03:00
Martijn Cuppens
d9e83671ae Drop IE support from Sass 2020-03-18 20:59:27 +02:00
Cinnead
770d95ed02 Add transition and add box-shadow for navbar-toggler (#30038)
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-01-28 13:28:44 +01:00
Martijn Cuppens
6904afe36b Inherit flex-wrap to decrease generated css (#29951) 2020-01-07 22:32:46 +02:00
Martijn Cuppens
74e45ebc07 Navbar optimizations (#29864)
- Remove redundant `display: inline-block` from flex children
- Remove `line-height: inherit;` which is the default value of `line-height`
- Use flex shorthand
- Improve background shorthand
- Fix removed brand margin caused by requiring containers in navbars
2019-12-25 18:38:41 +02:00
Matias Puhakka
639c405c65 Remove redundant "Navbar divider" from "Contents" (#29601) 2019-10-28 15:19:03 +01:00
Mark Otto
9c7bc1a111
v5: Simplify navbars by requiring containers (#29339)
* v5: Simplify navbars by requiring containers

* Update migration docs for navbar
2019-10-27 20:26:52 -07:00
Mark Otto
d94148bf50
Responsive containers (follow-up to #29095) (#29118)
* Follow-up to #29095

This PR fixes the responsive containers that were added in #29095, originally stubbed out in #25631. Apologies to @browner12 for getting that wrong.

Fixes #25631.

* update navbar as well because we cannot reset all containers uniformly

* Update navbars example to include container-xl example to ensure containers match

* rewrite responsive containers docs, add table of max-widths

* Update container docs
- Move table up to the intro
- Remove the container example because it's actually hella confusing
- Update and link to grid example as a demo instead
2019-08-05 12:12:16 -07:00
Mark Otto
cd4768aa81 fix broken classes 2019-07-22 10:38:28 -07:00
Mark Otto
634344c003
v4/v5: Add responsive containers (#29095)
* create responsive containers

provide more flexibility and allow the user to determine when containers switch from fluid to fixed width.

* fix the base container code

this commit fixes the non-media portion of the generated CSS. I learned about the `@extends` directive and was able to put it to good use.

I create a new temporary map that contains all the main `$container-max-widths` and join it to our 2 special cases of 'xs' and 'fluid'.  Then we loop through that and, with the appropriate infixes, extend our placeholder

* formatting for style

forgot to run my tests before the last push, i think these are better.

* finish incomplete comment

* fix the responsive containers

using the `@extend` directive I was able to clean up this code

* fix responsive containers in the navbar

mostly we just look through all of our breakpoints so we can include all of the responsive container classes in the tweaks we have to do for the navbar (redeclaring flex properties, don't double up on padding, etc)

* Simplify container extends

* Simplify navbar containers

* Rearrange, add comments, ensure everything is nested in $enable-grid-classes

* Reduce new CSS by using attribute selector

We avoid using `@extend` whenever possible, and this is more readable

* Update _grid.scss

* Update _navbar.scss

* Add docs for responsive containers, redesign the container layout page

* Add to the Grid example
2019-07-21 17:38:36 -07:00
Martijn Cuppens
f6694b7440 Use escape-svg() function (#29077)
* Use escape-svg() function

* Update theming.md
2019-07-19 18:57:12 -07:00
Mark Otto
1d4d9f8d89 Drop all hover mixins
Previously deprecated in v4.x, this clears out the now unused Sass option and removes some unused mixins. Arguably we could remove more, but I like the hover-focus mixin and we make extensive use of it across the project.
2019-05-08 20:58:07 +03:00
Martijn Cuppens
0321fbf036
Remove floats from dropdown (#28690) 2019-05-02 20:37:10 +02:00
Martijn Cuppens
51375abca5
Responsive font size implementation (#23816) 2019-02-07 23:32:05 +01:00
Martijn Cuppens
48fe2c23d3 Space fixes (#27997) 2019-01-08 06:46:29 +02:00
Martijn Cuppens
e1b990fb90 Move hand cursor for buttons to reboot 2019-01-04 11:53:32 +02:00
Andres Galante
ed3c611949 creates variables for navbar brand colors #27187 2018-09-13 17:51:14 +03:00
Andrew
abb4868626 correct spelling errors (#26837) 2018-07-09 17:59:22 -07:00
ysds
14f712601e Add basic position to dropup/right/left and dropdown-menu-right (#25400) 2018-03-12 19:44:05 +02:00
Patrick H. Lauke
1f490ec165
Consistently use :disabled rather than [disabled] selector (#25317)
Closes https://github.com/twbs/bootstrap/issues/25316
2018-01-15 20:51:01 +00:00
Andres Galante
5f3856ce29 removes hardcoded value for nav-link padding 2017-12-30 20:58:25 -08:00
patrickhlauke
e3f9c463fc Opinionated: reintroduce cursor:pointer
Explicitly re-adds the "hand" `cursor:pointer` for non-disabled `.btn`, `.close`, `.navbar-toggler` elements, as well as forcing `page-link` pagination controls to always have the "hand" cursor (even if an author uses it on, say, `<button>` elements for a dynamically updating in-page pagination).

Controversial, as everybody jumped on the bandwagon following this article https://medium.com/simple-human/buttons-shouldnt-have-a-hand-cursor-b11e99ca374b - which does have its merits of course, but there are also counter-arguments like http://kizu.ru/en/issues/cursor-pointer/

And seeing the amount of issues we've seen following the change, and the potential complexity needed to consistently address the cursor issue (see https://github.com/twbs/bootstrap/issues/24156 where i explore how the cursor needs to be based on "intent", and how that's tough to determine), I'm favouring an opinionated take here of just reintroducing the `cursor:pointer`.
2017-12-27 16:28:10 -08:00
XhmikosR
34d745540d
Minor Sass consistency changes. (#24677)
* use `background-color` instead of the shorthand
* use `outline: 0` consistently
* fix transform order
* remove quotes from `SFMono-Regular`
2017-11-06 02:23:36 +02:00
Johann-S
b9c4a5cde2 Fix dropup in bottom navbar for all the breakpoints 2017-10-04 16:22:55 +02:00
Johann-S
a9e7abd29b Fix caret position for Dropdown in a bottom navbar 2017-10-04 10:32:32 +02:00
Johann-S
b6988714a1 Fix dropup in navbar 2017-10-04 10:32:32 +02:00