0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-12 00:08:59 +01:00
Commit Graph

695 Commits

Author SHA1 Message Date
Patrick H. Lauke
6d64afe508 Replace dropdown backdrop hack with cleaner JS-only hack
* Replace backdrop with simple noop mouse listener

As discussed in https://github.com/twbs/bootstrap/pull/22422 the current
approach of injecting a backdrop (to work around iOS' broken event
delegation for the `click` event) has annoying consequences on
touch-enabled laptop/desktop devices.
Instead of a backdrop `<div>`, here we simply add extra empty/noop
mouse listeners to the immediate children of `<body>` (and remove
them when the dropdown is closed) in order to force iOS to properly
bubble a `click` resulting from a tap (essentially, method 2 from
https://www.quirksmode.org/blog/archives/2014/02/mouse_event_bub.html)
This is sufficient (except in rare cases where the user does manage to tap
on the body itself, rather than any child elements of body - which is not
very likely in an iOS phone/tablet scenario for most layouts) to get iOS to
get a grip and do the correct event bubbling/delegation, meaning the regular
"click" event will bubble back to the `<body>` when tapping outside of the dropdown,
and the dropdown will close properly (just like it already does, even without
this fix, in non-iOS touchscreen devices/browsers, like Chrome/Android and
Windows on a touch laptop).
This approach, though a bit hacky, has no impact on the DOM structure, and
has no unforeseen side effects on touch-enabled laptops/desktops. And crucially,
it works just fine in iOS.

* Remove dropdown backdrop styles

* Update doc for dropdowns and touch-enabled devices
2017-04-14 09:19:00 +01:00
Patrick H. Lauke
3275ca4b30 Reword "mobile" to "touch-enabled"
...as touch is not exclusive to "mobile" anymore nowadays. also explicitly clarifies this is a fix for iOS, and that it impacts touch laptops etc as well. lastly, renames the variable from "dropdown" to "backdrop" for clarity/consistency
2017-04-12 18:39:23 +01:00
Patrick H. Lauke
53b2c5520b Remove inappropriate role="listbox" from carousels 2017-04-11 11:12:30 +01:00
Patrick H. Lauke
18e8704221 Fix collapse.js aria-expanded behavior
* Remove aria-expanded from collapse.js target element

aria-expanded="true"/aria-expanded="false" only applies to the trigger,
not the element that is being expanded/collapsed.

* Tweak collapse.js accessibility section

...to make it clearer that the aria-expanded attribute always just goes
on the control.

* Fix collapse.js unit tests

- reword some of the text to make it clear we're checking behavior of
trigger/control
- move incorrect aria-expanded out of the <div>s and to the actual
trigger/control <a>s
- fix incorrect test assertion text output false -> true
2017-04-10 14:51:22 +01:00
Patrick H. Lauke
ba306d98bb Merge branch 'v4-dev' into v4-dev-docs-navs-js-tabpanel-fix 2017-04-09 22:09:45 +01:00
Patrick H. Lauke
50d178ece0 Remove incorrect role="tabpanel" from navs docs
`role="tabpanel"` is not appropriate as role for the overall container -
it only applies to the individual content parts of each tab
2017-04-09 21:15:05 +01:00
Patrick H. Lauke
c5db196e76 Merge branch 'v4-dev' into v4-docs-button-group-a11y-patch1 2017-04-09 13:25:47 +01:00
Mark Otto
ee5dc37ba3 drop img-fluid for w-100 2017-04-08 16:29:21 -07:00
Mark Otto
9a475730dc Docs and CSS updates for #21807 (#22336)
* tweak some copy
* fix up scrollspy docs
* remove nav styles that were added
* fix nav-based docs by requiring .nav-item on .nav-link
2017-04-08 13:58:20 -07:00
Johann-S
31a21044e0 Documentation - Add inserted event for Tooltip and Popover 2017-04-07 14:23:26 +02:00
Pierre Vanduynslager
7e64147adf Rename navbar-toggleable to navbar-expand in docs (#22309) 2017-04-02 12:44:38 -07:00
Pierre Vanduynslager
91b62941af Tabs/Scrollspy/.nav/.list-group/.active independent of markup (<nav>, .nav-item, <li> etc...) 2017-04-02 11:21:04 +02:00
Patrick H. Lauke
63cd4e96b3 Add explicit aria-label to placeholder-only inputs
While `placeholder` is nominally valid per spec
http://rawgit.com/w3c/html-api-map/master/index.html#accessible-name-and-description-calculation
it is inelegant, a fallback, and not supported in ios/safari/voiceover
and android/chrome/talkback, to name a few combinations

`aria-describedby` is also not really the right tool for providing a
name/label equivalent, so remove that from the list of possible
alternative methods / clarify how it can be used
2017-03-30 23:31:14 +01:00
Pierre Vanduynslager
48c5efa4c3 Fix JS components console error "Error: <Component> is transitioning" 2017-03-28 23:43:15 +02:00
Mark Otto
fe3acc097a Card image fixes (#22288)
* fix image stretching due to flexbox
* fix broke text-muted on dark bg
* no img-fluid needed
2017-03-27 22:52:24 -07:00
Mark Otto
1ad0496724 fix broken fieldset grid, workaround for flexbug 9 2017-03-26 13:23:49 -07:00
Sid
d2b919143c Add missing v4 docs for tooltip/popover methods (#22246)
Add missing v4 docs for tooltip/popover methods
2017-03-24 11:32:39 +01:00
Mark Otto
11ba308b2f more docs updates 2017-03-23 23:02:28 -07:00
Mark Otto
c5d10f6dee update docs 2017-03-23 23:02:28 -07:00
Pierre-Denis Vanduynslager
c1325a756e Generate correct breakpoints for navbar-toggleable-* and generate toggleable without media query to never collapse 2017-03-23 23:02:28 -07:00
Patrick Hayes
e41316cd94 Fix modal documentation (#22252)
The example code has the class `"modal fade"`, but the visible example has the class `"modal"`. `"fade"` appears to not work for modals that you do not intend to animate onto the page
2017-03-23 21:16:06 -07:00
Johann
3f247a42f2 Fix Modal documentation about _handleUpdate method + move to public scope (#21877)
Fix Modal documentation about _handleUpdate method + move to public scope
2017-03-23 22:22:09 +01:00
Pierre Vanduynslager
37f438910f Accordion behavior with JQuery interface (#21726)
Fix accordion behavior with JQuery interface
2017-03-23 21:15:41 +01:00
Gifford Nowland
7c4ed09da2 fix data-pause documentation for carousel (#21938)
fix data-pause documentation for carousel
2017-03-22 23:02:56 +01:00
Johann
c72a315740 Carousel - Add attributes from and to for Slid and Slide events (#21668)
Carousel - Add attributes from and to for Slid and Slide events
2017-03-22 22:42:13 +01:00
Mark Otto
38f89726b9 fixes #21920 2017-03-19 20:51:35 -07:00
Mark Otto
b836371525 document it 2017-03-19 19:03:29 -07:00
Mark Otto
caebfcd246 Fix justified nav styles and update nav docs for fill/justify
- Justified and fill nav variants need .nav-item classes on the anchors in addition to .nav-link
- Fix broken styles for the .nav-justified class which wasn't actually doing what we needed it to
2017-03-19 15:47:34 -07:00
Mark Otto
bfcfbb7d5c link to caniuse for context 2017-03-19 15:24:20 -07:00
Bardi Harborow
95841f7432 Change duplicate id. 2017-03-19 22:57:17 +11:00
Mark Otto
5f3473258e add header and footer to example 2017-03-18 16:49:55 -07:00
Mark Otto
ec8c251928 fixes #21584
- revert back to display block for list items to prevent unwanted behaviors
- fixes a handful of other linked issues (see main thread)
- updates docs to include more utilities for the one example
2017-03-18 16:30:12 -07:00
Mark Otto
7e07d5bf2e Merge branch 'v4-dev' of https://github.com/twbs/bootstrap into v4-dev 2017-03-07 20:44:42 -08:00
Alex Neises
c10200267b Fixed spelling error. (#22102) 2017-03-02 16:32:21 -08:00
Sam Rapaport
651243f57c Fix spelling error. 2017-03-02 14:22:01 +11:00
Bardi Harborow
e8015e3f16 Fix broken links. 2017-02-27 21:51:26 +11:00
Mark Otto
07f63324d1 add more grid layout options 2017-02-26 17:14:25 -08:00
Mark Otto
d2ddb55180 use secondary buttons instead of primary ones for a bit better example of styles 2017-02-12 17:15:16 -08:00
Matt Eason
29a8f9fc99 Change 'has no affect' to 'has no effect' 2017-02-09 16:17:32 +00:00
Mark Otto
0da20476ec Fixes #21892 2017-02-04 16:43:05 -08:00
Erin Brown
8167682deb Specify card component is necessary for accordion behavior (#21746)
- It is unclear that the use of the card component is necessary
when extending the collapse behavior to behave like an accordion.
2017-01-16 10:25:42 -08:00
Pierre-Denis Vanduynslager
1528516dd6 Add doc example with badge links (#21674) 2017-01-15 21:45:04 -08:00
Pierre-Denis Vanduynslager
1d0f527249 Add alert divider (<hr>) example in docs (#21673)
* Add alert divider (<hr />)example in docs

* <hr/> => <hr> per @vsn4ik suggestion
2017-01-15 21:33:32 -08:00
Patrick H. Lauke
b47c252ee1 Merge pull request #21671 from vanduynslagerp/fix-21665
Fix modal id in doc example (Fix #21665)
2017-01-12 13:34:40 +00:00
Patrick H. Lauke
6b48ba4e0d Remove incorrect aria-multiselectable
Closes https://github.com/twbs/bootstrap/issues/21635
2017-01-11 23:57:59 +00:00
Pierre-Denis Vanduynslager
a98fb3c83a Fix modal id in doc 2017-01-11 18:30:48 -05:00
Quy
98e55484e7 Doc updates (#21542)
* Change it's to its.

* Fix links

* Fix typos
2017-01-05 14:24:40 -08:00
Bardi Harborow
e4c0311626 Update broken links. 2017-01-05 11:17:22 +11:00
Mark Otto
f93930199e Update custom content example for list group to use utils so the layout doesn't break 2017-01-04 11:41:40 -08:00
Pierre-Denis Vanduynslager
b2121d499c Fix progress doc markup 2017-01-04 11:27:45 -08:00