Laussel Loïc
4cac833447
Implement data-dismiss="toast"
to allow user to interact itself with the component ( #27155 )
2018-11-13 08:47:32 +02:00
Johann-S
2f81ab007c
Fix toast documentation page.
2018-11-13 08:47:32 +02:00
Johann-S
16cf76ff1a
Create toast JS plugin, add unit tests.
2018-11-13 08:47:32 +02:00
Johann-S
f7a4b39767
handle detached tooltip when we try to hide a modal
2018-11-02 13:39:58 +01:00
Johann-S
cebdfb9090
fix dispose modal unit test
2018-10-30 16:59:24 +01:00
Andrew Luca
bd2851938a
test(Modal): check if modal is disposed
2018-10-30 16:28:32 +01:00
XhmikosR
02df7cd0d2
Fix util tests on IE 10 ( #27556 )
2018-10-30 15:29:04 +02:00
Martijn Cuppens
5aed968750
Prevent the background to be shown when transitioning
2018-10-30 08:57:02 +02:00
Johann-S
2868f07240
update our coverage required for branches and functions
2018-10-29 14:49:29 +01:00
Johann-S
91f8077ed5
add unit tests for our carousel
2018-10-29 14:49:29 +01:00
Johann-S
2c2d04aba5
add unit test to test tabs can be removed without throwing error
2018-10-29 14:01:03 +01:00
Johann-S
ffc8d507c7
calculate modal transition duration based on modal-dialog element
2018-10-28 23:59:17 +02:00
Andrew Luca
1f1308ba22
test(Modal): reuse _getScrollbarWidth in tests
2018-10-21 17:45:02 +02:00
Johann-S
b1dc6b324c
avoid drag img
2018-10-20 15:32:09 +03:00
patrickhlauke
8883ccb205
Set touch-action to "none"
...
Firefox currently seems extremely fickle - with `pan-y` if fires pointercancel as soon as a touch strays even a pixel or so vertically.
While `touch-action: pan-y` would be ideal (allowing users to scroll the page even when their finger started the scroll on the carousel), this prevents a swipe that isn't perfectly/only horizontal to be recognised by Firefox.
2018-10-20 15:32:09 +03:00
patrickhlauke
7b8f01d839
Use correct touch-action values
...
- my fault, my original advice of using `touch-action: pan-x` is exactly the value we *don't* want to have the browser handle...
2018-10-20 15:32:09 +03:00
Johann-S
735c374e9c
use pointer events if available
2018-10-20 15:32:09 +03:00
Johann-S
c08652cfe8
swipe left/right without hammerjs
2018-10-20 15:32:09 +03:00
Johann-S
caefd70463
Add touch support in our carousel with HammerJS.
2018-10-20 15:32:09 +03:00
galczo5
6cbcd03efb
Add show
and hide
methods to dropdown ( #27370 )
2018-10-20 14:27:51 +03:00
XhmikosR
ea575bc1a7
js/tests/visual: fix popper script.
...
Broken after 787441d
.
2018-10-14 08:17:40 +03:00
XhmikosR
339311ddb5
Fix invalid selectors in tests and examples.
2018-10-14 08:17:40 +03:00
Christopher Morrissey
ea0faadde5
feature(carousel): carousel-item interval ( #26667 )
...
adds the ability to assign data-interval to an individual carousel-item
2018-09-18 15:55:48 +03:00
XhmikosR
787441d4bf
docs: use the bundle dist file.
2018-09-18 12:50:18 +03:00
XhmikosR
0b97d1b0c4
Use https in more places and fix a few redirects.
2018-09-14 18:27:55 +03:00
Johann-S
a689120fd2
throw error when folks try to use a bad selector
2018-09-13 22:13:36 +02:00
Johann-S
9efed82522
refactor karma config in one file
2018-09-13 21:59:37 +02:00
Johann-S
c543f360c9
do not use coverage files on browserstack
2018-09-13 21:59:37 +02:00
Johann-S
6e2a823a44
collapse children with no data-parent
2018-09-10 21:10:00 +02:00
Johann-S
a3e45d8ced
add information about valid selectors ( #27137 )
2018-08-31 21:00:29 +02:00
Johann-S
54d86e6249
move away from sauce labs to browserstack
2018-08-30 22:17:15 +02:00
Johann-S
eab9da5beb
fix(util): use querySelector for ids
2018-08-12 17:01:01 +02:00
Johann-S
6b92321f6a
fix(util): use getElementById when it's possible
2018-08-07 18:49:02 +02:00
Johann-S
d18045210c
fix(tests): visual plugins tests
2018-07-23 17:29:53 -07:00
Mark Otto
0e920ce3f4
Reorganize docs for easier deploys
...
With the current docs directory setup, I'm making too many mistakes and have to manually address path changes and directory moves on deploy. This makes for a frustrating experience developing locally and shipping releases. With this PR, we're basically back to the same setup from v3—duplicating the dist directory into our docs directory. Not the most ideal, but very straightforward for me as the release manager.
2018-07-11 23:30:46 -07:00
Johann-S
283ab30164
fix(modal): fix unit test and resetting style
2018-07-11 11:05:38 +02:00
Catalin Zalog
cb82394fc8
fix(modal): removes .navbar-toggler margin
2018-07-11 11:05:38 +02:00
Johann-S
e57a2f244b
fix(tooltip): get tip on placement change
2018-06-25 16:54:14 +02:00
jakubhonisek
49e094619b
feat(dropdown): add original click event
2018-06-25 15:29:34 +02:00
Johann-S
149096016f
fix(collapse): xss in parent option
2018-06-01 09:10:25 +02:00
Johann-S
2d90d369bb
fix(tooltip): xss in container option
2018-06-01 09:10:25 +02:00
Johann-S
f2aab5ea99
fix(tooltip): remove useless unit test
2018-05-22 17:26:21 +03:00
Johann-S
0338b61eb6
chore(deps): update qunit and karma-qunit
2018-05-22 17:26:21 +03:00
Johann-S
ba10b63c9d
fix issue related to Object.keys and Dropdown issue
2018-04-13 18:59:30 +02:00
Swardu
c3caf7ee4e
Docs/examples: change links to Sass documentation and example.com to https
2018-04-12 11:56:33 +01:00
Johann-S
0871d69ec9
v4 improve coverage ( #25945 )
...
* Improve code coverage for our Button plugin
* improve coverage for our Alert plugin
* test tooltip update method
* test update and dispose for dropdown
* increase code coverage requirements
2018-04-10 09:28:29 +02:00
XhmikosR
875ed0b975
Clean up globals.
...
Also, add a missing license header in build/workbox.js.
2018-04-09 22:44:22 +03:00
XhmikosR
95cdfa2a65
Use https when possible.
2018-04-02 19:19:09 +03:00
Johann-S
fd57d371f8
fix bundle and run test against it
2018-03-29 21:21:31 -07:00
vsn4ik
68db42c9f8
Fix skip element disabled via attribute when using keyboard navigation
2018-03-26 09:37:25 +02:00
XhmikosR
2cd700313d
Remove the local jquery-1.9.1.min.js.
2018-03-21 12:15:47 +02:00
XhmikosR
f5e16ceccc
tests: load 3rd-party libs from the local node_modules folder.
...
This reduces duplication and the chances to forget to update something.
2018-03-21 12:15:47 +02:00
XhmikosR
e0ab096bac
Update all devDependencies.
...
Kept back karma-qunit and qunitjs because tests fail.
2018-03-21 12:15:47 +02:00
XhmikosR
1615a76f83
Use sinon from cdnjs.
2018-03-21 12:15:47 +02:00
XhmikosR
7d3ca1b2ea
tests: use QUnit from the jQuery CDN.
2018-03-21 12:15:47 +02:00
Johann-S
9191fa73df
throw error when coverage is under our thresholds
2018-03-21 07:04:24 +01:00
Johann-S
bedc96e48b
Use transitionEnd in QUnit since we moved away from PhantomJS
2018-03-20 15:56:51 +01:00
Johann-S
4d5c5923fa
Add Sinon to do better unit test
2018-03-13 15:37:11 +01:00
Johann-S
2c41b0aea6
fix get the transition duration parent
2018-03-13 12:57:44 +01:00
Martijn Cuppens
1fadad1c33
Variable transition durations ( #25662 )
2018-03-13 09:59:20 +01:00
Johann-S
fb60a4a986
Add a bit of documentation on how to run the code coverage ( #25783 )
2018-03-06 07:35:28 +02:00
Johann-S
e43f97304e
add code coverage
2018-03-05 10:04:54 +01:00
Martijn Cuppens
3dd0bde664
Fix carousel transition duration ( #25218 )
2018-02-19 10:10:25 +01:00
Johann-S
65ae622d40
Dropdown - Allow to disable Popper.js style ( #24092 )
...
* Dropdown - Allow to disable Popper.js style
* Update dropdown.js
* Update dropdown.html
* copy changes
2018-02-11 16:45:59 -08:00
Johann-S
5a6be71791
Remove escaping selector and add a warning to inform folks to escape their selectors ( #25390 )
2018-01-21 22:02:16 +02:00
719media
bd9084d249
Update dropdown.js to allow referenceElement ( #25219 )
2018-01-21 19:09:23 +01:00
XhmikosR
80d0943b95
Comply to the new rules.
2018-01-11 18:48:46 +02:00
XhmikosR
6d336502c7
Clean up and tweak ESLint rules.
...
Also, refactor ESLint and stylelint config files; now everything will work from our root dir.
2018-01-11 18:48:46 +02:00
Martijn Cuppens
a1d134f8a8
Multiple accordion support ( #25161 )
2018-01-03 16:40:58 +02:00
Martijn Cuppens
ae71e71fe1
Allow nested structure for accordions ( #25121 )
...
This commit allows nested structures for accordions. Also a part of
the documentation about data-children is removed because this
functionality didn't work and it's not applicable anymore.
Tests with the collapse accordion are also a bit adjusted to the new
situation.
2017-12-31 14:53:33 +02:00
Troy Morehouse
8839c03865
dropdown: add boundary config option ( #24976 )
2017-12-12 11:28:30 +02:00
Johann-S
a07bc5dbcb
Update README.md ( #24912 )
2017-11-29 18:42:09 +02:00
Alessandro Chitolina
80d4a51e79
tab.js: do not remove fade class if there's no initial active pane
2017-11-26 20:29:19 +01:00
Johann-S
e8ba37139f
Allow us to run our unit test on differents jquery version
2017-11-23 10:41:56 +02:00
Edward Betts
ffc5965f2c
Correct spelling mistakes. ( #24778 )
2017-11-15 04:12:38 -05:00
Vasilii Artemchuk
5a2d6c70f4
Use native pseudo-selectors instead of jQuery selectors ( #24713 )
2017-11-09 07:51:19 +02:00
XhmikosR
4bacf8dd04
Update devDependencies.
2017-11-08 01:04:31 +02:00
XhmikosR
fc9967e175
Fix test failure with jQuery 1.9.1 ( #24706 )
2017-11-07 14:13:52 +02:00
Johann-S
79d6b574cc
Escape ID in Util.getSelectorFromElement ( #24700 )
2017-11-07 12:41:06 +01:00
Johann-S
26dc17bcd2
Popover - call content
once if it's a function. ( #24690 )
2017-11-07 09:18:52 +02:00
patrickhlauke
96a9fa1c82
Remove invalid example of title
attribute in an SVG and related vnu error suppression
2017-10-31 21:36:17 +02:00
Johann-S
e454c8ec1e
Add dropright and dropleft (right and left placements for our dropdown) ( #23860 )
...
* Add dropright (right placement for our dropdown)
* Add dropleft
* moves drop left arrow to the left
2017-10-29 15:29:13 -07:00
Johann-S
41fbec1188
Fix unit tests.
2017-10-27 19:19:55 +03:00
Pierre-Denis Vanduynslager
6fe72c6de8
Dropdown handle keydown on input and textarea.
2017-10-27 19:19:55 +03:00
Johann-S
988327032d
Add unit tests for util.js
2017-10-25 12:59:40 +02:00
Johann-S
62fbb23ee6
Change Rollup config to wrap our dist files with jQuery instead of $
2017-10-24 12:39:25 +02:00
Johann-S
1487c3a994
Add Util.jQuery
which will detect jQuery instead of relying on global $
( #24513 )
2017-10-23 10:35:27 +03:00
XhmikosR
2ef5b90136
Tighten htmllint's rules. ( #24471 )
2017-10-22 15:02:24 +03:00
Johann-S
8e7ba02c5c
Modal plugin set _isTransitioning after the trigger of hide event
2017-10-10 14:19:22 +02:00
Vasilii Artemchuk
1aea9d7517
Update js/tests/README.md ( #24281 )
2017-10-07 01:04:21 +03:00
Johann-S
347b3ac1c0
Remove global jQuery in eslint because we import jQuery ( #24246 )
2017-10-04 17:31:35 +03:00
XhmikosR
be9e6f3638
Update modal.js
2017-10-04 15:03:06 +03:00
lucascono
47968c8126
Unit test for modal bug fix
...
Unit test for pull request #24240
2017-10-04 08:55:40 -03:00
XhmikosR
ee574b76a7
Switch to lowercase doctype
. ( #24217 )
...
Having it uppercase doesn't offer anything and the lowercase version slightly improves gzip compression.
2017-10-03 19:34:59 +03:00
XhmikosR
499f9dc960
js/tests/visual/tab.html: fix HTML validation errors. ( #24183 )
2017-10-01 09:49:35 +03:00
XhmikosR
502ac7ee4d
Lint docs js too and use `strict consistently. ( #24160 )
2017-09-28 17:25:28 +03:00
XhmikosR
31c8721913
Normalize all links. ( #24109 )
...
* use a trailing slash when possible
* use https when possible
* remove a few redirected links
* consistently use `https://popper.js.org/ `
* fix `iconUrl` in nuget files
* change Jekyll Windows guide to the official one
2017-09-26 15:24:14 +03:00
Johann-S
9b8356ba52
Collapse - Allow to pass jQuery object or DOM element to the parent option
2017-09-25 13:23:13 +02:00
Patrick H. Lauke
fd56ea370c
Accessibility fixes to dynamic tabs (aria-selected
, remove dynamic tabs with dropdowns)
...
* Use `aria-selected` instead of `aria-expanded`
* Change tab.js to use `aria-selected` rather than `aria-expanded`
* Add `aria-orientation=vertical` to vertical tab list
* Remove dynamic tabs with dropdowns
* Fix non-interactive code examples
* Only set `aria-selected` on the `role="tab"` trigger - this stops `aria-selected` being incorrectly added to the `role="tabpanel"` itself (probably harmless, but nonetheless incorrect)
2017-09-24 12:00:54 +02:00
Troy Morehouse
6c70c70f63
fix(scrollspy): Spying on nested navs fails to activate for .nav-link's inside nav-item's ( #23967 )
...
* fix(scrollspy): Handle nested navs when nav-link inside nav-item
* [scrolspy] Find only child .nav-link's inside .nav-item
* [scrollspyt] Add tests for nested navs with nav-link inside nav-item
* fix troy-o's in test
2017-09-17 09:30:37 +02:00
Johann-S
e04e42d08c
Merge branch 'v4-dev' into fix-jumping-modal-on-resize
2017-09-03 12:56:04 +02:00
Johann-S
37e105333d
Merge branch 'v4-dev' into fix-unwanted-padding-on-modal
2017-09-02 09:04:04 +02:00
Johann-S
9936bf5944
Create a bundled release of Bootstrap with Popper.js inside
2017-08-31 18:43:04 +02:00
David Bailey
ce41d3fd15
Add failing test
2017-08-29 15:36:37 +01:00
David Bailey
2622a015f2
Fix unit tests in PhantomJS
...
Use a virtual scrollbar as this is simpler than having a real one (overflow: scroll doesn't seem to work in Phantom), and disable it for the new test.
One test has also been altered to prevent erroneous fails when other inline styles are added to the body (e.g. overflow).
2017-08-29 12:01:41 +01:00
David Bailey
487513ff03
Add failing test
...
When the body does not overflow (achieved by hiding the QUnit container), it should not be given a margin.
2017-08-28 16:21:04 +01:00
meeque
9612830701
Add unit test for xss in data target attribute
2017-08-25 23:20:14 +01:00
Johann-S
bcad4bcb5f
Fix XSS in data-target
2017-08-25 23:20:14 +01:00
David Bailey
ba6a6f1369
Fix sticky margin when a modal is opened ( #23669 )
...
* Adjust margin for sticky elements on modal
Previously white space was visible to the right of sticky elements due to right padding being added to the body. This fixes #23661 .
* Add unit tests for margin of sticky elements on modal
2017-08-25 22:01:41 +01:00
Johann-S
5a90b4aa3e
Collapse - preventDefault only on <a> elements not inside the collapsible
...
element
2017-08-25 09:48:35 +01:00
Johann-S
4571ab0e57
Fix toggle for Tooltips/Popover which was called even if the Tooltip/Popover was disabled
2017-08-24 09:33:49 +01:00
XhmikosR
ef8c77d8dc
Tweak ESLint rules.
2017-08-23 00:05:38 +03:00
Johann-S
58994a16c5
Add a unit test to check if the carousel do not cycle when its parent isn't visible
2017-08-17 17:48:14 +01:00
Johann-S
d2bd8fb7a9
Unit test to check if our carousel do not cycle when we cannot see it
2017-08-17 17:48:14 +01:00
Johann-S
2eb1e687bd
Improve previous selector for nested tabs
2017-08-11 15:04:07 +03:00
Johann-S
edf90c1bc4
Add unit test for nested tabs
2017-08-11 15:04:07 +03:00
Bardi Harborow
d35020cee8
Update dependencies.
2017-07-16 13:51:16 +10:00
Johann-S
0480a75a5a
Dropdown - Disable applyStyle modifier instead of removing inline style applied by Popper.js
2017-07-04 10:37:44 +02:00
Mark Otto
52cf0fe648
update instances of .bg-inverse and .bg-faded to .bg-dark and .bg-light
2017-06-25 18:31:23 -07:00
Mark Otto
36e482ed27
update navbars to rename .navbar-inverse to .navbar-dark, update all navbar examples and variables
2017-06-25 18:29:43 -07:00
Mark Otto
9c0e423008
Rename popover classes
...
Part of an update to align the naming schemes across our components.
- Renames .popover-title to .popover-header
- Renames .popover-content to .popover-body
Refs: #22092
2017-06-15 09:05:30 -07:00
Mark Otto
6c8c0aa4cf
Rename .card-block to .card-body to match nomenclature of modals
2017-06-15 09:05:16 -07:00
Johann-S
f0124769c9
Collapse supports multi-target thanks to @vanduynslagerp ( #22713 )
2017-06-14 13:21:49 +02:00
Johann-S
4a2b183e48
Fix unit tests with no assertion
2017-06-14 11:18:12 +02:00
Johann-S
1ec68d748b
Upgrade QUnit to 2.3.3
2017-06-14 11:18:12 +02:00
Johann-S
2d87895089
Update path to our docs assets for visual tests
2017-06-04 11:08:31 +02:00
Mark Otto
2fd192968d
Merge branch 'v4-dev' into v4-docs-streamlined
2017-05-30 23:31:40 -07:00
CDAGaming
ccd86bdc96
Update Dependencies (REUPLOAD) ( #22594 )
...
* Update Dependencies (REUPLOAD)
Uglify-JS: 2.8.22 > 3.0.3
QUnitJS: 2.3.1 > 2.3.2
PostCSS-CLI: 3.1.1 > 4.0.0
Clean-CSS-CLI: 4.0.12 > 4.1.0
Babel-Eslint: 7.2.2 > 7.2.3
AutoPrefixer: 6.7.7 > 7.0.1
* Updates More Dependencies
Autoprefixer: v7.0.1 > v7.1.1
Clean-CSS-CLI: v4.1.0 > v4.1.3
Node-Sass: v4.5.2 > v4.5.3
PostCSS-FlexBugs-Fixes: v2.1.1 > v3.0.0
Uglify-JS: v3.0.3 > v3.0.11
Signed-off-by: CDAGaming <cstack2011@yahoo.com>
* Update Gem Bundler Dependency
Signed-off-by: CDAGaming <cstack2011@yahoo.com>
* Update Gemfile.lock Dependency
Signed-off-by: CDAGaming <cstack2011@yahoo.com>
* Update QUnit
Signed-off-by: CDAGaming <cstack2011@yahoo.com>
* Update Uglify-JS to v3.0.13
Signed-off-by: CDAGaming <cstack2011@yahoo.com>
2017-05-30 21:11:56 -07:00
Mark Otto
73a550c7f8
update paths
2017-05-29 23:32:28 -07:00
Geremia Taglialatela
db44e4b311
Update nav and navbar HTML markup
...
According to the docs, you just need to apply the `navbar-nav` to an
`<ul>` tag in a list-based navbar. In fact, `navbar-nav` seems to
override all the css properties set by `nav`.
Also, `nav-item` class should be used only for `<li>` tags, or in
conjunction with `<a>` tags to entirely avoid the list-based approach.
This commit removes the redundant `nav` class from `navbar-nav` `<ul>`
tags, moves `nav-item` from `<a>` tags to `<li>` tags and properly
adds `nav-item` class to `<li>` tags where missing.
Refs:
* https://v4-alpha.getbootstrap.com/components/navs/
* https://v4-alpha.getbootstrap.com/components/navbar/#nav
2017-05-27 15:21:49 -07:00
Johann-S
4c3b6c5ceb
Placement auto for popovers
2017-05-24 14:57:40 +02:00
Johann-S
2c72af88ee
Placement auto for tooltips
2017-05-24 14:57:40 +02:00
Johann-S
70f4a30def
Better management of dropdown/dropup with alignment
2017-05-22 16:14:10 +02:00
Johann-S
b36d8ae6cb
Use popper to align dropdown menu instead of using css with important
2017-05-17 22:03:11 +02:00
Johann-S
ab7dc8ae2a
Fix dropdown in scrollspy visual test (add Popper.js)
2017-05-14 11:41:19 +02:00
Johann-S
18e4e851e2
Better placement for Dropdown + Handle flip of Tooltip/Popover
2017-05-14 11:41:19 +02:00
Johann-S
53ee455bc7
Handle dropup for Dropdown
2017-05-14 11:41:19 +02:00
Johann-S
69de65180f
Fix unit tests + Update Popper to 1.6.0
2017-05-14 11:41:19 +02:00
Johann-S
54a8ab4011
Begin to use Popper for Dropdown
2017-05-14 11:41:19 +02:00
Johann-S
d8996a7e0a
Fix arrow for tooltip and popover
2017-05-14 11:41:19 +02:00
Johann-S
b40b1bc396
Add attachment classes
2017-05-14 11:41:19 +02:00
Johann-S
81e07ec052
Begin to add arrow to Popover and Tooltip
2017-05-14 11:41:19 +02:00
Johann-S
6cf0fe8780
Use Popper for tooltip and popover
2017-05-14 11:41:19 +02:00
Anna
33715a73d2
Fix Toggle buttons don't honor [disabled] or .disabled
2017-04-26 18:46:05 +02:00
Pierre Vanduynslager
ab39defe74
Detach accordion from card without requiring 'data-children'
2017-04-25 09:32:14 +02:00
Zach Leatherman
638b97f19c
Arguably more professional pictures of Rick Ross
2017-04-21 20:51:35 -07:00
Bardi Harborow
2906b612d5
More minor build tweaks and docs updates.
2017-04-21 21:08:40 +10:00
Bardi Harborow
b4ac48fdec
Build system overhaul.
2017-04-20 14:31:22 +10:00
Patrick H. Lauke
6ae5fb12e6
Fix carousel "hover" behavior on touch-enabled devices
...
* Add carousel mouse listeners even if touch events enabled
- touch events are enabled not just on "mobile", just also on
touch-enabled desktop/laptop devices; additionally, it's possible to
pair a mouse with traditionally touch-only devices (e.g. Android
phones/tablets); currently, in these situations the carousel WON'T pause
even when using a mouse
* Restart cycle after touchend
as `mouseenter` is fired as part of the touch compatibility events, the
previous change results in carousels which cycle until the user
tapped/interacted with them. after that they stop cycling (as
`mouseleave` is not sent to the carousel after user scrolled/tapped
away).
this fix resets the cycling after `touchend` - essentially returning
to the previous behavior, where on touch the carousel essentially never
pauses, but now with the previous fix it at least pauses correctly for
mouse users on touch-enabled devices.
includes documentation for this new behavior.
2017-04-17 13:26:46 +01:00
Pierre Vanduynslager
208e0384df
Merge branch 'v4-dev' into dropdown-keyboard
2017-04-12 10:36:14 -04:00
Patrick H. Lauke
53b2c5520b
Remove inappropriate role="listbox" from carousels
2017-04-11 11:12:30 +01:00
Pierre Vanduynslager
025ddb185e
Merge branch 'v4-dev' into dropdown-keyboard
2017-04-10 11:04:05 -04:00
Patrick H. Lauke
18e8704221
Fix collapse.js aria-expanded behavior
...
* Remove aria-expanded from collapse.js target element
aria-expanded="true"/aria-expanded="false" only applies to the trigger,
not the element that is being expanded/collapsed.
* Tweak collapse.js accessibility section
...to make it clearer that the aria-expanded attribute always just goes
on the control.
* Fix collapse.js unit tests
- reword some of the text to make it clear we're checking behavior of
trigger/control
- move incorrect aria-expanded out of the <div>s and to the actual
trigger/control <a>s
- fix incorrect test assertion text output false -> true
2017-04-10 14:51:22 +01:00
Patrick H. Lauke
3f6e1faf45
Only change aria-pressed if it's not an input-based radio or checkbox group
...
* Only change aria-pressed if it's not an input-based radio or checkbox group
aria-pressed="true"/aria-pressed="false" is really only useful for
making on/off toggles out of, say, `<button>` elements. the attribute is
useless (and potentially confusing/conflicting) on, say, `<label>`
elements for an existing `<input type="radio">` or similar.
* Add unit test for buttons.js and radio/checkbox inputs in button groups
2017-04-10 14:43:54 +01:00
Pierre Vanduynslager
fe72daf2b3
Merge branch 'v4-dev' into dropdown-keyboard
2017-04-08 18:43:25 -04:00
Ilias
e6e070b02a
Fix #22332 : Adjust tests for hidden scrollbar
2017-04-03 13:27:15 +02:00
Ilias
a14451deb3
Fix #18373 : properly adjust padding-right of body and fixed elements when opening or closing modal
2017-04-02 13:26:25 +02:00
Pierre Vanduynslager
91b62941af
Tabs/Scrollspy/.nav/.list-group/.active independent of markup (<nav>, .nav-item, <li> etc...)
2017-04-02 11:21:04 +02:00
Johann-S
5142de7e59
Popover + Tooltip - fix error when content or title is a number
2017-03-31 10:03:54 +02:00
Johann-S
fb42d6e043
Collapse - Fix check to not prevent event for input and textarea
2017-03-29 00:10:27 +02:00
Pierre Vanduynslager
48c5efa4c3
Fix JS components console error "Error: <Component> is transitioning"
2017-03-28 23:43:15 +02:00
Johann
904efc043d
Fix different tooltips offset when hovering
2017-03-28 15:55:03 +02:00
Johann
24924c23b2
Collapse - do not prevent event for input and textarea
2017-03-27 10:08:39 +02:00
Mark Otto
90c5f6230b
rename from .navbar-toggleable to .navbar-expand to reflect mobile first approach everywhere else
2017-03-23 23:02:28 -07:00
Mark Otto
11ba308b2f
more docs updates
2017-03-23 23:02:28 -07:00
Pierre Vanduynslager
37f438910f
Accordion behavior with JQuery interface ( #21726 )
...
Fix accordion behavior with JQuery interface
2017-03-23 21:15:41 +01:00
Johann
c72a315740
Carousel - Add attributes from and to for Slid and Slide events ( #21668 )
...
Carousel - Add attributes from and to for Slid and Slide events
2017-03-22 22:42:13 +01:00
Pierre Vanduynslager
78fc4d23fc
Always append element to fixture in Scrollspy unit tests ( #22234 )
2017-03-21 10:21:00 -07:00
Bardi Harborow
09fb2b9af3
Update dependencies.
2017-03-20 17:37:05 +11:00
Mark Otto
3730c5dbf5
Merge branch 'collapse' of https://github.com/Johann-S/bootstrap into Johann-S-collapse
2017-03-19 18:43:13 -07:00
Pierre-Denis Vanduynslager
f5cc591456
Merge branch 'twbs/v4-dev' into dropdown-keyboard
2017-03-18 22:08:55 -04:00
Johann
1a46d8c730
Allow to use Tab.js with list-group ( #21756 )
...
* Allow to use Tab.js with list-group
* Allow to use list-group with div parent instead of an ul parent
2017-03-18 16:36:33 -07:00
Johann-S
21b537cc24
Add unit test
2017-03-09 11:08:47 +01:00
Bardi Harborow
6593b15555
Refactor QUnit test page.
2017-02-22 11:14:47 +11:00
Pierre-Denis Vanduynslager
4ab576a419
Fixes #21941
2017-02-08 18:51:50 -05:00
Bardi Harborow
cb87eebcbb
Update dependencies.
2017-02-05 23:50:06 +11:00
Pierre-Denis Vanduynslager
ef2181ff4d
Harmonize document.activeElement comparison
2017-01-20 23:22:50 -05:00
Pierre-Denis Vanduynslager
4448ca057b
Refactor test to event and async
2017-01-20 23:02:45 -05:00
Pierre-Denis Vanduynslager
1a783a4255
Add unit test for keyboard navigation
2017-01-20 23:02:19 -05:00
Pierre-Denis Vanduynslager
59f438b40e
Merge branch 'twbs/v4-dev' into dropdown-keyboard
2017-01-20 20:27:17 -05:00
Pierre-Denis Vanduynslager
9daf681478
Fix test to retrieve the proper item instead of it's parent
2017-01-20 20:27:14 -05:00
Pierre-Denis Vanduynslager
57713c9fc5
Fix missing closing tag
2017-01-18 15:01:06 -05:00
Pierre-Denis Vanduynslager
a85b80fa75
Merge branch 'twbs/v4-dev' into dropdown-keyboard
2017-01-15 10:33:54 -05:00
Patrick H. Lauke
6b48ba4e0d
Remove incorrect aria-multiselectable
...
Closes https://github.com/twbs/bootstrap/issues/21635
2017-01-11 23:57:59 +00:00
Pierre-Denis Vanduynslager
4c2f544359
Merge branch 'twbs/v4-dev' into dropdown-keyboard
2017-01-06 15:57:15 -05:00
Pierre-Denis Vanduynslager
eb84c03ddf
Update dropdown unit test to new markup
2017-01-06 15:56:38 -05:00
Johann-S
0463b01282
Close #21090 - Fix aria-pressed attribute for buttons in container with data-toggle='buttons'
2017-01-04 11:02:16 +01:00
Pierre-Denis Vanduynslager
bbb0d2b573
Dropdown: close menu when focusing outside element ( #21375 )
...
* Close dropdown menu when focusing an outside element
* Update unit test to new markup
2017-01-02 14:44:27 -08:00
Mark Otto
c61a0059ad
update seletors in js
2017-01-02 11:52:38 -08:00
Mark Otto
20b05e42e3
update rest of docs, remove navbar specific modifiers, fix docs example css
2017-01-02 11:48:51 -08:00
Mark Otto
e2b6badb86
v4: Rip out IE compatibility mode meta tags ( #21483 )
...
* Remove IE compatibility mode meta tag from docs, examples, and JS tests as we no longer support IE9 and IE8
* update and remove some IE bits from our supported browser page
* update introduction.md to match
* reword starter template intro
2016-12-31 12:20:32 -08:00
Johann-S
026e1a1421
Allow to use nav with tab JS
2016-12-31 00:54:00 -08:00
Mark Otto
d935cca9f6
one more test file
2016-12-31 00:52:08 -08:00
Mark Otto
55413e109f
nuke local test vendor jquery and tether, replace with docs assets
2016-12-31 00:52:08 -08:00
Johann-S
719318f485
Update visual test carousel
2016-12-31 00:51:19 -08:00
Mark Otto
92fa9b2256
fix navbar in dropdown visual test file
2016-12-30 22:45:39 -08:00
Bardi Harborow
a8100e1f01
Extend ESLint to cover all JS files and drop JSCS.
2016-12-31 16:49:15 +11:00
Johann-S
95ce03f000
Close #21249 : Add a Unit test for #21227
2016-12-29 13:28:42 -08:00
Max Beatty
aa7f95fd77
update click state when hiding so can be shown again by trigger. fixes #16732
2016-12-27 14:19:12 -08:00
Alessandro Rodi
9103bffe37
[ Fix #19849 ] Tabs are opened even if disabled. ( #20795 )
...
* [Fix #19849 ] Tabs are opened even if disabled.
* fix hund code review hints
* rollback hound issues because Travis fails
2016-12-24 23:31:34 -08:00
Matheus Azzi
dab6a41e04
Carousel: Only prevents default for ARROW_LEFT and ARROW_RIGHT keys
...
Fixes 2 bugs:
1. All keydowns were being prevented. Because of that the user wasn't able to navigate in the whole page using ARROW_UP/ARROW_DOWN.
2. Even when is an input or textarea the keydowns were being prevented. Because of that the user wasn't able to type any text on these elements.
2016-12-23 17:55:40 +11:00
Starsam80
bf39bb3ac3
Rename .active
to .show
2016-12-07 21:20:15 -07:00
Johann
297c47c3fd
[V4] Throw error when a plugin is in transition ( #17823 )
...
* Throw error when a plugin is in transition
* Add unit tests about plugins in transition
2016-12-02 09:52:19 -08:00
Rob Ruana
5eddb0b0fd
Closes #21055 : Prevents ScrollSpy from clearing active item when Safari rubberbands ( #21056 )
...
When the rubberband effect causes Safari to scroll past the top of the
page, the value of scrollTop becomes negative. If the offset of the first
ScrollSpy target is 0 - essentially if the target is at the top of the
page - then ScrollSpy should not clear the active item. Conceptually, the
first item should remain active when rubberbanding past the top of the
page.
This commit fixes issue #21055 by verifying the first scrollspy target is
not at the top of the page before clearing the active nav-item.
2016-11-27 16:20:33 -08:00
Mark Otto
b6b8280938
Merge pull request #18900 from vlastikcz/v4-dev-buttonChange
...
Button toggling - trigger change event on input. Fixes #16673 , fixes #17599 .
2016-11-26 01:18:21 -08:00
Mark Otto
ce31f54c36
Merge pull request #19058 from Johann-S/carouselInput
...
Carousel - Do not prevent on keydown for input and textarea
2016-11-26 01:14:55 -08:00
Mark Otto
25d218b02d
Merge branch 'v4-dev-18796' of https://github.com/maxbeatty/bootstrap into maxbeatty-v4-dev-18796
2016-11-26 00:58:51 -08:00
Johann
ce18a66809
Add test unit to check logic of ignoreBackdropClick ( #18245 )
2016-11-25 22:57:20 -08:00
matus
d328c911cb
Added a virtual test
2016-11-25 17:39:00 -08:00
Mark Otto
432fe74c31
Merge branch 'eslint' of https://github.com/bardiharborow/bootstrap into bardiharborow-eslint
2016-11-25 14:59:28 -08:00
Matt Hernandez
b1b1f30cbd
[ Fix #17371 ][V4] Deactivating dropdown links in nav tab ( #17642 )
...
* Fix bug with dropdown tab links not deactivating when other tab or dropdown link is clicked
* Revise bug fix for more stability
2016-11-25 14:56:41 -08:00
Bardi Harborow
c2616fb74e
Make JS compliant with the new ESLint rules.
2016-11-24 11:59:55 +11:00
Bardi Harborow
26c16743fc
Refactor ESLint configuration.
2016-11-24 11:59:55 +11:00
Bardi Harborow
b9e7cef965
Update visual tests.
2016-11-13 02:34:18 +11:00
Johann
a7f1b59959
Making .tooltip('show') throw an error on elements with display:none ( #20940 )
2016-10-31 20:33:53 -07:00
Mark Otto
c01fa6b369
Merge pull request #17536 from Johann-S/testPadding
...
[Fix #17400 ] Add tests about padding restoration
2016-10-28 13:46:14 -07:00
Johann-S
9d129a43d6
Use a single class name for opened/expanded/shown state of widgets
2016-10-25 14:07:41 +02:00
Mark Otto
73154d0392
Merge pull request #20467 from maxbeatty/v4-dev-17754
...
add support for ol in tab plugin
2016-10-24 20:50:52 -07:00
Johann-S
9bc7de9395
Fix bug multiple accordions collapse
2016-10-19 09:35:48 +02:00
vsn4ik
85327e4f9a
v4: Fix outdated utilites classes
2016-10-12 01:46:10 +03:00
Johann-S
de1255b14e
Collapse using card component
2016-10-11 13:25:36 +02:00
Mark Otto
4d725c90d6
Merge pull request #17568 from Johann-S/fixCollapseHeight
...
[Fix #17555 ][V4] fix resetting style on closing collapse
2016-10-09 20:32:40 -07:00
Bardi Harborow
d57d5a606b
Update dependencies, including Babel to v6 and zeroUnits fix.
2016-10-09 12:15:17 +11:00
Bardi Harborow
2e69dfa8c1
Fix broken/redirected links, moving to HTTPS where possible. ( #20557 )
2016-10-03 09:55:59 -07:00
VarelloThemes
63129112bb
replace some profanities ( #20715 )
2016-09-15 09:39:31 -07:00
Max Beatty
dc1b4e78d4
add support for ol in tab plugin. fixes #17754
2016-08-04 16:57:08 -07:00
Max Beatty
bfa714ae1e
prevent navigating to area href when modal target. fixes #18796
2016-08-04 13:47:30 -07:00
Chris Rebert
ed3ba47425
Support jQuery v3 in Bootstrap v4 ( #20191 )
...
* bower.json, package.json: Extend jQuery version ranges to include v3
* NuGet: Bump jQuery to v3.0.0.1
* Docs+Examples: Update jQuery to v3.0.0
* Use jQuery v3.0.0 for JS unit tests
* Update jqueryVersionCheck to allow jQuery v3.x.x
2016-06-28 22:19:46 -07:00
Dave Methvin
8900d953ed
ScrollSpy unit test: Use single done() in a then() instead of multiple done()s ( #20198 )
...
Fixes test flakiness on OS X Safari and Android when using jQuery 3.
Fixes #20182 more
Refs #20191
2016-06-28 13:24:28 -07:00
Dave Methvin
208d587c7e
Scrollspy test: Allow for async .then() in jQuery 3; fixes #20182
...
Instead of doing a new assert.async(), just do a single one for the entire test
and let the .then() be async as well.
Closes #20190
2016-06-27 22:37:31 -07:00
Chris Rebert
aa369bd8f9
Remove unnecessary usage of Promises in non-async ScrollSpy tests ( #20180 )
...
Closes #19906
[skip validator]
2016-06-26 21:33:07 -07:00
Chris Rebert
14c7ba95f9
Fix load & scroll event usage in ScrollSpy tests ( #19986 )
...
* Use $.one() instead of $.on() since there are no $.off()s in the code.
* Remove unnecessary namespacing of listeners for the `scroll` & `load` events.
These are vanilla DOM events (not custom jQuery namespaced events)
and we're not using jQuery namespacing to manage these event listeners either (e.g. `$.off()`).
[skip validator]
2016-05-30 09:39:45 -07:00
Chris Rebert
d35973c2b3
js/tests/unit/scrollspy.js: Fix "offsed" typos ( #19985 )
...
[skip sauce]
[skip validator]
2016-05-29 18:36:09 -07:00
XhmikosR
a950d5642b
Update jQuery to v2.2.4.
2016-05-26 15:26:12 +03:00
Patrick H. Lauke
b107e3342a
Handle aria-hidden on modal container when showing/hiding
...
Fixes #19878
2016-05-11 02:01:56 +01:00
XhmikosR
8a878c1f7b
Update jQuery to v2.2.2.
2016-03-19 15:21:12 +02:00
Chris Rebert
25cf50a4ac
JS visual tests: Remove usages of defunct .page-header class
...
[skip sauce]
2016-02-27 18:01:12 -08:00
XhmikosR
96cafe2d2d
Update tether to v1.2.0.
...
[skip sauce]
[skip validator]
2016-02-27 13:56:40 +02:00
XhmikosR
79067a6440
Fix validation errors.
...
[skip sauce]
2016-02-19 11:26:54 +02:00
Patrick H. Lauke
83217479c3
Visual/manual test for checkbox/radio button kbd behavior
2016-02-16 21:24:29 +00:00
Chris Rebert
ff4792fcef
js/tests/index.html: Replace jQuery event alias methods with functions that throw explanatory errors, instead of with undefined
...
Refs https://github.com/twbs/bootstrap/pull/19219#issuecomment-184653699
[skip validator]
2016-02-16 04:05:41 -08:00
Johann-S
14ec4fdfc1
Carousel - Do not prevent on keydown for input and textarea
2016-02-01 00:06:07 +01:00
Kotas Vlastimil
866e99b00c
Button toggling - trigger change event on input
...
Bootstrap’s .button styles can be applied to other elements, such as labels, to provide checkbox or radio style button toggling.
When the checkbox or radio state is changed, there should be triggered the change event. Currently, the change event is triggered on the Button, which is not correct. Only input fields do support the change event.
2016-01-14 20:26:32 +01:00
Chris Rebert
d30310feae
Merge pull request #18638 from twbs/fix-18365
...
Modal: Ignore spurious focus event that Firefox fires at document when switching back to its tab
2015-12-24 08:15:27 -07:00
Chris Rebert
2c69e0f810
Add visual test for #18365
...
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1228802
2015-12-22 23:08:03 -07:00
Chris Rebert
96e9205009
js/tests/unit/modal.js: Fix typo
...
[ci skip]
2015-12-22 17:11:21 -07:00
XhmikosR
e55fcbcdfe
tests: bump QUnit to v1.20.0.
...
[skip validator]
2015-12-03 08:41:46 +02:00
Chris Rebert
580e2f7845
Remove stray </p> from js/tests/visual/scrollspy.html
...
[skip sauce]
2015-11-19 01:50:20 -08:00
XhmikosR
7a85751144
Remove html5shiv and respond.js from test files.
2015-10-26 23:57:19 +02:00
XhmikosR
a50849f61b
Switch to jQuery 2.1.4.
...
Now that we don't support IE 8 it's safe to do that.
2015-10-24 19:09:33 +03:00