0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-02 14:24:19 +01:00
Commit Graph

128 Commits

Author SHA1 Message Date
Chris Rebert
aa2c5b5672 Merge pull request #16014 from redbmk/issue-16008
Multiple tooltip triggers don't play well together
2015-05-04 15:07:17 -07:00
XhmikosR
3e7ca3bbc8 Minor lint tweaks. 2015-04-28 11:03:37 +03:00
Braden M. Kelley
4b269037cb Multiple tooltip triggers don't play well together
Fixes issue #16008
2015-04-27 23:03:56 -07:00
F A T
aa479892d5 Merge pull request #16152 from jarthod/tooltip-placement-viewport-fix
Tooltip/popover: Fix auto placement to use viewport
2015-04-27 11:28:54 -07:00
Adrien
37a10d37c1 Compare tooltip right offset to viewport right offset (and not width)
Closes #16142 by merging it.
2015-04-27 01:13:16 -07:00
Chris Rebert
fc372952e2 Throw error when tooltip/popover template has multiple top-level elements
Closes #16219.
2015-04-25 13:16:53 -07:00
Adrien Siami
e949505b89 Allow viewport option to be a function
Closes #16151 by merging a rebased version of it that adds docs and 1 more assertion.
2015-04-21 22:20:15 -07:00
Chris Rebert
c6b62f0cd9 Merge pull request #16147 from Johann-S/event_inserted
Fixes #16124.
2015-04-21 21:40:14 -07:00
Niels Steenbeek
7429fc7ff9 Tooltip: Destroy $tip, $arrow, $viewport to avoid memory leak
Closes #16039.
2015-04-20 23:29:31 -07:00
Johann-S
3d71eae301 Add event after template inserted 2015-04-08 13:10:53 +02:00
Adrien Jarthon
0e8e5222ff Tooltip/popover: Fix auto placement to use viewport
Currently, auto placement is using the container dimensions (if provided) or the element's parent to determine where to open the tooltip:
```javascript
var $container   = this.options.container ? $(this.options.container) : this.$element.parent()
var containerDim = this.getPosition($container)
```
This is quite broken in fact, because the parent element could be just a small div outside the element for example, leading in a totally random placement (placing the tooltip on top even if there's no room). And the container can also be outside of the viewport.

This fix simply uses the viewport instead, that's the purpose of the viewport actually, to position the tooltip.
So the auto placement should use it to find where there's more room.
By default this is body, which is good.
2015-03-25 18:05:58 +01:00
Chris Rebert
4d652035dc v3.3.2 => v3.3.4 2015-03-16 08:39:31 -07:00
Chris Rebert
27bbc7dbe9 Hiding an uninitialized tooltip/popover no longer initializes it; fixes #15874 2015-03-03 22:22:13 -08:00
Chris Rebert
168297c779 rm semicolon for sake of fat's eccentric tastes
Erratum from #15496
2015-03-03 13:06:32 -08:00
Quentin Spencer-Harper
acc5f65756 Tooltip: Avoid creating an unnecessary tooltip when Tooltip#hide is called
Fixed performance bug where a tooltip element is created and then immediately destroyed when tooltip.hide() is called and there is no existing tooltip element

Resolves #15557 by merging it.
2015-02-26 06:53:58 +01:00
Kevin Kirsche
238be65786 [Ref #15881] Use Explicit Values rather than Chain
[Ref #15881] Use Explicit Values for javascript variables rather than chained ones.

From https://github.com/twbs/bootstrap/pull/15881#discussion_r25330647
2015-02-25 12:19:11 -05:00
Chris Rebert
cd4467b194 Merge pull request #15496 from twbs/15484-alternative
Make $(document).tooltip({...}) without a `selector` throw an error
2015-01-28 11:05:40 -08:00
Chris Rebert
ebedeaf2fe Fix name of Tooltip.replaceArrow() parameter
isHorizontal => isVertical
2015-01-27 11:15:55 -08:00
Mark Otto
c683e7dea7 bump versions 2015-01-19 08:32:13 -08:00
XhmikosR
0481ce973f Fix bogus JSCS warning. 2015-01-16 17:50:05 +02:00
Chris Rebert
34f88e94fc window.Document doesn't exist in IE8 2015-01-05 14:47:33 -08:00
Chris Rebert
f6a837cbf1 Make $(document).tooltip({...}) without a selector throw an error
Closes #15484
2015-01-05 14:22:49 -08:00
Zlatan Vasović
576230b92a Happy New Year 🎅 2015-01-01 01:23:48 +01:00
Chris Rebert
adaabab81b Revert "Allow multiple delegated tooltip selectors on a node"
This reverts commit 1b3237629a.
This reverts PR #14189 because it caused major regressions.

Fixes #15168.

We'll try to revisit #14167's feature request in Bootstrap v4.

[skip validator]
2014-12-29 20:08:22 -08:00
Mark Otto
9a7e365c2c bump version to v3.3.1 2014-11-12 09:03:16 -08:00
Mark Otto
94b59b57d6 version bump 2014-10-29 08:56:20 -07:00
Phil Hughes
9740d8bb69 Fix tooltip occasionally not hiding when using a hide delay
Fixes #14375.
Closes #14519 by merging it.
2014-10-26 04:38:18 +01:00
Andrew S. Brown
1b3237629a Allow multiple delegated tooltip selectors on a node
Fixes #14167.
Closes #14189 by merging it.
2014-10-26 03:51:55 +01:00
Heinrich Fenkart
95e0f48e3a Follow-up to e2cfbd5: Fix spaces in placement calculation 2014-10-22 21:38:34 +02:00
saranya.r
e2cfbd5f2d Fixes tooltip misplacements in scrollable viewports with auto positioning
Fixes #14756.
Closes #14767.
2014-10-22 21:35:44 +02:00
Chris Rebert
443a1b11ee tooltip.js: fix alignment 2014-09-24 21:27:56 -07:00
Chris Rebert
4d9890ea2e Use container instead of parent for tooltip/popover auto-placement calcs
Fixes #14561. Big thanks to @wickstargazer.

[skip validator]
2014-09-24 20:46:49 -07:00
Heinrich Fenkart
24ae068f21 Tooltip: Rely on getBoundingClientRect for width and height
Fixes #14553.
2014-09-25 01:35:51 +02:00
saranya.r
db9e8ee813 Fix tooltip misplacement with "auto top"
Fixes #14322.
Closes #14581.
2014-09-17 23:11:04 +02:00
Heinrich Fenkart
e094d470d4 Remove unused Tooltip#validate method 2014-09-13 09:39:15 +02:00
Peter West
4c98507010 Correctly selects arrow placement for a tooltip
Fixes #13696.
Fixes #13696.
Fixes #14197.
Closes #13718.
2014-09-13 04:25:34 +02:00
Heinrich Fenkart
76762169c3 Properly fire hidden event when tooltip is destroyed
Fixes #13031.
2014-09-13 03:07:32 +02:00
Heinrich Fenkart
6e206f5e8f Merge pull request #14492 from twbs/ie8-getBoundingClientRect
Handle lack of .width and .height from getBoundingClientRect() in IE8
2014-09-11 23:11:45 +02:00
Heinrich Fenkart
759a95b0fe Make inDom check of tooltip cross document compatible
Fixes #14483
2014-09-09 03:03:14 +02:00
Heinrich Fenkart
859ddc11fb Merge pull request #14242 from hnrch02/remove-aria-describedby-later
Remove `aria-describedby` attribute later
2014-09-08 23:14:50 +02:00
Chris Rebert
989dafb153 Handle lack of .width and .height from getBoundingClientRect() in IE8
Closes #14093
Correction to #14090
Relevant docs: https://developer.mozilla.org/en-US/docs/Web/API/Element.getBoundingClientRect#Browser_compatibility
2014-09-07 22:58:33 -07:00
Jacob
c22b270582 Merge pull request #14273 from sgonyea/master
Fix hover-popover/tooltip flickering when mouse re-enters
2014-09-07 10:36:45 -07:00
Scott Gonyea
aac0e16452 Fix hover-tooltip flickering when mouse re-enters
- is(':visible') seems to be the only reliable check, without a refactoring of how hoverState is used
- tests need improvement
2014-08-28 17:17:50 -07:00
Chris Rebert
ea0e1606dc Assume Element.getBoundingClientRect() exists; Fixes #14093
[skip validator]
2014-08-17 16:08:49 -07:00
Heinrich Fenkart
dca8afa333 Remove aria-describedby attribute later
Fixes #14241
2014-08-04 19:21:49 +02:00
Jacob
8bf48121a0 Merge pull request #14061 from hnrch02/fix-13656
Expose transition durations on plugin constructors; closes #13656
2014-08-01 12:50:03 -07:00
Heinrich Fenkart
0268b41c4f Fix IE8 reporting type object for getBoundingClientRect 2014-07-09 00:42:02 +02:00
Heinrich Fenkart
231744d628 Expose transition durations on plugin constructors; closes #13656 2014-07-07 13:03:56 +02:00
Chris Rebert
f9ffb49932 refactor/reformat Tooltip.getPosition per @fat's feedback 2014-07-06 00:16:54 -07:00
Chris Rebert
1ce5e9f3ae possible fix for #14013 2014-07-02 10:09:28 -07:00