0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-12 00:08:59 +01:00
Commit Graph

1897 Commits

Author SHA1 Message Date
Laussel Loïc
7ce29d75f3
v5 tabs - accessibility issue when using ul/li semantic
Add aria-role presentation on li element when ul element has role tablist and remove dropdown from visual tests as they've been removed from doc
2020-03-28 09:51:24 +02:00
Johann-S
fe492d8021 fix babel config in our files 2020-03-25 22:32:37 +02:00
Johann-S
26d86fce2a
fix: remove make array util function (#30430) 2020-03-25 16:35:02 +02:00
Martijn Cuppens
2e150e722a Use next dropdown menu instead of first of the parent 2020-03-23 15:35:07 +01:00
XhmikosR
018a94c9c1 Remove Internet Explorer leftovers 2020-03-18 20:59:27 +02:00
Johann-S
47aef7b2c6 Remove IE compatibility JS code 2020-03-18 20:59:27 +02:00
Johann-S
aff115219e
fix: ensure totype always returns stringified null/undefined when null/undefined is passed (#30383) 2020-03-18 13:10:55 +02:00
XhmikosR
38333feda5 Switch to strings constants.
This allows the minifier to mangle the constants. It also allows the linter to find unused strings properly.

While at it, remove a few unused properties.

File                        Before      After       Diff
--------------------------------------------------------
bootstrap.bundle.min.js     23.61 kB    22.61 kB    -1.00 kB (-4.23 %)
bootstrap.min.js            17.04 kB    16.08 kB    -0.96 kB (-5.63 %)
2020-03-18 12:58:54 +02:00
Sparks
c47547cd09
Improvement: harmonize usage of constants (#30285) 2020-03-09 17:26:29 +02:00
Martijn Cuppens
7d8c7c4ba8
prev() function fails when non-element nodes are present (#30117)
The `prev()` function doesn't take nodes other than elements into account. Also we could simplify things a lot using the `previousElementSibling` property. This property isn't fully supported in IE, it only works for elements, but since the `element` variable is an element, we can safely use it here.

I've also added an additional test.

I don't think we had this issue in v4, since we relied on jQuery back then.

Ref. https://developer.mozilla.org/en-US/docs/Web/API/NonDocumentTypeChildNode/nextElementSibling
2020-03-09 17:21:04 +02:00
yonikohen
7a60dcf9b0 Corrected grammatical error in test descriptions (#30150)
"without instantiate it" should be "without instantiating it"
2020-02-10 09:35:13 +02:00
Martijn Cuppens
ef6c13c534
tests: Remove button hrefs (#30119) 2020-02-01 20:39:18 +02:00
Giovanni Mendoza
954a0b1e6a Close modal with keyboard=true & backdrop=static (#29986)
* Close modal with keyboard=true & backdrop=static
2020-01-10 11:06:12 +02:00
XhmikosR
5638499aba
sanitizer.js: Add srcset in the allowed attributes (#29968) 2020-01-07 22:46:28 +02:00
XhmikosR
5d1da6377d Fix the new lint errors. 2020-01-07 22:25:50 +02:00
XhmikosR
9c2b9ac74d
Use regex.test() when we want to check for a Boolean. (#29969) 2020-01-07 22:07:51 +02:00
XhmikosR
8f1c4b9a03
Switch to @rollup/plugin-commonjs (#29907) 2019-12-25 21:43:56 +02:00
XhmikosR
f153748f52
Switch to @rollup/plugin-node-resolve (#29851) 2019-12-25 21:36:22 +02:00
XhmikosR
cc6f66f72a
Dist (#29638) 2019-11-08 10:11:23 +02:00
Steffen Roßkamp
c62efc3ef6 Update normalizeDataKey to match the spec (#29609) 2019-10-31 07:58:09 +02:00
Higor Araújo dos Anjos
46912797b2 Added animation when modal backdrop is static (#29516) 2019-10-25 21:12:09 +03:00
Jeremy Jackson
c1ee395f80 Skip hidden dropdowns while focusing (#29523) 2019-10-17 18:01:44 +03:00
XhmikosR
577bf8b14d
Rename "js/tests/units" to "js/tests/unit". (#29503) 2019-10-09 01:27:43 +03:00
XhmikosR
1770691b33
Dist (#29484) 2019-10-08 09:39:10 +03:00
XhmikosR
622c914a3a
Update devDependencies. (#29447) 2019-10-07 09:31:12 +03:00
Johann-S
e1b82f51e2 add modularity integration test 2019-10-03 09:55:57 +02:00
Johann-S
3d12b541c4 return to the original file structure to avoid breaking modularity 2019-10-03 09:55:57 +02:00
XhmikosR
6cb4ebc048
ESLint: specify --report-unused-disable-directives (#29350) 2019-09-02 12:44:19 +03:00
XhmikosR
d06eec372a
Minor lint tweaks. (#29328) 2019-08-29 16:20:49 +03:00
XhmikosR
bf57274fb5
Dist (#29263) 2019-08-27 16:03:21 +03:00
Johann-S
a5cbb5e71a dropdown show method should do the same as toggle 2019-08-25 15:54:22 +02:00
Markus Hatvan
4d101491da Remaining JS linting TODO (#29289)
* Enable and fix all occurrences with no-mixed-operators rule
* Take care of the max-depth warning in button.js

Signed-off-by: mhatvan <markus_hatvan@aon.at>
2019-08-22 22:17:34 +03:00
Johann-S
6885d65578 dropdown - destroy old popper.js references 2019-08-22 20:30:16 +02:00
Johann-S
a9c35b3ca8 Remove useless check for null object with spread operator 2019-08-18 17:19:36 +03:00
XhmikosR
9cee3c2808 Minor wording tweaks 2019-08-18 17:19:36 +03:00
Johann-S
f03c10a189 allow to pass popper.js configuration for tooltip/popover and dropdown 2019-08-18 17:19:36 +03:00
Johann-S
8b2b490f9b add a way to disable jQuery detection 2019-08-02 16:50:05 +02:00
XhmikosR
eecd75db00
Fix typos. (#29178) 2019-07-31 16:14:21 +03:00
Johann-S
dcba526775 remove underscore for static methods 2019-07-29 11:34:12 +02:00
Johann-S
2ea71a9e78 allow dynamic modal body for scrollable modals 2019-07-28 12:11:10 +02:00
Johann-S
fc02932946 use get selector from element only when needed 2019-07-24 11:27:35 +02:00
Johann-S
e48e498bf4 fix arrow popover (#29115) 2019-07-24 10:53:58 +03:00
Mark Otto
114a0ee193 Rebuild the dist to pickup new utilities file (#29105)
Dist after adding new utils file
2019-07-24 09:13:50 +03:00
Johann-S
e101ba4989 add polyfill.js in visual tests (#29116) 2019-07-24 08:19:47 +03:00
Shohei Yoshida
ebb1eea520 Force reflow for fade-in animation (#29113) 2019-07-23 17:21:23 +03:00
Johann-S
233f3fb1ce rewrite tab unit tests 2019-07-23 14:23:50 +02:00
Johann-S
e1b5d8471a use qunit css for our fixture 2019-07-23 14:23:50 +02:00
Johann-S
b7b56cb10a rewrite scrollspy unit tests 2019-07-23 14:23:50 +02:00
Johann-S
85b70cef3c rewrite tooltip unit tests 2019-07-23 14:23:50 +02:00
Johann-S
c9e650a56f rewrite popover unit tests 2019-07-23 14:23:50 +02:00
Johann-S
1ac07a66ce rewrite modal unit tests 2019-07-23 14:23:50 +02:00
Anton Bershanskiy
e916a9bc03 rewrite toast unit tests 2019-07-23 14:23:50 +02:00
Johann-S
6a59c58480 rewrite dropdown unit tests 2019-07-23 14:23:50 +02:00
Johann-S
0ed1618c06 rewrite collapse unit tests 2019-07-23 14:23:50 +02:00
Johann-S
62730d9afd rewrite carousel unit tests 2019-07-23 14:23:50 +02:00
Johann-S
747f0f4c7b test jquery interface for our alert plugin 2019-07-23 14:23:50 +02:00
Johann-S
891a187059 rewrite button unit tests 2019-07-23 14:23:50 +02:00
Johann-S
c834895fa0 rewrite unit tests for selector engine 2019-07-23 14:23:50 +02:00
Anton Bershanskiy
fe6ba2384a rewrite manipulator unit tests 2019-07-23 14:23:50 +02:00
Johann-S
c8c2074650 Switch from QUnit to Jasmine. 2019-07-23 14:23:50 +02:00
Kitten King
37703a6fc9 Fix Typos across Bootstrap repository (#29082) 2019-07-20 12:53:02 +03:00
Johann-S
18077460aa updated babel 2019-07-17 15:03:32 +03:00
Patrick H. Lauke
cc49977038 Fix dropdown unit test (#29037)
swap jQuery's `trigger(...)` with the more verbose native `dispatchEvent(...)`, as the former may not always behave/bubble correctly (observed while trying to write unit tests for keyboard handling of ARIA tab navigation), which may lead to this test passing even though it fails in real usage.
2019-07-14 12:24:27 +03:00
Mark Otto
39c4ca3970 dist v5 2019-07-12 16:56:26 -05:00
Patrick H. Lauke
f2c63ac729 Port new unit test for dropdown from v4 (#28913)
Add unit test from #28912 to v5
2019-06-25 14:57:41 +03:00
Patrick H. Lauke
f0f75379f6 Closing dropdown with ESC correctly sets focus to toggle (#28928)
Just firing the focus event isn't enough ... need to actually call the proper `focus()` method for it to actually do it...
2019-06-19 12:23:41 +03:00
david-lallement
0829decce0 tooltip dispose:removing only own event handler (#28896) 2019-06-13 10:42:54 +02:00
XhmikosR
8a79cf894d event-handler.js: use a plain for loop. (#28853) 2019-06-03 13:08:17 +02:00
Johann-S
d5752a18ab toast should allow prevent default for hide and show events 2019-05-16 13:24:29 +02:00
Johann-S
c805aec770 fix popover arrow by selecting the first element child 2019-05-14 15:28:43 +02:00
Martijn Cuppens
a827934f13 Documentation tweaks (#28679)
* Documentation tweaks

* Remove redundant col-12 classes
2019-05-08 19:58:29 +03:00
XhmikosR
438e01b61c Rename eventHandler and selectorEngine files. 2019-05-08 17:26:37 +03:00
Johann-S
dda31bbee6 improve build plugin script to keep file name 2019-05-08 17:26:37 +03:00
XhmikosR
e7657c8bc0 Remove the unicorn/filename-case rule suppression. 2019-05-08 17:26:37 +03:00
XhmikosR
091aa1e9fd
v5 dist (#28657) 2019-04-18 14:47:52 +03:00
Johann-S
14f53d9baa fix unit tests for chrome mobile 2019-04-15 13:48:27 +02:00
XhmikosR
afc63ec887 Fix xo error: use for...of. 2019-04-10 15:18:57 +03:00
XhmikosR
105687ac4a Update eslint config for the new xo rules. 2019-04-10 15:18:57 +03:00
ysds
f4877dbf03 Remove _close() and marge with _hide() 2019-04-09 13:59:41 +02:00
ysds
91ebb4b3b2 Call hide() after delay time 2019-04-09 13:59:41 +02:00
XhmikosR
efb9a7749f
karma.conf.js: switch to CI === true. (#28588) 2019-04-01 17:26:43 +03:00
Johann-S
1752addadf Reset carousel touch delta x to prevent click transformation in swipe (#28558) 2019-03-27 14:37:04 +02:00
Johann-S
ad0f5f153c fix remove files in our visual tests 2019-03-18 01:11:05 +02:00
Johann-S
08679ac0b5 Add back support for IE 11 2019-03-18 01:11:05 +02:00
XhmikosR
6aa475c82e
Use one-line imports when possible. (#28467) 2019-03-13 14:55:53 +02:00
XhmikosR
ac67e04ce0 Dist. 2019-03-11 17:59:08 +02:00
Johann-S
2fd50f98a5 build bootstrap in esm 2019-03-11 17:59:08 +02:00
XhmikosR
3ffe3a5d82 collapse.js: minor refactoring. 2019-03-11 17:01:28 +02:00
XhmikosR
1393678f0b Remove obsolete comments. 2019-03-11 17:01:28 +02:00
XhmikosR
dd0239d169 Remove more unused properties. 2019-03-11 17:01:28 +02:00
Johann-S
dce47b5451 scrollspy.js: remove unused properties 2019-03-11 17:01:28 +02:00
XhmikosR
5ac1a12625 Remove assignment from return. 2019-03-11 17:01:28 +02:00
XhmikosR
5bcd6a29cd Disable a few rules for now. 2019-03-11 17:01:28 +02:00
XhmikosR
46c037410b Comply to the new rules. 2019-03-11 17:01:28 +02:00
XhmikosR
44e6abcba5 Switch to eslint-config-xo and eslint-plugin-unicorn. 2019-03-11 17:01:28 +02:00
XhmikosR
19aee321a0
Dist (#28392) 2019-03-01 18:31:34 +02:00
XhmikosR
d5f9107abb
Remove the now unneeded shrink-to-fit directive. (#28314) 2019-02-27 17:47:41 +02:00
XhmikosR
9cbd041f6b
tests: add tests for plugins version. (#28366) 2019-02-27 13:20:25 +02:00
XhmikosR
f7b55da450
dom/manipulator.js: minor simplification. (#28358)
Combine two checks since we return the same value for both.
2019-02-26 13:13:01 +02:00
XhmikosR
7933ee3282 karma.conf.js: minor simplification. 2019-02-26 13:04:04 +02:00
Johann-S
497518db1a remove tests for old jQuery 1.9.x compatibility 2019-02-26 13:04:04 +02:00
Johann-S
8a37045b79 move util in a util folder with the sanitizer 2019-02-26 13:04:04 +02:00
XhmikosR
5ad2121819
Remove DOMContentLoaded. (#28337)
There's no reason for us to wait here.
2019-02-24 15:42:18 +02:00
XhmikosR
423e4a3811 tests/visual/modal.html: fix close button placement. 2019-02-20 22:05:45 +02:00
Johann-S
fee11fd7ae use our selector engine instead of native api 2019-02-20 22:05:45 +02:00
XhmikosR
68e6de42ec Use Util.makeArray(). 2019-02-20 22:05:45 +02:00
Johann-S
e58b47cf74 improve event handler 2019-02-20 22:05:45 +02:00
XhmikosR
30861cbc6d Simplify checks. 2019-02-20 22:05:45 +02:00
XhmikosR
4b7c058a25 Remove unneeded ESLint suppression. 2019-02-20 22:05:45 +02:00
Johann-S
08227506f2 use only dataset to get data attributes 2019-02-20 22:05:45 +02:00
Johann-S
764bab2941 remove polyfills which override browsers default 2019-02-20 22:05:45 +02:00
XhmikosR
f0c6b24bd7 4.3.1. 2019-02-20 22:05:45 +02:00
Joshua Wilson
fdbb5db919 minor jQuery.hasclass removal (#28158) 2019-02-20 22:05:45 +02:00
Peter Blazejewicz
cbd333185e Use consistent arrow class (#28105) 2019-02-20 22:05:45 +02:00
Emil Müller
049a500d18 Fixed Util.jQuery: window.$ is not reliable. Both Firefox and Chrome implements $ natively. 2019-02-20 22:05:45 +02:00
Johann-S
c096e0e0da bump to 4.2.1 2019-02-20 22:05:45 +02:00
Johann-S
661db08eeb rewrite toast plugin without jquery 2019-02-20 22:05:45 +02:00
Johann-S
57d50b2134 Improve manipulator coverage 2019-02-20 22:05:45 +02:00
Alessandro Chitolina
6cfc78f2d9 Remove IE support and button bsChecked hack 2019-02-20 22:05:45 +02:00
Johann-S
a2f1d79045 Refactor util plugin and some tests 2019-02-20 22:05:45 +02:00
Johann-S
c44db783bf chore(update): bump to 4.1.3 2019-02-20 22:05:45 +02:00
Johann-S
467dd113c5 fix(plugins): save instance in constructor 2019-02-20 22:05:45 +02:00
Johann-S
5dcca44fcf fix(visual-test): remove jquery in them 2019-02-20 22:05:45 +02:00
Johann-S
0b726de94e fix(carousel): on load page create a carousel 2019-02-20 22:05:45 +02:00
Johann-S
6b0808354d fix(unit-test): dropdown, collapse and carousel 2019-02-20 22:05:45 +02:00
Johann-S
8010c010e9 fix(event-handler): use Object.key for passing values in an event 2019-02-20 22:05:45 +02:00
Johann-S
a1cc9a6e33 fix(util): increase util coverage 2019-02-20 22:05:45 +02:00
Johann-S
096413a994 fix(selector-engine): increase coverage for selector engine 2019-02-20 22:05:45 +02:00
Johann-S
4510e7e61d fix(util): remove extend 2019-02-20 22:05:45 +02:00
Johann-S
b4a3b00ac8 fix(event-handler): remove polyfill and move it to index 2019-02-20 22:05:45 +02:00
Johann-S
fe580a8e5a fix(polyfill): disable coverage for our polyfills 2019-02-20 22:05:45 +02:00
Johann-S
64591b3722 fix(manipulator): increase coverage for manipulator 2019-02-20 22:05:45 +02:00
Johann-S
4d6e41dea6 refactor(polyfill): a file for polyfills 2019-02-20 22:05:45 +02:00
Johann-S
0b719e065c fix(data): increase coverage for data 2019-02-20 22:05:45 +02:00
Johann-S
9313446274 fix(event-handler): remove the use of our event handler in unit test 2019-02-20 22:05:45 +02:00
Johann-S
2b78078779 fix(data): do not use data object in our unit tests 2019-02-20 22:05:45 +02:00
Johann-S
7eddee286e remove old references to jquery and some fixes 2019-02-20 22:05:45 +02:00
Alessandro Chitolina
0263d1742c rewritten scrollspy without jquery 2019-02-20 22:05:45 +02:00
Johann-S
9744886519 upgrade to v4 stable 2019-02-20 22:05:45 +02:00
Alessandro Chitolina
7f08061eca rewritten tab without jquery 2019-02-20 22:05:45 +02:00
Johann-S
90261b484c Dropdown without jQuery 2019-02-20 22:05:45 +02:00
Johann-S
330a29734f fix chores karma 2019-02-20 22:05:45 +02:00
Johann-S
2ff8ed5cbf Fix new unit test in popover 2019-02-20 22:05:45 +02:00
Alessandro Chitolina
ec69de4b7e allow register the same handler for different delegated selectors in eventHandler 2019-02-20 22:05:45 +02:00
Johann-S
99c3119c82 Return a new function with Util.noop 2019-02-20 22:05:45 +02:00
Johann-S
b5077a1a81 fix one forgets of using jQuery in Carousel and Tooltip 2019-02-20 22:05:45 +02:00
Johann-S
2929bf9619 fix weird case with jQuery 2019-02-20 22:05:45 +02:00
Alessandro Chitolina
cc6e130fc1 tooltip without jquery 2019-02-20 22:05:45 +02:00
Johann-S
7c1d0a1097 Wrap our objects into IIFE 2019-02-20 22:05:45 +02:00
Johann-S
bcbea02886 fix unit test modal 2019-02-20 22:05:45 +02:00