Julien Déramond
3515ac16a1
Docs: add missing aria-disabled='true'
to disabled anchors
2023-07-05 22:28:00 -07:00
Kyle Tsang
d5dee316f7
Update URL sanitizer to allow more protocols ( #38531 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2023-05-01 00:33:09 +03:00
Alejandro Mendoza
a06c2e6b5f
Fix scrollspy and accented anchor links ( #38502 )
2023-05-01 00:31:26 +03:00
XhmikosR
4f24144a31
dropdown.spec.js: expect nothing in constructor ( #38442 )
2023-04-11 18:03:34 +03:00
XhmikosR
ae43f0c48b
Tweak and re-organize ESLint config ( #38369 )
...
* Tweak and re-organize ESLint config
* merge individual configs to the root config
* enable more eslint-plugin-import rules
* lint markdown files
* Lint
2023-03-29 13:49:30 -04:00
Neeraj Kumar Das
6a043d95fa
Remove empty script tag ( #38233 )
2023-03-14 14:30:36 +02:00
Jan Bensch
e00d06e45b
Fix wrong generation of aria-labelledby
in tab navigation ( #38223 )
...
* fix wrong generation of aria-labelledby in tab navigation
* fix wrong test
---------
Co-authored-by: Jan Bensch <github@bensch.dev>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2023-03-14 06:50:08 +02:00
Julien Déramond
f44feabe16
Tests: remove unnecessary id
/aria-labelledby
from collapse unit tests ( #38089 )
2023-02-21 19:33:52 +01:00
Julien Déramond
f5f6c5c4e3
Minor fix to avoid creating void elements in tooltip test file ( #38034 )
2023-02-11 10:18:39 +01:00
Tanguy Krotoff
1369b81492
Fix Android Chrome input date dimensions ( #36143 )
...
* Bind Hugo to 0.0.0.0, helps debug on mobile when on the same network
* Use http-server for visual tests
* Add input visual tests
* Fix input date dimensions on Android Chrome
* Increase bootstrap.css max size
* Revert "Bind Hugo to 0.0.0.0" & "Use http-server for visual tests"
* Switch to pixels: this is an empirical minimum safe value
* Update .bundlewatch.config.json
Co-authored-by: Mark Otto <otto@github.com>
2023-01-17 21:09:39 -08:00
Louis-Maxime Piton
9042efd0f8
Deprecate the Sass var and remove any occurence of the .text-muted
( #37890 )
2023-01-16 15:55:28 -08:00
Patrick H. Lauke
0446e22b5a
Docs: use <button>
for dropdown/popover examples, explain preference over <a>
for dropdowns, tweak collapse prose ( #37432 )
...
* Expand dropdown explanation for use of `<a>`, use `<button>`s for modal examples
* Remove redundant `role="button"` from collapse test `<button>` elements
* Tweak language
* Tweak collapse prose
2022-11-12 09:21:33 -08:00
XhmikosR
5208dd10c4
ESLint: enable prefer-template rule ( #37484 )
2022-11-12 10:09:36 +02:00
Pierre Souchay
ef4e2daa48
Properly escape IDs in getSelector() to handle weird IDs ( #35565 ) ( #35566 )
2022-11-07 14:43:06 +02:00
GeoSot
e81e7cda90
Move getElementFromSelector
& getSelectorFromElement
to SelectorEngine ( #36027 )
...
* Move `getElementFromSelector` & getSelectorFromElement` inside selector-engine.js, in order to use SelectorEngine methods, avoiding raw querySelector usage
* add `getMultipleElementsFromSelector` helper
Co-authored-by: Julien Déramond <juderamond@gmail.com>
2022-11-06 20:31:43 +02:00
Julien Déramond
137c932e47
Docs: standardize usage of <kbd>
2022-10-12 11:45:46 -07:00
GeoSot
4cb046a6b8
Boost execute
function, being able to handle arguments ( #36652 )
2022-10-07 15:25:00 +03:00
Julien Déramond
1b3c38d2cd
Rename some vars in tab unit tests for consistency ( #37248 )
2022-10-03 17:44:37 +03:00
GeoSot
d49d8ce583
Ensure Tab keyboard functionality after #37146 ( #37200 )
...
* fix: keyboard functionality
* test: add tests
* Add some focus spies in 2 other unit tests
Co-authored-by: Julien Déramond <juderamond@gmail.com>
2022-10-02 13:05:30 +03:00
Patrick H. Lauke
0a5f6e078c
Use <h1>
for all modal-title
examples/uses ( #37210 )
...
* Use `fs-` font sizing classes where needed
* Also add info callout about heading hierarchy in modals
2022-10-02 13:02:36 +03:00
Julien Déramond
abb1cf529f
Add eslint-plugin-html to lint JS in HTML files ( #37186 )
2022-09-27 22:53:59 +03:00
GeoSot
597c402314
Dropdown: fix case with invalid markup ( #37190 )
...
This fixes a backward incompatible change in v5.2.1 where `.drodown-toggle` isn't present in the markup.
2022-09-27 10:39:11 +03:00
GeoSot
24f6e2764a
Tests: add testcase to Tabs, keyboard handler ( #37189 )
2022-09-23 22:18:57 +02:00
Carson Sievert
2b46842af9
Fix active class toggling of tabs within dropdown ( #37151 )
...
* Close #36947 : fix active class toggling tabs within dropdown
2022-09-22 02:29:58 +03:00
GeoSot
27f20257eb
Use es6 on visual tests ( #36915 )
2022-09-22 01:48:23 +03:00
GeoSot
1510c25e9b
Drop tabs auto-focus ( #37146 )
...
* fix: drop tabs auto-focus
2022-09-20 17:20:47 +03:00
XhmikosR
d0117a17d8
Update devDependencies ( #37177 )
2022-09-20 08:09:14 +03:00
Jérémie Broutier
6f65df4fae
Fix modal event listeners ( #37128 )
...
* Fix modal event listeners (#37126 )
Co-authored-by: GeoSot <geo.sotis@gmail.com>
2022-09-15 13:30:51 +03:00
GeoSot
3bd5756414
fix: add trick to support tooltip selector usage on dynamic created tooltips that utilize title
attribute ( #36914 )
2022-09-14 16:24:37 +03:00
GeoSot
23fb7a7915
Fix modal event-listeners during dismiss click ( #36863 )
...
ref: #36855
2022-09-07 11:56:33 +03:00
Louis-Maxime Piton
337068f8b1
fix(dropdowns): Fix multiple dropdowns when they are inside the same tag ( #37011 )
2022-09-02 10:52:33 +03:00
GeoSot
db86607c08
ScrollSpy: make the threshold option configurable ( #36750 )
...
* feat(ScrollSpy): make the threshold option configurable
2022-07-28 11:58:28 +03:00
GeoSot
dfae892801
Re-set tooltip title, on disposal ( #36751 )
...
fix(reg): Re-set tooltip title, on disposal
2022-07-27 17:40:05 +03:00
GeoSot
f451b4161e
Fix failing test on EventHandler ( #36772 )
2022-07-19 15:46:36 +03:00
Marc Wrobel
705d6857ad
Fix typos in code ( #36763 )
...
Shoutout is correct but has been replaced by its more common form : Shout-out (https://www.merriam-webster.com/dictionary/shout-out ).
2022-07-18 13:30:29 -07:00
Julien Déramond
aa8d0b3439
Standardization of spyOn
usage ( #36742 )
2022-07-15 16:52:03 +03:00
GeoSot
713d7140f1
Offcanvas: activate focustrap when backdrop is enabled ( #36717 )
...
* fix(offcanvas): activate focustrap when backdrop is enabled
* Adding tabindex='-1' for both offcanvases in the docs
* Remove useless aria-expanded='false' in togglers
* Update js/tests/unit/offcanvas.spec.js
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <juderamond@gmail.com>
Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk>
2022-07-14 10:06:06 +01:00
Nathan Walters
3f324eed02
Handle non-empty whitespace textContent
in Tooltip trigger ( #36588 )
2022-07-06 07:15:50 +02:00
Julien Déramond
c1813ef2bc
ref(tests): Minor fix to use self-closing input HTML tag ( #36667 )
2022-07-04 14:12:10 +03:00
Aleksander Machniak
505e0235b9
Fix interoperability issue regarding Event properties ( #36386 )
...
* Fix interoperability issue regarding Event properties
- make possible to re-set read-only event properties
- use hydrateObj() to set delegateTarget property
Fixes #36207
Co-authored-by: GeoSot <geo.sotis@gmail.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
2022-06-30 22:52:47 +03:00
GeoSot
4f4b42dd14
Force tooltip and popover to recreate content every time it opens ( #35679 )
2022-06-27 12:58:27 +03:00
GeoSot
f14c58f494
ref(tab): remove show from panels dependent-less they have .fade
class or not (simplify checks) ( #36622 )
2022-06-27 12:43:11 +03:00
GeoSot
d05c42a397
fix: change dismiss handler, listening to key down, instead of click ( #36401 )
2022-06-21 11:03:57 +03:00
GeoSot
fc24f8788f
Carousel: Remove redundant reference to interval=false
from docs ( #36545 )
...
* docs: remove redundant reference to `interval=false`
* docs: remove redundant reference to `interval=false` from tests
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2022-06-14 16:17:28 +03:00
Julien Déramond
ae3442041c
Fix typo in dropdown unit test
2022-06-08 15:23:03 -07:00
GeoSot
37cf7d11b9
Scrollspy: enable smooth-scroll behavior ( #36528 )
2022-06-08 22:35:09 +03:00
Patrick H. Lauke
8965b11dd5
Remove confusing unnecessary id/aria-labelledby for dropdown menus ( #36487 )
...
see https://github.com/twbs/bootstrap/discussions/35755
Note that even the APG guide for disclosure widgets doesn't use this optional "nice-to-have" extra bit https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/ (though they do use `aria-controls`, which in most current browser/AT combos is borked though)
2022-06-03 11:18:22 +01:00
Louis-Maxime Piton
d388bd6e1b
JS: tests fixes & standardization of spies usage ( #36398 )
...
* Fix carousel spec typo
* Change carousel test name in align with testing method
* Make the spies declarations the same everywhere
2022-05-31 11:18:32 +03:00
Louis-Maxime Piton
8959bf3f0b
Docs: quick fixes for HTML ( #36395 )
...
* Using the new helper in the doc
* Remove input from `Tab` access
* Change scrollspy code examples
* Reordering tables for JS
* Fix for parcel file
* Center align all the code example texts in layout
* Alphabetical reorder the helpers
2022-05-20 10:21:48 -07:00
GeoSot
b167420bdf
Revert backdrop utilization, handling clicks over modal ( #36324 )
...
* refactor(Modal.js): stop using backdrop class to handle clicks over modal
* Revert #35554 and backdrop callback usage
Explanation: In order to bypass `.modal`, was applied a css rule `pointer-events:none` which caused the side effect, and user couldn't scroll "long content modals"
* Update .bundlewatch.config.json
Co-authored-by: Mark Otto <markd.otto@gmail.com>
2022-05-12 21:20:04 -07:00