0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-13 01:08:58 +01:00
Commit Graph

128 Commits

Author SHA1 Message Date
Rohit Sharma
87a8ba9a82 Change from preventOverflow to detectOverflow
- Since the link is for detectOverflow docs
2021-04-18 21:23:31 -07:00
Mark Otto
d25920b182 Fix toggle between modals example 2021-04-17 16:08:58 -07:00
ghost_32
95aec47d21
Docs: Tried to fix the issue #33650 (#33664)
Prefixed the `aria-controls` with `list-` to match with `tabpanel`
ids in `Javascript behavior` example in `List Group Component`.
2021-04-17 14:40:43 -07:00
Peter Hartree
cb24272544
Add example: Panels stay open (#33553)
* Add example: Panels stay open

* Set unique element IDs in the new example

* Update language

Co-authored-by: Mark Otto <markd.otto@gmail.com>
Co-authored-by: Mark Otto <otto@github.com>
2021-04-14 13:43:52 -07:00
Danny Trunk
1de0d94130 Fixed wrong method name _getInstance
There is no _getInstance method, but there is a getInstance method
2021-04-06 21:51:01 -07:00
Mark Otto
056ad3ad95
Add offcanvas-top modifier (#33549) 2021-04-04 11:11:33 -07:00
Mark Otto
90c9059784
Clarify docs accordion example (#33522) 2021-03-31 09:01:01 +03:00
Mark Otto
232e392c91
Make offcanvas example fully static (#33446) 2021-03-23 19:06:11 +02:00
GeoSot
1c02ef4f97
Allow offcanvas to be initialized in open state (#33382)
* Update docs to use new .show behavior and clarify some copy for first example

Co-authored-by: Mark Otto <markdotto@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-03-23 08:22:59 +02:00
Anton
fcac2e3aa6
Add example: toggle modal dialogs (#33301)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markdotto@gmail.com>
2021-03-16 22:15:06 -07:00
GeoSot
ddf72bc612
Accept data-bs-body option in the configuration object as well (#33248)
* Accept data-bs-body option in the configuration object as well

Tweak jqueryInterface, add some more tests

* Fix Markdown table formatting and tweak the wording on backdrop

Co-authored-by: Mark Otto <markdotto@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-03-16 18:35:03 +02:00
Anton
af42557f4a
Update modal's show method to accept relatedTarget as an argument (#33300)
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-03-16 07:49:52 +02:00
Mark Otto
5c6e72c6fe Change from element selector to the opt-in class 2021-03-10 22:04:32 -08:00
Mark Otto
defce83027 Add ol.list-group with psuedo-element numbers 2021-03-10 22:04:32 -08:00
GeoSot
548be2ed66
Offcanvas as component (#29017)
* Add a new offcanvas component

* offcanvas.js: switch to string constants and `event.key`

* Remove unneeded code

* Sass optimizations

* Fixes

Make sure the element is hidden and not offscreen when inactive
fix close icon negative margins
Add content in right & bottom examples
Re-fix bottom offcanvas height not to cover all viewport

* Wording tweaks

* update tests and offcanvas class

* separate scrollbar functionality and use it in offcanvas

* Update .bundlewatch.config.json

* fix focus

* update btn-close / fix focus on close

* add aria-modal and role
return focus on trigger when offcanvas is closed
change body scrolling timings

* move common code to reusable functions

* add aria-labelledby

* Replace lorem ipsum text

* fix focus when offcanvas is closed

* updates

* revert modal, add tests for scrollbar

* show backdrop by default

* Update offcanvas.md

* Update offcanvas CSS to better match modals

- Add background-clip for borders
- Move from outline to border (less clever, more consistent)
- Add scss-docs in vars

* Revamp offcanvas docs

- Add static example to show and explain the components
- Split live examples and rename them
- Simplify example content
- Expand docs notes elsewhere
- Add sass docs

* Add .offcanvas-title instead of .modal-title

* Rename offcanvas example to offcanvas-navbar to reflect it's purpose

* labelledby references title and not header

* Add default shadow to offcanvas

* enable offcanvas-body to fill all the remaining wrapper area

* Be more descriptive, on Accessibility area

* remove redundant classes

* ensure in case of an already open offcanvas, not to open another one

* bring back backdrop|scroll combinations

* bring back toggling class

* refactor scrollbar method, plus tests

* add check if element is not full-width, according to #30621

* revert all in modal

* use documentElement innerWidth

* Rename classes to -start and -end

Also copyedit some docs wording

* omit some things on scrollbar

* PASS BrowserStack tests

-- IOS devices, Android devices and Browsers on Mac, hide scrollbar by default and appear it, only while scrolling.

* Rename '_handleClosing' to '_addEventListeners'

* change pipe usage to comma

* change Data.getData to Data.get

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
Co-authored-by: Mark Otto <markdotto@gmail.com>
2021-03-02 19:10:10 +02:00
Rohit Sharma
b9e51dc3c4
Dropdown — Drop flip option (#33198) 2021-03-02 17:27:13 +02:00
Patrick H. Lauke
5693f1ad86
Fix small typos / follow-up to #32630 (#33164) 2021-02-21 08:00:03 +02:00
Mark Otto
5c32767e0e
Clarify docs around .navbar-brand (#33123)
- Add new headings and text for each example
- Fixes #33072 by changing align-* class
2021-02-17 05:58:26 +02:00
Siju Samson
51c7075c1c
Fix typo in nav-tabs docs (#33081) 2021-02-15 08:45:34 +02:00
Gaël Poupard
0a9d392975
Docs improvements after beta2 (#33049)
* docs(carousel): double-spaces out there

* docs(toasts): missing word, ins't it?

* docs(cheatsheet): use buttons for carousels and tabs ion cheatsheets too

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-11 19:48:08 +02:00
Mark Otto
4c7a3e8adf
Add Sass docs (variables, mixins, and loops) to most pages (#32747)
* WIP: Mention variables, mixins, and loops in docs

* Add Sass sections to component pages

* add sass docs for forms and content

* Update buttons.md

* Remove empty mixins sections

* Massive update to utilities and some consistency changes

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-10 19:29:59 -08:00
Rohit Sharma
f7088e5d28
Add function type for popperConfig option (#32882)
* Add function type for `popperConfig` option

* Update .bundlewatch.config.json

* copy edits

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markdotto@gmail.com>
2021-02-09 21:16:13 +02:00
Mark Otto
8f1c882545 Remove .dropdown-menu[style] reset and adjust .dropdown-menu-* modifiers
- Removes the &[style] selector that was used for resetting Popper styles
- Separate Popper-based alignment from static alignment with `data-bs-popover` attribute that separates the --bs-position and custom right/left properties

Co-Authored-By: Rohit Sharma <rohit2sharma95@gmail.com>
2021-02-09 14:34:27 +02:00
Patrick H. Lauke
96be06e32b
Dynamic tabs: use buttons rather than links (#32630)
* Dynamic tabs: use buttons rather than links

- change docs
- add mention that tabs should be <button> elements
- tweak styles to neutralise border and background

* Update js unit and visual test accordingly

- replace links with buttons
- make one specific test that uses links instead of buttons, as we still want to support it despite it being non-semantically appropriate
- Leaving a couple of tests for now. The test for removed tabs should be redone so that tabs are removed programmatically (as the approach of having that close button inside the link is invalid and broken markup). The test for dropdowns should be removed together we actually ripping out the handling for dropdowns in the tab.js code (arguably a breaking change, though we discouraged this for a few versions and effectively "deprecated" it)

* Add isolation:isolate to prevent focus being overlapped

https://github.com/twbs/bootstrap/pull/32630#issuecomment-756015766
2021-02-09 07:23:45 +02:00
Rohit Sharma
b6cae91893
Add a note to change the case type of option name (#32995) 2021-02-08 16:55:47 +02:00
Kyle Tsang
22d8e34b3e
Fix boundary config description for dropdown and popover (#32979) 2021-02-04 07:26:32 +02:00
Rohit Sharma
3770b7b9e3
Dropdown — Emit events on the .dropdown-toggle button (#32625)
* Emit events on the dropdown button

Emit the events on `.dropdown-toggle` button and then bubble up

* Add migration note for events

* Update the docs for events

* Add unit test to check the event bubbling

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-03 21:51:19 +02:00
Rohit Sharma
217d84d6b2
Remove the initial margin from dropdown/popover in favor of Popper (#32524)
* Remove the margin from dropdown in favor of Popper

- Set the default margin to 0 for dropdowns (To remove the Popper's  warning)
- Set the required offset in dropdown's defaults

* Remove the margin from the popover component

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-03 21:37:25 +02:00
Mark Otto
88be1ce502 Update docs for color and bg utilities
- Split colors from background utilities with new docs page
- Add Sass docs for both pages
2021-02-03 07:15:49 +02:00
Patrick H. Lauke
a882614c45 Make carousel indicators actual buttons 2021-01-28 23:32:24 +02:00
Rohit Sharma
e036e604de Update docs for offset option 2021-01-28 12:23:33 +02:00
joke2k
881f43a3b9 Restore offset option for dropdown component 2021-01-28 12:23:33 +02:00
Patrick H. Lauke
3aa3fda730
Carousel: use buttons, not links, for prev/next controls (#32627)
* Carousel: use buttons, not links, for prev/next

- expand the styles to neutralise border/background
- change docs page
- add extra unit test to check that links or buttons work as controls
- modify visual test to use buttons as well
- use buttons instead of links for prev/next
- remove `role="button"` from links that are actually links

* Clarify that controls can be button or link

* Update site/content/docs/5.0/components/carousel.md

Co-authored-by: Mark Otto <markd.otto@gmail.com>

* Explicitly set padding to 0 to prevent dipping/moving on active in Firefox

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-27 17:31:16 +02:00
Kyle Tsang
c6d6160a7c
docs: Fix navbar-nav-scroll description (#32846) 2021-01-20 12:12:35 +02:00
Mark Otto
40b15de723
Add .navbar-nav-scroll for vertical scrolling of navbar content (#32037)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-19 07:32:18 +02:00
Mark Otto
4167c107f8
Add a live toast example to the docs (#32760) 2021-01-18 15:10:01 +02:00
Siju Samson
9bec37a77b
docs: work around Toast CSS conflict with utils (#32620)
* Toast CSS conflict resolved

* Update toasts.md

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-14 16:07:36 -08:00
Marcin Kasperski
408b2558dc
Update toasts.md (#32782)
* dropped mention of `backdrop-filter`
* changed mention of `.text-white` to `.btn-close-white` on close button
2021-01-13 19:05:25 +02:00
Florian Lacreuse
e635a49536
Fix navbar docs - active nav-link (#32589)
* Fix navbar docs - active nav-link

* Update navbar.md

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-07 09:24:57 +02:00
Patrick H. Lauke
d1a62b47c3
Tweak wording for no-touch carousel (#32688)
based on changes made in the backport https://github.com/twbs/bootstrap/pull/32639
2021-01-06 00:59:44 +00:00
Patrick H. Lauke
fd48a8732f
Remove incorrect mention of dropdowns for dynamic tab behavior (#32634)
While technically it still works, we're already saying authors shouldn't do it later on, and we removed any examples of this. This was a straggler.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-05 22:04:06 +02:00
Patrick H. Lauke
e1e6f5684e
Tweak the wording for collapse to indicate button is preferred/more semantic (#32632)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-05 21:53:50 +02:00
Patrick H. Lauke
b05145c951
Add an actual data-bs-touch="false" example in the carousel docs (#32638)
* Add an actual `data-touch="false"` example in the carousel docs

this can also make it easier to actually check/debug any issues we may have with this data attribute

* Correct attribute table explanation and remove slide class from example
2020-12-29 15:40:42 +02:00
Nils K
2d46e47464
Support Popper virtual elements (#32376)
Adds the ability to use objects implementing the virtual element interface as the value for the reference option of a dropdown config.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-21 14:32:11 +02:00
Florian Lacreuse
86802f701c
Add keyboard-focusable elements for popover on disabled button (#32490) 2020-12-20 20:28:58 +02:00
XhmikosR
d140f50b35
Tooltips: add missing space (#32529) 2020-12-20 17:12:22 +02:00
Florian Lacreuse
4e7c9e56fc
Fix popover docs example (#32489) 2020-12-15 17:27:06 +02:00
Kyle Tsang
9b6c815148
docs: Remove unneeded .form-group class (#32483) 2020-12-15 09:21:25 +02:00
Florian Lacreuse
e8d14b302e
Remove redundant pointer-events: none override for tooltip and popover disabled buttons (#32478)
Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-15 09:17:58 +02:00
Rohit Sharma
042a4a255f
Tooltip/popover - change the default value for fallbackPlacements (#32437)
The default Popper `fallbackPlacements` value is `[oppositePlacement]`.

- The default value was previously (in v4) `'flip'` that can be achieved by passing the single value in the array, like — `[oppositePlacement]`. Keeping `null` also sets the `fallbackPlacements` to `[oppositePlacement]` (Default value in Popper)
- It's better to have **clockwise** (`['top', 'right', 'bottom', 'left']`) fallback options so that tooltip/popover can be placed to another side even if the opposite placement doesn't fit.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-14 20:51:14 +02:00