0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-10 22:24:19 +01:00
Commit Graph

329 Commits

Author SHA1 Message Date
Garrett Johnson
a49d1e3e58 Fix Flex utilities to add vertical space in example
The `justify-content-around` example is missing a `mb-3` class because it is not the last example.
2021-03-10 17:23:24 -08:00
Martin Choutka
a245ef46e2 Update the "Nonblocking files" section in the docs
Added few paragraphs about optimizing FCP times, deferring non-critical JS and CSS, may update in the future again
2021-03-10 08:57:50 -08:00
GeoSot
548be2ed66
Offcanvas as component (#29017)
* Add a new offcanvas component

* offcanvas.js: switch to string constants and `event.key`

* Remove unneeded code

* Sass optimizations

* Fixes

Make sure the element is hidden and not offscreen when inactive
fix close icon negative margins
Add content in right & bottom examples
Re-fix bottom offcanvas height not to cover all viewport

* Wording tweaks

* update tests and offcanvas class

* separate scrollbar functionality and use it in offcanvas

* Update .bundlewatch.config.json

* fix focus

* update btn-close / fix focus on close

* add aria-modal and role
return focus on trigger when offcanvas is closed
change body scrolling timings

* move common code to reusable functions

* add aria-labelledby

* Replace lorem ipsum text

* fix focus when offcanvas is closed

* updates

* revert modal, add tests for scrollbar

* show backdrop by default

* Update offcanvas.md

* Update offcanvas CSS to better match modals

- Add background-clip for borders
- Move from outline to border (less clever, more consistent)
- Add scss-docs in vars

* Revamp offcanvas docs

- Add static example to show and explain the components
- Split live examples and rename them
- Simplify example content
- Expand docs notes elsewhere
- Add sass docs

* Add .offcanvas-title instead of .modal-title

* Rename offcanvas example to offcanvas-navbar to reflect it's purpose

* labelledby references title and not header

* Add default shadow to offcanvas

* enable offcanvas-body to fill all the remaining wrapper area

* Be more descriptive, on Accessibility area

* remove redundant classes

* ensure in case of an already open offcanvas, not to open another one

* bring back backdrop|scroll combinations

* bring back toggling class

* refactor scrollbar method, plus tests

* add check if element is not full-width, according to #30621

* revert all in modal

* use documentElement innerWidth

* Rename classes to -start and -end

Also copyedit some docs wording

* omit some things on scrollbar

* PASS BrowserStack tests

-- IOS devices, Android devices and Browsers on Mac, hide scrollbar by default and appear it, only while scrolling.

* Rename '_handleClosing' to '_addEventListeners'

* change pipe usage to comma

* change Data.getData to Data.get

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
Co-authored-by: Mark Otto <markdotto@gmail.com>
2021-03-02 19:10:10 +02:00
Rohit Sharma
b9e51dc3c4
Dropdown — Drop flip option (#33198) 2021-03-02 17:27:13 +02:00
Mark Otto
1df59bb17f
Add an example of v4's media component in the flex utils docs (#33207)
* Add an example of v4's media component in the flex utils docs

* Link to new example from Migration guide

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-03-02 16:08:32 +02:00
Gaël Poupard
bcda711849
docs(migration): duplicated 5.0.0-beta2 heading (#33178) 2021-02-22 17:05:59 +02:00
Rohit Sharma
dc5e3328c1
Allow constructors to accept a CSS selector (#32245)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <otto@github.com>
2021-02-22 09:01:04 +02:00
Patrick H. Lauke
5693f1ad86
Fix small typos / follow-up to #32630 (#33164) 2021-02-21 08:00:03 +02:00
Mark Otto
5c32767e0e
Clarify docs around .navbar-brand (#33123)
- Add new headings and text for each example
- Fixes #33072 by changing align-* class
2021-02-17 05:58:26 +02:00
XhmikosR
ca9087ba92
overview: add missing EOF newline (#33098) 2021-02-16 12:22:35 +02:00
k-utsumi
4d19e0e8a4
Clear duplicated class border-0 (#32925)
* Clear duplicated class `border-0`

* Update migration.md

Co-authored-by: Mark Otto <otto@github.com>
2021-02-16 08:05:09 +02:00
Gaël Poupard
b7bd094351
docs(examples): typo in offcanvas example in .bg-body (#33092)
Caught by pa11y-ci on Boosted (because of insufficient contrasts) ❤️
2021-02-15 21:06:57 +02:00
Siju Samson
51c7075c1c
Fix typo in nav-tabs docs (#33081) 2021-02-15 08:45:34 +02:00
Gaël Poupard
0a9d392975
Docs improvements after beta2 (#33049)
* docs(carousel): double-spaces out there

* docs(toasts): missing word, ins't it?

* docs(cheatsheet): use buttons for carousels and tabs ion cheatsheets too

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-11 19:48:08 +02:00
eldk
8125856272
Add Parcel Bundler doc (#30909)
* Add Parcel Bundler doc

* Update parcel.md

* Improve parcel.md

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
2021-02-11 08:22:20 +02:00
Mark Otto
4c7a3e8adf
Add Sass docs (variables, mixins, and loops) to most pages (#32747)
* WIP: Mention variables, mixins, and loops in docs

* Add Sass sections to component pages

* add sass docs for forms and content

* Update buttons.md

* Remove empty mixins sections

* Massive update to utilities and some consistency changes

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-10 19:29:59 -08:00
Rohit Sharma
f7088e5d28
Add function type for popperConfig option (#32882)
* Add function type for `popperConfig` option

* Update .bundlewatch.config.json

* copy edits

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markdotto@gmail.com>
2021-02-09 21:16:13 +02:00
Mark Otto
d56992b6d2 Mention dropdown static change in Migration guide
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
2021-02-09 14:34:27 +02:00
Mark Otto
8f1c882545 Remove .dropdown-menu[style] reset and adjust .dropdown-menu-* modifiers
- Removes the &[style] selector that was used for resetting Popper styles
- Separate Popper-based alignment from static alignment with `data-bs-popover` attribute that separates the --bs-position and custom right/left properties

Co-Authored-By: Rohit Sharma <rohit2sharma95@gmail.com>
2021-02-09 14:34:27 +02:00
Philip Kiely
96b86c1f58
Docs on enforcing HTTPS and avoiding mixed content (#33017)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-09 07:54:16 +02:00
Patrick H. Lauke
96be06e32b
Dynamic tabs: use buttons rather than links (#32630)
* Dynamic tabs: use buttons rather than links

- change docs
- add mention that tabs should be <button> elements
- tweak styles to neutralise border and background

* Update js unit and visual test accordingly

- replace links with buttons
- make one specific test that uses links instead of buttons, as we still want to support it despite it being non-semantically appropriate
- Leaving a couple of tests for now. The test for removed tabs should be redone so that tabs are removed programmatically (as the approach of having that close button inside the link is invalid and broken markup). The test for dropdowns should be removed together we actually ripping out the handling for dropdowns in the tab.js code (arguably a breaking change, though we discouraged this for a few versions and effectively "deprecated" it)

* Add isolation:isolate to prevent focus being overlapped

https://github.com/twbs/bootstrap/pull/32630#issuecomment-756015766
2021-02-09 07:23:45 +02:00
Rohit Sharma
b6cae91893
Add a note to change the case type of option name (#32995) 2021-02-08 16:55:47 +02:00
Kyle Tsang
22d8e34b3e
Fix boundary config description for dropdown and popover (#32979) 2021-02-04 07:26:32 +02:00
Rohit Sharma
3770b7b9e3
Dropdown — Emit events on the .dropdown-toggle button (#32625)
* Emit events on the dropdown button

Emit the events on `.dropdown-toggle` button and then bubble up

* Add migration note for events

* Update the docs for events

* Add unit test to check the event bubbling

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-03 21:51:19 +02:00
Stanisław Gregor
203b3e218c
Fix default value for $enable-deprecation-messages (#32940)
* Update the default value for $enable-deprecation-messages

As seen in the https://github.com/twbs/bootstrap/blob/main/scss/_variables.scss,
the $enable-deprecation-messages variable is set to `true` by default.

* Update site/content/docs/5.0/customize/options.md

Co-authored-by: Gaël Poupard <ffoodd@users.noreply.github.com>

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Gaël Poupard <ffoodd@users.noreply.github.com>
2021-02-03 21:40:05 +02:00
Rohit Sharma
217d84d6b2
Remove the initial margin from dropdown/popover in favor of Popper (#32524)
* Remove the margin from dropdown in favor of Popper

- Set the default margin to 0 for dropdowns (To remove the Popper's  warning)
- Set the required offset in dropdown's defaults

* Remove the margin from the popover component

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-03 21:37:25 +02:00
Mark Otto
88be1ce502 Update docs for color and bg utilities
- Split colors from background utilities with new docs page
- Add Sass docs for both pages
2021-02-03 07:15:49 +02:00
Patrick H. Lauke
a882614c45 Make carousel indicators actual buttons 2021-01-28 23:32:24 +02:00
Rohit Sharma
e036e604de Update docs for offset option 2021-01-28 12:23:33 +02:00
joke2k
881f43a3b9 Restore offset option for dropdown component 2021-01-28 12:23:33 +02:00
Mark Otto
51ca9a9e2f
Update checks and radios in input groups (#32912)
- Adds .mt-0 to the examples
- Zero-ing out universally for all of them like in #32896 would cause issues for those who include the input with visible label text, where the text and input would be misaligned
2021-01-28 11:39:36 +02:00
Tobias Bengfort
e06ffa288f
migration: mention .form-text changes (#32911)
see #30598 and #30565
2021-01-28 08:05:05 +02:00
Patrick H. Lauke
3aa3fda730
Carousel: use buttons, not links, for prev/next controls (#32627)
* Carousel: use buttons, not links, for prev/next

- expand the styles to neutralise border/background
- change docs page
- add extra unit test to check that links or buttons work as controls
- modify visual test to use buttons as well
- use buttons instead of links for prev/next
- remove `role="button"` from links that are actually links

* Clarify that controls can be button or link

* Update site/content/docs/5.0/components/carousel.md

Co-authored-by: Mark Otto <markd.otto@gmail.com>

* Explicitly set padding to 0 to prevent dipping/moving on active in Firefox

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-27 17:31:16 +02:00
Vino Rodrigues
ba30df146c Replace .bg-white with .bg-body in docs
Response to issue #32810

Use of the .bg-white class to define visual aspects of the examples
would be unintuitive for theme builders to test themes on.
This replaces instances of .bg-white with .bg-body in the examples.

- Edited examples to replace use .bg-white class with .bg-body class
  - product
  - offcanvas
  - pricing
  - cheatsheet
  - cheatsheet-rtl
- Edited utilities colors.md & shadows.md to include .bg-body class
2021-01-25 14:34:01 -08:00
Kyle Tsang
c6d6160a7c
docs: Fix navbar-nav-scroll description (#32846) 2021-01-20 12:12:35 +02:00
Mark Otto
40b15de723
Add .navbar-nav-scroll for vertical scrolling of navbar content (#32037)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-19 07:32:18 +02:00
Mark Otto
4167c107f8
Add a live toast example to the docs (#32760) 2021-01-18 15:10:01 +02:00
Mark Otto
803e49d928
Clarifies Sass variable defaults, adds bootstrap-npm-starter callout (#32795)
* Clarify Sass import and customize docs for how to modify variable defaulst

* Add an npm starter project callout to a few pages

* Update callout-info-npm-starter.md

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-14 16:21:21 -08:00
Siju Samson
9bec37a77b
docs: work around Toast CSS conflict with utils (#32620)
* Toast CSS conflict resolved

* Update toasts.md

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-14 16:07:36 -08:00
Patrick H. Lauke
949fa30152
Remove role="button" from CTA links in carousel examples (#32788)
They're links, acting as links. Just because they're styled as buttons visually doesn't mean they need/get `role="button"`
2021-01-14 01:54:25 +02:00
voltaek
f7d3870567
Docs v5: Fix Sass rounding precision and state Sass implementation (#32512)
* Add Sass section to Getting Started > Build Tools, mention Sass implementation used, mention current precision of 10 due to Dart Sass, and mention recommended minimum precision (value of 6 used in BS v4). Remove outdated Sass precision from Customize > Sass docs page.

* Remove more mentions of deprecated Sass implementations. Add links to Sass compiler mentions so we can keep all pertinent Sass compiler information in just one location instead of spread through the docs, which makes it hard to find the details and/or keep them up-to-date.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-14 00:41:42 +02:00
Mark Otto
80c0d4deab
Add mention of CSPs and SVGs (#32759)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-14 00:15:18 +02:00
Mark Otto
d21fb9b627
Document some basic code conventions for us (#32778)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-13 21:06:07 +02:00
Gaël Poupard
20a9d491a2
Improve docs regarding RTL migration (#32771)
* docs(migrations): add a note regarding migration from v4 used for RTL layouts

* docs(RTL): LTR & RTL at the same time

* docs(utilities): how-to use the API to rename utilities

* docs(RTL): mention issue when nesting styles with .ltr / .rtl
2021-01-13 21:01:36 +02:00
ghost_32
82e5fe2d8c
Migration: mention the removal of .rounded-sm/lg utilities (#32758)
* Changes made in migration.md file of documentation

Added information about the removal of `.rounded-sm` and `.rounded-lg`.
And addition of `.rounded-0` to `.rounded-3`

* Moved the edited line

Added `rounded-0` to `rounded-3` under  v5.0.0-alpha3

* Moved correctly

* Added link

Added link to issue #31687

* docs(migration): last typo thinggies

* Update migration.md

Co-authored-by: Gaël Poupard <ffoodd@users.noreply.github.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-13 09:18:56 -08:00
Mark Otto
05249c8c04
Document size and multiple aren't supported on floating label selects (#32744)
* Document size and multiple aren't supported on floating label selects

Closes #32660

* Update floating-labels.md
2021-01-13 09:15:05 -08:00
Marcin Kasperski
408b2558dc
Update toasts.md (#32782)
* dropped mention of `backdrop-filter`
* changed mention of `.text-white` to `.btn-close-white` on close button
2021-01-13 19:05:25 +02:00
Mark Otto
69afafe811
Mention stretched-link constraints with table elements (#32761)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-12 15:33:58 +02:00
Brian Thompson
ee8546da18
Fix typo (#32740)
* Fix typo

* Rewrite description to avoid awkward phrasing

Co-authored-by: Mark Otto <otto@github.com>
2021-01-09 13:06:41 -08:00
Théophile Helleboid - chtitux
80557b3ac0
Move "active" class from .nav-item to .nav-link (#32730) 2021-01-08 20:53:04 +02:00