muzige2000
3af4560c67
Modals: Fix bad paddingRight calculation; fixes #17399
...
We want to sum two numbers, not concatenate their stringifications.
Closes #17457 by merging a tweaked version of it.
2015-09-03 01:25:38 -07:00
Gleb Mazovetskiy
c7d8e7a077
Accept elements as the tooltip / popover content
...
When a DOM node is passed to an HTML tooltip, the `title` node is only
moved if it is not already in the tooltip. Otherwise, `empty()` is used
instead of `detach()` before appending the `title` to avoid memory
leaks. If a DOM node is passed to a plain text tooltip, its text is
copied via jQuery `.text()`.
Replaces `.detach()` with `.empty()`, as `.detach()` is almost never
useful but instead leaks memory. The difference between `empty` and
`detach` is that the latter keeps all the attached jQuery events/data.
However, since we do not return the previous children, the user would
have to keep these themselves, thus they can `detach()` if necessary.
This is a port of https://github.com/twbs/bootstrap/pull/14552 to v4.
2015-08-31 01:06:13 +01:00
XhmikosR
4dd9a5a6dc
Update QUnit to v1.18.0.
2015-08-27 08:15:19 +03:00
XhmikosR
13e33e329c
Remove the obsolete JSHint references.
2015-08-27 08:11:11 +03:00
Chris Rebert
d06f79e2f7
grunt babel:dev
2015-08-26 01:27:45 -07:00
Jelle Versele
54c4eb950b
fixes #17097 : Go back to using jQuery's text and html methods since innerText is nonstandard and not present in Firefox
...
Closes #17272 by merging a tweaked version of it.
[skip validator]
2015-08-26 01:00:46 -07:00
XhmikosR
7e2eb9e74a
js/.eslintrc: sort rules by name.
...
[ci skip]
2015-08-25 08:45:07 +03:00
Heinrich Fenkart
73a88dbe86
Docs: Update all dropdowns to new HTML structure
2015-08-21 00:18:55 +02:00
Boris Kaiser
463837c1c7
Remove duplicate "spaced-comment" in eslintrc
...
Closes #17100
2015-08-20 01:27:47 -07:00
lbryant
8b15b5a262
_removeTetherClasses is no longer referenced
2015-08-20 01:22:16 -04:00
lbryant
926fb11158
use Tether addTargetClasses: false option instead of manually removing them
2015-08-20 01:03:29 -04:00
Jacob Thornton
03e732708c
rewrite tab with new active shit
2015-08-18 22:03:34 -07:00
Jacob Thornton
4e45e2363c
Merge branch 'v4' of github.com:twbs/derpstrap into v4
2015-08-18 21:23:53 -07:00
Jacob Thornton
fd65b9f32e
some minor alert shit
2015-08-18 20:33:57 -07:00
Mark Otto
1c19ded8c1
Merge branch 'v4' of https://github.com/twbs/derpstrap into v4
2015-08-18 20:25:48 -07:00
Jacob Thornton
8cfde5ef29
fix modal visual example for js
2015-08-18 19:50:32 -07:00
Jacob Thornton
efae761c39
fix dropdown js visual example
2015-08-18 19:42:27 -07:00
Jacob Thornton
18ff57a183
js tests passing + eslint
2015-08-18 19:22:46 -07:00
Mark Otto
15b7ce59df
grunt
2015-08-18 18:45:12 -07:00
Jacob Thornton
f1827e5f9c
add polyfil for bind for tether.js
2015-08-18 17:06:17 -07:00
Jacob Thornton
19e43b62ed
use proxy not bind in alert
2015-08-18 17:01:56 -07:00
Jacob Thornton
05c7a37507
fix dropdown test
2015-08-15 12:17:13 -07:00
Jacob Thornton
c830956d17
change modal.js to use is-fixed classes to target padding-right
2015-08-15 12:10:24 -07:00
Jacob Thornton
11abb0f7e9
fix modal
2015-08-12 21:12:03 -07:00
Jacob Thornton
23d05f1585
get the js working for docs
2015-08-12 19:59:55 -07:00
Mark Otto
1ddc3f5e21
Merge branch 'master' into v4m
2015-08-04 22:29:45 -07:00
Johann-S
ef1ce9ac0b
Fix triggering of {shown,hidden}.bs.dropdown events so relatedTarget gets set properly
...
Fixes #16828
Closes #16865
2015-07-27 00:58:51 -07:00
Melinda Sarnicki Bernardo
cebea5b6f6
Removes unnecessary period at end of comment
2015-07-02 19:30:11 -07:00
Mark Otto
169d2a4a78
Merge branch 'master' into v4
2015-06-18 23:56:43 -07:00
Mark Otto
83bfff7f07
bump version
2015-06-16 09:10:22 -07:00
Patrick H. Lauke
5fd7bc1554
generalize dropdowns / drop role="menu"
...
as role="menu" is a very specific (and strict) ARIA pattern for
desktop-like application menus, and our dropdowns are often used
as pure navigation dropdowns, this change abandons ARIA menus for
a more open-ended and light-weight approach
(see http://heydonworks.com/practical_aria_examples/#submenus and
http://www.w3.org/WAI/tutorials/menus/flyout/#improve-screen-reader-support-using-wai-aria )
note that in dropdown.js, switched to now target ``.dropdown-menu``
instead of ``role["menu"]`` - this also prevents bootstrap scripts
from "bleeding" into non-bootstrap components on the same page.
also removed the ``role=["listbox"]`` part, which appears to be
vestigial/unused (only place in bootstrap that uses that
role are carousels, and their key handling is done separately)
2015-06-02 11:03:21 +01:00
XhmikosR
315907c97c
Use https when possible.
2015-05-17 12:43:20 +03:00
fat
6b2b0ed32f
al tests passing, dist rebuilt, w/typechecker
2015-05-13 14:52:46 -07:00
fat
eaab1def7a
add simple type checker implementation
2015-05-13 14:46:50 -07:00
fat
c2ced2292a
fix up tests
2015-05-13 13:46:08 -07:00
fat
b0d142334f
fix #15301
2015-05-13 13:43:56 -07:00
fat
7ef0e52fd0
add "focus" option for turning off modal focusing #16050
2015-05-13 13:22:26 -07:00
fat
da495ee24c
address https://github.com/twbs/bootstrap/pull/16135
2015-05-13 13:15:11 -07:00
fat
f8b2569ec8
implement global dispose method
2015-05-13 12:48:34 -07:00
fat
6b251582d6
update attachment -> placement
2015-05-12 16:54:21 -07:00
fat
ab1578465a
grunt test-js, grunt dist-js now working
2015-05-12 16:52:54 -07:00
fat
a58febf71a
popover passing as well
2015-05-12 14:35:00 -07:00
fat
3452e8dc83
rewritten tooltip + tether integration and death to our positioner jank
2015-05-11 23:32:37 -07:00
fat
8eee78ca15
tab es6
2015-05-11 12:29:06 -07:00
fat
2d91494d96
scrollspy es6
2015-05-11 12:05:35 -07:00
fat
ca9c850ebb
add getters for Version and Default where applicable
...
add modal my gawd
2015-05-10 19:45:38 -07:00
fat
bbb97a8660
add dropdown
2015-05-10 13:47:11 -07:00
fat
8bab38bb71
add collapse
2015-05-09 23:04:58 -07:00
XhmikosR
1eba173c9e
Update jQuery to v1.11.3.
2015-05-10 01:22:23 +03:00
fat
1b183e2ff7
carousel -> es6
2015-05-07 22:26:40 -07:00
fat
6605051882
button -> es6
2015-05-07 17:14:38 -07:00
fat
c3a79b1a8c
change the export pattern to protect against leaking globals
2015-05-07 16:34:28 -07:00
fat
0724bd91ff
es6 alert :|
2015-05-07 12:57:31 -07:00
fat
d1fbe200f4
remove closureness from plugins
2015-05-06 13:34:14 -07:00
XhmikosR
a2f81ceb57
phantom.js: switch to unicode characters that work on Windows too.
2015-05-05 06:58:54 +03:00
XhmikosR
49c4556354
Comply to the new JSCS rules.
2015-05-05 06:50:18 +03:00
XhmikosR
93785be2c6
Update JSCS rules.
2015-05-05 06:50:18 +03:00
Chris Rebert
aa2c5b5672
Merge pull request #16014 from redbmk/issue-16008
...
Multiple tooltip triggers don't play well together
2015-05-04 15:07:17 -07:00
Patrick H. Lauke
a254782ca4
Merge pull request #16404 from patrickhlauke/radio-checkbox-kbd-toggle-fix
...
Fix radio and checkbox keyboard handling in .btn-group
2015-05-03 17:05:12 +01:00
Carlo Stearns
0689117f13
Fix issue where affixed element has incorrect positioning
...
when used with a sticky footer layout.
Adds visual test for affix with sticky footer.
Closes #15694 .
Refs #15032 .
2015-05-02 17:59:31 -07:00
Patrick H. Lauke
0c1daaf2ce
Remove broken/vestigial unit test
...
Overall logic for this test appears broken, possibly relating to an
older version of Bootstrap that did not require explicit
`data-toggle="button"` on single toggle buttons?
2015-05-01 12:58:10 +01:00
Patrick H. Lauke
f9cd88e09f
Fix radio and checkbox keyboard handling
...
Fix for problem that emerged from #16226 (`.active` class not actually
being applied) and expansion of the script to also correctly handle
keyboard interaction with checkboxes in `data-toggle="button"` groups
2015-05-01 12:19:19 +01:00
XhmikosR
3e7ca3bbc8
Minor lint tweaks.
2015-04-28 11:03:37 +03:00
Braden M. Kelley
4b269037cb
Multiple tooltip triggers don't play well together
...
Fixes issue #16008
2015-04-27 23:03:56 -07:00
F A T
aa479892d5
Merge pull request #16152 from jarthod/tooltip-placement-viewport-fix
...
Tooltip/popover: Fix auto placement to use viewport
2015-04-27 11:28:54 -07:00
Chris Rebert
cdb37dce3a
Set box-sizing: border-box on .container-viewport in #16142 testcase
...
Otherwise, the test doesn't properly fail when the fix is reverted.
2015-04-27 01:23:39 -07:00
Adrien
37a10d37c1
Compare tooltip right offset to viewport right offset (and not width)
...
Closes #16142 by merging it.
2015-04-27 01:13:16 -07:00
Chris Rebert
fc372952e2
Throw error when tooltip/popover template has multiple top-level elements
...
Closes #16219 .
2015-04-25 13:16:53 -07:00
Chris Rebert
0d77644fc4
throw error when trying to show tooltip on :hidden element
2015-04-23 17:14:45 -07:00
Adrien Siami
e949505b89
Allow viewport option to be a function
...
Closes #16151 by merging a rebased version of it that adds docs and 1 more assertion.
2015-04-21 22:20:15 -07:00
Chris Rebert
c6b62f0cd9
Merge pull request #16147 from Johann-S/event_inserted
...
Fixes #16124 .
2015-04-21 21:40:14 -07:00
Niels Steenbeek
7429fc7ff9
Tooltip: Destroy $tip, $arrow, $viewport to avoid memory leak
...
Closes #16039 .
2015-04-20 23:29:31 -07:00
Patrick H. Lauke
8549722846
Merge pull request #16226 from patrickhlauke/radio-toggle-kbd-fix
...
Fix radio button toggle behavior for keyboard users
2015-04-17 18:19:11 +02:00
Patrick H. Lauke
66d71136e6
Fix existing radio button unit test
2015-04-11 19:24:21 +02:00
Patrick H. Lauke
1b9baa0d98
Don't preventDefault radio buttons
...
as this breaks keyboard navigation for radio button toggles (see
https://github.com/twbs/bootstrap/issues/16223 )
2015-04-11 19:21:55 +02:00
Chris Rebert
b8935a5d0c
Use .dropdown-menu instead of ARIA roles for dropdown keydown event handler; fixes #16090
2015-04-08 19:20:15 -07:00
Johann-S
3d71eae301
Add event after template inserted
2015-04-08 13:10:53 +02:00
Adrien Jarthon
5921724d9c
fixed IE incompatible CSS
2015-03-29 19:16:59 +02:00
Adrien Jarthon
df96c3e615
Added non-regression test & fixed existing one
2015-03-29 14:59:21 +02:00
Mark Otto
58082cd83e
Merge branch 'master' into v4
...
Conflicts:
.gitignore
Gruntfile.js
_config.yml
dist/css/bootstrap-theme.css
dist/css/bootstrap-theme.min.css
dist/css/bootstrap.css
dist/css/bootstrap.css.map
dist/css/bootstrap.min.css
dist/js/bootstrap.js
dist/js/bootstrap.min.js
docs/_includes/components/navbar.html
docs/_includes/components/progress-bars.html
docs/_includes/css/grid.html
docs/_includes/css/overview.html
docs/_includes/customizer-variables.html
docs/_includes/getting-started/accessibility.html
docs/_includes/getting-started/browser-device-support.html
docs/_includes/getting-started/community.html
docs/_includes/getting-started/disabling-responsiveness.html
docs/_includes/getting-started/download.html
docs/_includes/getting-started/examples.html
docs/_includes/getting-started/license.html
docs/_includes/getting-started/third-party-support.html
docs/_includes/js/alerts.html
docs/_includes/js/buttons.html
docs/_includes/js/carousel.html
docs/_includes/js/collapse.html
docs/_includes/js/dropdowns.html
docs/_includes/js/modal.html
docs/_includes/js/popovers.html
docs/_includes/js/scrollspy.html
docs/_includes/js/tabs.html
docs/_includes/js/tooltips.html
docs/_includes/js/transitions.html
docs/_includes/nav/javascript.html
docs/_includes/nav/main.html
docs/about.html
docs/assets/css/docs.min.css
docs/assets/css/src/docs.css
docs/assets/js/customize.min.js
docs/assets/js/raw-files.min.js
docs/assets/js/src/customizer.js
docs/dist/css/bootstrap-theme.css
docs/dist/css/bootstrap-theme.min.css
docs/dist/css/bootstrap.css
docs/dist/css/bootstrap.css.map
docs/dist/css/bootstrap.min.css
docs/dist/js/bootstrap.js
docs/dist/js/bootstrap.min.js
docs/migration.html
js/affix.js
js/alert.js
js/button.js
js/carousel.js
js/collapse.js
js/dropdown.js
js/modal.js
js/popover.js
js/scrollspy.js
js/tab.js
js/tests/unit/affix.js
js/tests/unit/button.js
js/tests/unit/carousel.js
js/tests/unit/modal.js
js/tests/unit/tooltip.js
js/tests/visual/modal.html
js/tooltip.js
less/component-animations.less
less/jumbotron.less
less/mixins/background-variant.less
less/mixins/buttons.less
less/mixins/responsive-visibility.less
less/mixins/text-emphasis.less
less/navbar.less
less/navs.less
less/scaffolding.less
less/tooltip.less
less/utilities.less
less/variables.less
package.json
scss/_buttons.scss
scss/_forms.scss
scss/_modal.scss
2015-03-29 00:08:54 -07:00
Heinrich Fenkart
da63ff2e95
JSCS: Add "disallowSpacesInFunctionDeclaration"
...
Valid:
function a() {}
Invalid:
function a () {}
2015-03-26 18:28:17 +01:00
Chris Rebert
6c5e7dfce1
rm redundant aria-hidden usage from Modals; fixes #16020
2015-03-25 18:06:47 -07:00
Adrien Jarthon
0e8e5222ff
Tooltip/popover: Fix auto placement to use viewport
...
Currently, auto placement is using the container dimensions (if provided) or the element's parent to determine where to open the tooltip:
```javascript
var $container = this.options.container ? $(this.options.container) : this.$element.parent()
var containerDim = this.getPosition($container)
```
This is quite broken in fact, because the parent element could be just a small div outside the element for example, leading in a totally random placement (placing the tooltip on top even if there's no room). And the container can also be outside of the viewport.
This fix simply uses the viewport instead, that's the purpose of the viewport actually, to position the tooltip.
So the auto placement should use it to find where there's more room.
By default this is body, which is good.
2015-03-25 18:05:58 +01:00
Chris Rebert
d37bc2ae65
Merge pull request #15987 from twbs/fix-15972
...
add role="button" to a[data-toggle="collapse"]
2015-03-24 08:57:56 -07:00
Emmanuel Bourgerie
fa9d28b634
Fix #16072 : Clicking into input field within dropdown no longer closes the dropdown
...
Closes #16073 by merging it
2015-03-21 16:00:15 -07:00
Chris Rebert
9aad9a4164
Merge pull request #16024 from twbs/unnecessary-parsing
...
avoid unnecessary HTML string building+parsing
2015-03-18 22:28:07 -07:00
Chris Rebert
4d652035dc
v3.3.2 => v3.3.4
2015-03-16 08:39:31 -07:00
Maxim Andrukhovych
83371735fc
Fixed proper navigation element selection on backward scrolling (from the bottom to the top)
2015-03-10 20:04:15 +00:00
Chris Rebert
1383b88328
Merge pull request #16012 from twbs/refs-12761
...
Disable jQuery event aliases when running test suite
2015-03-09 17:47:51 -07:00
Chris Rebert
a14665e73e
avoid unnecessary HTML string building+parsing
2015-03-09 06:47:34 -07:00
Chris Rebert
a5243ad3d0
Affix: $('body') => $(document.body)
2015-03-09 06:43:41 -07:00
Chris Rebert
725c6848c3
Disable jQuery event aliases when running test suite
...
To ensure that we don't accidentally use any of the aliases.
This should prevent any future regressions from #12761 .
Also updates the test suite since it now can't use these aliases either.
2015-03-09 01:05:43 -07:00
Chris Rebert
21d56378e1
Merge pull request #16011 from twbs/fix-15315
...
.collapse('hide') on hidden uninit-ed collapsible no longer shows it
2015-03-09 01:03:27 -07:00
Chris Rebert
a134491fe5
add togglable scrollbar-inducing content to Modal visual test
2015-03-07 06:40:57 -08:00
Chris Rebert
6ddb8c2dd7
add static navbar to Modal visual test
2015-03-07 06:39:46 -08:00
Chris Rebert
64ca888cbc
Merge pull request #15999 from twbs/kkirsche-includeTestsReadme
...
Document JS test suite basics
2015-03-06 23:28:30 -08:00
Kevin Kirsche
ba2f7e92d0
[ Fixes #15951 ] Document JS test suite basics
...
X-Ref: #15953
Closes #15952 by merging a tweaked version of it.
[skip sauce]
[skip validator]
2015-03-06 23:27:00 -08:00
Chris Rebert
5c8d56d515
Collapse unit test: rm check that no-op hide adds style="height: 0px"
...
Appears to be unnecessary and is broken by #16011 ,
which is otherwise quite sane.
2015-03-06 18:10:53 -08:00
Chris Rebert
872e56fcf2
.collapse('hide') on hidden uninit-ed collapsible no longer shows it; fixes #15315
...
Thanks to @peterblazejewicz & @Nikita240
Adds unit tests based on #14417
X-Ref: #14282
Closes #15807
2015-03-06 06:58:48 -08:00
Chris Rebert
27bbc7dbe9
Hiding an uninitialized tooltip/popover no longer initializes it; fixes #15874
2015-03-03 22:22:13 -08:00
