0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-03 15:24:19 +01:00
Commit Graph

9 Commits

Author SHA1 Message Date
Patrick H. Lauke
aa06dffdf6
Disabled link cleanup (#34886)
* Disabled link cleanup

per https://www.w3.org/TR/html-aria/#docconformance

> It is NOT RECOMMENDED to use `aria-disabled="true"` on an `a` element with an `href` attribute.
>
>NOTE
>If a link needs to be "disabled", remove the `href` attribute.

This PR removes the unnecessary `href="#"`, `tabindex="-1"`, and `aria-disabled="true"` from disabled links in both docs pages and examples. `aria-disabled="true"` *is* kept for disabled link-based buttons (that have `role="button"`) as there it's appropriate to use (you *want* to convey to assistive technologies that this thing you're claiming is a button is also disabled at the moment)

Further, the PR extends the "Link functionality caveat" to show the "proper" way (removing `href` and adding `.disabled` class only) to disable a link, but then explains what to do if that's not possible (and then keeps an example with all the traditional `href="#" tabindex="-1" aria-disabled="true"`, but explains clearly that it's not ideal). Same sort of explanation is also added to the pointer event utilities page

* Turn big note into actual normal doc text

Co-authored-by: Mark Otto <markd.otto@gmail.com>

Co-authored-by: Mark Otto <markd.otto@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-09-06 22:14:21 +03:00
Julien Déramond
2a1aa2a9f4
Fix a11y issues in .hstack example and placeholder 'How it works' example (#34892) 2021-09-04 09:36:18 +03:00
Julien Déramond
a0da3a0f42
Enhance Alerts > Live Example section (#34769) 2021-08-30 16:00:16 +03:00
XhmikosR
9e1d81a851
Progress page: remove toggle animation button (#34787)
We don't use the same approach with a button on the Placeholders page.
2021-08-21 06:54:53 +03:00
SaintMalik
bfad22f23c
docs: fix typos in approach and placeholders (#34781) 2021-08-20 18:25:03 +03:00
Kyle Tsang
b10c1a76c7
Fix typo in placeholder docs (#34752) 2021-08-18 07:30:06 +03:00
GeoSot
1e5e655670
Fix modal when is triggered by bs-toggle, to hide other open instances (#34701) 2021-08-10 17:55:34 +03:00
Christian Oliff
fdc2f723a5
docs: Fix placeholders typo (#34686) 2021-08-05 08:36:00 +03:00
XhmikosR
f20fece3a8
Prepare v5.1.0. (#34674) 2021-08-04 18:41:51 +03:00