0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-01 13:24:25 +01:00
Commit Graph

98 Commits

Author SHA1 Message Date
Mark Otto
b01e81ed36 Rewrite custom file input
- Changes the wrapping label to a div so we can style the label instead of another element while also supporting form validation.
- Fixes form validation styles for custom file input (closes #24831).
- Updates docs with validation styles (also adding example feedback text while I was there) and new how it works section.
2017-12-26 16:14:08 -08:00
Mark Otto
c468f89b1c Make custom select and file inputs 100% wide
Matches browser default inputs and swaps some max-width properties for a regular width
2017-12-23 17:50:52 -08:00
Mark Otto
16f1417240
Form check markup v2 (#25050)
* match layout behaviors

* ditch the indicator as separate element for psuedo-elements on the label

* move disabled to attribute only on input

* redo default inline check to support new markup

* redo inline forms

* clean up vars

* update validation mixin to new structure

* update checks in docs

* linting for for/id attributes
2017-12-22 16:13:01 -08:00
Mark Otto
671bb278bb Restore currently unused variables (#24891) 2017-11-27 19:31:11 +02:00
Mark Otto
2ec1606ab7
Custom select updates (#24699)
* Add support for size attribute on custom selects

* Add large custom select, document it and the small variant

* fix custom select focus state

* fix custom file input focus styles

* remove empty line
2017-11-24 14:29:59 -08:00
Mark Otto
4829350a46
Rewrite custom form check backgrounds (#24697)
* Rewrite custom form check backgrounds

Previously, this was all just a background-color and background-image. When we restored the gradients though, we had two background-images competing on the same element, causing rendering glitches. This refactors that code, creating a mixin to simplify things, so we can we easily use two background-images (SVG icon and gradient) when -gradients is set to true.

Fixes #24598

* restore default vars

* Revamp custom check and radio backgrounds

Instead of applying multiple background-image's to the same element, we're adding a new ::before pseudo-element to layer the background-images. Gradients go on the .custom-control-indicator while their icons go on the ::before element. This allows us to shave some bytes from when we compile and we previously needed to redeclare the background-image for the icon if you changed the gradient.

* remove now unused mixin

* mention change in migration docs
2017-11-24 14:26:56 -08:00
Edward Betts
ffc5965f2c Correct spelling mistakes. (#24778) 2017-11-15 04:12:38 -05:00
ysds
ccc95d0c96 Reduce custom file z-index (#24633) 2017-11-06 15:58:28 -08:00
XhmikosR
34d745540d
Minor Sass consistency changes. (#24677)
* use `background-color` instead of the shorthand
* use `outline: 0` consistently
* fix transform order
* remove quotes from `SFMono-Regular`
2017-11-06 02:23:36 +02:00
Mark Otto
06641ca0b3 Gradients and shadows (#24429)
* Update the form focus mixin to use a manual `$enable-shadows` check so we can always ensure a focus state for accessibility and consistency

* - Add new `$input-btn-focus-width` and `$input-btn-focus-color` variables.

- Replace separate `$btn-focus-box-shadow` and `$input-focus-box-shadow`
variables with unified `$input-btn-focus-box-shadow` to match our
combined variables approach elsewhere.

* Put new focus width var to use in buttons mixins

* use new button input-box shadow var

* Add a new mixin for quickly adding linear gradient to components when $enable-gradients is set to true

* use correct var

* fix focus shadows in button mixins

* Add opt-in gradients to alerts, buttons, carousel, custom radios and checkboxes, custom file input, and dropdown items

* Generate .bg-gradient- utilities

* add headings to colors page and document bg-gradient utils

* update the button color for active status, check with yiq as it's done for basic state and hover state
2017-10-19 09:03:33 -07:00
Lodder
bd858f0ceb Fix custom-select with "multiple" attribute (#23055) 2017-10-02 21:00:57 -07:00
XhmikosR
7b766e1ad5 Switch to stylelint. (#23572) 2017-10-02 20:34:56 -07:00
Mark Otto
8fb48eaae2 Revert input group border changes (#24197)
Turns out #22612 is a bad idea and it makes all sorts of weird visual
glitches when working with form controls and transparent borders.
2017-10-02 14:18:33 -07:00
Patrick Yeo
ffa789327b Custom File padding-x and padding-y values are reversed (#23067)
Custom File `$custom-file-focus-box-shadow` should show even if box shadows are disabled

Custom File variables should inherit from inputs
2017-08-10 23:01:52 -07:00
Nathan Woltman
f95282c27e Fix border on input group elements and custom form inputs
c3e4cbd changed the border of input elements to be translucent. This commit makes
input group elements and custom form inputs follow the same pattern.
2017-08-10 22:41:21 -07:00
Patrick Yeo
696b2bee11 (#22414) Rename for consistency $custom-checkbox-border-radius, $custom-checkbox-icon-checked, $custom-checkbox-indeterminate-bg, $custom-checkbox-icon-indeterminate, $custom-checkbox-indeterminate-box-shadow, $custom-radio-border-radius, $custom-radio-icon-checked to $custom-checkbox-indicator-border-radius, $custom-checkbox-indicator-icon-checked, $custom-checkbox-indicator-indeterminate-bg, $custom-checkbox-indicator-icon-indeterminate, $custom-checkbox-indicator-indeterminate-box-shadow, $custom-radio-indicator-border-radius, $custom-radio-indicator-icon-checked, respectively 2017-07-16 12:36:26 -07:00
Mark Otto
21b874d19d Merge branch 'v4-dev' into form-tweaks 2017-06-13 20:15:42 -07:00
Patrick Yeo
d7867377d9 (Fixes #22414) Rename for consistency $custom-checkbox-radius, $custom-checkbox-checked-icon, $custom-checkbox-indeterminate-indicator-color, $custom-checkbox-indeterminate-icon, $custom-radio-radius, $custom-radio-checked-icon, $custom-select-sm-font-size, to $custom-checkbox-border-radius, $custom-checkbox-icon-checked, $custom-checkbox-indicator-indeterminate-color, $custom-checkbox-icon-indeterminate, $custom-radio-border-radius, $custom-radio-icon-checked, $custom-select-font-size-sm respectively 2017-06-13 19:22:49 -07:00
Patrick Yeo
2317b7fc96 (#22414) Rename for consistency $custom-control-disabled-indicator-bg, $custom-control-disabled-description-color, $custom-control-checked-indicator-color, $custom-control-checked-indicator-bg, $custom-control-checked-indicator-box-shadow, $custom-control-focus-indicator-box-shadow, $custom-control-active-indicator-color, $custom-control-active-indicator-bg, $custom-control-active-indicator-box-shadow to $custom-control-indicator-disabled-bg, $custom-control-description-disabled-color, $custom-control-indicator-checked-color, $custom-control-indicator-checked-bg, $custom-control-indicator-checked-box-shadow, $custom-control-indicator-focus-box-shadow, $custom-control-indicator-active-color, $custom-control-indicator-active-bg, $custom-control-indicator-active-box-shadow, respectively 2017-06-13 08:45:36 -07:00
Mark Otto
ca44f5b03a Redo the small custom select vars
— Sizing shorthand comes last
— Add height var and put it to use
2017-04-22 11:56:27 -07:00
Mark Otto
dc3af6711d Change how input and select height is computed
— Previously we weren't including the border-width on the computed height, leading to alignment issues.

— New system utilizes three variables (not ideal, but straightforward) for computing these heights. One for the vertical border, one for the line-height/font-size/padding dance, and one to add those together.

— Updates CSS across forms and custom forms to use new sizing. Special note here: form validation icon sizing uses the inner variables because background-image doesn't bleed into borders unless explicit background-clip.
2017-04-22 11:56:01 -07:00
Mark Otto
5463d8436b Merge branch 'v4-dev' into form-tweaks 2017-04-21 23:36:24 -07:00
Patrick H. Lauke
7056f70240 Remove cursor: not-allowed styles 2017-04-10 22:10:20 +01:00
Mark Otto
0cb2576bf2 fixes #21922: set border-radius to 0 when global radius is disabled 2017-04-08 21:58:26 -07:00
Theriault
6f42daf747 Add :empty to .custom-file-control selector (#22176)
<label class="custom-file"><input type="file" class="custom-file-input" /><span class="custom-file-control"></span></label>
VS
<label class="custom-file"><input type="file" class="custom-file-input" /><span class="custom-file-control">test.txt</span></label>
2017-03-18 13:23:10 -07:00
naicko
890c6041f3 Update scss mixins to comply with scss-linting rules (#22151)
* Fixed some linting issues

* Run npm tasks after scss cleanup

* Revert "Run npm tasks after scss cleanup"

This reverts commit 1103a0da68.

* Property sort order for grid

* Let's respest the property order in the mixins

* Respect property sort order in reboot file

* ::-ms-expand is a vendor-prefix, add it to the scss-lint disable

* Revert hover mixin comment

* Fixed missing mixin hover-focus
2017-03-18 13:06:05 -07:00
Rutger Laurman
0a997795b4 Fix border width calculation for custom-select (#22068)
In addition to #22011 and #21994
2017-03-03 11:19:02 -08:00
Bardi Harborow
9bacc6715a Remove vendor prefixes from appearance: none. 2017-02-21 17:38:11 +11:00
Mark Otto
02e0fdbd52 Remove cursor: pointer; (#21812)
* Remove most of custom cursor: pointer; implementations

* turns out that's not so much of a thing
2017-01-23 22:15:28 -08:00
Christian Oliff
d7af46359b Remove filter: alpha(opacity = 0);
Not needed (and all other old IE filter attributes have been removed from the CSS. This was the only one remaining
2017-01-15 17:52:34 -08:00
Phillip Marshall
1b194c0660 Custom Forms: Allow Chrome/Firefox feature that lets the user drag and drop into file inputs (#20033)
* Restored functionality of dragging files into .custom-file inputs.

* Replaced padding with height on .custom-file-input
2017-01-03 19:44:44 -08:00
Mark Otto
30fd1590d3 use flex and direction to do the stacked controls instead of float hacks
This also fixes #21280. Previously, we were using float and clear on the individual controls, but that meant a computer height of `0` for the parent `.custom-controls-stacked`. No more problem after using flexbox though.
2016-12-25 15:48:44 -08:00
Mark Otto
82061b25c4 move custom checks/radios to inline-flex 2016-12-25 15:48:44 -08:00
Mark Otto
66c87cb7ca Undo #21171 (which closed #20977)
Turns out we did have the correct height calculation with our custom selects. The problem was we lacked a shared line-height with our buttons and inputs.

This restores the previous `calc` math and adds a line-height that reuses the input line-height.
2016-12-24 14:21:04 -08:00
Bardi Harborow
855a67b1d6 Remove IE9 browser hacks. (#21393) 2016-12-22 13:41:31 -08:00
Mark Otto
d8bdb819a7 linting property order 2016-12-10 16:58:52 -08:00
Mark Otto
65aed32d95 put the custom control spacer var to use 2016-12-10 16:58:52 -08:00
Mark Otto
306f75216d Move margin from adjacent selector to right on the .custom-control for better responsive rendering (#21295) 2016-12-04 20:42:12 -08:00
Mark Otto
d50fc038c5 Update comment for use of IE9 hack to fix #18082 2016-11-26 17:31:10 -08:00
Mark Otto
20178076ee Merge pull request #19915 from zalog/patch-9
Zero out the default margin-bottom on label.custom-file
2016-10-27 22:20:26 -07:00
Mark Otto
f655343ac9 Merge pull request #21033 from twbs/label-less-custom-controls
Add a min-height: 1.5rem; to custom controls
2016-10-27 21:23:04 -07:00
Mark Otto
2dcc50f017 Calculcate the top offset for custom control indicators
Fixes #21023.

Uses some math functions to determine what the offset should be. This is helpful for those who customize the size of their indicators and still want them vertically centered.
2016-10-27 14:41:12 -07:00
Mark Otto
1421ca5b87 Add a min-height: 1.5rem; to custom controls
Fixes #20730.

This change computes the minimum needed height of what a single line of text would be for the custom checkboxes/radios. This is required because our custom control indicators are positioned absolutely, meaning they cannot be clearfixed or anything like that. Using a computed value means it should scale nicely in case of customization
2016-10-27 14:32:56 -07:00
Mark Otto
300cedfe8c Set height on custom select
Matches the changes from #20874 to the regular select element. This is really only necessary for IE and Edge near as I can tell. Fixes #20810.
2016-10-09 19:49:52 -07:00
Bardi Harborow
2e69dfa8c1 Fix broken/redirected links, moving to HTTPS where possible. (#20557) 2016-10-03 09:55:59 -07:00
Mark Otto
82e7abcdf3 v4: Custom checkbox and radio alignment (#20671)
* Allow text of custom form labels to wrap like the default ones
* Switch from using after to force line breaks to float/clear combo in stacked custom forms
2016-09-08 21:26:19 -07:00
Catalin Zalog
990e2c5d2b Update _custom-forms.scss 2016-05-16 17:00:45 +03:00
Mark Otto
399fdb8ebe Merge pull request #19735 from MatthewRayfield/v4-custom-select-disabled-styling
Add disabled styling for .custom-select
2016-05-08 14:20:54 -07:00
Matthew Rayfield
b21750cbb7 Add disabled styling for .custom-select 2016-04-14 13:37:14 -04:00
Patrick H. Lauke
d239fbb5f2 Suppress IE/Edge additional white/blue colors for focused <select> 2016-04-12 08:06:10 +01:00