0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-13 01:08:58 +01:00
Commit Graph

228 Commits

Author SHA1 Message Date
Chris Rebert
5ba5200195 move carousel accessibility callout next to rest of callouts 2014-11-11 19:29:56 -08:00
Chris Rebert
3b2d1570fa move single-toggle button plugin callout before example for consistency 2014-11-11 19:26:10 -08:00
Heinrich Fenkart
56f4156126 Merge pull request #15087 from patrickhlauke/dropdown-accessibility-tweaks
Wash-up of some stray dropdown examples
2014-11-12 01:19:39 +01:00
Patrick H. Lauke
0681971c8a Wash-up of some stray dropdown examples
adding explicit aria-expanded="false" initial state (so they're
correctly announced by AT as being collapsed), and - in the case of
old-school use of <a> - role="button"
2014-11-11 23:52:52 +00:00
Mark Otto
2006a435d9 Merge pull request #15077 from jayanthkoushik/issue-15076-fix
Fix Issue #15076.
2014-11-11 15:47:01 -08:00
Patrick H. Lauke
9391ef207f aria-hidden added to some stray glyphicons
plus minor tweak to customizer's generated alerts
2014-11-11 22:41:21 +00:00
Jayanth Koushik
917decab6c Fix Issue #15076.
This commit adds documentation explaining the need to have an initial
.active element in carousels.
2014-11-11 15:28:21 +05:30
Patrick H. Lauke
bb89657bcb Assorted accessibility (and some consistency) fixes for documentation
Closes #14951 by merging it.
2014-11-11 07:46:14 +01:00
Jayanth Koushik
e55feacf5b Add initialization examples to tooltip and popover "Opt-in functionality" callouts
Fixes #14950.
Closes #15015 by merging it.
2014-11-04 20:00:08 +01:00
Chris Rebert
594831f4f3 Add event.relatedTarget + data-* example to Modal docs
Fixes #14245
2014-11-03 13:37:27 -08:00
Aaron Cordovez
f412979287 Fix typo
Corrected spelling of the word "elements"
2014-11-01 17:46:33 -07:00
Manuel Meurer
1f64aac6b9 fix whitespace in js dropdown docs 2014-11-01 11:51:11 +01:00
hillai
1339ab7a13 Replace v3.2.1 reference with v3.3.0 since there wasn't a v3.2.1
Closes #14941
2014-10-30 10:20:54 -07:00
Cameron Little
0755d529c6 Tabs plugin accessibility
Added support for `aria-expanded` toggling via JavaScript. Added
`aria-controls`, `aria-expanded`, `aria-labelledby` to tabs docs.

Added `aria-expanded` unit test for the tabs plugin.

See also #13554.

Closes #14154 by merging it.
2014-10-26 02:25:47 +01:00
Chris Rebert
57e4b58782 Merge pull request #14859 from twbs/fix-14853
Clarify order of tabs events
2014-10-22 18:57:43 -07:00
Chris Rebert
b421dc9490 Clarify order of tabs events; fixes #14853
[skip sauce]
2014-10-22 18:38:18 -07:00
Chris Rebert
8d806b0ae5 Document .alert-dismissible .close restrictions; fixes #14802
[skip sauce]
2014-10-22 18:05:42 -07:00
Phil Hughes
ab8dbc214e Implement hide and hidden events for tabs
Closes #14772.
2014-10-22 21:42:35 +02:00
Patrick H. Lauke
e1d40f7633 Add aria-pressed to single toggle buttons
also includes tiny fix/clarification to two existing unit tests for the
.active class, adding data-toggle=“button” explicitly to the tested
buttons

Closes #14819.
2014-10-22 21:02:19 +02:00
Chris Rebert
f26dde085f add role="button" to a couple more dummy-anchor btns 2014-10-20 20:16:09 -07:00
XhmikosR
909a178362 Change Twitter links to use https. 2014-10-07 15:28:41 +03:00
Jacob
2c562d2386 Merge pull request #14590 from twbs/carousel-keyboard-option
Add `keyboard` option to carousel
2014-10-02 23:11:14 -07:00
Mark Otto
76268c4b96 more grunt 2014-10-02 21:21:49 -07:00
Mark Otto
12091b9567 Fixes #14711: Account for list groups in collapsing panels 2014-10-02 21:19:20 -07:00
Heinrich Fenkart
038a63b0eb Add keyboard option to carousel
Also adds unit tests for keyboard events.

Fixes #14468.
2014-10-03 05:16:31 +02:00
David Nguyen
6fa7495333 Fix #12563: Reiterate that empty tooltips+popovers do not get displayed 2014-10-02 10:44:20 -07:00
Nicole Bartelt
7398e1904b Added default collapsed class to the collapsed accordion html code example in the docs 2014-09-30 17:54:34 -07:00
Nicole Bartelt
d8c02c7d29 Added default collapsed class to the collapsed accordion examples in the docs 2014-09-30 17:10:51 -07:00
Mark Otto
6eb633775b Merge pull request #14674 from twbs/fix-14478
Document that the autofocus attribute doesn't work in modals.
2014-09-23 22:03:13 -07:00
Chris Rebert
93f4426fed linkify reference to Nav component in Scrollspy docs 2014-09-23 17:18:15 -07:00
Chris Rebert
d6903e4239 Document that the autofocus attribute doesn't work in modals.
Closes #14478.
2014-09-23 16:53:09 -07:00
Mark Otto
ccecb7cde4 fixes #14654: callout for scrollspy-nav link 2014-09-22 20:27:23 -07:00
Chris Rebert
ad00ad85fe modal docs: ensure all <button>s have an explicit type attribute
[skip sauce]
2014-09-15 15:43:34 -07:00
Chris Rebert
4849ec1cea add aria-labelledby to accordion example to improve accessibility 2014-09-12 17:40:44 -07:00
Chris Rebert
60164bc4ba Merge pull request #14579 from twbs/accordion-heading-role-tab
add role="tab" to .panel-heading-s in accordion example to improve accessibility
2014-09-12 17:23:23 -07:00
Chris Rebert
56c8c1bb55 add role="tab" to .panel-heading-s in accordion example to improve accessibility 2014-09-08 23:33:26 -07:00
Patrick H. Lauke
fb1ca10b99 ARIA support for collapse
Added handling of aria-expanded=true/false to collapse.js, updated
documentation to include advice on making expand/collapse controls
accessible, updated examples and javascript documentation to use
aria-expanded and aria-controls (when targetting single collapsible
element, using ID rather than class selector)

Closes #14147.
Closes #14153.
2014-09-09 01:19:20 +02:00
gitname
83daf95c64 Fixed typos involving apostrophes
Added apostrophes to 3 words to indicate possession (i.e. ownership of something) instead of plurality (i.e. multiples of something).
2014-09-04 22:10:19 -07:00
Chris Rebert
b9bfc74c62 Add Wall of Browser bugs entry for #793
Also, link to the Mozilla bug in the relevant callout.
2014-09-03 16:50:47 -07:00
Mark Otto
72ddad6fc8 Fixes #14439: Add static tooltip example to docs 2014-08-27 23:33:03 -07:00
Mark Otto
28c907f635 fixes #14441 2014-08-23 13:35:39 -07:00
Heinrich Fenkart
2c625c7d1a Clean up buttons documentation 2014-08-06 06:10:51 +02:00
Heinrich Fenkart
d9f1ea8252 Small wording tweak in alert docs 2014-08-06 03:50:10 +02:00
Heinrich Fenkart
ddadb2cf65 Document that alerts are removed from the DOM when closed; fixes #14318 2014-08-06 02:42:03 +02:00
Chris Rebert
fb2e9fe30c Merge branch 'KyleMit/add-default-settings-documentation' 2014-08-04 09:08:07 -07:00
Kyle
333af7d371 Add docs for how to change default JS plugin settings
Closes #14250.
2014-08-04 09:07:19 -07:00
Heinrich Fenkart
852d0d1144 Document arguments passed to placement function of tooltip/popover
Closes #14255
2014-07-29 02:29:41 +02:00
Chris Rebert
86d698f4e4 Merge pull request #14256 from twbs/fix-14224
Correctly doc args passed to function vals for `title` & `content` options of tooltips+popovers
2014-07-28 13:53:48 -07:00
Chris Rebert
90424296eb Fix #14219: Document that empty tooltips+popovers do not get displayed 2014-07-27 16:51:07 -07:00
Chris Rebert
ff12a76e5a Fix #14224: Correctly document args passed to function vals for title & content options of tooltips+popovers 2014-07-27 16:18:59 -07:00
vsn4ik
3e15e40ac9 dropdowns.html: Remove wrong "type" attribute. 2014-07-25 16:54:05 +04:00
Chris Rebert
2c4641855d fix #14115
[skip sauce]
2014-07-24 15:16:08 -07:00
Mark Otto
7fcc6c7889 unfuck those dropdowns 2014-07-23 21:00:48 -07:00
Mark Otto
463fe476d8 Merge pull request #14166 from hnrch02/docs-cleanup
Docs cleanup
2014-07-23 20:39:40 -07:00
Chris Rebert
c0eddc1fe3 Merge pull request #14188 from twbs/doc-14148
Document limitations of buttons JS plugin
2014-07-23 18:01:31 -07:00
Chris Rebert
4a98e2d765 Merge pull request #14191 from twbs/autocomplete-off-btns
Use autocomplete="off" in buttons plugin docs examples
2014-07-23 17:55:12 -07:00
fat
4775c9296a Merge branch 'dropdown-aria' of git://github.com/mckramer/bootstrap into mckramer-dropdown-aria
Conflicts:
	docs/_includes/js/dropdowns.html
2014-07-21 22:44:35 -07:00
Chris Rebert
db352bcc94 Make warning from #13875 slightly more detailed
[skip sauce]
2014-07-18 14:19:19 -07:00
Chris Rebert
fc19cad608 Use autocomplete="off" in buttons plugin docs examples
Refs #13875.
2014-07-18 13:59:37 -07:00
Chris Rebert
976441ac1b Document limitations of buttons JS plugin
Addresses #14148.
2014-07-18 11:48:00 -07:00
Heinrich Fenkart
38335b2a3d Merge alert examples and add .bs-example-standalone class 2014-07-17 05:16:48 +02:00
Heinrich Fenkart
31772677f9 Clean up the Alert documentation 2014-07-17 05:16:34 +02:00
Heinrich Fenkart
f9349f36df Clean up Affix documentation 2014-07-17 03:53:49 +02:00
Chris Rebert
11db482371 popover dismiss-on-next-click example: instead of <button>, use <a> w/ tabindex
Fixes #14038.

Research supporting this choice of approach:
    https://gist.github.com/cvrebert/68659d0333a578d75372

Why not <button>?
Even with a `tabindex` attribute, they don't gain focus when clicked upon in:
    * Mac OS X Firefox 30.0
    * Mac OS X Safari 7.0.5
2014-07-15 16:57:54 -07:00
Chris Rebert
74691b7e27 add docs note about browsers w/ JS disabled; fixes #14134
[skip sauce]
2014-07-14 17:17:38 -07:00
Mark Otto
2c540b7e33 typos 2014-07-13 00:08:25 -07:00
Mark Otto
d9a38cd99f Fixes #14132: add .alert-dismissible to docs examples 2014-07-12 17:51:57 -07:00
Mark Otto
7ec6c9fd13 Fixes #14116: Use <button> elements over empty anchors 2014-07-12 15:16:43 -07:00
vsn4ik
816c8f480a dropdowns.html: Add role="button" and id="..." to link in example. 2014-07-10 21:44:46 +04:00
Chris Rebert
8c6061c195 Merge pull request #14089 from twbs/accordion-panel-group-aria-multiselectable
Add role="tablist" & aria-multiselectable="true" to accordion .panel-group
2014-07-08 12:56:06 -07:00
Chris Rebert
878f720ea1 Add role="tablist" & aria-multiselectable="true" to accordion .panel-group to improve accessibility
Refs #13555.
Per https://github.com/paypal/bootstrap-accessibility-plugin/blob/master/README.md#collapse
Credit: https://github.com/paypal/bootstrap-accessibility-plugin

[skip sauce]
2014-07-08 12:47:44 -07:00
Chris Rebert
81f67e925a add role="tabpanel" to .panel-collapse to improve accessibility
Refs #13555.
Per https://github.com/paypal/bootstrap-accessibility-plugin/blob/master/README.md#collapse
Credit: https://github.com/paypal/bootstrap-accessibility-plugin

[skip sauce]
2014-07-08 12:40:42 -07:00
Chris Rebert
4683beeedf Merge pull request #14085 from twbs/tab-lis-role-preso
add role="presentation" to tab <li>s to improve accessibility
2014-07-08 12:25:38 -07:00
Chris Rebert
e2b4f3429c Add role="tabpanel" to .tab-pane <div>s to improve accessibility
Refs #13554.
Per https://github.com/paypal/bootstrap-accessibility-plugin/blob/master/README.md#tab-panel
Credit: https://github.com/paypal/bootstrap-accessibility-plugin

[skip sauce]
2014-07-08 12:11:02 -07:00
Chris Rebert
5c1f4e1a0c add role="presentation" to tab <li>s to improve accessibility
Refs #13554.
Per https://github.com/paypal/bootstrap-accessibility-plugin/blob/master/README.md#tab-panel
Credit: https://github.com/paypal/bootstrap-accessibility-plugin

[skip sauce]
2014-07-08 12:00:43 -07:00
Chris Rebert
2e3f1a23f6 Merge pull request #14072 from twbs/carousel-gloss-buttons
Add screenreader text to prev/next carousel buttons in examples to improve accessibility
2014-07-07 20:16:52 -07:00
Chris Rebert
849bf58a54 Add screenreader text to prev/next carousel buttons in examples to improve accessibility
Refs #13556.
Per https://github.com/paypal/bootstrap-accessibility-plugin/blob/master/README.md#carousel
Credit: https://github.com/paypal/bootstrap-accessibility-plugin

[skip sauce]
2014-07-07 20:05:44 -07:00
Chris Rebert
94eff8c159 add role="listbox" to .carousel-inner to improve accessibility of Carousels
Refs #13556.
Per https://github.com/paypal/bootstrap-accessibility-plugin/#carousel
Credit: https://github.com/paypal/bootstrap-accessibility-plugin

[skip sauce]
2014-07-07 19:53:57 -07:00
Chris Rebert
7c50b9ad7a Add role="tablist" to .nav-pills in examples to improve accessibility
Follow-up to e9374c0609
Per f203dea4b6
Credit: https://github.com/paypal/bootstrap-accessibility-plugin & @rohk

[skip sauce]
2014-07-07 19:24:32 -07:00
Chris Rebert
520b3547a4 nitpick phrasing of the docs added for #13835 2014-07-07 00:10:49 -07:00
Mark Otto
5e41a23ec5 Fixes #13835: More explicitly document mobile dropdown menu dismissing behavior 2014-07-06 16:55:35 -07:00
Mark Otto
44f83fff90 Merge pull request #14021 from CFXd/add_collapsed_default_class_to_navbar_collapse_button
Add collapsed default class to navbar-toggle
2014-07-06 16:37:42 -07:00
Chris Rebert
7933a50ee5 Merge pull request #14034 from twbs/deprecate-modal-remote
Deprecate the `remote` option of modals?
2014-07-05 23:48:25 -07:00
Chris Rebert
7f4af4aeea remote modal docs: mention jQuery.load and other JS options as alternatives
[skip sauce]
2014-07-05 23:43:29 -07:00
Chris Rebert
24e51590b7 modal docs formatting tweak
[skip sauce]
2014-07-03 12:58:20 -07:00
Chris Rebert
8340d664ce Mark the remote option of the Modal plugin as deprecated.
Follow-up to https://github.com/twbs/bootstrap/issues/13087#issuecomment-46563760
Closes #13087 as WONTFIX.
Closes #13597 as WONTFIX.
2014-07-03 12:58:10 -07:00
Chris Rebert
456bd67da8 Merge pull request #13986 from twbs/address-13874
docs: use valid JSON in compound option value examples
2014-07-03 11:07:50 -07:00
Michael Silber
1e407c81f1 Add collapsed default class to navbar-toggle 2014-07-02 16:49:03 -04:00
Chris Rebert
8deab3a95d Merge pull request #13988 from twbs/fix-13896
doc that you can't use both data-ride and $().carousel() on the same carousel
2014-06-30 14:49:11 -07:00
Patrick Robertson
dcb09f3b09 Fix inconsistency between demo and displayed code for modal demo
Fixes #13991
2014-06-30 19:19:18 +07:00
Chris Rebert
3dfad4f1ad doc that you can't use both data-ride and $().carousel() on the same carousel; fixes #13896
[skip sauce]
2014-06-29 21:16:44 -07:00
Chris Rebert
48e35cb830 docs: use valid JSON in compound option value examples
Fixes #13874.
[skip sauce]
2014-06-29 21:08:42 -07:00
Chris Rebert
d23d9ee4a0 fix #13979 2014-06-29 19:58:09 -07:00
Chris Rebert
2f7d5fd26b docs: minor correction to the focus-triggered popover demo explanation 2014-06-26 12:21:45 -07:00
Chris Rebert
43b7a942bc fix class names in popover live examples in docs 2014-06-26 10:51:07 -07:00
Mark Otto
34248437c3 tweak alert per #13875 2014-06-19 19:54:25 -07:00
Bas Bosman
128e52ff29 Fix dismissible spelling 2014-06-18 00:00:28 +02:00
Chris Rebert
5b9e2bf126 popovers.html: fix typo: "Dimissmisable" 2014-06-17 12:57:54 -07:00
Heinrich Fenkart
5e6967358f Update generated markup by the tooltip plugin in docs; fixes #13796 2014-06-12 05:35:27 +02:00
Mark Otto
ef360b61b5 clarify and danger-ify affix docs usage requirements, per #10235 2014-05-22 20:14:32 -07:00
Max Kramer
ee12ce8305 Add aria-haspopup and aria-expanded attributes to dropdown plugin
1. Add aria-haspopup="true" and aria-expanded="false" to dropdown docs
2. Toggle aria-expanded between "true" and "false" when opening and closing dropdown

Satisfy item 1 from https://github.com/paypal/bootstrap-accessibility-plugin#dropdown. See #13553.
2014-05-22 18:13:41 -04:00
Attila Dobi
f47ad79538 add target option to Affix plugin 2014-05-16 13:07:45 -07:00
Chris Rebert
00fcf072c6 update default 'template' value in popover docs 2014-05-14 18:43:14 -07:00
Chris Rebert
3465d984fb add 'container' option motivation to tooltip docs 2014-05-14 18:23:58 -07:00
Chris Rebert
6fdbd8e3cf add 'selector' option motivation to tooltip docs 2014-05-14 18:21:19 -07:00
Chris Rebert
e839a49995 add multiple triggers info to popover docs 2014-05-14 18:21:19 -07:00
Chris Rebert
90cfa1a44d add 'viewport' option to popover docs; #12328 erratum 2014-05-14 18:20:55 -07:00
Chris Rebert
99f6f700f4 docs: sort tooltip & container options for sanity 2014-05-14 18:12:18 -07:00
Chris Rebert
a217ed776d Merge pull request #13558 from twbs/nav-tabs-role-tablist
add some ARIA roles to tabs for improved accessibility
2014-05-09 23:12:46 -07:00
Chris Rebert
b7ac0d401f add role="button" to [data-slide="prev"],[data-slide="next"] to improve accessibility
Per https://github.com/paypal/bootstrap-accessibility-plugin/blob/master/README.md#carousel
Credit: https://github.com/paypal/bootstrap-accessibility-plugin
2014-05-09 15:31:52 -07:00
Chris Rebert
0a808fc56c add role="tab" to .nav-tabs [data-toggle="tab"]
Per https://github.com/paypal/bootstrap-accessibility-plugin#tab-panel
Credit: https://github.com/paypal/bootstrap-accessibility-plugin
2014-05-09 15:12:57 -07:00
Chris Rebert
e9374c0609 add role="tablist" to .nav-tabs in examples to improve accessibility
Per https://github.com/paypal/bootstrap-accessibility-plugin#tab-panel
Credit: https://github.com/paypal/bootstrap-accessibility-plugin
2014-05-09 15:05:20 -07:00
Chris Rebert
d36c150569 tweak formatting in Carousel docs for clarity; fixes #13522 2014-05-06 11:34:46 -07:00
Chris Rebert
949b81f511 Improve accessibility of close buttons in modals & alerts
Adds textual caption to the close buttons. The "X" multiplication sign isn't very meaningful to screenreaders.

Credit: https://github.com/paypal/bootstrap-accessibility-plugin
Per:
    https://github.com/paypal/bootstrap-accessibility-plugin/blob/master/README.md#alert
    https://github.com/paypal/bootstrap-accessibility-plugin/blob/master/README.md#modal-dialog
2014-05-03 19:53:34 -07:00
Chris Rebert
05d4932cad Merge pull request #13396 from twbs/carousel-events
Carousel event properties
2014-04-25 19:35:38 -07:00
Chris Rebert
6617d8bcd1 Document .direction & .relatedTarget properties of Carousel events.
Fixes #13395
2014-04-24 19:02:47 -07:00
Chris Rebert
9c25f5c06e document that show-ing a tooltip/popover on a hidden element doesn't work; fixes #13362 2014-04-24 18:06:59 -07:00
Chris Rebert
6161c98238 document that non-:visible scrollspy targets are ignored; fixes #13394 2014-04-21 16:42:22 -07:00
Chris Rebert
a6214273b9 quote attribute value in selector in JS docs example 2014-04-19 17:42:06 -07:00
Mark Otto
f159ce8b9e Fixes #13208: Drop <b> for <span> in code snippets and examples 2014-04-07 22:59:37 -07:00
Heinrich Fenkart
b94306d29b Replace $.fn.bind with $.fn.on in alert docs 2014-04-04 02:46:19 +02:00
Chris Rebert
2d1d5754f7 document that you have to add .active yourself on prechecked btn-ized checkboxes+radios; fixes #12651 2014-04-02 20:00:52 -07:00
Chris Rebert
640923eb36 help avoid misuse of Carousel's .active when copy-pasting from examples; fix #13252 2014-04-01 13:04:43 -07:00
Chris Rebert
361f452ed4 doc that popover content() is given the element as an arg; fix #13175 2014-03-26 12:49:15 -07:00
Chris Rebert
7c50859e93 Document template option of tooltip & popover; fixes #13088
Also capitalize column titles and descriptions.
2014-03-26 12:40:23 -07:00
Ben Ogle
8534e12523 Add tooltip viewport option, respect bounds of the viewport 2014-03-21 11:28:13 -07:00
Julian Thilo
d52ad3ee3b Separate JS includes for alerts and popovers
/cc @mdo
2014-03-17 15:58:03 +01:00
Mark Otto
2a43e7e78a Break up docs into includes 2014-03-16 19:03:53 -07:00