Johann-S
2ccfa57467
handle # selector for dropdown
2019-02-13 17:55:38 +02:00
Johann-S
2c8abb9a43
Add sanitize for tooltips and popovers html content.
...
On browsers that `createHTMLDocument` isn't available just return the unsafe HTML.
2019-02-13 17:55:38 +02:00
Andrew Luca
0b78f465d3
test: ensure .navbar-fixed-* padding on modal open
2018-10-18 10:14:05 +02:00
XhmikosR
5cce25d515
Minor indentation fixes.
2018-10-08 20:12:34 +03:00
Johann-S
4ebe2b8753
Use BrowserStack for our unit tests.
2018-09-28 09:53:59 +03:00
Johann-S
9c4c72e31e
fix unit tests
2018-08-19 16:57:25 +02:00
don-spyker
2a5ba23ce8
Fix/xss issues on data attributes ( #27047 )
...
* fix(collapse): xss CVE-2018-14040
Fixes #26625
* fix(tooltip): xss CVE-2018-14042
Fixes #26628
* fix(tooltip): XSS on data-viewport attribute
Fixes #27044
* fix(affix): XSS on target config
Fixes #27045
2018-08-13 18:09:18 +02:00
Dave Methvin
bc05ef16ec
Port #20198 to v3
...
ScrollSpy unit test: Use single done() in a then() instead of multiple done()s
Fixes test flakiness on OS X Safari and Android when using jQuery 3.
Fixes #20182 more
Refs #20191
2016-07-07 23:32:50 -07:00
Dave Methvin
4a8b29fbf5
Port #20190 to v3
...
Scrollspy test: Allow for async .then() in jQuery 3; fixes #20182
Instead of doing a new assert.async(), just do a single one for the entire test
and let the .then() be async as well.
2016-07-07 23:32:18 -07:00
Chris Rebert
40996725ce
js/tests/unit/modal.js: Fix typo
...
[ci skip]
2015-12-22 17:11:18 -07:00
Johann-S
ef1ce9ac0b
Fix triggering of {shown,hidden}.bs.dropdown events so relatedTarget gets set properly
...
Fixes #16828
Closes #16865
2015-07-27 00:58:51 -07:00
Patrick H. Lauke
5fd7bc1554
generalize dropdowns / drop role="menu"
...
as role="menu" is a very specific (and strict) ARIA pattern for
desktop-like application menus, and our dropdowns are often used
as pure navigation dropdowns, this change abandons ARIA menus for
a more open-ended and light-weight approach
(see http://heydonworks.com/practical_aria_examples/#submenus and
http://www.w3.org/WAI/tutorials/menus/flyout/#improve-screen-reader-support-using-wai-aria )
note that in dropdown.js, switched to now target ``.dropdown-menu``
instead of ``role["menu"]`` - this also prevents bootstrap scripts
from "bleeding" into non-bootstrap components on the same page.
also removed the ``role=["listbox"]`` part, which appears to be
vestigial/unused (only place in bootstrap that uses that
role are carousels, and their key handling is done separately)
2015-06-02 11:03:21 +01:00
XhmikosR
315907c97c
Use https
when possible.
2015-05-17 12:43:20 +03:00
XhmikosR
a2f81ceb57
phantom.js: switch to unicode characters that work on Windows too.
2015-05-05 06:58:54 +03:00
XhmikosR
49c4556354
Comply to the new JSCS rules.
2015-05-05 06:50:18 +03:00
Chris Rebert
aa2c5b5672
Merge pull request #16014 from redbmk/issue-16008
...
Multiple tooltip triggers don't play well together
2015-05-04 15:07:17 -07:00
Patrick H. Lauke
0c1daaf2ce
Remove broken/vestigial unit test
...
Overall logic for this test appears broken, possibly relating to an
older version of Bootstrap that did not require explicit
`data-toggle="button"` on single toggle buttons?
2015-05-01 12:58:10 +01:00
Braden M. Kelley
4b269037cb
Multiple tooltip triggers don't play well together
...
Fixes issue #16008
2015-04-27 23:03:56 -07:00
F A T
aa479892d5
Merge pull request #16152 from jarthod/tooltip-placement-viewport-fix
...
Tooltip/popover: Fix auto placement to use viewport
2015-04-27 11:28:54 -07:00
Chris Rebert
cdb37dce3a
Set box-sizing: border-box
on .container-viewport in #16142 testcase
...
Otherwise, the test doesn't properly fail when the fix is reverted.
2015-04-27 01:23:39 -07:00
Adrien
37a10d37c1
Compare tooltip right offset to viewport right offset (and not width)
...
Closes #16142 by merging it.
2015-04-27 01:13:16 -07:00
Chris Rebert
fc372952e2
Throw error when tooltip/popover template has multiple top-level elements
...
Closes #16219 .
2015-04-25 13:16:53 -07:00
Adrien Siami
e949505b89
Allow viewport option to be a function
...
Closes #16151 by merging a rebased version of it that adds docs and 1 more assertion.
2015-04-21 22:20:15 -07:00
Chris Rebert
c6b62f0cd9
Merge pull request #16147 from Johann-S/event_inserted
...
Fixes #16124 .
2015-04-21 21:40:14 -07:00
Patrick H. Lauke
66d71136e6
Fix existing radio button unit test
2015-04-11 19:24:21 +02:00
Johann-S
3d71eae301
Add event after template inserted
2015-04-08 13:10:53 +02:00
Adrien Jarthon
5921724d9c
fixed IE incompatible CSS
2015-03-29 19:16:59 +02:00
Adrien Jarthon
df96c3e615
Added non-regression test & fixed existing one
2015-03-29 14:59:21 +02:00
Chris Rebert
6c5e7dfce1
rm redundant aria-hidden usage from Modals; fixes #16020
2015-03-25 18:06:47 -07:00
Chris Rebert
d37bc2ae65
Merge pull request #15987 from twbs/fix-15972
...
add role="button" to a[data-toggle="collapse"]
2015-03-24 08:57:56 -07:00
Emmanuel Bourgerie
fa9d28b634
Fix #16072 : Clicking into input field within dropdown no longer closes the dropdown
...
Closes #16073 by merging it
2015-03-21 16:00:15 -07:00
Maxim Andrukhovych
83371735fc
Fixed proper navigation element selection on backward scrolling (from the bottom to the top)
2015-03-10 20:04:15 +00:00
Chris Rebert
725c6848c3
Disable jQuery event aliases when running test suite
...
To ensure that we don't accidentally use any of the aliases.
This should prevent any future regressions from #12761 .
Also updates the test suite since it now can't use these aliases either.
2015-03-09 01:05:43 -07:00
Chris Rebert
5c8d56d515
Collapse unit test: rm check that no-op hide adds style="height: 0px"
...
Appears to be unnecessary and is broken by #16011 ,
which is otherwise quite sane.
2015-03-06 18:10:53 -08:00
Chris Rebert
872e56fcf2
.collapse('hide') on hidden uninit-ed collapsible no longer shows it; fixes #15315
...
Thanks to @peterblazejewicz & @Nikita240
Adds unit tests based on #14417
X-Ref: #14282
Closes #15807
2015-03-06 06:58:48 -08:00
Chris Rebert
27bbc7dbe9
Hiding an uninitialized tooltip/popover no longer initializes it; fixes #15874
2015-03-03 22:22:13 -08:00
Chris Rebert
cc39f5c52d
add role="button" to a[data-toggle="collapse"]; fixes #15972
2015-03-03 13:18:36 -08:00
Heinrich Fenkart
420a8088a4
Merge pull request #15961 from kkirsche/ImplementAssertExpect
...
[Fixes #15953 ] Implement assert.expect in each unit test
2015-03-03 15:52:05 +01:00
Kevin Kirsche
4febcb4b49
[ Fixes #15953 ] Implement assert.expect in each unit test
...
[Fixes #15953 ] Implement `assert.expect` in each unit test
2015-03-03 08:45:07 -05:00
Heinrich Fenkart
f5beebe726
Modal: Fix backdrop not readjusting when height changes
...
Fixes #15136 .
Closes #15345 .
Closes #15314 .
Refs #14724 , #14927 .
2015-03-03 05:27:26 +01:00
XhmikosR
f8e34ff48b
Disable es3 for tests and customizer.js.
2015-03-02 11:16:06 +02:00
Chris Rebert
015e63f6df
Merge pull request #15593 from neoeno/handle_multiple_zero_offset_scrollspy_elements
...
Handle multiple zero-offset Scrollspy elements.
2015-03-01 16:04:04 -08:00
Caden Lovelace
a1aa0f8afd
Handle multiple zero-offset Scrollspy elements.
...
When the first two elements in a scrollspy content block have a document
offset of zero (i.e. they're hard against the top of the page),
Scrollspy would switch between them on every scroll event.
This could happen, for example, in a system of nested sections:
```
<section id="animals">
<section id="dogs">
Content
</section>
</section>
```
This ocurred because Scrollspy's check to see if it's at the end of the
array of sections uses `!arr[index]`. This misses the case where
`arr[index]` does exist and is zero.
This commit explicitly checks the array bounds.
2015-03-01 23:55:39 +00:00
Ivan Cheung
d5071b19f1
Update all collapse triggers with .collapsed class and aria-expanded
...
Fixes #15741
Closes #15751 by merging it.
2015-02-26 18:48:20 -08:00
Chris Rebert
9afb61fffd
QUnit.jsDump => QUnit.dump
...
Refs http://qunitjs.com/upgrade-guide-2.x/#replace-qunit-jsdump-with-qunit-dump
2015-02-25 23:29:27 -08:00
Heinrich Fenkart
3bb05b5fbb
Unit tests: Use new names of module hooks
...
Refs #15893
2015-02-26 08:20:42 +01:00
nakupanda
142a9e4ae0
Modal: Apply any preexisting body padding again after closing
2015-02-26 08:02:06 +01:00
vsn4ik
b395f3526e
Dropdowns: Skip .disabled
instead of .divider
on keydown event
...
Fixes #15147 .
Closes #15520 by merging it.
2015-02-26 06:42:09 +01:00
Chris Rebert
804457c474
fix 2 typos in modal unit test assertion messages
2015-02-24 23:49:08 -08:00
Heinrich Fenkart
c40c31a308
Dropdown unit tests: Tiny style changes
2015-02-25 02:53:39 +01:00