XhmikosR
be9e6f3638
Update modal.js
2017-10-04 15:03:06 +03:00
lucascono
47968c8126
Unit test for modal bug fix
...
Unit test for pull request #24240
2017-10-04 08:55:40 -03:00
Johann-S
e04e42d08c
Merge branch 'v4-dev' into fix-jumping-modal-on-resize
2017-09-03 12:56:04 +02:00
David Bailey
ce41d3fd15
Add failing test
2017-08-29 15:36:37 +01:00
David Bailey
2622a015f2
Fix unit tests in PhantomJS
...
Use a virtual scrollbar as this is simpler than having a real one (overflow: scroll doesn't seem to work in Phantom), and disable it for the new test.
One test has also been altered to prevent erroneous fails when other inline styles are added to the body (e.g. overflow).
2017-08-29 12:01:41 +01:00
David Bailey
487513ff03
Add failing test
...
When the body does not overflow (achieved by hiding the QUnit container), it should not be given a margin.
2017-08-28 16:21:04 +01:00
meeque
9612830701
Add unit test for xss in data target attribute
2017-08-25 23:20:14 +01:00
David Bailey
ba6a6f1369
Fix sticky margin when a modal is opened ( #23669 )
...
* Adjust margin for sticky elements on modal
Previously white space was visible to the right of sticky elements due to right padding being added to the body. This fixes #23661 .
* Add unit tests for margin of sticky elements on modal
2017-08-25 22:01:41 +01:00
XhmikosR
ef8c77d8dc
Tweak ESLint rules.
2017-08-23 00:05:38 +03:00
Ilias
e6e070b02a
Fix #22332 : Adjust tests for hidden scrollbar
2017-04-03 13:27:15 +02:00
Ilias
a14451deb3
Fix #18373 : properly adjust padding-right of body and fixed elements when opening or closing modal
2017-04-02 13:26:25 +02:00
Mark Otto
c61a0059ad
update seletors in js
2017-01-02 11:52:38 -08:00
Mark Otto
25d218b02d
Merge branch 'v4-dev-18796' of https://github.com/maxbeatty/bootstrap into maxbeatty-v4-dev-18796
2016-11-26 00:58:51 -08:00
Johann
ce18a66809
Add test unit to check logic of ignoreBackdropClick ( #18245 )
2016-11-25 22:57:20 -08:00
Bardi Harborow
c2616fb74e
Make JS compliant with the new ESLint rules.
2016-11-24 11:59:55 +11:00
Mark Otto
c01fa6b369
Merge pull request #17536 from Johann-S/testPadding
...
[Fix #17400 ] Add tests about padding restoration
2016-10-28 13:46:14 -07:00
Max Beatty
bfa714ae1e
prevent navigating to area href when modal target. fixes #18796
2016-08-04 13:47:30 -07:00
Patrick H. Lauke
b107e3342a
Handle aria-hidden on modal container when showing/hiding
...
Fixes #19878
2016-05-11 02:01:56 +01:00
Chris Rebert
96e9205009
js/tests/unit/modal.js: Fix typo
...
[ci skip]
2015-12-22 17:11:21 -07:00
Johann-S
21a65f181e
Add throw error for undefined method on plugins
2015-10-02 10:01:24 +02:00
Johann-S
8ece899ba8
Add tests about padding restoration
2015-09-10 08:19:59 +02:00
fat
ca9c850ebb
add getters for Version and Default where applicable
...
add modal my gawd
2015-05-10 19:45:38 -07:00
fat
d1fbe200f4
remove closureness from plugins
2015-05-06 13:34:14 -07:00
fat
834220ea20
bootstrap onto closure
2015-02-11 11:29:43 -08:00
Chris Rebert
1652efc3f6
tweak 'close reopened modal' unit test to work under new QUnit API
2015-01-20 20:18:33 -08:00
Chris Rebert
b56d97f210
update JS unit tests to future-proof QUnit 1.16.0 API
...
[skip validator]
2015-01-20 19:57:51 -08:00
fat
4bbe80658a
fixes #13816 Modal dialog closes when dragging and releasing mouse button outside dialog
2014-10-09 20:01:51 -07:00
Heinrich Fenkart
18c0a1c977
Revert "Use mousedown instead of click for backdrop click detection; fixes #13816 "
2014-07-30 23:54:25 +02:00
Heinrich Fenkart
998c3724e8
Clean modal unit tests up
2014-07-06 09:24:22 +02:00
Jacob
5830febd9a
Merge pull request #13855 from hnrch02/modal-mousedown
...
Use mousedown instead of click for backdrop click detection; fixes #13816
2014-07-06 00:01:57 -07:00
Heinrich Fenkart
91f329e448
Only close modal if escape was hit with keydown; fixes #13929
2014-07-01 05:50:31 +02:00
Heinrich Fenkart
121bf6633e
Use mousedown instead of click for backdrop click detection; fixes #13816
2014-07-01 02:53:57 +02:00
XhmikosR
3b99a41246
Merge pull request #13388 from twbs/xhmikosr-js-style
...
Improve JS style
2014-06-07 09:13:05 +03:00
Chris Rebert
3cbbc70d55
Merge pull request #13627 from twbs/maybe-fix-12364
...
Hopefully fixes trigger focus restoration on modal close
2014-06-06 15:59:17 -07:00
XhmikosR
7b0acf14d8
Comply to the new style.
2014-06-06 01:23:07 +03:00
Chris Rebert
b058c018eb
Hopefully a fix for #12364
...
* register the callback before invoking the toggling
* listen for `hidden` instead of `hide`
* account for the possibility of the associated `show` event being preventDefault-ed
Adds relevant unit tests.
2014-05-19 02:14:14 -07:00
Chris Rebert
e9b99d475c
fix typo in assertion description
2014-05-19 00:47:06 -07:00
Collin Donahue-Oponski
a9f2b6ce0f
#11464 - Fix JS noConflict mode - Refactor all plugins to use an internal reference to the jQuery plugin, because in noConflict mode you can never expect to be defined on the jQuery object
2014-04-21 23:03:33 -06:00
Chris Rebert
0aaf2cdd3a
quote attribute values in selectors in JS unit tests for consistency
2014-04-19 17:45:58 -07:00
Chris Rebert
5ef634dab9
replace $.bind() with $.on() in unit tests; per #13272
2014-04-03 18:13:16 -07:00
XhmikosR
895b0006b9
Re-indent test files.
2014-02-14 11:02:03 +02:00
fat
2f76821a4d
new qunit
2014-01-16 13:33:09 -08:00
XhmikosR
eca8ff3803
Use single quotes consistently.
2013-12-08 12:44:14 +02:00
XhmikosR
4aad52797c
Use a space after function consistently.
2013-12-06 12:43:48 +02:00
fat
712b89ed4e
fixes #9362
2013-08-17 14:24:38 -07:00
Jacob Thornton
a4f0e8d37a
fixes #9111
2013-08-10 13:35:20 -07:00
fat
57768d7ea9
fix #7660
2013-07-17 23:01:33 -07:00
Mark Otto
432d417ade
fixes #6898 : typo in modal test
2013-05-22 23:17:39 -07:00
fat
140ef2320b
change namespace back to dot notation and someother js shizzle
2013-05-16 20:19:51 -07:00
fat
a72d0d6e3a
fix tests
2013-05-16 17:44:50 -07:00
