0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-04 16:24:22 +01:00
Commit Graph

43 Commits

Author SHA1 Message Date
XhmikosR
730566221f
visual tests: add missing base-component dist file (#33167)
Regression of #32313
2021-02-22 08:42:43 +02:00
Patrick H. Lauke
96be06e32b
Dynamic tabs: use buttons rather than links (#32630)
* Dynamic tabs: use buttons rather than links

- change docs
- add mention that tabs should be <button> elements
- tweak styles to neutralise border and background

* Update js unit and visual test accordingly

- replace links with buttons
- make one specific test that uses links instead of buttons, as we still want to support it despite it being non-semantically appropriate
- Leaving a couple of tests for now. The test for removed tabs should be redone so that tabs are removed programmatically (as the approach of having that close button inside the link is invalid and broken markup). The test for dropdowns should be removed together we actually ripping out the handling for dropdowns in the tab.js code (arguably a breaking change, though we discouraged this for a few versions and effectively "deprecated" it)

* Add isolation:isolate to prevent focus being overlapped

https://github.com/twbs/bootstrap/pull/32630#issuecomment-756015766
2021-02-09 07:23:45 +02:00
Rohit Sharma
418f17ee2b Add bs in data attributes
- Add `bs` in data APIs everywhere
- Update unit tests
2020-11-14 07:09:15 +02:00
XhmikosR
13572a6867 Remove the now unneeded polyfills. 2020-11-05 15:37:34 +02:00
XhmikosR
5a3f273b60
Move href attribute first (#31835) 2020-10-22 09:38:15 +03:00
Martijn Cuppens
c48d89cb70 Use unordered lists in dropdown-menus 2020-03-31 22:52:57 +02:00
Laussel Loïc
7ce29d75f3
v5 tabs - accessibility issue when using ul/li semantic
Add aria-role presentation on li element when ul element has role tablist and remove dropdown from visual tests as they've been removed from doc
2020-03-28 09:51:24 +02:00
Johann-S
e101ba4989 add polyfill.js in visual tests (#29116) 2019-07-24 08:19:47 +03:00
XhmikosR
438e01b61c Rename eventHandler and selectorEngine files. 2019-05-08 17:26:37 +03:00
Johann-S
ad0f5f153c fix remove files in our visual tests 2019-03-18 01:11:05 +02:00
XhmikosR
d5f9107abb
Remove the now unneeded shrink-to-fit directive. (#28314) 2019-02-27 17:47:41 +02:00
Johann-S
c44db783bf chore(update): bump to 4.1.3 2019-02-20 22:05:45 +02:00
Johann-S
5dcca44fcf fix(visual-test): remove jquery in them 2019-02-20 22:05:45 +02:00
Alessandro Chitolina
7f08061eca rewritten tab without jquery 2019-02-20 22:05:45 +02:00
Johann-S
0b16c8c6d9 alert without jquery 2019-02-20 22:05:45 +02:00
Johann-S
fb465c4745 Remove jQuery from Util.js
s
2019-02-20 22:05:45 +02:00
Patrick H. Lauke
4b00aa6c4e Remove incorrect aria-haspopup from dropdown toggles (#28299)
`aria-haspopup` use requires the use of an ARIA `menu`, `listbox`, `tree`, `grid` or `dialog` (see https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup)

in our use (as generic disclosure widgets), it's incorrect and sets up the wrong assumption/behavior from assistive technologies.

in future, we likely want to change our dropdowns to essentially be like a `dialog` - move focus to it when opened, possibly make it modal so focus is maintained inside it and the rest of the page
is hidden/inert.

but for now, removing the incorrect attribute is probably the quickest, most immediate fix.
2019-02-19 11:25:36 +02:00
XhmikosR
3aeda9942d
tests: use jQuery from node_modules. (#28059) 2019-01-15 18:01:40 +02:00
Mark Otto
eda851ee76 Prep for v4.2.0 release
- Move 4.1 docs to 4.2
- Update versions everywhere to 4.1.3 with release script
- Manually bump the shorthand version in package.json
- Add 4.2 to the versions docs page
- Update some redirects
- Fix tests asset URLs
- Bump Nuget and more
2018-12-21 09:03:29 -08:00
XhmikosR
07b4b5907b
Revert "Remove now unnecessary shrink-to-fit viewport directive (#27818)" (#27855)
This reverts commit af484dc12c.
2018-12-16 16:39:48 +02:00
Patrick H. Lauke
af484dc12c
Remove now unnecessary shrink-to-fit viewport directive (#27818)
`shrink-to-fit=no` is not needed anymore - Apple removed the need for it from iOS9.3 onwards

See https://www.scottohara.me/blog/2018/12/11/shrink-to-fit.html and https://github.com/h5bp/html5-boilerplate/issues/2102
2018-12-15 01:05:49 +00:00
XhmikosR
ea575bc1a7 js/tests/visual: fix popper script.
Broken after 787441d.
2018-10-14 08:17:40 +03:00
Johann-S
d18045210c fix(tests): visual plugins tests 2018-07-23 17:29:53 -07:00
XhmikosR
2ef5b90136 Tighten htmllint's rules. (#24471) 2017-10-22 15:02:24 +03:00
XhmikosR
ee574b76a7 Switch to lowercase doctype. (#24217)
Having it uppercase doesn't offer anything and the lowercase version slightly improves gzip compression.
2017-10-03 19:34:59 +03:00
XhmikosR
499f9dc960 js/tests/visual/tab.html: fix HTML validation errors. (#24183) 2017-10-01 09:49:35 +03:00
Johann-S
2d87895089 Update path to our docs assets for visual tests 2017-06-04 11:08:31 +02:00
Pierre Vanduynslager
91b62941af Tabs/Scrollspy/.nav/.list-group/.active independent of markup (<nav>, .nav-item, <li> etc...) 2017-04-02 11:21:04 +02:00
Johann
1a46d8c730 Allow to use Tab.js with list-group (#21756)
* Allow to use Tab.js with list-group

* Allow to use list-group with div parent instead of an ul parent
2017-03-18 16:36:33 -07:00
Mark Otto
e2b6badb86 v4: Rip out IE compatibility mode meta tags (#21483)
* Remove IE compatibility mode meta tag from docs, examples, and JS tests as we no longer support IE9 and IE8
* update and remove some IE bits from our supported browser page
* update introduction.md to match
* reword starter template intro
2016-12-31 12:20:32 -08:00
Johann-S
026e1a1421 Allow to use nav with tab JS 2016-12-31 00:54:00 -08:00
Mark Otto
55413e109f nuke local test vendor jquery and tether, replace with docs assets 2016-12-31 00:52:08 -08:00
Bardi Harborow
b9e7cef965 Update visual tests. 2016-11-13 02:34:18 +11:00
Chris Rebert
25cf50a4ac JS visual tests: Remove usages of defunct .page-header class
[skip sauce]
2016-02-27 18:01:12 -08:00
XhmikosR
7a85751144 Remove html5shiv and respond.js from test files. 2015-10-26 23:57:19 +02:00
Jacob Thornton
03e732708c rewrite tab with new active shit 2015-08-18 22:03:34 -07:00
fat
8eee78ca15 tab es6 2015-05-11 12:29:06 -07:00
fat
d1fbe200f4 remove closureness from plugins 2015-05-06 13:34:14 -07:00
fat
834220ea20 bootstrap onto closure 2015-02-11 11:29:43 -08:00
Chris Rebert
a28e25c00b Remove IE8 compat shims from JS visual tests 2014-12-15 11:38:57 -08:00
Heinrich Fenkart
425a985491 Update head of all visual tests to use our basic template 2014-11-05 01:18:11 +01:00
Heinrich Fenkart
282f8fc04b Add a few more cases to the visual test tab page 2014-06-25 04:18:51 +02:00
fat
91103e6d1f Adds isolated visual tests for javascript plugins (decoupled from docs). This makes it
faster and easier to test/develop js functionality not represented in unit tests, and gives us
a playground for interactions, etc.

It also makes it so developing javascript is now decoupled form jekyll, which should make everything
faster and less painful.

This commit also reverts my filter commit 9900771aa7
which broke scrollspy for dropdowns.
2014-06-07 19:11:44 -07:00