Patrick H. Lauke
adc857f617
Extra check for existence of any aria-label
...
before overwriting it...
2020-11-30 12:07:51 +02:00
Matty Williams
b0372bb658
Accessibility update for tooltip.js
...
Update to the tooltip.js to add an aria-label attribute that contains the original title of the element, but only if the element doesn't have an existing aria-label attribute.
This is to address cases where screen readers are not capturing the aria-describedby attribute that is added when the tooltip is triggered. This should also avoid a race condition between the screen reader and the appearance of the tooltip.
2020-11-30 12:07:51 +02:00
Rohit Sharma
04674f88b0
Remove setData from construtors ( #32264 )
2020-11-29 20:58:26 +02:00
Johann-S
4999c3dbbc
remove data key in base component
2020-11-29 20:58:26 +02:00
Rohit Sharma
f6a8733741
Move VERSION
to BaseComponent ( #32254 )
2020-11-29 20:58:26 +02:00
Johann-S
9eb9d02084
add dispose in base component
2020-11-29 20:58:26 +02:00
Johann-S
9f6b342dc7
create a base component
2020-11-29 20:58:26 +02:00
Rohit Sharma
c348ad4a94
Ability to add custom class in tooltip/popover ( #32217 )
...
Porting of #31834 to main.
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-25 09:16:22 +02:00
XhmikosR
f4457bca02
Be consistent with Popper's name. ( #32224 )
...
The npm package is named "popper.js" but the project is named "Popper", so use the latter consistently.
2020-11-21 16:22:08 +02:00
Rohit Sharma
0839cbf04d
Don't hide modal when keyboard is set to false in modal's configuration ( #32179 )
...
* Don't hide modal when config.keyboard is false
* Update unit test
- Modal should not be closed when pressing esc key if keyboard = false
and backdrop is 'static'
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-20 15:36:24 +02:00
Rohit Sharma
2630b05eb3
Make the attribute methods bs specific ( #32173 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-20 11:13:13 +02:00
XhmikosR
eaf616c653
Use Array.find
instead of Array.filter
2020-11-14 15:54:50 +02:00
XhmikosR
53ec604eb1
Use String.startsWith
2020-11-14 15:54:50 +02:00
XhmikosR
6d7bc54d22
Switch to Set#has()
2020-11-14 15:54:50 +02:00
XhmikosR
2e758f64cf
Switch to Number properties
2020-11-14 15:54:50 +02:00
XhmikosR
b9f7668cf6
Switch to String.includes()
2020-11-14 15:54:50 +02:00
XhmikosR
470e99ed5f
tooltip.js: deduplicate _fixTitle()
( #32124 )
2020-11-14 15:43:25 +02:00
Rohit Sharma
e530118117
Get only bs prefixed data attributes
2020-11-14 07:09:15 +02:00
Rohit Sharma
418f17ee2b
Add bs
in data attributes
...
- Add `bs` in data APIs everywhere
- Update unit tests
2020-11-14 07:09:15 +02:00
XhmikosR
384eccbfaf
Prepare v5.0.0-alpha3 ( #32122 )
2020-11-11 19:07:37 +02:00
XhmikosR
13572a6867
Remove the now unneeded polyfills.
2020-11-05 15:37:34 +02:00
XhmikosR
e8f1709adf
Drop Legacy Edge support.
...
This allows us to move forward without being held back. Microsoft already replaces the Legacy Edge with the new one on supported Windows versions.
2020-11-05 15:37:34 +02:00
XhmikosR
b864973a94
dropdown.js: simplify code ( #32055 )
2020-11-03 16:43:20 +02:00
XhmikosR
59692ce862
karma: stop excluding polyfill.js from istanbul ( #30740 )
2020-11-01 15:52:24 +02:00
XhmikosR
421e2482e2
Streamline jQuery comment. ( #32016 )
2020-11-01 15:49:51 +02:00
Sascha
c21506d499
Fix TypeError when Bootstrap is included in head
( #32024 )
...
* extend jquery after domContentLoaded event is fired
* add unittest for util onDOMContentLoaded
* wait for trigger jquery event after domContentLoaded
* remove domcontentready from eventHandler
* move istanbul ignore statements to correct line
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-01 15:32:36 +02:00
Mitchell Bryson
3a5f9f5cf0
Check for data-interval on the first slide of carousel ( #31818 )
...
* check for data-interval on the first slide of carousel
* add updateInterval method for elements of a carousel
* add test for carousel interval being set during cycle
* update activeElement as soon as slide has finished (before transition end)
* only updateInterval before using it
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-01 14:36:50 +02:00
XhmikosR
e6f8428b28
polyfill.js minor tweaks ( #32011 )
...
* rename function to `supportsScopeQuery`
* use a ternary in `findOne` function return value
2020-11-01 07:38:55 +02:00
XhmikosR
0c1651ee9d
Remove Manipulator.toggleClass
( #31842 )
...
It's only used in one place so it makes more sense to remove it for the time being.
2020-10-05 18:07:49 +03:00
XhmikosR
b083c9639f
Prepare v5.0.0-alpha2. ( #31748 )
2020-09-29 18:33:00 +03:00
Hiws
43b4252a34
fix tooltip hide method when already hidden ( #31115 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-09-24 14:55:38 +03:00
XhmikosR
b345746bb6
Join template literals
2020-07-12 15:52:25 +03:00
XhmikosR
6d86b140f9
Add parentheses around multiple spread conditions
2020-07-12 15:52:25 +03:00
XhmikosR
a67231ae1c
Move function
2020-07-12 15:52:25 +03:00
XhmikosR
0eb120eea0
tooltip.js: remove variable used once.
2020-07-12 15:52:25 +03:00
XhmikosR
b97fcd3289
scrollspy.js: minor refactoring
2020-07-12 15:52:25 +03:00
XhmikosR
f15af45c6e
Unbreak lines.
2020-07-12 15:52:25 +03:00
Rohit Sharma
91c11d6465
toasts: make default duration 5s ( #31109 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-07-12 15:43:26 +03:00
Rohit Sharma
f6348f6c89
Clear timeout before showing the toast ( #31155 )
...
* clear timeout before showing the toast
* Add unit test
* Remove the check for timeout
* Check for clearTimeout to have been called
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-07-11 11:51:04 -07:00
Shohei Yoshida
fb4efb49ea
Prevent overflowing static backdrop modal animation ( #30326 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-06-25 11:35:53 +03:00
Patrick H. Lauke
edbcc401c2
Change whitelist to allowlist ( #31066 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
2020-06-19 11:31:37 +03:00
Tanguy Krotoff
d80a9fc553
Fix tooltip when hovering a children element (delegateTarget) ( #30928 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-06-18 10:02:44 +03:00
XhmikosR
12b754800c
collapse.js: return early.
2020-06-17 16:58:56 +03:00
XhmikosR
8debdf6ce6
Remove a couple of variables used once
2020-06-17 16:58:56 +03:00
XhmikosR
94a5d87e15
Unbreak short lines
2020-06-17 16:58:56 +03:00
Johann-S
088c727a31
data: reword storage key in dom
2020-06-17 15:45:36 +02:00
XhmikosR
c28934cb18
Rename "master" to "main". ( #31050 )
2020-06-16 21:41:47 +03:00
Martijn Cuppens
1a0a0858ef
Remove checkbox/radio toggle from button plugin in favor of a CSS only solution
2020-06-15 19:04:19 -07:00
Rohit Sharma
5faf41eb48
Add role="dialog" in modals via JavaScript ( #30936 )
2020-06-04 10:35:09 +03:00
XhmikosR
7966167cf6
Replace double tilde with Math.floor
( #30691 )
...
Nowadays, browser engines have improved a lot and `Math.floor` is the same, if not faster.
Also, clarity is better than micro-optimizations in this case.
2020-05-14 09:46:42 +03:00