Johann-S
79d6b574cc
Escape ID in Util.getSelectorFromElement ( #24700 )
2017-11-07 12:41:06 +01:00
Johann-S
26dc17bcd2
Popover - call content
once if it's a function. ( #24690 )
2017-11-07 09:18:52 +02:00
Johann-S
41fbec1188
Fix unit tests.
2017-10-27 19:19:55 +03:00
Pierre-Denis Vanduynslager
6fe72c6de8
Dropdown handle keydown on input and textarea.
2017-10-27 19:19:55 +03:00
Johann-S
988327032d
Add unit tests for util.js
2017-10-25 12:59:40 +02:00
Johann-S
62fbb23ee6
Change Rollup config to wrap our dist files with jQuery instead of $
2017-10-24 12:39:25 +02:00
Johann-S
1487c3a994
Add Util.jQuery
which will detect jQuery instead of relying on global $
( #24513 )
2017-10-23 10:35:27 +03:00
XhmikosR
be9e6f3638
Update modal.js
2017-10-04 15:03:06 +03:00
lucascono
47968c8126
Unit test for modal bug fix
...
Unit test for pull request #24240
2017-10-04 08:55:40 -03:00
XhmikosR
31c8721913
Normalize all links. ( #24109 )
...
* use a trailing slash when possible
* use https when possible
* remove a few redirected links
* consistently use `https://popper.js.org/ `
* fix `iconUrl` in nuget files
* change Jekyll Windows guide to the official one
2017-09-26 15:24:14 +03:00
Johann-S
9b8356ba52
Collapse - Allow to pass jQuery object or DOM element to the parent option
2017-09-25 13:23:13 +02:00
Patrick H. Lauke
fd56ea370c
Accessibility fixes to dynamic tabs (aria-selected
, remove dynamic tabs with dropdowns)
...
* Use `aria-selected` instead of `aria-expanded`
* Change tab.js to use `aria-selected` rather than `aria-expanded`
* Add `aria-orientation=vertical` to vertical tab list
* Remove dynamic tabs with dropdowns
* Fix non-interactive code examples
* Only set `aria-selected` on the `role="tab"` trigger - this stops `aria-selected` being incorrectly added to the `role="tabpanel"` itself (probably harmless, but nonetheless incorrect)
2017-09-24 12:00:54 +02:00
Troy Morehouse
6c70c70f63
fix(scrollspy): Spying on nested navs fails to activate for .nav-link's inside nav-item's ( #23967 )
...
* fix(scrollspy): Handle nested navs when nav-link inside nav-item
* [scrolspy] Find only child .nav-link's inside .nav-item
* [scrollspyt] Add tests for nested navs with nav-link inside nav-item
* fix troy-o's in test
2017-09-17 09:30:37 +02:00
Johann-S
e04e42d08c
Merge branch 'v4-dev' into fix-jumping-modal-on-resize
2017-09-03 12:56:04 +02:00
David Bailey
ce41d3fd15
Add failing test
2017-08-29 15:36:37 +01:00
David Bailey
2622a015f2
Fix unit tests in PhantomJS
...
Use a virtual scrollbar as this is simpler than having a real one (overflow: scroll doesn't seem to work in Phantom), and disable it for the new test.
One test has also been altered to prevent erroneous fails when other inline styles are added to the body (e.g. overflow).
2017-08-29 12:01:41 +01:00
David Bailey
487513ff03
Add failing test
...
When the body does not overflow (achieved by hiding the QUnit container), it should not be given a margin.
2017-08-28 16:21:04 +01:00
meeque
9612830701
Add unit test for xss in data target attribute
2017-08-25 23:20:14 +01:00
David Bailey
ba6a6f1369
Fix sticky margin when a modal is opened ( #23669 )
...
* Adjust margin for sticky elements on modal
Previously white space was visible to the right of sticky elements due to right padding being added to the body. This fixes #23661 .
* Add unit tests for margin of sticky elements on modal
2017-08-25 22:01:41 +01:00
Johann-S
5a90b4aa3e
Collapse - preventDefault only on <a> elements not inside the collapsible
...
element
2017-08-25 09:48:35 +01:00
Johann-S
4571ab0e57
Fix toggle for Tooltips/Popover which was called even if the Tooltip/Popover was disabled
2017-08-24 09:33:49 +01:00
XhmikosR
ef8c77d8dc
Tweak ESLint rules.
2017-08-23 00:05:38 +03:00
Johann-S
58994a16c5
Add a unit test to check if the carousel do not cycle when its parent isn't visible
2017-08-17 17:48:14 +01:00
Johann-S
d2bd8fb7a9
Unit test to check if our carousel do not cycle when we cannot see it
2017-08-17 17:48:14 +01:00
Johann-S
2eb1e687bd
Improve previous selector for nested tabs
2017-08-11 15:04:07 +03:00
Johann-S
edf90c1bc4
Add unit test for nested tabs
2017-08-11 15:04:07 +03:00
Johann-S
0480a75a5a
Dropdown - Disable applyStyle modifier instead of removing inline style applied by Popper.js
2017-07-04 10:37:44 +02:00
Mark Otto
9c0e423008
Rename popover classes
...
Part of an update to align the naming schemes across our components.
- Renames .popover-title to .popover-header
- Renames .popover-content to .popover-body
Refs: #22092
2017-06-15 09:05:30 -07:00
Johann-S
f0124769c9
Collapse supports multi-target thanks to @vanduynslagerp ( #22713 )
2017-06-14 13:21:49 +02:00
Johann-S
4a2b183e48
Fix unit tests with no assertion
2017-06-14 11:18:12 +02:00
Geremia Taglialatela
db44e4b311
Update nav and navbar HTML markup
...
According to the docs, you just need to apply the `navbar-nav` to an
`<ul>` tag in a list-based navbar. In fact, `navbar-nav` seems to
override all the css properties set by `nav`.
Also, `nav-item` class should be used only for `<li>` tags, or in
conjunction with `<a>` tags to entirely avoid the list-based approach.
This commit removes the redundant `nav` class from `navbar-nav` `<ul>`
tags, moves `nav-item` from `<a>` tags to `<li>` tags and properly
adds `nav-item` class to `<li>` tags where missing.
Refs:
* https://v4-alpha.getbootstrap.com/components/navs/
* https://v4-alpha.getbootstrap.com/components/navbar/#nav
2017-05-27 15:21:49 -07:00
Johann-S
53ee455bc7
Handle dropup for Dropdown
2017-05-14 11:41:19 +02:00
Johann-S
69de65180f
Fix unit tests + Update Popper to 1.6.0
2017-05-14 11:41:19 +02:00
Johann-S
d8996a7e0a
Fix arrow for tooltip and popover
2017-05-14 11:41:19 +02:00
Johann-S
b40b1bc396
Add attachment classes
2017-05-14 11:41:19 +02:00
Anna
33715a73d2
Fix Toggle buttons don't honor [disabled] or .disabled
2017-04-26 18:46:05 +02:00
Pierre Vanduynslager
ab39defe74
Detach accordion from card without requiring 'data-children'
2017-04-25 09:32:14 +02:00
Bardi Harborow
b4ac48fdec
Build system overhaul.
2017-04-20 14:31:22 +10:00
Patrick H. Lauke
6ae5fb12e6
Fix carousel "hover" behavior on touch-enabled devices
...
* Add carousel mouse listeners even if touch events enabled
- touch events are enabled not just on "mobile", just also on
touch-enabled desktop/laptop devices; additionally, it's possible to
pair a mouse with traditionally touch-only devices (e.g. Android
phones/tablets); currently, in these situations the carousel WON'T pause
even when using a mouse
* Restart cycle after touchend
as `mouseenter` is fired as part of the touch compatibility events, the
previous change results in carousels which cycle until the user
tapped/interacted with them. after that they stop cycling (as
`mouseleave` is not sent to the carousel after user scrolled/tapped
away).
this fix resets the cycling after `touchend` - essentially returning
to the previous behavior, where on touch the carousel essentially never
pauses, but now with the previous fix it at least pauses correctly for
mouse users on touch-enabled devices.
includes documentation for this new behavior.
2017-04-17 13:26:46 +01:00
Pierre Vanduynslager
025ddb185e
Merge branch 'v4-dev' into dropdown-keyboard
2017-04-10 11:04:05 -04:00
Patrick H. Lauke
18e8704221
Fix collapse.js aria-expanded behavior
...
* Remove aria-expanded from collapse.js target element
aria-expanded="true"/aria-expanded="false" only applies to the trigger,
not the element that is being expanded/collapsed.
* Tweak collapse.js accessibility section
...to make it clearer that the aria-expanded attribute always just goes
on the control.
* Fix collapse.js unit tests
- reword some of the text to make it clear we're checking behavior of
trigger/control
- move incorrect aria-expanded out of the <div>s and to the actual
trigger/control <a>s
- fix incorrect test assertion text output false -> true
2017-04-10 14:51:22 +01:00
Patrick H. Lauke
3f6e1faf45
Only change aria-pressed if it's not an input-based radio or checkbox group
...
* Only change aria-pressed if it's not an input-based radio or checkbox group
aria-pressed="true"/aria-pressed="false" is really only useful for
making on/off toggles out of, say, `<button>` elements. the attribute is
useless (and potentially confusing/conflicting) on, say, `<label>`
elements for an existing `<input type="radio">` or similar.
* Add unit test for buttons.js and radio/checkbox inputs in button groups
2017-04-10 14:43:54 +01:00
Pierre Vanduynslager
fe72daf2b3
Merge branch 'v4-dev' into dropdown-keyboard
2017-04-08 18:43:25 -04:00
Ilias
e6e070b02a
Fix #22332 : Adjust tests for hidden scrollbar
2017-04-03 13:27:15 +02:00
Ilias
a14451deb3
Fix #18373 : properly adjust padding-right of body and fixed elements when opening or closing modal
2017-04-02 13:26:25 +02:00
Pierre Vanduynslager
91b62941af
Tabs/Scrollspy/.nav/.list-group/.active independent of markup (<nav>, .nav-item, <li> etc...)
2017-04-02 11:21:04 +02:00
Johann-S
5142de7e59
Popover + Tooltip - fix error when content or title is a number
2017-03-31 10:03:54 +02:00
Johann-S
fb42d6e043
Collapse - Fix check to not prevent event for input and textarea
2017-03-29 00:10:27 +02:00
Johann
904efc043d
Fix different tooltips offset when hovering
2017-03-28 15:55:03 +02:00
Johann
24924c23b2
Collapse - do not prevent event for input and textarea
2017-03-27 10:08:39 +02:00
Pierre Vanduynslager
37f438910f
Accordion behavior with JQuery interface ( #21726 )
...
Fix accordion behavior with JQuery interface
2017-03-23 21:15:41 +01:00
Johann
c72a315740
Carousel - Add attributes from and to for Slid and Slide events ( #21668 )
...
Carousel - Add attributes from and to for Slid and Slide events
2017-03-22 22:42:13 +01:00
Pierre Vanduynslager
78fc4d23fc
Always append element to fixture in Scrollspy unit tests ( #22234 )
2017-03-21 10:21:00 -07:00
Mark Otto
3730c5dbf5
Merge branch 'collapse' of https://github.com/Johann-S/bootstrap into Johann-S-collapse
2017-03-19 18:43:13 -07:00
Johann
1a46d8c730
Allow to use Tab.js with list-group ( #21756 )
...
* Allow to use Tab.js with list-group
* Allow to use list-group with div parent instead of an ul parent
2017-03-18 16:36:33 -07:00
Johann-S
21b537cc24
Add unit test
2017-03-09 11:08:47 +01:00
Pierre-Denis Vanduynslager
4ab576a419
Fixes #21941
2017-02-08 18:51:50 -05:00
Pierre-Denis Vanduynslager
ef2181ff4d
Harmonize document.activeElement comparison
2017-01-20 23:22:50 -05:00
Pierre-Denis Vanduynslager
4448ca057b
Refactor test to event and async
2017-01-20 23:02:45 -05:00
Pierre-Denis Vanduynslager
1a783a4255
Add unit test for keyboard navigation
2017-01-20 23:02:19 -05:00
Pierre-Denis Vanduynslager
9daf681478
Fix test to retrieve the proper item instead of it's parent
2017-01-20 20:27:14 -05:00
Pierre-Denis Vanduynslager
4c2f544359
Merge branch 'twbs/v4-dev' into dropdown-keyboard
2017-01-06 15:57:15 -05:00
Pierre-Denis Vanduynslager
eb84c03ddf
Update dropdown unit test to new markup
2017-01-06 15:56:38 -05:00
Johann-S
0463b01282
Close #21090 - Fix aria-pressed attribute for buttons in container with data-toggle='buttons'
2017-01-04 11:02:16 +01:00
Pierre-Denis Vanduynslager
bbb0d2b573
Dropdown: close menu when focusing outside element ( #21375 )
...
* Close dropdown menu when focusing an outside element
* Update unit test to new markup
2017-01-02 14:44:27 -08:00
Mark Otto
c61a0059ad
update seletors in js
2017-01-02 11:52:38 -08:00
Johann-S
026e1a1421
Allow to use nav with tab JS
2016-12-31 00:54:00 -08:00
Johann-S
95ce03f000
Close #21249 : Add a Unit test for #21227
2016-12-29 13:28:42 -08:00
Max Beatty
aa7f95fd77
update click state when hiding so can be shown again by trigger. fixes #16732
2016-12-27 14:19:12 -08:00
Alessandro Rodi
9103bffe37
[ Fix #19849 ] Tabs are opened even if disabled. ( #20795 )
...
* [Fix #19849 ] Tabs are opened even if disabled.
* fix hund code review hints
* rollback hound issues because Travis fails
2016-12-24 23:31:34 -08:00
Matheus Azzi
dab6a41e04
Carousel: Only prevents default for ARROW_LEFT and ARROW_RIGHT keys
...
Fixes 2 bugs:
1. All keydowns were being prevented. Because of that the user wasn't able to navigate in the whole page using ARROW_UP/ARROW_DOWN.
2. Even when is an input or textarea the keydowns were being prevented. Because of that the user wasn't able to type any text on these elements.
2016-12-23 17:55:40 +11:00
Starsam80
bf39bb3ac3
Rename .active
to .show
2016-12-07 21:20:15 -07:00
Rob Ruana
5eddb0b0fd
Closes #21055 : Prevents ScrollSpy from clearing active item when Safari rubberbands ( #21056 )
...
When the rubberband effect causes Safari to scroll past the top of the
page, the value of scrollTop becomes negative. If the offset of the first
ScrollSpy target is 0 - essentially if the target is at the top of the
page - then ScrollSpy should not clear the active item. Conceptually, the
first item should remain active when rubberbanding past the top of the
page.
This commit fixes issue #21055 by verifying the first scrollspy target is
not at the top of the page before clearing the active nav-item.
2016-11-27 16:20:33 -08:00
Mark Otto
b6b8280938
Merge pull request #18900 from vlastikcz/v4-dev-buttonChange
...
Button toggling - trigger change event on input. Fixes #16673 , fixes #17599 .
2016-11-26 01:18:21 -08:00
Mark Otto
ce31f54c36
Merge pull request #19058 from Johann-S/carouselInput
...
Carousel - Do not prevent on keydown for input and textarea
2016-11-26 01:14:55 -08:00
Mark Otto
25d218b02d
Merge branch 'v4-dev-18796' of https://github.com/maxbeatty/bootstrap into maxbeatty-v4-dev-18796
2016-11-26 00:58:51 -08:00
Johann
ce18a66809
Add test unit to check logic of ignoreBackdropClick ( #18245 )
2016-11-25 22:57:20 -08:00
Mark Otto
432fe74c31
Merge branch 'eslint' of https://github.com/bardiharborow/bootstrap into bardiharborow-eslint
2016-11-25 14:59:28 -08:00
Matt Hernandez
b1b1f30cbd
[ Fix #17371 ][V4] Deactivating dropdown links in nav tab ( #17642 )
...
* Fix bug with dropdown tab links not deactivating when other tab or dropdown link is clicked
* Revise bug fix for more stability
2016-11-25 14:56:41 -08:00
Bardi Harborow
c2616fb74e
Make JS compliant with the new ESLint rules.
2016-11-24 11:59:55 +11:00
Johann
a7f1b59959
Making .tooltip('show') throw an error on elements with display:none ( #20940 )
2016-10-31 20:33:53 -07:00
Mark Otto
c01fa6b369
Merge pull request #17536 from Johann-S/testPadding
...
[Fix #17400 ] Add tests about padding restoration
2016-10-28 13:46:14 -07:00
Johann-S
9d129a43d6
Use a single class name for opened/expanded/shown state of widgets
2016-10-25 14:07:41 +02:00
Mark Otto
73154d0392
Merge pull request #20467 from maxbeatty/v4-dev-17754
...
add support for ol in tab plugin
2016-10-24 20:50:52 -07:00
Johann-S
9bc7de9395
Fix bug multiple accordions collapse
2016-10-19 09:35:48 +02:00
Johann-S
de1255b14e
Collapse using card component
2016-10-11 13:25:36 +02:00
Mark Otto
4d725c90d6
Merge pull request #17568 from Johann-S/fixCollapseHeight
...
[Fix #17555 ][V4] fix resetting style on closing collapse
2016-10-09 20:32:40 -07:00
VarelloThemes
63129112bb
replace some profanities ( #20715 )
2016-09-15 09:39:31 -07:00
Max Beatty
dc1b4e78d4
add support for ol in tab plugin. fixes #17754
2016-08-04 16:57:08 -07:00
Max Beatty
bfa714ae1e
prevent navigating to area href when modal target. fixes #18796
2016-08-04 13:47:30 -07:00
Dave Methvin
8900d953ed
ScrollSpy unit test: Use single done() in a then() instead of multiple done()s ( #20198 )
...
Fixes test flakiness on OS X Safari and Android when using jQuery 3.
Fixes #20182 more
Refs #20191
2016-06-28 13:24:28 -07:00
Dave Methvin
208d587c7e
Scrollspy test: Allow for async .then() in jQuery 3; fixes #20182
...
Instead of doing a new assert.async(), just do a single one for the entire test
and let the .then() be async as well.
Closes #20190
2016-06-27 22:37:31 -07:00
Chris Rebert
aa369bd8f9
Remove unnecessary usage of Promises in non-async ScrollSpy tests ( #20180 )
...
Closes #19906
[skip validator]
2016-06-26 21:33:07 -07:00
Chris Rebert
14c7ba95f9
Fix load & scroll event usage in ScrollSpy tests ( #19986 )
...
* Use $.one() instead of $.on() since there are no $.off()s in the code.
* Remove unnecessary namespacing of listeners for the `scroll` & `load` events.
These are vanilla DOM events (not custom jQuery namespaced events)
and we're not using jQuery namespacing to manage these event listeners either (e.g. `$.off()`).
[skip validator]
2016-05-30 09:39:45 -07:00
Chris Rebert
d35973c2b3
js/tests/unit/scrollspy.js: Fix "offsed" typos ( #19985 )
...
[skip sauce]
[skip validator]
2016-05-29 18:36:09 -07:00
Patrick H. Lauke
b107e3342a
Handle aria-hidden on modal container when showing/hiding
...
Fixes #19878
2016-05-11 02:01:56 +01:00
Johann-S
14ec4fdfc1
Carousel - Do not prevent on keydown for input and textarea
2016-02-01 00:06:07 +01:00
Kotas Vlastimil
866e99b00c
Button toggling - trigger change event on input
...
Bootstrap’s .button styles can be applied to other elements, such as labels, to provide checkbox or radio style button toggling.
When the checkbox or radio state is changed, there should be triggered the change event. Currently, the change event is triggered on the Button, which is not correct. Only input fields do support the change event.
2016-01-14 20:26:32 +01:00
Chris Rebert
96e9205009
js/tests/unit/modal.js: Fix typo
...
[ci skip]
2015-12-22 17:11:21 -07:00
Johann-S
21a65f181e
Add throw error for undefined method on plugins
2015-10-02 10:01:24 +02:00
Johann-S
32f9a5d6a5
fix resetting style on closing collapse
2015-09-11 10:45:08 +02:00
Johann-S
8ece899ba8
Add tests about padding restoration
2015-09-10 08:19:59 +02:00
Gleb Mazovetskiy
c7d8e7a077
Accept elements as the tooltip / popover content
...
When a DOM node is passed to an HTML tooltip, the `title` node is only
moved if it is not already in the tooltip. Otherwise, `empty()` is used
instead of `detach()` before appending the `title` to avoid memory
leaks. If a DOM node is passed to a plain text tooltip, its text is
copied via jQuery `.text()`.
Replaces `.detach()` with `.empty()`, as `.detach()` is almost never
useful but instead leaks memory. The difference between `empty` and
`detach` is that the latter keeps all the attached jQuery events/data.
However, since we do not return the previous children, the user would
have to keep these themselves, thus they can `detach()` if necessary.
This is a port of https://github.com/twbs/bootstrap/pull/14552 to v4.
2015-08-31 01:06:13 +01:00
XhmikosR
13e33e329c
Remove the obsolete JSHint references.
2015-08-27 08:11:11 +03:00
Jacob Thornton
03e732708c
rewrite tab with new active shit
2015-08-18 22:03:34 -07:00
Jacob Thornton
4e45e2363c
Merge branch 'v4' of github.com:twbs/derpstrap into v4
2015-08-18 21:23:53 -07:00
Jacob Thornton
18ff57a183
js tests passing + eslint
2015-08-18 19:22:46 -07:00
Jacob Thornton
f1827e5f9c
add polyfil for bind for tether.js
2015-08-18 17:06:17 -07:00
Mark Otto
1ddc3f5e21
Merge branch 'master' into v4m
2015-08-04 22:29:45 -07:00
Johann-S
ef1ce9ac0b
Fix triggering of {shown,hidden}.bs.dropdown events so relatedTarget gets set properly
...
Fixes #16828
Closes #16865
2015-07-27 00:58:51 -07:00
Mark Otto
169d2a4a78
Merge branch 'master' into v4
2015-06-18 23:56:43 -07:00
Patrick H. Lauke
5fd7bc1554
generalize dropdowns / drop role="menu"
...
as role="menu" is a very specific (and strict) ARIA pattern for
desktop-like application menus, and our dropdowns are often used
as pure navigation dropdowns, this change abandons ARIA menus for
a more open-ended and light-weight approach
(see http://heydonworks.com/practical_aria_examples/#submenus and
http://www.w3.org/WAI/tutorials/menus/flyout/#improve-screen-reader-support-using-wai-aria )
note that in dropdown.js, switched to now target ``.dropdown-menu``
instead of ``role["menu"]`` - this also prevents bootstrap scripts
from "bleeding" into non-bootstrap components on the same page.
also removed the ``role=["listbox"]`` part, which appears to be
vestigial/unused (only place in bootstrap that uses that
role are carousels, and their key handling is done separately)
2015-06-02 11:03:21 +01:00
XhmikosR
315907c97c
Use https
when possible.
2015-05-17 12:43:20 +03:00
fat
6b2b0ed32f
al tests passing, dist rebuilt, w/typechecker
2015-05-13 14:52:46 -07:00
fat
eaab1def7a
add simple type checker implementation
2015-05-13 14:46:50 -07:00
fat
c2ced2292a
fix up tests
2015-05-13 13:46:08 -07:00
fat
b0d142334f
fix #15301
2015-05-13 13:43:56 -07:00
fat
da495ee24c
address https://github.com/twbs/bootstrap/pull/16135
2015-05-13 13:15:11 -07:00
fat
f8b2569ec8
implement global dispose method
2015-05-13 12:48:34 -07:00
fat
ab1578465a
grunt test-js, grunt dist-js now working
2015-05-12 16:52:54 -07:00
fat
a58febf71a
popover passing as well
2015-05-12 14:35:00 -07:00
fat
3452e8dc83
rewritten tooltip + tether integration and death to our positioner jank
2015-05-11 23:32:37 -07:00
fat
ca9c850ebb
add getters for Version and Default where applicable
...
add modal my gawd
2015-05-10 19:45:38 -07:00
fat
8bab38bb71
add collapse
2015-05-09 23:04:58 -07:00
fat
1b183e2ff7
carousel -> es6
2015-05-07 22:26:40 -07:00
fat
6605051882
button -> es6
2015-05-07 17:14:38 -07:00
fat
0724bd91ff
es6 alert :|
2015-05-07 12:57:31 -07:00
fat
d1fbe200f4
remove closureness from plugins
2015-05-06 13:34:14 -07:00
XhmikosR
a2f81ceb57
phantom.js: switch to unicode characters that work on Windows too.
2015-05-05 06:58:54 +03:00
XhmikosR
49c4556354
Comply to the new JSCS rules.
2015-05-05 06:50:18 +03:00
Chris Rebert
aa2c5b5672
Merge pull request #16014 from redbmk/issue-16008
...
Multiple tooltip triggers don't play well together
2015-05-04 15:07:17 -07:00
Patrick H. Lauke
0c1daaf2ce
Remove broken/vestigial unit test
...
Overall logic for this test appears broken, possibly relating to an
older version of Bootstrap that did not require explicit
`data-toggle="button"` on single toggle buttons?
2015-05-01 12:58:10 +01:00
Braden M. Kelley
4b269037cb
Multiple tooltip triggers don't play well together
...
Fixes issue #16008
2015-04-27 23:03:56 -07:00
F A T
aa479892d5
Merge pull request #16152 from jarthod/tooltip-placement-viewport-fix
...
Tooltip/popover: Fix auto placement to use viewport
2015-04-27 11:28:54 -07:00
Chris Rebert
cdb37dce3a
Set box-sizing: border-box
on .container-viewport in #16142 testcase
...
Otherwise, the test doesn't properly fail when the fix is reverted.
2015-04-27 01:23:39 -07:00
Adrien
37a10d37c1
Compare tooltip right offset to viewport right offset (and not width)
...
Closes #16142 by merging it.
2015-04-27 01:13:16 -07:00
Chris Rebert
fc372952e2
Throw error when tooltip/popover template has multiple top-level elements
...
Closes #16219 .
2015-04-25 13:16:53 -07:00
Chris Rebert
0d77644fc4
throw error when trying to show tooltip on :hidden element
2015-04-23 17:14:45 -07:00
Adrien Siami
e949505b89
Allow viewport option to be a function
...
Closes #16151 by merging a rebased version of it that adds docs and 1 more assertion.
2015-04-21 22:20:15 -07:00
Chris Rebert
c6b62f0cd9
Merge pull request #16147 from Johann-S/event_inserted
...
Fixes #16124 .
2015-04-21 21:40:14 -07:00
Patrick H. Lauke
66d71136e6
Fix existing radio button unit test
2015-04-11 19:24:21 +02:00
Johann-S
3d71eae301
Add event after template inserted
2015-04-08 13:10:53 +02:00
Adrien Jarthon
5921724d9c
fixed IE incompatible CSS
2015-03-29 19:16:59 +02:00
Adrien Jarthon
df96c3e615
Added non-regression test & fixed existing one
2015-03-29 14:59:21 +02:00
Mark Otto
58082cd83e
Merge branch 'master' into v4
...
Conflicts:
.gitignore
Gruntfile.js
_config.yml
dist/css/bootstrap-theme.css
dist/css/bootstrap-theme.min.css
dist/css/bootstrap.css
dist/css/bootstrap.css.map
dist/css/bootstrap.min.css
dist/js/bootstrap.js
dist/js/bootstrap.min.js
docs/_includes/components/navbar.html
docs/_includes/components/progress-bars.html
docs/_includes/css/grid.html
docs/_includes/css/overview.html
docs/_includes/customizer-variables.html
docs/_includes/getting-started/accessibility.html
docs/_includes/getting-started/browser-device-support.html
docs/_includes/getting-started/community.html
docs/_includes/getting-started/disabling-responsiveness.html
docs/_includes/getting-started/download.html
docs/_includes/getting-started/examples.html
docs/_includes/getting-started/license.html
docs/_includes/getting-started/third-party-support.html
docs/_includes/js/alerts.html
docs/_includes/js/buttons.html
docs/_includes/js/carousel.html
docs/_includes/js/collapse.html
docs/_includes/js/dropdowns.html
docs/_includes/js/modal.html
docs/_includes/js/popovers.html
docs/_includes/js/scrollspy.html
docs/_includes/js/tabs.html
docs/_includes/js/tooltips.html
docs/_includes/js/transitions.html
docs/_includes/nav/javascript.html
docs/_includes/nav/main.html
docs/about.html
docs/assets/css/docs.min.css
docs/assets/css/src/docs.css
docs/assets/js/customize.min.js
docs/assets/js/raw-files.min.js
docs/assets/js/src/customizer.js
docs/dist/css/bootstrap-theme.css
docs/dist/css/bootstrap-theme.min.css
docs/dist/css/bootstrap.css
docs/dist/css/bootstrap.css.map
docs/dist/css/bootstrap.min.css
docs/dist/js/bootstrap.js
docs/dist/js/bootstrap.min.js
docs/migration.html
js/affix.js
js/alert.js
js/button.js
js/carousel.js
js/collapse.js
js/dropdown.js
js/modal.js
js/popover.js
js/scrollspy.js
js/tab.js
js/tests/unit/affix.js
js/tests/unit/button.js
js/tests/unit/carousel.js
js/tests/unit/modal.js
js/tests/unit/tooltip.js
js/tests/visual/modal.html
js/tooltip.js
less/component-animations.less
less/jumbotron.less
less/mixins/background-variant.less
less/mixins/buttons.less
less/mixins/responsive-visibility.less
less/mixins/text-emphasis.less
less/navbar.less
less/navs.less
less/scaffolding.less
less/tooltip.less
less/utilities.less
less/variables.less
package.json
scss/_buttons.scss
scss/_forms.scss
scss/_modal.scss
2015-03-29 00:08:54 -07:00
Chris Rebert
6c5e7dfce1
rm redundant aria-hidden usage from Modals; fixes #16020
2015-03-25 18:06:47 -07:00
Chris Rebert
d37bc2ae65
Merge pull request #15987 from twbs/fix-15972
...
add role="button" to a[data-toggle="collapse"]
2015-03-24 08:57:56 -07:00
Emmanuel Bourgerie
fa9d28b634
Fix #16072 : Clicking into input field within dropdown no longer closes the dropdown
...
Closes #16073 by merging it
2015-03-21 16:00:15 -07:00
Maxim Andrukhovych
83371735fc
Fixed proper navigation element selection on backward scrolling (from the bottom to the top)
2015-03-10 20:04:15 +00:00
Chris Rebert
725c6848c3
Disable jQuery event aliases when running test suite
...
To ensure that we don't accidentally use any of the aliases.
This should prevent any future regressions from #12761 .
Also updates the test suite since it now can't use these aliases either.
2015-03-09 01:05:43 -07:00
Chris Rebert
5c8d56d515
Collapse unit test: rm check that no-op hide adds style="height: 0px"
...
Appears to be unnecessary and is broken by #16011 ,
which is otherwise quite sane.
2015-03-06 18:10:53 -08:00
Chris Rebert
872e56fcf2
.collapse('hide') on hidden uninit-ed collapsible no longer shows it; fixes #15315
...
Thanks to @peterblazejewicz & @Nikita240
Adds unit tests based on #14417
X-Ref: #14282
Closes #15807
2015-03-06 06:58:48 -08:00
Chris Rebert
27bbc7dbe9
Hiding an uninitialized tooltip/popover no longer initializes it; fixes #15874
2015-03-03 22:22:13 -08:00
Chris Rebert
cc39f5c52d
add role="button" to a[data-toggle="collapse"]; fixes #15972
2015-03-03 13:18:36 -08:00
Heinrich Fenkart
420a8088a4
Merge pull request #15961 from kkirsche/ImplementAssertExpect
...
[Fixes #15953 ] Implement assert.expect in each unit test
2015-03-03 15:52:05 +01:00
Kevin Kirsche
4febcb4b49
[ Fixes #15953 ] Implement assert.expect in each unit test
...
[Fixes #15953 ] Implement `assert.expect` in each unit test
2015-03-03 08:45:07 -05:00
Heinrich Fenkart
f5beebe726
Modal: Fix backdrop not readjusting when height changes
...
Fixes #15136 .
Closes #15345 .
Closes #15314 .
Refs #14724 , #14927 .
2015-03-03 05:27:26 +01:00
XhmikosR
f8e34ff48b
Disable es3 for tests and customizer.js.
2015-03-02 11:16:06 +02:00
Chris Rebert
015e63f6df
Merge pull request #15593 from neoeno/handle_multiple_zero_offset_scrollspy_elements
...
Handle multiple zero-offset Scrollspy elements.
2015-03-01 16:04:04 -08:00
Caden Lovelace
a1aa0f8afd
Handle multiple zero-offset Scrollspy elements.
...
When the first two elements in a scrollspy content block have a document
offset of zero (i.e. they're hard against the top of the page),
Scrollspy would switch between them on every scroll event.
This could happen, for example, in a system of nested sections:
```
<section id="animals">
<section id="dogs">
Content
</section>
</section>
```
This ocurred because Scrollspy's check to see if it's at the end of the
array of sections uses `!arr[index]`. This misses the case where
`arr[index]` does exist and is zero.
This commit explicitly checks the array bounds.
2015-03-01 23:55:39 +00:00
Mark Otto
c16fee5efd
Merge branch 'master' into v4
...
Conflicts:
.travis.yml
Gruntfile.js
bower.json
dist/css/bootstrap.css
dist/css/bootstrap.css.map
dist/css/bootstrap.min.css
dist/js/bootstrap.js
dist/js/bootstrap.min.js
docs/_data/glyphicons.yml
docs/_includes/components/breadcrumbs.html
docs/_includes/components/button-dropdowns.html
docs/_includes/components/button-groups.html
docs/_includes/components/dropdowns.html
docs/_includes/components/glyphicons.html
docs/_includes/components/labels.html
docs/_includes/components/list-group.html
docs/_includes/components/media.html
docs/_includes/components/navs.html
docs/_includes/components/panels.html
docs/_includes/components/progress-bars.html
docs/_includes/components/thumbnails.html
docs/_includes/components/wells.html
docs/_includes/css/buttons.html
docs/_includes/css/forms.html
docs/_includes/css/helpers.html
docs/_includes/css/images.html
docs/_includes/css/less.html
docs/_includes/customizer-variables.html
docs/_includes/getting-started/accessibility.html
docs/_includes/getting-started/browser-device-support.html
docs/_includes/getting-started/community.html
docs/_includes/getting-started/examples.html
docs/_includes/getting-started/grunt.html
docs/_includes/getting-started/license.html
docs/_includes/getting-started/template.html
docs/_includes/header.html
docs/_includes/js/affix.html
docs/_includes/js/alerts.html
docs/_includes/js/carousel.html
docs/_includes/js/collapse.html
docs/_includes/js/dropdowns.html
docs/_includes/js/modal.html
docs/_includes/js/overview.html
docs/_includes/js/popovers.html
docs/_includes/js/scrollspy.html
docs/_includes/js/tabs.html
docs/_includes/js/tooltips.html
docs/_includes/js/transitions.html
docs/_includes/nav/javascript.html
docs/_layouts/default.html
docs/assets/css/docs.min.css
docs/assets/css/src/docs.css
docs/assets/js/customize.min.js
docs/assets/js/docs.min.js
docs/assets/js/raw-files.min.js
docs/assets/js/vendor/FileSaver.js
docs/assets/js/vendor/autoprefixer.js
docs/assets/js/vendor/uglify.min.js
docs/dist/css/bootstrap.css
docs/dist/css/bootstrap.css.map
docs/dist/css/bootstrap.min.css
docs/dist/js/bootstrap.min.js
docs/examples/blog/index.html
docs/examples/carousel/index.html
docs/examples/cover/index.html
docs/examples/dashboard/index.html
docs/examples/narrow-jumbotron/narrow-jumbotron.css
docs/examples/navbar-fixed-top/index.html
docs/examples/navbar-static-top/index.html
docs/examples/non-responsive/index.html
docs/examples/non-responsive/non-responsive.css
docs/examples/theme/index.html
grunt/configBridge.json
js/affix.js
js/carousel.js
js/collapse.js
js/dropdown.js
js/modal.js
js/popover.js
js/scrollspy.js
js/tab.js
js/tests/unit/affix.js
js/tests/unit/button.js
js/tests/unit/carousel.js
js/tests/unit/modal.js
js/tests/unit/tooltip.js
js/tooltip.js
less/badges.less
less/glyphicons.less
less/type.less
less/variables.less
package.json
scss/_dropdown.scss
scss/_forms.scss
test-infra/npm-shrinkwrap.json
2015-03-01 13:44:10 -08:00
Ivan Cheung
d5071b19f1
Update all collapse triggers with .collapsed class and aria-expanded
...
Fixes #15741
Closes #15751 by merging it.
2015-02-26 18:48:20 -08:00
Chris Rebert
9afb61fffd
QUnit.jsDump => QUnit.dump
...
Refs http://qunitjs.com/upgrade-guide-2.x/#replace-qunit-jsdump-with-qunit-dump
2015-02-25 23:29:27 -08:00
Heinrich Fenkart
3bb05b5fbb
Unit tests: Use new names of module hooks
...
Refs #15893
2015-02-26 08:20:42 +01:00
nakupanda
142a9e4ae0
Modal: Apply any preexisting body padding again after closing
2015-02-26 08:02:06 +01:00
vsn4ik
b395f3526e
Dropdowns: Skip .disabled
instead of .divider
on keydown event
...
Fixes #15147 .
Closes #15520 by merging it.
2015-02-26 06:42:09 +01:00
Chris Rebert
804457c474
fix 2 typos in modal unit test assertion messages
2015-02-24 23:49:08 -08:00
Heinrich Fenkart
c40c31a308
Dropdown unit tests: Tiny style changes
2015-02-25 02:53:39 +01:00
Chris Rebert
2a6207c0c9
Merge pull request #15904 from kkirsche/patch-8
...
Closes #15904
2015-02-24 14:11:03 -08:00
Kevin Kirsche
696fc2e53c
Add unit test of aria-expanded to dropdown suite
...
Redo of #15876
2015-02-24 14:09:08 -08:00
Kevin Kirsche
30d8cdf639
Add tests for aria-hidden of modal
...
Add tests for `aria-hidden` of modal
Use strictEqual of 1 here instead of 2 asserts
2015-02-24 16:29:40 -05:00
Chris Rebert
9c75c855c6
JS unit tests: equal() => strictEqual()
...
[skip validator]
2015-02-23 22:43:17 -08:00
Chris Rebert
118b8c2695
JS unit tests: use QUnit.module() & QUnit.test() everywhere
...
[skip validator]
2015-02-23 22:14:11 -08:00
Chris Rebert
7c19fee3f1
JS unit tests: use modern QUnit assert object everywhere
2015-02-23 22:14:11 -08:00
fat
1e9e3316b6
kill affix
2015-02-11 11:40:57 -08:00
fat
834220ea20
bootstrap onto closure
2015-02-11 11:29:43 -08:00
Chris Rebert
cd4467b194
Merge pull request #15496 from twbs/15484-alternative
...
Make $(document).tooltip({...}) without a `selector` throw an error
2015-01-28 11:05:40 -08:00
Chris Rebert
9238337cbb
Merge branch 'master' into v4
2015-01-21 13:00:12 -08:00
Chris Rebert
1652efc3f6
tweak 'close reopened modal' unit test to work under new QUnit API
2015-01-20 20:18:33 -08:00
Chris Rebert
df73535a2d
fix bug in tab show/shown relatedTarget unit test
2015-01-20 20:16:42 -08:00
Chris Rebert
b56d97f210
update JS unit tests to future-proof QUnit 1.16.0 API
...
[skip validator]
2015-01-20 19:57:51 -08:00
Chris Rebert
f6a837cbf1
Make $(document).tooltip({...}) without a selector
throw an error
...
Closes #15484
2015-01-05 14:22:49 -08:00
Mark Otto
0e5d17d5f6
Merge branch 'master' into v4
...
Conflicts:
Gruntfile.js
dist/css/bootstrap-theme.css
dist/css/bootstrap-theme.css.map
dist/css/bootstrap-theme.min.css
dist/css/bootstrap.css
dist/css/bootstrap.css.map
dist/css/bootstrap.min.css
dist/js/bootstrap.min.js
docs/_data/glyphicons.yml
docs/_includes/components/alerts.html
docs/_includes/components/badges.html
docs/_includes/components/breadcrumbs.html
docs/_includes/components/button-dropdowns.html
docs/_includes/components/button-groups.html
docs/_includes/components/dropdowns.html
docs/_includes/components/glyphicons.html
docs/_includes/components/input-groups.html
docs/_includes/components/jumbotron.html
docs/_includes/components/labels.html
docs/_includes/components/list-group.html
docs/_includes/components/media.html
docs/_includes/components/navbar.html
docs/_includes/components/navs.html
docs/_includes/components/page-header.html
docs/_includes/components/pagination.html
docs/_includes/components/panels.html
docs/_includes/components/progress-bars.html
docs/_includes/components/responsive-embed.html
docs/_includes/components/thumbnails.html
docs/_includes/components/wells.html
docs/_includes/css/buttons.html
docs/_includes/css/code.html
docs/_includes/css/forms.html
docs/_includes/css/grid.html
docs/_includes/css/helpers.html
docs/_includes/css/images.html
docs/_includes/css/less.html
docs/_includes/css/tables.html
docs/_includes/css/type.html
docs/_includes/customizer-variables.html
docs/_includes/getting-started/accessibility.html
docs/_includes/getting-started/disabling-responsiveness.html
docs/_includes/getting-started/download.html
docs/_includes/getting-started/whats-included.html
docs/_includes/js/alerts.html
docs/_includes/js/buttons.html
docs/_includes/js/carousel.html
docs/_includes/js/collapse.html
docs/_includes/js/modal.html
docs/_includes/js/overview.html
docs/_includes/js/popovers.html
docs/_includes/js/tabs.html
docs/_includes/js/tooltips.html
docs/_includes/nav/components.html
docs/_includes/nav/javascript.html
docs/_jade/customizer-variables.jade
docs/_layouts/default.html
docs/about.html
docs/assets/css/docs.min.css
docs/assets/css/src/docs.css
docs/assets/js/customize.min.js
docs/assets/js/raw-files.min.js
docs/assets/js/src/customizer.js
docs/customize.html
docs/dist/css/bootstrap-theme.css.map
docs/dist/css/bootstrap.css
docs/dist/css/bootstrap.css.map
docs/dist/css/bootstrap.min.css
less/glyphicons.less
less/mixins/vendor-prefixes.less
less/navbar.less
less/popovers.less
less/tables.less
less/theme.less
less/tooltip.less
less/variables.less
package.json
scss/_carousel.scss
scss/_close.scss
scss/_forms.scss
test-infra/npm-shrinkwrap.json
2015-01-03 20:08:58 -08:00
Chris Rebert
adaabab81b
Revert "Allow multiple delegated tooltip selectors on a node"
...
This reverts commit 1b3237629a
.
This reverts PR #14189 because it caused major regressions.
Fixes #15168 .
We'll try to revisit #14167 's feature request in Bootstrap v4.
[skip validator]
2014-12-29 20:08:22 -08:00
Chris Rebert
32cb071594
Remove semicolons from #15425 because fat
2014-12-29 18:34:35 -08:00
Chris Rebert
27bfef5b35
Add regression test for #14244 .
...
Special thanks to @programcsharp
[skip validator]
2014-12-29 16:09:37 -08:00
Chris Rebert
05d1877985
update JS to use .{tooltip,popover}-{left,right,top,bottom}
2014-12-29 12:34:09 -08:00
Chris Rebert
6a5bc63649
rename .arrow => .popover-arrow
2014-12-29 12:33:06 -08:00
Chris Rebert
c7ef5810e1
rename .item => .carousel-item
2014-12-17 18:44:55 -08:00
Dan Dascalescu
2c64fc2c4d
Fix copy/paste error
2014-11-28 04:30:04 -08:00
Chris Rebert
bc5a753b67
fix affix-top unit test to properly clean up after itself
2014-11-20 23:26:37 -08:00
Nick O'Donoghue
da79ab9488
add unit test for affix-top for padding issue
2014-11-17 18:17:40 -08:00
Chris Rebert
8008fe707e
add unit tests for Carousel's 'wrap' option
2014-11-15 22:37:55 -08:00
Heinrich Fenkart
1d55ada581
Dropdown: ignore keydown events coming from input
s and textarea
s
...
Fixes #15084 .
2014-11-12 02:01:25 +01:00
Chris Rebert
469dc3ab1f
Have Carousel ignore keyboard events from <input>s or <textarea>s; fixes #14991
2014-11-04 16:23:44 -08:00
Heinrich Fenkart
ed3a65f084
Handle collapsed
class on triggers even when manually invoked
...
Fixes #13636 .
2014-10-29 04:34:05 +01:00
Heinrich Fenkart
e851b8685a
Merge pull request #14457 from hnrch02/button-set-val-after-event-loop
...
Change value of stateful button after event loop
2014-10-29 04:28:22 +01:00
Chris Rebert
22e1f94b52
Increase timeouts in tooltip unit tests to avoid spurious Sauce failures
...
Fixes #14851
2014-10-27 15:53:43 -07:00
Heinrich Fenkart
007fbdb66d
Remove faulty unit test from 9740d8b
...
This would only work with transitions but since we disable them for unit tests, this delivers unreliably results.
2014-10-26 04:56:52 +01:00
Heinrich Fenkart
5da85f8e8b
Follow-up to 9740d8b
: fix small typo
2014-10-26 04:41:47 +01:00