0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-11-29 11:24:18 +01:00
Commit Graph

98 Commits

Author SHA1 Message Date
jonnysp
9c0b2be469 Update _carousel.scss
fix  data-bs-theme="dark" on component itself
2023-03-10 11:26:25 -06:00
Mark Otto
cf6972ccf1 Remove list-style reset on .carousel-indicators 2023-01-25 18:09:48 -08:00
Julien Déramond
41f62c5a11
Fix Sass compilation when $color-mode-type is set to media-query (#37687)
* Fix Sass compilation when `$color-mode-type` is set to `media-query`

* Update mixin names, fix docs color modes for using media queries by using mixin

Co-authored-by: Mark Otto <markdotto@gmail.com>
2022-12-21 08:52:07 +02:00
Mark Otto
fc3f4b67d6
Add dark mode support (#35857)
* Add dark mode to docs

* Minor fix: missing space indentation

* Minor fix: revert utilities/z-index added-in modification

* Remove prev: and next: from doc because extracted to another PR

* Use .bg-body-tertiary in all Utilities > Overflow examples

* fix example

* Fix up spacing examples

* Update box-shadow Sass variables and utilities to auto-adjust to color modes

* Remove unused docs class

* Refactor form styles to use CSS variable for background images on .form-check and .form-switch

* Fix docs selector

* Rename shortcut for clarity

* Heading consistency

* Reintroduce missing 4th grid item in Utilities > Spacing example

* Fix bundlewatch

* .bd-callout* rendering is OK so removing comments in the code

* Update scss/_utilities.scss

Co-authored-by: Julien Déramond <julien.deramond@orange.com>

* Fix gutters example styling

* Fix text colors on background utils docs

* redesign and fix up position marker example, which doesn't show nicely in darkmode but at least isn't broken

* fix some color utils examples

* Deprecate mixin notice

* Deprecate notice for list-group-item-variant() mixin

* Revamp new link CSS vars

* Use map-keys in some each Sass files

* Remove list-group-item-variant mixin ref in sass loop desc

* Display CSS vars scoped to our built-in dark mode

* Revert previous commit

* Fix list group variant link

* Fix typo

* Remove imports of alert/list-group mixins in scss/_mixins.scss

* Small formatting + comments removal in scss/_content.scss

* Fix alert links colors

* fix dropdown border-radius mixin

* fix link color and underline again, this time using CSS var override for color var and fallback value for the underline

* fix colors on docs navbar for dark mode

* remove two changes

* missing ref

* another link underline fix, just use sass vars for link decoration for now

* missing color bg docs, plus move dropdown override to scss

* more changes from review

* fix some examples, drop unused docs navbar styles, update docs navbar color mode to use mixin

* Few fixes around type

- Restored CSS variable for color on headings, this time with a fallback value
- In conjunction, restored and wrapped the default CSS var with a null value check
- Split headings and paragraphs docs in Reboot, elaborated on them

* Restyle custom details > summary element in docs

* Rewrite some migration docs

* fix form checks

* Fix up some navbar styling, tweak docs callout

* Fix select images, mostly for validation styling

* Clean up some migration notes, document some new form control CSS vars, mention new variables-dark in sass docs

* Update site/content/docs/5.2/components/scrollspy.md

Co-authored-by: Julien Déramond <julien.deramond@orange.com>

* Apply suggestions from code review

Co-authored-by: Julien Déramond <julien.deramond@orange.com>

* mention form control css vars in migration guide

* Tweak grid and flex docs background examples

* clarify some docs

* fix some more things

Co-authored-by: Julien Déramond <juderamond@gmail.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
2022-11-28 22:30:26 -08:00
Gaël Poupard
5029370a10 fix(carousel): RTL translate() direction
Trying to fix #37180
2022-10-06 13:07:49 -07:00
Mark Otto
be17444756
Replace / division with multiplication and custom divide() function (#34245)
* Convert bulk of division to multiplication

* Use custom divide() function instead of Dart Sass math module for greater compatibility

* Apply suggestions from code review

* Fix functions
2021-06-14 09:35:30 -07:00
Quy
ed0fc83216
_carousel.scss: Fix typo in comment (#32950) 2021-02-01 15:22:24 +02:00
Patrick H. Lauke
a882614c45 Make carousel indicators actual buttons 2021-01-28 23:32:24 +02:00
Patrick H. Lauke
3aa3fda730
Carousel: use buttons, not links, for prev/next controls (#32627)
* Carousel: use buttons, not links, for prev/next

- expand the styles to neutralise border/background
- change docs page
- add extra unit test to check that links or buttons work as controls
- modify visual test to use buttons as well
- use buttons instead of links for prev/next
- remove `role="button"` from links that are actually links

* Clarify that controls can be button or link

* Update site/content/docs/5.0/components/carousel.md

Co-authored-by: Mark Otto <markd.otto@gmail.com>

* Explicitly set padding to 0 to prevent dipping/moving on active in Firefox

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-27 17:31:16 +02:00
Gaël Poupard
9488978fb5 feat(RTL): implement RTL
Using RTLCSS directives, renaming things to use logical names and following best practices.
2020-12-04 07:52:03 +02:00
Mark Otto
f951be36a1
Carousel enhancements, including .carousel-dark (#31650)
* Replace existing carousel control icons with chevrons from Bootstrap Icons

* Add .carousel-dark variant

* Test

* Add variable for .carousel-dark filter

* Update _variables.scss

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-09-24 13:16:20 -07:00
Martijn Cuppens
f54b83073d Shorten if notations so that property order can be applied 2020-02-12 19:45:54 +02:00
Martijn Cuppens
dc64ff3314 Convert background shorthands to separate properties 2020-02-12 19:45:54 +02:00
leshasmp
64e22b4284 Carousel variables (#29493) 2019-10-12 14:09:04 +02:00
astrahov
46e8f1a34f Variable carousel indicator opacity (#29468) 2019-10-01 15:14:43 +02:00
Martijn Cuppens
2ad135ebb4 Update z-indices (#29292)
- `.carousel-caption` doesn't need a z-index. There are no non-static element in its containing block (`.carousel-item`)
- The `z-index` of `.carousel-indicators` is way higher than it needs to be (`15`), the highest sibling `z-index` is `1`, so it can be set to `2` to be the top layer.
2019-08-26 09:42:44 +03:00
XhmikosR
b016825edd
carousel: fix transition properties order. (#29173) 2019-07-30 18:30:23 +03:00
Chandan Deep
b433a05cbd Change property from background to background-image (#29149)
For Gradient, We have to use the background-image instead of only background.
2019-07-29 08:12:44 +03:00
Martijn Cuppens
f6694b7440 Use escape-svg() function (#29077)
* Use escape-svg() function

* Update theming.md
2019-07-19 18:57:12 -07:00
Mark Otto
1d4d9f8d89 Drop all hover mixins
Previously deprecated in v4.x, this clears out the now unused Sass option and removes some unused mixins. Arguably we could remove more, but I like the hover-focus mixin and we make extensive use of it across the project.
2019-05-08 20:58:07 +03:00
Martijn Cuppens
d09bd2e629 Fix background size y 2019-01-13 16:24:01 -08:00
Martijn Cuppens
e2ac792bc7 Minify background property 2019-01-13 16:24:01 -08:00
Martijn Cuppens
502b6c8ed6
Remove redundant brackets (#27768) 2018-12-14 17:54:44 +01:00
Martijn Cuppens
b33d0d3790 Prevent white line in Firefox (regression) (#27594) 2018-11-05 18:56:41 +02:00
patrickhlauke
c46a0c7e88 Replace touch-action: none with pan-y, remove preventDefault from touch event handling 2018-11-04 14:40:19 +02:00
Martijn Cuppens
96b49d7833 Fix Edge bounce and restore original transition easing (#27279) 2018-10-31 09:45:39 +02:00
Martijn Cuppens
5aed968750 Prevent the background to be shown when transitioning 2018-10-30 08:57:02 +02:00
Martijn Cuppens
c9a43b027a Re-add carousel control transition (#27277) 2018-10-21 10:13:35 +03:00
Martijn Cuppens
2a28c7d9fd Carousel fade cleanup (#27278) 2018-10-21 09:55:43 +03:00
patrickhlauke
8883ccb205 Set touch-action to "none"
Firefox currently seems extremely fickle - with `pan-y` if fires pointercancel as soon as a touch strays even a pixel or so vertically.
While `touch-action: pan-y` would be ideal (allowing users to scroll the page even when their finger started the scroll on the carousel), this prevents a swipe that isn't perfectly/only horizontal to be recognised by Firefox.
2018-10-20 15:32:09 +03:00
patrickhlauke
7b8f01d839 Use correct touch-action values
- my fault, my original advice of using `touch-action: pan-x` is exactly the value we *don't* want to have the browser handle...
2018-10-20 15:32:09 +03:00
Johann-S
735c374e9c use pointer events if available 2018-10-20 15:32:09 +03:00
Martijn Cuppens
0e8831505a Simpler carousel indicators css (#26996) 2018-08-26 14:53:36 +03:00
Martijn Cuppens
4f926671e9 Carousel indicators transition (#26902) 2018-07-24 21:15:05 -07:00
domq
616ce9b75a Fix double-transition bug (#26452)
By applying the transition: CSS property only to classes that are
active during sliding, we avoid an unnecessary, non-zero-time
animation that although mostly invisible, does interfere with e.g.
z-index based parallax
2018-05-18 18:59:52 +03:00
Varunram
4bc5cc149a Closes #26300: Add cursor pointer to carousel indicators 2018-04-23 21:55:45 -07:00
Tom Swirly
a0c7473a34 Tiny grammar and punctuation tweaks to a comment.
1. It's == "it is"

2. The subject of the sentence is "Only one" (not "these") so the verb must agree with it.

Feel free to do nothing with this change, use it, etc - I just saw this while reading through the code.
2018-04-01 23:08:58 +03:00
Jacob Müller
27f553c965 Replace "loose" HEX values with their respective variables (#25672) 2018-03-12 19:19:37 +02:00
Mark Otto
663057d441
Feature: Add carousel fade option (#22958)
* Move helpful code comments

* Add .carousel-fade option to Sass

* Document example of the fade carousel

* more logical warning of the .active class on carousel items
2018-01-21 22:51:08 -08:00
XhmikosR
29d58fb758 Enable stylelint's function-comma-space-after. (#24501)
The option is set to `always-single-line` in stylelint-config-standard which we extend.
2017-10-23 00:00:00 +03:00
Mark Otto
06641ca0b3 Gradients and shadows (#24429)
* Update the form focus mixin to use a manual `$enable-shadows` check so we can always ensure a focus state for accessibility and consistency

* - Add new `$input-btn-focus-width` and `$input-btn-focus-color` variables.

- Replace separate `$btn-focus-box-shadow` and `$input-focus-box-shadow`
variables with unified `$input-btn-focus-box-shadow` to match our
combined variables approach elsewhere.

* Put new focus width var to use in buttons mixins

* use new button input-box shadow var

* Add a new mixin for quickly adding linear gradient to components when $enable-gradients is set to true

* use correct var

* fix focus shadows in button mixins

* Add opt-in gradients to alerts, buttons, carousel, custom radios and checkboxes, custom file input, and dropdown items

* Generate .bg-gradient- utilities

* add headings to colors page and document bg-gradient utils

* update the button color for active status, check with yiq as it's done for basic state and hover state
2017-10-19 09:03:33 -07:00
Mark Otto
2bf4de0698 Update carousel display settings
Use `display: block` since we're not really using any flex styles on the `.carousel-items` (only their controls and indicators). For the indicators, since moving to `width`, our indicators grow to fill available space, so we need to change `flex: 1 0 auto` to `flex: 0 1 auto` to prevent that.
2017-07-01 16:59:16 -07:00
Mark Otto
75156f419a using max-width in flex: 1 0 auto; in ie11 offsets the center-aligned contents 2017-07-01 11:21:20 -07:00
Mark Otto
2d4534e112 use @supports to apply transform3d to those who can do it, then provide a non-3d fallback to ie11 2017-07-01 11:21:20 -07:00
Mark Otto
0c59741812 property order 2017-04-08 16:29:21 -07:00
Pierre-Denis Vanduynslager
73cfefd594 Do not stretch images in carousel-item 2017-04-08 16:29:21 -07:00
Mark Otto
ab67ffe167 Ensure carousel works in IE10/11
- Drops the `if-supports-3d-transforms()` mixin since all our browsers do support it

- Updates carousel to not rely on that mixin
2017-04-08 16:29:21 -07:00
Mark Otto
02e0fdbd52 Remove cursor: pointer; (#21812)
* Remove most of custom cursor: pointer; implementations

* turns out that's not so much of a thing
2017-01-23 22:15:28 -08:00
Quy
28072f153c Update carousel comments (#21501) 2017-01-01 12:00:17 -08:00
Mark Otto
736be8fca6 linting 2016-12-22 14:58:40 -08:00