0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-02 14:24:19 +01:00
Commit Graph

40 Commits

Author SHA1 Message Date
GeoSot
548be2ed66
Offcanvas as component (#29017)
* Add a new offcanvas component

* offcanvas.js: switch to string constants and `event.key`

* Remove unneeded code

* Sass optimizations

* Fixes

Make sure the element is hidden and not offscreen when inactive
fix close icon negative margins
Add content in right & bottom examples
Re-fix bottom offcanvas height not to cover all viewport

* Wording tweaks

* update tests and offcanvas class

* separate scrollbar functionality and use it in offcanvas

* Update .bundlewatch.config.json

* fix focus

* update btn-close / fix focus on close

* add aria-modal and role
return focus on trigger when offcanvas is closed
change body scrolling timings

* move common code to reusable functions

* add aria-labelledby

* Replace lorem ipsum text

* fix focus when offcanvas is closed

* updates

* revert modal, add tests for scrollbar

* show backdrop by default

* Update offcanvas.md

* Update offcanvas CSS to better match modals

- Add background-clip for borders
- Move from outline to border (less clever, more consistent)
- Add scss-docs in vars

* Revamp offcanvas docs

- Add static example to show and explain the components
- Split live examples and rename them
- Simplify example content
- Expand docs notes elsewhere
- Add sass docs

* Add .offcanvas-title instead of .modal-title

* Rename offcanvas example to offcanvas-navbar to reflect it's purpose

* labelledby references title and not header

* Add default shadow to offcanvas

* enable offcanvas-body to fill all the remaining wrapper area

* Be more descriptive, on Accessibility area

* remove redundant classes

* ensure in case of an already open offcanvas, not to open another one

* bring back backdrop|scroll combinations

* bring back toggling class

* refactor scrollbar method, plus tests

* add check if element is not full-width, according to #30621

* revert all in modal

* use documentElement innerWidth

* Rename classes to -start and -end

Also copyedit some docs wording

* omit some things on scrollbar

* PASS BrowserStack tests

-- IOS devices, Android devices and Browsers on Mac, hide scrollbar by default and appear it, only while scrolling.

* Rename '_handleClosing' to '_addEventListeners'

* change pipe usage to comma

* change Data.getData to Data.get

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
Co-authored-by: Mark Otto <markdotto@gmail.com>
2021-03-02 19:10:10 +02:00
Gaël Poupard
b7bd094351
docs(examples): typo in offcanvas example in .bg-body (#33092)
Caught by pa11y-ci on Boosted (because of insufficient contrasts) ❤️
2021-02-15 21:06:57 +02:00
Gaël Poupard
0a9d392975
Docs improvements after beta2 (#33049)
* docs(carousel): double-spaces out there

* docs(toasts): missing word, ins't it?

* docs(cheatsheet): use buttons for carousels and tabs ion cheatsheets too

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-11 19:48:08 +02:00
Patrick H. Lauke
a882614c45 Make carousel indicators actual buttons 2021-01-28 23:32:24 +02:00
Patrick H. Lauke
3aa3fda730
Carousel: use buttons, not links, for prev/next controls (#32627)
* Carousel: use buttons, not links, for prev/next

- expand the styles to neutralise border/background
- change docs page
- add extra unit test to check that links or buttons work as controls
- modify visual test to use buttons as well
- use buttons instead of links for prev/next
- remove `role="button"` from links that are actually links

* Clarify that controls can be button or link

* Update site/content/docs/5.0/components/carousel.md

Co-authored-by: Mark Otto <markd.otto@gmail.com>

* Explicitly set padding to 0 to prevent dipping/moving on active in Firefox

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-27 17:31:16 +02:00
Vino Rodrigues
ba30df146c Replace .bg-white with .bg-body in docs
Response to issue #32810

Use of the .bg-white class to define visual aspects of the examples
would be unintuitive for theme builders to test themes on.
This replaces instances of .bg-white with .bg-body in the examples.

- Edited examples to replace use .bg-white class with .bg-body class
  - product
  - offcanvas
  - pricing
  - cheatsheet
  - cheatsheet-rtl
- Edited utilities colors.md & shadows.md to include .bg-body class
2021-01-25 14:34:01 -08:00
Patrick H. Lauke
949fa30152
Remove role="button" from CTA links in carousel examples (#32788)
They're links, acting as links. Just because they're styled as buttons visually doesn't mean they need/get `role="button"`
2021-01-14 01:54:25 +02:00
Théophile Helleboid - chtitux
80557b3ac0
Move "active" class from .nav-item to .nav-link (#32730) 2021-01-08 20:53:04 +02:00
Jonathan
88d35b725b
Hyphen to dash for ranges (#32488)
* Hyphen to dash for ranges

* Hyphen to dash for ranges

* Hyphen to dash for ranges

* Hyphen to dash for ranges

* Hyphen to dash for ranges
2021-01-05 13:56:44 -08:00
Théophile Helleboid - chtitux
265605bba0
carousel example: Move "active" class on .nav-link element (#32647) (#32647)
The "active" CSS class must be on "nav-link" element, see `_navbar.scss`:

```css
.nav-link.active {
  color: $navbar-dark-active-color;
}
```

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-05 22:15:59 +02:00
Florian Lacreuse
fe3658672c
Add missing has-validation in checkout examples (#32464) 2020-12-14 14:33:20 +02:00
Gaël Poupard
e967ecf900 docs(cheatsheet): fix RTL sidenav arrows 2020-12-14 11:11:47 +02:00
Alan Orth
f2b39d620c
examples: Update font utility classes to new v5 versions (#32449)
* site: Fix .font-italic to .fst-italic in blog example

The font utility class was renamed from .font-italic to .fst-italic
but a few references didn't get updated.

* site: Fix .font-weight-* to .fw-* in RTL examples

These font utility classes were renamed from .font-weight-* to .fw-*
but a few references didn't get updated.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-14 10:51:21 +02:00
Patrick H. Lauke
764e5298de
Replace Lorem Ipsum placeholder text with more representative (or at least english language) text (#32246)
Replaces shorter examples with more sensible/representative/inforrmative text. For longer passages, resorted to using SFW extracts from http://katyperryipsum.com/
2020-12-11 20:05:33 +00:00
Gaël Poupard
0f12f58711
cheatsheet: Drop redundant (current) text (#32401)
Useless since we're using `aria-current` (see #31891).
2020-12-09 17:54:47 +02:00
XhmikosR
321ee7a1ad
cheatsheet.js: use event instead of e (#32335) 2020-12-04 16:00:21 +02:00
Gaël Poupard
0a141dae94 chore(dist): generate dist files 2020-12-04 07:52:03 +02:00
Mark Otto
53d861c814 fix gradient 2020-12-04 07:52:03 +02:00
Gaël Poupard
082723f3f4 docs(cheatsheet): various fixes 2020-12-04 07:52:03 +02:00
Mark Otto
153f6c72ce Revamp header, headings, aside spacing
Gradients caused artifacts in Safari, layout was feeling a little loose
2020-12-04 07:52:03 +02:00
Gaël Poupard
3ef8483c5d docs(examples): use RTLCSS for RTL examples 2020-12-04 07:52:03 +02:00
XhmikosR
edfa103444 Adapt to the recent main branch changes 2020-12-04 07:52:03 +02:00
Gaël Poupard
aaff11a0b3 docs(examples): new cheatsheet and RTL examples 2020-12-04 07:52:03 +02:00
XhmikosR
ecbc7189b6 examples: fix .btn-block instances 2020-11-19 07:47:06 +02:00
XhmikosR
b5a64ce60f
Switch to jsDelivr for the remaining docs assets (#32158) 2020-11-15 14:21:01 +02:00
Rohit Sharma
418f17ee2b Add bs in data attributes
- Add `bs` in data APIs everywhere
- Update unit tests
2020-11-14 07:09:15 +02:00
Mark Otto
d1dcc1e5e6 Update instances of .font-weight to .fw 2020-10-31 19:19:52 +01:00
Mark Otto
3e2f9ab237
v5: Floating labels (#30449)
* v5: Promote floating labels example to component

- Adds new .form-floating
- Stubs out basics of a docs page
- Removes existing Example

* Update floating labels to support .form-select, make inputs and selects more consistent

- To do this, I made the .form-control and .form-select consistent in min-height vs height
- Removed some unused variables now
- Updated -color to be the -color because I don't know why this was any different before
- Update page to include some examples for layout, validation, and value
- Rewrite styles to not modify padding, but instead transform and opacity

* Streamline and bulletproof some things

- Apply some optimizations from code review
- Removed unecessary properties from the label
- Add some comments for what properties are required
- Move from fixed height for labels to height 100% so we can support textareas
- Improve docs a little bit, add ToC

* Move some values to variables, switch from scaling font-size to scale, update transforms

* Bring over changes from #30966 and add to them to tighten things up

* Delete the now unused example images

* Fix typo

* Allowlist the calc function

* Add transform-origin, update transform values

* Test out autofill fix

* Fix linter issue

* Mention it in the migration guide

* Bump bundlesize

* Add one more variable per review

* Shave .25rem off the height

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-10-27 20:45:48 -07:00
Gaël Poupard
b2d7d29f6d
docs(examples): ensure content sits in landmarks (#31579) 2020-09-10 12:39:29 +03:00
XhmikosR
ea5d555139 Fix the remaining instances using the old logos. 2020-09-10 11:56:02 +03:00
Patrick H. Lauke
10690dd317
Rename sr-only/sr-only-focusable (#31139)
* Rename `sr-only`/`sr-only-focusable`

To be more representative of the fact that these are not necessarily "screen reader" specific, but actually apply to assistive technologies in general (and also things like Alexa/Siri/etc). Goes hand-in-hand with #31133

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-07-03 14:38:11 +03:00
Gaël Poupard
9c320df652
Floating labels improvements (#30966)
* docs(example): floating-labels' better Edge fallback

* docs(example): refactor floating-labels' CSS
2020-06-24 14:11:20 +03:00
Jonathan
1b2ea5efb1 Update index.html
Hyphen to minus for amount.
Hyphen to dash for ranges.
2020-06-14 21:22:35 -07:00
Gaël Poupard
aee711bfa9 docs(examples): fix pricing example 2020-06-14 14:47:56 -07:00
Gaël Poupard
6fa3dfe8d9 docs(examples): improve headings hierarchy 2020-06-14 14:47:56 -07:00
Gaël Poupard
7b30cb9b77 docs(examples): empty alt for screenshots to prevent redundancy 2020-06-14 14:47:56 -07:00
Mark Otto
a656458856 Run dist on latest 2020-06-14 13:52:54 -07:00
Mark Otto
286f16b92c
v5: Redo blockquote attributions (#30814)
* v5: Redo blockquote attributions

- Renames -small-* variables to -footer-*
- Updates blockquote demos with attribution to place it outside the blockquote with a figure wrapper

* Updated class name

* docs(examples): refactor blockquotes in masonry example

Co-authored-by: Gaël Poupard <gael.poupard@orange.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-06-12 14:26:37 -07:00
XhmikosR
b1c720d047
examples: remove no longer used classes. (#30894) 2020-05-26 11:01:17 +03:00
XhmikosR
38ec7c4df7
Bump version to 5.0.0-alpha1 (#29925)
Also add v4.5.0 in versions and keep README.md pointing to v4.5.0 so that there are no broken stuff.
2020-05-13 22:36:00 +03:00