0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-04 16:24:22 +01:00
Commit Graph

7 Commits

Author SHA1 Message Date
Patrick H. Lauke
3aa3fda730
Carousel: use buttons, not links, for prev/next controls (#32627)
* Carousel: use buttons, not links, for prev/next

- expand the styles to neutralise border/background
- change docs page
- add extra unit test to check that links or buttons work as controls
- modify visual test to use buttons as well
- use buttons instead of links for prev/next
- remove `role="button"` from links that are actually links

* Clarify that controls can be button or link

* Update site/content/docs/5.0/components/carousel.md

Co-authored-by: Mark Otto <markd.otto@gmail.com>

* Explicitly set padding to 0 to prevent dipping/moving on active in Firefox

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-27 17:31:16 +02:00
Patrick H. Lauke
949fa30152
Remove role="button" from CTA links in carousel examples (#32788)
They're links, acting as links. Just because they're styled as buttons visually doesn't mean they need/get `role="button"`
2021-01-14 01:54:25 +02:00
Jonathan
88d35b725b
Hyphen to dash for ranges (#32488)
* Hyphen to dash for ranges

* Hyphen to dash for ranges

* Hyphen to dash for ranges

* Hyphen to dash for ranges

* Hyphen to dash for ranges
2021-01-05 13:56:44 -08:00
Théophile Helleboid - chtitux
265605bba0
carousel example: Move "active" class on .nav-link element (#32647) (#32647)
The "active" CSS class must be on "nav-link" element, see `_navbar.scss`:

```css
.nav-link.active {
  color: $navbar-dark-active-color;
}
```

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-05 22:15:59 +02:00
Gaël Poupard
3ef8483c5d docs(examples): use RTLCSS for RTL examples 2020-12-04 07:52:03 +02:00
XhmikosR
edfa103444 Adapt to the recent main branch changes 2020-12-04 07:52:03 +02:00
Gaël Poupard
aaff11a0b3 docs(examples): new cheatsheet and RTL examples 2020-12-04 07:52:03 +02:00