XhmikosR
ae43f0c48b
Tweak and re-organize ESLint config ( #38369 )
...
* Tweak and re-organize ESLint config
* merge individual configs to the root config
* enable more eslint-plugin-import rules
* lint markdown files
* Lint
2023-03-29 13:49:30 -04:00
XhmikosR
7a7fc1ad34
Modal: drop loop ( #38368 )
...
We only have two elements to iterate over so it doesn't make a lot of sense to use a loop here
2023-03-29 11:00:31 +03:00
GeoSot
ab049cd4a0
Remove version comment from JavaScript src files ( #38294 )
2023-03-22 09:12:33 +02:00
Roni Diwan
7432ebc665
Unify offcanvas
keydown
event logic with modal
( #38025 )
2023-02-11 09:35:10 +01:00
XhmikosR
cf9454caa0
Release v5.3.0-alpha1 ( #37661 )
...
* Bump version to 5.3.0-alpha1
* Dist
* Add docs versions updates
* Update note in homepage hero
Co-authored-by: Mark Otto <markdotto@gmail.com>
2022-12-24 18:37:22 +02:00
XhmikosR
8f6de23682
Merge branch 'main' into prepare-523
2022-11-22 09:51:29 +02:00
XhmikosR
39589472f7
Bump version to 5.2.3
2022-11-21 20:15:33 +02:00
GeoSot
e81e7cda90
Move getElementFromSelector
& getSelectorFromElement
to SelectorEngine ( #36027 )
...
* Move `getElementFromSelector` & getSelectorFromElement` inside selector-engine.js, in order to use SelectorEngine methods, avoiding raw querySelector usage
* add `getMultipleElementsFromSelector` helper
Co-authored-by: Julien Déramond <juderamond@gmail.com>
2022-11-06 20:31:43 +02:00
GeoSot
aa9d32dd15
Use explicit imports in our javascript source files ( #36854 )
2022-10-26 08:26:51 +03:00
XhmikosR
961d5ff984
Release v5.2.2 ( #37236 )
...
* Bump version to v5.2.2
* Dist
2022-10-03 10:44:02 +03:00
Jérémie Broutier
6f65df4fae
Fix modal event listeners ( #37128 )
...
* Fix modal event listeners (#37126 )
Co-authored-by: GeoSot <geo.sotis@gmail.com>
2022-09-15 13:30:51 +03:00
XhmikosR
23e50829f9
Release v5.2.1 ( #37098 )
...
* Bump version to v5.2.1.
* Dist
2022-09-07 18:31:39 +03:00
GeoSot
23fb7a7915
Fix modal event-listeners during dismiss click ( #36863 )
...
ref: #36855
2022-09-07 11:56:33 +03:00
XhmikosR
edf9c40956
Release v5.2.0 ( #36768 )
...
* Bump version to 5.2.0
* Dist
* Update masthead.html
2022-07-19 18:43:58 +03:00
GeoSot
d05c42a397
fix: change dismiss handler, listening to key down, instead of click ( #36401 )
2022-06-21 11:03:57 +03:00
louismaxime.piton
c137d11aa2
Re-ordering js default objects
2022-06-01 19:24:45 -07:00
Mark Otto
f7e8ca91e0
Prepare v5.2.0-beta1
2022-05-13 19:44:01 +03:00
GeoSot
b167420bdf
Revert backdrop utilization, handling clicks over modal ( #36324 )
...
* refactor(Modal.js): stop using backdrop class to handle clicks over modal
* Revert #35554 and backdrop callback usage
Explanation: In order to bypass `.modal`, was applied a css rule `pointer-events:none` which caused the side effect, and user couldn't scroll "long content modals"
* Update .bundlewatch.config.json
Co-authored-by: Mark Otto <markd.otto@gmail.com>
2022-05-12 21:20:04 -07:00
GeoSot
63f30ac8ee
Modal: refactor listeners to reduce some code noise ( #35902 )
2022-03-01 17:08:12 +02:00
GeoSot
28c9002573
Modal: handle click event from backdrop callback
2022-01-30 15:39:34 +02:00
XhmikosR
62d86c07f8
Rename variables
2022-01-29 13:25:30 +02:00
XhmikosR
0c3dfe104b
Remove a few unneeded variables
2022-01-29 13:25:30 +02:00
Phil E. Taylor
c2db7108c2
Fix typo in comment ( #35564 )
...
s/moddal/modal
2021-12-18 07:58:31 +02:00
GeoSot
886b940796
Extract Component config functionality to a separate class ( #33872 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-10 18:18:18 +02:00
GeoSot
91ad255e07
Change adjustDialog's if conditions to improve readability
2021-11-25 19:23:49 +02:00
GeoSot
0f9fd75d6c
Respect modal's initial overflowY
2021-11-25 19:23:49 +02:00
GeoSot
cc3e5789ec
Remove some uncovered code that seems to be unused
2021-11-25 19:23:49 +02:00
GeoSot
92e664c921
Change check for dynamic modal
2021-11-25 19:23:49 +02:00
GeoSot
fc33ce4b46
Tweak methods
...
Name them to be more descriptive and have agnostic functionality
2021-11-25 19:23:49 +02:00
GeoSot
79e01c3bad
Some refactoring on modal, to improve readability and generic functionality
2021-11-25 19:23:49 +02:00
XhmikosR
e8f702666f
JS: minor refactoring ( #35183 )
...
* add missing comments
* shorten block comments
* reorder constants
* reorder public/private methods
* sort exports alphabetically in util/index.js
* fix a couple of typos
2021-10-13 15:19:28 +03:00
XhmikosR
c44d64ed71
Merge remote-tracking branch 'remotes/origin/v513'
2021-10-09 18:28:28 +03:00
XhmikosR
1a6fdfae6b
Bump version to 5.1.3.
2021-10-09 09:43:19 +03:00
XhmikosR
666fe596bf
Enable unicorn/no-array-for-each
rule
2021-10-05 19:52:11 +03:00
XhmikosR
5ecef8ac01
Release v5.1.2 ( #35114 )
2021-10-05 18:50:18 +03:00
XhmikosR
0d81d3cbc1
Release v5.1.1 ( #34869 )
...
* Prepare v5.1.1.
* Dist
2021-09-07 18:37:44 +03:00
GeoSot
1e5e655670
Fix modal when is triggered by bs-toggle
, to hide other open instances ( #34701 )
2021-08-10 17:55:34 +03:00
XhmikosR
f20fece3a8
Prepare v5.1.0. ( #34674 )
2021-08-04 18:41:51 +03:00
XhmikosR
6d707f4801
Enable a few eslint-config-xo rules ( #34620 )
...
* unicorn/prefer-dom-node-append
* unicorn/prefer-dom-node-remove
2021-07-30 00:23:00 +02:00
GeoSot
4bfd8a2cbc
Use a streamlined way to trigger component dismiss ( #34170 )
...
* use a streamlined way to trigger component dismiss
* add documentation
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-28 17:39:32 +03:00
Ryan Berliner
7646f6bd33
Add shift-tab keyboard support for dialogs (modal & Offcanvas components) ( #33865 )
...
* consolidate dialog focus trap logic
* add shift-tab support to focustrap
* remove redundant null check of trap element
Co-authored-by: GeoSot <geo.sotis@gmail.com>
* remove area support forom focusableChildren
* fix no expectations warning in focustrap tests
Co-authored-by: GeoSot <geo.sotis@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-27 08:01:04 +03:00
GeoSot
dfafb9a60c
modal: change data-dismiss
so that it can be outside of a modal using bs-target
( #33403 )
...
* change data-dismiss, so can be outside modal, using a bs-target
* Update site/content/docs/5.0/components/modal.md
Co-authored-by: Gaël Poupard <ffoodd@users.noreply.github.com>
2021-07-19 16:56:05 +03:00
XhmikosR
688bce4fa6
Release v5.0.2 ( #34276 )
...
* Bump version to v5.0.2.
* Dist
2021-06-22 21:29:16 +03:00
GeoSot
cb47b8c964
Refactor scrollbar.js to be used as a Class ( #33947 )
2021-06-06 09:26:36 +03:00
GeoSot
c98657b830
Add getOrCreateInstance
method in base-component ( #33276 )
...
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-06-03 18:53:27 +03:00
alpadev
4a5029ea29
Fix handling of transitionend events dispatched by nested elements( #33845 )
...
Fix handling of transitionend events dispatched by nested elements
Properly handle events from nested elements
Change `emulateTransitionEnd` to `executeAfterTransition` &&
2021-06-03 14:44:16 +03:00
alpadev
b513a19003
Fix prevented show event disables modals with fade class from being displayed again ( #34085 )
...
Fix modal, in case is faded, a prevented show event can cause show method to not be executed again.
2021-05-24 18:52:36 +03:00
GeoSot
2757fbe28e
Reset inside a Dialog does not work if data-dismiss="modal"
is set ( #33928 )
2021-05-18 09:26:22 +03:00
XhmikosR
58b1be927f
Release v5.0.1 ( #33972 )
...
* Bump version to 5.0.1.
* Dist
2021-05-13 19:22:20 +03:00
GeoSot
9fe36edf68
Extract static DATA_KEY
& EVENT_KEY
to base-component ( #33635 )
...
* Force each plugin that extends base-components to implement a static method `NAME()`
* Remove redundant `NAME` argument from 'Utils.defineJQueryPlugin' & fix test
2021-05-11 10:49:30 +03:00