Mike Greiling
bc8e6ffb7d
removing this.$element as it is a superfluous copy of this.$scrollElement
2014-06-07 18:09:53 -07:00
Mike Greiling
632313d631
no need to check for href attribute on the scrollable element
2014-06-07 18:09:53 -07:00
Mike Greiling
0be4109688
there is no need for this.offsets and this.targets to be jQuery objects
2014-06-07 18:09:53 -07:00
Chris Rebert
21de05c8c0
don't show tooltips/popovers whose element isn't in the DOM; fixes #13268
2014-06-07 17:54:11 -07:00
Chris Rebert
b23ed1b034
put the tooltips into the DOM in the tooltip unit tests
2014-06-07 17:54:11 -07:00
Chris Rebert
20c099d41a
add failing test for #13268
2014-06-07 17:54:10 -07:00
XhmikosR
3b99a41246
Merge pull request #13388 from twbs/xhmikosr-js-style
...
Improve JS style
2014-06-07 09:13:05 +03:00
Chris Rebert
3cbbc70d55
Merge pull request #13627 from twbs/maybe-fix-12364
...
Hopefully fixes trigger focus restoration on modal close
2014-06-06 15:59:17 -07:00
XhmikosR
e2cabe4971
Minor style tweaks.
2014-06-06 01:23:07 +03:00
XhmikosR
82fc03f3b6
carousel.js: remove unneeded variable assignment.
...
`slideIndex` is assigned to the same value a few lines above.
2014-06-06 01:23:07 +03:00
XhmikosR
7b0acf14d8
Comply to the new style.
2014-06-06 01:23:07 +03:00
XhmikosR
5ef9383f53
Tweak JSHint and JSCS checks.
...
Be more consistent across the whole codebase.
Also, make use of JSHint's 2.5.1 `extends` and `qunit` options. This way we set our basis options in js/.jshintrc and override the rest.
2014-06-06 01:23:06 +03:00
Chris Rebert
475dbe58b0
Merge pull request #13589 from mrobinet/scrollspy-maxScroll-with-offset
...
Adjust for Scrollspy offset when calculating maxScroll.
2014-05-23 14:36:05 -07:00
Chris Rebert
bc1ce426d9
Merge pull request #13593 from ResentedHook/master
...
Add tooltip self-reference to address #12320
2014-05-23 14:33:19 -07:00
Chris Rebert
ef62254917
Merge pull request #13557 from bassettsj/aria-describedby-tooltip-13480
...
Aria describedby tooltip: #13480
2014-05-23 14:11:15 -07:00
Max Kramer
ee12ce8305
Add aria-haspopup and aria-expanded attributes to dropdown plugin
...
1. Add aria-haspopup="true" and aria-expanded="false" to dropdown docs
2. Toggle aria-expanded between "true" and "false" when opening and closing dropdown
Satisfy item 1 from https://github.com/paypal/bootstrap-accessibility-plugin#dropdown . See #13553 .
2014-05-22 18:13:41 -04:00
Chris Rebert
b058c018eb
Hopefully a fix for #12364
...
* register the callback before invoking the toggling
* listen for `hidden` instead of `hide`
* account for the possibility of the associated `show` event being preventDefault-ed
Adds relevant unit tests.
2014-05-19 02:14:14 -07:00
Chris Rebert
e9b99d475c
fix typo in assertion description
2014-05-19 00:47:06 -07:00
Chris Rebert
3d1723d689
add missing event namespacing in modal.js
2014-05-16 17:05:03 -07:00
Attila Dobi
f47ad79538
add target
option to Affix plugin
2014-05-16 13:07:45 -07:00
Steven Bassett
a70da16f6f
Adds aria described by to tooltip plugin for accessibility
...
Generates a unique id for tooltip and adds [aria-describedby] to the element
it is called on. Resolves issue #13480
- set up test
- linted the code styles
- passed the tests
- integrated feedback from @cvrebert
2014-05-16 10:45:38 -07:00
j.corns
122c05dbd8
Add tooltip self-reference to address #12320
...
primarily adds a data- attribute to the tooltip (and thus, the popover)
to create a self-reference.
2014-05-14 10:36:32 -07:00
Mike Robinet
c2e94eba8d
Add Scrollspy maxScroll with offset test.
2014-05-13 12:53:54 -05:00
Mike Robinet
e84b0c0433
Adjust for Scrollspy offset when calculating maxScroll.
2014-05-13 09:57:04 -05:00
XhmikosR
7a765d1f8b
Update jQuery to v1.11.1.
2014-05-13 08:33:23 +03:00
fat
f219fee07b
versions
2014-05-12 21:15:16 -07:00
Jacob
c312d735d9
Merge pull request #13191 from AshleyDawson/master
...
Fixed nested tab elements li activation
2014-05-12 20:57:21 -07:00
fat
9900771aa7
fixes #12211 : Scrollspy: Navs in different tabs can interfere with each othe
2014-05-12 19:15:23 -07:00
Gregory Pakosz
78cac11cef
Fixed affix-bottom positioning
...
Set top position to (scrollHeight - this.$element.height() - offsetBottom).
2014-05-09 00:26:31 +02:00
Chris Rebert
9444df2476
Merge pull request #13511 from hnrch02/button-reset-falsey-values-fix
...
Allow for resetText of a button to be a falsey value; fixes #13466
2014-05-05 22:55:05 -07:00
Chris Rebert
a032c396ee
Merge pull request #13406 from EnsignR/closed.bs.alert-after-remove
...
fires closed.bs.alert *after* DOM detach() as per #12379
2014-05-05 22:47:50 -07:00
Heinrich Fenkart
d8ee1ba9b6
Allow for resetText of a button to be a falsey value; fixes #13466
2014-05-05 19:07:47 +02:00
Chris Rebert
06af640e82
import rules from Ratchet's JSCS config with which we already comply
2014-05-04 15:15:02 -07:00
breaddevil
7627b24c1e
replace js scrollspy test for default behavior
2014-05-04 11:24:31 +02:00
Chris Rebert
d9edf28c5f
make new Carousel tests compatible with noConflict mode
2014-05-01 13:37:44 -07:00
Chris Rebert
b23ca2de41
add role="tooltip" to popovers; fixes #13481
2014-05-01 13:27:00 -07:00
Mark Otto
f20f66604b
Merge pull request #11966 from colllin/noconflict
...
Fix #11464 - JS noConflict() mode not working in 3.0.x
2014-04-30 17:43:43 -07:00
Ross Nye
73f7acc01b
Update alert.js
...
Added call to remove() after event fires to clean up data as per discussion at #12379
2014-04-30 13:12:31 +10:00
Chris Rebert
05d4932cad
Merge pull request #13396 from twbs/carousel-events
...
Carousel event properties
2014-04-25 19:35:38 -07:00
Chris Rebert
e114727ae9
Carousel.slide: rename e => slideEvent
2014-04-25 17:50:38 -07:00
Chris Rebert
4bd29bfcff
change 'slid' comments per @fat's feedback
2014-04-25 17:48:02 -07:00
Chris Rebert
4d0a8e31a4
Add direction & relatedTarget properties to slid.bs.carousel event
...
Fixes #13393
2014-04-24 19:02:47 -07:00
Ross Nye
637808f2ee
fires closed.bs.alert *after* DOM detach()
...
fires closed.bs.alert *after* element is removed from DOM.
Previously it fired while the element was still attached.
2014-04-23 17:34:32 +10:00
Collin Donahue-Oponski
a9f2b6ce0f
#11464 - Fix JS noConflict mode - Refactor all plugins to use an internal reference to the jQuery plugin, because in noConflict mode you can never expect to be defined on the jQuery object
2014-04-21 23:03:33 -06:00
fat
b9ae07d84a
fixes #13157 - Collapse plugin - issues with transition end event bubbling
2014-04-21 17:35:29 -07:00
Chris Rebert
f66a747615
add unit tests for Carousel slid events
2014-04-21 13:14:53 -07:00
Chris Rebert
9c4afc5772
spelling fixes in Carousel unit tests
2014-04-21 13:08:42 -07:00
Chris Rebert
d971ddb730
add missing operators to some JSCS rules that we already comply with
2014-04-20 16:33:23 -07:00
Tobias Lindig
a69bc3bc09
move call for removeBackdrop() to backdrop()
...
Closes #11958 by rebasing & merging it
2014-04-20 14:47:32 -07:00
Jacob
b02d3c7eff
Merge pull request #13306 from twbs/fat-11099
...
fixes #11099 - $.collapse() overrides the original dimension of the coll...
2014-04-20 12:12:17 -07:00