0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-02 14:24:19 +01:00
Commit Graph

1780 Commits

Author SHA1 Message Date
patrickhlauke
e3f9c463fc Opinionated: reintroduce cursor:pointer
Explicitly re-adds the "hand" `cursor:pointer` for non-disabled `.btn`, `.close`, `.navbar-toggler` elements, as well as forcing `page-link` pagination controls to always have the "hand" cursor (even if an author uses it on, say, `<button>` elements for a dynamically updating in-page pagination).

Controversial, as everybody jumped on the bandwagon following this article https://medium.com/simple-human/buttons-shouldnt-have-a-hand-cursor-b11e99ca374b - which does have its merits of course, but there are also counter-arguments like http://kizu.ru/en/issues/cursor-pointer/

And seeing the amount of issues we've seen following the change, and the potential complexity needed to consistently address the cursor issue (see https://github.com/twbs/bootstrap/issues/24156 where i explore how the cursor needs to be based on "intent", and how that's tough to determine), I'm favouring an opinionated take here of just reintroducing the `cursor:pointer`.
2017-12-27 16:28:10 -08:00
Mark Otto
cf5e99e172 Merge branch 'v4-dev' of https://github.com/twbs/bootstrap into v4-dev 2017-12-26 22:28:14 -08:00
Mark Otto
d603239b8a linting 2017-12-26 22:02:54 -08:00
Mark Otto
28fd9deb54 un-nest and un-chain popover classes 2017-12-26 21:58:57 -08:00
Mark Otto
fa2cc20e92 consolidate content properties, un-nest 2017-12-26 21:56:48 -08:00
Mark Otto
468c1615e2 smaller popover arrows for more reasonable visuals and more ideal pixel rounding 2017-12-26 21:54:47 -08:00
Mark Otto
6cf71f298c Merge branch 'fix-arrows' of https://github.com/simonihmig/bootstrap into simonihmig-fix-arrows 2017-12-26 21:36:12 -08:00
Mark Otto
b01e81ed36 Rewrite custom file input
- Changes the wrapping label to a div so we can style the label instead of another element while also supporting form validation.
- Fixes form validation styles for custom file input (closes #24831).
- Updates docs with validation styles (also adding example feedback text while I was there) and new how it works section.
2017-12-26 16:14:08 -08:00
ysds
c5209270ac Clean up button group (#25073)
* Remove unnecessary float

- since parent btn-group is displayed as inline-flex, the child elements are placed left to right by default.

* Cleanup of reset rounded corners

- Remove `border-radius :0` since it is enough by each reset of left and right side
- A `.dropdown-toggle` selector should not be used for reset rounded corner since it does not have border-radius property. Instead use .dropdown-toggle as negation pseudo-class.
2017-12-26 16:04:11 -08:00
ysds
8c6011ab4f Fix input group border radius issue (#25075) (#25076)
* Fix input group border radius issue (#25075)

* Remove migration note

- All buttons In input group do not have to be the same element now.

* lint
2017-12-26 14:23:07 -08:00
Mark Otto
03e1c47bc2 Darken table border-color
Fixes #25016 which noticed a .thead-light and border-color of the .table-border are the same color.
2017-12-26 13:47:48 -08:00
Mark Otto
4205b262d3 Update SCSS import order to have print styles last 2017-12-26 13:20:12 -08:00
Mark Otto
2416801c7e remove input group overrides since they're defaults now 2017-12-23 17:50:52 -08:00
Mark Otto
c468f89b1c Make custom select and file inputs 100% wide
Matches browser default inputs and swaps some max-width properties for a regular width
2017-12-23 17:50:52 -08:00
simonihmig
9600ab1003 Fix tooltip/popover arrow size and position 2017-12-23 18:29:57 +01:00
Mark Otto
eb60521c03 Move .table-responsive to a parent class instead of a modifier 2017-12-22 20:09:58 -08:00
Andres Galante
aacfcc248d adds hover state to the button element for background color utilities (#24813)
* adds a hover state to the button element on the backrgound color utitility

* Adjust z-index to fix hover/focus overlaps
2017-12-22 19:41:13 -08:00
Mark Otto
0a420124ea
Restyle code element, remove docs example overflow, improve docs examples (#25054)
* Restyle code element, clean up variables

- Removes the padding and background-color
- Changes the color to a brand color ()
- Add new variables to kbd element styles to account for removing the code ones
- Remove overrides that were needed previously

* only break between words, and override it in the pre

* make file inputs 100% wide

* scope custom file changes in input group for sizing

* shorter button labels for responsive

* narrower cards

* button was too wide

* downsize

* fewer links in pagination

* redo cell text

* improve overflow docs
2017-12-22 16:49:57 -08:00
Mark Otto
16f1417240
Form check markup v2 (#25050)
* match layout behaviors

* ditch the indicator as separate element for psuedo-elements on the label

* move disabled to attribute only on input

* redo default inline check to support new markup

* redo inline forms

* clean up vars

* update validation mixin to new structure

* update checks in docs

* linting for for/id attributes
2017-12-22 16:13:01 -08:00
Mark Otto
13150872c6
Rewrite input group component (#25020)
* Rewrite input group component

* Set the feedback to 100% width for input group

* Move from .row to .form-row for tighter layout

* no need for custom feedback here, we're using browser messaging

* add input group to validation examples

* add note about validating multiple

* migration note added
2017-12-22 15:29:49 -08:00
Troy Morehouse
9de141f428 Remove .col-form-legend in favor of .col-form-label (#24932)
* chore: sync with twbs (#1)

* Make styling of grouped option buttons class-based

Referencing #23728, styling grouped radio and checkbox buttons should not require the data-toggle attribute.

* Fix installing deps in our webpack docs

* Fix nested cards on card group (#24766)

* Update popper.js to v1.12.9. (#24797)

* Don't run postcss for `dist/css/*.min.css` files. (#24676)

* Change the text color to dark on bg color warning examples (#24805)

* Remove unused file and bundle ie-emulation-modes-warning.js with docs.min.js (#24825)

* Remove the unused assets/js/ie10-viewport-bug-workaround.js.

* Combine ie-emulation-modes-warning.js with docs.min.js.

* Typos in grid.md (#24828)

Fixed typos in offsetting section of grid.md

* Fix dropup example code

* Update devDependencies. (#24829)

* Add support for fractional viewport widths (zoom/high-dpi displays) (#24299)

* Change breakpoint  max- calculation to fractional values
* Update docs to reflect fractional max-width breakpoint values
* Add fractional max-width to offcanvas example
* Add documentation and SCSS comment for fractional viewport support

* Add a simple script to generate SRI hashes for our assets. (#24814)

* Allow us to run our unit test on differents jquery version

* Run karma tests in parallel.

* Update typography docs (#24863)

* closes #24450

* Rewrite custom form check backgrounds (#24697)

* Rewrite custom form check backgrounds

Previously, this was all just a background-color and background-image. When we restored the gradients though, we had two background-images competing on the same element, causing rendering glitches. This refactors that code, creating a mixin to simplify things, so we can we easily use two background-images (SVG icon and gradient) when -gradients is set to true.

Fixes #24598

* restore default vars

* Revamp custom check and radio backgrounds

Instead of applying multiple background-image's to the same element, we're adding a new ::before pseudo-element to layer the background-images. Gradients go on the .custom-control-indicator while their icons go on the ::before element. This allows us to shave some bytes from when we compile and we previously needed to redeclare the background-image for the icon if you changed the gradient.

* remove now unused mixin

* mention change in migration docs

* lets the centered modal have any height (#24803)

* Custom select updates (#24699)

* Add support for size attribute on custom selects

* Add large custom select, document it and the small variant

* fix custom select focus state

* fix custom file input focus styles

* remove empty line

* Update package.json. (#24582)

1. Use the same jQuery version in jspm
2. Update the files to only include the source and dist folders

* Use Jekyll's `smartify` filter when possible. (#24866)

* Darken outline hover color to match default button hover (#24150)

* Fix Issue #24144

Alter button-outline-variant mixin to darken hover and active background in same fashion as filled button.

* Fix Issue #24144

Filled button on hover should utilize the same color-yiq mixin so that theme buttons match

* default values, fix mixin

* rename it

* document it

* add migration note

* fixes #24728

* Remove unused CSS. (#24872)

* tab.js: do not remove fade class if there's no initial active pane

* Restore currently unused variables (#24891)

* Replace lint-vars.sh with a Node.js script. (#24860)

Also, include it in the `css` npm script since it's instant.

* Fix docs horizontal scrollbar (#24878)

* Fix docs horizontal scrollbar in Components > Modal

* Add overflow to docs example class

* Drop the handleUpdate() variant

While I understand the variant covers the "get a particular plugin instance" case from http://getbootstrap.com/docs/4.0/getting-started/javascript/#programmatic-api it seems weird that we do it here but not everywhere else in the docs (randomly checking other pages, we seem to stick to the documented methods as written on those pages). As this isn't properly explained as is, and as it adds nothing (more of a preference for authors), it would be easier to just drop the variant and stick with the documented method as outlined later on in the same page (avoids having to go off on a "why should you use this instead of that" tangent here).

* Combine path and remove variable used in one place. (#24873)

* Update devDependencies and gems. (#24876)

* Override padding on radio input label (#24899)

We could tell folks to nix the class, we could tell them to override it, or we could add another modifier of some kind to address this. None of them seem particularly useful, but the padding override feels the most approachable and clearly documentable. Added this here to close #24844.

* Update README.md (#24912)

* Work around Travis failures.

Note that we should revert this when the issue is fixed.

* Revert the Travis workaround. (#24926)

The issue has been fixed.

* add .col-form-legend-lg and .col-form-legend-sm classes

* document .col-form-legend-{size}

* trash .col-form-legend completely

One class fits all

* Update forms.md

* consolidate copy

* property order
2017-12-02 11:51:38 -08:00
Andres Galante
1d6e3710dd Adds variable for color yiq threshold (#24886) 2017-12-01 19:26:10 -08:00
XhmikosR
c2c0eebd43
Update devDependencies and gems. (#24876) 2017-11-28 12:26:50 +02:00
Mark Otto
671bb278bb Restore currently unused variables (#24891) 2017-11-27 19:31:11 +02:00
Mark Otto
babdf36c42 Merge branch 'v4-dev' of https://github.com/twbs/bootstrap into v4-dev 2017-11-24 17:02:01 -08:00
Mark Otto
ccb201b22a rename it 2017-11-24 16:58:23 -08:00
Mark Otto
725f5fbda5 Merge branch 'btn-group-styling' of https://github.com/picapixa/bootstrap into picapixa-btn-group-styling 2017-11-24 16:49:43 -08:00
afholderman
7c10068c76 Darken outline hover color to match default button hover (#24150)
* Fix Issue #24144

Alter button-outline-variant mixin to darken hover and active background in same fashion as filled button.

* Fix Issue #24144

Filled button on hover should utilize the same color-yiq mixin so that theme buttons match

* default values, fix mixin
2017-11-24 16:42:40 -08:00
Mark Otto
2ec1606ab7
Custom select updates (#24699)
* Add support for size attribute on custom selects

* Add large custom select, document it and the small variant

* fix custom select focus state

* fix custom file input focus styles

* remove empty line
2017-11-24 14:29:59 -08:00
Andres Galante
b29e3f2a4c lets the centered modal have any height (#24803) 2017-11-24 14:28:58 -08:00
Mark Otto
4829350a46
Rewrite custom form check backgrounds (#24697)
* Rewrite custom form check backgrounds

Previously, this was all just a background-color and background-image. When we restored the gradients though, we had two background-images competing on the same element, causing rendering glitches. This refactors that code, creating a mixin to simplify things, so we can we easily use two background-images (SVG icon and gradient) when -gradients is set to true.

Fixes #24598

* restore default vars

* Revamp custom check and radio backgrounds

Instead of applying multiple background-image's to the same element, we're adding a new ::before pseudo-element to layer the background-images. Gradients go on the .custom-control-indicator while their icons go on the ::before element. This allows us to shave some bytes from when we compile and we previously needed to redeclare the background-image for the icon if you changed the gradient.

* remove now unused mixin

* mention change in migration docs
2017-11-24 14:26:56 -08:00
Patrick H. Lauke
dcb761350c
Add support for fractional viewport widths (zoom/high-dpi displays) (#24299)
* Change breakpoint  max- calculation to fractional values
* Update docs to reflect fractional max-width breakpoint values
* Add fractional max-width to offcanvas example
* Add documentation and SCSS comment for fractional viewport support
2017-11-20 05:13:37 -05:00
Andres Galante
8e4ba117bc Fix nested cards on card group (#24766) 2017-11-16 12:41:48 +02:00
Edward Betts
ffc5965f2c Correct spelling mistakes. (#24778) 2017-11-15 04:12:38 -05:00
Andres Galante
1ee9cb04bd Adds variables for form validation messages (#24767) 2017-11-15 03:32:08 +02:00
Raffy Alcoriza
9e8a3c041b
Make styling of grouped option buttons class-based
Referencing #23728, styling grouped radio and checkbox buttons should not require the data-toggle attribute.
2017-11-09 15:02:46 +08:00
Andres Galante
b755883059 Adds underline back to btn-link on focus 2017-11-08 11:05:12 -05:00
ysds
ccc95d0c96 Reduce custom file z-index (#24633) 2017-11-06 15:58:28 -08:00
Patrick Yeo
c2a7a2c41d Nav Tabs use single variable to style $nav-tabs-link-hover-border-color and $nav-tabs-link-active-border-color (#24639) 2017-11-06 13:35:52 -08:00
Patrick Yeo
e2c15da967 Move hardcoded opacity value in .btn:disabled to variable $btn-disabled-opacity (#24680) 2017-11-06 13:34:42 -08:00
Mark Otto
bb53b32585
fixes #24553: override border-color on focus of custom select with form validation (#24695) 2017-11-06 12:04:56 -08:00
Mark Otto
a8aaccbd4d
Restore .progress-bar transition (#24694)
Unintentionally removed in #22703. Fixes #24643.
2017-11-06 12:02:42 -08:00
Gijs Boddeus
bfbf24e7a5 fixing label cutoff at 0% (#24544) 2017-11-06 09:57:25 -08:00
Andres Galante
058123440f Convert px values to rem on tooltip variables (#23468)
* converts px valures to rem on tooltip variables

* keep as px to match popover changes
2017-11-06 09:29:12 -08:00
Andres Galante
b931070bd7 changes list-inline-padding from 5px to .5rem 2017-11-06 09:28:29 -08:00
XhmikosR
34d745540d
Minor Sass consistency changes. (#24677)
* use `background-color` instead of the shorthand
* use `outline: 0` consistently
* fix transform order
* remove quotes from `SFMono-Regular`
2017-11-06 02:23:36 +02:00
Andres Galante
9244974064 Convert modal's px units to rem (#23782) 2017-11-02 02:23:51 +02:00
Andres Galante
1870b871d0 adds variables for the hr element margin 2017-10-30 13:11:47 -07:00
Andres Galante
904f22c94f changes colors references on variables.scss from hardcoded to variables on the theme 2017-10-30 13:10:52 -07:00
Johann-S
e454c8ec1e Add dropright and dropleft (right and left placements for our dropdown) (#23860)
* Add dropright (right placement for our dropdown)

* Add dropleft

* moves drop left arrow to the left
2017-10-29 15:29:13 -07:00