Ilias
a14451deb3
Fix #18373 : properly adjust padding-right of body and fixed elements when opening or closing modal
2017-04-02 13:26:25 +02:00
Pierre Vanduynslager
91b62941af
Tabs/Scrollspy/.nav/.list-group/.active independent of markup (<nav>, .nav-item, <li> etc...)
2017-04-02 11:21:04 +02:00
Johann-S
5142de7e59
Popover + Tooltip - fix error when content or title is a number
2017-03-31 10:03:54 +02:00
Johann-S
fb42d6e043
Collapse - Fix check to not prevent event for input and textarea
2017-03-29 00:10:27 +02:00
Johann
904efc043d
Fix different tooltips offset when hovering
2017-03-28 15:55:03 +02:00
Johann
24924c23b2
Collapse - do not prevent event for input and textarea
2017-03-27 10:08:39 +02:00
Pierre Vanduynslager
37f438910f
Accordion behavior with JQuery interface ( #21726 )
...
Fix accordion behavior with JQuery interface
2017-03-23 21:15:41 +01:00
Johann
c72a315740
Carousel - Add attributes from and to for Slid and Slide events ( #21668 )
...
Carousel - Add attributes from and to for Slid and Slide events
2017-03-22 22:42:13 +01:00
Pierre Vanduynslager
78fc4d23fc
Always append element to fixture in Scrollspy unit tests ( #22234 )
2017-03-21 10:21:00 -07:00
Mark Otto
3730c5dbf5
Merge branch 'collapse' of https://github.com/Johann-S/bootstrap into Johann-S-collapse
2017-03-19 18:43:13 -07:00
Johann
1a46d8c730
Allow to use Tab.js with list-group ( #21756 )
...
* Allow to use Tab.js with list-group
* Allow to use list-group with div parent instead of an ul parent
2017-03-18 16:36:33 -07:00
Johann-S
21b537cc24
Add unit test
2017-03-09 11:08:47 +01:00
Pierre-Denis Vanduynslager
4ab576a419
Fixes #21941
2017-02-08 18:51:50 -05:00
Pierre-Denis Vanduynslager
ef2181ff4d
Harmonize document.activeElement comparison
2017-01-20 23:22:50 -05:00
Pierre-Denis Vanduynslager
4448ca057b
Refactor test to event and async
2017-01-20 23:02:45 -05:00
Pierre-Denis Vanduynslager
1a783a4255
Add unit test for keyboard navigation
2017-01-20 23:02:19 -05:00
Pierre-Denis Vanduynslager
9daf681478
Fix test to retrieve the proper item instead of it's parent
2017-01-20 20:27:14 -05:00
Pierre-Denis Vanduynslager
4c2f544359
Merge branch 'twbs/v4-dev' into dropdown-keyboard
2017-01-06 15:57:15 -05:00
Pierre-Denis Vanduynslager
eb84c03ddf
Update dropdown unit test to new markup
2017-01-06 15:56:38 -05:00
Johann-S
0463b01282
Close #21090 - Fix aria-pressed attribute for buttons in container with data-toggle='buttons'
2017-01-04 11:02:16 +01:00
Pierre-Denis Vanduynslager
bbb0d2b573
Dropdown: close menu when focusing outside element ( #21375 )
...
* Close dropdown menu when focusing an outside element
* Update unit test to new markup
2017-01-02 14:44:27 -08:00
Mark Otto
c61a0059ad
update seletors in js
2017-01-02 11:52:38 -08:00
Johann-S
026e1a1421
Allow to use nav with tab JS
2016-12-31 00:54:00 -08:00
Johann-S
95ce03f000
Close #21249 : Add a Unit test for #21227
2016-12-29 13:28:42 -08:00
Max Beatty
aa7f95fd77
update click state when hiding so can be shown again by trigger. fixes #16732
2016-12-27 14:19:12 -08:00
Alessandro Rodi
9103bffe37
[ Fix #19849 ] Tabs are opened even if disabled. ( #20795 )
...
* [Fix #19849 ] Tabs are opened even if disabled.
* fix hund code review hints
* rollback hound issues because Travis fails
2016-12-24 23:31:34 -08:00
Matheus Azzi
dab6a41e04
Carousel: Only prevents default for ARROW_LEFT and ARROW_RIGHT keys
...
Fixes 2 bugs:
1. All keydowns were being prevented. Because of that the user wasn't able to navigate in the whole page using ARROW_UP/ARROW_DOWN.
2. Even when is an input or textarea the keydowns were being prevented. Because of that the user wasn't able to type any text on these elements.
2016-12-23 17:55:40 +11:00
Starsam80
bf39bb3ac3
Rename .active
to .show
2016-12-07 21:20:15 -07:00
Rob Ruana
5eddb0b0fd
Closes #21055 : Prevents ScrollSpy from clearing active item when Safari rubberbands ( #21056 )
...
When the rubberband effect causes Safari to scroll past the top of the
page, the value of scrollTop becomes negative. If the offset of the first
ScrollSpy target is 0 - essentially if the target is at the top of the
page - then ScrollSpy should not clear the active item. Conceptually, the
first item should remain active when rubberbanding past the top of the
page.
This commit fixes issue #21055 by verifying the first scrollspy target is
not at the top of the page before clearing the active nav-item.
2016-11-27 16:20:33 -08:00
Mark Otto
b6b8280938
Merge pull request #18900 from vlastikcz/v4-dev-buttonChange
...
Button toggling - trigger change event on input. Fixes #16673 , fixes #17599 .
2016-11-26 01:18:21 -08:00
Mark Otto
ce31f54c36
Merge pull request #19058 from Johann-S/carouselInput
...
Carousel - Do not prevent on keydown for input and textarea
2016-11-26 01:14:55 -08:00
Mark Otto
25d218b02d
Merge branch 'v4-dev-18796' of https://github.com/maxbeatty/bootstrap into maxbeatty-v4-dev-18796
2016-11-26 00:58:51 -08:00
Johann
ce18a66809
Add test unit to check logic of ignoreBackdropClick ( #18245 )
2016-11-25 22:57:20 -08:00
Mark Otto
432fe74c31
Merge branch 'eslint' of https://github.com/bardiharborow/bootstrap into bardiharborow-eslint
2016-11-25 14:59:28 -08:00
Matt Hernandez
b1b1f30cbd
[ Fix #17371 ][V4] Deactivating dropdown links in nav tab ( #17642 )
...
* Fix bug with dropdown tab links not deactivating when other tab or dropdown link is clicked
* Revise bug fix for more stability
2016-11-25 14:56:41 -08:00
Bardi Harborow
c2616fb74e
Make JS compliant with the new ESLint rules.
2016-11-24 11:59:55 +11:00
Johann
a7f1b59959
Making .tooltip('show') throw an error on elements with display:none ( #20940 )
2016-10-31 20:33:53 -07:00
Mark Otto
c01fa6b369
Merge pull request #17536 from Johann-S/testPadding
...
[Fix #17400 ] Add tests about padding restoration
2016-10-28 13:46:14 -07:00
Johann-S
9d129a43d6
Use a single class name for opened/expanded/shown state of widgets
2016-10-25 14:07:41 +02:00
Mark Otto
73154d0392
Merge pull request #20467 from maxbeatty/v4-dev-17754
...
add support for ol in tab plugin
2016-10-24 20:50:52 -07:00
Johann-S
9bc7de9395
Fix bug multiple accordions collapse
2016-10-19 09:35:48 +02:00
Johann-S
de1255b14e
Collapse using card component
2016-10-11 13:25:36 +02:00
Mark Otto
4d725c90d6
Merge pull request #17568 from Johann-S/fixCollapseHeight
...
[Fix #17555 ][V4] fix resetting style on closing collapse
2016-10-09 20:32:40 -07:00
VarelloThemes
63129112bb
replace some profanities ( #20715 )
2016-09-15 09:39:31 -07:00
Max Beatty
dc1b4e78d4
add support for ol in tab plugin. fixes #17754
2016-08-04 16:57:08 -07:00
Max Beatty
bfa714ae1e
prevent navigating to area href when modal target. fixes #18796
2016-08-04 13:47:30 -07:00
Dave Methvin
8900d953ed
ScrollSpy unit test: Use single done() in a then() instead of multiple done()s ( #20198 )
...
Fixes test flakiness on OS X Safari and Android when using jQuery 3.
Fixes #20182 more
Refs #20191
2016-06-28 13:24:28 -07:00
Dave Methvin
208d587c7e
Scrollspy test: Allow for async .then() in jQuery 3; fixes #20182
...
Instead of doing a new assert.async(), just do a single one for the entire test
and let the .then() be async as well.
Closes #20190
2016-06-27 22:37:31 -07:00
Chris Rebert
aa369bd8f9
Remove unnecessary usage of Promises in non-async ScrollSpy tests ( #20180 )
...
Closes #19906
[skip validator]
2016-06-26 21:33:07 -07:00
Chris Rebert
14c7ba95f9
Fix load & scroll event usage in ScrollSpy tests ( #19986 )
...
* Use $.one() instead of $.on() since there are no $.off()s in the code.
* Remove unnecessary namespacing of listeners for the `scroll` & `load` events.
These are vanilla DOM events (not custom jQuery namespaced events)
and we're not using jQuery namespacing to manage these event listeners either (e.g. `$.off()`).
[skip validator]
2016-05-30 09:39:45 -07:00
Chris Rebert
d35973c2b3
js/tests/unit/scrollspy.js: Fix "offsed" typos ( #19985 )
...
[skip sauce]
[skip validator]
2016-05-29 18:36:09 -07:00
Patrick H. Lauke
b107e3342a
Handle aria-hidden on modal container when showing/hiding
...
Fixes #19878
2016-05-11 02:01:56 +01:00
Johann-S
14ec4fdfc1
Carousel - Do not prevent on keydown for input and textarea
2016-02-01 00:06:07 +01:00
Kotas Vlastimil
866e99b00c
Button toggling - trigger change event on input
...
Bootstrap’s .button styles can be applied to other elements, such as labels, to provide checkbox or radio style button toggling.
When the checkbox or radio state is changed, there should be triggered the change event. Currently, the change event is triggered on the Button, which is not correct. Only input fields do support the change event.
2016-01-14 20:26:32 +01:00
Chris Rebert
96e9205009
js/tests/unit/modal.js: Fix typo
...
[ci skip]
2015-12-22 17:11:21 -07:00
Johann-S
21a65f181e
Add throw error for undefined method on plugins
2015-10-02 10:01:24 +02:00
Johann-S
32f9a5d6a5
fix resetting style on closing collapse
2015-09-11 10:45:08 +02:00
Johann-S
8ece899ba8
Add tests about padding restoration
2015-09-10 08:19:59 +02:00
Gleb Mazovetskiy
c7d8e7a077
Accept elements as the tooltip / popover content
...
When a DOM node is passed to an HTML tooltip, the `title` node is only
moved if it is not already in the tooltip. Otherwise, `empty()` is used
instead of `detach()` before appending the `title` to avoid memory
leaks. If a DOM node is passed to a plain text tooltip, its text is
copied via jQuery `.text()`.
Replaces `.detach()` with `.empty()`, as `.detach()` is almost never
useful but instead leaks memory. The difference between `empty` and
`detach` is that the latter keeps all the attached jQuery events/data.
However, since we do not return the previous children, the user would
have to keep these themselves, thus they can `detach()` if necessary.
This is a port of https://github.com/twbs/bootstrap/pull/14552 to v4.
2015-08-31 01:06:13 +01:00
XhmikosR
13e33e329c
Remove the obsolete JSHint references.
2015-08-27 08:11:11 +03:00
Jacob Thornton
03e732708c
rewrite tab with new active shit
2015-08-18 22:03:34 -07:00
Jacob Thornton
4e45e2363c
Merge branch 'v4' of github.com:twbs/derpstrap into v4
2015-08-18 21:23:53 -07:00
Jacob Thornton
18ff57a183
js tests passing + eslint
2015-08-18 19:22:46 -07:00
Jacob Thornton
f1827e5f9c
add polyfil for bind for tether.js
2015-08-18 17:06:17 -07:00
Mark Otto
1ddc3f5e21
Merge branch 'master' into v4m
2015-08-04 22:29:45 -07:00
Johann-S
ef1ce9ac0b
Fix triggering of {shown,hidden}.bs.dropdown events so relatedTarget gets set properly
...
Fixes #16828
Closes #16865
2015-07-27 00:58:51 -07:00
Mark Otto
169d2a4a78
Merge branch 'master' into v4
2015-06-18 23:56:43 -07:00
Patrick H. Lauke
5fd7bc1554
generalize dropdowns / drop role="menu"
...
as role="menu" is a very specific (and strict) ARIA pattern for
desktop-like application menus, and our dropdowns are often used
as pure navigation dropdowns, this change abandons ARIA menus for
a more open-ended and light-weight approach
(see http://heydonworks.com/practical_aria_examples/#submenus and
http://www.w3.org/WAI/tutorials/menus/flyout/#improve-screen-reader-support-using-wai-aria )
note that in dropdown.js, switched to now target ``.dropdown-menu``
instead of ``role["menu"]`` - this also prevents bootstrap scripts
from "bleeding" into non-bootstrap components on the same page.
also removed the ``role=["listbox"]`` part, which appears to be
vestigial/unused (only place in bootstrap that uses that
role are carousels, and their key handling is done separately)
2015-06-02 11:03:21 +01:00
XhmikosR
315907c97c
Use https
when possible.
2015-05-17 12:43:20 +03:00
fat
6b2b0ed32f
al tests passing, dist rebuilt, w/typechecker
2015-05-13 14:52:46 -07:00
fat
eaab1def7a
add simple type checker implementation
2015-05-13 14:46:50 -07:00
fat
c2ced2292a
fix up tests
2015-05-13 13:46:08 -07:00
fat
b0d142334f
fix #15301
2015-05-13 13:43:56 -07:00
fat
da495ee24c
address https://github.com/twbs/bootstrap/pull/16135
2015-05-13 13:15:11 -07:00
fat
f8b2569ec8
implement global dispose method
2015-05-13 12:48:34 -07:00
fat
ab1578465a
grunt test-js, grunt dist-js now working
2015-05-12 16:52:54 -07:00
fat
a58febf71a
popover passing as well
2015-05-12 14:35:00 -07:00
fat
3452e8dc83
rewritten tooltip + tether integration and death to our positioner jank
2015-05-11 23:32:37 -07:00
fat
ca9c850ebb
add getters for Version and Default where applicable
...
add modal my gawd
2015-05-10 19:45:38 -07:00
fat
8bab38bb71
add collapse
2015-05-09 23:04:58 -07:00
fat
1b183e2ff7
carousel -> es6
2015-05-07 22:26:40 -07:00
fat
6605051882
button -> es6
2015-05-07 17:14:38 -07:00
fat
0724bd91ff
es6 alert :|
2015-05-07 12:57:31 -07:00
fat
d1fbe200f4
remove closureness from plugins
2015-05-06 13:34:14 -07:00
XhmikosR
a2f81ceb57
phantom.js: switch to unicode characters that work on Windows too.
2015-05-05 06:58:54 +03:00
XhmikosR
49c4556354
Comply to the new JSCS rules.
2015-05-05 06:50:18 +03:00
Chris Rebert
aa2c5b5672
Merge pull request #16014 from redbmk/issue-16008
...
Multiple tooltip triggers don't play well together
2015-05-04 15:07:17 -07:00
Patrick H. Lauke
0c1daaf2ce
Remove broken/vestigial unit test
...
Overall logic for this test appears broken, possibly relating to an
older version of Bootstrap that did not require explicit
`data-toggle="button"` on single toggle buttons?
2015-05-01 12:58:10 +01:00
Braden M. Kelley
4b269037cb
Multiple tooltip triggers don't play well together
...
Fixes issue #16008
2015-04-27 23:03:56 -07:00
F A T
aa479892d5
Merge pull request #16152 from jarthod/tooltip-placement-viewport-fix
...
Tooltip/popover: Fix auto placement to use viewport
2015-04-27 11:28:54 -07:00
Chris Rebert
cdb37dce3a
Set box-sizing: border-box
on .container-viewport in #16142 testcase
...
Otherwise, the test doesn't properly fail when the fix is reverted.
2015-04-27 01:23:39 -07:00
Adrien
37a10d37c1
Compare tooltip right offset to viewport right offset (and not width)
...
Closes #16142 by merging it.
2015-04-27 01:13:16 -07:00
Chris Rebert
fc372952e2
Throw error when tooltip/popover template has multiple top-level elements
...
Closes #16219 .
2015-04-25 13:16:53 -07:00
Chris Rebert
0d77644fc4
throw error when trying to show tooltip on :hidden element
2015-04-23 17:14:45 -07:00
Adrien Siami
e949505b89
Allow viewport option to be a function
...
Closes #16151 by merging a rebased version of it that adds docs and 1 more assertion.
2015-04-21 22:20:15 -07:00
Chris Rebert
c6b62f0cd9
Merge pull request #16147 from Johann-S/event_inserted
...
Fixes #16124 .
2015-04-21 21:40:14 -07:00
Patrick H. Lauke
66d71136e6
Fix existing radio button unit test
2015-04-11 19:24:21 +02:00
Johann-S
3d71eae301
Add event after template inserted
2015-04-08 13:10:53 +02:00
Adrien Jarthon
5921724d9c
fixed IE incompatible CSS
2015-03-29 19:16:59 +02:00
Adrien Jarthon
df96c3e615
Added non-regression test & fixed existing one
2015-03-29 14:59:21 +02:00