0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-14 02:24:00 +01:00
Commit Graph

20857 Commits

Author SHA1 Message Date
Kyle Tsang
02dbd87ffa
Fix event handler removal in dropdown/carousel dispose (#33000)
* Fix event handler removal in carousel dispose

* Fix event handler removal in dropdown dispose

* Test event handlers in scrollspy dispose

* Test event handlers in toast dispose

* Test event handlers in tooltip dispose

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
2021-02-12 07:51:34 +02:00
Gaël Poupard
0a9d392975
Docs improvements after beta2 (#33049)
* docs(carousel): double-spaces out there

* docs(toasts): missing word, ins't it?

* docs(cheatsheet): use buttons for carousels and tabs ion cheatsheets too

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-11 19:48:08 +02:00
Mark Otto
037b5df737
Revert dist changes from #32747 (#33050) 2021-02-11 17:22:18 +02:00
eldk
8125856272
Add Parcel Bundler doc (#30909)
* Add Parcel Bundler doc

* Update parcel.md

* Improve parcel.md

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
2021-02-11 08:22:20 +02:00
Sam Willis
2f03e32d8c Add input focus blur variable 2021-02-10 21:03:37 -08:00
Patrick H. Lauke
df79aad5e4 Remove explicit suppression of focus outline
It's unclear what the reason for first introducing the original hack here (for `[tabindex="-1"]:focus {...}`) was. Seems something that may have been useful/necessary in SuitCSS, but don't think BS ever relied on this. https://github.com/twbs/bootstrap/issues/18330
It's since been modified to only apply when the browser wouldn't apply a visible outline anyway based on its own heuristics (the `:not(:focus-visible)` part) https://github.com/twbs/bootstrap/pull/28437/

But now, thinking this through more...in browsers that do support this pseudo-selector, what this is essentially saying is redundant: don't apply outline in cases where a `tabindex="-1"` element receives focus but the browser wouldn't normally apply focus outline". at best, this is unnecessary. at worst, this actually overrides things an author may explicitly be trying to do with adding `:focus { outline: ... }` explicitly.
2021-02-10 19:35:52 -08:00
Mark Otto
4c7a3e8adf
Add Sass docs (variables, mixins, and loops) to most pages (#32747)
* WIP: Mention variables, mixins, and loops in docs

* Add Sass sections to component pages

* add sass docs for forms and content

* Update buttons.md

* Remove empty mixins sections

* Massive update to utilities and some consistency changes

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-10 19:29:59 -08:00
XhmikosR
e50c11b8c6
Release v5.0.0-beta2 (#32467)
* Bump version to 5.0.0-beta2

* Dist
2021-02-10 18:14:51 +02:00
Gaël Poupard
2bb42a9176
docs(scroll offset): improve a11y for sticky header (#33027)
Our current trick works great for headings or landmarks `:target`ed by links activation, however it still allows focus to be hidden under the sticky header. 

1. Go to any docs page, 
2. use a TOC link to scroll down the page, 
3. then `Shift`+`Tab` to navigate backward using keyboard. 

You should see on some browsers (mainly Firefox from my tests, but it used to do the same in Chrome) that focused elements isn't visible, hidden by our sticky header.

Applying `scroll-padding-top` to the `:root` solves this without any side-effect—but it requires to drop `scroll-margin-top` for anchors to prevent doubling the offset.

FWIW based on my test, Edgium and Chromium don't really care since they seem to have a new heuristic for such cases, making the focused element scroll to the center of the view.
2021-02-10 07:27:43 +02:00
XhmikosR
2ab6dbd2d6
Downgrade karma to v6.0.4. (#33030)
It seems v6.1.0 has some disconnect issues, so, trying to see if that's the case.
2021-02-10 07:22:45 +02:00
Rohit Sharma
f7088e5d28
Add function type for popperConfig option (#32882)
* Add function type for `popperConfig` option

* Update .bundlewatch.config.json

* copy edits

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markdotto@gmail.com>
2021-02-09 21:16:13 +02:00
Rohit Sharma
29e0c9dfa1
Dropdown — Change the selector to check the use of Popper (#33003)
* Create the popper instance first

Make sure that popper instance has been created first and then apply the
styling on the dropdown(menu)

* Use `data-bs-popper` attibute to check popper

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-09 21:04:23 +02:00
Gaël Poupard
91d3da1f3d
fix(navbar): ensure .navbar-collapse behaves as intended (#33022) 2021-02-09 20:54:37 +02:00
Rohit Sharma
273db7c205 Remove the default left styling in favor of Popper 2021-02-09 14:34:27 +02:00
Mark Otto
d56992b6d2 Mention dropdown static change in Migration guide
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
2021-02-09 14:34:27 +02:00
Mark Otto
8f1c882545 Remove .dropdown-menu[style] reset and adjust .dropdown-menu-* modifiers
- Removes the &[style] selector that was used for resetting Popper styles
- Separate Popper-based alignment from static alignment with `data-bs-popover` attribute that separates the --bs-position and custom right/left properties

Co-Authored-By: Rohit Sharma <rohit2sharma95@gmail.com>
2021-02-09 14:34:27 +02:00
dependabot[bot]
a2b56de707
Bump linkinator from 2.13.3 to 2.13.4 (#33019)
Bumps [linkinator](https://github.com/JustinBeckwith/linkinator) from 2.13.3 to 2.13.4.
- [Release notes](https://github.com/JustinBeckwith/linkinator/releases)
- [Commits](https://github.com/JustinBeckwith/linkinator/compare/v2.13.3...v2.13.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-09 09:22:31 +02:00
XhmikosR
28aba43ae0
vnu-jar.js: quote vnu path (#33016)
Should work now with folders with spaces
2021-02-09 08:01:44 +02:00
Rohit Sharma
0eaa6c05cf
Remove custom fallbackPlacements from dropdown (#32843) 2021-02-09 07:55:17 +02:00
Philip Kiely
96b86c1f58
Docs on enforcing HTTPS and avoiding mixed content (#33017)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-09 07:54:16 +02:00
Patrick H. Lauke
96be06e32b
Dynamic tabs: use buttons rather than links (#32630)
* Dynamic tabs: use buttons rather than links

- change docs
- add mention that tabs should be <button> elements
- tweak styles to neutralise border and background

* Update js unit and visual test accordingly

- replace links with buttons
- make one specific test that uses links instead of buttons, as we still want to support it despite it being non-semantically appropriate
- Leaving a couple of tests for now. The test for removed tabs should be redone so that tabs are removed programmatically (as the approach of having that close button inside the link is invalid and broken markup). The test for dropdowns should be removed together we actually ripping out the handling for dropdowns in the tab.js code (arguably a breaking change, though we discouraged this for a few versions and effectively "deprecated" it)

* Add isolation:isolate to prevent focus being overlapped

https://github.com/twbs/bootstrap/pull/32630#issuecomment-756015766
2021-02-09 07:23:45 +02:00
XhmikosR
c93d754d35
CI: remove the cache fallback and shorten cache key (#33012) 2021-02-08 21:41:10 +02:00
XhmikosR
6d34d93d69
Update devDependencies (#33011)
* @babel/cli         ^7.12.10  →  ^7.12.13
* @babel/core        ^7.12.10  →  ^7.12.13
* @babel/preset-env  ^7.12.11  →  ^7.12.13
* karma                ^6.0.4  →    ^6.1.0
* linkinator           2.11.2  →   ^2.13.3
* postcss              ^8.2.4  →    ^8.2.5
* rollup              ^2.38.4  →   ^2.38.5
* rtlcss               ^3.1.1  →    ^3.1.2
* vnu-jar             20.6.30  →    21.2.5
2021-02-08 21:05:24 +02:00
Rohit Sharma
b6cae91893
Add a note to change the case type of option name (#32995) 2021-02-08 16:55:47 +02:00
Kyle Tsang
22d8e34b3e
Fix boundary config description for dropdown and popover (#32979) 2021-02-04 07:26:32 +02:00
Kyle Tsang
d63a922436
Fix Popper preventOverflow boundary config (#32845)
Currently, the boundary config is being assigned to the wrong var (`rootBoundary`) in the popper config.  It should be assigned to the `boundary` var in popper's config.

Ref: https://popper.js.org/docs/v2/utils/detect-overflow/#boundary
2021-02-04 06:55:25 +02:00
Siju Samson
b376a3d80d
Fix dropdown keys to open menu (#32750)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-03 22:03:21 +02:00
Florian Vick
2a9d72133d
Prevent getSelector from returning URLs as selector (#32586)
* added checks to getSelector in util to prevent returning hrefs that are invalid selectors

* restored compatibility for the class selector and added test cases for keeping urls from being returned as a selector

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-03 21:58:54 +02:00
Rohit Sharma
3770b7b9e3
Dropdown — Emit events on the .dropdown-toggle button (#32625)
* Emit events on the dropdown button

Emit the events on `.dropdown-toggle` button and then bubble up

* Add migration note for events

* Update the docs for events

* Add unit test to check the event bubbling

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-03 21:51:19 +02:00
Gaël Poupard
02d103be91
fix(accordion): ensure .accordion-button stays left-aligned (#32951)
Fixes #32938

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-03 21:44:48 +02:00
Gaël Poupard
e4b249d02b
fix(navbar): hardcoded custom property (#32930) 2021-02-03 21:42:24 +02:00
Stanisław Gregor
203b3e218c
Fix default value for $enable-deprecation-messages (#32940)
* Update the default value for $enable-deprecation-messages

As seen in the https://github.com/twbs/bootstrap/blob/main/scss/_variables.scss,
the $enable-deprecation-messages variable is set to `true` by default.

* Update site/content/docs/5.0/customize/options.md

Co-authored-by: Gaël Poupard <ffoodd@users.noreply.github.com>

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Gaël Poupard <ffoodd@users.noreply.github.com>
2021-02-03 21:40:05 +02:00
Rohit Sharma
217d84d6b2
Remove the initial margin from dropdown/popover in favor of Popper (#32524)
* Remove the margin from dropdown in favor of Popper

- Set the default margin to 0 for dropdowns (To remove the Popper's  warning)
- Set the required offset in dropdown's defaults

* Remove the margin from the popover component

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-03 21:37:25 +02:00
XhmikosR
a1bb65ef49 Tweak scss-docs shortcode
Should work now with indented start/end capture statements
2021-02-03 07:15:49 +02:00
Mark Otto
88be1ce502 Update docs for color and bg utilities
- Split colors from background utilities with new docs page
- Add Sass docs for both pages
2021-02-03 07:15:49 +02:00
dependabot[bot]
14cfb7af93
Bump rtlcss from 3.0.0 to 3.1.1 (#32972)
Bumps [rtlcss](https://github.com/MohammadYounes/rtlcss) from 3.0.0 to 3.1.1.
- [Release notes](https://github.com/MohammadYounes/rtlcss/releases)
- [Changelog](https://github.com/MohammadYounes/rtlcss/blob/master/CHANGELOG.md)
- [Commits](https://github.com/MohammadYounes/rtlcss/compare/3.0.0...3.1.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-02 21:00:15 +02:00
dependabot[bot]
1383f542c2
Bump @rollup/plugin-commonjs from 17.0.0 to 17.1.0 (#32963) 2021-02-02 12:09:14 +00:00
dependabot[bot]
eff792843a
Bump sass from 1.32.5 to 1.32.6 (#32965)
Bumps [sass](https://github.com/sass/dart-sass) from 1.32.5 to 1.32.6.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/dart-sass/compare/1.32.5...1.32.6)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-02 14:01:40 +02:00
dependabot[bot]
863dd32e0e
Bump @rollup/plugin-node-resolve from 11.1.0 to 11.1.1 (#32962)
Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins) from 11.1.0 to 11.1.1.
- [Release notes](https://github.com/rollup/plugins/releases)
- [Commits](https://github.com/rollup/plugins/compare/commonjs-v11.1.0...node-resolve-v11.1.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-02 13:59:57 +02:00
dependabot[bot]
7c8415e5c5
Bump eslint from 7.18.0 to 7.19.0 (#32964)
Bumps [eslint](https://github.com/eslint/eslint) from 7.18.0 to 7.19.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.18.0...v7.19.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-02 13:56:19 +02:00
dependabot[bot]
9cdf322038
Bump rollup from 2.38.0 to 2.38.4 (#32961) 2021-02-02 11:52:20 +00:00
dependabot[bot]
586b43e2c2
Bump autoprefixer from 10.2.3 to 10.2.4 (#32966)
Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 10.2.3 to 10.2.4.
- [Release notes](https://github.com/postcss/autoprefixer/releases)
- [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/autoprefixer/compare/10.2.3...10.2.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-02 13:42:32 +02:00
dependabot[bot]
d0db6b7b8e
Bump karma from 6.0.2 to 6.0.4 (#32959)
Bumps [karma](https://github.com/karma-runner/karma) from 6.0.2 to 6.0.4.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.0.2...v6.0.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-02 13:33:16 +02:00
dependabot[bot]
4c1acccc22
Bump @rollup/plugin-babel from 5.2.2 to 5.2.3 (#32958)
Bumps [@rollup/plugin-babel](https://github.com/rollup/plugins) from 5.2.2 to 5.2.3.
- [Release notes](https://github.com/rollup/plugins/releases)
- [Commits](https://github.com/rollup/plugins/compare/babel-v5.2.2...babel-v5.2.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-02 13:21:52 +02:00
Quy
ed0fc83216
_carousel.scss: Fix typo in comment (#32950) 2021-02-01 15:22:24 +02:00
Rohit Sharma
e79c8f3489 Just find the active indicator 2021-01-28 23:32:24 +02:00
Patrick H. Lauke
a882614c45 Make carousel indicators actual buttons 2021-01-28 23:32:24 +02:00
XhmikosR
1fd34a1a2c
CI: switch to the coverallsapp/github-action tag (#32919)
Unfortunately, they don't offer a `v1` tag
2021-01-28 23:31:33 +02:00
XhmikosR
a838571c50
change-version: remove vendor, add resources (#32917) 2021-01-28 23:30:10 +02:00
Rohit Sharma
e036e604de Update docs for offset option 2021-01-28 12:23:33 +02:00