rooty/Bootstrap
0
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2024-11-29 11:24:18 +01:00
Code Issues Actions Packages Releases Activity
21,300 Commits 108 Branches 89 Tags 547 MiB
e5d8256e42
Commit Graph

48 Commits

Author SHA1 Message Date
XhmikosR
f8f9dc3b5c tests: remove extra spaces, unneeded arrays and add missing newlines 2021-12-01 14:30:49 +02:00
XhmikosR
eb54e1a1ce tests: tweak Jasmine's matchers usage 
Use:

* toBeNull
* toEqual
* toBeTrue
* toBeFalse
* toHaveSize
* toHaveClass
 2021-12-01 14:30:49 +02:00
GeoSot
569bca54d2 Add test for modal-content 2021-11-25 19:23:49 +02:00
GeoSot
b991a6b851
tests: try to fix a few random failures (#35184) 
* Change `Swipe` dispose spy on EventHandler
* Modal hide spy on backdrop hide
 2021-10-13 17:45:39 +03:00
XhmikosR
a260967a55
tests: minor cleanup (#35138) 
* tests: minor cleanup

* tests: use the util noop function
 2021-10-08 12:32:11 +03:00
XhmikosR
666fe596bf Enable unicorn/no-array-for-each rule 2021-10-05 19:52:11 +03:00
XhmikosR
c5d03d93fc
Rename e to event (#34979) 2021-09-15 14:27:46 +03:00
GeoSot
1e5e655670
Fix modal when is triggered by bs-toggle, to hide other open instances (#34701) 2021-08-10 17:55:34 +03:00
XhmikosR
6d707f4801
Enable a few eslint-config-xo rules (#34620) 
* unicorn/prefer-dom-node-append
* unicorn/prefer-dom-node-remove
 2021-07-30 00:23:00 +02:00
Ryan Berliner
7646f6bd33
Add shift-tab keyboard support for dialogs (modal & Offcanvas components) (#33865) 
* consolidate dialog focus trap logic

* add shift-tab support to focustrap

* remove redundant null check of trap element

Co-authored-by: GeoSot <geo.sotis@gmail.com>

* remove area support forom focusableChildren

* fix no expectations warning in focustrap tests

Co-authored-by: GeoSot <geo.sotis@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
 2021-07-27 08:01:04 +03:00
GeoSot
dfafb9a60c
modal: change data-dismiss so that it can be outside of a modal using bs-target (#33403) 
* change data-dismiss, so can be outside modal, using a bs-target

* Update site/content/docs/5.0/components/modal.md

Co-authored-by: Gaël Poupard <ffoodd@users.noreply.github.com>
 2021-07-19 16:56:05 +03:00
GeoSot
cb47b8c964
Refactor scrollbar.js to be used as a Class (#33947) 2021-06-06 09:26:36 +03:00
GeoSot
c98657b830
Add getOrCreateInstance method in base-component (#33276) 
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
 2021-06-03 18:53:27 +03:00
alpadev
4a5029ea29
Fix handling of transitionend events dispatched by nested elements(#33845) 
Fix handling of transitionend events dispatched by nested elements
Properly handle events from nested elements

Change `emulateTransitionEnd` to `executeAfterTransition` &&
 2021-06-03 14:44:16 +03:00
alpadev
b513a19003
Fix prevented show event disables modals with fade class from being displayed again (#34085) 
Fix modal, in case is faded, a prevented show event can cause show method to not  be executed again.
 2021-05-24 18:52:36 +03:00
GeoSot
79c3bf47bc
Add Tests on scrollbar.js & better handling if a style property doesn't exists (#33948) 
* scrollbar.js:
add some tests
transfer test from modal.spec. to scrollbar.spec
proper handling if style property doesn't exist
 2021-05-20 16:29:04 +03:00
GeoSot
2757fbe28e
Reset inside a Dialog does not work if data-dismiss="modal" is set (#33928) 2021-05-18 09:26:22 +03:00
Ben Lertlumprasertkul
052def4568
Remove potential false positive assertions (#33288) 
* Remove potential false positive assertions

querySelector() returns null but

expect(document.querySelector('...')).toBeDefined()

tests that the value is not undefined

* Migrated assertions from .toBeDefined() to .not.toBeNull() for .getInstance() calls in tests

* Migrate offcanvas assertions from .toBeDefined() to .not.toBeNull() for .getInstance() call

* convert more cases to not.toBeNull assertions

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
 2021-05-11 08:45:57 +03:00
GeoSot
d381820d16
Scrollbar: respect the initial body overflow value (#33706) 
* add method to handle overflow on body element & tests
* replace duplicated code on modal/offcanvas tests
 2021-04-25 06:50:16 +03:00
GeoSot
6ea4dab142
modal.js: fix test for scrollbar (#33666) 
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
 2021-04-18 20:55:22 -07:00
GeoSot
0d440b0e14 Js: fix some tests 2021-04-14 13:25:44 -07:00
GeoSot
7b7f4a5ced
Decouple Modal's scrollbar functionality (#33245) 2021-04-11 09:37:59 +03:00
Rohit Sharma
9bca1b5a8b
Remove unnecessary data-bs-backdrop="static" (#33578) 
Since the value for the `backdrop` option is available in the configuration object.
 2021-04-08 08:20:21 +03:00
GeoSot
752b001b0a Simplify Modal config 2021-04-06 18:43:43 +03:00
Muhammadamin
056216a3bd
modal: don't add margin & padding when sticky is not full width (#30621) 
* modal: don't add margin & padding when sticky is not full width

* Check if element is shorter than window

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
 2021-02-23 14:52:09 +02:00
Rohit Sharma
dc5e3328c1
Allow constructors to accept a CSS selector (#32245) 
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <otto@github.com>
 2021-02-22 09:01:04 +02:00
GeoSot
3602828a90
Add tests for DATA_KEY (#33090) 
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
 2021-02-16 08:58:08 +02:00
Rohit Sharma
c9cd741aff
Throw a TypeError instead of the generic Error (#32585) 
* Change from Error to TypeError

* Convert the `NAME` to upper case to make the consistency in the error message

* Update the remaining tests to be stricter

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
 2021-01-13 22:13:30 +02:00
Rohit Sharma
e34481b6eb
Fix toggling modal when clicking on data-bs-toggle="modal" (#32691) 
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
 2021-01-13 21:59:47 +02:00
XhmikosR
51a208f119 Switch to Jasmine's toBeInstanceOf matcher 2020-11-29 20:58:26 +02:00
Johann-S
9f6b342dc7 create a base component 2020-11-29 20:58:26 +02:00
Rohit Sharma
358c36d4b5
Add missing tags in unit tests (#32221) 2020-11-20 20:10:15 +02:00
Rohit Sharma
0839cbf04d
Don't hide modal when keyboard is set to false in modal's configuration (#32179) 
* Don't hide modal when config.keyboard is false

* Update unit test

- Modal should not be closed when pressing esc key if keyboard = false
  and backdrop is 'static'

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
 2020-11-20 15:36:24 +02:00
XhmikosR
2e758f64cf Switch to Number properties 2020-11-14 15:54:50 +02:00
Rohit Sharma
418f17ee2b Add bs in data attributes 
- Add `bs` in data APIs everywhere
- Update unit tests
 2020-11-14 07:09:15 +02:00
XhmikosR
c9f8fa45fb
tests: tweak Jasmine usage (#32046) 
* jasmine/expect-matcher
* jasmine/prefer-jasmine-matcher

Found with `eslint-plugin-jasmine`
 2020-11-02 16:13:24 +02:00
Shohei Yoshida
fb4efb49ea
Prevent overflowing static backdrop modal animation (#30326) 
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
 2020-06-25 11:35:53 +03:00
Rohit Sharma
5faf41eb48
Add role="dialog" in modals via JavaScript (#30936) 2020-06-04 10:35:09 +03:00
Dominik Kremer
d59de33fc0 Add a test about the scrollbar issue on non-integer width 2020-05-12 07:51:09 +03:00
XhmikosR
94109cabf4
Add missing closing div tags (#30775) 
Missed those in 967e607
 2020-05-11 16:54:56 +03:00
XhmikosR
967e6071ba
tests: streamline HTML end tags (#30648) 2020-05-06 09:20:08 +03:00
Tanguy Krotoff
dcd99aa7d1 Replace event.which with event.key and event.button 2020-04-17 18:22:15 +03:00
ysds
dfa017adc3 Always modal scroll top to 0 2020-04-01 10:05:43 +03:00
Johann-S
26d86fce2a
fix: remove make array util function (#30430) 2020-03-25 16:35:02 +02:00
XhmikosR
018a94c9c1 Remove Internet Explorer leftovers 2020-03-18 20:59:27 +02:00
Giovanni Mendoza
954a0b1e6a Close modal with keyboard=true & backdrop=static (#29986) 
* Close modal with keyboard=true & backdrop=static
 2020-01-10 11:06:12 +02:00
Higor Araújo dos Anjos
46912797b2 Added animation when modal backdrop is static (#29516) 2019-10-25 21:12:09 +03:00
XhmikosR
577bf8b14d
Rename "js/tests/units" to "js/tests/unit". (#29503) 2019-10-09 01:27:43 +03:00