XhmikosR
eb54e1a1ce
tests: tweak Jasmine's matchers usage
...
Use:
* toBeNull
* toEqual
* toBeTrue
* toBeFalse
* toHaveSize
* toHaveClass
2021-12-01 14:30:49 +02:00
XhmikosR
a260967a55
tests: minor cleanup ( #35138 )
...
* tests: minor cleanup
* tests: use the util noop function
2021-10-08 12:32:11 +03:00
GeoSot
4bfd8a2cbc
Use a streamlined way to trigger component dismiss ( #34170 )
...
* use a streamlined way to trigger component dismiss
* add documentation
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-28 17:39:32 +03:00
GeoSot
c98657b830
Add getOrCreateInstance
method in base-component ( #33276 )
...
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-06-03 18:53:27 +03:00
Ben Lertlumprasertkul
052def4568
Remove potential false positive assertions ( #33288 )
...
* Remove potential false positive assertions
querySelector() returns null but
expect(document.querySelector('...')).toBeDefined()
tests that the value is not undefined
* Migrated assertions from .toBeDefined() to .not.toBeNull() for .getInstance() calls in tests
* Migrate offcanvas assertions from .toBeDefined() to .not.toBeNull() for .getInstance() call
* convert more cases to not.toBeNull assertions
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-05-11 08:45:57 +03:00
Ryan Berliner
9c3ab6557e
Prevent toast autohiding if focusing or hovering ( #33221 )
2021-05-11 08:37:57 +03:00
Rohit Sharma
dc5e3328c1
Allow constructors to accept a CSS selector ( #32245 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <otto@github.com>
2021-02-22 09:01:04 +02:00
GeoSot
3602828a90
Add tests for DATA_KEY
( #33090 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-16 08:58:08 +02:00
Kyle Tsang
02dbd87ffa
Fix event handler removal in dropdown/carousel dispose ( #33000 )
...
* Fix event handler removal in carousel dispose
* Fix event handler removal in dropdown dispose
* Test event handlers in scrollspy dispose
* Test event handlers in toast dispose
* Test event handlers in tooltip dispose
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
2021-02-12 07:51:34 +02:00
Rohit Sharma
c9cd741aff
Throw a TypeError
instead of the generic Error
( #32585 )
...
* Change from Error to TypeError
* Convert the `NAME` to upper case to make the consistency in the error message
* Update the remaining tests to be stricter
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-13 22:13:30 +02:00
Gaël Poupard
9488978fb5
feat(RTL): implement RTL
...
Using RTLCSS directives, renaming things to use logical names and following best practices.
2020-12-04 07:52:03 +02:00
XhmikosR
51a208f119
Switch to Jasmine's toBeInstanceOf
matcher
2020-11-29 20:58:26 +02:00
Johann-S
9f6b342dc7
create a base component
2020-11-29 20:58:26 +02:00
XhmikosR
4f8b243ac1
Fix .close
instances ( #32152 )
2020-11-14 08:16:30 +02:00
Rohit Sharma
418f17ee2b
Add bs
in data attributes
...
- Add `bs` in data APIs everywhere
- Update unit tests
2020-11-14 07:09:15 +02:00
XhmikosR
b63066d630
toast.spec.js: fix typo ( #32026 )
2020-10-31 09:25:33 +02:00
Rohit Sharma
f6348f6c89
Clear timeout before showing the toast ( #31155 )
...
* clear timeout before showing the toast
* Add unit test
* Remove the check for timeout
* Check for clearTimeout to have been called
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-07-11 11:51:04 -07:00
XhmikosR
577bf8b14d
Rename "js/tests/units" to "js/tests/unit". ( #29503 )
2019-10-09 01:27:43 +03:00