0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-10 22:24:19 +01:00
Commit Graph

1480 Commits

Author SHA1 Message Date
lbryant
8b15b5a262 _removeTetherClasses is no longer referenced 2015-08-20 01:22:16 -04:00
lbryant
926fb11158 use Tether addTargetClasses: false option instead of manually removing them 2015-08-20 01:03:29 -04:00
Jacob Thornton
03e732708c rewrite tab with new active shit 2015-08-18 22:03:34 -07:00
Jacob Thornton
4e45e2363c Merge branch 'v4' of github.com:twbs/derpstrap into v4 2015-08-18 21:23:53 -07:00
Jacob Thornton
fd65b9f32e some minor alert shit 2015-08-18 20:33:57 -07:00
Mark Otto
1c19ded8c1 Merge branch 'v4' of https://github.com/twbs/derpstrap into v4 2015-08-18 20:25:48 -07:00
Jacob Thornton
8cfde5ef29 fix modal visual example for js 2015-08-18 19:50:32 -07:00
Jacob Thornton
efae761c39 fix dropdown js visual example 2015-08-18 19:42:27 -07:00
Jacob Thornton
18ff57a183 js tests passing + eslint 2015-08-18 19:22:46 -07:00
Mark Otto
15b7ce59df grunt 2015-08-18 18:45:12 -07:00
Jacob Thornton
f1827e5f9c add polyfil for bind for tether.js 2015-08-18 17:06:17 -07:00
Jacob Thornton
19e43b62ed use proxy not bind in alert 2015-08-18 17:01:56 -07:00
Jacob Thornton
05c7a37507 fix dropdown test 2015-08-15 12:17:13 -07:00
Jacob Thornton
c830956d17 change modal.js to use is-fixed classes to target padding-right 2015-08-15 12:10:24 -07:00
Jacob Thornton
11abb0f7e9 fix modal 2015-08-12 21:12:03 -07:00
Jacob Thornton
23d05f1585 get the js working for docs 2015-08-12 19:59:55 -07:00
Mark Otto
1ddc3f5e21 Merge branch 'master' into v4m 2015-08-04 22:29:45 -07:00
Johann-S
ef1ce9ac0b Fix triggering of {shown,hidden}.bs.dropdown events so relatedTarget gets set properly
Fixes #16828
Closes #16865
2015-07-27 00:58:51 -07:00
Melinda Sarnicki Bernardo
cebea5b6f6 Removes unnecessary period at end of comment 2015-07-02 19:30:11 -07:00
Mark Otto
169d2a4a78 Merge branch 'master' into v4 2015-06-18 23:56:43 -07:00
Mark Otto
83bfff7f07 bump version 2015-06-16 09:10:22 -07:00
Patrick H. Lauke
5fd7bc1554 generalize dropdowns / drop role="menu"
as role="menu" is a very specific (and strict) ARIA pattern for
desktop-like application menus, and our dropdowns are often used
as pure navigation dropdowns, this change abandons ARIA menus for
a more open-ended and light-weight approach
(see http://heydonworks.com/practical_aria_examples/#submenus and
http://www.w3.org/WAI/tutorials/menus/flyout/#improve-screen-reader-support-using-wai-aria)
note that in dropdown.js, switched to now target ``.dropdown-menu``
instead of ``role["menu"]`` - this also prevents bootstrap scripts
from "bleeding" into non-bootstrap components on the same page.
also removed the ``role=["listbox"]`` part, which appears to be
vestigial/unused (only place in bootstrap that uses that
role are carousels, and their key handling is done separately)
2015-06-02 11:03:21 +01:00
XhmikosR
315907c97c Use https when possible. 2015-05-17 12:43:20 +03:00
fat
6b2b0ed32f al tests passing, dist rebuilt, w/typechecker 2015-05-13 14:52:46 -07:00
fat
eaab1def7a add simple type checker implementation 2015-05-13 14:46:50 -07:00
fat
c2ced2292a fix up tests 2015-05-13 13:46:08 -07:00
fat
b0d142334f fix #15301 2015-05-13 13:43:56 -07:00
fat
7ef0e52fd0 add "focus" option for turning off modal focusing #16050 2015-05-13 13:22:26 -07:00
fat
da495ee24c address https://github.com/twbs/bootstrap/pull/16135 2015-05-13 13:15:11 -07:00
fat
f8b2569ec8 implement global dispose method 2015-05-13 12:48:34 -07:00
fat
6b251582d6 update attachment -> placement 2015-05-12 16:54:21 -07:00
fat
ab1578465a grunt test-js, grunt dist-js now working 2015-05-12 16:52:54 -07:00
fat
a58febf71a popover passing as well 2015-05-12 14:35:00 -07:00
fat
3452e8dc83 rewritten tooltip + tether integration and death to our positioner jank 2015-05-11 23:32:37 -07:00
fat
8eee78ca15 tab es6 2015-05-11 12:29:06 -07:00
fat
2d91494d96 scrollspy es6 2015-05-11 12:05:35 -07:00
fat
ca9c850ebb add getters for Version and Default where applicable
add modal my gawd
2015-05-10 19:45:38 -07:00
fat
bbb97a8660 add dropdown 2015-05-10 13:47:11 -07:00
fat
8bab38bb71 add collapse 2015-05-09 23:04:58 -07:00
XhmikosR
1eba173c9e Update jQuery to v1.11.3. 2015-05-10 01:22:23 +03:00
fat
1b183e2ff7 carousel -> es6 2015-05-07 22:26:40 -07:00
fat
6605051882 button -> es6 2015-05-07 17:14:38 -07:00
fat
c3a79b1a8c change the export pattern to protect against leaking globals 2015-05-07 16:34:28 -07:00
fat
0724bd91ff es6 alert :| 2015-05-07 12:57:31 -07:00
fat
d1fbe200f4 remove closureness from plugins 2015-05-06 13:34:14 -07:00
XhmikosR
a2f81ceb57 phantom.js: switch to unicode characters that work on Windows too. 2015-05-05 06:58:54 +03:00
XhmikosR
49c4556354 Comply to the new JSCS rules. 2015-05-05 06:50:18 +03:00
XhmikosR
93785be2c6 Update JSCS rules. 2015-05-05 06:50:18 +03:00
Chris Rebert
aa2c5b5672 Merge pull request #16014 from redbmk/issue-16008
Multiple tooltip triggers don't play well together
2015-05-04 15:07:17 -07:00
Patrick H. Lauke
a254782ca4 Merge pull request #16404 from patrickhlauke/radio-checkbox-kbd-toggle-fix
Fix radio and checkbox keyboard handling in .btn-group
2015-05-03 17:05:12 +01:00
Carlo Stearns
0689117f13 Fix issue where affixed element has incorrect positioning
when used with a sticky footer layout.
Adds visual test for affix with sticky footer.

Closes #15694.
Refs #15032.
2015-05-02 17:59:31 -07:00
Patrick H. Lauke
0c1daaf2ce Remove broken/vestigial unit test
Overall logic for this test appears broken, possibly relating to an
older version of Bootstrap that did not require explicit
`data-toggle="button"` on single toggle buttons?
2015-05-01 12:58:10 +01:00
Patrick H. Lauke
f9cd88e09f Fix radio and checkbox keyboard handling
Fix for problem that emerged from #16226 (`.active` class not actually
being applied) and expansion of the script to also correctly handle
keyboard interaction with checkboxes in `data-toggle="button"` groups
2015-05-01 12:19:19 +01:00
XhmikosR
3e7ca3bbc8 Minor lint tweaks. 2015-04-28 11:03:37 +03:00
Braden M. Kelley
4b269037cb Multiple tooltip triggers don't play well together
Fixes issue #16008
2015-04-27 23:03:56 -07:00
F A T
aa479892d5 Merge pull request #16152 from jarthod/tooltip-placement-viewport-fix
Tooltip/popover: Fix auto placement to use viewport
2015-04-27 11:28:54 -07:00
Chris Rebert
cdb37dce3a Set box-sizing: border-box on .container-viewport in #16142 testcase
Otherwise, the test doesn't properly fail when the fix is reverted.
2015-04-27 01:23:39 -07:00
Adrien
37a10d37c1 Compare tooltip right offset to viewport right offset (and not width)
Closes #16142 by merging it.
2015-04-27 01:13:16 -07:00
Chris Rebert
fc372952e2 Throw error when tooltip/popover template has multiple top-level elements
Closes #16219.
2015-04-25 13:16:53 -07:00
Chris Rebert
0d77644fc4 throw error when trying to show tooltip on :hidden element 2015-04-23 17:14:45 -07:00
Adrien Siami
e949505b89 Allow viewport option to be a function
Closes #16151 by merging a rebased version of it that adds docs and 1 more assertion.
2015-04-21 22:20:15 -07:00
Chris Rebert
c6b62f0cd9 Merge pull request #16147 from Johann-S/event_inserted
Fixes #16124.
2015-04-21 21:40:14 -07:00
Niels Steenbeek
7429fc7ff9 Tooltip: Destroy $tip, $arrow, $viewport to avoid memory leak
Closes #16039.
2015-04-20 23:29:31 -07:00
Patrick H. Lauke
8549722846 Merge pull request #16226 from patrickhlauke/radio-toggle-kbd-fix
Fix radio button toggle behavior for keyboard users
2015-04-17 18:19:11 +02:00
Patrick H. Lauke
66d71136e6 Fix existing radio button unit test 2015-04-11 19:24:21 +02:00
Patrick H. Lauke
1b9baa0d98 Don't preventDefault radio buttons
as this breaks keyboard navigation for radio button toggles (see
https://github.com/twbs/bootstrap/issues/16223)
2015-04-11 19:21:55 +02:00
Chris Rebert
b8935a5d0c Use .dropdown-menu instead of ARIA roles for dropdown keydown event handler; fixes #16090 2015-04-08 19:20:15 -07:00
Johann-S
3d71eae301 Add event after template inserted 2015-04-08 13:10:53 +02:00
Adrien Jarthon
5921724d9c fixed IE incompatible CSS 2015-03-29 19:16:59 +02:00
Adrien Jarthon
df96c3e615 Added non-regression test & fixed existing one 2015-03-29 14:59:21 +02:00
Mark Otto
58082cd83e Merge branch 'master' into v4
Conflicts:
	.gitignore
	Gruntfile.js
	_config.yml
	dist/css/bootstrap-theme.css
	dist/css/bootstrap-theme.min.css
	dist/css/bootstrap.css
	dist/css/bootstrap.css.map
	dist/css/bootstrap.min.css
	dist/js/bootstrap.js
	dist/js/bootstrap.min.js
	docs/_includes/components/navbar.html
	docs/_includes/components/progress-bars.html
	docs/_includes/css/grid.html
	docs/_includes/css/overview.html
	docs/_includes/customizer-variables.html
	docs/_includes/getting-started/accessibility.html
	docs/_includes/getting-started/browser-device-support.html
	docs/_includes/getting-started/community.html
	docs/_includes/getting-started/disabling-responsiveness.html
	docs/_includes/getting-started/download.html
	docs/_includes/getting-started/examples.html
	docs/_includes/getting-started/license.html
	docs/_includes/getting-started/third-party-support.html
	docs/_includes/js/alerts.html
	docs/_includes/js/buttons.html
	docs/_includes/js/carousel.html
	docs/_includes/js/collapse.html
	docs/_includes/js/dropdowns.html
	docs/_includes/js/modal.html
	docs/_includes/js/popovers.html
	docs/_includes/js/scrollspy.html
	docs/_includes/js/tabs.html
	docs/_includes/js/tooltips.html
	docs/_includes/js/transitions.html
	docs/_includes/nav/javascript.html
	docs/_includes/nav/main.html
	docs/about.html
	docs/assets/css/docs.min.css
	docs/assets/css/src/docs.css
	docs/assets/js/customize.min.js
	docs/assets/js/raw-files.min.js
	docs/assets/js/src/customizer.js
	docs/dist/css/bootstrap-theme.css
	docs/dist/css/bootstrap-theme.min.css
	docs/dist/css/bootstrap.css
	docs/dist/css/bootstrap.css.map
	docs/dist/css/bootstrap.min.css
	docs/dist/js/bootstrap.js
	docs/dist/js/bootstrap.min.js
	docs/migration.html
	js/affix.js
	js/alert.js
	js/button.js
	js/carousel.js
	js/collapse.js
	js/dropdown.js
	js/modal.js
	js/popover.js
	js/scrollspy.js
	js/tab.js
	js/tests/unit/affix.js
	js/tests/unit/button.js
	js/tests/unit/carousel.js
	js/tests/unit/modal.js
	js/tests/unit/tooltip.js
	js/tests/visual/modal.html
	js/tooltip.js
	less/component-animations.less
	less/jumbotron.less
	less/mixins/background-variant.less
	less/mixins/buttons.less
	less/mixins/responsive-visibility.less
	less/mixins/text-emphasis.less
	less/navbar.less
	less/navs.less
	less/scaffolding.less
	less/tooltip.less
	less/utilities.less
	less/variables.less
	package.json
	scss/_buttons.scss
	scss/_forms.scss
	scss/_modal.scss
2015-03-29 00:08:54 -07:00
Heinrich Fenkart
da63ff2e95 JSCS: Add "disallowSpacesInFunctionDeclaration"
Valid:

    function a() {}

Invalid:

    function a () {}
2015-03-26 18:28:17 +01:00
Chris Rebert
6c5e7dfce1 rm redundant aria-hidden usage from Modals; fixes #16020 2015-03-25 18:06:47 -07:00
Adrien Jarthon
0e8e5222ff Tooltip/popover: Fix auto placement to use viewport
Currently, auto placement is using the container dimensions (if provided) or the element's parent to determine where to open the tooltip:
```javascript
var $container   = this.options.container ? $(this.options.container) : this.$element.parent()
var containerDim = this.getPosition($container)
```
This is quite broken in fact, because the parent element could be just a small div outside the element for example, leading in a totally random placement (placing the tooltip on top even if there's no room). And the container can also be outside of the viewport.

This fix simply uses the viewport instead, that's the purpose of the viewport actually, to position the tooltip.
So the auto placement should use it to find where there's more room.
By default this is body, which is good.
2015-03-25 18:05:58 +01:00
Chris Rebert
d37bc2ae65 Merge pull request #15987 from twbs/fix-15972
add role="button" to a[data-toggle="collapse"]
2015-03-24 08:57:56 -07:00
Emmanuel Bourgerie
fa9d28b634 Fix #16072: Clicking into input field within dropdown no longer closes the dropdown
Closes #16073 by merging it
2015-03-21 16:00:15 -07:00
Chris Rebert
9aad9a4164 Merge pull request #16024 from twbs/unnecessary-parsing
avoid unnecessary HTML string building+parsing
2015-03-18 22:28:07 -07:00
Chris Rebert
4d652035dc v3.3.2 => v3.3.4 2015-03-16 08:39:31 -07:00
Maxim Andrukhovych
83371735fc Fixed proper navigation element selection on backward scrolling (from the bottom to the top) 2015-03-10 20:04:15 +00:00
Chris Rebert
1383b88328 Merge pull request #16012 from twbs/refs-12761
Disable jQuery event aliases when running test suite
2015-03-09 17:47:51 -07:00
Chris Rebert
a14665e73e avoid unnecessary HTML string building+parsing 2015-03-09 06:47:34 -07:00
Chris Rebert
a5243ad3d0 Affix: $('body') => $(document.body) 2015-03-09 06:43:41 -07:00
Chris Rebert
725c6848c3 Disable jQuery event aliases when running test suite
To ensure that we don't accidentally use any of the aliases.
This should prevent any future regressions from #12761.
Also updates the test suite since it now can't use these aliases either.
2015-03-09 01:05:43 -07:00
Chris Rebert
21d56378e1 Merge pull request #16011 from twbs/fix-15315
.collapse('hide') on hidden uninit-ed collapsible no longer shows it
2015-03-09 01:03:27 -07:00
Chris Rebert
a134491fe5 add togglable scrollbar-inducing content to Modal visual test 2015-03-07 06:40:57 -08:00
Chris Rebert
6ddb8c2dd7 add static navbar to Modal visual test 2015-03-07 06:39:46 -08:00
Chris Rebert
64ca888cbc Merge pull request #15999 from twbs/kkirsche-includeTestsReadme
Document JS test suite basics
2015-03-06 23:28:30 -08:00
Kevin Kirsche
ba2f7e92d0 [Fixes #15951] Document JS test suite basics
X-Ref: #15953
Closes #15952 by merging a tweaked version of it.
[skip sauce]
[skip validator]
2015-03-06 23:27:00 -08:00
Chris Rebert
5c8d56d515 Collapse unit test: rm check that no-op hide adds style="height: 0px"
Appears to be unnecessary and is broken by #16011,
which is otherwise quite sane.
2015-03-06 18:10:53 -08:00
Chris Rebert
872e56fcf2 .collapse('hide') on hidden uninit-ed collapsible no longer shows it; fixes #15315
Thanks to @peterblazejewicz & @Nikita240
Adds unit tests based on #14417
X-Ref: #14282
Closes #15807
2015-03-06 06:58:48 -08:00
Chris Rebert
27bbc7dbe9 Hiding an uninitialized tooltip/popover no longer initializes it; fixes #15874 2015-03-03 22:22:13 -08:00
Chris Rebert
cc39f5c52d add role="button" to a[data-toggle="collapse"]; fixes #15972 2015-03-03 13:18:36 -08:00
Chris Rebert
168297c779 rm semicolon for sake of fat's eccentric tastes
Erratum from #15496
2015-03-03 13:06:32 -08:00
Heinrich Fenkart
420a8088a4 Merge pull request #15961 from kkirsche/ImplementAssertExpect
[Fixes #15953] Implement assert.expect in each unit test
2015-03-03 15:52:05 +01:00
Kevin Kirsche
4febcb4b49 [Fixes #15953] Implement assert.expect in each unit test
[Fixes #15953] Implement `assert.expect` in each unit test
2015-03-03 08:45:07 -05:00
Heinrich Fenkart
f5beebe726 Modal: Fix backdrop not readjusting when height changes
Fixes #15136.
Closes #15345.
Closes #15314.
Refs #14724, #14927.
2015-03-03 05:27:26 +01:00
Chris Rebert
46f5a8f478 Merge pull request #15970 from twbs/the-future-is-now-qunit
Disable deprecated QUnit global methods
2015-03-02 02:39:29 -08:00
XhmikosR
f8e34ff48b Disable es3 for tests and customizer.js. 2015-03-02 11:16:06 +02:00
Chris Rebert
c291c12cb1 Disable deprecated global QUnit method aliases to prevent backsliding on QUnit v2 readiness 2015-03-01 19:50:11 -08:00
Chris Rebert
c80872235f Merge pull request #15955 from twbs/fixture-on-screen-ios
Unit tests: Only display fixture on-screen for iOS
2015-03-01 18:28:46 -08:00
Chris Rebert
015e63f6df Merge pull request #15593 from neoeno/handle_multiple_zero_offset_scrollspy_elements
Handle multiple zero-offset Scrollspy elements.
2015-03-01 16:04:04 -08:00
Caden Lovelace
a1aa0f8afd Handle multiple zero-offset Scrollspy elements.
When the first two elements in a scrollspy content block have a document
offset of zero (i.e. they're hard against the top of the page),
Scrollspy would switch between them on every scroll event.

This could happen, for example, in a system of nested sections:

```
<section id="animals">
  <section id="dogs">
	Content
  </section>
</section>
```

This ocurred because Scrollspy's check to see if it's at the end of the
array of sections uses `!arr[index]`. This misses the case where
`arr[index]` does exist and is zero.

This commit explicitly checks the array bounds.
2015-03-01 23:55:39 +00:00
Mark Otto
c16fee5efd Merge branch 'master' into v4
Conflicts:
	.travis.yml
	Gruntfile.js
	bower.json
	dist/css/bootstrap.css
	dist/css/bootstrap.css.map
	dist/css/bootstrap.min.css
	dist/js/bootstrap.js
	dist/js/bootstrap.min.js
	docs/_data/glyphicons.yml
	docs/_includes/components/breadcrumbs.html
	docs/_includes/components/button-dropdowns.html
	docs/_includes/components/button-groups.html
	docs/_includes/components/dropdowns.html
	docs/_includes/components/glyphicons.html
	docs/_includes/components/labels.html
	docs/_includes/components/list-group.html
	docs/_includes/components/media.html
	docs/_includes/components/navs.html
	docs/_includes/components/panels.html
	docs/_includes/components/progress-bars.html
	docs/_includes/components/thumbnails.html
	docs/_includes/components/wells.html
	docs/_includes/css/buttons.html
	docs/_includes/css/forms.html
	docs/_includes/css/helpers.html
	docs/_includes/css/images.html
	docs/_includes/css/less.html
	docs/_includes/customizer-variables.html
	docs/_includes/getting-started/accessibility.html
	docs/_includes/getting-started/browser-device-support.html
	docs/_includes/getting-started/community.html
	docs/_includes/getting-started/examples.html
	docs/_includes/getting-started/grunt.html
	docs/_includes/getting-started/license.html
	docs/_includes/getting-started/template.html
	docs/_includes/header.html
	docs/_includes/js/affix.html
	docs/_includes/js/alerts.html
	docs/_includes/js/carousel.html
	docs/_includes/js/collapse.html
	docs/_includes/js/dropdowns.html
	docs/_includes/js/modal.html
	docs/_includes/js/overview.html
	docs/_includes/js/popovers.html
	docs/_includes/js/scrollspy.html
	docs/_includes/js/tabs.html
	docs/_includes/js/tooltips.html
	docs/_includes/js/transitions.html
	docs/_includes/nav/javascript.html
	docs/_layouts/default.html
	docs/assets/css/docs.min.css
	docs/assets/css/src/docs.css
	docs/assets/js/customize.min.js
	docs/assets/js/docs.min.js
	docs/assets/js/raw-files.min.js
	docs/assets/js/vendor/FileSaver.js
	docs/assets/js/vendor/autoprefixer.js
	docs/assets/js/vendor/uglify.min.js
	docs/dist/css/bootstrap.css
	docs/dist/css/bootstrap.css.map
	docs/dist/css/bootstrap.min.css
	docs/dist/js/bootstrap.min.js
	docs/examples/blog/index.html
	docs/examples/carousel/index.html
	docs/examples/cover/index.html
	docs/examples/dashboard/index.html
	docs/examples/narrow-jumbotron/narrow-jumbotron.css
	docs/examples/navbar-fixed-top/index.html
	docs/examples/navbar-static-top/index.html
	docs/examples/non-responsive/index.html
	docs/examples/non-responsive/non-responsive.css
	docs/examples/theme/index.html
	grunt/configBridge.json
	js/affix.js
	js/carousel.js
	js/collapse.js
	js/dropdown.js
	js/modal.js
	js/popover.js
	js/scrollspy.js
	js/tab.js
	js/tests/unit/affix.js
	js/tests/unit/button.js
	js/tests/unit/carousel.js
	js/tests/unit/modal.js
	js/tests/unit/tooltip.js
	js/tooltip.js
	less/badges.less
	less/glyphicons.less
	less/type.less
	less/variables.less
	package.json
	scss/_dropdown.scss
	scss/_forms.scss
	test-infra/npm-shrinkwrap.json
2015-03-01 13:44:10 -08:00
Heinrich Fenkart
20fb55a840 Unit tests: Only display fixture on-screen for iOS
Since only on iOS tests fail when the fixture is displayed off-screen, see https://travis-ci.org/twbs/bootstrap/jobs/52605742
2015-03-01 09:49:59 +01:00
Heinrich Fenkart
4345e24479 Use different way to make failing test more visible in Sauce 2015-03-01 09:20:00 +01:00
Ivan Cheung
d5071b19f1 Update all collapse triggers with .collapsed class and aria-expanded
Fixes #15741
Closes #15751 by merging it.
2015-02-26 18:48:20 -08:00
Chris Rebert
9afb61fffd QUnit.jsDump => QUnit.dump
Refs http://qunitjs.com/upgrade-guide-2.x/#replace-qunit-jsdump-with-qunit-dump
2015-02-25 23:29:27 -08:00
Chris Rebert
4ff9c54cdd Use QUnit.log(...) instead of QUnit.log = ...
Refs http://qunitjs.com/upgrade-guide-2.x/#replace-qunit-log-callback-with-qunit-log-callback-for-all-reporting-callbacks
2015-02-25 23:29:27 -08:00
Heinrich Fenkart
3bb05b5fbb Unit tests: Use new names of module hooks
Refs #15893
2015-02-26 08:20:42 +01:00
nakupanda
142a9e4ae0 Modal: Apply any preexisting body padding again after closing 2015-02-26 08:02:06 +01:00
Quentin Spencer-Harper
acc5f65756 Tooltip: Avoid creating an unnecessary tooltip when Tooltip#hide is called
Fixed performance bug where a tooltip element is created and then immediately destroyed when tooltip.hide() is called and there is no existing tooltip element

Resolves #15557 by merging it.
2015-02-26 06:53:58 +01:00
vsn4ik
b395f3526e Dropdowns: Skip .disabled instead of .divider on keydown event
Fixes #15147.
Closes #15520 by merging it.
2015-02-26 06:42:09 +01:00
Heinrich Fenkart
cac6cfcd84 Merge pull request #15923 from kkirsche/useExplicitVariableDeclaration
[Ref #15881] Use Explicit JS Variable Declarations rather than Chained
2015-02-26 05:55:27 +01:00
Chris Rebert
a339bfb0ac Merge pull request #15693 from huang-x-h/patch-1
tip method in popover.js can be removed
2015-02-25 19:49:26 -08:00
Kevin Kirsche
238be65786 [Ref #15881] Use Explicit Values rather than Chain
[Ref #15881] Use Explicit Values for javascript variables rather than chained ones.

From https://github.com/twbs/bootstrap/pull/15881#discussion_r25330647
2015-02-25 12:19:11 -05:00
Chris Rebert
804457c474 fix 2 typos in modal unit test assertion messages 2015-02-24 23:49:08 -08:00
Heinrich Fenkart
c40c31a308 Dropdown unit tests: Tiny style changes 2015-02-25 02:53:39 +01:00
Heinrich Fenkart
6e0c843223 ScrollSpy: Small style consistency adjustments 2015-02-25 01:37:13 +01:00
Chris Rebert
2a6207c0c9 Merge pull request #15904 from kkirsche/patch-8
Closes #15904
2015-02-24 14:11:03 -08:00
Kevin Kirsche
696fc2e53c Add unit test of aria-expanded to dropdown suite
Redo of #15876
2015-02-24 14:09:08 -08:00
Kevin Kirsche
30d8cdf639 Add tests for aria-hidden of modal
Add tests for `aria-hidden` of modal

Use strictEqual of 1 here instead of 2 asserts
2015-02-24 16:29:40 -05:00
Chris Rebert
ecd469ec16 Merge pull request #15893 from twbs/qunit-modern
Modernize QUnit usage by avoiding usage of global functions
2015-02-24 11:47:29 -08:00
Chris Rebert
9c75c855c6 JS unit tests: equal() => strictEqual()
[skip validator]
2015-02-23 22:43:17 -08:00
Chris Rebert
bda4fe87ca upgrade to QUnit v1.17.1
[skip validator]
2015-02-23 22:18:51 -08:00
Chris Rebert
118b8c2695 JS unit tests: use QUnit.module() & QUnit.test() everywhere
[skip validator]
2015-02-23 22:14:11 -08:00
Chris Rebert
7c19fee3f1 JS unit tests: use modern QUnit assert object everywhere 2015-02-23 22:14:11 -08:00
Heinrich Fenkart
16479e9051 Merge pull request #15378 from twbs/fix-ie-modal-scrollbar-for-realz
Modal: Work around IE scrollbars not taking up page width
2015-02-24 03:33:32 +01:00
fat
1e9e3316b6 kill affix 2015-02-11 11:40:57 -08:00
fat
834220ea20 bootstrap onto closure 2015-02-11 11:29:43 -08:00
dormouse
91b384399c tip method in popover.js can be removed
Popover is extend Tooltip, the tip function can use tootltip's tip, so we can remove the tip function definition in popover to reduce the js filesize

tip function definition in tooltip.js https://github.com/tbs/bootstrap/blob/master/js/tooltip.js#L405-L407
2015-01-29 11:21:07 +08:00
Chris Rebert
cd4467b194 Merge pull request #15496 from twbs/15484-alternative
Make $(document).tooltip({...}) without a `selector` throw an error
2015-01-28 11:05:40 -08:00
Chris Rebert
af8fa54fcd Merge pull request #15630 from twbs/tabs-cond-fix
Fix error in condition in Tab plugin
2015-01-28 10:59:51 -08:00
Chris Rebert
ebedeaf2fe Fix name of Tooltip.replaceArrow() parameter
isHorizontal => isVertical
2015-01-27 11:15:55 -08:00
Chris Rebert
eaaaa00520 Integrate mq4-hover-hover-shim 2015-01-22 11:37:37 -08:00
Chris Rebert
426e8e12cd Fix error in condition in Tab plugin
Refs #15186
2015-01-21 14:13:26 -08:00
Chris Rebert
9238337cbb Merge branch 'master' into v4 2015-01-21 13:00:12 -08:00
Chris Rebert
1652efc3f6 tweak 'close reopened modal' unit test to work under new QUnit API 2015-01-20 20:18:33 -08:00
Chris Rebert
df73535a2d fix bug in tab show/shown relatedTarget unit test 2015-01-20 20:16:42 -08:00
Chris Rebert
b56d97f210 update JS unit tests to future-proof QUnit 1.16.0 API
[skip validator]
2015-01-20 19:57:51 -08:00
Mark Otto
325748ff68 Merge branch 'master' into v4
Conflicts:
	_config.yml
	dist/css/bootstrap-theme.css
	dist/css/bootstrap-theme.css.map
	dist/css/bootstrap-theme.min.css
	dist/css/bootstrap.css
	dist/css/bootstrap.css.map
	dist/css/bootstrap.min.css
	dist/js/bootstrap.min.js
	docs/_includes/components/thumbnails.html
	docs/_includes/css/forms.html
	docs/_includes/css/grid.html
	docs/_includes/customizer-variables.html
	docs/_includes/footer.html
	docs/_includes/getting-started/download.html
	docs/_includes/getting-started/template.html
	docs/_includes/js/overview.html
	docs/_includes/js/popovers.html
	docs/_includes/js/tooltips.html
	docs/assets/css/docs.min.css
	docs/assets/js/customize.min.js
	docs/assets/js/raw-files.min.js
	docs/assets/js/src/customizer.js
	docs/dist/css/bootstrap-theme.css
	docs/dist/css/bootstrap-theme.css.map
	docs/dist/css/bootstrap-theme.min.css
	docs/dist/css/bootstrap.css
	docs/dist/css/bootstrap.css.map
	docs/dist/css/bootstrap.min.css
	docs/dist/js/bootstrap.js
	docs/dist/js/bootstrap.min.js
	docs/examples/navbar-fixed-top/index.html
	docs/examples/navbar-static-top/index.html
	docs/examples/non-responsive/index.html
	docs/examples/theme/index.html
	grunt/configBridge.json
	less/alerts.less
	less/badges.less
	less/jumbotron.less
	less/panels.less
	less/tables.less
	less/theme.less
	less/variables.less
	package.json
	scss/_button-group.scss
	scss/_buttons.scss
	scss/_forms.scss
2015-01-19 14:48:12 -08:00
XhmikosR
a8139a0392 Update QUnit to v1.17.0. 2015-01-19 20:10:34 +02:00
Mark Otto
c683e7dea7 bump versions 2015-01-19 08:32:13 -08:00
XhmikosR
0481ce973f Fix bogus JSCS warning. 2015-01-16 17:50:05 +02:00
XhmikosR
0e79fe1a9f Update JSCS config for the new version. 2015-01-16 17:49:58 +02:00
XhmikosR
9db1de2a3a Update jQuery to v1.11.2. 2015-01-07 00:31:18 +02:00
Chris Rebert
34f88e94fc window.Document doesn't exist in IE8 2015-01-05 14:47:33 -08:00
Chris Rebert
f6a837cbf1 Make $(document).tooltip({...}) without a selector throw an error
Closes #15484
2015-01-05 14:22:49 -08:00
Mark Otto
0e5d17d5f6 Merge branch 'master' into v4
Conflicts:
	Gruntfile.js
	dist/css/bootstrap-theme.css
	dist/css/bootstrap-theme.css.map
	dist/css/bootstrap-theme.min.css
	dist/css/bootstrap.css
	dist/css/bootstrap.css.map
	dist/css/bootstrap.min.css
	dist/js/bootstrap.min.js
	docs/_data/glyphicons.yml
	docs/_includes/components/alerts.html
	docs/_includes/components/badges.html
	docs/_includes/components/breadcrumbs.html
	docs/_includes/components/button-dropdowns.html
	docs/_includes/components/button-groups.html
	docs/_includes/components/dropdowns.html
	docs/_includes/components/glyphicons.html
	docs/_includes/components/input-groups.html
	docs/_includes/components/jumbotron.html
	docs/_includes/components/labels.html
	docs/_includes/components/list-group.html
	docs/_includes/components/media.html
	docs/_includes/components/navbar.html
	docs/_includes/components/navs.html
	docs/_includes/components/page-header.html
	docs/_includes/components/pagination.html
	docs/_includes/components/panels.html
	docs/_includes/components/progress-bars.html
	docs/_includes/components/responsive-embed.html
	docs/_includes/components/thumbnails.html
	docs/_includes/components/wells.html
	docs/_includes/css/buttons.html
	docs/_includes/css/code.html
	docs/_includes/css/forms.html
	docs/_includes/css/grid.html
	docs/_includes/css/helpers.html
	docs/_includes/css/images.html
	docs/_includes/css/less.html
	docs/_includes/css/tables.html
	docs/_includes/css/type.html
	docs/_includes/customizer-variables.html
	docs/_includes/getting-started/accessibility.html
	docs/_includes/getting-started/disabling-responsiveness.html
	docs/_includes/getting-started/download.html
	docs/_includes/getting-started/whats-included.html
	docs/_includes/js/alerts.html
	docs/_includes/js/buttons.html
	docs/_includes/js/carousel.html
	docs/_includes/js/collapse.html
	docs/_includes/js/modal.html
	docs/_includes/js/overview.html
	docs/_includes/js/popovers.html
	docs/_includes/js/tabs.html
	docs/_includes/js/tooltips.html
	docs/_includes/nav/components.html
	docs/_includes/nav/javascript.html
	docs/_jade/customizer-variables.jade
	docs/_layouts/default.html
	docs/about.html
	docs/assets/css/docs.min.css
	docs/assets/css/src/docs.css
	docs/assets/js/customize.min.js
	docs/assets/js/raw-files.min.js
	docs/assets/js/src/customizer.js
	docs/customize.html
	docs/dist/css/bootstrap-theme.css.map
	docs/dist/css/bootstrap.css
	docs/dist/css/bootstrap.css.map
	docs/dist/css/bootstrap.min.css
	less/glyphicons.less
	less/mixins/vendor-prefixes.less
	less/navbar.less
	less/popovers.less
	less/tables.less
	less/theme.less
	less/tooltip.less
	less/variables.less
	package.json
	scss/_carousel.scss
	scss/_close.scss
	scss/_forms.scss
	test-infra/npm-shrinkwrap.json
2015-01-03 20:08:58 -08:00
Zlatan Vasović
576230b92a Happy New Year 🎅 2015-01-01 01:23:48 +01:00
Chris Rebert
adaabab81b Revert "Allow multiple delegated tooltip selectors on a node"
This reverts commit 1b3237629a.
This reverts PR #14189 because it caused major regressions.

Fixes #15168.

We'll try to revisit #14167's feature request in Bootstrap v4.

[skip validator]
2014-12-29 20:08:22 -08:00
Chris Rebert
32cb071594 Remove semicolons from #15425 because fat 2014-12-29 18:34:35 -08:00
Chris Rebert
27bfef5b35 Add regression test for #14244.
Special thanks to @programcsharp

[skip validator]
2014-12-29 16:09:37 -08:00
Chris Rebert
54b03c27d2 Merge pull request #43 from twbs/popover-arrow
rename .arrow => .popover-arrow
2014-12-29 16:01:07 -08:00
Chris Rebert
e26701c04e JSCS: enable requireSpaceBetweenArguments
New rule added in JSCS v1.9.0
Our JS already complies with this.
2014-12-29 14:16:26 -08:00
Chris Rebert
05d1877985 update JS to use .{tooltip,popover}-{left,right,top,bottom} 2014-12-29 12:34:09 -08:00
Chris Rebert
6a5bc63649 rename .arrow => .popover-arrow 2014-12-29 12:33:06 -08:00
Chris Rebert
2ae4c0b03f JSCS: enable requireSpaceBetweenArguments
New rule added in JSCS v1.9.0
Our JS already complies with this.
2014-12-29 12:02:33 -08:00
Heinrich Fenkart
32f62bc565 Modal: Work around IE scrollbars not taking up page width
Fixes #15353.
2014-12-18 07:29:34 +01:00
Chris Rebert
c7ef5810e1 rename .item => .carousel-item 2014-12-17 18:44:55 -08:00
Chris Rebert
a8299b5b45 Remove ancillary references to IE<9 in comments+docs 2014-12-16 19:06:57 -08:00
Chris Rebert
a28e25c00b Remove IE8 compat shims from JS visual tests 2014-12-15 11:38:57 -08:00
Dan Dascalescu
2c64fc2c4d Fix copy/paste error 2014-11-28 04:30:04 -08:00
Chris Rebert
bc5a753b67 fix affix-top unit test to properly clean up after itself 2014-11-20 23:26:37 -08:00
Nick O'Donoghue
36b4f90f25 Fixes affix-top class not applying
Use scrollTop instead of colliderTop which uses the elements
offset().top, as the offset top does not account for padding.

This issue can be replicated by using a navbar-fixed-top and applying
relevant padding to the body. (A navbar-static-top with no padding on
the body does not encounter this issue)

Fixes #15078
Closes #15154 by merging it
2014-11-17 18:17:42 -08:00
Nick O'Donoghue
da79ab9488 add unit test for affix-top for padding issue 2014-11-17 18:17:40 -08:00
Chris Rebert
b7398bc9c4 honor wrap option in Carousel.getItemForDirection; fixes #15144 2014-11-15 22:43:20 -08:00
Chris Rebert
8008fe707e add unit tests for Carousel's 'wrap' option 2014-11-15 22:37:55 -08:00
Heinrich Fenkart
a577f1922e Collapse: Use $.fn.children instead of > in selector
Fixes #15131.
2014-11-14 15:18:34 +01:00
Mark Otto
9a7e365c2c bump version to v3.3.1 2014-11-12 09:03:16 -08:00
Heinrich Fenkart
1d55ada581 Dropdown: ignore keydown events coming from inputs and textareas
Fixes #15084.
2014-11-12 02:01:25 +01:00
Chris Rebert
21644321e4 Merge pull request #14993 from twbs/fix-14991
Have Carousel ignore keyboard events from <input>s or <textarea>s
2014-11-04 16:50:36 -08:00
Heinrich Fenkart
da74fba490 Center modal dialog at all times 2014-11-05 01:37:44 +01:00
Chris Rebert
469dc3ab1f Have Carousel ignore keyboard events from <input>s or <textarea>s; fixes #14991 2014-11-04 16:23:44 -08:00
Heinrich Fenkart
425a985491 Update head of all visual tests to use our basic template 2014-11-05 01:18:11 +01:00
Heinrich Fenkart
14e5fb04e9 Fix modal backdrop overlaying the modal's scrollbar
Fixes #14916.
2014-11-04 23:17:55 +01:00
Chris Rebert
4102a67f33 fix typo in comment 2014-10-30 01:47:48 -07:00
Heinrich Fenkart
cf482dbb0b Fix the iOS 8 unit test failures
Resolves #14919.
2014-10-30 09:35:53 +01:00
Heinrich Fenkart
5178d8b8ba Use RegExp for button plugin's focus shim
Fixes #14923.
2014-10-30 03:46:49 +01:00
Mark Otto
94b59b57d6 version bump 2014-10-29 08:56:20 -07:00
Ben-Russell
68b771a057 Independently delegate data-api selectors
Fixes #14462.
Closes #14463 by merging it.
2014-10-29 04:54:53 +01:00
Heinrich Fenkart
ed3a65f084 Handle collapsed class on triggers even when manually invoked
Fixes #13636.
2014-10-29 04:34:05 +01:00
Heinrich Fenkart
e851b8685a Merge pull request #14457 from hnrch02/button-set-val-after-event-loop
Change value of stateful button after event loop
2014-10-29 04:28:22 +01:00
Chris Rebert
22e1f94b52 Increase timeouts in tooltip unit tests to avoid spurious Sauce failures
Fixes #14851
2014-10-27 15:53:43 -07:00
Heinrich Fenkart
007fbdb66d Remove faulty unit test from 9740d8b
This would only work with transitions but since we disable them for unit tests, this delivers unreliably results.
2014-10-26 04:56:52 +01:00
Heinrich Fenkart
5da85f8e8b Follow-up to 9740d8b: fix small typo 2014-10-26 04:41:47 +01:00
Phil Hughes
9740d8bb69 Fix tooltip occasionally not hiding when using a hide delay
Fixes #14375.
Closes #14519 by merging it.
2014-10-26 04:38:18 +01:00
Andrew S. Brown
1b3237629a Allow multiple delegated tooltip selectors on a node
Fixes #14167.
Closes #14189 by merging it.
2014-10-26 03:51:55 +01:00
Heinrich Fenkart
0e991ccba2 Follow-up to e8af21c: rm unused variable in unit test 2014-10-26 03:16:05 +01:00
Tadeu Zagallo
e8af21cc9d Clear scrollspy selection above first section
Closes #13563 by merging it.
2014-10-26 03:14:08 +01:00
Cameron Little
0755d529c6 Tabs plugin accessibility
Added support for `aria-expanded` toggling via JavaScript. Added
`aria-controls`, `aria-expanded`, `aria-labelledby` to tabs docs.

Added `aria-expanded` unit test for the tabs plugin.

See also #13554.

Closes #14154 by merging it.
2014-10-26 02:25:47 +01:00
Heinrich Fenkart
c1f669e83b Revert "Scrollspy: ignore invisible list items" 2014-10-26 01:50:38 +02:00
Heinrich Fenkart
fe51148434 Merge pull request #14669 from vsn4ik/dropdown_event_target
Use e.target instead :focus selector.
2014-10-23 06:13:46 +02:00
Heinrich Fenkart
3c98dd35ba Fix IE8 unit test breakage introduced by #14767 2014-10-22 22:09:58 +02:00
Phil Hughes
ab8dbc214e Implement hide and hidden events for tabs
Closes #14772.
2014-10-22 21:42:35 +02:00
Heinrich Fenkart
95e0f48e3a Follow-up to e2cfbd5: Fix spaces in placement calculation 2014-10-22 21:38:34 +02:00
saranya.r
e2cfbd5f2d Fixes tooltip misplacements in scrollable viewports with auto positioning
Fixes #14756.
Closes #14767.
2014-10-22 21:35:44 +02:00
Patrick H. Lauke
e1d40f7633 Add aria-pressed to single toggle buttons
also includes tiny fix/clarification to two existing unit tests for the
.active class, adding data-toggle=“button” explicitly to the tested
buttons

Closes #14819.
2014-10-22 21:02:19 +02:00
Heinrich Fenkart
e811a24118 Don't fire show event if show is prevented because other element is still transitioning
Fixes #14844.
Closes #14845.
2014-10-22 04:25:05 +02:00
fat
4bbe80658a fixes #13816 Modal dialog closes when dragging and releasing mouse button outside dialog 2014-10-09 20:01:51 -07:00
XhmikosR
909a178362 Change Twitter links to use https. 2014-10-07 15:28:41 +03:00
Heinrich Fenkart
61705d35fa Small clean-up in scrollspy unit test 2014-10-07 06:57:46 +02:00
Chris Rebert
d361470487 tooltip unit tests: fix typo in test description 2014-10-03 16:26:53 -07:00
Maarten Van Hoof
44894a40e5 Add missing collapse JS files to dropdown visual test
Closes #14726.
2014-10-03 19:55:13 +02:00
Jacob
2c562d2386 Merge pull request #14590 from twbs/carousel-keyboard-option
Add `keyboard` option to carousel
2014-10-02 23:11:14 -07:00
Jacob
3fda099f5c Merge pull request #14722 from twbs/fat-14646
Escape key should only close Dropdown
2014-10-02 21:26:38 -07:00
fat
e5fc22ccfa Escape key should only close Dropdown 2014-10-02 21:11:17 -07:00
Heinrich Fenkart
038a63b0eb Add keyboard option to carousel
Also adds unit tests for keyboard events.

Fixes #14468.
2014-10-03 05:16:31 +02:00
Jacob
b702889613 Merge pull request #14626 from twbs/carousel-pause-hover-non-mobile
Only enable `pause: hover` for non-touch browsers
2014-10-02 20:09:20 -07:00
Chris Rebert
443a1b11ee tooltip.js: fix alignment 2014-09-24 21:27:56 -07:00
Chris Rebert
4d9890ea2e Use container instead of parent for tooltip/popover auto-placement calcs
Fixes #14561. Big thanks to @wickstargazer.

[skip validator]
2014-09-24 20:46:49 -07:00
Heinrich Fenkart
24ae068f21 Tooltip: Rely on getBoundingClientRect for width and height
Fixes #14553.
2014-09-25 01:35:51 +02:00
Heinrich Fenkart
c37c1a6743 Only enable pause: hover for non-touch browsers
Fixes #11967.
2014-09-23 23:34:58 +02:00
vsn4ik
bd66b12a94 Use e.target instead :focus selector. 2014-09-23 13:19:15 +04:00
Heinrich Fenkart
acf3c0bf48 Merge pull request #14570 from twbs/remove-modal-open-after-backdrop-closed
Remove `.modal-open` class after backdrop is hidden
2014-09-22 21:44:39 +02:00
Chris Rebert
6f6466330d Make it easier to see failing tests in Sauce screencasts
...by hiding passing tests in the list of tests.
2014-09-17 18:33:39 -07:00
Heinrich Fenkart
3beeb32bb0 Follow-up to #14581: Use div instead of HTML5 section for IE8 2014-09-17 23:33:22 +02:00
saranya.r
db9e8ee813 Fix tooltip misplacement with "auto top"
Fixes #14322.
Closes #14581.
2014-09-17 23:11:04 +02:00
Heinrich Fenkart
c4f431d262 Remove .modal-open class after backdrop is hidden
Fixes #14274.
Fixes #14632.
2014-09-17 09:21:09 +02:00
Heinrich Fenkart
152d9dfe2e Merge pull request #14610 from twbs/axe-tooltip-validate
Remove unused Tooltip#validate method
2014-09-16 05:41:17 +02:00
Chris Rebert
73e3db0a2f Must explicitly destroy tooltip in SVG unit test since its container is body.
Leaking tooltips across tests leads to confusion and sadness.
2014-09-15 20:01:06 -07:00
Heinrich Fenkart
e094d470d4 Remove unused Tooltip#validate method 2014-09-13 09:39:15 +02:00
Peter West
4c98507010 Correctly selects arrow placement for a tooltip
Fixes #13696.
Fixes #13696.
Fixes #14197.
Closes #13718.
2014-09-13 04:25:34 +02:00
Heinrich Fenkart
76762169c3 Properly fire hidden event when tooltip is destroyed
Fixes #13031.
2014-09-13 03:07:32 +02:00
Heinrich Fenkart
a97db64881 Merge pull request #14569 from twbs/scrollspy-ignore-invisible-targets
Scrollspy: ignore invisible list items
2014-09-13 02:29:28 +02:00
Heinrich Fenkart
40f889df2a Merge pull request #14353 from hnrch02/collapse-count-collapsing-as-active
Collapse: count `.collapsing` elements as actives; closes #13447
2014-09-13 02:28:25 +02:00
Heinrich Fenkart
6e206f5e8f Merge pull request #14492 from twbs/ie8-getBoundingClientRect
Handle lack of .width and .height from getBoundingClientRect() in IE8
2014-09-11 23:11:45 +02:00
Heinrich Fenkart
759a95b0fe Make inDom check of tooltip cross document compatible
Fixes #14483
2014-09-09 03:03:14 +02:00
samme
e29c75041e Make affix accept 0 as offsetTop or offsetBottom
Fixes #12815.
Closes #14363.
2014-09-09 01:32:42 +02:00
Heinrich Fenkart
9b9e2f5d13 grunt and missing new line 2014-09-09 01:23:48 +02:00
Patrick H. Lauke
fb1ca10b99 ARIA support for collapse
Added handling of aria-expanded=true/false to collapse.js, updated
documentation to include advice on making expand/collapse controls
accessible, updated examples and javascript documentation to use
aria-expanded and aria-controls (when targetting single collapsible
element, using ID rather than class selector)

Closes #14147.
Closes #14153.
2014-09-09 01:19:20 +02:00
Heinrich Fenkart
d15444d15e Scrollspy: ignore invisible list items
Fixes #13071
2014-09-09 00:18:18 +02:00
Heinrich Fenkart
859ddc11fb Merge pull request #14242 from hnrch02/remove-aria-describedby-later
Remove `aria-describedby` attribute later
2014-09-08 23:14:50 +02:00
Heinrich Fenkart
e4b55ded5c Merge pull request #13928 from SGinTech/sgit_collapseEventOrder
Ensure that hidden event is sent when content is really hidden (collapsi...
2014-09-08 23:12:27 +02:00
Heinrich Fenkart
787404e090 Merge pull request #14287 from hnrch02/revert-13855-modal-mousedown
Revert #13855 due to #14263
2014-09-08 22:23:43 +02:00
Chris Rebert
7f56233862 Merge branch 'stefansundin/master' 2014-09-07 23:07:38 -07:00
Stefan Sundin
f25181615e Fix bug not re-calculating scrollbar width when opening modal.
If opening a modal when a scrollbar is present, closing it, then
resizing the window so the scrollbar disappears, then opening the
modal again, the content would shift. This fixes the problem by
always calculating the scrollbar width every time a modal is opened.

Closes #14357.
2014-09-07 23:06:37 -07:00
Chris Rebert
989dafb153 Handle lack of .width and .height from getBoundingClientRect() in IE8
Closes #14093
Correction to #14090
Relevant docs: https://developer.mozilla.org/en-US/docs/Web/API/Element.getBoundingClientRect#Browser_compatibility
2014-09-07 22:58:33 -07:00
Jacob
c22b270582 Merge pull request #14273 from sgonyea/master
Fix hover-popover/tooltip flickering when mouse re-enters
2014-09-07 10:36:45 -07:00
Scott Gonyea
aac0e16452 Fix hover-tooltip flickering when mouse re-enters
- is(':visible') seems to be the only reliable check, without a refactoring of how hoverState is used
- tests need improvement
2014-08-28 17:17:50 -07:00
XhmikosR
d869a5fb62 Update QUnit to v1.15.0. 2014-08-28 09:38:53 +03:00
Heinrich Fenkart
c207b5b66b Change value of stateful button after event loop
Fixes #14450
2014-08-26 03:02:29 +02:00
Mark Otto
875006d08c Merge pull request #14417 from twbs/fat-14282
fixes #14282 - Already Visible collapse gets closed when …
2014-08-23 12:58:24 -07:00
Chris Rebert
9efedf8f7b Merge pull request #14406 from twbs/nav-tag-for-navbar
consistently use <nav> instead of <div> for .navbar in docs
2014-08-20 21:48:59 -07:00
Jacob
c95aa97c03 Merge pull request #14244 from programcsharp/master
Remove popover content with .children().detach() instead of .empty()
2014-08-18 20:06:02 -07:00
fat
9c2e54bfec fixes #14282 - Already Visible collapse gets closed when .collapse('show') is called 2014-08-18 19:58:19 -07:00
Chris Rebert
ea0e1606dc Assume Element.getBoundingClientRect() exists; Fixes #14093
[skip validator]
2014-08-17 16:08:49 -07:00
Chris Rebert
6b7142212f consistently use <nav> instead of <div> for .navbar in docs 2014-08-15 18:09:05 -07:00
Heinrich Fenkart
436015c191 Collapse: count .collapsing elements as actives; closes #13447 2014-08-08 01:23:50 +02:00
Heinrich Fenkart
75bffd84ae Use closest .alert for alert dismissal; closes #14306 2014-08-04 19:33:42 +02:00
Heinrich Fenkart
dca8afa333 Remove aria-describedby attribute later
Fixes #14241
2014-08-04 19:21:49 +02:00
Jacob
8bf48121a0 Merge pull request #14061 from hnrch02/fix-13656
Expose transition durations on plugin constructors; closes #13656
2014-08-01 12:50:03 -07:00
Chris Rebert
08393bf68a Fix #14076: Add unit test for tooltips on SVG elements
[skip validator]
2014-08-01 12:10:00 -07:00
Chris Rebert
cbba8e53df Fix #13818 by using more robust "find next carousel item" logic
Also adds another test for #9461: carousel next/prev should ignore non-items
2014-07-31 11:36:24 -07:00
Heinrich Fenkart
18c0a1c977 Revert "Use mousedown instead of click for backdrop click detection; fixes #13816" 2014-07-30 23:54:25 +02:00
Chris Hynes
531fc80885 Use .end() to remove extra line 2014-07-25 11:10:46 -07:00
Chris Rebert
c2f4e5fef1 re-alphabetize .jscsrc 2014-07-25 11:02:30 -07:00
Chris Hynes
519a087dbe Remove popover content with .children().detach() instead of .empty() so it can be reused 2014-07-25 10:16:44 -07:00
Artem Belov
098242afd8 Delete duplicate JSCS properties 2014-07-25 15:03:07 +04:00
Jacob
36483af92c Merge pull request #14207 from twbs/charlesbjohnson-affix-bottom-when-dynamic-height
Charlesbjohnson affix bottom when dynamic height
2014-07-21 22:48:38 -07:00
fat
4775c9296a Merge branch 'dropdown-aria' of git://github.com/mckramer/bootstrap into mckramer-dropdown-aria
Conflicts:
	docs/_includes/js/dropdowns.html
2014-07-21 22:44:35 -07:00
fat
eff9b063da cleanup style 2014-07-21 22:37:04 -07:00
Charles B Johnson
724c4f526c Fix issue where bottom affixed element floats over the footer when the
document height is smaller than the viewport height.
2014-07-18 10:46:42 -04:00
Charles B Johnson
8c0eb9b00e Refactor determining affix state into a separate expanded method
in order to handle multiple edge cases, specifically when the document
  height is dynamic.
Always reposition an affix that is affixed to the bottom.
2014-07-18 10:45:59 -04:00
Charles B Johnson
d3dea01a11 Add a bottom affixed element to affix visual tests. 2014-07-18 10:45:59 -04:00
Jacob
866ffc4f37 Merge pull request #14055 from twbs/fat-speed-up-tests
speed up js tests a bit
2014-07-17 10:07:28 -07:00
fat
9b90b87099 speed up js tests a bit 2014-07-16 22:22:42 -07:00
Heinrich Fenkart
cc7fab893d Follow-up to #13907: simplify JS logic for focus shim 2014-07-16 08:44:56 +02:00
Heinrich Fenkart
1719d2b051 document.head is undefined in IE8 2014-07-09 00:42:02 +02:00
Heinrich Fenkart
0268b41c4f Fix IE8 reporting type object for getBoundingClientRect 2014-07-09 00:42:02 +02:00
Heinrich Fenkart
05ddea314c Fix IE8 reporting height style as all uppercase 2014-07-09 00:42:02 +02:00
Chris Rebert
21571b3412 Fix invalid HTML in "should allow html entities" tooltip unit test
Refs #14090.
Also, fix one typo.
2014-07-08 14:40:20 -07:00
Heinrich Fenkart
231744d628 Expose transition durations on plugin constructors; closes #13656 2014-07-07 13:03:56 +02:00
Mark Otto
907b3b2892 Merge pull request #13907 from twbs/fat-12145
add "focus" to focused btns with button plugin
2014-07-07 00:36:59 -07:00
fat
587c09cb48 fix scrollspy test in firefox mac os 2014-07-06 21:50:46 -07:00
Jacob
b5d86ad0bd Merge pull request #13853 from hnrch02/unit-tests-cleanup
Major unit tests cleanup
2014-07-06 21:43:48 -07:00
Mark Otto
44f83fff90 Merge pull request #14021 from CFXd/add_collapsed_default_class_to_navbar_collapse_button
Add collapsed default class to navbar-toggle
2014-07-06 16:37:42 -07:00
Mark Otto
ac18e5811d jscs fix 2014-07-06 15:08:33 -07:00
fat
cb19f4f227 Merge branch 'breaddevil-replace-scrollspy-default-behavior-test' 2014-07-06 14:11:38 -07:00
fat
b19719ea1a Merge branch 'replace-scrollspy-default-behavior-test' of git://github.com/breaddevil/bootstrap into breaddevil-replace-scrollspy-default-behavior-test
Conflicts:
	js/tests/unit/scrollspy.js
2014-07-06 14:11:23 -07:00
Jacob
279c46152b Merge pull request #13815 from hnrch02/tabs-fade-not-active
Allow tabs to fade in if no initially active pane is present
2014-07-06 13:50:54 -07:00
Heinrich Fenkart
58eb8b2ae3 Move to leading pluses 2014-07-06 11:56:12 +02:00
Chris Rebert
a34e52de4d Merge pull request #14015 from twbs/possible-14013-fix
Possible fix for #14013
2014-07-06 00:36:52 -07:00
Heinrich Fenkart
dad56be96c Move to 16ms from 18ms based on the Paul Irish's rAF polyfill 2014-07-06 09:24:23 +02:00
Heinrich Fenkart
8ff099585f Mention #13500 in comment for ScrollSpy test 2014-07-06 09:24:23 +02:00
Heinrich Fenkart
e341355d28 Clean tooltip unit tests up 2014-07-06 09:24:23 +02:00
Heinrich Fenkart
b3a125e941 Clean tab unit tests up 2014-07-06 09:24:23 +02:00
Heinrich Fenkart
05ba1e491e Clean scrollspy unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
56b8d5fe6e Clean popover unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
998c3724e8 Clean modal unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
9ff66a12bc Clean dropdown unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
77d0557468 Clean collapse unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
6a523bf99d Clean carousel unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
f3345f68d7 Clean button unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
b063de54a5 Clean alert unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
95d7c9c3fb Clean affix unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
4950fe6f4e Perform a cleanup after each test 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
1e64c4c0ba Update QUnit settings/QUnit phantomjs bridge to new versions 2014-07-06 09:24:22 +02:00
Chris Rebert
f9ffb49932 refactor/reformat Tooltip.getPosition per @fat's feedback 2014-07-06 00:16:54 -07:00
Jacob
5830febd9a Merge pull request #13855 from hnrch02/modal-mousedown
Use mousedown instead of click for backdrop click detection; fixes #13816
2014-07-06 00:01:57 -07:00
Jacob
13a4c50cc7 Merge pull request #14000 from hnrch02/modal-keydown
Only close modal if escape was hit with keydown; fixes #13929
2014-07-05 23:55:36 -07:00
fat
c08e275000 fix build 2014-07-05 23:49:45 -07:00
fat
22f851fa62 apply #14022 without semicolon – cleans up some jquery class usage 2014-07-05 23:28:44 -07:00
Wing
4b08832308 no need to create $.Event
`trigger()` can handle string argument
2014-07-03 10:52:22 -07:00
Wing
48b822db40 trigger 'affixed.bs.affix' instead of 'affixed'
Original is triggering `affixed` not `affixed.bs.affix`, only `.on('affixed.bs.affix', ...)` also catch `affixed` event.

Closes #13998.
2014-07-03 10:52:22 -07:00
Michael Silber
1e407c81f1 Add collapsed default class to navbar-toggle 2014-07-02 16:49:03 -04:00
Chris Rebert
1ce5e9f3ae possible fix for #14013 2014-07-02 10:09:28 -07:00
Heinrich Fenkart
91f329e448 Only close modal if escape was hit with keydown; fixes #13929 2014-07-01 05:50:31 +02:00
Heinrich Fenkart
121bf6633e Use mousedown instead of click for backdrop click detection; fixes #13816 2014-07-01 02:53:57 +02:00
Mark Otto
ff6b279b3c bump to v3.2.0 2014-06-26 09:13:24 -07:00
sgamel
9445b84b0b Ensure that hidden event is sent when content is really hidden (collapsing class is removed) 2014-06-26 10:18:45 +02:00
Heinrich Fenkart
282f8fc04b Add a few more cases to the visual test tab page 2014-06-25 04:18:51 +02:00
Heinrich Fenkart
634ea59a25 Allow tabs to fade in if no initially active pane is present; fixes #13814 2014-06-25 04:18:51 +02:00
fat
6b6476fcd9 add "focus" to focused btns with button plugin 2014-06-23 23:39:54 -07:00
fat
0aa01f63e3 Merge branch 'master' into fix-13386
Conflicts:
	js/carousel.js
2014-06-23 23:08:23 -07:00
Chris Rebert
c2c19a4d2d Revert UMD (#13772 & friends) for now, due to #13812.
Will hopefully revert this reversion and land a fully-working version of UMD in v3.3.0.

Revert "some changes from #13801 - add strict mode back and =="
This reverts commit 2b302f69ee.

Revert "Fix regression of #10038 introduced by #13772"
This reverts commit e9d6756a1a.

Revert "MD/CommonJS/Globals #12909"
This reverts commit 1c6fa9010d.

Revert "address #13811"
This reverts commit f347d7d955.

Conflicts:
    js/carousel.js
    js/collapse.js
    js/dropdown.js
    js/modal.js
    js/tab.js
    js/tooltip.js
2014-06-23 11:11:59 -07:00
Heinrich Fenkart
587451ad9a Update a few source files to comply to new JSCS rules 2014-06-19 21:08:05 +02:00
Heinrich Fenkart
09c2e41ec4 Remove deprecated JSCS rules and add requireSpaceAfterLineComment 2014-06-19 21:08:05 +02:00
Erwan Jegouzo
1b63d0b9ba fix for #13747
Closes #13782 by merging it.
2014-06-17 17:56:15 -07:00
Chris Rebert
f071549c84 fix #13386 2014-06-13 12:12:32 -07:00
fat
2b302f69ee some changes from #13801 - add strict mode back and == 2014-06-12 11:11:04 -07:00
Jacob
696632d7da Merge pull request #13786 from twbs/fat-13430
add special transitionend type to test event origin
2014-06-11 22:44:04 -07:00
Heinrich Fenkart
e9d6756a1a Fix regression of #10038 introduced by #13772 2014-06-12 06:00:02 +02:00
Jacob
6ac5708a0d Merge pull request #13787 from twbs/fat-3731
fix #13185 - keyboard support for carousel
2014-06-11 15:19:39 -07:00
fat
7f122be004 add special transitionend type to test event origin
fixes #13430
2014-06-10 20:42:19 -07:00
fat
a1dad14f44 fix #13185 - keyboard support for carousel 2014-06-10 20:35:03 -07:00
fat
571fd32bce fix #13220 Scrollspy generates wrong offsets for a page-- recalculate offsets if scrollheight changes 2014-06-10 17:38:42 -07:00
Katie Zhu
1c6fa9010d MD/CommonJS/Globals #12909 2014-06-10 17:16:29 -07:00
Katie Zhu
5eaedbe097 change how carousel indicators activate #12592 2014-06-09 21:59:03 -07:00
Jacob
fe74a8bb3e Merge pull request #13755 from twbs/fat-visual-test
Adds isolated visual tests for javascript plugins (decoupled from docs)....
2014-06-08 16:05:08 -07:00
fat
91103e6d1f Adds isolated visual tests for javascript plugins (decoupled from docs). This makes it
faster and easier to test/develop js functionality not represented in unit tests, and gives us
a playground for interactions, etc.

It also makes it so developing javascript is now decoupled form jekyll, which should make everything
faster and less painful.

This commit also reverts my filter commit 9900771aa7
which broke scrollspy for dropdowns.
2014-06-07 19:11:44 -07:00
Mike Greiling
1cfa902e31 refactor scrollspy refresh method
Closes #13702 by merging a rebased version of it.
2014-06-07 18:26:39 -07:00
Mike Greiling
bc8e6ffb7d removing this.$element as it is a superfluous copy of this.$scrollElement 2014-06-07 18:09:53 -07:00
Mike Greiling
632313d631 no need to check for href attribute on the scrollable element 2014-06-07 18:09:53 -07:00
Mike Greiling
0be4109688 there is no need for this.offsets and this.targets to be jQuery objects 2014-06-07 18:09:53 -07:00
Chris Rebert
21de05c8c0 don't show tooltips/popovers whose element isn't in the DOM; fixes #13268 2014-06-07 17:54:11 -07:00
Chris Rebert
b23ed1b034 put the tooltips into the DOM in the tooltip unit tests 2014-06-07 17:54:11 -07:00
Chris Rebert
20c099d41a add failing test for #13268 2014-06-07 17:54:10 -07:00
XhmikosR
3b99a41246 Merge pull request #13388 from twbs/xhmikosr-js-style
Improve JS style
2014-06-07 09:13:05 +03:00
Chris Rebert
3cbbc70d55 Merge pull request #13627 from twbs/maybe-fix-12364
Hopefully fixes trigger focus restoration on modal close
2014-06-06 15:59:17 -07:00
XhmikosR
e2cabe4971 Minor style tweaks. 2014-06-06 01:23:07 +03:00
XhmikosR
82fc03f3b6 carousel.js: remove unneeded variable assignment.
`slideIndex` is assigned to the same value a few lines above.
2014-06-06 01:23:07 +03:00
XhmikosR
7b0acf14d8 Comply to the new style. 2014-06-06 01:23:07 +03:00
XhmikosR
5ef9383f53 Tweak JSHint and JSCS checks.
Be more consistent across the whole codebase.

Also, make use of JSHint's 2.5.1 `extends` and `qunit` options. This way we set our basis options in js/.jshintrc and override the rest.
2014-06-06 01:23:06 +03:00
Chris Rebert
475dbe58b0 Merge pull request #13589 from mrobinet/scrollspy-maxScroll-with-offset
Adjust for Scrollspy offset when calculating maxScroll.
2014-05-23 14:36:05 -07:00
Chris Rebert
bc1ce426d9 Merge pull request #13593 from ResentedHook/master
Add tooltip self-reference to address #12320
2014-05-23 14:33:19 -07:00
Chris Rebert
ef62254917 Merge pull request #13557 from bassettsj/aria-describedby-tooltip-13480
Aria describedby tooltip: #13480
2014-05-23 14:11:15 -07:00
Max Kramer
ee12ce8305 Add aria-haspopup and aria-expanded attributes to dropdown plugin
1. Add aria-haspopup="true" and aria-expanded="false" to dropdown docs
2. Toggle aria-expanded between "true" and "false" when opening and closing dropdown

Satisfy item 1 from https://github.com/paypal/bootstrap-accessibility-plugin#dropdown. See #13553.
2014-05-22 18:13:41 -04:00
Chris Rebert
b058c018eb Hopefully a fix for #12364
* register the callback before invoking the toggling
* listen for `hidden` instead of `hide`
* account for the possibility of the associated `show` event being preventDefault-ed

Adds relevant unit tests.
2014-05-19 02:14:14 -07:00
Chris Rebert
e9b99d475c fix typo in assertion description 2014-05-19 00:47:06 -07:00
Chris Rebert
3d1723d689 add missing event namespacing in modal.js 2014-05-16 17:05:03 -07:00
Attila Dobi
f47ad79538 add target option to Affix plugin 2014-05-16 13:07:45 -07:00
Steven Bassett
a70da16f6f Adds aria described by to tooltip plugin for accessibility
Generates a unique id for tooltip and adds [aria-describedby] to the element
it is called on. Resolves issue #13480

- set up test
- linted the code styles
- passed the tests
- integrated feedback from @cvrebert
2014-05-16 10:45:38 -07:00
j.corns
122c05dbd8 Add tooltip self-reference to address #12320
primarily adds a data- attribute to the tooltip (and thus, the popover)
to create a self-reference.
2014-05-14 10:36:32 -07:00
Mike Robinet
c2e94eba8d Add Scrollspy maxScroll with offset test. 2014-05-13 12:53:54 -05:00
Mike Robinet
e84b0c0433 Adjust for Scrollspy offset when calculating maxScroll. 2014-05-13 09:57:04 -05:00
XhmikosR
7a765d1f8b Update jQuery to v1.11.1. 2014-05-13 08:33:23 +03:00
fat
f219fee07b versions 2014-05-12 21:15:16 -07:00
Jacob
c312d735d9 Merge pull request #13191 from AshleyDawson/master
Fixed nested tab elements li activation
2014-05-12 20:57:21 -07:00
fat
9900771aa7 fixes #12211: Scrollspy: Navs in different tabs can interfere with each othe 2014-05-12 19:15:23 -07:00
Gregory Pakosz
78cac11cef Fixed affix-bottom positioning
Set top position to (scrollHeight - this.$element.height() - offsetBottom).
2014-05-09 00:26:31 +02:00
Chris Rebert
9444df2476 Merge pull request #13511 from hnrch02/button-reset-falsey-values-fix
Allow for resetText of a button to be a falsey value; fixes #13466
2014-05-05 22:55:05 -07:00
Chris Rebert
a032c396ee Merge pull request #13406 from EnsignR/closed.bs.alert-after-remove
fires closed.bs.alert *after* DOM detach() as per #12379
2014-05-05 22:47:50 -07:00
Heinrich Fenkart
d8ee1ba9b6 Allow for resetText of a button to be a falsey value; fixes #13466 2014-05-05 19:07:47 +02:00
Chris Rebert
06af640e82 import rules from Ratchet's JSCS config with which we already comply 2014-05-04 15:15:02 -07:00
breaddevil
7627b24c1e replace js scrollspy test for default behavior 2014-05-04 11:24:31 +02:00
Chris Rebert
d9edf28c5f make new Carousel tests compatible with noConflict mode 2014-05-01 13:37:44 -07:00
Chris Rebert
b23ca2de41 add role="tooltip" to popovers; fixes #13481 2014-05-01 13:27:00 -07:00
Mark Otto
f20f66604b Merge pull request #11966 from colllin/noconflict
Fix #11464 - JS noConflict() mode not working in 3.0.x
2014-04-30 17:43:43 -07:00
Ross Nye
73f7acc01b Update alert.js
Added call to remove() after event fires to clean up data as per discussion at #12379
2014-04-30 13:12:31 +10:00
Chris Rebert
05d4932cad Merge pull request #13396 from twbs/carousel-events
Carousel event properties
2014-04-25 19:35:38 -07:00
Chris Rebert
e114727ae9 Carousel.slide: rename e => slideEvent 2014-04-25 17:50:38 -07:00
Chris Rebert
4bd29bfcff change 'slid' comments per @fat's feedback 2014-04-25 17:48:02 -07:00
Chris Rebert
4d0a8e31a4 Add direction & relatedTarget properties to slid.bs.carousel event
Fixes #13393
2014-04-24 19:02:47 -07:00
Ross Nye
637808f2ee fires closed.bs.alert *after* DOM detach()
fires closed.bs.alert *after* element is removed from DOM.
Previously it fired while the element was still attached.
2014-04-23 17:34:32 +10:00
Collin Donahue-Oponski
a9f2b6ce0f #11464 - Fix JS noConflict mode - Refactor all plugins to use an internal reference to the jQuery plugin, because in noConflict mode you can never expect to be defined on the jQuery object 2014-04-21 23:03:33 -06:00
fat
b9ae07d84a fixes #13157 - Collapse plugin - issues with transition end event bubbling 2014-04-21 17:35:29 -07:00
Chris Rebert
f66a747615 add unit tests for Carousel slid events 2014-04-21 13:14:53 -07:00
Chris Rebert
9c4afc5772 spelling fixes in Carousel unit tests 2014-04-21 13:08:42 -07:00
Chris Rebert
d971ddb730 add missing operators to some JSCS rules that we already comply with 2014-04-20 16:33:23 -07:00
Tobias Lindig
a69bc3bc09 move call for removeBackdrop() to backdrop()
Closes #11958 by rebasing & merging it
2014-04-20 14:47:32 -07:00
Jacob
b02d3c7eff Merge pull request #13306 from twbs/fat-11099
fixes #11099 - $.collapse() overrides the original dimension of the coll...
2014-04-20 12:12:17 -07:00
Jacob
4f427cbe32 Merge pull request #13354 from twbs/fat-13296
fixes #13296 Dropdown disappears with right-click on Firefox
2014-04-20 12:11:25 -07:00
Chris Rebert
170ba560c2 quote attribute value in ^= selector in button.js 2014-04-19 18:53:23 -07:00
Chris Rebert
a54e6d4ea9 rename jquery.js -> jquery.min.js since it's minified 2014-04-19 18:25:40 -07:00
Chris Rebert
0aaf2cdd3a quote attribute values in selectors in JS unit tests for consistency 2014-04-19 17:45:58 -07:00
fat
f2af95353e fixes #13296 Dropdown disappears with right-click on Firefox 2014-04-15 21:52:34 -07:00
fat
cd4696f723 fixes #11099 - $.collapse() overrides the original dimension of the coll... 2014-04-15 21:16:40 -07:00
Germán M. Bravo
82b066f0a9 Wait for the expected target during a collapse
Actually wait for the collapsed item to complete. If complete is called
with other target, instead of simply returning and do nothing, wait again
until the proper target triggers the event (otherwise this leaves collapse
in a broken state).
2014-04-12 14:44:35 -05:00
XhmikosR
45b476bdbf JS: remove unused variables. 2014-04-09 10:01:48 +03:00
Collin Donahue-Oponski
d7a3771abd When opening the dropdown, focus() the dropdown-toggle BEFORE triggering 'shown.bs.dropdown'
Closes #11281 by merging it (after rebasing & resolving conflicts)
2014-04-08 22:36:21 -07:00
Chris Rebert
5ef634dab9 replace $.bind() with $.on() in unit tests; per #13272 2014-04-03 18:13:16 -07:00
XhmikosR
2b30b48894 Fix the new JSHint warnings. 2014-04-03 10:53:13 +03:00
Chris Rebert
26f6807a3d Add comments in carousel.js to clarify that "slid" is not a typo
Addresses #13248.
2014-03-31 18:09:24 -07:00
Tyler Cipriani
0907244256 Modal body shift fix for IE10/11
Closes #13103 by merging it.
2014-03-28 23:45:22 -07:00
Ashley Dawson
138af82e29 Fixed nested tab elements li activation
Added closest li instead of direct parent so that you can nest multiple elements within tabs, such as button groups
2014-03-26 22:21:54 +00:00
Jacob
b3421cf040 Merge pull request #13165 from stefanneculai/master
Fix popover when using append
2014-03-24 22:42:40 -04:00
Mark Otto
39fec66fc4 Merge branch 'master' into fat-9461 2014-03-24 19:30:17 -07:00
fat
4a2d337bf5 fixes #9461 - Make carousel ignore non-items in carousel-inner 2014-03-24 19:23:39 -07:00
Stefan Neculai
674b41dd63 Add test for popover. 2014-03-24 19:49:06 +02:00
Stefan Neculai
41628c90a2 Fix popover when using append. 2014-03-24 18:49:03 +02:00
XhmikosR
d74aee4093 tests/index.html: re-indent. 2014-03-24 09:30:44 +02:00
XhmikosR
cfb7093dc0 tests/index.html: add missing meta charset. 2014-03-24 09:28:57 +02:00
XhmikosR
58ea8a5601 Update QUnit to v1.14.0. 2014-03-24 09:28:57 +02:00
Ben Ogle
8534e12523 Add tooltip viewport option, respect bounds of the viewport 2014-03-21 11:28:13 -07:00
Chris Rebert
7cf7e42c67 Merge branch 'hnrch02-modal-toggle' 2014-03-16 20:24:59 -07:00
Heinrich Fenkart
4e4e456341 Fix #12845 - Modal#hide should only be called with an event argument
Closes #12850
2014-03-16 20:24:33 -07:00
Jacob
fa4379de08 Merge pull request #12862 from sultano/patch-1
Fixed flickering and simplified calculations
2014-03-16 20:24:21 -07:00
Zlatan Vasović
ead17b7ca6 Fix #12375: stop using document.body.scrollTop as it's deprecated in the strict mode
Closes #12377
2014-03-16 20:10:52 -07:00
Tobias Lindig
0f366e0376 correct event naming of scroll and `load' event
closes #12337
2014-03-16 19:58:12 -07:00
fat
615dcb5ca0 fixes #9855 2014-03-16 18:38:47 -07:00
Julian Thilo
6d882a6420 Fix JSHint errors
X-Ref: 8c9739d477
2014-03-14 18:16:36 +01:00
Chris Rebert
b50d4a176f Merge pull request #13060 from twbs/role-tooltip
add role="tooltip" to tooltips by default to improve accessibility
2014-03-13 21:50:01 -07:00
Jacob
905c78129f Merge pull request #11937 from IHomer/master
Fix: IE10 or lower incorrectly determines the scrollheight of the body. ...
2014-03-13 21:45:04 -07:00
Jacob
8c9739d477 Merge pull request #11453 from moodyroto/patch-1
fix scrollspy for targets within tabs
2014-03-13 21:44:05 -07:00
Chris Rebert
8a6cdff825 add role="tooltip" to tooltips by default to improve accessibility
See https://github.com/paypal/bootstrap-accessibility-plugin/blob/master/README.md#tooltip
2014-03-13 15:05:13 -07:00
Chris Rebert
6dd51fab44 fix #12771 2014-03-10 00:06:38 -07:00
XhmikosR
9d027d2bee Remove unneeded quotes. 2014-03-09 11:10:52 +02:00
fat
4d96e69a55 fixes #9836 2014-03-08 19:45:38 -08:00
fat
e9cced72fd fix #9342 2014-03-08 19:20:47 -08:00
Chris Rebert
297303a7cc use quotes around all element attr vals in JS; fixes #12946 2014-03-06 11:12:17 -08:00
XhmikosR
2545073024 Move trailing check to JSCS. 2014-02-28 17:30:08 +02:00
XhmikosR
be8f125ce6 Move camelcase check to JSCS. 2014-02-28 17:30:08 +02:00
XhmikosR
2619325626 JSCS: Use more style checks. 2014-02-28 17:30:08 +02:00
XhmikosR
d65f749390 Move the quotes check to JSCS. 2014-02-28 17:30:08 +02:00
XhmikosR
537e10033e Switch to using JSCS for the indentation check. 2014-02-28 17:30:08 +02:00
Suleman Chikhalia
f7c360d620 Fixed flickering and simplified calculations
- Removed offending line causing a flicker to the default top state
- Simplified calculation of the top offset when in the bottom state
2014-02-27 00:39:46 -08:00
XhmikosR
63031a3ca5 Bump grunt-jscs-checker. 2014-02-26 19:32:43 +02:00
jonahss
7a80b801d7 updated qunit test reporting so sauce labs can report failing tests 2014-02-21 18:54:50 -08:00
Mark Otto
70b875ceb3 Merge pull request #12761 from hnrch02/no-event-aliases
Remove event aliases from JavaScript
2014-02-21 15:14:22 -08:00
XhmikosR
25d047ded4 Merge pull request #12058 from ZDroid/uti
Remove semicolons from JS tests
2014-02-18 13:21:05 +02:00
Zlatan Vasović
a4dac463e0 Improve js/tests/index.html
- Improve comments.
- Remove `transition.js` script load as `transition.js` unit test doesn't exist.
2014-02-18 10:43:24 +01:00
Zlatan Vasović
a06e15dd36 Remove semicolons from JS tests 2014-02-17 20:56:46 +01:00
Chris Rebert
8eeab63e7e Merge pull request #12720 from twbs/reident-test-files
Reindent test files
2014-02-16 12:13:04 -08:00
Heinrich Fenkart
8a78bc065f Remove event aliases from JavaScript
Makes life for people with custom jQuery builds excluding event aliases much easier.
2014-02-16 21:00:04 +01:00
XhmikosR
5566c935f2 Merge pull request #12513 from ZDroid/jshint
Remove `curly: false` from `.jshintrc`
2014-02-16 20:45:00 +02:00
Zlatan Vasović
69cb7be07f Remove curly: false from .jshintrc 2014-02-16 19:30:02 +01:00
XhmikosR
895b0006b9 Re-indent test files. 2014-02-14 11:02:03 +02:00
Mark Otto
88fdd45427 v3.1.1 bump 2014-02-13 01:12:26 -08:00
XhmikosR
8939268a33 Update jQuery to v1.11.0.
Also, use Google's CDN per #11369.
2014-01-30 20:50:17 +02:00
Mark Otto
1409cde7e8 Bump versions, run grunt 2014-01-30 08:30:37 -08:00
Tobias Lindig
084f0fb113 add namespace .bs also to the event dismiss.modal 2014-01-17 12:16:53 -08:00
Tobias Lindig
7fab3c30f2 remove needless space character 2014-01-17 13:34:03 +01:00
Chris Rebert
6af0013ac5 Revert "Add tooltip viewport option, respect bounds of the viewport"
This reverts commit edb221a20c.
Reverting due to broken JS unit tests.

Conflicts:
	docs/javascript.html
2014-01-16 20:32:59 -08:00
Mark Otto
03f4534307 Merge branch 'bo-tooltip-viewport' of https://github.com/benogle/bootstrap into benogle-bo-tooltip-viewport
Conflicts:
	docs/javascript.html
2014-01-16 20:01:28 -08:00
fat
4bd6a52562 add missing paren 2014-01-16 14:28:21 -08:00
fat
82ff4e2e40 tooltip subpixel test fixes 2014-01-16 14:25:28 -08:00
fat
3b2418e688 remove flaky pos bottom test which is effect by unit scroll pos 2014-01-16 13:44:08 -08:00
fat
2f76821a4d new qunit 2014-01-16 13:33:09 -08:00
Islam Sharabash
ad64b0acc8 Fixing js error in IE9 where no transition is supported 2014-01-16 10:11:59 -08:00
Chris Rebert
b260d93c58 more detailed QUnit test results in Sauce 2014-01-14 20:21:15 -08:00
Ben Ogle
edb221a20c Add tooltip viewport option, respect bounds of the viewport 2014-01-14 17:42:29 -08:00
Chris Rebert
dde38280f7 upgrade to QUnit v1.0.0 2014-01-13 19:21:07 -08:00
Chris Rebert
bfe74f7b2f Revert accidental overzealousness from 16eccc43d9
Let's not confuse the archaeologists & historians.
2014-01-13 19:09:51 -08:00
Chris Rebert
c9ba678b9f JSCS can be dumb sometimes 2014-01-08 12:37:10 -08:00
Chris Rebert
5f328dce88 Merge pull request #12057 from ZDroid/nl
'use strict' on new line
2014-01-07 00:31:27 -08:00
Julian Thilo
7fcfe61f4d Update copyright notices in all places
- Implements new format "Copyright 2011-xxxx Twitter, Inc.", which resonates well with our History page and more accurately reflects the copyright status of the repo
- grunt dist to update all the files
2014-01-07 01:05:24 +01:00
Kevin Sawicki
5141e4da10 Use $ instead of jQuery 2014-01-03 14:39:18 -08:00
Zlatan Vasović
0f060e7bc4 'use strict' on new line 2014-01-01 15:42:41 +01:00
Zlatan Vasović
1c83d68ca4 New Year 2014-01-01 15:37:08 +01:00
fat
2a0b99104c Merge branch 'dropdown-aria-roles' of git://github.com/plumlee/bootstrap into plumlee-dropdown-aria-roles
Conflicts:
	js/dropdown.js
2013-12-29 19:23:15 -08:00
fat
8a62f21113 fixes #11379 - Fix carousel this.sliding not getting reset if $next.hasClass('active') 2013-12-29 19:01:32 -08:00
fat
76f0d0ff32 fixes #11373 - adds related target to dropdown events 2013-12-29 18:57:22 -08:00
fat
162d9e1776 Merge branch 'scrollspy-speedy-scroll-top' of git://github.com/ziogaschr/bootstrap into ziogaschr-scrollspy-speedy-scroll-top
Conflicts:
	dist/js/bootstrap.min.js
2013-12-29 18:04:43 -08:00
fat
9d73d9c38c Merge branch 'master' of github.com:twbs/bootstrap 2013-12-29 17:54:40 -08:00
fat
ce4a2e4352 fixes #11288 - Vertical scroll position of modal saves between openings 2013-12-29 17:53:59 -08:00
Jacob
ea40e7999d Merge pull request #11203 from jasny/patch-1
Scrollspy acting up when targets are hidden
2013-12-28 22:06:26 -08:00
fat
5bf13914e4 fixes #10658 jQuery Popover content loses bound events on second setContent call. 2013-12-28 20:59:45 -08:00
fat
c595db19ff fixes #10911 - add loading event for use with remote option :| 2013-12-26 20:26:27 -08:00
fat
d21369c1ed fixes #10890 2013-12-26 19:40:18 -08:00
fat
3c73904e17 update tool/pop destroy placement 2013-12-26 18:27:43 -08:00
Jacob
6baf266cda Merge pull request #10761 from jochenberger/dont-create-tooltip-for-destroy
don't create new Tooltip/Popover objects just to destroy them immediately
2013-12-26 18:25:29 -08:00
fat
39091b0748 nope 2013-12-26 18:18:53 -08:00
Jacob
bf3c525d05 Merge pull request #11496 from satazor/patch-1
Clear timeout on destroy.
2013-12-26 18:18:09 -08:00
fat
34fb5767cb fixes #10798 2013-12-26 17:53:31 -08:00
Jacob
37bfd8fa60 Merge pull request #10801 from Travesty3/master
Add 'collapse' class back after expanding
2013-12-26 17:50:41 -08:00
Jacob
bea46fca70 Merge pull request #10834 from Prinzhorn/master
Only preventDefault on click on [data-toggle="modal"] when the element is a link
2013-12-26 17:46:59 -08:00
Mark Otto
d8e4c1578d Merge pull request #12010 from ZDroid/wrong-indent
Fix wrong indent in .jscs.json
2013-12-26 12:54:23 -08:00
fat
fc7049b18f fixes #10675 2013-12-25 20:33:05 -08:00
fat
c25fa0661a Merge branch 'tooltip-events-fix' of git://github.com/lukaszfiszer/bootstrap into lukaszfiszer-tooltip-events-fix
Conflicts:
	js/tooltip.js
2013-12-25 20:03:28 -08:00
Zlatan Vasović
1e05029d1a Fix wrong indent in .jscs.json 2013-12-25 20:22:52 +01:00
fat
dffd4ffad2 Merge branch 'master' of github.com:twbs/bootstrap 2013-12-24 17:00:55 -08:00
fat
394e0fa611 fixes #11788 - focusin focusout instead of focus/blur 2013-12-24 17:00:34 -08:00
Jacob
0fab6e7ea7 Merge pull request #11722 from DocX/patch-1
Use document scroll height instead of offset height
2013-12-24 16:43:24 -08:00
fat
c77740bd3a fixes #11720 - Add events trigger to affix 2013-12-24 16:29:51 -08:00
Jacob
139b395dfb Merge pull request #10359 from ixti/patch-1
Pass $element to offset top/bottom calc funcs
2013-12-24 13:21:19 -08:00
fat
a93a753c7d fixes #10134 – dont use jquery offset directly because it uses sub pixel rendering 2013-12-24 13:07:42 -08:00
fat
fe7fffe034 Merge branch 'slide-event-reset' of git://github.com/Rowno/bootstrap into Rowno-slide-event-reset
Conflicts:
	js/tests/unit/carousel.js
2013-12-24 12:50:55 -08:00
fat
0a75e4c09b fixes #10283 2013-12-24 12:40:24 -08:00
fat
558b6a478d Merge branch 'master' of github.com:twbs/bootstrap
Conflicts:
	dist/js/bootstrap.min.js
	docs-assets/js/raw-files.js
2013-12-24 12:35:24 -08:00
fat
50bd4edb8c fixes #10236
if affixed top add scrollTop to it position.top
calculate and cache pinnedoffset independent of scrolling for initial load
2013-12-24 12:32:06 -08:00
Mark Otto
5c2dfbf33b Merge branch 'master' of github.com:twbs/bootstrap
Conflicts:
	docs-assets/js/raw-files.js
2013-12-24 12:17:48 -08:00
Mark Otto
679c786237 roll back version numbers to avoid broken links in docs and readme (fixes #12000) 2013-12-24 12:16:17 -08:00
fat
fe839e6e78 change where modal loads content -– fixes #10105, #9318, #9459 2013-12-23 23:30:06 -08:00
fat
1fc08c1973 fixes #10568 - kill hoverstate info once command has been executed 2013-12-23 22:57:39 -08:00
fat
a87b150bc7 fixes #10205 Scrollspy Doesn't Support Chinese ID Targets http://mathiasbynens.be/notes/html5-id-class 2013-12-23 22:08:43 -08:00
Mark Otto
45a8a9508e Merge pull request #11974 from XhmikosR/meta
Normalize meta
2013-12-22 22:20:23 -08:00
XhmikosR
a05a11e5dc Get rid of JSHint's laxcomma option now that the comma is used on the right side. 2013-12-22 09:02:08 +02:00
XhmikosR
6e3ac8f2a4 js/.jscs.json: sort by name. 2013-12-22 08:59:36 +02:00
Zlatan Vasović
1bf5abab31 No leading pluses 2013-12-19 15:32:37 +01:00
joep.joosten@ihomer.nl
1ceab8b89f Fix: IE10 or lower incorrectly determines the scrollheight of the body. Use document.documentElement for IE. To make this browser agnostic, the maximum scrollheight of both body and documentElement is used. 2013-12-19 12:41:33 +01:00