GeoSot
a6a2d1e2df
Regression on tooltip template creation process. ( #34628 )
...
* Regression on tooltip template creation process.
* check if template content does not exist, or given argument is empty
* call `setContent()` once.
2021-08-03 11:59:33 +03:00
XhmikosR
23fd488c38
Add missing newlines around fenced codeblocks ( #34630 )
2021-07-30 08:56:36 +03:00
XhmikosR
742269a734
tooltip: move repeated strings to constants ( #34619 )
2021-07-30 00:32:07 +02:00
XhmikosR
6d707f4801
Enable a few eslint-config-xo rules ( #34620 )
...
* unicorn/prefer-dom-node-append
* unicorn/prefer-dom-node-remove
2021-07-30 00:23:00 +02:00
GeoSot
2bf32ad180
transfer interface
inside jQueryInterface
2021-07-29 16:30:02 +03:00
GeoSot
e5b606d242
simplify initialization on data-toggle
click
2021-07-29 16:30:02 +03:00
GeoSot
6f17e634ce
keep parent only as element
2021-07-29 16:30:02 +03:00
GeoSot
4c1f7bb051
remove duplicated Selector.find
2021-07-29 16:30:02 +03:00
GeoSot
7a71703fd3
Simplify check for children
2021-07-29 16:30:02 +03:00
GeoSot
8fc4f3aaf3
initialize variable properly
2021-07-29 16:30:02 +03:00
GeoSot
1947ca033e
Refactor internal function to use it in more cases.
...
Also, remove a few redundant checks since we already check for it in `_addAriaAndCollapsedClass()`.
2021-07-29 16:30:02 +03:00
GeoSot
5882d5dbe8
Add a helper function to check for showing
...
Also, remove the `isTransitioning()` helper.
2021-07-29 16:30:02 +03:00
GeoSot
4961ad0c63
Remove redundant check on data-toggle
click.
...
Previously, it was assumed that the trigger element would have its own separate config than the collapse element itself.
2021-07-29 16:30:02 +03:00
GeoSot
2ad0a4a9fd
streamline _getConfig
& interface
2021-07-29 16:30:02 +03:00
XhmikosR
c6c0bbb0b6
Collapse page: add a link to the accordion page ( #34605 )
2021-07-29 06:39:12 +03:00
Mark Otto
906a990eb7
Revert "Allow individual grid classes to override .row-cols
( #33621 )" ( #34612 )
...
This reverts commit f2b47e1c8a
.
2021-07-29 06:29:46 +03:00
GeoSot
4bfd8a2cbc
Use a streamlined way to trigger component dismiss ( #34170 )
...
* use a streamlined way to trigger component dismiss
* add documentation
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-28 17:39:32 +03:00
alpadev
047145e808
Fix Manipulator.offset()
( #33603 )
...
* test: add more test cases for Manipulator.offset()
* fix: Manipulator.offset() is using obsolete properties to get scroll position
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: GeoSot <geo.sotis@gmail.com>
2021-07-28 17:23:32 +03:00
Mark Young
24e14c36e8
Correct Toast docs ( #34604 )
...
Removes incorrect references to scrollspy in Toasts documentation
2021-07-28 16:17:24 +03:00
Andrew Pucci
fd9285bc9c
Make text decoration consistent with other anchors ( #34475 )
...
Fixes #34474
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-28 16:00:10 +03:00
XhmikosR
a389cb443e
Update devDependencies ( #34585 )
...
* @rollup/plugin-commonjs ^19.0.1 → ^19.0.2
* @rollup/plugin-node-resolve ^13.0.2 → ^13.0.4
* postcss ^8.3.5 → ^8.3.6
* rollup ^2.53.3 → ^2.55.0
* sass ^1.35.2 → ^1.36.0
2021-07-28 15:55:42 +03:00
Mark Otto
8513c69385
Document change to hr in v5 ( #34574 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-27 08:25:07 +03:00
Mark Otto
f41bf2f7c5
Rename Build Tools page to Contribute ( #34578 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-27 08:14:24 +03:00
Ryan Berliner
7646f6bd33
Add shift-tab keyboard support for dialogs (modal & Offcanvas components) ( #33865 )
...
* consolidate dialog focus trap logic
* add shift-tab support to focustrap
* remove redundant null check of trap element
Co-authored-by: GeoSot <geo.sotis@gmail.com>
* remove area support forom focusableChildren
* fix no expectations warning in focustrap tests
Co-authored-by: GeoSot <geo.sotis@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-27 08:01:04 +03:00
Gaël Poupard
8536474583
More concise improvements for add()
and subtract()
( #34432 )
2021-07-27 07:48:08 +03:00
Mark Otto
d140981fdb
Make note of _root.scss being required
2021-07-26 17:28:06 -05:00
Mark Otto
e208774fc1
Clean up a couple CSS Grid issues ( #34572 )
...
- Moves the make-cssgrid() mixin to the grid mixins stylesheet
- Updates the g-start-* classes to start at 1 instead of 0 as 0 is an invalid value (fixes #34399 )
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-26 18:45:10 +03:00
Mark Otto
905db7dadb
Update the custom Sass import docs ( #34573 )
...
Now includes mentino of the two utilities stylesheets, plus how and why to include the API stylesheet last
Fixes #34397
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-26 18:41:43 +03:00
Jitan Gupta
e805a5e287
Update nav-tab.md
...
Updated the from anchor tag to button in sample examples
2021-07-26 10:07:27 -05:00
TheFakeCake
9ef7ca5156
Make default $accordion-icon-color consistent
...
Change the $accordion-icon-color variable default value to
$accordion-button-color
2021-07-25 21:06:42 -05:00
XhmikosR
dd303fa971
docs: minor image compression improvements ( #34557 )
...
Before: 121 KB (124.549 bytes)
After: 121 KB (124.367 bytes)
2021-07-25 20:33:45 +03:00
Ben Koshy
2bdbb42dcf
docs: Add Github Octicons to the list ( #34526 )
...
Co-authored-by: Mark Otto <otto@github.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-22 18:29:47 +03:00
GeoSot
41292a5257
Toasts: Change showing timings and classes to keep toast display:none
by default ( #33610 )
2021-07-22 18:13:13 +03:00
GeoSot
e85a6ed77c
make dataApiKeydownHandler
to handle specific instance, avoiding extra manipulations
2021-07-22 17:54:48 +03:00
GeoSot
9916191311
extract createPopper method
2021-07-22 17:54:48 +03:00
GeoSot
b1dad0943f
handle click event in one place, remove undocumented click listener on element in case of not having the proper markup
2021-07-22 17:54:48 +03:00
GeoSot
d01a08547d
use classList add
instead of toggle
on show
2021-07-22 17:54:48 +03:00
GeoSot
d130b00cad
simplify toggle
2021-07-22 17:54:48 +03:00
GeoSot
3533e2d637
Merge dropdownInterface
to jQueryInterface
2021-07-22 17:54:48 +03:00
GeoSot
d3c6f25fd0
Add isShown
method and reuse it
2021-07-22 17:54:48 +03:00
GeoSot
da2db218ed
Use on private method to set content & cleanup template
2021-07-22 17:20:38 +03:00
GeoSot
9c3ceaa25b
popover: Move common code in tooltip's getTipElement()
2021-07-22 17:20:38 +03:00
GeoSot
a97fd1cd24
use one private method to resolve string or function
2021-07-22 17:20:38 +03:00
GeoSot
3716603dbc
Use getOrCreateInstance
on _initializeOnDelegatedTarget
2021-07-22 17:20:38 +03:00
GeoSot
92c7056619
_getDelegateConfig()
: add a comment and remove an unneeded config check
2021-07-22 17:20:38 +03:00
GeoSot
c4e189df40
use a class private getter to decouple same methods usage
2021-07-22 17:20:38 +03:00
XhmikosR
75b2934596
Update devDependencies ( #34552 )
...
* @babel/cli ^7.14.5 → ^7.14.8
* @babel/core ^7.14.6 → ^7.14.8
* @babel/preset-env ^7.14.7 → ^7.14.8
* eslint-config-xo ^0.36.0 → ^0.37.0
* eslint-plugin-unicorn ^31.0.0 → ^34.0.1
* hugo-bin ^0.73.0 → ^0.74.0
2021-07-21 15:57:47 +03:00
dependabot[bot]
3e01830d92
Bump rollup from 2.53.2 to 2.53.3 ( #34548 )
...
Bumps [rollup](https://github.com/rollup/rollup ) from 2.53.2 to 2.53.3.
- [Release notes](https://github.com/rollup/rollup/releases )
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rollup/rollup/compare/v2.53.2...v2.53.3 )
---
updated-dependencies:
- dependency-name: rollup
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-07-21 14:06:40 +03:00
Ryan Berliner
119cfc3dfe
Remove whitespace at beginning of util/index.js ( #34545 )
2021-07-21 07:49:55 +03:00
GeoSot
5541179b38
Fix Util.reflow
function and add documentation ( #34543 )
...
* add documentation to reflow function
* refactor to void as it should be
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-20 17:20:43 +03:00