GeoSot
cb8726d9e7
Dropdown: use a better selector to avoid triggering click if button is disabled ( #35866 )
2022-02-19 16:22:32 +02:00
GeoSot
353ad45b4b
Dropdown: use a combined selector to filter foreign not shown instances iteration ( #35766 )
2022-02-19 16:16:51 +02:00
GeoSot
c44d99f55c
Dropdown: use destructured variables in dataApyKeydownHandler
2022-02-01 08:58:46 +02:00
GeoSot
c14fc989df
Dropdown: dropdown doesn't document data-bs-target option & parentNode is ALWAYS the wrapper for toggle & menu
2022-02-01 08:58:46 +02:00
GeoSot
d105439235
Dropdown: merge instance identification in dataApiKeydownHandler
...
As we use the `dataApiKeydownHandler` only for events that are triggered on `[data-bs-toggle="dropdown"]` or on `.dropdown-menu`, we can ensure that their `parentNode` will ALWAYS be the `.dropdown` wrapper
2022-02-01 08:58:46 +02:00
GeoSot
7f04f84bf8
Dropdown: use only one check for shown state
2022-01-30 18:01:09 +02:00
GeoSot
5f1c542d67
Dropdown: get dropdown's parent in one place
2022-01-30 18:01:09 +02:00
XhmikosR
7d3bc44bb0
dropdown: Move constant
2022-01-29 13:25:30 +02:00
XhmikosR
62d86c07f8
Rename variables
2022-01-29 13:25:30 +02:00
GeoSot
886b940796
Extract Component config functionality to a separate class ( #33872 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-10 18:18:18 +02:00
GeoSot
c376cb0763
Dropdown: fix toggle focus after dropdown is hidden using the ESC button ( #35500 )
2021-12-09 15:34:17 +02:00
GeoSot
dd07c1ff9e
Dropdown: clearMenus is always an event callback
2021-12-01 17:10:39 +02:00
GeoSot
f71640f048
Dropdown: Clean more
2021-12-01 17:10:39 +02:00
GeoSot
21e5618ba7
Dropdown: rename vars
2021-12-01 17:10:39 +02:00
GeoSot
0686fa00f0
Dropdown: Remove redundant Space check
2021-12-01 17:10:39 +02:00
GeoSot
a14a552d83
Dropdown: Deduplicate complex check
2021-12-01 17:10:39 +02:00
GeoSot
bff95d55af
Dropdown: Remove redundant check since the show method already does it
2021-12-01 17:10:39 +02:00
GeoSot
2d32802f53
Dropdown: Change constant to the way we use it
2021-12-01 17:10:39 +02:00
GeoSot
fb5921dec4
Dropdown: Merge display='static' & isNavbar functionality activating static popper with no styles attached
2021-12-01 17:10:39 +02:00
GeoSot
137b324930
Dropdown: Remove static method used once
2021-12-01 17:10:39 +02:00
XhmikosR
e8f702666f
JS: minor refactoring ( #35183 )
...
* add missing comments
* shorten block comments
* reorder constants
* reorder public/private methods
* sort exports alphabetically in util/index.js
* fix a couple of typos
2021-10-13 15:19:28 +03:00
XhmikosR
c44d64ed71
Merge remote-tracking branch 'remotes/origin/v513'
2021-10-09 18:28:28 +03:00
XhmikosR
1a6fdfae6b
Bump version to 5.1.3.
2021-10-09 09:43:19 +03:00
XhmikosR
567a41347e
Fix a unicorn/no-array-callback-reference issue
2021-10-05 19:52:11 +03:00
XhmikosR
666fe596bf
Enable unicorn/no-array-for-each rule
2021-10-05 19:52:11 +03:00
XhmikosR
2b4d0d166b
Enable unicorn/no-for-loop rule
2021-10-05 19:52:11 +03:00
XhmikosR
5ecef8ac01
Release v5.1.2 ( #35114 )
2021-10-05 18:50:18 +03:00
XhmikosR
0d81d3cbc1
Release v5.1.1 ( #34869 )
...
* Prepare v5.1.1.
* Dist
2021-09-07 18:37:44 +03:00
XhmikosR
f20fece3a8
Prepare v5.1.0. ( #34674 )
2021-08-04 18:41:51 +03:00
GeoSot
e85a6ed77c
make dataApiKeydownHandler to handle specific instance, avoiding extra manipulations
2021-07-22 17:54:48 +03:00
GeoSot
9916191311
extract createPopper method
2021-07-22 17:54:48 +03:00
GeoSot
b1dad0943f
handle click event in one place, remove undocumented click listener on element in case of not having the proper markup
2021-07-22 17:54:48 +03:00
GeoSot
d01a08547d
use classList add instead of toggle on show
2021-07-22 17:54:48 +03:00
GeoSot
d130b00cad
simplify toggle
2021-07-22 17:54:48 +03:00
GeoSot
3533e2d637
Merge dropdownInterface to jQueryInterface
2021-07-22 17:54:48 +03:00
GeoSot
d3c6f25fd0
Add isShown method and reuse it
2021-07-22 17:54:48 +03:00
XhmikosR
688bce4fa6
Release v5.0.2 ( #34276 )
...
* Bump version to v5.0.2.
* Dist
2021-06-22 21:29:16 +03:00
GeoSot
c98657b830
Add getOrCreateInstance method in base-component ( #33276 )
...
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-06-03 18:53:27 +03:00
alpadev
b39b665072
Automatically select an item in the dropdown when using arrow keys ( #34052 )
2021-05-22 10:58:52 +03:00
GeoSot
df72a21fa8
Add getNextActiveElement helper function to utils, replacing custom implementation through components ( #33608 )
2021-05-19 01:23:52 +03:00
XhmikosR
58b1be927f
Release v5.0.1 ( #33972 )
...
* Bump version to 5.0.1.
* Dist
2021-05-13 19:22:20 +03:00
GeoSot
6e1c9096f0
Move get element functionality to a helper ( #33327 )
...
Looking around on js components I found out many checks, different expressed but with same purpose.
Some of them are trying to parse string to element, others, jQuery element to js simple nodeElement etc
With this Pr, I am trying to give a standard way to parse an element
So this pr:
* Creates `getElement` helper that tries to parse an argument to element or null
* Changes `isElement` to make explicit checks and return Boolean
* fixes tests deficiencies
2021-05-13 18:17:20 +03:00
GeoSot
9fe36edf68
Extract static DATA_KEY & EVENT_KEY to base-component ( #33635 )
...
* Force each plugin that extends base-components to implement a static method `NAME()`
* Remove redundant `NAME` argument from 'Utils.defineJQueryPlugin' & fix test
2021-05-11 10:49:30 +03:00
alpadev
7647b8fe5b
Fix: Click on input outside of dropdown-menu prevents dropdown from closing ( #33920 )
...
* test: add test if user clicks on input not contained within dropdown-menu
* fix: click on inputs that are not contained within dropdown-menu prevent dropdown from closing
2021-05-11 09:09:00 +03:00
GeoSot
03842b5f25
Refactor: move disposing properties into the base class ( #33740 )
...
Moves more functionality to `base-component`, transferring the responsibility of disposal to parent class.
Each component, dusting disposal, sets its protected properties to `null`. So the same can be done in one place for all children components .
2021-05-11 09:04:42 +03:00
XhmikosR
bf09367486
Release v5.0.0 ( #33647 )
...
* Bump version to 5.0.0
* Fix npm tag
* Dist
2021-05-05 22:32:12 +03:00
Rohit Sharma
b59b75bc55
Dropdown — Add option to make the dropdown menu clickable ( #33389 )
2021-04-20 08:19:57 +03:00
alpadev
6d312b37c2
fix: clicking an item in navbar dropdown collapses the dropdown in firefox ( #33643 )
2021-04-18 09:01:23 +03:00
Rohit Sharma
7eadf73f03
Change toggle method to remove
...
Since the class `.show` must be removed
2021-04-18 08:47:50 +03:00
Rohit Sharma
bce4684d34
Use context properties
2021-04-18 08:47:50 +03:00
