Patrick H. Lauke
3275ca4b30
Reword "mobile" to "touch-enabled"
...
...as touch is not exclusive to "mobile" anymore nowadays. also explicitly clarifies this is a fix for iOS, and that it impacts touch laptops etc as well. lastly, renames the variable from "dropdown" to "backdrop" for clarity/consistency
2017-04-12 18:39:23 +01:00
Pierre Vanduynslager
208e0384df
Merge branch 'v4-dev' into dropdown-keyboard
2017-04-12 10:36:14 -04:00
Pierre-Denis Vanduynslager
81e12d5715
Indent
2017-04-12 09:41:27 -04:00
Patrick H. Lauke
53b2c5520b
Remove inappropriate role="listbox" from carousels
2017-04-11 11:12:30 +01:00
Pierre Vanduynslager
025ddb185e
Merge branch 'v4-dev' into dropdown-keyboard
2017-04-10 11:04:05 -04:00
Patrick H. Lauke
18e8704221
Fix collapse.js aria-expanded behavior
...
* Remove aria-expanded from collapse.js target element
aria-expanded="true"/aria-expanded="false" only applies to the trigger,
not the element that is being expanded/collapsed.
* Tweak collapse.js accessibility section
...to make it clearer that the aria-expanded attribute always just goes
on the control.
* Fix collapse.js unit tests
- reword some of the text to make it clear we're checking behavior of
trigger/control
- move incorrect aria-expanded out of the <div>s and to the actual
trigger/control <a>s
- fix incorrect test assertion text output false -> true
2017-04-10 14:51:22 +01:00
Patrick H. Lauke
3f6e1faf45
Only change aria-pressed if it's not an input-based radio or checkbox group
...
* Only change aria-pressed if it's not an input-based radio or checkbox group
aria-pressed="true"/aria-pressed="false" is really only useful for
making on/off toggles out of, say, `<button>` elements. the attribute is
useless (and potentially confusing/conflicting) on, say, `<label>`
elements for an existing `<input type="radio">` or similar.
* Add unit test for buttons.js and radio/checkbox inputs in button groups
2017-04-10 14:43:54 +01:00
Pierre Vanduynslager
d3fbebefcd
Merge branch 'v4-dev' into dropdown-keyboard
2017-04-09 18:16:37 -04:00
Patrick H. Lauke
2626eba5f1
Prevent default for ESC in modal.js
...
ESC can be used to close modals, but on OS X/macOS this also jumps out
of full-screen mode. `preventDefault` suppresses this.
2017-04-09 16:19:20 +01:00
Pierre Vanduynslager
fe72daf2b3
Merge branch 'v4-dev' into dropdown-keyboard
2017-04-08 18:43:25 -04:00
Mark Otto
364e01885f
grunt
2017-04-08 13:22:53 -07:00
Ilias
e6e070b02a
Fix #22332 : Adjust tests for hidden scrollbar
2017-04-03 13:27:15 +02:00
Mark Otto
7d88f365c0
Merge branch 'v4-dev' of https://github.com/twbs/bootstrap into v4-dev
2017-04-02 12:00:52 -07:00
Ilias
a14451deb3
Fix #18373 : properly adjust padding-right of body and fixed elements when opening or closing modal
2017-04-02 13:26:25 +02:00
Pierre Vanduynslager
91b62941af
Tabs/Scrollspy/.nav/.list-group/.active independent of markup (<nav>, .nav-item, <li> etc...)
2017-04-02 11:21:04 +02:00
Mark Otto
49b6cf845d
grunt
2017-04-01 19:18:29 -07:00
Johann-S
5142de7e59
Popover + Tooltip - fix error when content or title is a number
2017-03-31 10:03:54 +02:00
Johann-S
fb42d6e043
Collapse - Fix check to not prevent event for input and textarea
2017-03-29 00:10:27 +02:00
Pierre Vanduynslager
48c5efa4c3
Fix JS components console error "Error: <Component> is transitioning"
2017-03-28 23:43:15 +02:00
Mark Otto
cf7d3e11e0
grunt
2017-03-28 09:31:32 -07:00
Johann
904efc043d
Fix different tooltips offset when hovering
2017-03-28 15:55:03 +02:00
Mark Otto
7742ba6dc9
grunt
2017-03-27 22:56:14 -07:00
Johann
24924c23b2
Collapse - do not prevent event for input and textarea
2017-03-27 10:08:39 +02:00
Mark Otto
4ab06ca453
grunt
2017-03-26 11:26:31 -07:00
Mark Otto
90c5f6230b
rename from .navbar-toggleable to .navbar-expand to reflect mobile first approach everywhere else
2017-03-23 23:02:28 -07:00
Mark Otto
11ba308b2f
more docs updates
2017-03-23 23:02:28 -07:00
Johann
3f247a42f2
Fix Modal documentation about _handleUpdate method + move to public scope ( #21877 )
...
Fix Modal documentation about _handleUpdate method + move to public scope
2017-03-23 22:22:09 +01:00
Pierre Vanduynslager
37f438910f
Accordion behavior with JQuery interface ( #21726 )
...
Fix accordion behavior with JQuery interface
2017-03-23 21:15:41 +01:00
Johann
c72a315740
Carousel - Add attributes from and to for Slid and Slide events ( #21668 )
...
Carousel - Add attributes from and to for Slid and Slide events
2017-03-22 22:42:13 +01:00
Pierre Vanduynslager
78fc4d23fc
Always append element to fixture in Scrollspy unit tests ( #22234 )
2017-03-21 10:21:00 -07:00
Bardi Harborow
cab6f7d16c
More config tweaks.
2017-03-21 21:37:33 +11:00
Bardi Harborow
09fb2b9af3
Update dependencies.
2017-03-20 17:37:05 +11:00
Mark Otto
e506e59c45
grunt
2017-03-19 19:03:32 -07:00
Mark Otto
3730c5dbf5
Merge branch 'collapse' of https://github.com/Johann-S/bootstrap into Johann-S-collapse
2017-03-19 18:43:13 -07:00
Pierre-Denis Vanduynslager
f5cc591456
Merge branch 'twbs/v4-dev' into dropdown-keyboard
2017-03-18 22:08:55 -04:00
Mark Otto
ae50bb7845
grunt
2017-03-18 18:47:57 -07:00
Pierre Vanduynslager
275821bbb0
HTMLElement.offset* by getBoundingClientRect() ( #21788 )
...
* Replace element.offet* by getBoundingClientRect()
* Use variable to store BoundingClientRect
* Fix cc issue...
2017-03-18 18:24:54 -07:00
Johann
f2f2e39a45
Fix getSelectorFromElement when # is a selector ( #21615 )
...
* Fix getSelectorFromElement when # is a selector
* Thanks to @vanduynslagerp remove regex to validate selector
2017-03-18 17:42:11 -07:00
Pierre Vanduynslager
f2f8051285
Fix backdrop for dropdown menu on mobile ( #21578 )
...
- Create backdrop only if the menu is actually open (do not create it if the show event is prevented)
- Drop the backdrop only when the corresponding menu is closed (do not remove if there is no menu to close or if the hide event is prevented)
2017-03-18 17:41:13 -07:00
Mark Otto
5a5ab4c0de
grunt
2017-03-18 16:51:32 -07:00
Johann
1a46d8c730
Allow to use Tab.js with list-group ( #21756 )
...
* Allow to use Tab.js with list-group
* Allow to use list-group with div parent instead of an ul parent
2017-03-18 16:36:33 -07:00
Bardi Harborow
84ce248f06
Update config files across the board.
2017-03-12 16:15:00 +11:00
Johann-S
21b537cc24
Add unit test
2017-03-09 11:08:47 +01:00
Johann-S
fa1504e6f6
Fix code style
2017-03-08 11:15:58 +01:00
Johann-S
099486f294
Detach accordions from .card
2017-03-07 10:46:08 +01:00
Bardi Harborow
6593b15555
Refactor QUnit test page.
2017-02-22 11:14:47 +11:00
Pierre-Denis Vanduynslager
4ab576a419
Fixes #21941
2017-02-08 18:51:50 -05:00
Bardi Harborow
cb87eebcbb
Update dependencies.
2017-02-05 23:50:06 +11:00
Pierre-Denis Vanduynslager
403f55fba9
Fix spacebar key in Firefox for button elements
2017-01-22 17:34:54 -05:00
Pierre-Denis Vanduynslager
1cdd0d16c1
Merge branch 'twbs/v4-dev' into dropdown-keyboard
2017-01-22 17:32:50 -05:00
Mark Otto
deb1c59c53
grunt
2017-01-21 17:50:45 -08:00
Pierre-Denis Vanduynslager
ef2181ff4d
Harmonize document.activeElement comparison
2017-01-20 23:22:50 -05:00
Pierre-Denis Vanduynslager
4448ca057b
Refactor test to event and async
2017-01-20 23:02:45 -05:00
Pierre-Denis Vanduynslager
1a783a4255
Add unit test for keyboard navigation
2017-01-20 23:02:19 -05:00
Pierre-Denis Vanduynslager
59f438b40e
Merge branch 'twbs/v4-dev' into dropdown-keyboard
2017-01-20 20:27:17 -05:00
Pierre-Denis Vanduynslager
9daf681478
Fix test to retrieve the proper item instead of it's parent
2017-01-20 20:27:14 -05:00
Pierre-Denis Vanduynslager
57713c9fc5
Fix missing closing tag
2017-01-18 15:01:06 -05:00
Pierre-Denis Vanduynslager
a85b80fa75
Merge branch 'twbs/v4-dev' into dropdown-keyboard
2017-01-15 10:33:54 -05:00
Pierre-Denis Vanduynslager
8fbd4aaa38
Correct reference to Direction.PREV constant. ( #21709 )
2017-01-15 13:46:03 +11:00
Pierre-Denis Vanduynslager
c80e13a48a
Use existing keycode constants in dropdown. ( #21697 )
2017-01-15 13:42:24 +11:00
Patrick H. Lauke
6b48ba4e0d
Remove incorrect aria-multiselectable
...
Closes https://github.com/twbs/bootstrap/issues/21635
2017-01-11 23:57:59 +00:00
Pierre-Denis Vanduynslager
4c2f544359
Merge branch 'twbs/v4-dev' into dropdown-keyboard
2017-01-06 15:57:15 -05:00
Pierre-Denis Vanduynslager
eb84c03ddf
Update dropdown unit test to new markup
2017-01-06 15:56:38 -05:00
Mark Otto
d2fbf58546
grunt
2017-01-06 08:39:56 -08:00
Mark Otto
045888fa38
version bump
2017-01-06 08:38:04 -08:00
Mark Otto
43d9391fba
grunt
2017-01-05 14:51:14 -08:00
Patrick H. Lauke
85a1fdcb29
Merge pull request #21093 from Johann-S/fixButtonGrpAria
...
Close #21090 - Fix aria-pressed attribute for buttons in container with data-attribute="buttons"
2017-01-05 09:35:43 +00:00
Mark Otto
0015da793a
grunt
2017-01-04 11:59:07 -08:00
Pierre-Denis Vanduynslager
d1b742f228
Use pageYOffset instead of scrollY
2017-01-04 11:42:08 -08:00
Pierre-Denis Vanduynslager
67958f35e8
Merge conflict
2017-01-04 12:24:33 -05:00
Pierre-Denis Vanduynslager
c4867cfedb
Merge branch 'twbs/v4-dev' into dropdown-keyboard
...
# Conflicts:
# js/src/dropdown.js
2017-01-04 12:22:06 -05:00
Johann-S
0463b01282
Close #21090 - Fix aria-pressed attribute for buttons in container with data-toggle='buttons'
2017-01-04 11:02:16 +01:00
Mark Otto
56f917dd8c
grunt
2017-01-03 13:16:18 -08:00
Pierre-Denis Vanduynslager
bbb0d2b573
Dropdown: close menu when focusing outside element ( #21375 )
...
* Close dropdown menu when focusing an outside element
* Update unit test to new markup
2017-01-02 14:44:27 -08:00
Mark Otto
9fc54f89f4
grunt
2017-01-02 11:54:28 -08:00
Mark Otto
c61a0059ad
update seletors in js
2017-01-02 11:52:38 -08:00
Mark Otto
20b05e42e3
update rest of docs, remove navbar specific modifiers, fix docs example css
2017-01-02 11:48:51 -08:00
Heinrich Fenkart
daff021578
grunt
2017-01-01 03:21:02 +01:00
Mark Otto
e2b6badb86
v4: Rip out IE compatibility mode meta tags ( #21483 )
...
* Remove IE compatibility mode meta tag from docs, examples, and JS tests as we no longer support IE9 and IE8
* update and remove some IE bits from our supported browser page
* update introduction.md to match
* reword starter template intro
2016-12-31 12:20:32 -08:00
Johann-S
026e1a1421
Allow to use nav with tab JS
2016-12-31 00:54:00 -08:00
Mark Otto
d935cca9f6
one more test file
2016-12-31 00:52:08 -08:00
Mark Otto
55413e109f
nuke local test vendor jquery and tether, replace with docs assets
2016-12-31 00:52:08 -08:00
Johann-S
719318f485
Update visual test carousel
2016-12-31 00:51:19 -08:00
Mark Otto
92fa9b2256
fix navbar in dropdown visual test file
2016-12-30 22:45:39 -08:00
Bardi Harborow
a8100e1f01
Extend ESLint to cover all JS files and drop JSCS.
2016-12-31 16:49:15 +11:00
Johann-S
95ce03f000
Close #21249 : Add a Unit test for #21227
2016-12-29 13:28:42 -08:00
Pierre-Denis Vanduynslager
425d156df2
Merge branch 'twbs/v4-dev' into dropdown-keyboard
2016-12-28 19:57:38 -05:00
Mark Otto
d3646e3884
grunt
2016-12-27 14:27:41 -08:00
Max Beatty
aa7f95fd77
update click state when hiding so can be shown again by trigger. fixes #16732
2016-12-27 14:19:12 -08:00
Mark Otto
0e8ee1bfba
grunt
2016-12-25 15:47:03 -08:00
Alessandro Rodi
9103bffe37
[ Fix #19849 ] Tabs are opened even if disabled. ( #20795 )
...
* [Fix #19849 ] Tabs are opened even if disabled.
* fix hund code review hints
* rollback hound issues because Travis fails
2016-12-24 23:31:34 -08:00
Mark Otto
cd18ee8af6
grunt
2016-12-24 14:29:41 -08:00
Johann-S
b0508a975d
Closes : #21412 : Fix unit test for carousel
2016-12-23 22:56:55 +11:00
Matheus Azzi
dab6a41e04
Carousel: Only prevents default for ARROW_LEFT and ARROW_RIGHT keys
...
Fixes 2 bugs:
1. All keydowns were being prevented. Because of that the user wasn't able to navigate in the whole page using ARROW_UP/ARROW_DOWN.
2. Even when is an input or textarea the keydowns were being prevented. Because of that the user wasn't able to type any text on these elements.
2016-12-23 17:55:40 +11:00
mr-july
1d6cdb65b3
scrollspy: fix wrong activation of all nested links ( #20304 )
...
* fix wrong activation of all nested links;
just first level item should be activated
* use template instead of string concatenation
2016-12-22 22:00:56 -08:00
Mark Otto
1f9619a517
Merge branch 'patch-1' of https://github.com/tracker1/bootstrap into tracker1-patch-1
2016-12-21 20:34:29 -08:00
Mark Otto
ab38529dcc
grunt
2016-12-19 21:48:24 -08:00
Mark Otto
8eeb71c91c
Merge branch 'fix-20982' of https://github.com/Starsam80/bootstrap into Starsam80-fix-20982
2016-12-19 21:44:03 -08:00
Mark Otto
cd76a6775d
grunt
2016-12-07 20:46:17 -08:00
Starsam80
d991c868a4
Fix tabs by using new classes
2016-12-07 21:20:18 -07:00