rooty/Bootstrap
0
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-15 03:24:00 +01:00
Code Issues Actions Packages Releases Activity
22,328 Commits 108 Branches 89 Tags 553 MiB
f8a56da8b0
Commit Graph

2349 Commits

Author SHA1 Message Date
David Bailey
487513ff03 Add failing test 
When the body does not overflow (achieved by hiding the QUnit container), it should not be given a margin.
 2017-08-28 16:21:04 +01:00
meeque
9612830701 Add unit test for xss in data target attribute 2017-08-25 23:20:14 +01:00
Johann-S
bcad4bcb5f Fix XSS in data-target 2017-08-25 23:20:14 +01:00
David Bailey
ba6a6f1369 Fix sticky margin when a modal is opened (#23669) 
* Adjust margin for sticky elements on modal

Previously white space was visible to the right of sticky elements due to right padding being added to the body. This fixes #23661.

* Add unit tests for margin of sticky elements on modal
 2017-08-25 22:01:41 +01:00
Johann-S
5a90b4aa3e Collapse - preventDefault only on <a> elements not inside the collapsible 
element
 2017-08-25 09:48:35 +01:00
Johann-S
4571ab0e57 Fix toggle for Tooltips/Popover which was called even if the Tooltip/Popover was disabled 2017-08-24 09:33:49 +01:00
Johann-S
6063b0dc65 Enable the no-return-assign rule. 2017-08-23 00:05:38 +03:00
XhmikosR
ef8c77d8dc Tweak ESLint rules. 2017-08-23 00:05:38 +03:00
Mark Otto
6bea2e24fe dist 2017-08-20 13:36:58 -07:00
Mark Otto
25bbfcdd7c dist 2017-08-20 12:09:33 -07:00
XhmikosR
74d96392d2 Update devDependencies and fix a typo in comment. (#23534) 2017-08-18 16:55:59 +03:00
Johann-S
58994a16c5 Add a unit test to check if the carousel do not cycle when its parent isn't visible 2017-08-17 17:48:14 +01:00
Johann-S
d2bd8fb7a9 Unit test to check if our carousel do not cycle when we cannot see it 2017-08-17 17:48:14 +01:00
Johann-S
58b54b6c15 Carousel - do not call next when the carousel or the parent isn't visible 2017-08-17 17:48:14 +01:00
Mark Otto
ca7b7cd377 dist 2017-08-14 20:23:45 -07:00
Mark Otto
2be34d5ce9 dist 2017-08-13 12:59:27 -07:00
Johann-S
2eb1e687bd Improve previous selector for nested tabs 2017-08-11 15:04:07 +03:00
Johann-S
edf90c1bc4 Add unit test for nested tabs 2017-08-11 15:04:07 +03:00
Johann-S
640c13062c When we show our tabs element use children to be more restrictive 2017-08-11 15:04:07 +03:00
XhmikosR
b55fa5579b tabs: make the active selector more restrictive again. 
When one uses say a carousel inside a tab, the `.active` selector previously matches the carousel ones too leading to broken tabs.

It's not the perfect solution but should the job for now.
 2017-08-11 15:04:07 +03:00
Mark Otto
35f80bb12e bump to beta 2017-08-10 20:56:35 -07:00
XhmikosR
88c9a1609c Fix ESLint docs errors. (#23163) 
Ignore ESLint error in ie-emulation-modes-warning.js.

Although the error is valid, enough time has been spent on old IE's problems, so just ignore it.
 2017-07-28 09:18:47 +03:00
Mark Otto
082c9d92fe dist 2017-07-16 13:11:21 -07:00
Bardi Harborow
028863dd08 Fall back to ESLint v3 indentation behaviour. 2017-07-16 13:51:16 +10:00
Bardi Harborow
d35020cee8 Update dependencies. 2017-07-16 13:51:16 +10:00
Mark Otto
2a745e54de npm build 2017-07-04 11:55:16 -07:00
Johann-S
0480a75a5a Dropdown - Disable applyStyle modifier instead of removing inline style applied by Popper.js 2017-07-04 10:37:44 +02:00
Mark Otto
93b2682880 npm build 2017-07-02 10:40:27 -07:00
Mark Otto
337ead4b27 build dist 2017-07-01 22:25:38 -07:00
Mark Otto
7f6479b0d9 build dist 2017-06-30 15:45:27 -07:00
Mark Otto
eedbe43ea7 build dist 2017-06-30 13:15:09 -07:00
Mark Otto
56d43eb3e9 Merge branch 'v4-dev' into colors-redux 2017-06-30 08:33:09 -07:00
Mark Otto
f83c981d08 build dist 2017-06-30 08:32:49 -07:00
Mark Otto
6055453e41 Merge branch 'v4-dev' into colors-redux 2017-06-29 23:15:48 -07:00
Mark Otto
f46f26bbaa build 2017-06-29 21:31:11 -07:00
Mark Otto
52cf0fe648 update instances of .bg-inverse and .bg-faded to .bg-dark and .bg-light 2017-06-25 18:31:23 -07:00
Mark Otto
36e482ed27 update navbars to rename .navbar-inverse to .navbar-dark, update all navbar examples and variables 2017-06-25 18:29:43 -07:00
Mark Otto
16d77b4cb0 build 2017-06-18 18:32:16 -07:00
Mark Otto
72a0093200 build 2017-06-18 00:14:35 -07:00
Johann-S
8170816094 Detect if the dropdown is in a navbar or not when update is called 2017-06-17 13:12:39 -07:00
Catalin Zalog
f640ec9662 Some .navbar .dropdown-menu optimisation (#22776) 2017-06-17 13:12:39 -07:00
Johann-S
af93db294b Reset Popper.js styles for Dropdowns in navbar 2017-06-17 13:12:39 -07:00
Mark Otto
ce98a1da5b build 2017-06-17 10:13:43 -07:00
Johann-S
6ed8a735d0 fix some errors in our js 2017-06-16 10:57:13 +02:00
Mark Otto
9c0e423008 Rename popover classes 
Part of an update to align the naming schemes across our components.

- Renames .popover-title to .popover-header
- Renames .popover-content to .popover-body

Refs: #22092
 2017-06-15 09:05:30 -07:00
Mark Otto
6c8c0aa4cf Rename .card-block to .card-body to match nomenclature of modals 2017-06-15 09:05:16 -07:00
Mark Otto
2e798301ca build 2017-06-14 20:44:32 -07:00
Johann-S
f0124769c9 Collapse supports multi-target thanks to @vanduynslagerp (#22713) 2017-06-14 13:21:49 +02:00
Johann-S
4a2b183e48 Fix unit tests with no assertion 2017-06-14 11:18:12 +02:00
Johann-S
1ec68d748b Upgrade QUnit to 2.3.3 2017-06-14 11:18:12 +02:00
Johann-S
2d87895089 Update path to our docs assets for visual tests 2017-06-04 11:08:31 +02:00
Mark Otto
620257456e build 2017-05-31 21:25:47 -07:00
Mark Otto
332d882cdb Merge branch 'v4-dev' into v4-docs-streamlined 2017-05-31 20:46:29 -07:00
Johann-S
5f493cfc74 Remove the use of x-arrow attribute for Tooltips/Popovers arrows 2017-05-31 09:54:58 +02:00
Mark Otto
2fd192968d Merge branch 'v4-dev' into v4-docs-streamlined 2017-05-30 23:31:40 -07:00
CDAGaming
ccd86bdc96 Update Dependencies (REUPLOAD) (#22594) 
* Update Dependencies (REUPLOAD)

Uglify-JS: 2.8.22 > 3.0.3
QUnitJS: 2.3.1 > 2.3.2
PostCSS-CLI: 3.1.1 > 4.0.0
Clean-CSS-CLI: 4.0.12 > 4.1.0
Babel-Eslint: 7.2.2 > 7.2.3
AutoPrefixer: 6.7.7 > 7.0.1

* Updates More Dependencies

Autoprefixer: v7.0.1 > v7.1.1
Clean-CSS-CLI: v4.1.0 > v4.1.3
Node-Sass: v4.5.2 > v4.5.3
PostCSS-FlexBugs-Fixes: v2.1.1 > v3.0.0
Uglify-JS: v3.0.3 > v3.0.11
Signed-off-by: CDAGaming <cstack2011@yahoo.com>

* Update Gem Bundler Dependency

Signed-off-by: CDAGaming <cstack2011@yahoo.com>

* Update Gemfile.lock Dependency

Signed-off-by: CDAGaming <cstack2011@yahoo.com>

* Update QUnit

Signed-off-by: CDAGaming <cstack2011@yahoo.com>

* Update Uglify-JS to v3.0.13

Signed-off-by: CDAGaming <cstack2011@yahoo.com>
 2017-05-30 21:11:56 -07:00
Mark Otto
73a550c7f8 update paths 2017-05-29 23:32:28 -07:00
Geremia Taglialatela
db44e4b311 Update nav and navbar HTML markup 
According to the docs, you just need to apply the `navbar-nav` to an
`<ul>` tag in a list-based navbar. In fact, `navbar-nav` seems to
override all the css properties set by `nav`.

Also, `nav-item` class should be used only for `<li>` tags, or in
conjunction with `<a>` tags to entirely avoid the list-based approach.

This commit removes the redundant `nav` class from `navbar-nav` `<ul>`
tags, moves `nav-item` from `<a>` tags to `<li>` tags and properly
adds `nav-item` class to `<li>` tags where missing.

Refs:

* https://v4-alpha.getbootstrap.com/components/navs/
* https://v4-alpha.getbootstrap.com/components/navbar/#nav
 2017-05-27 15:21:49 -07:00
Mark Otto
4282d892f3 build 2017-05-26 20:20:10 -07:00
Johann-S
4c3b6c5ceb Placement auto for popovers 2017-05-24 14:57:40 +02:00
Johann-S
2c72af88ee Placement auto for tooltips 2017-05-24 14:57:40 +02:00
Johann-S
aa36439e17 Use Popper.js to manage arrow position 2017-05-23 15:19:54 +02:00
Johann-S
70f4a30def Better management of dropdown/dropup with alignment 2017-05-22 16:14:10 +02:00
Johann-S
b36d8ae6cb Use popper to align dropdown menu instead of using css with important 2017-05-17 22:03:11 +02:00
Johann-S
3719ed4cb6 build 2017-05-16 10:09:48 +02:00
Johann-S
c78cbb275b Change fallbackPlacement to flip by default for Tooltips/Popovers 2017-05-14 11:41:19 +02:00
Johann-S
cc455c16c3 Fix bad position for Tooltips with animation at true 2017-05-14 11:41:19 +02:00
Johann-S
0cdf176f7a Use _jQueryInterface for Dropdown to call toggle method 2017-05-14 11:41:19 +02:00
Johann-S
0ae9d28ba3 Add fallbackPlacement option for Tooltip and Popover 2017-05-14 11:41:19 +02:00
Johann-S
ab7dc8ae2a Fix dropdown in scrollspy visual test (add Popper.js) 2017-05-14 11:41:19 +02:00
Johann-S
4f882a840c Allow to disable flip behaviour on Dropdown + documentation 2017-05-14 11:41:19 +02:00
Johann-S
e5a0471b0b Add an update method to allow to update position for Tooltip/Popover/Dropdown manually 2017-05-14 11:41:19 +02:00
Johann-S
fc8b85b626 Fix some css for the arrow of Popover/Tooltip + update documentation 2017-05-14 11:41:19 +02:00
Johann-S
18e4e851e2 Better placement for Dropdown + Handle flip of Tooltip/Popover 2017-05-14 11:41:19 +02:00
Johann-S
d5fabf8de5 Remove totaly Tether from documentation + dependencies 2017-05-14 11:41:19 +02:00
Johann-S
53ee455bc7 Handle dropup for Dropdown 2017-05-14 11:41:19 +02:00
Johann-S
69de65180f Fix unit tests + Update Popper to 1.6.0 2017-05-14 11:41:19 +02:00
Johann-S
c21a2b0d92 Remove constraints option and check every options 2017-05-14 11:41:19 +02:00
Johann-S
54a8ab4011 Begin to use Popper for Dropdown 2017-05-14 11:41:19 +02:00
Johann-S
d8996a7e0a Fix arrow for tooltip and popover 2017-05-14 11:41:19 +02:00
Johann-S
b40b1bc396 Add attachment classes 2017-05-14 11:41:19 +02:00
Johann-S
81e07ec052 Begin to add arrow to Popover and Tooltip 2017-05-14 11:41:19 +02:00
Johann-S
6cf0fe8780 Use Popper for tooltip and popover 2017-05-14 11:41:19 +02:00
Joyce Babu
db2db6cd0e Fix typo removeData for Tabs plugin 
Should remove `data` not `class` on dispose
 2017-04-28 15:31:35 +02:00
Anna
33715a73d2 Fix Toggle buttons don't honor [disabled] or .disabled 2017-04-26 18:46:05 +02:00
Pierre Vanduynslager
ab39defe74 Detach accordion from card without requiring 'data-children' 2017-04-25 09:32:14 +02:00
Mark Otto
ba312c20a5 build 2017-04-21 23:58:09 -07:00
Zach Leatherman
638b97f19c Arguably more professional pictures of Rick Ross 2017-04-21 20:51:35 -07:00
Bardi Harborow
2906b612d5 More minor build tweaks and docs updates. 2017-04-21 21:08:40 +10:00
Patrick H. Lauke
fb3303f5dd Fix for copy/paste error in iOS hack to tooltips 
(with apologies, this slipped through due to build system problems on my
end)
 2017-04-20 14:35:33 +01:00
Patrick H. Lauke
1f37c536b2 Tweak iOS hack for dropdown 
Tweak to https://github.com/twbs/bootstrap/pull/22426, where the wrong selector slipped through the net (selecting all of `<body>`s grand-children rather than children)
 2017-04-20 14:08:40 +01:00
Patrick H. Lauke
ef099ad05d Add iOS hack to tooltips 
Same hack as in https://github.com/twbs/bootstrap/pull/22426 (modulo the selector, which is wrong in that PR and will be updated in a separate PR) to get tooltips to work correctly on iOS. Dynamically adds/removes empty (`noop`) `touchstart` event handlers to all children of `<body>` in order to coax iOS into proper event delegation/bubbling
 2017-04-20 13:49:35 +01:00
Bardi Harborow
b4ac48fdec Build system overhaul. 2017-04-20 14:31:22 +10:00
Patrick H. Lauke
6ae5fb12e6 Fix carousel "hover" behavior on touch-enabled devices 
* Add carousel mouse listeners even if touch events enabled

- touch events are enabled not just on "mobile", just also on
touch-enabled desktop/laptop devices; additionally, it's possible to
pair a mouse with traditionally touch-only devices (e.g. Android
phones/tablets); currently, in these situations the carousel WON'T pause
even when using a mouse

* Restart cycle after touchend

as `mouseenter` is fired as part of the touch compatibility events, the
previous change results in carousels which cycle until the user
tapped/interacted with them. after that they stop cycling (as
`mouseleave` is not sent to the carousel after user scrolled/tapped
away).
this fix resets the cycling after `touchend` - essentially returning
to the previous behavior, where on touch the carousel essentially never
pauses, but now with the previous fix it at least pauses correctly for
mouse users on touch-enabled devices.
includes documentation for this new behavior.
 2017-04-17 13:26:46 +01:00
Mark Otto
bc0cf36dc8 grunt 2017-04-16 13:54:07 -07:00
Patrick H. Lauke
6d64afe508 Replace dropdown backdrop hack with cleaner JS-only hack 
* Replace backdrop with simple noop mouse listener

As discussed in https://github.com/twbs/bootstrap/pull/22422 the current
approach of injecting a backdrop (to work around iOS' broken event
delegation for the `click` event) has annoying consequences on
touch-enabled laptop/desktop devices.
Instead of a backdrop `<div>`, here we simply add extra empty/noop
mouse listeners to the immediate children of `<body>` (and remove
them when the dropdown is closed) in order to force iOS to properly
bubble a `click` resulting from a tap (essentially, method 2 from
https://www.quirksmode.org/blog/archives/2014/02/mouse_event_bub.html)
This is sufficient (except in rare cases where the user does manage to tap
on the body itself, rather than any child elements of body - which is not
very likely in an iOS phone/tablet scenario for most layouts) to get iOS to
get a grip and do the correct event bubbling/delegation, meaning the regular
"click" event will bubble back to the `<body>` when tapping outside of the dropdown,
and the dropdown will close properly (just like it already does, even without
this fix, in non-iOS touchscreen devices/browsers, like Chrome/Android and
Windows on a touch laptop).
This approach, though a bit hacky, has no impact on the DOM structure, and
has no unforeseen side effects on touch-enabled laptops/desktops. And crucially,
it works just fine in iOS.

* Remove dropdown backdrop styles

* Update doc for dropdowns and touch-enabled devices
 2017-04-14 09:19:00 +01:00
Pierre Vanduynslager
2f94166276 Merge branch 'v4-dev' into dropdown-keyboard 2017-04-12 16:31:50 -04:00
Patrick H. Lauke
3275ca4b30 Reword "mobile" to "touch-enabled" 
...as touch is not exclusive to "mobile" anymore nowadays. also explicitly clarifies this is a fix for iOS, and that it impacts touch laptops etc as well. lastly, renames the variable from "dropdown" to "backdrop" for clarity/consistency
 2017-04-12 18:39:23 +01:00
Pierre Vanduynslager
208e0384df Merge branch 'v4-dev' into dropdown-keyboard 2017-04-12 10:36:14 -04:00
Pierre-Denis Vanduynslager
81e12d5715 Indent 2017-04-12 09:41:27 -04:00
Patrick H. Lauke
53b2c5520b Remove inappropriate role="listbox" from carousels 2017-04-11 11:12:30 +01:00
Pierre Vanduynslager
025ddb185e Merge branch 'v4-dev' into dropdown-keyboard 2017-04-10 11:04:05 -04:00
Patrick H. Lauke
18e8704221 Fix collapse.js aria-expanded behavior 
* Remove aria-expanded from collapse.js target element

aria-expanded="true"/aria-expanded="false" only applies to the trigger,
not the element that is being expanded/collapsed.

* Tweak collapse.js accessibility section

...to make it clearer that the aria-expanded attribute always just goes
on the control.

* Fix collapse.js unit tests

- reword some of the text to make it clear we're checking behavior of
trigger/control
- move incorrect aria-expanded out of the <div>s and to the actual
trigger/control <a>s
- fix incorrect test assertion text output false -> true
 2017-04-10 14:51:22 +01:00
Patrick H. Lauke
3f6e1faf45 Only change aria-pressed if it's not an input-based radio or checkbox group 
* Only change aria-pressed if it's not an input-based radio or checkbox group

aria-pressed="true"/aria-pressed="false" is really only useful for
making on/off toggles out of, say, `<button>` elements. the attribute is
useless (and potentially confusing/conflicting) on, say, `<label>`
elements for an existing `<input type="radio">` or similar.

* Add unit test for buttons.js and radio/checkbox inputs in button groups
 2017-04-10 14:43:54 +01:00
Pierre Vanduynslager
d3fbebefcd Merge branch 'v4-dev' into dropdown-keyboard 2017-04-09 18:16:37 -04:00
Patrick H. Lauke
2626eba5f1 Prevent default for ESC in modal.js 
ESC can be used to close modals, but on OS X/macOS this also jumps out
of full-screen mode. `preventDefault` suppresses this.
 2017-04-09 16:19:20 +01:00
Pierre Vanduynslager
fe72daf2b3 Merge branch 'v4-dev' into dropdown-keyboard 2017-04-08 18:43:25 -04:00
Mark Otto
364e01885f grunt 2017-04-08 13:22:53 -07:00
Ilias
e6e070b02a Fix #22332: Adjust tests for hidden scrollbar 2017-04-03 13:27:15 +02:00
Mark Otto
7d88f365c0 Merge branch 'v4-dev' of https://github.com/twbs/bootstrap into v4-dev 2017-04-02 12:00:52 -07:00
Ilias
a14451deb3 Fix #18373: properly adjust padding-right of body and fixed elements when opening or closing modal 2017-04-02 13:26:25 +02:00
Pierre Vanduynslager
91b62941af Tabs/Scrollspy/.nav/.list-group/.active independent of markup (<nav>, .nav-item, <li> etc...) 2017-04-02 11:21:04 +02:00
Mark Otto
49b6cf845d grunt 2017-04-01 19:18:29 -07:00
Johann-S
5142de7e59 Popover + Tooltip - fix error when content or title is a number 2017-03-31 10:03:54 +02:00
Johann-S
fb42d6e043 Collapse - Fix check to not prevent event for input and textarea 2017-03-29 00:10:27 +02:00
Pierre Vanduynslager
48c5efa4c3 Fix JS components console error "Error: <Component> is transitioning" 2017-03-28 23:43:15 +02:00
Mark Otto
cf7d3e11e0 grunt 2017-03-28 09:31:32 -07:00
Johann
904efc043d Fix different tooltips offset when hovering 2017-03-28 15:55:03 +02:00
Mark Otto
7742ba6dc9 grunt 2017-03-27 22:56:14 -07:00
Johann
24924c23b2 Collapse - do not prevent event for input and textarea 2017-03-27 10:08:39 +02:00
Mark Otto
4ab06ca453 grunt 2017-03-26 11:26:31 -07:00
Mark Otto
90c5f6230b rename from .navbar-toggleable to .navbar-expand to reflect mobile first approach everywhere else 2017-03-23 23:02:28 -07:00
Mark Otto
11ba308b2f more docs updates 2017-03-23 23:02:28 -07:00
Johann
3f247a42f2 Fix Modal documentation about _handleUpdate method + move to public scope (#21877) 
Fix Modal documentation about _handleUpdate method + move to public scope
 2017-03-23 22:22:09 +01:00
Pierre Vanduynslager
37f438910f Accordion behavior with JQuery interface (#21726) 
Fix accordion behavior with JQuery interface
 2017-03-23 21:15:41 +01:00
Johann
c72a315740 Carousel - Add attributes from and to for Slid and Slide events (#21668) 
Carousel - Add attributes from and to for Slid and Slide events
 2017-03-22 22:42:13 +01:00
Pierre Vanduynslager
78fc4d23fc Always append element to fixture in Scrollspy unit tests (#22234) 2017-03-21 10:21:00 -07:00
Bardi Harborow
cab6f7d16c More config tweaks. 2017-03-21 21:37:33 +11:00
Bardi Harborow
09fb2b9af3 Update dependencies. 2017-03-20 17:37:05 +11:00
Mark Otto
e506e59c45 grunt 2017-03-19 19:03:32 -07:00
Mark Otto
3730c5dbf5 Merge branch 'collapse' of https://github.com/Johann-S/bootstrap into Johann-S-collapse 2017-03-19 18:43:13 -07:00
Pierre-Denis Vanduynslager
f5cc591456 Merge branch 'twbs/v4-dev' into dropdown-keyboard 2017-03-18 22:08:55 -04:00
Mark Otto
ae50bb7845 grunt 2017-03-18 18:47:57 -07:00
Pierre Vanduynslager
275821bbb0 HTMLElement.offset* by getBoundingClientRect() (#21788) 
* Replace element.offet* by getBoundingClientRect()

* Use variable to store BoundingClientRect

* Fix cc issue...
 2017-03-18 18:24:54 -07:00
Johann
f2f2e39a45 Fix getSelectorFromElement when # is a selector (#21615) 
* Fix getSelectorFromElement when # is a selector

* Thanks to @vanduynslagerp remove regex to validate selector
 2017-03-18 17:42:11 -07:00
Pierre Vanduynslager
f2f8051285 Fix backdrop for dropdown menu on mobile (#21578) 
- Create backdrop only if the menu is actually open (do not create it if the show event is prevented)
- Drop the backdrop only when the corresponding menu is closed (do not remove if there is no menu to close or if the hide event is prevented)
 2017-03-18 17:41:13 -07:00
Mark Otto
5a5ab4c0de grunt 2017-03-18 16:51:32 -07:00
Johann
1a46d8c730 Allow to use Tab.js with list-group (#21756) 
* Allow to use Tab.js with list-group

* Allow to use list-group with div parent instead of an ul parent
 2017-03-18 16:36:33 -07:00
Bardi Harborow
84ce248f06 Update config files across the board. 2017-03-12 16:15:00 +11:00
Johann-S
21b537cc24 Add unit test 2017-03-09 11:08:47 +01:00
Johann-S
fa1504e6f6 Fix code style 2017-03-08 11:15:58 +01:00
Johann-S
099486f294 Detach accordions from .card 2017-03-07 10:46:08 +01:00
Bardi Harborow
6593b15555 Refactor QUnit test page. 2017-02-22 11:14:47 +11:00
Pierre-Denis Vanduynslager
4ab576a419 Fixes #21941 2017-02-08 18:51:50 -05:00
Bardi Harborow
cb87eebcbb Update dependencies. 2017-02-05 23:50:06 +11:00
Pierre-Denis Vanduynslager
403f55fba9 Fix spacebar key in Firefox for button elements 2017-01-22 17:34:54 -05:00
Pierre-Denis Vanduynslager
1cdd0d16c1 Merge branch 'twbs/v4-dev' into dropdown-keyboard 2017-01-22 17:32:50 -05:00
Mark Otto
deb1c59c53 grunt 2017-01-21 17:50:45 -08:00
Pierre-Denis Vanduynslager
ef2181ff4d Harmonize document.activeElement comparison 2017-01-20 23:22:50 -05:00
Pierre-Denis Vanduynslager
4448ca057b Refactor test to event and async 2017-01-20 23:02:45 -05:00
Pierre-Denis Vanduynslager
1a783a4255 Add unit test for keyboard navigation 2017-01-20 23:02:19 -05:00
Pierre-Denis Vanduynslager
59f438b40e Merge branch 'twbs/v4-dev' into dropdown-keyboard 2017-01-20 20:27:17 -05:00
Pierre-Denis Vanduynslager
9daf681478 Fix test to retrieve the proper item instead of it's parent 2017-01-20 20:27:14 -05:00
Pierre-Denis Vanduynslager
57713c9fc5 Fix missing closing tag 2017-01-18 15:01:06 -05:00
Pierre-Denis Vanduynslager
a85b80fa75 Merge branch 'twbs/v4-dev' into dropdown-keyboard 2017-01-15 10:33:54 -05:00
Pierre-Denis Vanduynslager
8fbd4aaa38 Correct reference to Direction.PREV constant. (#21709) 2017-01-15 13:46:03 +11:00
Pierre-Denis Vanduynslager
c80e13a48a Use existing keycode constants in dropdown. (#21697) 2017-01-15 13:42:24 +11:00
Patrick H. Lauke
6b48ba4e0d Remove incorrect aria-multiselectable 
Closes https://github.com/twbs/bootstrap/issues/21635
 2017-01-11 23:57:59 +00:00
Pierre-Denis Vanduynslager
4c2f544359 Merge branch 'twbs/v4-dev' into dropdown-keyboard 2017-01-06 15:57:15 -05:00
Pierre-Denis Vanduynslager
eb84c03ddf Update dropdown unit test to new markup 2017-01-06 15:56:38 -05:00
Mark Otto
d2fbf58546 grunt 2017-01-06 08:39:56 -08:00
Mark Otto
045888fa38 version bump 2017-01-06 08:38:04 -08:00
Mark Otto
43d9391fba grunt 2017-01-05 14:51:14 -08:00
Patrick H. Lauke
85a1fdcb29 Merge pull request #21093 from Johann-S/fixButtonGrpAria 
Close #21090 - Fix aria-pressed attribute for buttons in container with data-attribute="buttons"
 2017-01-05 09:35:43 +00:00
Mark Otto
0015da793a grunt 2017-01-04 11:59:07 -08:00
Pierre-Denis Vanduynslager
d1b742f228 Use pageYOffset instead of scrollY 2017-01-04 11:42:08 -08:00
Pierre-Denis Vanduynslager
67958f35e8 Merge conflict 2017-01-04 12:24:33 -05:00
Pierre-Denis Vanduynslager
c4867cfedb Merge branch 'twbs/v4-dev' into dropdown-keyboard 
# Conflicts:
#	js/src/dropdown.js
 2017-01-04 12:22:06 -05:00
Johann-S
0463b01282 Close #21090 - Fix aria-pressed attribute for buttons in container with data-toggle='buttons' 2017-01-04 11:02:16 +01:00
Mark Otto
56f917dd8c grunt 2017-01-03 13:16:18 -08:00
Pierre-Denis Vanduynslager
bbb0d2b573 Dropdown: close menu when focusing outside element (#21375) 
* Close dropdown menu when focusing an outside element
* Update unit test to new markup
 2017-01-02 14:44:27 -08:00
Mark Otto
9fc54f89f4 grunt 2017-01-02 11:54:28 -08:00
Mark Otto
c61a0059ad update seletors in js 2017-01-02 11:52:38 -08:00
Mark Otto
20b05e42e3 update rest of docs, remove navbar specific modifiers, fix docs example css 2017-01-02 11:48:51 -08:00
Heinrich Fenkart
daff021578 grunt 2017-01-01 03:21:02 +01:00
Mark Otto
e2b6badb86 v4: Rip out IE compatibility mode meta tags (#21483) 
* Remove IE compatibility mode meta tag from docs, examples, and JS tests as we no longer support IE9 and IE8
* update and remove some IE bits from our supported browser page
* update introduction.md to match
* reword starter template intro
 2016-12-31 12:20:32 -08:00
Johann-S
026e1a1421 Allow to use nav with tab JS 2016-12-31 00:54:00 -08:00
Mark Otto
d935cca9f6 one more test file 2016-12-31 00:52:08 -08:00
Mark Otto
55413e109f nuke local test vendor jquery and tether, replace with docs assets 2016-12-31 00:52:08 -08:00
Johann-S
719318f485 Update visual test carousel 2016-12-31 00:51:19 -08:00
Mark Otto
92fa9b2256 fix navbar in dropdown visual test file 2016-12-30 22:45:39 -08:00
Bardi Harborow
a8100e1f01 Extend ESLint to cover all JS files and drop JSCS. 2016-12-31 16:49:15 +11:00
Johann-S
95ce03f000 Close #21249 : Add a Unit test for #21227 2016-12-29 13:28:42 -08:00
Pierre-Denis Vanduynslager
425d156df2 Merge branch 'twbs/v4-dev' into dropdown-keyboard 2016-12-28 19:57:38 -05:00
Mark Otto
d3646e3884 grunt 2016-12-27 14:27:41 -08:00
Max Beatty
aa7f95fd77 update click state when hiding so can be shown again by trigger. fixes #16732 2016-12-27 14:19:12 -08:00
Mark Otto
0e8ee1bfba grunt 2016-12-25 15:47:03 -08:00
Alessandro Rodi
9103bffe37 [Fix #19849] Tabs are opened even if disabled. (#20795) 
* [Fix #19849] Tabs are opened even if disabled.

* fix hund code review hints

* rollback hound issues because Travis fails
 2016-12-24 23:31:34 -08:00
Mark Otto
cd18ee8af6 grunt 2016-12-24 14:29:41 -08:00
Johann-S
b0508a975d Closes: #21412: Fix unit test for carousel 2016-12-23 22:56:55 +11:00
Matheus Azzi
dab6a41e04 Carousel: Only prevents default for ARROW_LEFT and ARROW_RIGHT keys 
Fixes 2 bugs:

1. All keydowns were being prevented. Because of that the user wasn't able to navigate in the whole page using ARROW_UP/ARROW_DOWN.

2. Even when  is an input or textarea the keydowns were being prevented. Because of that the user wasn't able to type any text on these elements.
 2016-12-23 17:55:40 +11:00
mr-july
1d6cdb65b3 scrollspy: fix wrong activation of all nested links (#20304) 
* fix wrong activation of all nested links;
just first level item should be activated

* use template instead of string concatenation
 2016-12-22 22:00:56 -08:00
Mark Otto
1f9619a517 Merge branch 'patch-1' of https://github.com/tracker1/bootstrap into tracker1-patch-1 2016-12-21 20:34:29 -08:00
Mark Otto
ab38529dcc grunt 2016-12-19 21:48:24 -08:00
Mark Otto
8eeb71c91c Merge branch 'fix-20982' of https://github.com/Starsam80/bootstrap into Starsam80-fix-20982 2016-12-19 21:44:03 -08:00
Mark Otto
cd76a6775d grunt 2016-12-07 20:46:17 -08:00
Starsam80
d991c868a4
Fix tabs by using new classes 2016-12-07 21:20:18 -07:00
Starsam80
bf39bb3ac3
Rename .active to .show 2016-12-07 21:20:15 -07:00
Mark Otto
1afb6959fa remove commented out code 2016-12-04 21:05:57 -08:00
Mark Otto
1e3ec89355 Merge branch 'v4-dev' into carousel 2016-12-04 21:05:19 -08:00
Mark Otto
01f81dd552 fix js for previous 2016-12-04 20:27:21 -08:00
Mark Otto
94e2d80af4 pull in js changes from #18830 2016-12-04 19:53:16 -08:00
Mark Otto
3ec37d4a4d grunt 2016-12-02 10:13:36 -08:00
Johann
297c47c3fd [V4] Throw error when a plugin is in transition (#17823) 
* Throw error when a plugin is in transition
* Add unit tests about plugins in transition
 2016-12-02 09:52:19 -08:00
Mark Otto
59dc3e174d grunt 2016-11-29 21:37:00 -08:00
Bardi Harborow
535fec93cf Hide popovers when their containing modal is closed. (#21227) 2016-11-29 09:45:14 -08:00
Mark Otto
9749bab4ce grunt 2016-11-28 17:18:44 -08:00
Juno_okyo
8c17e5fb3c Use multi-selector to remove the same event handler (#20642) 2016-11-28 13:42:32 -08:00
Mark Otto
82875586c1 Merge branch 'v4-js-carousel' of https://github.com/J2TeaM/bootstrap into J2TeaM-v4-js-carousel 2016-11-28 13:39:56 -08:00
Mark Otto
d6c1fa37bd grunt 2016-11-28 13:36:46 -08:00
Rob Ruana
5eddb0b0fd Closes #21055: Prevents ScrollSpy from clearing active item when Safari rubberbands (#21056) 
When the rubberband effect causes Safari to scroll past the top of the
page, the value of scrollTop becomes negative. If the offset of the first
ScrollSpy target is 0 - essentially if the target is at the top of the
page - then ScrollSpy should not clear the active item. Conceptually, the
first item should remain active when rubberbanding past the top of the
page.

This commit fixes issue #21055 by verifying the first scrollspy target is
not at the top of the page before clearing the active nav-item.
 2016-11-27 16:20:33 -08:00
Mark Otto
0b8a281920 grunt 2016-11-26 19:17:23 -08:00
Mark Otto
87a0749f89 Merge branch 'container-tooltip-option' into v4-dev 2016-11-26 17:02:40 -08:00
Mark Otto
c7b8451cdc grunt 2016-11-26 11:16:53 -08:00
Mark Otto
b6b8280938 Merge pull request #18900 from vlastikcz/v4-dev-buttonChange 
Button toggling - trigger change event on input. Fixes #16673, fixes #17599.
 2016-11-26 01:18:21 -08:00
Mark Otto
ce31f54c36 Merge pull request #19058 from Johann-S/carouselInput 
Carousel - Do not prevent on keydown for input and textarea
 2016-11-26 01:14:55 -08:00
Mark Otto
bb6c197d9b grunt 2016-11-26 01:04:12 -08:00
Mark Otto
b110070dcd Follow up fix to #19953 for linting error in builds 
See https://travis-ci.org/twbs/bootstrap/jobs/179010884 for build failure
 2016-11-26 01:04:02 -08:00
Mark Otto
19ab4873ff grunt 2016-11-26 01:00:16 -08:00
Mark Otto
25d218b02d Merge branch 'v4-dev-18796' of https://github.com/maxbeatty/bootstrap into maxbeatty-v4-dev-18796 2016-11-26 00:58:51 -08:00
Mark Otto
e953d5d4f0 grunt 2016-11-26 00:40:17 -08:00
Pierre-Denis Vanduynslager
3606c5b9c5 Dropdown perf - on keyboard nav, find active item in the active dropdown rather than the whole document (#19953) 2016-11-26 00:35:49 -08:00
andyexeter
0ded703f6b Implement container option for tooltips and popovers. 2016-11-26 19:13:15 +11:00
Johann
ce18a66809 Add test unit to check logic of ignoreBackdropClick (#18245) 2016-11-25 22:57:20 -08:00
matus
d328c911cb Added a virtual test 2016-11-25 17:39:00 -08:00
matus
39d7861f34 Scrollspy selecting the last element when at the bottom of the page (fixes #17739) 2016-11-25 17:38:42 -08:00
Mark Otto
49be9bc63a grunt 2016-11-25 15:00:23 -08:00
Mark Otto
432fe74c31 Merge branch 'eslint' of https://github.com/bardiharborow/bootstrap into bardiharborow-eslint 2016-11-25 14:59:28 -08:00
Matt Hernandez
b1b1f30cbd [Fix #17371][V4] Deactivating dropdown links in nav tab (#17642) 
* Fix bug with dropdown tab links not deactivating when other tab or dropdown link is clicked

* Revise bug fix for more stability
 2016-11-25 14:56:41 -08:00
Bardi Harborow
c2616fb74e Make JS compliant with the new ESLint rules. 2016-11-24 11:59:55 +11:00
Bardi Harborow
26c16743fc Refactor ESLint configuration. 2016-11-24 11:59:55 +11:00
Bardi Harborow
b9e7cef965 Update visual tests. 2016-11-13 02:34:18 +11:00
Mark Otto
cd5c7a2263 grunt 2016-10-31 21:36:10 -07:00
Mark Otto
ffaad0a819 Responsive display utilities (#20934) 
* Explore responsive display utils, but with a twist: lowest breakpoint has no breakpoint modifier in the class name
* make floats use the same format, add float-none mixin
 2016-10-31 21:27:56 -07:00
Mark Otto
76d53404b5 grunt 2016-10-31 21:14:23 -07:00
Johann
a7f1b59959 Making .tooltip('show') throw an error on elements with display:none (#20940) 2016-10-31 20:33:53 -07:00
Bardi Harborow
0974267b8c Move from $.proxy to es6 arrow functions. (#21049) 2016-10-31 20:32:36 -07:00
Mark Otto
d1171ac44a grunt 2016-10-30 15:21:53 -07:00
Ilias
bf43936377 Fix #17964 (#17997) 
* Fix #17964

Some browsers are lazy when updating dom elements after transition effects. This can be fixed by reading element properties such as offsetHeight or offsetWidth. However, creating a function using the Function constructor just to access such element, results in a violation of Content Security Policy (where applied), which in turn crashes the application. This fix actually reverts to the way this was handled in v3 and should work as intended.
 2016-10-30 14:47:14 -07:00
Mark Otto
c01fa6b369 Merge pull request #17536 from Johann-S/testPadding 
[Fix #17400] Add tests about padding restoration
 2016-10-28 13:46:14 -07:00
Mark Otto
9dbfc90eae grunt 2016-10-27 09:51:22 -07:00
Johann-S
9d129a43d6 Use a single class name for opened/expanded/shown state of widgets 2016-10-25 14:07:41 +02:00
Mark Otto
73154d0392 Merge pull request #20467 from maxbeatty/v4-dev-17754 
add support for ol in tab plugin
 2016-10-24 20:50:52 -07:00
Mark Otto
60e51bc918 Merge pull request #18847 from Johann-S/fix18824 
Fix bug multiple accordions collapse
 2016-10-24 20:50:04 -07:00
Mark Otto
d4d53cad96 grunt 2016-10-19 08:28:19 -07:00
Mark Otto
8ff7edaab4 version bump to alpha 5 2016-10-19 08:27:41 -07:00
Johann-S
9bc7de9395 Fix bug multiple accordions collapse 2016-10-19 09:35:48 +02:00
Mark Otto
6d6538fc81 grunt 2016-10-16 19:44:11 -07:00
vsn4ik
85327e4f9a v4: Fix outdated utilites classes 2016-10-12 01:46:10 +03:00
Johann-S
de1255b14e Collapse using card component 2016-10-11 13:25:36 +02:00
Mark Otto
259fa88e3e Merge pull request #17614 from Johann-S/patchTooltip 
[Fix #17611][V4] Change destroy to dispose for tooltip in _JQueryInterface
 2016-10-10 13:03:28 -07:00
Mark Otto
7407518fd1 grunt 2016-10-09 20:39:50 -07:00
Mark Otto
4d725c90d6 Merge pull request #17568 from Johann-S/fixCollapseHeight 
[Fix #17555][V4] fix resetting style on closing collapse
 2016-10-09 20:32:40 -07:00
Mark Otto
4493701ee2 grunt 2016-10-09 20:26:49 -07:00
Mark Otto
e7f79b32f2 Merge branch 'tooltip-arrow' of https://github.com/brnrdog/bootstrap into brnrdog-tooltip-arrow 2016-10-09 19:56:30 -07:00
Mark Otto
571e86e770 grunt 2016-10-09 17:26:51 -07:00
Mark Otto
6def7a5d56 Merge pull request #20555 from bardiharborow/updatedeps 
Update dependencies, including Babel to v6 and zeroUnits fix.
 2016-10-09 17:08:39 -07:00
Mark Otto
a2a53cb8c5 grunt 2016-10-09 12:39:56 -07:00
Bardi Harborow
d57d5a606b Update dependencies, including Babel to v6 and zeroUnits fix. 2016-10-09 12:15:17 +11:00
Bardi Harborow
2e69dfa8c1 Fix broken/redirected links, moving to HTTPS where possible. (#20557) 2016-10-03 09:55:59 -07:00
VarelloThemes
63129112bb replace some profanities (#20715) 2016-09-15 09:39:31 -07:00
J2TeaM
4f520c7ff3
Merge #20563 and #20567 2016-09-07 10:09:54 +07:00
J2TeaM
4f5a7c96e7
Fix eslint (prefer-template) 2016-09-07 03:17:19 +07:00
J2TeaM
edc43a4ea6
Remove classes at one time 2016-09-07 02:55:48 +07:00
Mark Otto
d90d060c8c grunt 2016-09-05 12:42:12 -07:00
Mark Otto
5495a4b3d3 versions 2016-09-05 12:41:44 -07:00
Max Beatty
dc1b4e78d4 add support for ol in tab plugin. fixes #17754 2016-08-04 16:57:08 -07:00
Max Beatty
bfa714ae1e prevent navigating to area href when modal target. fixes #18796 2016-08-04 13:47:30 -07:00
Mark Otto
0fd2f8b889 grunt dist 2016-07-27 09:32:05 -07:00
Mark Otto
24e992a6ff bump versions 2016-07-27 09:31:24 -07:00
Chris Rebert
ed3ba47425 Support jQuery v3 in Bootstrap v4 (#20191) 
* bower.json, package.json: Extend jQuery version ranges to include v3
* NuGet: Bump jQuery to v3.0.0.1
* Docs+Examples: Update jQuery to v3.0.0
* Use jQuery v3.0.0 for JS unit tests
* Update jqueryVersionCheck to allow jQuery v3.x.x
 2016-06-28 22:19:46 -07:00
Dave Methvin
8900d953ed ScrollSpy unit test: Use single done() in a then() instead of multiple done()s (#20198) 
Fixes test flakiness on OS X Safari and Android when using jQuery 3.
Fixes #20182 more
Refs #20191
 2016-06-28 13:24:28 -07:00
Dave Methvin
208d587c7e Scrollspy test: Allow for async .then() in jQuery 3; fixes #20182 
Instead of doing a new assert.async(), just do a single one for the entire test
and let the .then() be async as well.

Closes #20190
 2016-06-27 22:37:31 -07:00
Chris Rebert
aa369bd8f9 Remove unnecessary usage of Promises in non-async ScrollSpy tests (#20180) 
Closes #19906

[skip validator]
 2016-06-26 21:33:07 -07:00
Mark Otto
aaad85bc30 Merge branch 'v4-dev' of https://github.com/twbs/bootstrap into v4-dev 2016-06-12 21:17:14 -07:00
Chris Rebert
c955868982 Enable more rules from ESLint 2.0; refs #19999 (#20076) 
[skip sauce]
[skip validator]
 2016-06-05 11:17:05 -07:00
Chris Rebert
0f3d427bbd grunt 
[ci skip]
 2016-06-04 18:21:15 -07:00
Chris Rebert
eb350d1a7c Upgrade to latest version of JSCS (v3.0.4) (#20070) 
Fixes #20002

[skip sauce]
[skip validator]
 2016-06-04 17:55:21 -07:00
Chris Rebert
04165ba6e3 Update ESLint to v2.11.1 (latest stable) (#20068) 
Fixes #19908

[skip sauce]
[skip validator]
 2016-06-04 17:08:59 -07:00
Chris Rebert
d1b8ec85e2 Upgrade ESLint to v2.9.0 (#20047) 
Refs #19908

[skip sauce]
[skip validator]
 2016-06-04 15:07:16 -07:00
Chris Rebert
2b16f5c510 Update ESLint to v2.5.3 (#20043) 
Refs #19908.

[skip sauce]
[skip validator]
 2016-06-04 14:28:34 -07:00
Chris Rebert
92ec110f08 Upgrade ESLint to v2.3.0 (#20041) 
Refs #19908

[skip sauce]
 2016-06-04 14:01:12 -07:00
Chris Rebert
5dcd1a743d Tweak Esc key comment in modal.js 
[skip sauce]
[skip validator]
 2016-05-31 02:19:56 -07:00
Chris Rebert
92e9d9de62 Enable new ESLint-recommended rules in ESLint config 
Refs http://eslint.org/docs/user-guide/migrating-to-2.0.0#new-rules-in-eslintrecommended
 2016-05-31 00:49:48 -07:00
Chris Rebert
4d3bd8e6c5 Migrate parser & env config to ESLint 2.0.0 2016-05-31 00:46:33 -07:00
Chris Rebert
c4add0c2f3 Comply with consistent-return ESLint rule 2016-05-31 00:45:32 -07:00
Chris Rebert
0efec1a3db Migrate ESLint rules config to ESLint 2.0.0 
Refs http://eslint.org/docs/user-guide/migrating-to-2.0.0
 2016-05-31 00:39:39 -07:00
Chris Rebert
9324da7aeb Upgrade ESLint to v1.10.3 
Refs #19908
 2016-05-31 00:12:17 -07:00
Chris Rebert
00a3e1d9ad Upgrade ESLint to v1.9.0 
Refs #19908
 2016-05-30 23:59:24 -07:00
Chris Rebert
324cbb2280 Upgrade ESlint to v1.7.3 
Enable new rules:
* no-empty-pattern
* no-magic-numbers (exempting 0 and ±1)

Refs #19908

[skip sauce]
[skip validator]
 2016-05-30 23:42:22 -07:00
Chris Rebert
5a35ad6d74 Use named constants for magic numbers (#19992) 
Mostly KeyboardEvent.which and MouseEvent.which values.

[skip validator]
 2016-05-30 23:42:00 -07:00
Chris Rebert
14c7ba95f9 Fix load & scroll event usage in ScrollSpy tests (#19986) 
* Use $.one() instead of $.on() since there are no $.off()s in the code.
* Remove unnecessary namespacing of listeners for the `scroll` & `load` events.
    These are vanilla DOM events (not custom jQuery namespaced events)
    and we're not using jQuery namespacing to manage these event listeners either (e.g. `$.off()`).

[skip validator]
 2016-05-30 09:39:45 -07:00
Chris Rebert
d35973c2b3 js/tests/unit/scrollspy.js: Fix "offsed" typos (#19985) 
[skip sauce]
[skip validator]
 2016-05-29 18:36:09 -07:00
XhmikosR
4bca0f878a Merge pull request #19894 from twbs/v4-dev-jquery223 
Update jQuery to v2.2.4.
 2016-05-26 15:40:02 +03:00
XhmikosR
a950d5642b Update jQuery to v2.2.4. 2016-05-26 15:26:12 +03:00
Pierre-Denis Vanduynslager
ab2fc63d08 Dropdown: remove dependency to role="menu", role="listbox" a and li elements => fix keyboard navigation 2016-05-22 02:16:27 -04:00
akai
4d1b9d7ce7 Remove stray "~" in modal paddingRight value (#19932) 
[skip validator]
 2016-05-18 13:53:01 -07:00
Patrick H. Lauke
b107e3342a Handle aria-hidden on modal container when showing/hiding 
Fixes #19878
 2016-05-11 02:01:56 +01:00
Mark Otto
932d0aa068 grunt 2016-05-08 13:43:13 -07:00
Chris Rebert
afdd62d161 Modal: Remove IE8-specific window.innerWidth workaround 
[skip validator]
 2016-04-21 01:15:24 -07:00
XhmikosR
8a878c1f7b Update jQuery to v2.2.2. 2016-03-19 15:21:12 +02:00
Michael J. Ryan
681d390a05 Update tooltip.js 
match project's style check
 2016-03-14 13:29:03 -07:00
Michael J. Ryan
1a23279237 Update tooltip.js 
Don't reference `Tether` via attachment to `window`, with the update one can import bootstrap providing the dependencies in webpack with:

```
new webpack.ProvidePlugin({
  $: 'jquery',
  jQuery: 'jquery',
  Tether: 'tether',
});
```

Then inside one's own bootstrap/globals, `import 'bootstrap';` will simply work, and $/jQuery can be used from there.

I had wanted to do this, but also expose jQuery, Tether, etc when in development build in my code, but if I provide `window.Tether`, I can't then expose it to the outside...
 2016-03-14 13:18:08 -07:00
Chris Rebert
25cf50a4ac JS visual tests: Remove usages of defunct .page-header class 
[skip sauce]
 2016-02-27 18:01:12 -08:00
XhmikosR
96cafe2d2d Update tether to v1.2.0. 
[skip sauce]
[skip validator]
 2016-02-27 13:56:40 +02:00
XhmikosR
255e89b241 Run grunt. 
[ci skip]
 2016-02-19 13:14:47 +02:00
XhmikosR
79067a6440 Fix validation errors. 
[skip sauce]
 2016-02-19 11:26:54 +02:00
Patrick H. Lauke
701b12bf58 Replace jQuery with vanilla JS 2016-02-17 15:21:02 +00:00
Mark Otto
3b84ffcc54 grunt 2016-02-16 20:09:57 -08:00
Patrick H. Lauke
83217479c3 Visual/manual test for checkbox/radio button kbd behavior 2016-02-16 21:24:29 +00:00
Patrick H. Lauke
a496cb8be4 Focus (visually hidden) input radio/checkbox 
This allows for keyboard navigation (e.g. arrow keys left/right to
trigger different radio buttons) following an initial mouse click
interaction
 2016-02-16 14:29:59 +00:00
Chris Rebert
ff4792fcef js/tests/index.html: Replace jQuery event alias methods with functions that throw explanatory errors, instead of with undefined 
Refs https://github.com/twbs/bootstrap/pull/19219#issuecomment-184653699

[skip validator]
 2016-02-16 04:05:41 -08:00
Mark Otto
0e70c6a37f Merge branch 'v4-dev' of https://github.com/twbs/bootstrap into v4-dev 2016-02-03 19:23:29 -08:00
Johann-S
14ec4fdfc1 Carousel - Do not prevent on keydown for input and textarea 2016-02-01 00:06:07 +01:00
Chris Rebert
f2d77b674c scrollspy.js: Avoid gratuitous non-ASCII for consistency+compatibility 
Fixes #19028

[skip sauce]
[skip validator]
 2016-01-26 11:58:40 -08:00
Kotas Vlastimil
866e99b00c Button toggling - trigger change event on input 
Bootstrap’s .button styles can be applied to other elements, such as labels, to provide checkbox or radio style button toggling.

When the checkbox or radio state is changed, there should be triggered the change event. Currently, the change event is triggered on the Button, which is not correct. Only input fields do support the change event.
 2016-01-14 20:26:32 +01:00
Chris Rebert
422ed9ab48 grunt dist docs 
[ci skip]
 2016-01-01 12:37:52 -08:00
Chris Rebert
5deb734b53 ESLint: enable no-bitwise rule 
[skip sauce]
 2015-12-24 18:53:41 -07:00
Chris Rebert
ad4c0ee52f Exempt getUID() from ESLint's no-bitwise rule 
[skip sauce]
[skip validator]
 2015-12-24 18:53:08 -07:00
Chris Rebert
74f1d3b9b8 Merge pull request #18393 from twbs/dropdown-bitwise-less-tricksy 
dropdown.js: Use more straightforward phrasing for index bound check
 2015-12-24 08:16:19 -07:00
Chris Rebert
d30310feae Merge pull request #18638 from twbs/fix-18365 
Modal: Ignore spurious focus event that Firefox fires at document when switching back to its tab
 2015-12-24 08:15:27 -07:00
XhmikosR
612ff4f5d1 Run grunt. 
[ci skip]
 2015-12-24 12:50:15 +02:00
Chris Rebert
d12ed5520e Modal: Ignore spurious focus event that Firefox fires at document when switching back to its tab 
Fixes #18365
Refs https://bugzilla.mozilla.org/show_bug.cgi?id=1228802
 2015-12-22 23:08:03 -07:00
Chris Rebert
2c69e0f810 Add visual test for #18365 
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1228802
 2015-12-22 23:08:03 -07:00
Chris Rebert
96e9205009 js/tests/unit/modal.js: Fix typo 
[ci skip]
 2015-12-22 17:11:21 -07:00
Chris Rebert
31d4139a74 Update version numbers using npm script 
Errata from:
* 8ce5da3026
* 5d3144e8fb
which missed a few numbers.

[skip sauce]
[skip validator]
 2015-12-08 18:16:47 -08:00
Mark Otto
5d3144e8fb manually bump versions because npm script wasn't working for me 2015-12-08 09:36:08 -08:00
XhmikosR
b7b448a0e7 Run grunt. 
[ci skip]
 2015-12-05 12:59:13 +02:00
Chris Rebert
75c39f9138 Fix version numbers is JS files; fixes #18435 
[skip sauce]
[skip validator]
 2015-12-05 02:19:46 -08:00
XhmikosR
34a0ce571e Run grunt. 
[ci skip]
 2015-12-05 11:43:23 +02:00
XhmikosR
92d0a71fb6 Merge pull request #18391 from twbs/double-bitwise-not-comment 
util.js: Add comment explaining ~~ trick
 2015-12-05 10:37:27 +02:00
XhmikosR
8a1685fdee Run grunt. 
[ci skip]
 2015-12-03 08:51:57 +02:00
XhmikosR
79a4273891 Tweak ESLint rules. 2015-12-03 08:41:46 +02:00
XhmikosR
e55fcbcdfe tests: bump QUnit to v1.20.0. 
[skip validator]
 2015-12-03 08:41:46 +02:00
Chris Rebert
31ca64232d dropdown.js: Use more straightforward phrasing for index lower bound check 
[skip sauce]
[skip validator]
 2015-11-30 23:59:39 -08:00
Chris Rebert
a887a1207c util.js: Add comment explaining ~~ trick 
[skip sauce]
[skip validator]
 2015-11-30 23:47:56 -08:00
Chris Rebert
580e2f7845 Remove stray </p> from js/tests/visual/scrollspy.html 
[skip sauce]
 2015-11-19 01:50:20 -08:00
XhmikosR
eea6690d0e Run grunt. 
[ci skip]
 2015-11-16 10:03:57 +02:00
Jacob Thornton
ece98f980c add undefined for now 2015-11-14 20:43:45 -08:00
Jacob Thornton
d600831a15 add explicit error for lack of tether in tooltips - fixes #17273 2015-11-14 20:35:10 -08:00
Jacob Thornton
186c1c6d80 Merge branch 'v4-dev' of https://github.com/lincolndbryant/bootstrap into lincolndbryant-v4-dev 2015-11-14 19:49:48 -08:00
XhmikosR
a291d79ecb Run grunt. 
[ci skip]
 2015-11-11 09:00:47 +02:00
Jon Tewksbury
2d87ec9a64 Add eslint no-undef rule and resolve errors 2015-11-03 15:04:26 -08:00
Chris Rebert
1dc8583bc5 grunt dist 2015-10-29 22:08:31 -07:00
XhmikosR
7a85751144 Remove html5shiv and respond.js from test files. 2015-10-26 23:57:19 +02:00
XhmikosR
a50849f61b Switch to jQuery 2.1.4. 
Now that we don't support IE 8 it's safe to do that.
 2015-10-24 19:09:33 +03:00
Henry Zhu
8924b5044e update grunt-jscs to 2.1.0 to use jscs 2.x 2015-10-19 08:17:13 -04:00
XhmikosR
724bf86288 Run grunt. 
[ci skip]
 2015-10-14 00:49:31 +03:00
Johann-S
817d997b75 Use Page Visibility API in Carousel; fixes #17706 
Avoids cycling carousels when the page isn't visible.
Closes #17710
Refs #15566
 2015-10-11 15:10:49 -07:00
Chris Rebert
b74536fa8c grunt dist 2015-10-09 21:03:57 -07:00
Chris Rebert
10f6e97ec2 Merge pull request #17616 from Johann-S/ThrowError 
Fix #17612: Throw explicit error when a nonexistent method is invoked
 2015-10-02 01:18:16 -07:00
Johann-S
21a65f181e Add throw error for undefined method on plugins 2015-10-02 10:01:24 +02:00
XhmikosR
22c8c1e887 Specify root: true for ESLint. 
That way, ESLint won't look in parent dirs for configuration files.
 2015-09-24 20:24:38 +03:00
XhmikosR
b93c16341d Run grunt. 2015-09-23 09:39:13 +03:00
Johann-S
6d451ad99d Change destroy -> dispose 2015-09-16 09:46:55 +02:00
Johann-S
32f9a5d6a5 fix resetting style on closing collapse 2015-09-11 10:45:08 +02:00
Johann-S
8ece899ba8 Add tests about padding restoration 2015-09-10 08:19:59 +02:00
XhmikosR
f0840c893b Run grunt. 2015-09-05 08:13:43 +03:00
muzige2000
3af4560c67 Modals: Fix bad paddingRight calculation; fixes #17399 
We want to sum two numbers, not concatenate their stringifications.
Closes #17457 by merging a tweaked version of it.
 2015-09-03 01:25:38 -07:00
Gleb Mazovetskiy
c7d8e7a077 Accept elements as the tooltip / popover content 
When a DOM node is passed to an HTML tooltip, the `title` node is only
moved if it is not already in the tooltip. Otherwise, `empty()` is used
instead of `detach()` before appending the `title` to avoid memory
leaks. If a DOM node is passed to a plain text tooltip, its text is
copied via jQuery `.text()`.

Replaces `.detach()` with `.empty()`, as `.detach()` is almost never
useful but instead leaks memory. The difference between `empty` and
`detach` is that the latter keeps all the attached jQuery events/data.
However, since we do not return the previous children, the user would
have to keep these themselves, thus they can `detach()` if necessary.

This is a port of https://github.com/twbs/bootstrap/pull/14552 to v4.
 2015-08-31 01:06:13 +01:00
XhmikosR
4dd9a5a6dc Update QUnit to v1.18.0. 2015-08-27 08:15:19 +03:00
XhmikosR
13e33e329c Remove the obsolete JSHint references. 2015-08-27 08:11:11 +03:00
Bernardo Gurgel Filho
8ef66df6d7 Convert popover's arrows to generated CSS content via :before/:after 2015-08-26 17:20:01 -03:00
Bernardo Gurgel Filho
2ae5fdf9dd Convert tooltip's arrows to generated CSS content via :before 2015-08-26 17:20:01 -03:00
Chris Rebert
d06f79e2f7 grunt babel:dev 2015-08-26 01:27:45 -07:00
Jelle Versele
54c4eb950b fixes #17097: Go back to using jQuery's text and html methods since innerText is nonstandard and not present in Firefox 
Closes #17272 by merging a tweaked version of it.

[skip validator]
 2015-08-26 01:00:46 -07:00
XhmikosR
7e2eb9e74a js/.eslintrc: sort rules by name. 
[ci skip]
 2015-08-25 08:45:07 +03:00
Heinrich Fenkart
73a88dbe86 Docs: Update all dropdowns to new HTML structure 2015-08-21 00:18:55 +02:00
Boris Kaiser
463837c1c7 Remove duplicate "spaced-comment" in eslintrc 
Closes #17100
 2015-08-20 01:27:47 -07:00
lbryant
8b15b5a262 _removeTetherClasses is no longer referenced 2015-08-20 01:22:16 -04:00
lbryant
926fb11158 use Tether addTargetClasses: false option instead of manually removing them 2015-08-20 01:03:29 -04:00
Jacob Thornton
03e732708c rewrite tab with new active shit 2015-08-18 22:03:34 -07:00
Jacob Thornton
4e45e2363c Merge branch 'v4' of github.com:twbs/derpstrap into v4 2015-08-18 21:23:53 -07:00
Jacob Thornton
fd65b9f32e some minor alert shit 2015-08-18 20:33:57 -07:00
Mark Otto
1c19ded8c1 Merge branch 'v4' of https://github.com/twbs/derpstrap into v4 2015-08-18 20:25:48 -07:00
Jacob Thornton
8cfde5ef29 fix modal visual example for js 2015-08-18 19:50:32 -07:00
Jacob Thornton
efae761c39 fix dropdown js visual example 2015-08-18 19:42:27 -07:00
Jacob Thornton
18ff57a183 js tests passing + eslint 2015-08-18 19:22:46 -07:00
Mark Otto
15b7ce59df grunt 2015-08-18 18:45:12 -07:00
Jacob Thornton
f1827e5f9c add polyfil for bind for tether.js 2015-08-18 17:06:17 -07:00
Jacob Thornton
19e43b62ed use proxy not bind in alert 2015-08-18 17:01:56 -07:00
Jacob Thornton
05c7a37507 fix dropdown test 2015-08-15 12:17:13 -07:00
Jacob Thornton
c830956d17 change modal.js to use is-fixed classes to target padding-right 2015-08-15 12:10:24 -07:00
Jacob Thornton
11abb0f7e9 fix modal 2015-08-12 21:12:03 -07:00
Jacob Thornton
23d05f1585 get the js working for docs 2015-08-12 19:59:55 -07:00
Mark Otto
1ddc3f5e21 Merge branch 'master' into v4m 2015-08-04 22:29:45 -07:00
Johann-S
ef1ce9ac0b Fix triggering of {shown,hidden}.bs.dropdown events so relatedTarget gets set properly 
Fixes #16828
Closes #16865
 2015-07-27 00:58:51 -07:00
Melinda Sarnicki Bernardo
cebea5b6f6 Removes unnecessary period at end of comment 2015-07-02 19:30:11 -07:00
Mark Otto
169d2a4a78 Merge branch 'master' into v4 2015-06-18 23:56:43 -07:00
Mark Otto
83bfff7f07 bump version 2015-06-16 09:10:22 -07:00
Patrick H. Lauke
5fd7bc1554 generalize dropdowns / drop role="menu" 
as role="menu" is a very specific (and strict) ARIA pattern for
desktop-like application menus, and our dropdowns are often used
as pure navigation dropdowns, this change abandons ARIA menus for
a more open-ended and light-weight approach
(see http://heydonworks.com/practical_aria_examples/#submenus and
http://www.w3.org/WAI/tutorials/menus/flyout/#improve-screen-reader-support-using-wai-aria)
note that in dropdown.js, switched to now target ``.dropdown-menu``
instead of ``role["menu"]`` - this also prevents bootstrap scripts
from "bleeding" into non-bootstrap components on the same page.
also removed the ``role=["listbox"]`` part, which appears to be
vestigial/unused (only place in bootstrap that uses that
role are carousels, and their key handling is done separately)
 2015-06-02 11:03:21 +01:00
XhmikosR
315907c97c Use https when possible. 2015-05-17 12:43:20 +03:00
fat
6b2b0ed32f al tests passing, dist rebuilt, w/typechecker 2015-05-13 14:52:46 -07:00
fat
eaab1def7a add simple type checker implementation 2015-05-13 14:46:50 -07:00
fat
c2ced2292a fix up tests 2015-05-13 13:46:08 -07:00
fat
b0d142334f fix #15301 2015-05-13 13:43:56 -07:00
fat
7ef0e52fd0 add "focus" option for turning off modal focusing #16050 2015-05-13 13:22:26 -07:00
fat
da495ee24c address https://github.com/twbs/bootstrap/pull/16135 2015-05-13 13:15:11 -07:00
fat
f8b2569ec8 implement global dispose method 2015-05-13 12:48:34 -07:00
fat
6b251582d6 update attachment -> placement 2015-05-12 16:54:21 -07:00
fat
ab1578465a grunt test-js, grunt dist-js now working 2015-05-12 16:52:54 -07:00
fat
a58febf71a popover passing as well 2015-05-12 14:35:00 -07:00
fat
3452e8dc83 rewritten tooltip + tether integration and death to our positioner jank 2015-05-11 23:32:37 -07:00
fat
8eee78ca15 tab es6 2015-05-11 12:29:06 -07:00
fat
2d91494d96 scrollspy es6 2015-05-11 12:05:35 -07:00
fat
ca9c850ebb add getters for Version and Default where applicable 
add modal my gawd
 2015-05-10 19:45:38 -07:00
fat
bbb97a8660 add dropdown 2015-05-10 13:47:11 -07:00
fat
8bab38bb71 add collapse 2015-05-09 23:04:58 -07:00
XhmikosR
1eba173c9e Update jQuery to v1.11.3. 2015-05-10 01:22:23 +03:00
fat
1b183e2ff7 carousel -> es6 2015-05-07 22:26:40 -07:00
fat
6605051882 button -> es6 2015-05-07 17:14:38 -07:00
fat
c3a79b1a8c change the export pattern to protect against leaking globals 2015-05-07 16:34:28 -07:00
fat
0724bd91ff es6 alert :| 2015-05-07 12:57:31 -07:00
fat
d1fbe200f4 remove closureness from plugins 2015-05-06 13:34:14 -07:00
XhmikosR
a2f81ceb57 phantom.js: switch to unicode characters that work on Windows too. 2015-05-05 06:58:54 +03:00
XhmikosR
49c4556354 Comply to the new JSCS rules. 2015-05-05 06:50:18 +03:00
XhmikosR
93785be2c6 Update JSCS rules. 2015-05-05 06:50:18 +03:00
Chris Rebert
aa2c5b5672 Merge pull request #16014 from redbmk/issue-16008 
Multiple tooltip triggers don't play well together
 2015-05-04 15:07:17 -07:00
Patrick H. Lauke
a254782ca4 Merge pull request #16404 from patrickhlauke/radio-checkbox-kbd-toggle-fix 
Fix radio and checkbox keyboard handling in .btn-group
 2015-05-03 17:05:12 +01:00
Carlo Stearns
0689117f13 Fix issue where affixed element has incorrect positioning 
when used with a sticky footer layout.
Adds visual test for affix with sticky footer.

Closes #15694.
Refs #15032.
 2015-05-02 17:59:31 -07:00
Patrick H. Lauke
0c1daaf2ce Remove broken/vestigial unit test 
Overall logic for this test appears broken, possibly relating to an
older version of Bootstrap that did not require explicit
`data-toggle="button"` on single toggle buttons?
 2015-05-01 12:58:10 +01:00
Patrick H. Lauke
f9cd88e09f Fix radio and checkbox keyboard handling 
Fix for problem that emerged from #16226 (`.active` class not actually
being applied) and expansion of the script to also correctly handle
keyboard interaction with checkboxes in `data-toggle="button"` groups
 2015-05-01 12:19:19 +01:00
XhmikosR
3e7ca3bbc8 Minor lint tweaks. 2015-04-28 11:03:37 +03:00
Braden M. Kelley
4b269037cb Multiple tooltip triggers don't play well together 
Fixes issue #16008
 2015-04-27 23:03:56 -07:00
F A T
aa479892d5 Merge pull request #16152 from jarthod/tooltip-placement-viewport-fix 
Tooltip/popover: Fix auto placement to use viewport
 2015-04-27 11:28:54 -07:00
Chris Rebert
cdb37dce3a Set box-sizing: border-box on .container-viewport in #16142 testcase 
Otherwise, the test doesn't properly fail when the fix is reverted.
 2015-04-27 01:23:39 -07:00
Adrien
37a10d37c1 Compare tooltip right offset to viewport right offset (and not width) 
Closes #16142 by merging it.
 2015-04-27 01:13:16 -07:00
Chris Rebert
fc372952e2 Throw error when tooltip/popover template has multiple top-level elements 
Closes #16219.
 2015-04-25 13:16:53 -07:00
Chris Rebert
0d77644fc4 throw error when trying to show tooltip on :hidden element 2015-04-23 17:14:45 -07:00
Adrien Siami
e949505b89 Allow viewport option to be a function 
Closes #16151 by merging a rebased version of it that adds docs and 1 more assertion.
 2015-04-21 22:20:15 -07:00
Chris Rebert
c6b62f0cd9 Merge pull request #16147 from Johann-S/event_inserted 
Fixes #16124.
 2015-04-21 21:40:14 -07:00
Niels Steenbeek
7429fc7ff9 Tooltip: Destroy $tip, $arrow, $viewport to avoid memory leak 
Closes #16039.
 2015-04-20 23:29:31 -07:00
Patrick H. Lauke
8549722846 Merge pull request #16226 from patrickhlauke/radio-toggle-kbd-fix 
Fix radio button toggle behavior for keyboard users
 2015-04-17 18:19:11 +02:00
Patrick H. Lauke
66d71136e6 Fix existing radio button unit test 2015-04-11 19:24:21 +02:00
Patrick H. Lauke
1b9baa0d98 Don't preventDefault radio buttons 
as this breaks keyboard navigation for radio button toggles (see
https://github.com/twbs/bootstrap/issues/16223)
 2015-04-11 19:21:55 +02:00
Chris Rebert
b8935a5d0c Use .dropdown-menu instead of ARIA roles for dropdown keydown event handler; fixes #16090 2015-04-08 19:20:15 -07:00
Johann-S
3d71eae301 Add event after template inserted 2015-04-08 13:10:53 +02:00
Adrien Jarthon
5921724d9c fixed IE incompatible CSS 2015-03-29 19:16:59 +02:00
Adrien Jarthon
df96c3e615 Added non-regression test & fixed existing one 2015-03-29 14:59:21 +02:00
Mark Otto
58082cd83e Merge branch 'master' into v4 
Conflicts:
	.gitignore
	Gruntfile.js
	_config.yml
	dist/css/bootstrap-theme.css
	dist/css/bootstrap-theme.min.css
	dist/css/bootstrap.css
	dist/css/bootstrap.css.map
	dist/css/bootstrap.min.css
	dist/js/bootstrap.js
	dist/js/bootstrap.min.js
	docs/_includes/components/navbar.html
	docs/_includes/components/progress-bars.html
	docs/_includes/css/grid.html
	docs/_includes/css/overview.html
	docs/_includes/customizer-variables.html
	docs/_includes/getting-started/accessibility.html
	docs/_includes/getting-started/browser-device-support.html
	docs/_includes/getting-started/community.html
	docs/_includes/getting-started/disabling-responsiveness.html
	docs/_includes/getting-started/download.html
	docs/_includes/getting-started/examples.html
	docs/_includes/getting-started/license.html
	docs/_includes/getting-started/third-party-support.html
	docs/_includes/js/alerts.html
	docs/_includes/js/buttons.html
	docs/_includes/js/carousel.html
	docs/_includes/js/collapse.html
	docs/_includes/js/dropdowns.html
	docs/_includes/js/modal.html
	docs/_includes/js/popovers.html
	docs/_includes/js/scrollspy.html
	docs/_includes/js/tabs.html
	docs/_includes/js/tooltips.html
	docs/_includes/js/transitions.html
	docs/_includes/nav/javascript.html
	docs/_includes/nav/main.html
	docs/about.html
	docs/assets/css/docs.min.css
	docs/assets/css/src/docs.css
	docs/assets/js/customize.min.js
	docs/assets/js/raw-files.min.js
	docs/assets/js/src/customizer.js
	docs/dist/css/bootstrap-theme.css
	docs/dist/css/bootstrap-theme.min.css
	docs/dist/css/bootstrap.css
	docs/dist/css/bootstrap.css.map
	docs/dist/css/bootstrap.min.css
	docs/dist/js/bootstrap.js
	docs/dist/js/bootstrap.min.js
	docs/migration.html
	js/affix.js
	js/alert.js
	js/button.js
	js/carousel.js
	js/collapse.js
	js/dropdown.js
	js/modal.js
	js/popover.js
	js/scrollspy.js
	js/tab.js
	js/tests/unit/affix.js
	js/tests/unit/button.js
	js/tests/unit/carousel.js
	js/tests/unit/modal.js
	js/tests/unit/tooltip.js
	js/tests/visual/modal.html
	js/tooltip.js
	less/component-animations.less
	less/jumbotron.less
	less/mixins/background-variant.less
	less/mixins/buttons.less
	less/mixins/responsive-visibility.less
	less/mixins/text-emphasis.less
	less/navbar.less
	less/navs.less
	less/scaffolding.less
	less/tooltip.less
	less/utilities.less
	less/variables.less
	package.json
	scss/_buttons.scss
	scss/_forms.scss
	scss/_modal.scss
 2015-03-29 00:08:54 -07:00
Heinrich Fenkart
da63ff2e95 JSCS: Add "disallowSpacesInFunctionDeclaration" 
Valid:

    function a() {}

Invalid:

    function a () {}
 2015-03-26 18:28:17 +01:00
Chris Rebert
6c5e7dfce1 rm redundant aria-hidden usage from Modals; fixes #16020 2015-03-25 18:06:47 -07:00
Adrien Jarthon
0e8e5222ff Tooltip/popover: Fix auto placement to use viewport 
Currently, auto placement is using the container dimensions (if provided) or the element's parent to determine where to open the tooltip:
```javascript
var $container   = this.options.container ? $(this.options.container) : this.$element.parent()
var containerDim = this.getPosition($container)
```
This is quite broken in fact, because the parent element could be just a small div outside the element for example, leading in a totally random placement (placing the tooltip on top even if there's no room). And the container can also be outside of the viewport.

This fix simply uses the viewport instead, that's the purpose of the viewport actually, to position the tooltip.
So the auto placement should use it to find where there's more room.
By default this is body, which is good.
 2015-03-25 18:05:58 +01:00
Chris Rebert
d37bc2ae65 Merge pull request #15987 from twbs/fix-15972 
add role="button" to a[data-toggle="collapse"]
 2015-03-24 08:57:56 -07:00
Emmanuel Bourgerie
fa9d28b634 Fix #16072: Clicking into input field within dropdown no longer closes the dropdown 
Closes #16073 by merging it
 2015-03-21 16:00:15 -07:00
Chris Rebert
9aad9a4164 Merge pull request #16024 from twbs/unnecessary-parsing 
avoid unnecessary HTML string building+parsing
 2015-03-18 22:28:07 -07:00
Chris Rebert
4d652035dc v3.3.2 => v3.3.4 2015-03-16 08:39:31 -07:00
Maxim Andrukhovych
83371735fc Fixed proper navigation element selection on backward scrolling (from the bottom to the top) 2015-03-10 20:04:15 +00:00
Chris Rebert
1383b88328 Merge pull request #16012 from twbs/refs-12761 
Disable jQuery event aliases when running test suite
 2015-03-09 17:47:51 -07:00
Chris Rebert
a14665e73e avoid unnecessary HTML string building+parsing 2015-03-09 06:47:34 -07:00
Chris Rebert
a5243ad3d0 Affix: $('body') => $(document.body) 2015-03-09 06:43:41 -07:00
Chris Rebert
725c6848c3 Disable jQuery event aliases when running test suite 
To ensure that we don't accidentally use any of the aliases.
This should prevent any future regressions from #12761.
Also updates the test suite since it now can't use these aliases either.
 2015-03-09 01:05:43 -07:00
Chris Rebert
21d56378e1 Merge pull request #16011 from twbs/fix-15315 
.collapse('hide') on hidden uninit-ed collapsible no longer shows it
 2015-03-09 01:03:27 -07:00
Chris Rebert
a134491fe5 add togglable scrollbar-inducing content to Modal visual test 2015-03-07 06:40:57 -08:00
Chris Rebert
6ddb8c2dd7 add static navbar to Modal visual test 2015-03-07 06:39:46 -08:00
Chris Rebert
64ca888cbc Merge pull request #15999 from twbs/kkirsche-includeTestsReadme 
Document JS test suite basics
 2015-03-06 23:28:30 -08:00
Kevin Kirsche
ba2f7e92d0 [Fixes #15951] Document JS test suite basics 
X-Ref: #15953
Closes #15952 by merging a tweaked version of it.
[skip sauce]
[skip validator]
 2015-03-06 23:27:00 -08:00
Chris Rebert
5c8d56d515 Collapse unit test: rm check that no-op hide adds style="height: 0px" 
Appears to be unnecessary and is broken by #16011,
which is otherwise quite sane.
 2015-03-06 18:10:53 -08:00
Chris Rebert
872e56fcf2 .collapse('hide') on hidden uninit-ed collapsible no longer shows it; fixes #15315 
Thanks to @peterblazejewicz & @Nikita240
Adds unit tests based on #14417
X-Ref: #14282
Closes #15807
 2015-03-06 06:58:48 -08:00
Chris Rebert
27bbc7dbe9 Hiding an uninitialized tooltip/popover no longer initializes it; fixes #15874 2015-03-03 22:22:13 -08:00
Chris Rebert
cc39f5c52d add role="button" to a[data-toggle="collapse"]; fixes #15972 2015-03-03 13:18:36 -08:00
Chris Rebert
168297c779 rm semicolon for sake of fat's eccentric tastes 
Erratum from #15496
 2015-03-03 13:06:32 -08:00
Heinrich Fenkart
420a8088a4 Merge pull request #15961 from kkirsche/ImplementAssertExpect 
[Fixes #15953] Implement assert.expect in each unit test
 2015-03-03 15:52:05 +01:00
Kevin Kirsche
4febcb4b49 [Fixes #15953] Implement assert.expect in each unit test 
[Fixes #15953] Implement `assert.expect` in each unit test
 2015-03-03 08:45:07 -05:00
Heinrich Fenkart
f5beebe726 Modal: Fix backdrop not readjusting when height changes 
Fixes #15136.
Closes #15345.
Closes #15314.
Refs #14724, #14927.
 2015-03-03 05:27:26 +01:00
Chris Rebert
46f5a8f478 Merge pull request #15970 from twbs/the-future-is-now-qunit 
Disable deprecated QUnit global methods
 2015-03-02 02:39:29 -08:00
XhmikosR
f8e34ff48b Disable es3 for tests and customizer.js. 2015-03-02 11:16:06 +02:00
Chris Rebert
c291c12cb1 Disable deprecated global QUnit method aliases to prevent backsliding on QUnit v2 readiness 2015-03-01 19:50:11 -08:00
Chris Rebert
c80872235f Merge pull request #15955 from twbs/fixture-on-screen-ios 
Unit tests: Only display fixture on-screen for iOS
 2015-03-01 18:28:46 -08:00
Chris Rebert
015e63f6df Merge pull request #15593 from neoeno/handle_multiple_zero_offset_scrollspy_elements 
Handle multiple zero-offset Scrollspy elements.
 2015-03-01 16:04:04 -08:00
Caden Lovelace
a1aa0f8afd Handle multiple zero-offset Scrollspy elements. 
When the first two elements in a scrollspy content block have a document
offset of zero (i.e. they're hard against the top of the page),
Scrollspy would switch between them on every scroll event.

This could happen, for example, in a system of nested sections:

```
<section id="animals">
  <section id="dogs">
	Content
  </section>
</section>
```

This ocurred because Scrollspy's check to see if it's at the end of the
array of sections uses `!arr[index]`. This misses the case where
`arr[index]` does exist and is zero.

This commit explicitly checks the array bounds.
 2015-03-01 23:55:39 +00:00
Mark Otto
c16fee5efd Merge branch 'master' into v4 
Conflicts:
	.travis.yml
	Gruntfile.js
	bower.json
	dist/css/bootstrap.css
	dist/css/bootstrap.css.map
	dist/css/bootstrap.min.css
	dist/js/bootstrap.js
	dist/js/bootstrap.min.js
	docs/_data/glyphicons.yml
	docs/_includes/components/breadcrumbs.html
	docs/_includes/components/button-dropdowns.html
	docs/_includes/components/button-groups.html
	docs/_includes/components/dropdowns.html
	docs/_includes/components/glyphicons.html
	docs/_includes/components/labels.html
	docs/_includes/components/list-group.html
	docs/_includes/components/media.html
	docs/_includes/components/navs.html
	docs/_includes/components/panels.html
	docs/_includes/components/progress-bars.html
	docs/_includes/components/thumbnails.html
	docs/_includes/components/wells.html
	docs/_includes/css/buttons.html
	docs/_includes/css/forms.html
	docs/_includes/css/helpers.html
	docs/_includes/css/images.html
	docs/_includes/css/less.html
	docs/_includes/customizer-variables.html
	docs/_includes/getting-started/accessibility.html
	docs/_includes/getting-started/browser-device-support.html
	docs/_includes/getting-started/community.html
	docs/_includes/getting-started/examples.html
	docs/_includes/getting-started/grunt.html
	docs/_includes/getting-started/license.html
	docs/_includes/getting-started/template.html
	docs/_includes/header.html
	docs/_includes/js/affix.html
	docs/_includes/js/alerts.html
	docs/_includes/js/carousel.html
	docs/_includes/js/collapse.html
	docs/_includes/js/dropdowns.html
	docs/_includes/js/modal.html
	docs/_includes/js/overview.html
	docs/_includes/js/popovers.html
	docs/_includes/js/scrollspy.html
	docs/_includes/js/tabs.html
	docs/_includes/js/tooltips.html
	docs/_includes/js/transitions.html
	docs/_includes/nav/javascript.html
	docs/_layouts/default.html
	docs/assets/css/docs.min.css
	docs/assets/css/src/docs.css
	docs/assets/js/customize.min.js
	docs/assets/js/docs.min.js
	docs/assets/js/raw-files.min.js
	docs/assets/js/vendor/FileSaver.js
	docs/assets/js/vendor/autoprefixer.js
	docs/assets/js/vendor/uglify.min.js
	docs/dist/css/bootstrap.css
	docs/dist/css/bootstrap.css.map
	docs/dist/css/bootstrap.min.css
	docs/dist/js/bootstrap.min.js
	docs/examples/blog/index.html
	docs/examples/carousel/index.html
	docs/examples/cover/index.html
	docs/examples/dashboard/index.html
	docs/examples/narrow-jumbotron/narrow-jumbotron.css
	docs/examples/navbar-fixed-top/index.html
	docs/examples/navbar-static-top/index.html
	docs/examples/non-responsive/index.html
	docs/examples/non-responsive/non-responsive.css
	docs/examples/theme/index.html
	grunt/configBridge.json
	js/affix.js
	js/carousel.js
	js/collapse.js
	js/dropdown.js
	js/modal.js
	js/popover.js
	js/scrollspy.js
	js/tab.js
	js/tests/unit/affix.js
	js/tests/unit/button.js
	js/tests/unit/carousel.js
	js/tests/unit/modal.js
	js/tests/unit/tooltip.js
	js/tooltip.js
	less/badges.less
	less/glyphicons.less
	less/type.less
	less/variables.less
	package.json
	scss/_dropdown.scss
	scss/_forms.scss
	test-infra/npm-shrinkwrap.json
 2015-03-01 13:44:10 -08:00
Heinrich Fenkart
20fb55a840 Unit tests: Only display fixture on-screen for iOS 
Since only on iOS tests fail when the fixture is displayed off-screen, see https://travis-ci.org/twbs/bootstrap/jobs/52605742
 2015-03-01 09:49:59 +01:00
Heinrich Fenkart
4345e24479 Use different way to make failing test more visible in Sauce 2015-03-01 09:20:00 +01:00
Ivan Cheung
d5071b19f1 Update all collapse triggers with .collapsed class and aria-expanded 
Fixes #15741
Closes #15751 by merging it.
 2015-02-26 18:48:20 -08:00
Chris Rebert
9afb61fffd QUnit.jsDump => QUnit.dump 
Refs http://qunitjs.com/upgrade-guide-2.x/#replace-qunit-jsdump-with-qunit-dump
 2015-02-25 23:29:27 -08:00
Chris Rebert
4ff9c54cdd Use QUnit.log(...) instead of QUnit.log = ... 
Refs http://qunitjs.com/upgrade-guide-2.x/#replace-qunit-log-callback-with-qunit-log-callback-for-all-reporting-callbacks
 2015-02-25 23:29:27 -08:00
Heinrich Fenkart
3bb05b5fbb Unit tests: Use new names of module hooks 
Refs #15893
 2015-02-26 08:20:42 +01:00
nakupanda
142a9e4ae0 Modal: Apply any preexisting body padding again after closing 2015-02-26 08:02:06 +01:00
Quentin Spencer-Harper
acc5f65756 Tooltip: Avoid creating an unnecessary tooltip when Tooltip#hide is called 
Fixed performance bug where a tooltip element is created and then immediately destroyed when tooltip.hide() is called and there is no existing tooltip element

Resolves #15557 by merging it.
 2015-02-26 06:53:58 +01:00
vsn4ik
b395f3526e Dropdowns: Skip .disabled instead of .divider on keydown event 
Fixes #15147.
Closes #15520 by merging it.
 2015-02-26 06:42:09 +01:00
Heinrich Fenkart
cac6cfcd84 Merge pull request #15923 from kkirsche/useExplicitVariableDeclaration 
[Ref #15881] Use Explicit JS Variable Declarations rather than Chained
 2015-02-26 05:55:27 +01:00
Chris Rebert
a339bfb0ac Merge pull request #15693 from huang-x-h/patch-1 
tip method in popover.js can be removed
 2015-02-25 19:49:26 -08:00
Kevin Kirsche
238be65786 [Ref #15881] Use Explicit Values rather than Chain 
[Ref #15881] Use Explicit Values for javascript variables rather than chained ones.

From https://github.com/twbs/bootstrap/pull/15881#discussion_r25330647
 2015-02-25 12:19:11 -05:00
Chris Rebert
804457c474 fix 2 typos in modal unit test assertion messages 2015-02-24 23:49:08 -08:00
Heinrich Fenkart
c40c31a308 Dropdown unit tests: Tiny style changes 2015-02-25 02:53:39 +01:00
Heinrich Fenkart
6e0c843223 ScrollSpy: Small style consistency adjustments 2015-02-25 01:37:13 +01:00
Chris Rebert
2a6207c0c9 Merge pull request #15904 from kkirsche/patch-8 
Closes #15904
 2015-02-24 14:11:03 -08:00
Kevin Kirsche
696fc2e53c Add unit test of aria-expanded to dropdown suite 
Redo of #15876
 2015-02-24 14:09:08 -08:00
Kevin Kirsche
30d8cdf639 Add tests for aria-hidden of modal 
Add tests for `aria-hidden` of modal

Use strictEqual of 1 here instead of 2 asserts
 2015-02-24 16:29:40 -05:00
Chris Rebert
ecd469ec16 Merge pull request #15893 from twbs/qunit-modern 
Modernize QUnit usage by avoiding usage of global functions
 2015-02-24 11:47:29 -08:00
Chris Rebert
9c75c855c6 JS unit tests: equal() => strictEqual() 
[skip validator]
 2015-02-23 22:43:17 -08:00
Chris Rebert
bda4fe87ca upgrade to QUnit v1.17.1 
[skip validator]
 2015-02-23 22:18:51 -08:00
Chris Rebert
118b8c2695 JS unit tests: use QUnit.module() & QUnit.test() everywhere 
[skip validator]
 2015-02-23 22:14:11 -08:00
Chris Rebert
7c19fee3f1 JS unit tests: use modern QUnit assert object everywhere 2015-02-23 22:14:11 -08:00
Heinrich Fenkart
16479e9051 Merge pull request #15378 from twbs/fix-ie-modal-scrollbar-for-realz 
Modal: Work around IE scrollbars not taking up page width
 2015-02-24 03:33:32 +01:00
fat
1e9e3316b6 kill affix 2015-02-11 11:40:57 -08:00
fat
834220ea20 bootstrap onto closure 2015-02-11 11:29:43 -08:00
dormouse
91b384399c tip method in popover.js can be removed 
Popover is extend Tooltip, the tip function can use tootltip's tip, so we can remove the tip function definition in popover to reduce the js filesize

tip function definition in tooltip.js https://github.com/tbs/bootstrap/blob/master/js/tooltip.js#L405-L407
 2015-01-29 11:21:07 +08:00
Chris Rebert
cd4467b194 Merge pull request #15496 from twbs/15484-alternative 
Make $(document).tooltip({...}) without a `selector` throw an error
 2015-01-28 11:05:40 -08:00
Chris Rebert
af8fa54fcd Merge pull request #15630 from twbs/tabs-cond-fix 
Fix error in condition in Tab plugin
 2015-01-28 10:59:51 -08:00
Chris Rebert
ebedeaf2fe Fix name of Tooltip.replaceArrow() parameter 
isHorizontal => isVertical
 2015-01-27 11:15:55 -08:00
Chris Rebert
eaaaa00520 Integrate mq4-hover-hover-shim 2015-01-22 11:37:37 -08:00
Chris Rebert
426e8e12cd Fix error in condition in Tab plugin 
Refs #15186
 2015-01-21 14:13:26 -08:00
Chris Rebert
9238337cbb Merge branch 'master' into v4 2015-01-21 13:00:12 -08:00
Chris Rebert
1652efc3f6 tweak 'close reopened modal' unit test to work under new QUnit API 2015-01-20 20:18:33 -08:00
Chris Rebert
df73535a2d fix bug in tab show/shown relatedTarget unit test 2015-01-20 20:16:42 -08:00
Chris Rebert
b56d97f210 update JS unit tests to future-proof QUnit 1.16.0 API 
[skip validator]
 2015-01-20 19:57:51 -08:00
Mark Otto
325748ff68 Merge branch 'master' into v4 
Conflicts:
	_config.yml
	dist/css/bootstrap-theme.css
	dist/css/bootstrap-theme.css.map
	dist/css/bootstrap-theme.min.css
	dist/css/bootstrap.css
	dist/css/bootstrap.css.map
	dist/css/bootstrap.min.css
	dist/js/bootstrap.min.js
	docs/_includes/components/thumbnails.html
	docs/_includes/css/forms.html
	docs/_includes/css/grid.html
	docs/_includes/customizer-variables.html
	docs/_includes/footer.html
	docs/_includes/getting-started/download.html
	docs/_includes/getting-started/template.html
	docs/_includes/js/overview.html
	docs/_includes/js/popovers.html
	docs/_includes/js/tooltips.html
	docs/assets/css/docs.min.css
	docs/assets/js/customize.min.js
	docs/assets/js/raw-files.min.js
	docs/assets/js/src/customizer.js
	docs/dist/css/bootstrap-theme.css
	docs/dist/css/bootstrap-theme.css.map
	docs/dist/css/bootstrap-theme.min.css
	docs/dist/css/bootstrap.css
	docs/dist/css/bootstrap.css.map
	docs/dist/css/bootstrap.min.css
	docs/dist/js/bootstrap.js
	docs/dist/js/bootstrap.min.js
	docs/examples/navbar-fixed-top/index.html
	docs/examples/navbar-static-top/index.html
	docs/examples/non-responsive/index.html
	docs/examples/theme/index.html
	grunt/configBridge.json
	less/alerts.less
	less/badges.less
	less/jumbotron.less
	less/panels.less
	less/tables.less
	less/theme.less
	less/variables.less
	package.json
	scss/_button-group.scss
	scss/_buttons.scss
	scss/_forms.scss
 2015-01-19 14:48:12 -08:00
XhmikosR
a8139a0392 Update QUnit to v1.17.0. 2015-01-19 20:10:34 +02:00
Mark Otto
c683e7dea7 bump versions 2015-01-19 08:32:13 -08:00
XhmikosR
0481ce973f Fix bogus JSCS warning. 2015-01-16 17:50:05 +02:00
XhmikosR
0e79fe1a9f Update JSCS config for the new version. 2015-01-16 17:49:58 +02:00
XhmikosR
9db1de2a3a Update jQuery to v1.11.2. 2015-01-07 00:31:18 +02:00
Chris Rebert
34f88e94fc window.Document doesn't exist in IE8 2015-01-05 14:47:33 -08:00
Chris Rebert
f6a837cbf1 Make $(document).tooltip({...}) without a selector throw an error 
Closes #15484
 2015-01-05 14:22:49 -08:00
Mark Otto
0e5d17d5f6 Merge branch 'master' into v4 
Conflicts:
	Gruntfile.js
	dist/css/bootstrap-theme.css
	dist/css/bootstrap-theme.css.map
	dist/css/bootstrap-theme.min.css
	dist/css/bootstrap.css
	dist/css/bootstrap.css.map
	dist/css/bootstrap.min.css
	dist/js/bootstrap.min.js
	docs/_data/glyphicons.yml
	docs/_includes/components/alerts.html
	docs/_includes/components/badges.html
	docs/_includes/components/breadcrumbs.html
	docs/_includes/components/button-dropdowns.html
	docs/_includes/components/button-groups.html
	docs/_includes/components/dropdowns.html
	docs/_includes/components/glyphicons.html
	docs/_includes/components/input-groups.html
	docs/_includes/components/jumbotron.html
	docs/_includes/components/labels.html
	docs/_includes/components/list-group.html
	docs/_includes/components/media.html
	docs/_includes/components/navbar.html
	docs/_includes/components/navs.html
	docs/_includes/components/page-header.html
	docs/_includes/components/pagination.html
	docs/_includes/components/panels.html
	docs/_includes/components/progress-bars.html
	docs/_includes/components/responsive-embed.html
	docs/_includes/components/thumbnails.html
	docs/_includes/components/wells.html
	docs/_includes/css/buttons.html
	docs/_includes/css/code.html
	docs/_includes/css/forms.html
	docs/_includes/css/grid.html
	docs/_includes/css/helpers.html
	docs/_includes/css/images.html
	docs/_includes/css/less.html
	docs/_includes/css/tables.html
	docs/_includes/css/type.html
	docs/_includes/customizer-variables.html
	docs/_includes/getting-started/accessibility.html
	docs/_includes/getting-started/disabling-responsiveness.html
	docs/_includes/getting-started/download.html
	docs/_includes/getting-started/whats-included.html
	docs/_includes/js/alerts.html
	docs/_includes/js/buttons.html
	docs/_includes/js/carousel.html
	docs/_includes/js/collapse.html
	docs/_includes/js/modal.html
	docs/_includes/js/overview.html
	docs/_includes/js/popovers.html
	docs/_includes/js/tabs.html
	docs/_includes/js/tooltips.html
	docs/_includes/nav/components.html
	docs/_includes/nav/javascript.html
	docs/_jade/customizer-variables.jade
	docs/_layouts/default.html
	docs/about.html
	docs/assets/css/docs.min.css
	docs/assets/css/src/docs.css
	docs/assets/js/customize.min.js
	docs/assets/js/raw-files.min.js
	docs/assets/js/src/customizer.js
	docs/customize.html
	docs/dist/css/bootstrap-theme.css.map
	docs/dist/css/bootstrap.css
	docs/dist/css/bootstrap.css.map
	docs/dist/css/bootstrap.min.css
	less/glyphicons.less
	less/mixins/vendor-prefixes.less
	less/navbar.less
	less/popovers.less
	less/tables.less
	less/theme.less
	less/tooltip.less
	less/variables.less
	package.json
	scss/_carousel.scss
	scss/_close.scss
	scss/_forms.scss
	test-infra/npm-shrinkwrap.json
 2015-01-03 20:08:58 -08:00
Zlatan Vasović
576230b92a Happy New Year 🎅 2015-01-01 01:23:48 +01:00
Chris Rebert
adaabab81b Revert "Allow multiple delegated tooltip selectors on a node" 
This reverts commit 1b3237629a.
This reverts PR #14189 because it caused major regressions.

Fixes #15168.

We'll try to revisit #14167's feature request in Bootstrap v4.

[skip validator]
 2014-12-29 20:08:22 -08:00
Chris Rebert
32cb071594 Remove semicolons from #15425 because fat 2014-12-29 18:34:35 -08:00
Chris Rebert
27bfef5b35 Add regression test for #14244. 
Special thanks to @programcsharp

[skip validator]
 2014-12-29 16:09:37 -08:00
Chris Rebert
54b03c27d2 Merge pull request #43 from twbs/popover-arrow 
rename .arrow => .popover-arrow
 2014-12-29 16:01:07 -08:00
Chris Rebert
e26701c04e JSCS: enable requireSpaceBetweenArguments 
New rule added in JSCS v1.9.0
Our JS already complies with this.
 2014-12-29 14:16:26 -08:00
Chris Rebert
05d1877985 update JS to use .{tooltip,popover}-{left,right,top,bottom} 2014-12-29 12:34:09 -08:00
Chris Rebert
6a5bc63649 rename .arrow => .popover-arrow 2014-12-29 12:33:06 -08:00
Chris Rebert
2ae4c0b03f JSCS: enable requireSpaceBetweenArguments 
New rule added in JSCS v1.9.0
Our JS already complies with this.
 2014-12-29 12:02:33 -08:00
Heinrich Fenkart
32f62bc565 Modal: Work around IE scrollbars not taking up page width 
Fixes #15353.
 2014-12-18 07:29:34 +01:00
Chris Rebert
c7ef5810e1 rename .item => .carousel-item 2014-12-17 18:44:55 -08:00
Chris Rebert
a8299b5b45 Remove ancillary references to IE<9 in comments+docs 2014-12-16 19:06:57 -08:00
Chris Rebert
a28e25c00b Remove IE8 compat shims from JS visual tests 2014-12-15 11:38:57 -08:00
Dan Dascalescu
2c64fc2c4d Fix copy/paste error 2014-11-28 04:30:04 -08:00
Chris Rebert
bc5a753b67 fix affix-top unit test to properly clean up after itself 2014-11-20 23:26:37 -08:00
Nick O'Donoghue
36b4f90f25 Fixes affix-top class not applying 
Use scrollTop instead of colliderTop which uses the elements
offset().top, as the offset top does not account for padding.

This issue can be replicated by using a navbar-fixed-top and applying
relevant padding to the body. (A navbar-static-top with no padding on
the body does not encounter this issue)

Fixes #15078
Closes #15154 by merging it
 2014-11-17 18:17:42 -08:00
Nick O'Donoghue
da79ab9488 add unit test for affix-top for padding issue 2014-11-17 18:17:40 -08:00
Chris Rebert
b7398bc9c4 honor wrap option in Carousel.getItemForDirection; fixes #15144 2014-11-15 22:43:20 -08:00
Chris Rebert
8008fe707e add unit tests for Carousel's 'wrap' option 2014-11-15 22:37:55 -08:00
Heinrich Fenkart
a577f1922e Collapse: Use $.fn.children instead of > in selector 
Fixes #15131.
 2014-11-14 15:18:34 +01:00
Mark Otto
9a7e365c2c bump version to v3.3.1 2014-11-12 09:03:16 -08:00
Heinrich Fenkart
1d55ada581 Dropdown: ignore keydown events coming from inputs and textareas 
Fixes #15084.
 2014-11-12 02:01:25 +01:00
Chris Rebert
21644321e4 Merge pull request #14993 from twbs/fix-14991 
Have Carousel ignore keyboard events from <input>s or <textarea>s
 2014-11-04 16:50:36 -08:00
Heinrich Fenkart
da74fba490 Center modal dialog at all times 2014-11-05 01:37:44 +01:00
Chris Rebert
469dc3ab1f Have Carousel ignore keyboard events from <input>s or <textarea>s; fixes #14991 2014-11-04 16:23:44 -08:00
Heinrich Fenkart
425a985491 Update head of all visual tests to use our basic template 2014-11-05 01:18:11 +01:00
Heinrich Fenkart
14e5fb04e9 Fix modal backdrop overlaying the modal's scrollbar 
Fixes #14916.
 2014-11-04 23:17:55 +01:00
Chris Rebert
4102a67f33 fix typo in comment 2014-10-30 01:47:48 -07:00
Heinrich Fenkart
cf482dbb0b Fix the iOS 8 unit test failures 
Resolves #14919.
 2014-10-30 09:35:53 +01:00
Heinrich Fenkart
5178d8b8ba Use RegExp for button plugin's focus shim 
Fixes #14923.
 2014-10-30 03:46:49 +01:00
Mark Otto
94b59b57d6 version bump 2014-10-29 08:56:20 -07:00
Ben-Russell
68b771a057 Independently delegate data-api selectors 
Fixes #14462.
Closes #14463 by merging it.
 2014-10-29 04:54:53 +01:00
Heinrich Fenkart
ed3a65f084 Handle collapsed class on triggers even when manually invoked 
Fixes #13636.
 2014-10-29 04:34:05 +01:00
Heinrich Fenkart
e851b8685a Merge pull request #14457 from hnrch02/button-set-val-after-event-loop 
Change value of stateful button after event loop
 2014-10-29 04:28:22 +01:00
Chris Rebert
22e1f94b52 Increase timeouts in tooltip unit tests to avoid spurious Sauce failures 
Fixes #14851
 2014-10-27 15:53:43 -07:00
Heinrich Fenkart
007fbdb66d Remove faulty unit test from 9740d8b 
This would only work with transitions but since we disable them for unit tests, this delivers unreliably results.
 2014-10-26 04:56:52 +01:00
Heinrich Fenkart
5da85f8e8b Follow-up to 9740d8b: fix small typo 2014-10-26 04:41:47 +01:00
Phil Hughes
9740d8bb69 Fix tooltip occasionally not hiding when using a hide delay 
Fixes #14375.
Closes #14519 by merging it.
 2014-10-26 04:38:18 +01:00
Andrew S. Brown
1b3237629a Allow multiple delegated tooltip selectors on a node 
Fixes #14167.
Closes #14189 by merging it.
 2014-10-26 03:51:55 +01:00
Heinrich Fenkart
0e991ccba2 Follow-up to e8af21c: rm unused variable in unit test 2014-10-26 03:16:05 +01:00
Tadeu Zagallo
e8af21cc9d Clear scrollspy selection above first section 
Closes #13563 by merging it.
 2014-10-26 03:14:08 +01:00
Cameron Little
0755d529c6 Tabs plugin accessibility 
Added support for `aria-expanded` toggling via JavaScript. Added
`aria-controls`, `aria-expanded`, `aria-labelledby` to tabs docs.

Added `aria-expanded` unit test for the tabs plugin.

See also #13554.

Closes #14154 by merging it.
 2014-10-26 02:25:47 +01:00
Heinrich Fenkart
c1f669e83b Revert "Scrollspy: ignore invisible list items" 2014-10-26 01:50:38 +02:00
Heinrich Fenkart
fe51148434 Merge pull request #14669 from vsn4ik/dropdown_event_target 
Use e.target instead :focus selector.
 2014-10-23 06:13:46 +02:00
Heinrich Fenkart
3c98dd35ba Fix IE8 unit test breakage introduced by #14767 2014-10-22 22:09:58 +02:00
Phil Hughes
ab8dbc214e Implement hide and hidden events for tabs 
Closes #14772.
 2014-10-22 21:42:35 +02:00
Heinrich Fenkart
95e0f48e3a Follow-up to e2cfbd5: Fix spaces in placement calculation 2014-10-22 21:38:34 +02:00
saranya.r
e2cfbd5f2d Fixes tooltip misplacements in scrollable viewports with auto positioning 
Fixes #14756.
Closes #14767.
 2014-10-22 21:35:44 +02:00
Patrick H. Lauke
e1d40f7633 Add aria-pressed to single toggle buttons 
also includes tiny fix/clarification to two existing unit tests for the
.active class, adding data-toggle=“button” explicitly to the tested
buttons

Closes #14819.
 2014-10-22 21:02:19 +02:00
Heinrich Fenkart
e811a24118 Don't fire show event if show is prevented because other element is still transitioning 
Fixes #14844.
Closes #14845.
 2014-10-22 04:25:05 +02:00
fat
4bbe80658a fixes #13816 Modal dialog closes when dragging and releasing mouse button outside dialog 2014-10-09 20:01:51 -07:00
XhmikosR
909a178362 Change Twitter links to use https. 2014-10-07 15:28:41 +03:00
Heinrich Fenkart
61705d35fa Small clean-up in scrollspy unit test 2014-10-07 06:57:46 +02:00
Chris Rebert
d361470487 tooltip unit tests: fix typo in test description 2014-10-03 16:26:53 -07:00
Maarten Van Hoof
44894a40e5 Add missing collapse JS files to dropdown visual test 
Closes #14726.
 2014-10-03 19:55:13 +02:00
Jacob
2c562d2386 Merge pull request #14590 from twbs/carousel-keyboard-option 
Add `keyboard` option to carousel
 2014-10-02 23:11:14 -07:00
Jacob
3fda099f5c Merge pull request #14722 from twbs/fat-14646 
Escape key should only close Dropdown
 2014-10-02 21:26:38 -07:00
fat
e5fc22ccfa Escape key should only close Dropdown 2014-10-02 21:11:17 -07:00
Heinrich Fenkart
038a63b0eb Add keyboard option to carousel 
Also adds unit tests for keyboard events.

Fixes #14468.
 2014-10-03 05:16:31 +02:00
Jacob
b702889613 Merge pull request #14626 from twbs/carousel-pause-hover-non-mobile 
Only enable `pause: hover` for non-touch browsers
 2014-10-02 20:09:20 -07:00
Chris Rebert
443a1b11ee tooltip.js: fix alignment 2014-09-24 21:27:56 -07:00
Chris Rebert
4d9890ea2e Use container instead of parent for tooltip/popover auto-placement calcs 
Fixes #14561. Big thanks to @wickstargazer.

[skip validator]
 2014-09-24 20:46:49 -07:00
Heinrich Fenkart
24ae068f21 Tooltip: Rely on getBoundingClientRect for width and height 
Fixes #14553.
 2014-09-25 01:35:51 +02:00
Heinrich Fenkart
c37c1a6743 Only enable pause: hover for non-touch browsers 
Fixes #11967.
 2014-09-23 23:34:58 +02:00
vsn4ik
bd66b12a94 Use e.target instead :focus selector. 2014-09-23 13:19:15 +04:00
Heinrich Fenkart
acf3c0bf48 Merge pull request #14570 from twbs/remove-modal-open-after-backdrop-closed 
Remove `.modal-open` class after backdrop is hidden
 2014-09-22 21:44:39 +02:00
Chris Rebert
6f6466330d Make it easier to see failing tests in Sauce screencasts 
...by hiding passing tests in the list of tests.
 2014-09-17 18:33:39 -07:00
Heinrich Fenkart
3beeb32bb0 Follow-up to #14581: Use div instead of HTML5 section for IE8 2014-09-17 23:33:22 +02:00
saranya.r
db9e8ee813 Fix tooltip misplacement with "auto top" 
Fixes #14322.
Closes #14581.
 2014-09-17 23:11:04 +02:00
Heinrich Fenkart
c4f431d262 Remove .modal-open class after backdrop is hidden 
Fixes #14274.
Fixes #14632.
 2014-09-17 09:21:09 +02:00
Heinrich Fenkart
152d9dfe2e Merge pull request #14610 from twbs/axe-tooltip-validate 
Remove unused Tooltip#validate method
 2014-09-16 05:41:17 +02:00
Chris Rebert
73e3db0a2f Must explicitly destroy tooltip in SVG unit test since its container is body. 
Leaking tooltips across tests leads to confusion and sadness.
 2014-09-15 20:01:06 -07:00
Heinrich Fenkart
e094d470d4 Remove unused Tooltip#validate method 2014-09-13 09:39:15 +02:00
Peter West
4c98507010 Correctly selects arrow placement for a tooltip 
Fixes #13696.
Fixes #13696.
Fixes #14197.
Closes #13718.
 2014-09-13 04:25:34 +02:00
Heinrich Fenkart
76762169c3 Properly fire hidden event when tooltip is destroyed 
Fixes #13031.
 2014-09-13 03:07:32 +02:00
Heinrich Fenkart
a97db64881 Merge pull request #14569 from twbs/scrollspy-ignore-invisible-targets 
Scrollspy: ignore invisible list items
 2014-09-13 02:29:28 +02:00
Heinrich Fenkart
40f889df2a Merge pull request #14353 from hnrch02/collapse-count-collapsing-as-active 
Collapse: count `.collapsing` elements as actives; closes #13447
 2014-09-13 02:28:25 +02:00
Heinrich Fenkart
6e206f5e8f Merge pull request #14492 from twbs/ie8-getBoundingClientRect 
Handle lack of .width and .height from getBoundingClientRect() in IE8
 2014-09-11 23:11:45 +02:00
Heinrich Fenkart
759a95b0fe Make inDom check of tooltip cross document compatible 
Fixes #14483
 2014-09-09 03:03:14 +02:00
samme
e29c75041e Make affix accept 0 as offsetTop or offsetBottom 
Fixes #12815.
Closes #14363.
 2014-09-09 01:32:42 +02:00
Heinrich Fenkart
9b9e2f5d13 grunt and missing new line 2014-09-09 01:23:48 +02:00
Patrick H. Lauke
fb1ca10b99 ARIA support for collapse 
Added handling of aria-expanded=true/false to collapse.js, updated
documentation to include advice on making expand/collapse controls
accessible, updated examples and javascript documentation to use
aria-expanded and aria-controls (when targetting single collapsible
element, using ID rather than class selector)

Closes #14147.
Closes #14153.
 2014-09-09 01:19:20 +02:00
Heinrich Fenkart
d15444d15e Scrollspy: ignore invisible list items 
Fixes #13071
 2014-09-09 00:18:18 +02:00
Heinrich Fenkart
859ddc11fb Merge pull request #14242 from hnrch02/remove-aria-describedby-later 
Remove `aria-describedby` attribute later
 2014-09-08 23:14:50 +02:00
Heinrich Fenkart
e4b55ded5c Merge pull request #13928 from SGinTech/sgit_collapseEventOrder 
Ensure that hidden event is sent when content is really hidden (collapsi...
 2014-09-08 23:12:27 +02:00
Heinrich Fenkart
787404e090 Merge pull request #14287 from hnrch02/revert-13855-modal-mousedown 
Revert #13855 due to #14263
 2014-09-08 22:23:43 +02:00
Chris Rebert
7f56233862 Merge branch 'stefansundin/master' 2014-09-07 23:07:38 -07:00
Stefan Sundin
f25181615e Fix bug not re-calculating scrollbar width when opening modal. 
If opening a modal when a scrollbar is present, closing it, then
resizing the window so the scrollbar disappears, then opening the
modal again, the content would shift. This fixes the problem by
always calculating the scrollbar width every time a modal is opened.

Closes #14357.
 2014-09-07 23:06:37 -07:00
Chris Rebert
989dafb153 Handle lack of .width and .height from getBoundingClientRect() in IE8 
Closes #14093
Correction to #14090
Relevant docs: https://developer.mozilla.org/en-US/docs/Web/API/Element.getBoundingClientRect#Browser_compatibility
 2014-09-07 22:58:33 -07:00
Jacob
c22b270582 Merge pull request #14273 from sgonyea/master 
Fix hover-popover/tooltip flickering when mouse re-enters
 2014-09-07 10:36:45 -07:00
Scott Gonyea
aac0e16452 Fix hover-tooltip flickering when mouse re-enters 
- is(':visible') seems to be the only reliable check, without a refactoring of how hoverState is used
- tests need improvement
 2014-08-28 17:17:50 -07:00
XhmikosR
d869a5fb62 Update QUnit to v1.15.0. 2014-08-28 09:38:53 +03:00
Heinrich Fenkart
c207b5b66b Change value of stateful button after event loop 
Fixes #14450
 2014-08-26 03:02:29 +02:00
Mark Otto
875006d08c Merge pull request #14417 from twbs/fat-14282 
fixes #14282 - Already Visible collapse gets closed when …
 2014-08-23 12:58:24 -07:00
Chris Rebert
9efedf8f7b Merge pull request #14406 from twbs/nav-tag-for-navbar 
consistently use <nav> instead of <div> for .navbar in docs
 2014-08-20 21:48:59 -07:00
Jacob
c95aa97c03 Merge pull request #14244 from programcsharp/master 
Remove popover content with .children().detach() instead of .empty()
 2014-08-18 20:06:02 -07:00
fat
9c2e54bfec fixes #14282 - Already Visible collapse gets closed when .collapse('show') is called 2014-08-18 19:58:19 -07:00
Chris Rebert
ea0e1606dc Assume Element.getBoundingClientRect() exists; Fixes #14093 
[skip validator]
 2014-08-17 16:08:49 -07:00
Chris Rebert
6b7142212f consistently use <nav> instead of <div> for .navbar in docs 2014-08-15 18:09:05 -07:00
Heinrich Fenkart
436015c191 Collapse: count .collapsing elements as actives; closes #13447 2014-08-08 01:23:50 +02:00
Heinrich Fenkart
75bffd84ae Use closest .alert for alert dismissal; closes #14306 2014-08-04 19:33:42 +02:00
Heinrich Fenkart
dca8afa333 Remove aria-describedby attribute later 
Fixes #14241
 2014-08-04 19:21:49 +02:00
Jacob
8bf48121a0 Merge pull request #14061 from hnrch02/fix-13656 
Expose transition durations on plugin constructors; closes #13656
 2014-08-01 12:50:03 -07:00
Chris Rebert
08393bf68a Fix #14076: Add unit test for tooltips on SVG elements 
[skip validator]
 2014-08-01 12:10:00 -07:00
Chris Rebert
cbba8e53df Fix #13818 by using more robust "find next carousel item" logic 
Also adds another test for #9461: carousel next/prev should ignore non-items
 2014-07-31 11:36:24 -07:00
Heinrich Fenkart
18c0a1c977 Revert "Use mousedown instead of click for backdrop click detection; fixes #13816" 2014-07-30 23:54:25 +02:00
Chris Hynes
531fc80885 Use .end() to remove extra line 2014-07-25 11:10:46 -07:00
Chris Rebert
c2f4e5fef1 re-alphabetize .jscsrc 2014-07-25 11:02:30 -07:00
Chris Hynes
519a087dbe Remove popover content with .children().detach() instead of .empty() so it can be reused 2014-07-25 10:16:44 -07:00
Artem Belov
098242afd8 Delete duplicate JSCS properties 2014-07-25 15:03:07 +04:00
Jacob
36483af92c Merge pull request #14207 from twbs/charlesbjohnson-affix-bottom-when-dynamic-height 
Charlesbjohnson affix bottom when dynamic height
 2014-07-21 22:48:38 -07:00
fat
4775c9296a Merge branch 'dropdown-aria' of git://github.com/mckramer/bootstrap into mckramer-dropdown-aria 
Conflicts:
	docs/_includes/js/dropdowns.html
 2014-07-21 22:44:35 -07:00
fat
eff9b063da cleanup style 2014-07-21 22:37:04 -07:00
Charles B Johnson
724c4f526c Fix issue where bottom affixed element floats over the footer when the 
document height is smaller than the viewport height.
 2014-07-18 10:46:42 -04:00
Charles B Johnson
8c0eb9b00e Refactor determining affix state into a separate expanded method 
in order to handle multiple edge cases, specifically when the document
  height is dynamic.
Always reposition an affix that is affixed to the bottom.
 2014-07-18 10:45:59 -04:00
Charles B Johnson
d3dea01a11 Add a bottom affixed element to affix visual tests. 2014-07-18 10:45:59 -04:00
Jacob
866ffc4f37 Merge pull request #14055 from twbs/fat-speed-up-tests 
speed up js tests a bit
 2014-07-17 10:07:28 -07:00
fat
9b90b87099 speed up js tests a bit 2014-07-16 22:22:42 -07:00
Heinrich Fenkart
cc7fab893d Follow-up to #13907: simplify JS logic for focus shim 2014-07-16 08:44:56 +02:00
Heinrich Fenkart
1719d2b051 document.head is undefined in IE8 2014-07-09 00:42:02 +02:00
Heinrich Fenkart
0268b41c4f Fix IE8 reporting type object for getBoundingClientRect 2014-07-09 00:42:02 +02:00
Heinrich Fenkart
05ddea314c Fix IE8 reporting height style as all uppercase 2014-07-09 00:42:02 +02:00
Chris Rebert
21571b3412 Fix invalid HTML in "should allow html entities" tooltip unit test 
Refs #14090.
Also, fix one typo.
 2014-07-08 14:40:20 -07:00
Heinrich Fenkart
231744d628 Expose transition durations on plugin constructors; closes #13656 2014-07-07 13:03:56 +02:00
Mark Otto
907b3b2892 Merge pull request #13907 from twbs/fat-12145 
add "focus" to focused btns with button plugin
 2014-07-07 00:36:59 -07:00
fat
587c09cb48 fix scrollspy test in firefox mac os 2014-07-06 21:50:46 -07:00
Jacob
b5d86ad0bd Merge pull request #13853 from hnrch02/unit-tests-cleanup 
Major unit tests cleanup
 2014-07-06 21:43:48 -07:00
Mark Otto
44f83fff90 Merge pull request #14021 from CFXd/add_collapsed_default_class_to_navbar_collapse_button 
Add collapsed default class to navbar-toggle
 2014-07-06 16:37:42 -07:00
Mark Otto
ac18e5811d jscs fix 2014-07-06 15:08:33 -07:00
fat
cb19f4f227 Merge branch 'breaddevil-replace-scrollspy-default-behavior-test' 2014-07-06 14:11:38 -07:00
fat
b19719ea1a Merge branch 'replace-scrollspy-default-behavior-test' of git://github.com/breaddevil/bootstrap into breaddevil-replace-scrollspy-default-behavior-test 
Conflicts:
	js/tests/unit/scrollspy.js
 2014-07-06 14:11:23 -07:00
Jacob
279c46152b Merge pull request #13815 from hnrch02/tabs-fade-not-active 
Allow tabs to fade in if no initially active pane is present
 2014-07-06 13:50:54 -07:00
Heinrich Fenkart
58eb8b2ae3 Move to leading pluses 2014-07-06 11:56:12 +02:00
Chris Rebert
a34e52de4d Merge pull request #14015 from twbs/possible-14013-fix 
Possible fix for #14013
 2014-07-06 00:36:52 -07:00
Heinrich Fenkart
dad56be96c Move to 16ms from 18ms based on the Paul Irish's rAF polyfill 2014-07-06 09:24:23 +02:00
Heinrich Fenkart
8ff099585f Mention #13500 in comment for ScrollSpy test 2014-07-06 09:24:23 +02:00
Heinrich Fenkart
e341355d28 Clean tooltip unit tests up 2014-07-06 09:24:23 +02:00
Heinrich Fenkart
b3a125e941 Clean tab unit tests up 2014-07-06 09:24:23 +02:00
Heinrich Fenkart
05ba1e491e Clean scrollspy unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
56b8d5fe6e Clean popover unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
998c3724e8 Clean modal unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
9ff66a12bc Clean dropdown unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
77d0557468 Clean collapse unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
6a523bf99d Clean carousel unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
f3345f68d7 Clean button unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
b063de54a5 Clean alert unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
95d7c9c3fb Clean affix unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
4950fe6f4e Perform a cleanup after each test 2014-07-06 09:24:22 +02:00
Heinrich Fenkart
1e64c4c0ba Update QUnit settings/QUnit phantomjs bridge to new versions 2014-07-06 09:24:22 +02:00
Chris Rebert
f9ffb49932 refactor/reformat Tooltip.getPosition per @fat's feedback 2014-07-06 00:16:54 -07:00
Jacob
5830febd9a Merge pull request #13855 from hnrch02/modal-mousedown 
Use mousedown instead of click for backdrop click detection; fixes #13816
 2014-07-06 00:01:57 -07:00
Jacob
13a4c50cc7 Merge pull request #14000 from hnrch02/modal-keydown 
Only close modal if escape was hit with keydown; fixes #13929
 2014-07-05 23:55:36 -07:00
fat
c08e275000 fix build 2014-07-05 23:49:45 -07:00
fat
22f851fa62 apply #14022 without semicolon – cleans up some jquery class usage 2014-07-05 23:28:44 -07:00
Wing
4b08832308 no need to create $.Event 
`trigger()` can handle string argument
 2014-07-03 10:52:22 -07:00
Wing
48b822db40 trigger 'affixed.bs.affix' instead of 'affixed' 
Original is triggering `affixed` not `affixed.bs.affix`, only `.on('affixed.bs.affix', ...)` also catch `affixed` event.

Closes #13998.
 2014-07-03 10:52:22 -07:00
Michael Silber
1e407c81f1 Add collapsed default class to navbar-toggle 2014-07-02 16:49:03 -04:00
Chris Rebert
1ce5e9f3ae possible fix for #14013 2014-07-02 10:09:28 -07:00
Heinrich Fenkart
91f329e448 Only close modal if escape was hit with keydown; fixes #13929 2014-07-01 05:50:31 +02:00
Heinrich Fenkart
121bf6633e Use mousedown instead of click for backdrop click detection; fixes #13816 2014-07-01 02:53:57 +02:00
Mark Otto
ff6b279b3c bump to v3.2.0 2014-06-26 09:13:24 -07:00
sgamel
9445b84b0b Ensure that hidden event is sent when content is really hidden (collapsing class is removed) 2014-06-26 10:18:45 +02:00
Heinrich Fenkart
282f8fc04b Add a few more cases to the visual test tab page 2014-06-25 04:18:51 +02:00
Heinrich Fenkart
634ea59a25 Allow tabs to fade in if no initially active pane is present; fixes #13814 2014-06-25 04:18:51 +02:00
fat
6b6476fcd9 add "focus" to focused btns with button plugin 2014-06-23 23:39:54 -07:00
fat
0aa01f63e3 Merge branch 'master' into fix-13386 
Conflicts:
	js/carousel.js
 2014-06-23 23:08:23 -07:00
Chris Rebert
c2c19a4d2d Revert UMD (#13772 & friends) for now, due to #13812. 
Will hopefully revert this reversion and land a fully-working version of UMD in v3.3.0.

Revert "some changes from #13801 - add strict mode back and =="
This reverts commit 2b302f69ee.

Revert "Fix regression of #10038 introduced by #13772"
This reverts commit e9d6756a1a.

Revert "MD/CommonJS/Globals #12909"
This reverts commit 1c6fa9010d.

Revert "address #13811"
This reverts commit f347d7d955.

Conflicts:
    js/carousel.js
    js/collapse.js
    js/dropdown.js
    js/modal.js
    js/tab.js
    js/tooltip.js
 2014-06-23 11:11:59 -07:00
Heinrich Fenkart
587451ad9a Update a few source files to comply to new JSCS rules 2014-06-19 21:08:05 +02:00
Heinrich Fenkart
09c2e41ec4 Remove deprecated JSCS rules and add requireSpaceAfterLineComment 2014-06-19 21:08:05 +02:00
Erwan Jegouzo
1b63d0b9ba fix for #13747 
Closes #13782 by merging it.
 2014-06-17 17:56:15 -07:00
Chris Rebert
f071549c84 fix #13386 2014-06-13 12:12:32 -07:00
fat
2b302f69ee some changes from #13801 - add strict mode back and == 2014-06-12 11:11:04 -07:00
Jacob
696632d7da Merge pull request #13786 from twbs/fat-13430 
add special transitionend type to test event origin
 2014-06-11 22:44:04 -07:00
Heinrich Fenkart
e9d6756a1a Fix regression of #10038 introduced by #13772 2014-06-12 06:00:02 +02:00
Jacob
6ac5708a0d Merge pull request #13787 from twbs/fat-3731 
fix #13185 - keyboard support for carousel
 2014-06-11 15:19:39 -07:00
fat
7f122be004 add special transitionend type to test event origin 
fixes #13430
 2014-06-10 20:42:19 -07:00
fat
a1dad14f44 fix #13185 - keyboard support for carousel 2014-06-10 20:35:03 -07:00
fat
571fd32bce fix #13220 Scrollspy generates wrong offsets for a page-- recalculate offsets if scrollheight changes 2014-06-10 17:38:42 -07:00
Katie Zhu
1c6fa9010d MD/CommonJS/Globals #12909 2014-06-10 17:16:29 -07:00
Katie Zhu
5eaedbe097 change how carousel indicators activate #12592 2014-06-09 21:59:03 -07:00
Jacob
fe74a8bb3e Merge pull request #13755 from twbs/fat-visual-test 
Adds isolated visual tests for javascript plugins (decoupled from docs)....
 2014-06-08 16:05:08 -07:00
fat
91103e6d1f Adds isolated visual tests for javascript plugins (decoupled from docs). This makes it 
faster and easier to test/develop js functionality not represented in unit tests, and gives us
a playground for interactions, etc.

It also makes it so developing javascript is now decoupled form jekyll, which should make everything
faster and less painful.

This commit also reverts my filter commit 9900771aa7
which broke scrollspy for dropdowns.
 2014-06-07 19:11:44 -07:00
Mike Greiling
1cfa902e31 refactor scrollspy refresh method 
Closes #13702 by merging a rebased version of it.
 2014-06-07 18:26:39 -07:00
Mike Greiling
bc8e6ffb7d removing this.$element as it is a superfluous copy of this.$scrollElement 2014-06-07 18:09:53 -07:00
Mike Greiling
632313d631 no need to check for href attribute on the scrollable element 2014-06-07 18:09:53 -07:00
Mike Greiling
0be4109688 there is no need for this.offsets and this.targets to be jQuery objects 2014-06-07 18:09:53 -07:00
Chris Rebert
21de05c8c0 don't show tooltips/popovers whose element isn't in the DOM; fixes #13268 2014-06-07 17:54:11 -07:00
Chris Rebert
b23ed1b034 put the tooltips into the DOM in the tooltip unit tests 2014-06-07 17:54:11 -07:00
Chris Rebert
20c099d41a add failing test for #13268 2014-06-07 17:54:10 -07:00
XhmikosR
3b99a41246 Merge pull request #13388 from twbs/xhmikosr-js-style 
Improve JS style
 2014-06-07 09:13:05 +03:00
Chris Rebert
3cbbc70d55 Merge pull request #13627 from twbs/maybe-fix-12364 
Hopefully fixes trigger focus restoration on modal close
 2014-06-06 15:59:17 -07:00
XhmikosR
e2cabe4971 Minor style tweaks. 2014-06-06 01:23:07 +03:00
XhmikosR
82fc03f3b6 carousel.js: remove unneeded variable assignment. 
`slideIndex` is assigned to the same value a few lines above.
 2014-06-06 01:23:07 +03:00
XhmikosR
7b0acf14d8 Comply to the new style. 2014-06-06 01:23:07 +03:00
XhmikosR
5ef9383f53 Tweak JSHint and JSCS checks. 
Be more consistent across the whole codebase.

Also, make use of JSHint's 2.5.1 `extends` and `qunit` options. This way we set our basis options in js/.jshintrc and override the rest.
 2014-06-06 01:23:06 +03:00
Chris Rebert
475dbe58b0 Merge pull request #13589 from mrobinet/scrollspy-maxScroll-with-offset 
Adjust for Scrollspy offset when calculating maxScroll.
 2014-05-23 14:36:05 -07:00
Chris Rebert
bc1ce426d9 Merge pull request #13593 from ResentedHook/master 
Add tooltip self-reference to address #12320
 2014-05-23 14:33:19 -07:00
Chris Rebert
ef62254917 Merge pull request #13557 from bassettsj/aria-describedby-tooltip-13480 
Aria describedby tooltip: #13480
 2014-05-23 14:11:15 -07:00
Max Kramer
ee12ce8305 Add aria-haspopup and aria-expanded attributes to dropdown plugin 
1. Add aria-haspopup="true" and aria-expanded="false" to dropdown docs
2. Toggle aria-expanded between "true" and "false" when opening and closing dropdown

Satisfy item 1 from https://github.com/paypal/bootstrap-accessibility-plugin#dropdown. See #13553.
 2014-05-22 18:13:41 -04:00
Chris Rebert
b058c018eb Hopefully a fix for #12364 
* register the callback before invoking the toggling
* listen for `hidden` instead of `hide`
* account for the possibility of the associated `show` event being preventDefault-ed

Adds relevant unit tests.
 2014-05-19 02:14:14 -07:00
Chris Rebert
e9b99d475c fix typo in assertion description 2014-05-19 00:47:06 -07:00
Chris Rebert
3d1723d689 add missing event namespacing in modal.js 2014-05-16 17:05:03 -07:00
Attila Dobi
f47ad79538 add target option to Affix plugin 2014-05-16 13:07:45 -07:00
Steven Bassett
a70da16f6f Adds aria described by to tooltip plugin for accessibility 
Generates a unique id for tooltip and adds [aria-describedby] to the element
it is called on. Resolves issue #13480

- set up test
- linted the code styles
- passed the tests
- integrated feedback from @cvrebert
 2014-05-16 10:45:38 -07:00
j.corns
122c05dbd8 Add tooltip self-reference to address #12320 
primarily adds a data- attribute to the tooltip (and thus, the popover)
to create a self-reference.
 2014-05-14 10:36:32 -07:00
Mike Robinet
c2e94eba8d Add Scrollspy maxScroll with offset test. 2014-05-13 12:53:54 -05:00
Mike Robinet
e84b0c0433 Adjust for Scrollspy offset when calculating maxScroll. 2014-05-13 09:57:04 -05:00
XhmikosR
7a765d1f8b Update jQuery to v1.11.1. 2014-05-13 08:33:23 +03:00
fat
f219fee07b versions 2014-05-12 21:15:16 -07:00
Jacob
c312d735d9 Merge pull request #13191 from AshleyDawson/master 
Fixed nested tab elements li activation
 2014-05-12 20:57:21 -07:00
fat
9900771aa7 fixes #12211: Scrollspy: Navs in different tabs can interfere with each othe 2014-05-12 19:15:23 -07:00
Gregory Pakosz
78cac11cef Fixed affix-bottom positioning 
Set top position to (scrollHeight - this.$element.height() - offsetBottom).
 2014-05-09 00:26:31 +02:00
Chris Rebert
9444df2476 Merge pull request #13511 from hnrch02/button-reset-falsey-values-fix 
Allow for resetText of a button to be a falsey value; fixes #13466
 2014-05-05 22:55:05 -07:00
Chris Rebert
a032c396ee Merge pull request #13406 from EnsignR/closed.bs.alert-after-remove 
fires closed.bs.alert *after* DOM detach() as per #12379
 2014-05-05 22:47:50 -07:00
Heinrich Fenkart
d8ee1ba9b6 Allow for resetText of a button to be a falsey value; fixes #13466 2014-05-05 19:07:47 +02:00
Chris Rebert
06af640e82 import rules from Ratchet's JSCS config with which we already comply 2014-05-04 15:15:02 -07:00
breaddevil
7627b24c1e replace js scrollspy test for default behavior 2014-05-04 11:24:31 +02:00
Chris Rebert
d9edf28c5f make new Carousel tests compatible with noConflict mode 2014-05-01 13:37:44 -07:00
Chris Rebert
b23ca2de41 add role="tooltip" to popovers; fixes #13481 2014-05-01 13:27:00 -07:00
Mark Otto
f20f66604b Merge pull request #11966 from colllin/noconflict 
Fix #11464 - JS noConflict() mode not working in 3.0.x
 2014-04-30 17:43:43 -07:00
Ross Nye
73f7acc01b Update alert.js 
Added call to remove() after event fires to clean up data as per discussion at #12379
 2014-04-30 13:12:31 +10:00
Chris Rebert
05d4932cad Merge pull request #13396 from twbs/carousel-events 
Carousel event properties
 2014-04-25 19:35:38 -07:00
Chris Rebert
e114727ae9 Carousel.slide: rename e => slideEvent 2014-04-25 17:50:38 -07:00
Chris Rebert
4bd29bfcff change 'slid' comments per @fat's feedback 2014-04-25 17:48:02 -07:00
Chris Rebert
4d0a8e31a4 Add direction & relatedTarget properties to slid.bs.carousel event 
Fixes #13393
 2014-04-24 19:02:47 -07:00
Ross Nye
637808f2ee fires closed.bs.alert *after* DOM detach() 
fires closed.bs.alert *after* element is removed from DOM.
Previously it fired while the element was still attached.
 2014-04-23 17:34:32 +10:00
Collin Donahue-Oponski
a9f2b6ce0f #11464 - Fix JS noConflict mode - Refactor all plugins to use an internal reference to the jQuery plugin, because in noConflict mode you can never expect to be defined on the jQuery object 2014-04-21 23:03:33 -06:00
fat
b9ae07d84a fixes #13157 - Collapse plugin - issues with transition end event bubbling 2014-04-21 17:35:29 -07:00
Chris Rebert
f66a747615 add unit tests for Carousel slid events 2014-04-21 13:14:53 -07:00
Chris Rebert
9c4afc5772 spelling fixes in Carousel unit tests 2014-04-21 13:08:42 -07:00
Chris Rebert
d971ddb730 add missing operators to some JSCS rules that we already comply with 2014-04-20 16:33:23 -07:00
Tobias Lindig
a69bc3bc09 move call for removeBackdrop() to backdrop() 
Closes #11958 by rebasing & merging it
 2014-04-20 14:47:32 -07:00
Jacob
b02d3c7eff Merge pull request #13306 from twbs/fat-11099 
fixes #11099 - $.collapse() overrides the original dimension of the coll...
 2014-04-20 12:12:17 -07:00
Jacob
4f427cbe32 Merge pull request #13354 from twbs/fat-13296 
fixes #13296 Dropdown disappears with right-click on Firefox
 2014-04-20 12:11:25 -07:00
Chris Rebert
170ba560c2 quote attribute value in ^= selector in button.js 2014-04-19 18:53:23 -07:00
Chris Rebert
a54e6d4ea9 rename jquery.js -> jquery.min.js since it's minified 2014-04-19 18:25:40 -07:00
Chris Rebert
0aaf2cdd3a quote attribute values in selectors in JS unit tests for consistency 2014-04-19 17:45:58 -07:00
fat
f2af95353e fixes #13296 Dropdown disappears with right-click on Firefox 2014-04-15 21:52:34 -07:00
fat
cd4696f723 fixes #11099 - $.collapse() overrides the original dimension of the coll... 2014-04-15 21:16:40 -07:00
Germán M. Bravo
82b066f0a9 Wait for the expected target during a collapse 
Actually wait for the collapsed item to complete. If complete is called
with other target, instead of simply returning and do nothing, wait again
until the proper target triggers the event (otherwise this leaves collapse
in a broken state).
 2014-04-12 14:44:35 -05:00
XhmikosR
45b476bdbf JS: remove unused variables. 2014-04-09 10:01:48 +03:00
Collin Donahue-Oponski
d7a3771abd When opening the dropdown, focus() the dropdown-toggle BEFORE triggering 'shown.bs.dropdown' 
Closes #11281 by merging it (after rebasing & resolving conflicts)
 2014-04-08 22:36:21 -07:00
Chris Rebert
5ef634dab9 replace $.bind() with $.on() in unit tests; per #13272 2014-04-03 18:13:16 -07:00
XhmikosR
2b30b48894 Fix the new JSHint warnings. 2014-04-03 10:53:13 +03:00
Chris Rebert
26f6807a3d Add comments in carousel.js to clarify that "slid" is not a typo 
Addresses #13248.
 2014-03-31 18:09:24 -07:00
Tyler Cipriani
0907244256 Modal body shift fix for IE10/11 
Closes #13103 by merging it.
 2014-03-28 23:45:22 -07:00
Ashley Dawson
138af82e29 Fixed nested tab elements li activation 
Added closest li instead of direct parent so that you can nest multiple elements within tabs, such as button groups
 2014-03-26 22:21:54 +00:00
Jacob
b3421cf040 Merge pull request #13165 from stefanneculai/master 
Fix popover when using append
 2014-03-24 22:42:40 -04:00
Mark Otto
39fec66fc4 Merge branch 'master' into fat-9461 2014-03-24 19:30:17 -07:00
fat
4a2d337bf5 fixes #9461 - Make carousel ignore non-items in carousel-inner 2014-03-24 19:23:39 -07:00
Stefan Neculai
674b41dd63 Add test for popover. 2014-03-24 19:49:06 +02:00
Stefan Neculai
41628c90a2 Fix popover when using append. 2014-03-24 18:49:03 +02:00
XhmikosR
d74aee4093 tests/index.html: re-indent. 2014-03-24 09:30:44 +02:00
XhmikosR
cfb7093dc0 tests/index.html: add missing meta charset. 2014-03-24 09:28:57 +02:00
XhmikosR
58ea8a5601 Update QUnit to v1.14.0. 2014-03-24 09:28:57 +02:00
Ben Ogle
8534e12523 Add tooltip viewport option, respect bounds of the viewport 2014-03-21 11:28:13 -07:00
Chris Rebert
7cf7e42c67 Merge branch 'hnrch02-modal-toggle' 2014-03-16 20:24:59 -07:00
Heinrich Fenkart
4e4e456341 Fix #12845 - Modal#hide should only be called with an event argument 
Closes #12850
 2014-03-16 20:24:33 -07:00
Jacob
fa4379de08 Merge pull request #12862 from sultano/patch-1 
Fixed flickering and simplified calculations
 2014-03-16 20:24:21 -07:00
Zlatan Vasović
ead17b7ca6 Fix #12375: stop using document.body.scrollTop as it's deprecated in the strict mode 
Closes #12377
 2014-03-16 20:10:52 -07:00
Tobias Lindig
0f366e0376 correct event naming of scroll and `load' event 
closes #12337
 2014-03-16 19:58:12 -07:00
fat
615dcb5ca0 fixes #9855 2014-03-16 18:38:47 -07:00
Julian Thilo
6d882a6420 Fix JSHint errors 
X-Ref: 8c9739d477
 2014-03-14 18:16:36 +01:00
Chris Rebert
b50d4a176f Merge pull request #13060 from twbs/role-tooltip 
add role="tooltip" to tooltips by default to improve accessibility
 2014-03-13 21:50:01 -07:00
Jacob
905c78129f Merge pull request #11937 from IHomer/master 
Fix: IE10 or lower incorrectly determines the scrollheight of the body. ...
 2014-03-13 21:45:04 -07:00
Jacob
8c9739d477 Merge pull request #11453 from moodyroto/patch-1 
fix scrollspy for targets within tabs
 2014-03-13 21:44:05 -07:00
Chris Rebert
8a6cdff825 add role="tooltip" to tooltips by default to improve accessibility 
See https://github.com/paypal/bootstrap-accessibility-plugin/blob/master/README.md#tooltip
 2014-03-13 15:05:13 -07:00
Chris Rebert
6dd51fab44 fix #12771 2014-03-10 00:06:38 -07:00
XhmikosR
9d027d2bee Remove unneeded quotes. 2014-03-09 11:10:52 +02:00
fat
4d96e69a55 fixes #9836 2014-03-08 19:45:38 -08:00
fat
e9cced72fd fix #9342 2014-03-08 19:20:47 -08:00
Chris Rebert
297303a7cc use quotes around all element attr vals in JS; fixes #12946 2014-03-06 11:12:17 -08:00
XhmikosR
2545073024 Move trailing check to JSCS. 2014-02-28 17:30:08 +02:00
XhmikosR
be8f125ce6 Move camelcase check to JSCS. 2014-02-28 17:30:08 +02:00
XhmikosR
2619325626 JSCS: Use more style checks. 2014-02-28 17:30:08 +02:00
XhmikosR
d65f749390 Move the quotes check to JSCS. 2014-02-28 17:30:08 +02:00
XhmikosR
537e10033e Switch to using JSCS for the indentation check. 2014-02-28 17:30:08 +02:00
Suleman Chikhalia
f7c360d620 Fixed flickering and simplified calculations 
- Removed offending line causing a flicker to the default top state
- Simplified calculation of the top offset when in the bottom state
 2014-02-27 00:39:46 -08:00
XhmikosR
63031a3ca5 Bump grunt-jscs-checker. 2014-02-26 19:32:43 +02:00
jonahss
7a80b801d7 updated qunit test reporting so sauce labs can report failing tests 2014-02-21 18:54:50 -08:00
Mark Otto
70b875ceb3 Merge pull request #12761 from hnrch02/no-event-aliases 
Remove event aliases from JavaScript
 2014-02-21 15:14:22 -08:00
XhmikosR
25d047ded4 Merge pull request #12058 from ZDroid/uti 
Remove semicolons from JS tests
 2014-02-18 13:21:05 +02:00
Zlatan Vasović
a4dac463e0 Improve js/tests/index.html 
- Improve comments.
- Remove `transition.js` script load as `transition.js` unit test doesn't exist.
 2014-02-18 10:43:24 +01:00
Zlatan Vasović
a06e15dd36 Remove semicolons from JS tests 2014-02-17 20:56:46 +01:00
Chris Rebert
8eeab63e7e Merge pull request #12720 from twbs/reident-test-files 
Reindent test files
 2014-02-16 12:13:04 -08:00
Heinrich Fenkart
8a78bc065f Remove event aliases from JavaScript 
Makes life for people with custom jQuery builds excluding event aliases much easier.
 2014-02-16 21:00:04 +01:00
XhmikosR
5566c935f2 Merge pull request #12513 from ZDroid/jshint 
Remove `curly: false` from `.jshintrc`
 2014-02-16 20:45:00 +02:00
Zlatan Vasović
69cb7be07f Remove curly: false from .jshintrc 2014-02-16 19:30:02 +01:00
XhmikosR
895b0006b9 Re-indent test files. 2014-02-14 11:02:03 +02:00
Mark Otto
88fdd45427 v3.1.1 bump 2014-02-13 01:12:26 -08:00
XhmikosR
8939268a33 Update jQuery to v1.11.0. 
Also, use Google's CDN per #11369.
 2014-01-30 20:50:17 +02:00
Mark Otto
1409cde7e8 Bump versions, run grunt 2014-01-30 08:30:37 -08:00
Tobias Lindig
084f0fb113 add namespace .bs also to the event dismiss.modal 2014-01-17 12:16:53 -08:00
Tobias Lindig
7fab3c30f2 remove needless space character 2014-01-17 13:34:03 +01:00
Chris Rebert
6af0013ac5 Revert "Add tooltip viewport option, respect bounds of the viewport" 
This reverts commit edb221a20c.
Reverting due to broken JS unit tests.

Conflicts:
	docs/javascript.html
 2014-01-16 20:32:59 -08:00
Mark Otto
03f4534307 Merge branch 'bo-tooltip-viewport' of https://github.com/benogle/bootstrap into benogle-bo-tooltip-viewport 
Conflicts:
	docs/javascript.html
 2014-01-16 20:01:28 -08:00
fat
4bd6a52562 add missing paren 2014-01-16 14:28:21 -08:00
fat
82ff4e2e40 tooltip subpixel test fixes 2014-01-16 14:25:28 -08:00
fat
3b2418e688 remove flaky pos bottom test which is effect by unit scroll pos 2014-01-16 13:44:08 -08:00
fat
2f76821a4d new qunit 2014-01-16 13:33:09 -08:00
Islam Sharabash
ad64b0acc8 Fixing js error in IE9 where no transition is supported 2014-01-16 10:11:59 -08:00
Chris Rebert
b260d93c58 more detailed QUnit test results in Sauce 2014-01-14 20:21:15 -08:00
Ben Ogle
edb221a20c Add tooltip viewport option, respect bounds of the viewport 2014-01-14 17:42:29 -08:00
Chris Rebert
dde38280f7 upgrade to QUnit v1.0.0 2014-01-13 19:21:07 -08:00
Chris Rebert
bfe74f7b2f Revert accidental overzealousness from 16eccc43d9 
Let's not confuse the archaeologists & historians.
 2014-01-13 19:09:51 -08:00
Chris Rebert
c9ba678b9f JSCS can be dumb sometimes 2014-01-08 12:37:10 -08:00
Chris Rebert
5f328dce88 Merge pull request #12057 from ZDroid/nl 
'use strict' on new line
 2014-01-07 00:31:27 -08:00
Julian Thilo
7fcfe61f4d Update copyright notices in all places 
- Implements new format "Copyright 2011-xxxx Twitter, Inc.", which resonates well with our History page and more accurately reflects the copyright status of the repo
- grunt dist to update all the files
 2014-01-07 01:05:24 +01:00
Kevin Sawicki
5141e4da10 Use $ instead of jQuery 2014-01-03 14:39:18 -08:00
Zlatan Vasović
0f060e7bc4 'use strict' on new line 2014-01-01 15:42:41 +01:00
Zlatan Vasović
1c83d68ca4 New Year 2014-01-01 15:37:08 +01:00
fat
2a0b99104c Merge branch 'dropdown-aria-roles' of git://github.com/plumlee/bootstrap into plumlee-dropdown-aria-roles 
Conflicts:
	js/dropdown.js
 2013-12-29 19:23:15 -08:00
fat
8a62f21113 fixes #11379 - Fix carousel this.sliding not getting reset if $next.hasClass('active') 2013-12-29 19:01:32 -08:00
fat
76f0d0ff32 fixes #11373 - adds related target to dropdown events 2013-12-29 18:57:22 -08:00
fat
162d9e1776 Merge branch 'scrollspy-speedy-scroll-top' of git://github.com/ziogaschr/bootstrap into ziogaschr-scrollspy-speedy-scroll-top 
Conflicts:
	dist/js/bootstrap.min.js
 2013-12-29 18:04:43 -08:00
fat
9d73d9c38c Merge branch 'master' of github.com:twbs/bootstrap 2013-12-29 17:54:40 -08:00
fat
ce4a2e4352 fixes #11288 - Vertical scroll position of modal saves between openings 2013-12-29 17:53:59 -08:00
Jacob
ea40e7999d Merge pull request #11203 from jasny/patch-1 
Scrollspy acting up when targets are hidden
 2013-12-28 22:06:26 -08:00
fat
5bf13914e4 fixes #10658 jQuery Popover content loses bound events on second setContent call. 2013-12-28 20:59:45 -08:00
fat
c595db19ff fixes #10911 - add loading event for use with remote option :| 2013-12-26 20:26:27 -08:00
fat
d21369c1ed fixes #10890 2013-12-26 19:40:18 -08:00
fat
3c73904e17 update tool/pop destroy placement 2013-12-26 18:27:43 -08:00
Jacob
6baf266cda Merge pull request #10761 from jochenberger/dont-create-tooltip-for-destroy 
don't create new Tooltip/Popover objects just to destroy them immediately
 2013-12-26 18:25:29 -08:00
fat
39091b0748 nope 2013-12-26 18:18:53 -08:00
Jacob
bf3c525d05 Merge pull request #11496 from satazor/patch-1 
Clear timeout on destroy.
 2013-12-26 18:18:09 -08:00
fat
34fb5767cb fixes #10798 2013-12-26 17:53:31 -08:00
Jacob
37bfd8fa60 Merge pull request #10801 from Travesty3/master 
Add 'collapse' class back after expanding
 2013-12-26 17:50:41 -08:00
Jacob
bea46fca70 Merge pull request #10834 from Prinzhorn/master 
Only preventDefault on click on [data-toggle="modal"] when the element is a link
 2013-12-26 17:46:59 -08:00
Mark Otto
d8e4c1578d Merge pull request #12010 from ZDroid/wrong-indent 
Fix wrong indent in .jscs.json
 2013-12-26 12:54:23 -08:00
fat
fc7049b18f fixes #10675 2013-12-25 20:33:05 -08:00
fat
c25fa0661a Merge branch 'tooltip-events-fix' of git://github.com/lukaszfiszer/bootstrap into lukaszfiszer-tooltip-events-fix 
Conflicts:
	js/tooltip.js
 2013-12-25 20:03:28 -08:00
Zlatan Vasović
1e05029d1a Fix wrong indent in .jscs.json 2013-12-25 20:22:52 +01:00
fat
dffd4ffad2 Merge branch 'master' of github.com:twbs/bootstrap 2013-12-24 17:00:55 -08:00
fat
394e0fa611 fixes #11788 - focusin focusout instead of focus/blur 2013-12-24 17:00:34 -08:00
Jacob
0fab6e7ea7 Merge pull request #11722 from DocX/patch-1 
Use document scroll height instead of offset height
 2013-12-24 16:43:24 -08:00
fat
c77740bd3a fixes #11720 - Add events trigger to affix 2013-12-24 16:29:51 -08:00
Jacob
139b395dfb Merge pull request #10359 from ixti/patch-1 
Pass $element to offset top/bottom calc funcs
 2013-12-24 13:21:19 -08:00
fat
a93a753c7d fixes #10134 – dont use jquery offset directly because it uses sub pixel rendering 2013-12-24 13:07:42 -08:00
fat
fe7fffe034 Merge branch 'slide-event-reset' of git://github.com/Rowno/bootstrap into Rowno-slide-event-reset 
Conflicts:
	js/tests/unit/carousel.js
 2013-12-24 12:50:55 -08:00
fat
0a75e4c09b fixes #10283 2013-12-24 12:40:24 -08:00
fat
558b6a478d Merge branch 'master' of github.com:twbs/bootstrap 
Conflicts:
	dist/js/bootstrap.min.js
	docs-assets/js/raw-files.js
 2013-12-24 12:35:24 -08:00
fat
50bd4edb8c fixes #10236 
if affixed top add scrollTop to it position.top
calculate and cache pinnedoffset independent of scrolling for initial load
 2013-12-24 12:32:06 -08:00
Mark Otto
5c2dfbf33b Merge branch 'master' of github.com:twbs/bootstrap 
Conflicts:
	docs-assets/js/raw-files.js
 2013-12-24 12:17:48 -08:00
Mark Otto
679c786237 roll back version numbers to avoid broken links in docs and readme (fixes #12000) 2013-12-24 12:16:17 -08:00
fat
fe839e6e78 change where modal loads content -– fixes #10105, #9318, #9459 2013-12-23 23:30:06 -08:00
fat
1fc08c1973 fixes #10568 - kill hoverstate info once command has been executed 2013-12-23 22:57:39 -08:00
fat
a87b150bc7 fixes #10205 Scrollspy Doesn't Support Chinese ID Targets http://mathiasbynens.be/notes/html5-id-class 2013-12-23 22:08:43 -08:00
Mark Otto
45a8a9508e Merge pull request #11974 from XhmikosR/meta 
Normalize meta
 2013-12-22 22:20:23 -08:00
XhmikosR
a05a11e5dc Get rid of JSHint's laxcomma option now that the comma is used on the right side. 2013-12-22 09:02:08 +02:00
XhmikosR
6e3ac8f2a4 js/.jscs.json: sort by name. 2013-12-22 08:59:36 +02:00
Zlatan Vasović
1bf5abab31 No leading pluses 2013-12-19 15:32:37 +01:00
joep.joosten@ihomer.nl
1ceab8b89f Fix: IE10 or lower incorrectly determines the scrollheight of the body. Use document.documentElement for IE. To make this browser agnostic, the maximum scrollheight of both body and documentElement is used. 2013-12-19 12:41:33 +01:00
joep.joosten@ihomer.nl
3bcb1cc255 Fix: IE10 or lower incorrectly determines the scrollheight of the body. Use document.documentElement for IE. To make this browser agnostic, the maximum scrollheight of both body and documentElement is used. 2013-12-19 12:18:51 +01:00
fat
22f9767714 check that href id's are followed by valid char – fixes #10044 2013-12-18 21:14:01 -08:00
Chris Rebert
df3716647d update licensing header in JS files & run grunt 2013-12-18 15:29:19 -08:00
Mark Otto
b9ca65ebe7 Merge pull request #11416 from danielboendergaard/carousel-duration 
Carousel: Use the transition duration from CSS
 2013-12-18 15:01:47 -08:00
Mark Otto
e8e60ae4bc version bump 2013-12-18 14:56:08 -08:00
Zlatan Vasović
ba3639b202 Require comma on left side 2013-12-16 18:06:31 +01:00
Mark Otto
35dd6b9fd7 Merge pull request #10704 from XhmikosR/various 
rm unused vars
 2013-12-14 18:55:25 -08:00
Zlatan Vasović
7f6cf5e50c Add try and catch to keywords 2013-12-14 21:57:59 +01:00
Scott Plumlee
bbe551044c Allow listbox AIRA role on dropdown component. 2013-12-10 14:17:32 -05:00
XhmikosR
5749039f8d Remove unused variables. 2013-12-10 10:11:10 +02:00
XhmikosR
eca8ff3803 Use single quotes consistently. 2013-12-08 12:44:14 +02:00
Chris Rebert
c1dae1e13c integrate JSCS 2013-12-06 17:26:07 -08:00
Chris Rebert
351f86e1db fix some JS to pass jscs 2013-12-06 17:23:45 -08:00
XhmikosR
5e2ef69e1c Use a space before functions' bracket consistently. 2013-12-06 12:43:48 +02:00
XhmikosR
4aad52797c Use a space after function consistently. 2013-12-06 12:43:48 +02:00
Lukáš Doležal
6e9efb2024 Use document scroll height instead of offset height to support body with absolute height 2013-12-05 16:28:31 +01:00
mdxs
f7d21d6919 Dropping unused variable in dropdown.js 
Dropping an unused variable in the Dropdown function inside the `dropdown.js` code.

There are no new/changed unit tests, as there are no feature/bug changes requiring new test cases.

For the record: I agree to dual-license this contribution under the Apache 2 and MIT licenses.
 2013-12-04 11:15:48 +01:00
Mark Otto
8a74264344 bump version numbers to 3.0.3 2013-12-01 19:31:52 -08:00
Mark Otto
a06610a030 Merge pull request #11502 from 1000hz/patch-1 
Add missing data namespace for dropdown
 2013-11-29 23:55:43 -08:00
Michael Rotoloni
24e3a8b859 Added unit test for removing only active class from within the scroll spy key. 2013-11-18 09:29:10 -05:00
Valera Rozuvan
ad86d9a51b Update dropdown.js 2013-11-18 11:55:33 +02:00
Cina S.
56f6847ed6 Add missing data namespace for dropdown 2013-11-16 09:43:47 -06:00
André Cruz
926b940e86 Clear timeout on destroy. 
Clears the internal timeout on destroy so that hanging timers are not fired.
 2013-11-15 23:33:23 +00:00
fat
7545da2e3c fixes #11477 and updates slid event in carousel with namespace 2013-11-14 23:58:29 -08:00
moodyroto
9f30f55721 Update scrollspy.js 
Scrollspy target in tab content does not work properly. Calling .parents('.active') will return all parents with an active class (including the tab pane). Changing this line to .parentsUntil(this.options.target, '.active') should resolve the issue. This will scope the query to only search for active elements inside the scrollspy target.
 2013-11-11 12:21:34 -05:00
Brian Leonard
5d6e9212a6 Don't deselect radio buttons in data-toggle; fixes #9920 
Merges #10787
 2013-11-10 17:23:11 -08:00
Nathan Muir
934d1bcae5 Add unit test for #9920 
Merges #10385
 2013-11-10 17:23:11 -08:00
Daniel Bøndergaard
268f20e84c Carousel: Use the transition duration from CSS 
This makes it possible to change the transition duration in CSS
 2013-11-08 11:55:06 +01:00
Chris Ziogas
ed5dbf1b2b Update affix properly on scrollspy speedy scroll to top of page #11310 
Fix scrollspy.js so as affix is updated properly when user scrolls fast
to top of page.

A fix for issue #11310.
 2013-11-07 16:39:57 +02:00
Mark Otto
6a42305565 bump versions to v3.0.2 2013-11-06 12:57:28 -08:00
Chris Rebert
f1b0cd491c Merge pull request #10039 from daguej/js-refs 
Don't explicitly reference global jQuery
 2013-11-05 16:55:55 -08:00
Chris Rebert
4e0d022de5 update version numbers in JS file comment headers to v3.0.1 & regrunt 2013-11-01 17:15:34 -07:00
Jared Christensen
583697fec3 JS comments pointed to new documentation 2013-10-29 12:10:47 -05:00
Chris Rebert
7b24f3c47c QUnit.equals() is deprecated; use QUnit.equal() instead 2013-10-25 14:14:30 -07:00
Zlatan Vasović
63433fbef9 Update license year 2013-10-22 18:41:33 +02:00
Arnold Daniels
5a38a5775f Scrollspy acting up when targets are hidden 
If elements are hidden using `display: none;` which are targets mapped by scrollspy, the plugin might select an incorrect or no menu item.

Checking if the target is visible solved this.
 2013-10-22 13:31:23 +02:00
Chris Rebert
f11aa31023 Merge pull request #10519 from zba/master 
changed attr('data-target') to data('target');
 2013-10-14 19:14:58 -07:00
Zlatan Vasović
62c905f5bc Remove [type] 
type="text/css" isn't needed
 2013-10-09 09:45:05 +02:00
Alexander Prinzhorn
12a3bb31f8 Only preventDefault on click on [data-toggle="modal"] when the element is a link 
In it's current state Bootstrap always prevents the default action for a click
event on `[data-toggle="modal"]` elements
(see https://github.com/twbs/bootstrap/blob/master/js/modal.js#L233).
Instead this should only happen when the element is a link.
 2013-09-27 11:32:06 +02:00
Travesty3
1c1850f63e Add 'collapse' class back after expanding 2013-09-25 08:59:01 -04:00
Jochen Berger
f350d1ba3d don't create new Tooltip/Popover objects just to destroy them immediately 2013-09-23 15:14:37 +02:00
XhmikosR
3c0489102e Sort by name. 2013-09-18 20:36:17 +03:00
Alexey
7ee2b6a976 changed attr('data-target') to data('target'); 
this will extend js interface, to be possible to setup targets for tabs as 
    var content=$('<div class="tab-pane">',{text: 'content'});
    var tab=('<li>',{html: $('<a>',{text: 'Main options'})}).addClass('active').data({target: $main,toggle: 'tab'}).appendTo(tabs);
 2013-09-08 04:49:27 +03:00
Aleksey V. Zapparov
626cef9fa4 Pass $element to offset top/bottom calc funcs 
At the moment to make dynamic top offset calculator on multiple elements, one would write:

``` javascript
$('.my-affix').each(function () {
  var $el = $(this);
  $el.affix({
    offset: {
      top: function () { return $el.offset().top; }
    }
  });
})
```

This patch will allow to:

``` javascript
$('.my-affix').affix({
  offset: {
    top: function ($el) { return $el.offset().top; }
  }
});
```
 2013-09-02 03:24:27 +02:00
Roland Warmerdam
ed1bd2b150 carousel: correctly reset when the slide event is prevented 2013-08-31 18:03:09 +12:00
Martin Hansen
6d3ad5ed7f deleted files not used anymore after transition to grunt-contrib-qunit 2013-08-30 21:39:48 +02:00
Lukasz Fiszer
0adb4e35f0 Fix hidden.bs.tooltip and shown.bs.tooltip events firing too early in tooltip.js 
* events fire only after the CSS animation is completed
* this fixes also events in popover.js (as it inherits from tooltip.js)
 2013-08-26 20:57:47 +02:00
Josh Dague
f140084f2b Don't explicitly reference global jQuery 
Removes `window.jQuery` in favor of `jQuery`, fixes #10038
 2013-08-22 14:50:15 -04:00
fat
734b6acf13 add small fix for tooltip consistency + fix customizer syntax issue 2013-08-17 20:28:58 -07:00
fat
4696565044 fixes #9745 2013-08-17 16:18:26 -07:00
fat
63ac9e354f fixes #9674 2013-08-17 16:13:48 -07:00
fat
c0eabdda9f fixes #9543 2013-08-17 16:11:05 -07:00
fat
d754e6564d add some crap 2013-08-17 15:54:42 -07:00
fat
1d53dd31f5 add role=menu to html 2013-08-17 15:48:29 -07:00
fat
a10ec62f63 fixes #9579 2013-08-17 15:05:59 -07:00
fat
712b89ed4e fixes #9362 2013-08-17 14:24:38 -07:00
fat
5e89f71ab2 fix for #8768 2013-08-17 13:14:19 -07:00
Mark Otto
237640c706 Drop the accordion for the panel 
* Deletes the accordion.less file
* Extends the panel to be collapsible with our JS plugin
* Supports panel color variations
 2013-08-12 23:36:25 -07:00
Jacob Thornton
92c2ad98e7 fixes #8983 2013-08-11 15:41:06 -07:00
Jacob Thornton
89b3cb0dac fixes #9318 2013-08-11 15:17:04 -07:00
Jacob Thornton
bf2ab457ea fix comment in tooltip 2013-08-11 14:59:39 -07:00
Jacob Thornton
6393a78bf0 fixes #9279 2013-08-11 14:32:32 -07:00
Jacob Thornton
1abb7947c2 fixes #9222 2013-08-10 14:09:05 -07:00
Jacob Thornton
a4f0e8d37a fixes #9111 2013-08-10 13:35:20 -07:00
Jacob Thornton
dbed9da774 fixes #6159 2013-08-09 00:16:47 -07:00
Chris Rebert
f86f6ee955 fix 'Calcuated' typo & run grunt; thanks @FagnerMartinsBrack 
fixes typo introduced in 2b6ec38987
 2013-08-08 13:31:22 -07:00
Jacob
d22bd3a660 Merge pull request #9089 from jdiamond/3.0.0-wip 
accordion's data-parent can't contain dots
 2013-08-07 23:37:05 -07:00
Braden Whitten
f816a18f79 Fix spacing after '=' 
Just added a space after a function definition to tidy up the code.
 2013-08-06 17:02:57 -04:00
Mark Otto
f266595092 Fixes #9150: Hide popover titles in IE8 
Properly hides popover titles in IE8 because apparently it doesn't
accept the `:empty` selector. /cc @fat @cvrebert
 2013-08-06 11:18:12 -07:00
Jason Diamond
fb57eda268 use quotes to allow dots in data-parent 2013-08-04 23:59:57 -07:00
Jason Diamond
700e742a9c failing test for dot in data-parent 2013-08-04 23:59:30 -07:00
Chris Rebert
180034a4b4 tooltip.js: add missing space 2013-08-04 17:36:08 -07:00
fat
2b6ec38987 fixes #8880 2013-08-04 17:22:49 -07:00
fat
f6cec812a6 fixes #8957 2013-08-02 15:13:12 -07:00
Jacob Thornton
7a3c61ee33 fixes #8892 2013-07-31 22:57:00 -07:00
Jacob Thornton
ccd4c9d7b5 fixes #8864 2013-07-31 22:28:05 -07:00
Cesidio Di Landa
3696530aaf Removed trailing whitespaces 
Changed hard tabs to soft tabs
 2013-07-31 18:11:11 +02:00
fat
c54b8adb85 fixes #8814 2013-07-30 13:33:56 -07:00
fat
5ee2a221ca fixes #8816 2013-07-30 13:31:57 -07:00
liuyl
270316f140 fix transition end 2013-07-29 20:23:01 +08:00
Jacob Thornton
a31c5cea42 Merge branch '3.0.0-wip' of github.com:twitter/bootstrap into 3.0.0-wip 2013-07-28 22:16:17 -07:00
Jacob Thornton
e5a7af36d5 fixes #8703 2013-07-28 22:14:43 -07:00
Chris Rebert
9c672c6b20 get jshint close to passing by updating .jshintrc settings 
I don't agree with these personally, but they jive with BS/@fat's JS code style.
The remaining jshint complaints are things that really actually should get fixed.
 2013-07-27 21:56:44 -07:00
fat
cfa4ab90f3 fix scrollspy for window *and* children 2013-07-26 22:24:51 -07:00
fat
38044e55ae rebuild + fix #2539 2013-07-26 20:44:35 -07:00
fat
e2d4cf5f68 change how collapse works - collapse, collapsing, and in 2013-07-26 20:34:39 -07:00
John-Philip Johansson
0d33455ef4 Replace Makefile with GruntJS 
A rebase (against soon-to-be 3.0.0-rc.1) & squash of
https://github.com/twbs/bootstrap/pull/7786 AKA
https://github.com/twitter/bootstrap/pull/7786
originally by
@seriema
@mokkabonna
@jojohess

Rebased by @cvrebert
 2013-07-26 00:39:14 -07:00
fat
f5f04ae4a0 fix affix… 2013-07-25 23:30:13 -07:00
fat
0190128ebc Merge branch '3.0.0-wip' of github.com:twitter/bootstrap into 3.0.0-wip 2013-07-25 21:34:02 -07:00
fat
15d9c82fc5 fix collapse event #8596 2013-07-25 21:33:26 -07:00
Jacob
f1ddf7681c Merge pull request #8419 from hollensteiner/3.0.0-wip 
Replace position() with offset() in scrollspy.js
 2013-07-25 21:19:57 -07:00
Chris Rebert
90fb40b707 twbs ALL the links 2013-07-25 12:24:13 -07:00
Jacob Thornton
e9c83647af fixes #8568 -- account for margins in offset 2013-07-24 20:57:26 -07:00
Jacob Thornton
aad910465c fixes #8569 2013-07-24 20:21:23 -07:00
Jacob Thornton
eaefed517a fixes #8399 w/ tests 2013-07-24 20:10:16 -07:00
Jacob Thornton
217eb988b8 add placement auto for tooltips + tests… kinda sad about this doe 2013-07-23 23:50:23 -07:00
Jacob Thornton
6841c50968 fixes #7814 2013-07-23 22:59:09 -07:00
Jacob Thornton
72d2661ff0 fixes #8232 2013-07-23 20:53:12 -07:00
Jacob Thornton
faa00629c4 add additional carousel test 2013-07-23 18:56:00 -07:00
Jacob Thornton
68e87183a0 fixes #8134 2013-07-23 18:54:00 -07:00
Jacob Thornton
f1009c19b3 revert collapse change + add emulateTransitionEvent to catch dead css transitions 2013-07-23 18:44:08 -07:00
Jacob Thornton
43e5e90a6d shown.bs.modal fix 2013-07-23 17:32:20 -07:00
Jacob Thornton
7b12a0dcbc fixes #7970 2013-07-23 17:23:02 -07:00
fat
4b40ee692d cleaner way of preventing double click events + clean up tests for jshint 2013-07-18 01:07:11 -07:00
fat
37e899d766 get button js working with actual form elements p cooll 2013-07-18 00:59:31 -07:00
fat
b13eecaeec fixes #7880 2013-07-17 23:52:29 -07:00
fat
59f847e8ee fixes #7777 2013-07-17 23:30:05 -07:00
fat
8cf04911db fixes #7776 2013-07-17 23:25:26 -07:00
fat
451acb42db fixes #7755 2013-07-17 23:15:50 -07:00
fat
57768d7ea9 fix #7660 2013-07-17 23:01:33 -07:00
fat
18d23b892c rebuild js + fixes #7583 2013-07-17 21:35:28 -07:00
fat
2cccc0889f make sure triggering element is visible before focusing #7521 2013-07-17 21:30:38 -07:00
fat
a7a9a14379 fix @muan's unit test ;) 2013-07-17 21:17:39 -07:00
fat
102df4ff33 Merge branch '3.0.0-wip' of git://github.com/muan/bootstrap into muan-3.0.0-wip 
Conflicts:
	docs/assets/js/bootstrap.min.js
 2013-07-17 21:14:02 -07:00
fat
eb3333a612 fix #7000 2013-07-17 21:08:50 -07:00
fat
392bf0c9c9 fixes #6691 2013-07-17 20:29:41 -07:00
fat
13cad5061d maybe fix this old ass issue #5973 2013-07-17 19:28:43 -07:00
ClausH
0a72530429 Replace position with offset 2013-07-08 12:02:31 +02:00
Mu-An Chiou
55fa1acbd6 Tooltip: apply position class before positioning 2013-06-28 11:05:38 +01:00
Jacob
d23800c828 Merge pull request #7424 from sody/3.0.0-wip 
Fixes #7213 Collapse plugin does not correctly set the "collapsed" class.
 2013-06-27 22:36:33 -07:00
fat
b0da97588e fixes #6982 2013-06-27 19:19:22 -07:00
Mark Otto
2aec6dae59 Fixes #7730: Better hiding of empty titles in popovers 
If the popover's title contains no text, hide it via JS. Previously was
done via CSS's `:empty` property, but that doesn't work in IE8, so JS
it is.

/cc @fat becaue I probably did this wrong <3
 2013-06-20 16:02:05 -07:00
Ivan Khalopik
e138b0df3a Merge remote-tracking branch 'bootstrap/3.0.0-wip' into 3.0.0-wip 2013-06-10 10:31:51 +03:00
Robert Burns
cc684750e5 Fix for carousel indicators 2013-06-01 08:15:40 -04:00
fat
f5ce66177b fix event binding in modal.js 2013-05-29 11:24:00 -04:00
fat
9257bdc097 fixes #7163 2013-05-27 12:45:13 -07:00
Ivan Khalopik
3285f4c306 Merge remote-tracking branch 'bootstrap/3.0.0-wip' into 3.0.0-wip 
Conflicts:
	js/bootstrap-collapse.js
 2013-05-27 11:06:31 +03:00
Jacob Thornton
7cbb1c0452 add data-ride=carousel support for starting carousel on load 2013-05-25 00:16:52 -07:00
Jacob Thornton
e424b3879c fixes #4781 2013-05-24 23:53:44 -07:00
Jacob Thornton
f3e45c3778 add show/shown hide/hidden events to dropdown + update dropdown links for testing + catch a few missed namespace things 2013-05-24 23:15:04 -07:00
Mark Otto
432d417ade fixes #6898: typo in modal test 2013-05-22 23:17:39 -07:00