0
0
mirror of https://github.com/twbs/bootstrap.git synced 2025-01-07 00:46:15 +01:00
Commit Graph

13 Commits

Author SHA1 Message Date
Mark Otto
01036ff2ef
Update description of active buttons (#34966) 2021-09-14 15:05:07 +03:00
Patrick H. Lauke
f4a1a35cf2
v4: Disabled link cleanup (#34924)
manual backport of #34886

per https://www.w3.org/TR/html-aria/#docconformance

> It is NOT RECOMMENDED to use `aria-disabled="true"` on an `a` element with an `href` attribute.
>
>NOTE
>If a link needs to be "disabled", remove the `href` attribute.

This PR removes the unnecessary `href="#"`, `tabindex="-1"`, and `aria-disabled="true"` from disabled links in both docs pages and examples. `aria-disabled="true"` *is* kept for disabled link-based buttons (that have `role="button"`) as there it's appropriate to use (you *want* to convey to assistive technologies that this thing you're claiming is a button is also disabled at the moment)

Further, the PR extends the "Link functionality caveat" to show the "proper" way (removing `href` and adding `.disabled` class only) to disable a link, but then explains what to do if that's not possible (and then keeps an example with all the traditional `href="#" tabindex="-1" aria-disabled="true"`, but explains clearly that it's not ideal). Same sort of explanation is also added to the pointer event utilities page
2021-09-09 14:49:06 +03:00
XhmikosR
408252eff1 Move RFS version in config.yml and update it. 2021-09-08 09:06:42 +03:00
XhmikosR
6c9951203c Backport #34336
Remove unneeded `.text-white-50` CSS rule

This is already part of Bootstrap 4.6 and 5.0.
2021-07-21 16:20:01 +03:00
Christian Oliff
538ea32cb7 Fix repetition in the description. 2021-06-09 14:08:50 -07:00
midzer
fb604bc03f Replace freenode with libera IRC server (#34050) 2021-05-21 08:19:22 +03:00
Patrick H. Lauke
d967553913
Remove aria-haspopup from dropdowns (#33624)
`aria-haspopup="true"` is really intended to signal that an ARIA `menu` will be opened on activation. as a result, some assistive technologies will announce controls with `aria-haspopup="true"` as a menu or menu item (e.g. JAWS and NVDA).
In addition, `aria-haspopup` seems to trigger a bug in Edge/Narrator where the `aria-expanded` state is not correctly announced at the moment when `aria-haspopup` is present.
This now makes the dropdown button more like a generic disclosure widget control - see also https://www.w3.org/TR/wai-aria-practices-1.2/examples/disclosure/disclosure-navigation.html01
2021-04-15 06:35:54 +03:00
Stefano Bartoletti
016f8fff11
fix typo in docs (#33562) 2021-04-06 17:55:29 +03:00
Mark Otto
51c8b91d91 Manually backport #33386 to v4 to properly document Sass default variables 2021-03-18 18:57:12 -07:00
Patrick H. Lauke
e16b06929a
Manual backport of #32627 (#33165)
Carousel: use buttons, not links, for prev/next controls
2021-03-11 09:23:46 +02:00
XhmikosR
bb5b5891da Backport #32940
* Update the default value for $enable-deprecation-messages

As seen in the https://github.com/twbs/bootstrap/blob/v4-dev/scss/_variables.scss,
the `$enable-deprecation-messages` variable is set to `true` by default.
2021-02-17 06:54:38 +02:00
Patrick H. Lauke
210cb72872 Add a callout for the sanitizer in popovers and tooltips (#32272)
* Add a callout for the sanitizer in popovers and tooltips

* Add second reference to sanitizer in the options

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-17 06:54:38 +02:00
XhmikosR
6ffb0b48e4
Release v4.6.0. (#32726)
* Bump version to v4.6.0.

* Dist
2021-01-19 18:16:38 +02:00