rooty/Bootstrap
0
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-01 13:24:25 +01:00
Code Issues Actions Packages Releases Activity
11,497 Commits 108 Branches 89 Tags 547 MiB
f9bee7deb6
Commit Graph

975 Commits

Author SHA1 Message Date
Chris Rebert
cc39f5c52d add role="button" to a[data-toggle="collapse"]; fixes #15972 2015-03-03 13:18:36 -08:00
Chris Rebert
168297c779 rm semicolon for sake of fat's eccentric tastes 
Erratum from #15496
 2015-03-03 13:06:32 -08:00
Heinrich Fenkart
420a8088a4 Merge pull request #15961 from kkirsche/ImplementAssertExpect 
[Fixes #15953] Implement assert.expect in each unit test
 2015-03-03 15:52:05 +01:00
Kevin Kirsche
4febcb4b49 [Fixes #15953] Implement assert.expect in each unit test 
[Fixes #15953] Implement `assert.expect` in each unit test
 2015-03-03 08:45:07 -05:00
Heinrich Fenkart
f5beebe726 Modal: Fix backdrop not readjusting when height changes 
Fixes #15136.
Closes #15345.
Closes #15314.
Refs #14724, #14927.
 2015-03-03 05:27:26 +01:00
Chris Rebert
46f5a8f478 Merge pull request #15970 from twbs/the-future-is-now-qunit 
Disable deprecated QUnit global methods
 2015-03-02 02:39:29 -08:00
XhmikosR
f8e34ff48b Disable es3 for tests and customizer.js. 2015-03-02 11:16:06 +02:00
Chris Rebert
c291c12cb1 Disable deprecated global QUnit method aliases to prevent backsliding on QUnit v2 readiness 2015-03-01 19:50:11 -08:00
Chris Rebert
c80872235f Merge pull request #15955 from twbs/fixture-on-screen-ios 
Unit tests: Only display fixture on-screen for iOS
 2015-03-01 18:28:46 -08:00
Chris Rebert
015e63f6df Merge pull request #15593 from neoeno/handle_multiple_zero_offset_scrollspy_elements 
Handle multiple zero-offset Scrollspy elements.
 2015-03-01 16:04:04 -08:00
Caden Lovelace
a1aa0f8afd Handle multiple zero-offset Scrollspy elements. 
When the first two elements in a scrollspy content block have a document
offset of zero (i.e. they're hard against the top of the page),
Scrollspy would switch between them on every scroll event.

This could happen, for example, in a system of nested sections:

```
<section id="animals">
  <section id="dogs">
	Content
  </section>
</section>
```

This ocurred because Scrollspy's check to see if it's at the end of the
array of sections uses `!arr[index]`. This misses the case where
`arr[index]` does exist and is zero.

This commit explicitly checks the array bounds.
 2015-03-01 23:55:39 +00:00
Heinrich Fenkart
20fb55a840 Unit tests: Only display fixture on-screen for iOS 
Since only on iOS tests fail when the fixture is displayed off-screen, see https://travis-ci.org/twbs/bootstrap/jobs/52605742
 2015-03-01 09:49:59 +01:00
Heinrich Fenkart
4345e24479 Use different way to make failing test more visible in Sauce 2015-03-01 09:20:00 +01:00
Ivan Cheung
d5071b19f1 Update all collapse triggers with .collapsed class and aria-expanded 
Fixes #15741
Closes #15751 by merging it.
 2015-02-26 18:48:20 -08:00
Chris Rebert
9afb61fffd QUnit.jsDump => QUnit.dump 
Refs http://qunitjs.com/upgrade-guide-2.x/#replace-qunit-jsdump-with-qunit-dump
 2015-02-25 23:29:27 -08:00
Chris Rebert
4ff9c54cdd Use QUnit.log(...) instead of QUnit.log = ... 
Refs http://qunitjs.com/upgrade-guide-2.x/#replace-qunit-log-callback-with-qunit-log-callback-for-all-reporting-callbacks
 2015-02-25 23:29:27 -08:00
Heinrich Fenkart
3bb05b5fbb Unit tests: Use new names of module hooks 
Refs #15893
 2015-02-26 08:20:42 +01:00
nakupanda
142a9e4ae0 Modal: Apply any preexisting body padding again after closing 2015-02-26 08:02:06 +01:00
Quentin Spencer-Harper
acc5f65756 Tooltip: Avoid creating an unnecessary tooltip when Tooltip#hide is called 
Fixed performance bug where a tooltip element is created and then immediately destroyed when tooltip.hide() is called and there is no existing tooltip element

Resolves #15557 by merging it.
 2015-02-26 06:53:58 +01:00
vsn4ik
b395f3526e Dropdowns: Skip .disabled instead of .divider on keydown event 
Fixes #15147.
Closes #15520 by merging it.
 2015-02-26 06:42:09 +01:00
Heinrich Fenkart
cac6cfcd84 Merge pull request #15923 from kkirsche/useExplicitVariableDeclaration 
[Ref #15881] Use Explicit JS Variable Declarations rather than Chained
 2015-02-26 05:55:27 +01:00
Chris Rebert
a339bfb0ac Merge pull request #15693 from huang-x-h/patch-1 
tip method in popover.js can be removed
 2015-02-25 19:49:26 -08:00
Kevin Kirsche
238be65786 [Ref #15881] Use Explicit Values rather than Chain 
[Ref #15881] Use Explicit Values for javascript variables rather than chained ones.

From https://github.com/twbs/bootstrap/pull/15881#discussion_r25330647
 2015-02-25 12:19:11 -05:00
Chris Rebert
804457c474 fix 2 typos in modal unit test assertion messages 2015-02-24 23:49:08 -08:00
Heinrich Fenkart
c40c31a308 Dropdown unit tests: Tiny style changes 2015-02-25 02:53:39 +01:00
Heinrich Fenkart
6e0c843223 ScrollSpy: Small style consistency adjustments 2015-02-25 01:37:13 +01:00
Chris Rebert
2a6207c0c9 Merge pull request #15904 from kkirsche/patch-8 
Closes #15904
 2015-02-24 14:11:03 -08:00
Kevin Kirsche
696fc2e53c Add unit test of aria-expanded to dropdown suite 
Redo of #15876
 2015-02-24 14:09:08 -08:00
Kevin Kirsche
30d8cdf639 Add tests for aria-hidden of modal 
Add tests for `aria-hidden` of modal

Use strictEqual of 1 here instead of 2 asserts
 2015-02-24 16:29:40 -05:00
Chris Rebert
ecd469ec16 Merge pull request #15893 from twbs/qunit-modern 
Modernize QUnit usage by avoiding usage of global functions
 2015-02-24 11:47:29 -08:00
Chris Rebert
9c75c855c6 JS unit tests: equal() => strictEqual() 
[skip validator]
 2015-02-23 22:43:17 -08:00
Chris Rebert
bda4fe87ca upgrade to QUnit v1.17.1 
[skip validator]
 2015-02-23 22:18:51 -08:00
Chris Rebert
118b8c2695 JS unit tests: use QUnit.module() & QUnit.test() everywhere 
[skip validator]
 2015-02-23 22:14:11 -08:00
Chris Rebert
7c19fee3f1 JS unit tests: use modern QUnit assert object everywhere 2015-02-23 22:14:11 -08:00
Heinrich Fenkart
16479e9051 Merge pull request #15378 from twbs/fix-ie-modal-scrollbar-for-realz 
Modal: Work around IE scrollbars not taking up page width
 2015-02-24 03:33:32 +01:00
dormouse
91b384399c tip method in popover.js can be removed 
Popover is extend Tooltip, the tip function can use tootltip's tip, so we can remove the tip function definition in popover to reduce the js filesize

tip function definition in tooltip.js https://github.com/tbs/bootstrap/blob/master/js/tooltip.js#L405-L407
 2015-01-29 11:21:07 +08:00
Chris Rebert
cd4467b194 Merge pull request #15496 from twbs/15484-alternative 
Make $(document).tooltip({...}) without a `selector` throw an error
 2015-01-28 11:05:40 -08:00
Chris Rebert
af8fa54fcd Merge pull request #15630 from twbs/tabs-cond-fix 
Fix error in condition in Tab plugin
 2015-01-28 10:59:51 -08:00
Chris Rebert
ebedeaf2fe Fix name of Tooltip.replaceArrow() parameter 
isHorizontal => isVertical
 2015-01-27 11:15:55 -08:00
Chris Rebert
426e8e12cd Fix error in condition in Tab plugin 
Refs #15186
 2015-01-21 14:13:26 -08:00
Chris Rebert
1652efc3f6 tweak 'close reopened modal' unit test to work under new QUnit API 2015-01-20 20:18:33 -08:00
Chris Rebert
df73535a2d fix bug in tab show/shown relatedTarget unit test 2015-01-20 20:16:42 -08:00
Chris Rebert
b56d97f210 update JS unit tests to future-proof QUnit 1.16.0 API 
[skip validator]
 2015-01-20 19:57:51 -08:00
XhmikosR
a8139a0392 Update QUnit to v1.17.0. 2015-01-19 20:10:34 +02:00
Mark Otto
c683e7dea7 bump versions 2015-01-19 08:32:13 -08:00
XhmikosR
0481ce973f Fix bogus JSCS warning. 2015-01-16 17:50:05 +02:00
XhmikosR
0e79fe1a9f Update JSCS config for the new version. 2015-01-16 17:49:58 +02:00
XhmikosR
9db1de2a3a Update jQuery to v1.11.2. 2015-01-07 00:31:18 +02:00
Chris Rebert
34f88e94fc window.Document doesn't exist in IE8 2015-01-05 14:47:33 -08:00
Chris Rebert
f6a837cbf1 Make $(document).tooltip({...}) without a selector throw an error 
Closes #15484
 2015-01-05 14:22:49 -08:00
Zlatan Vasović
576230b92a Happy New Year 🎅 2015-01-01 01:23:48 +01:00
Chris Rebert
adaabab81b Revert "Allow multiple delegated tooltip selectors on a node" 
This reverts commit 1b3237629a.
This reverts PR #14189 because it caused major regressions.

Fixes #15168.

We'll try to revisit #14167's feature request in Bootstrap v4.

[skip validator]
 2014-12-29 20:08:22 -08:00
Chris Rebert
32cb071594 Remove semicolons from #15425 because fat 2014-12-29 18:34:35 -08:00
Chris Rebert
27bfef5b35 Add regression test for #14244. 
Special thanks to @programcsharp

[skip validator]
 2014-12-29 16:09:37 -08:00
Chris Rebert
2ae4c0b03f JSCS: enable requireSpaceBetweenArguments 
New rule added in JSCS v1.9.0
Our JS already complies with this.
 2014-12-29 12:02:33 -08:00
Heinrich Fenkart
32f62bc565 Modal: Work around IE scrollbars not taking up page width 
Fixes #15353.
 2014-12-18 07:29:34 +01:00
Dan Dascalescu
2c64fc2c4d Fix copy/paste error 2014-11-28 04:30:04 -08:00
Chris Rebert
bc5a753b67 fix affix-top unit test to properly clean up after itself 2014-11-20 23:26:37 -08:00
Nick O'Donoghue
36b4f90f25 Fixes affix-top class not applying 
Use scrollTop instead of colliderTop which uses the elements
offset().top, as the offset top does not account for padding.

This issue can be replicated by using a navbar-fixed-top and applying
relevant padding to the body. (A navbar-static-top with no padding on
the body does not encounter this issue)

Fixes #15078
Closes #15154 by merging it
 2014-11-17 18:17:42 -08:00
Nick O'Donoghue
da79ab9488 add unit test for affix-top for padding issue 2014-11-17 18:17:40 -08:00
Chris Rebert
b7398bc9c4 honor wrap option in Carousel.getItemForDirection; fixes #15144 2014-11-15 22:43:20 -08:00
Chris Rebert
8008fe707e add unit tests for Carousel's 'wrap' option 2014-11-15 22:37:55 -08:00
Heinrich Fenkart
a577f1922e Collapse: Use $.fn.children instead of > in selector 
Fixes #15131.
 2014-11-14 15:18:34 +01:00
Mark Otto
9a7e365c2c bump version to v3.3.1 2014-11-12 09:03:16 -08:00
Heinrich Fenkart
1d55ada581 Dropdown: ignore keydown events coming from inputs and textareas 
Fixes #15084.
 2014-11-12 02:01:25 +01:00
Chris Rebert
21644321e4 Merge pull request #14993 from twbs/fix-14991 
Have Carousel ignore keyboard events from <input>s or <textarea>s
 2014-11-04 16:50:36 -08:00
Heinrich Fenkart
da74fba490 Center modal dialog at all times 2014-11-05 01:37:44 +01:00
Chris Rebert
469dc3ab1f Have Carousel ignore keyboard events from <input>s or <textarea>s; fixes #14991 2014-11-04 16:23:44 -08:00
Heinrich Fenkart
425a985491 Update head of all visual tests to use our basic template 2014-11-05 01:18:11 +01:00
Heinrich Fenkart
14e5fb04e9 Fix modal backdrop overlaying the modal's scrollbar 
Fixes #14916.
 2014-11-04 23:17:55 +01:00
Chris Rebert
4102a67f33 fix typo in comment 2014-10-30 01:47:48 -07:00
Heinrich Fenkart
cf482dbb0b Fix the iOS 8 unit test failures 
Resolves #14919.
 2014-10-30 09:35:53 +01:00
Heinrich Fenkart
5178d8b8ba Use RegExp for button plugin's focus shim 
Fixes #14923.
 2014-10-30 03:46:49 +01:00
Mark Otto
94b59b57d6 version bump 2014-10-29 08:56:20 -07:00
Ben-Russell
68b771a057 Independently delegate data-api selectors 
Fixes #14462.
Closes #14463 by merging it.
 2014-10-29 04:54:53 +01:00
Heinrich Fenkart
ed3a65f084 Handle collapsed class on triggers even when manually invoked 
Fixes #13636.
 2014-10-29 04:34:05 +01:00
Heinrich Fenkart
e851b8685a Merge pull request #14457 from hnrch02/button-set-val-after-event-loop 
Change value of stateful button after event loop
 2014-10-29 04:28:22 +01:00
Chris Rebert
22e1f94b52 Increase timeouts in tooltip unit tests to avoid spurious Sauce failures 
Fixes #14851
 2014-10-27 15:53:43 -07:00
Heinrich Fenkart
007fbdb66d Remove faulty unit test from 9740d8b 
This would only work with transitions but since we disable them for unit tests, this delivers unreliably results.
 2014-10-26 04:56:52 +01:00
Heinrich Fenkart
5da85f8e8b Follow-up to 9740d8b: fix small typo 2014-10-26 04:41:47 +01:00
Phil Hughes
9740d8bb69 Fix tooltip occasionally not hiding when using a hide delay 
Fixes #14375.
Closes #14519 by merging it.
 2014-10-26 04:38:18 +01:00
Andrew S. Brown
1b3237629a Allow multiple delegated tooltip selectors on a node 
Fixes #14167.
Closes #14189 by merging it.
 2014-10-26 03:51:55 +01:00
Heinrich Fenkart
0e991ccba2 Follow-up to e8af21c: rm unused variable in unit test 2014-10-26 03:16:05 +01:00
Tadeu Zagallo
e8af21cc9d Clear scrollspy selection above first section 
Closes #13563 by merging it.
 2014-10-26 03:14:08 +01:00
Cameron Little
0755d529c6 Tabs plugin accessibility 
Added support for `aria-expanded` toggling via JavaScript. Added
`aria-controls`, `aria-expanded`, `aria-labelledby` to tabs docs.

Added `aria-expanded` unit test for the tabs plugin.

See also #13554.

Closes #14154 by merging it.
 2014-10-26 02:25:47 +01:00
Heinrich Fenkart
c1f669e83b Revert "Scrollspy: ignore invisible list items" 2014-10-26 01:50:38 +02:00
Heinrich Fenkart
fe51148434 Merge pull request #14669 from vsn4ik/dropdown_event_target 
Use e.target instead :focus selector.
 2014-10-23 06:13:46 +02:00
Heinrich Fenkart
3c98dd35ba Fix IE8 unit test breakage introduced by #14767 2014-10-22 22:09:58 +02:00
Phil Hughes
ab8dbc214e Implement hide and hidden events for tabs 
Closes #14772.
 2014-10-22 21:42:35 +02:00
Heinrich Fenkart
95e0f48e3a Follow-up to e2cfbd5: Fix spaces in placement calculation 2014-10-22 21:38:34 +02:00
saranya.r
e2cfbd5f2d Fixes tooltip misplacements in scrollable viewports with auto positioning 
Fixes #14756.
Closes #14767.
 2014-10-22 21:35:44 +02:00
Patrick H. Lauke
e1d40f7633 Add aria-pressed to single toggle buttons 
also includes tiny fix/clarification to two existing unit tests for the
.active class, adding data-toggle=“button” explicitly to the tested
buttons

Closes #14819.
 2014-10-22 21:02:19 +02:00
Heinrich Fenkart
e811a24118 Don't fire show event if show is prevented because other element is still transitioning 
Fixes #14844.
Closes #14845.
 2014-10-22 04:25:05 +02:00
fat
4bbe80658a fixes #13816 Modal dialog closes when dragging and releasing mouse button outside dialog 2014-10-09 20:01:51 -07:00
XhmikosR
909a178362 Change Twitter links to use https. 2014-10-07 15:28:41 +03:00
Heinrich Fenkart
61705d35fa Small clean-up in scrollspy unit test 2014-10-07 06:57:46 +02:00
Chris Rebert
d361470487 tooltip unit tests: fix typo in test description 2014-10-03 16:26:53 -07:00
Maarten Van Hoof
44894a40e5 Add missing collapse JS files to dropdown visual test 
Closes #14726.
 2014-10-03 19:55:13 +02:00
Jacob
2c562d2386 Merge pull request #14590 from twbs/carousel-keyboard-option 
Add `keyboard` option to carousel
 2014-10-02 23:11:14 -07:00
Jacob
3fda099f5c Merge pull request #14722 from twbs/fat-14646 
Escape key should only close Dropdown
 2014-10-02 21:26:38 -07:00