0
0
mirror of https://github.com/twbs/bootstrap.git synced 2025-01-20 12:52:19 +01:00

7601 Commits

Author SHA1 Message Date
Mark Otto
bc0cf36dc8 grunt 2017-04-16 13:54:07 -07:00
Patrick H. Lauke
6d64afe508 Replace dropdown backdrop hack with cleaner JS-only hack
* Replace backdrop with simple noop mouse listener

As discussed in https://github.com/twbs/bootstrap/pull/22422 the current
approach of injecting a backdrop (to work around iOS' broken event
delegation for the `click` event) has annoying consequences on
touch-enabled laptop/desktop devices.
Instead of a backdrop `<div>`, here we simply add extra empty/noop
mouse listeners to the immediate children of `<body>` (and remove
them when the dropdown is closed) in order to force iOS to properly
bubble a `click` resulting from a tap (essentially, method 2 from
https://www.quirksmode.org/blog/archives/2014/02/mouse_event_bub.html)
This is sufficient (except in rare cases where the user does manage to tap
on the body itself, rather than any child elements of body - which is not
very likely in an iOS phone/tablet scenario for most layouts) to get iOS to
get a grip and do the correct event bubbling/delegation, meaning the regular
"click" event will bubble back to the `<body>` when tapping outside of the dropdown,
and the dropdown will close properly (just like it already does, even without
this fix, in non-iOS touchscreen devices/browsers, like Chrome/Android and
Windows on a touch laptop).
This approach, though a bit hacky, has no impact on the DOM structure, and
has no unforeseen side effects on touch-enabled laptops/desktops. And crucially,
it works just fine in iOS.

* Remove dropdown backdrop styles

* Update doc for dropdowns and touch-enabled devices
2017-04-14 09:19:00 +01:00
Patrick H. Lauke
3275ca4b30 Reword "mobile" to "touch-enabled"
...as touch is not exclusive to "mobile" anymore nowadays. also explicitly clarifies this is a fix for iOS, and that it impacts touch laptops etc as well. lastly, renames the variable from "dropdown" to "backdrop" for clarity/consistency
2017-04-12 18:39:23 +01:00
Patrick H. Lauke
53b2c5520b Remove inappropriate role="listbox" from carousels 2017-04-11 11:12:30 +01:00
Patrick H. Lauke
18e8704221 Fix collapse.js aria-expanded behavior
* Remove aria-expanded from collapse.js target element

aria-expanded="true"/aria-expanded="false" only applies to the trigger,
not the element that is being expanded/collapsed.

* Tweak collapse.js accessibility section

...to make it clearer that the aria-expanded attribute always just goes
on the control.

* Fix collapse.js unit tests

- reword some of the text to make it clear we're checking behavior of
trigger/control
- move incorrect aria-expanded out of the <div>s and to the actual
trigger/control <a>s
- fix incorrect test assertion text output false -> true
2017-04-10 14:51:22 +01:00
Patrick H. Lauke
ba306d98bb Merge branch 'v4-dev' into v4-dev-docs-navs-js-tabpanel-fix 2017-04-09 22:09:45 +01:00
Patrick H. Lauke
50d178ece0 Remove incorrect role="tabpanel" from navs docs
`role="tabpanel"` is not appropriate as role for the overall container -
it only applies to the individual content parts of each tab
2017-04-09 21:15:05 +01:00
Patrick H. Lauke
c5db196e76 Merge branch 'v4-dev' into v4-docs-button-group-a11y-patch1 2017-04-09 13:25:47 +01:00
Mark Otto
0719ab1888 grunt 2017-04-08 22:05:50 -07:00
Mark Otto
ee5dc37ba3 drop img-fluid for w-100 2017-04-08 16:29:21 -07:00
Mark Otto
feb35b94a6 Revert "Drop width from sizing utils given .col- classes can do the same thing (follow up to #22376)"
This reverts commit 2f21403a933336f7cb01c86bf3c650490bc658a6.
2017-04-08 15:15:14 -07:00
Mark Otto
2f21403a93 Drop width from sizing utils given .col- classes can do the same thing (follow up to #22376) 2017-04-08 14:23:47 -07:00
Mark Otto
9a475730dc Docs and CSS updates for #21807 (#22336)
* tweak some copy
* fix up scrollspy docs
* remove nav styles that were added
* fix nav-based docs by requiring .nav-item on .nav-link
2017-04-08 13:58:20 -07:00
Mark Otto
364e01885f grunt 2017-04-08 13:22:53 -07:00
Johann-S
31a21044e0 Documentation - Add inserted event for Tooltip and Popover 2017-04-07 14:23:26 +02:00
Pierre Vanduynslager
7e64147adf Rename navbar-toggleable to navbar-expand in docs (#22309) 2017-04-02 12:44:38 -07:00
Mark Otto
7d88f365c0 Merge branch 'v4-dev' of https://github.com/twbs/bootstrap into v4-dev 2017-04-02 12:00:52 -07:00
Pierre Vanduynslager
91b62941af Tabs/Scrollspy/.nav/.list-group/.active independent of markup (<nav>, .nav-item, <li> etc...) 2017-04-02 11:21:04 +02:00
Mark Otto
49b6cf845d grunt 2017-04-01 19:18:29 -07:00
Patrick H. Lauke
63cd4e96b3 Add explicit aria-label to placeholder-only inputs
While `placeholder` is nominally valid per spec
http://rawgit.com/w3c/html-api-map/master/index.html#accessible-name-and-description-calculation
it is inelegant, a fallback, and not supported in ios/safari/voiceover
and android/chrome/talkback, to name a few combinations

`aria-describedby` is also not really the right tool for providing a
name/label equivalent, so remove that from the list of possible
alternative methods / clarify how it can be used
2017-03-30 23:31:14 +01:00
Pierre Vanduynslager
48c5efa4c3 Fix JS components console error "Error: <Component> is transitioning" 2017-03-28 23:43:15 +02:00
Mark Otto
b3cad39782 quickly fix #21761 by adding .text-gray-dark example 2017-03-28 09:35:39 -07:00
Mark Otto
cf7d3e11e0 grunt 2017-03-28 09:31:32 -07:00
Mark Otto
7742ba6dc9 grunt 2017-03-27 22:56:14 -07:00
Mark Otto
fe3acc097a Card image fixes (#22288)
* fix image stretching due to flexbox
* fix broke text-muted on dark bg
* no img-fluid needed
2017-03-27 22:52:24 -07:00
Mark Otto
8edfe0ff56 fixes #21608 2017-03-26 17:31:29 -07:00
Mark Otto
6331b9962b grunt 2017-03-26 15:26:07 -07:00
Mark Otto
319c278cfe grunt 2017-03-26 14:52:41 -07:00
Mark Otto
7ca078da81 fixes #22111
- add .col-*-auto to the extend in our grid framework mixins so it gets padding
- this means we can avoid the col-12 classes in our docs for the responsive variants
2017-03-26 13:23:49 -07:00
Mark Otto
1d48151975 git that a link too for now 2017-03-26 13:23:49 -07:00
Mark Otto
9010978c1a add example and document bug behavior to fix #21967 2017-03-26 13:23:49 -07:00
Mark Otto
1ad0496724 fix broken fieldset grid, workaround for flexbug 9 2017-03-26 13:23:49 -07:00
Mark Otto
1e6902d21f fixes #22133 2017-03-26 13:23:49 -07:00
Mark Otto
2b3a2b65a9 doh forgot to save 2017-03-26 13:23:49 -07:00
Mark Otto
9596cb5087 clarify docs a bit more and remove some words; closes #21683 2017-03-26 13:23:49 -07:00
Mark Otto
1a264be8b3 Redo semantic grid example and make it real in the docs 2017-03-26 13:23:49 -07:00
Mark Otto
2d243086c9 clean up mixin docs 2017-03-26 13:23:49 -07:00
Mark Otto
4ab06ca453 grunt 2017-03-26 11:26:31 -07:00
Sid
d2b919143c Add missing v4 docs for tooltip/popover methods (#22246)
Add missing v4 docs for tooltip/popover methods
2017-03-24 11:32:39 +01:00
Mark Otto
7f21a80a6a fix dupe ids 2017-03-23 23:02:28 -07:00
Mark Otto
2af1be2440 fix broken justified-nav example, fixes #21874 2017-03-23 23:02:28 -07:00
Mark Otto
90c5f6230b rename from .navbar-toggleable to .navbar-expand to reflect mobile first approach everywhere else 2017-03-23 23:02:28 -07:00
Mark Otto
11ba308b2f more docs updates 2017-03-23 23:02:28 -07:00
Mark Otto
c5d10f6dee update docs 2017-03-23 23:02:28 -07:00
Mark Otto
a3a1a592b5 update docs example to use new stuff 2017-03-23 23:02:28 -07:00
Pierre-Denis Vanduynslager
c1325a756e Generate correct breakpoints for navbar-toggleable-* and generate toggleable without media query to never collapse 2017-03-23 23:02:28 -07:00
Mark Otto
d0b568470f fixes #22254 2017-03-23 22:34:35 -07:00
Patrick Hayes
e41316cd94 Fix modal documentation (#22252)
The example code has the class `"modal fade"`, but the visible example has the class `"modal"`. `"fade"` appears to not work for modals that you do not intend to animate onto the page
2017-03-23 21:16:06 -07:00
Johann
3f247a42f2 Fix Modal documentation about _handleUpdate method + move to public scope (#21877)
Fix Modal documentation about _handleUpdate method + move to public scope
2017-03-23 22:22:09 +01:00
Pierre Vanduynslager
37f438910f Accordion behavior with JQuery interface (#21726)
Fix accordion behavior with JQuery interface
2017-03-23 21:15:41 +01:00