mirror of
https://github.com/twbs/bootstrap.git
synced 2024-12-10 22:24:19 +01:00
e3f9c463fc
Explicitly re-adds the "hand" `cursor:pointer` for non-disabled `.btn`, `.close`, `.navbar-toggler` elements, as well as forcing `page-link` pagination controls to always have the "hand" cursor (even if an author uses it on, say, `<button>` elements for a dynamically updating in-page pagination). Controversial, as everybody jumped on the bandwagon following this article https://medium.com/simple-human/buttons-shouldnt-have-a-hand-cursor-b11e99ca374b - which does have its merits of course, but there are also counter-arguments like http://kizu.ru/en/issues/cursor-pointer/ And seeing the amount of issues we've seen following the change, and the potential complexity needed to consistently address the cursor issue (see https://github.com/twbs/bootstrap/issues/24156 where i explore how the cursor needs to be based on "intent", and how that's tough to determine), I'm favouring an opinionated take here of just reintroducing the `cursor:pointer`.
35 lines
861 B
SCSS
35 lines
861 B
SCSS
.close {
|
|
float: right;
|
|
font-size: $close-font-size;
|
|
font-weight: $close-font-weight;
|
|
line-height: 1;
|
|
color: $close-color;
|
|
text-shadow: $close-text-shadow;
|
|
opacity: .5;
|
|
|
|
@include hover-focus {
|
|
color: $close-color;
|
|
text-decoration: none;
|
|
opacity: .75;
|
|
}
|
|
|
|
// Opinionated: add "hand" cursor to non-disabled .close elements
|
|
&:not([disabled]):not(.disabled) {
|
|
cursor: pointer;
|
|
}
|
|
}
|
|
|
|
// Additional properties for button version
|
|
// iOS requires the button element instead of an anchor tag.
|
|
// If you want the anchor version, it requires `href="#"`.
|
|
// See https://developer.mozilla.org/en-US/docs/Web/Events/click#Safari_Mobile
|
|
|
|
// stylelint-disable property-no-vendor-prefix, selector-no-qualifying-type
|
|
button.close {
|
|
padding: 0;
|
|
background-color: transparent;
|
|
border: 0;
|
|
-webkit-appearance: none;
|
|
}
|
|
// stylelint-enable
|