rooty/DataTables
1
0
Fork 0
mirror of https://github.com/DataTables/DataTables.git synced 2025-02-18 16:54:14 +01:00
Code Issues Releases Activity

Dev: Code size - also in fnSetColumnVis reduce code size with aoData references in the same way as we do for aoColumns. Smaller size and more consistency. All good.

Browse Source
This commit is contained in:
Allan Jardine 2012-01-31 08:45:45 +00:00
parent 4a4b6f6d58
commit a5d34f2230
2 changed files with 20 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
media/js/jquery.dataTables.js vendored
View File

@ -5716,6 +5716,7 @@
var oSettings = _fnSettingsFromNode( this[DataTable.ext.iApiIndex] );
var i, iLen;
var aoColumns = oSettings.aoColumns;
var aoData = oSettings.aoData;
var nTd, nCell, anTrs, jqChildren, bAppend, iBefore;
/* No point in doing anything if we are requesting what is already true */
@ -5752,20 +5753,20 @@
}
}
for ( i=0, iLen=oSettings.aoData.length ; i<iLen ; i++ )
for ( i=0, iLen=aoData.length ; i<iLen ; i++ )
{
if ( oSettings.aoData[i].nTr !== null )
if ( aoData[i].nTr !== null )
{
if ( bAppend )
{
oSettings.aoData[i].nTr.appendChild(
oSettings.aoData[i]._anHidden[iCol]
aoData[i].nTr.appendChild(
aoData[i]._anHidden[iCol]
);
}
else
{
oSettings.aoData[i].nTr.insertBefore(
oSettings.aoData[i]._anHidden[iCol],
aoData[i].nTr.insertBefore(
aoData[i]._anHidden[iCol],
_fnGetTdNodes( oSettings, i )[iBefore] );
}
}
@ -5774,12 +5775,12 @@
else
{
/* Remove a column from display */
for ( i=0, iLen=oSettings.aoData.length ; i<iLen ; i++ )
for ( i=0, iLen=aoData.length ; i<iLen ; i++ )
{
if ( oSettings.aoData[i].nTr !== null )
if ( aoData[i].nTr !== null )
{
nTd = _fnGetTdNodes( oSettings, i )[iCol];
oSettings.aoData[i]._anHidden[iCol] = nTd;
aoData[i]._anHidden[iCol] = nTd;
nTd.parentNode.removeChild( nTd );
}
}

19
media/src/api/api.methods.js
View File

@ -962,6 +962,7 @@ this.fnSetColumnVis = function ( iCol, bShow, bRedraw )
var oSettings = _fnSettingsFromNode( this[DataTable.ext.iApiIndex] );
var i, iLen;
var aoColumns = oSettings.aoColumns;
var aoData = oSettings.aoData;
var nTd, nCell, anTrs, jqChildren, bAppend, iBefore;
/* No point in doing anything if we are requesting what is already true */
@ -998,20 +999,20 @@ this.fnSetColumnVis = function ( iCol, bShow, bRedraw )
}
}
for ( i=0, iLen=oSettings.aoData.length ; i<iLen ; i++ )
for ( i=0, iLen=aoData.length ; i<iLen ; i++ )
{
if ( oSettings.aoData[i].nTr !== null )
if ( aoData[i].nTr !== null )
{
if ( bAppend )
{
oSettings.aoData[i].nTr.appendChild(
oSettings.aoData[i]._anHidden[iCol]
aoData[i].nTr.appendChild(
aoData[i]._anHidden[iCol]
);
}
else
{
oSettings.aoData[i].nTr.insertBefore(
oSettings.aoData[i]._anHidden[iCol],
aoData[i].nTr.insertBefore(
aoData[i]._anHidden[iCol],
_fnGetTdNodes( oSettings, i )[iBefore] );
}
}
@ -1020,12 +1021,12 @@ this.fnSetColumnVis = function ( iCol, bShow, bRedraw )
else
{
/* Remove a column from display */
for ( i=0, iLen=oSettings.aoData.length ; i<iLen ; i++ )
for ( i=0, iLen=aoData.length ; i<iLen ; i++ )
{
if ( oSettings.aoData[i].nTr !== null )
if ( aoData[i].nTr !== null )
{
nTd = _fnGetTdNodes( oSettings, i )[iCol];
oSettings.aoData[i]._anHidden[iCol] = nTd;
aoData[i]._anHidden[iCol] = nTd;
nTd.parentNode.removeChild( nTd );
}
}