rooty/DataTables
1
0
Fork 0
mirror of https://github.com/DataTables/DataTables.git synced 2025-02-17 15:54:14 +01:00
Code Issues Releases Activity

Removed: bScrollInfinite and iScrollLoadGap

Browse Source 
- The infinite scrolling feature of DataTables is inadequate as a
  solution for the problem it is trying to solve as it introduces a
  number of compatiblity issues with the rest of the API parimarily
  due to the fact that it "tricks" the rest of DataTables into drawing
  just a small proportion of the table, leaving the elements which are
  currently in place. This means that DataTables doesn't realise that
  the table has additional rows at the top of the table, thus breaking
  numerous interactions with the API and confusing developers. As such,
  its a poor feature that is just taking up space and could be done much
  better externally.

- I will write an infinite loading feature for DataTables in future for
  users that do what to use this ability - there is nothing stopping a
  simple scroll event being attached to the scrolling element and
  calling the rows.add() function. This is exactly what the new plug-in
  will do.

- Scroller is a much better solution for defined length tables.
This commit is contained in:
Allan Jardine 2013-10-10 17:46:48 +01:00
parent c31d3a1447
commit fb2f40a455
2 changed files with 6 additions and 119 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.datatables-commit-sync
View File

@ -1 +1 @@
2e8c9ddd5aaf32c42462cef8cdb620654d186068
1961e26b6a8d8de91c784da88091899cd478dd4c

123
media/js/jquery.dataTables.js vendored
View File

@ -1581,15 +1581,7 @@
var body = $(oSettings.nTBody);
/* When doing infinite scrolling, only remove child rows when sorting, filtering or start
* up. When not infinite scroll, always do it.
*/
if ( !oSettings.oScroll.bInfinite || !oSettings._bInitComplete ||
oSettings.bSorted || oSettings.bFiltered )
{
body.children().detach();
}
body.children().detach();
body.append( $(anRows) );
/* Call all required callback functions for the end of a draw */
@ -2128,10 +2120,7 @@
oSettings.iDraw = json.sEcho * 1;
}
if ( !oSettings.oScroll.bInfinite || oSettings.bSorted || oSettings.bFiltered )
{
_fnClearTable( oSettings );
}
_fnClearTable( oSettings );
oSettings._iRecordsTotal = parseInt(json.iTotalRecords, 10);
oSettings._iRecordsDisplay = parseInt(json.iTotalDisplayRecords, 10);
@ -2602,7 +2591,7 @@
// internally
var
formatter = settings.fnFormatNumber,
start = settings.oScroll.bInfinite ? 1 : settings._iDisplayStart+1,
start = settings._iDisplayStart+1,
len = settings._iDisplayLength,
vis = settings.fnRecordsDisplay(),
all = len === -1;
@ -2741,10 +2730,6 @@
*/
function _fnFeatureHtmlLength ( settings )
{
if ( settings.oScroll.bInfinite ) {
return null;
}
var
classes = settings.oClasses,
tableId = settings.sTableId,
@ -2805,11 +2790,6 @@
*/
function _fnFeatureHtmlPaginate ( settings )
{
if ( settings.oScroll.bInfinite )
{
return null;
}
var
type = settings.sPaginationType,
plugin = DataTable.ext.pager[ type ],
@ -3109,28 +3089,6 @@
"sName": "scrolling"
} );
/* Infinite scrolling event handlers */
if ( oSettings.oScroll.bInfinite )
{
$(nScrollBody).scroll( function() {
/* Use a blocker to stop scrolling from loading more data while other data is still loading */
if ( !oSettings.bDrawing && $(this).scrollTop() !== 0 )
{
/* Check if we should load the next data set */
if ( $(this).scrollTop() + $(this).height() >
$(oSettings.nTable).height() - oSettings.oScroll.iLoadGap )
{
/* Only do the redraw if we have to - we might be at the end of the data */
if ( oSettings.fnDisplayEnd() < oSettings.fnRecordsDisplay() )
{
_fnPageChange( oSettings, 'next' );
_fnDraw( oSettings );
}
}
}
} );
}
oSettings.nScrollHead = nScrollHead;
oSettings.nScrollFoot = nScrollFoot;
@ -4321,10 +4279,10 @@
}
/* Store the interesting variables */
var i, iLen, bInfinite=oSettings.oScroll.bInfinite;
var i, iLen;
var oState = {
"iCreate": new Date().getTime(),
"iStart": bInfinite ? 0 : oSettings._iDisplayStart,
"iStart": oSettings._iDisplayStart,
"iLength": oSettings._iDisplayLength,
"aaSorting": $.extend( true, [], oSettings.aaSorting ),
"oSearch": $.extend( true, {}, oSettings.oPreviousSearch ),
@ -5646,8 +5604,6 @@
[ "sScrollXInner", "sXInner" ],
[ "sScrollY", "sY" ],
[ "bScrollCollapse", "bCollapse" ],
[ "bScrollInfinite", "bInfinite" ],
[ "iScrollLoadGap", "iLoadGap" ],
[ "bScrollAutoCss", "bAutoCss" ]
] );
_fnMap( oSettings.oLanguage, oInit, "fnInfoCallback" );
@ -9519,31 +9475,6 @@
"bScrollCollapse": false,
/**
* Enable infinite scrolling for DataTables (to be used in combination with
* `scrollY`). Infinite scrolling means that DataTables will continually load
* data as a user scrolls through a table, which is very useful for large
* dataset. This cannot be used with pagination, which is automatically
* disabled. *Note*: the Scroller extra for DataTables is recommended in
* in preference to this option.
* @type boolean
* @default false
*
* @dtopt Features
* @name DataTable.defaults.scrollInfinite
*
* @example
* $(document).ready( function() {
* $('#example').dataTable( {
* "scrollInfinite": true,
* "scrollCollapse": true,
* "scrollY": "200px"
* } );
* } );
*/
"bScrollInfinite": false,
/**
* Configure DataTables to use server-side processing. Note that the
* `ajaxSource` parameter must also be given in order to give DataTables a
@ -10253,31 +10184,6 @@
"iDisplayStart": 0,
/**
* The scroll gap is the amount of scrolling that is left to go before
* DataTables will load the next 'page' of data automatically when using
* `scrollInfinite`. You typically want a gap which is big enough that the
* scrolling will be smooth for the user, while not so large that it will
* load more data than need.
* @type int
* @default 100
*
* @dtopt Options
* @name DataTable.defaults.scrollLoadGap
*
* @example
* $(document).ready( function() {
* $('#example').dataTable( {
* "scrollInfinite": true,
* "scrollCollapse": true,
* "scrollY": "200px",
* "scrollLoadGap": 50
* } );
* } );
*/
"iScrollLoadGap": 100,
/**
* By default DataTables allows keyboard navigation of the table (sorting, paging,
* and filtering) by adding a `tabindex` attribute to the required elements. This
@ -12091,15 +11997,6 @@
*/
"bCollapse": null,
/**
* Infinite scrolling enablement flag. Now deprecated in favour of
* using the Scroller plug-in.
* Note that this parameter will be set by the initialisation routine. To
* set a default use {@link DataTable.defaults}.
* @type boolean
*/
"bInfinite": null,
/**
* Width of the scrollbar for the web-browser's platform. Calculated
* during table initialisation.
@ -12108,16 +12005,6 @@
*/
"iBarWidth": 0,
/**
* Space (in pixels) between the bottom of the scrolling container and
* the bottom of the scrolling viewport before the next page is loaded
* when using infinite scrolling.
* Note that this parameter will be set by the initialisation routine. To
* set a default use {@link DataTable.defaults}.
* @type int
*/
"iLoadGap": null,
/**
* Viewport width for horizontal scrolling. Horizontal scrolling is
* disabled if an empty string.