Allan Jardine
5311067cd2
Dev: Tidy up _fnColumnIndexToVisible and _fnVisibleToColumnIndex to use the new _fnGetColumns method.
2012-07-31 09:39:51 +01:00
Allan Jardine
d034d187bd
Performance: Alter how _fnBuildSearchRow works to be much faster. For this a new method call _fnGetColumns is introduced which will pluck the column indexes that we want into an array that can then be iterated over (rather than spinning over the full aoColumns array twice, we now do it only the once for columns which are actually marked as searchable). Also use array join rather than string concatination to keep the number of operations down as much as possible. The callers of _fnBuildSearchRow must now pass in the data to be searched, limited by the searchable flag (i.e. call _fnGetRowData with the column indexes from _fnGetColumns).
...
Fix: Use jQuery html() and text() for HTML data to search method. Much tidier and copes with strict XHTML - downside is that it is a little slower if & is in a data string.
2012-07-31 09:25:35 +01:00
Allan Jardine
d155f7a7e7
Updated: Renaming mDataProp to mData for naming consistency and to show its flexibility. Please note that this is a backwards compatible change! DataTables will automatically check for mDataProp on a column and use that if required (if both mData and mDataProp are given then the new mData is used in preference).
2012-06-29 20:08:52 +01:00
Allan Jardine
4886322183
New: mRender option for columns - this is effectively a simpiler version of mDataProp for reading data only (while mDataProp also sets data), and much more comprhensive than fnRender (as such fnRender is now offically deprecated). See the documentation comments in model.defaults.columns.js for further information on how to use mRender.
2012-06-29 19:37:22 +01:00
Allan Jardine
0ed6ceda95
Updated: mDataProp syntax now has the ability to accept array syntax (for example "access[].name" would get an array of the 'name' properties from the access property of the data source). This is exceptionally useful for manipulating arrays - however, you are very _strongly_ advised not to use in in mDataProp itself, since when setting arrays, you will overwrite the old array (thus destroying any other properties that it already has!). Instead, see the new mRender property if you want to make use of this syntax for drawing the table.
2012-06-29 17:47:00 +01:00
Allan Jardine
a022e2f736
Dev - remove debug
2012-06-25 20:06:19 +01:00
Allan Jardine
40a236a7cc
Update: Remove use of $.browser since this is depricated in jQuery 1.8 and will be completely removed in jQuery 1.9. Instead we now use feature detection to determine if there is a browser bug with the width calculation of scrolling elements that needs to be worked around. This does unfortunatly increase the code size a bit - it is either this or using user agent string detection (which is exactly what is being removed from jQuery).
...
Starting 1.9.3 development
2012-06-25 11:19:56 +01:00
Allan Jardine
1055d27887
Fix: Regex filter escaping wasn't escaping the dash ('-') character believe it or not. That's been there since very early DataTables!
2012-06-13 18:27:04 +01:00
Allan Jardine
284658e3c9
Fix: When setting deeply nested object properties, where the parent object doesn't yet exist, don't just silently fail. Since we are setting a value, we are at liberty to create the parent object and then set the value - this now does so.
2012-06-07 09:43:47 +01:00
Allan Jardine
3d802a685b
Fix - docs: JSDoc syntax errors which were picked up by JSDoc Toolkit
2012-05-20 10:55:23 +01:00
Allan Jardine
49fe9f2e0e
Fix: Calling fnClose in fnPreDrawCallback would result in an error - 9702
2012-04-29 18:57:37 +01:00
Allan Jardine
fee3ba754f
Merge pull request #46 from Petah/master
...
Allow custom JUI header and footer classes
2012-04-29 02:13:33 -07:00
Allan Jardine
9ec52faec5
Dev fix: The change to set all Ajax properties has a knock on effect on setting deep objects that don't exist, since that is now attempted. Picked up by unit test.
2012-04-13 17:56:46 +01:00
Allan Jardine
814ce1f7d5
Update: Bring the mDataProp as a function functionality to parity for Ajax / JS sourced data and DOM sourced data. Previously DOM sourced data would call the 'set' option for the mDataProp function but Ajax/JS sourced data would not, resulting in the set option never being called for those table types, which is a total bummer when you want to do some formatting in the set option. So now it is called. I was slightly conerned about the performance hit since this means a couple of extra function calls for each cell, but its all in JS, no DOM and I can see virtally no difference with about 50'000 rows and 5 columns of data, so acceptable for the benefits.
2012-04-13 17:25:25 +01:00
Allan Jardine
ac9e454e11
New: Column option "sCellType" - allows you to create TD (default) or TH cells for a column. Useful for creating row headings in the TBODY.
2012-04-13 13:31:02 +01:00
Allan Jardine
732d25b229
Fix: IE8 bug where an empty string read from a DOM input element is JSON encoded as '"null"' - absolutely mental! See this blog post for more information http://blogs.msdn.com/b/jscript/archive/2009/06/23/serializing-the-value-of-empty-dom-elements-using-native-json-in-ie8.aspx .
2012-04-13 11:56:01 +01:00
Allan Jardine
773c88b9f6
Fix: When mDataProp is given as a function, an error in getting the data would be rather ugly - 8400
2012-04-13 11:40:45 +01:00
Allan Jardine
8a66adc2d4
New: The _START_, _END_, _MAX_ and _TOTAL_ macros for the information language strings can now be used in any info string, rather than being limited to just the ones noted in the documentation - a new internal function called _fnInfoMacros is introduced to allow this to work - 9211
2012-04-13 11:29:56 +01:00
Allan Jardine
0518525f59
Fix: Captions which were positioned using caption-side:bottom (CSS) would be positioned incorrectly if using a scrolling table. Need to work around webkit bug 83867 to address this and add an empty tfoot element if one is not given - 2022
2012-04-13 09:25:47 +01:00
Allan Jardine
4be9b362c8
Fix: When scrolling and row height collapse was enabled, it was possible that the table column width applied would be too small due to the fact that a scrollbar would be shown for a fraction of a second, due to the height of the scroll body container enforced by the scroll collapse. Fix is to take into account the header height before the width calculation is done
2012-04-12 17:27:05 +01:00
Allan Jardine
3a27a605b9
Fix: Scrollbody height in IE7- - use offsetHeight consistently - 9424
2012-04-12 09:25:35 +01:00
Allan Jardine
35a23adb75
Dev fix: Missed a variable def in the recent _fnLanguageCompat change
2012-04-02 11:53:13 +01:00
Allan Jardine
cd0babca54
Fix: IE6/7 return an empty string for getAttribute('id') when there is no ID attribute, rather than null. As such tables were not automatically being given an ID when they didn't have one, which created a situation where the settings object for a table could be 'lost' in IE6/7. Now check for empty string when checking the table ID.
2012-04-02 10:25:52 +01:00
Allan Jardine
04d4786455
Fix: IE6/7 when scrolling is enabled could loose the sorting event due to the way cloned nodes work in those browsers. Note that this was introduced after 1.9.0. Related - jQuery bug 10437 - http://bugs.jquery.com/ticket/10437
2012-04-02 10:03:47 +01:00
Allan Jardine
c1e40a8596
Fix: Language backwards compatibility could override developer defined defaults - 9267
2012-03-30 15:30:19 +01:00
Allan Jardine
2096244c60
Fix: afnSortData functions were not being executed with the DataTables instance's scope
2012-03-19 12:09:49 +00:00
Allan Jardine
b5f4938d7d
Fix: If sType for a column is html and the data is null, then _fnDataToSearch could throw an error - 8987
2012-03-14 07:51:07 +00:00
Allan Jardine
c22dfe00d3
Strip HTML from the aria-label tag for the sorting headers
2012-03-14 07:04:33 +00:00
Allan Jardine
cc42c49ec3
New - initisalisation: iDeferLoading can now also be an array allowing the developer to specify the number of records before and after filtering for the information display - 7936
2012-03-03 07:34:11 +00:00
Allan Jardine
3a40c3a440
Fix: The sStripeOdd / sStripeEven options for the class objects were not being applied to the table. The fix is to set the default for asStripeClasses to be null, and then if null is found there, then the user hasn't applied a default, nor have they overridden the default, therefore we can use the classes from the class objects - 8770.
2012-02-29 09:09:16 +00:00
Allan Jardine
5479600611
Fix - performance: Don't extend the passed in data a second time - its a waste of time
2012-02-26 19:12:11 +00:00
Allan Jardine
126a4fe44e
Fix: When scrolling is enabled the initial width of the header was being set to 150% which was a bit random and could result in the header flashing its display in the wrong place when loading. The fix is to use 100% unless x-scrolling is being forced, at which point it needs to match the inner table - 8332
2012-02-25 07:56:27 +00:00
Allan Jardine
872dc0db3e
Fix: Feature match the server-side sorting to the client-side sorting for what information is sent to the server for sorting. Previously aDataSort was no honored - https://twitter.com/#!/naomiaro/status/172397914239414272
2012-02-22 19:47:09 +00:00
Allan Jardine
793020a8d4
Updated: When throwing an error, throw a "new Error()" so we can get a bit more information about the error
...
Updated: When using custom sort data types, if the returned array is not of the required length (aoData.length), then an error is thrown
2012-02-20 08:15:28 +00:00
Allan Jardine
af2e153bc3
Fix: When updating the filtering input control, we would just match on INPUT elements, so if the developer had appended an input button to the filter wrapper, that value would also be changed - 8537. Now a reference to the input element is stored and used to update the input value (this method means we don't need to add another class option, and developers can change to 'type=search' if they wish).
2012-02-15 09:36:51 +00:00
Allan Jardine
431b5e8a55
Fix: IE8 doesn't like the console check in logging - make it object based on window - 8517
2012-02-14 08:44:34 +00:00
Allan Jardine
ca009fdf88
Fix: When scrolling the column matching would remove any nested THEAD and TFOOT elements in the table - 8423
2012-02-08 08:34:39 +00:00
Allan Jardine
ab9dfd5052
Fix: x-scrolling to the end of a table would cause the header and the columns to go out of alignment due to the header not being able to scroll as far as was needed (this was caused by the changes in 876a75f) - 8332.
...
Fix: Table could conitnually expand when x-scrolling was enabled. This was partly addressed in 6776, but the fix was incomplete as it would still occur on Safari Mac (possibly other browsers as well). This fix is very closely related to 8332 (hence commiting together as they are interdependent). Now use padding right on the header/footer wrapper to provide the overflow scroll ability, but only add it when a scrollbar is present - otherwise the width gets added on and we get the forever expanding table.
Dev: Unit tests - New tests for scrolling to ensure 6776 and 8332 don't occur again
2012-02-06 18:09:16 +00:00
Allan Jardine
0151d43c25
Fix: When fnPreDrawCallback is used to cancel a draw the processing display would remain active - this should not be the case as DataTables is now finished with its processing - 8371
2012-02-03 17:46:05 +00:00
Allan Jardine
de6482a15e
Fix: asStripClasses if given was being overruled by the default given for asStripeClasses - 8332
...
Fix: The extend function was only extending properties that existed on the original source object, not properties that only existed on the extender
2012-02-02 10:04:51 +00:00
Allan Jardine
92ce6487f2
DataTables 1.9.1 development begins
...
Fix: When using full numbers pagination in IE and clicking upon one of the numbers in the paging control, a Javascript error would occur due to trying to blur an element that was no longer in the DOM
2012-02-02 07:06:33 +00:00
Allan Jardine
468390c337
Fix: When mDataProp was used to get a nested object, but a parent object didn't exist it would throw an unrecoverable error. With this change the behaviour matches that of single level data whereby if data cannot be found, at any level, then undefined is returned from the data get object. This means that if sDefaultContent is defined then that will be used instead, and if not defined an error will still be given (although this one under DataTables' control).
...
Dev: Removed the "fast lookup" function for data get and set as they weren't really that useful in terms of speed and would require more code to be added to copy with the above change to the error handling for missing objects. Smaller code and virtually no difference in speed. Sold.
2012-02-01 08:16:49 +00:00
Allan Jardine
3e366a5fe9
New: API: fnGetData now also allows TD/TH nodes to be passed in and DataTables will figure out the data for the cell, returning that - easier than calculating the column index yourself. So you can now get the whole table's data, a row's data or an individual cell's data from the fnGetData function (you could get the cell data before, but you would need to use fnGetPosition).
...
New: API: Underscore function updated to use fnGetData rather than its internal function calls. Although slightly more expensive in computation terms, it extends the capacibabites of the underscore function greatly, allowing TD nodes to be the result of the selector as well as TR nodes. So now you can get a column of data with something like: $('#example').dataTable()._('td:nth-child(4)') . Cool :-)
Dev: New internal function called _fnNodeToColumnIndex, adapted from fnGetPosition for reuse.
2012-01-31 08:09:51 +00:00
Petah
904f5dd672
Allow custom JUI header and footer classes
2012-01-31 14:42:10 +13:00
Allan Jardine
876a75f6ad
Fix: With scrolling enabled, adding the scrollbar width to the header / footer inner container elements could cause the table to resize incorrectly on the following draw (and this error was cumulative). Fix is not to adjust the inner element for the scrollbar width - makes no difference to the table draw. It is possible that if you've styled this element you might need to take this change into account, but by default DataTables will style the parent (scrollHead) so no change is required (regardless of jQuery UI theming enablement) - 6776.
...
Fix: The calculation to detect if the scroll bar would be shown in IE6/7 was incorrect - it was calculating the height of the entire table, rather than just the body of the table (i.e. body + header + footer) which caused the "correct" for the scrollbar to be incorrectly applied to small tables.
2012-01-30 09:52:35 +00:00
Allan Jardine
a057b9d8cf
Dev: Trivial modification to bring 1.9.0 back under the target size of 70000 btyes (was only 4 out). Simply reference the previous search object to a local variable so the compressor can compress more
2012-01-28 09:22:34 +00:00
Allan Jardine
8c8ddc0485
DataTables 1.9.0.dev.4
...
Fix: Multiple tables were going haywire on initialisation due to the self reference - 8233
2012-01-25 19:44:05 +00:00
Allan Jardine
9fb4492053
Fix: aoPreSearchCols can be given as null if you want to deinfe multiple columns - doing so would have resulted in an error. Fixed (unit test)
2012-01-25 16:09:41 +00:00
Allan Jardine
fc81ce726b
Update: mDataProp update to make it more versitile as a function and fix the settings of data with mDataProp. When mDataProp is given as a function, the function is now called with a 'type' of 'set', which the developer using mDataProp must used to store the value that if given (otherwise DOM read values would not be stored!).
...
Update: mDataProp documentation - example of using mDataProp as a function and clearer information about the options for mDataProp
2012-01-22 10:56:24 +00:00
Allan Jardine
ea9ebaa593
Dev: Update: _fnNodeToDataIndex can be made _so_ much faster with the new _DT_RowIndex prviate parameter - so this commit does so :-)
2012-01-20 21:58:17 +00:00
