1
0
mirror of https://github.com/DataTables/DataTables.git synced 2024-12-04 16:24:11 +01:00
Commit Graph

347 Commits

Author SHA1 Message Date
Allan Jardine
f433bb5ba4 New: -api $.fn.dataTable.isDataTable() will now check for DataTable API instances as well (i.e. variables passed in)
- Thread 38053
2016-12-02 17:54:14 +00:00
Allan Jardine
4b024ea60e Fix: If initialising a DataTable when the window was horizontally scrolled the browser detection would incorrectly determine that rtl layout was being used (effects scrolling view).
- Issue was due to the use of `position:fixed` for the element - from
  c856d0eb232ce41c76d0c30739d33e47cc7288f4. Ironically that change just
  moved the issue that it was trying to solve!
- Fixes DataTables/DataTables #866
2016-12-02 17:53:12 +00:00
Allan Jardine
d2e3bcec32 Dev: Fix no selector issue introduced by dfbf4fa23aa0952ee007bca06b791c2cd0ad48bb 2016-12-02 17:52:57 +00:00
Allan Jardine
946dfe85e3 Fix: Row selector would incorrectly select rows if row index 0 was passed in with a selector modifier.
- See thread 37834. Much qudos to `guyclairbois` for spotting this and
  test case!
2016-12-02 17:52:41 +00:00
Allan Jardine
774d1e7795 Merge branch 'master' of https://github.com/DataTables/DataTablesSrc 2016-12-02 17:49:20 +00:00
Allan Jardine
7df20199ca Added modified tests for stateLoad/stateSave 2016-12-02 17:49:03 +00:00
Allan Jardine
417a9cf2bd Dev: 1.10.13-dev version indicator 2016-12-02 17:48:46 +00:00
Allan Jardine
e5a3a794d6 Dev: Trigger a state save on the first draw like before
- Bug was introduced by the ordering of the code for the callback state
  loading
2016-12-02 17:48:30 +00:00
Allan Jardine
fe0ada1535 Fix: jQuery selectors which had a comma in them were incorrectly split by DataTables causing them to be invalid or give incorrect results
- fb-87
- Forum thread 34641
2016-12-02 17:48:13 +00:00
Allan Jardine
70d1afe8a1 Fix: Number renderer was not correctly rounding values
- Add number renderer tests
2016-12-02 17:47:58 +00:00
Allan Jardine
9e015213b0 New: -init stateLoadCallback can now use a callback function for async loading of state data, rather than requiring it to be sync.
- async is deprecated in the XHR spec and will be removed from Chrome
  (m53 I think).
2016-12-02 17:47:26 +00:00
Allan Jardine
9e45850c8d Merge branch 'master' of https://github.com/DataTables/DataTablesSrc 2016-12-02 17:44:50 +00:00
Allan Jardine
048d94836c Fixed several typos in documentation 2016-12-02 17:44:34 +00:00
Allan Jardine
f2f1a88c5c Fix: Remove deprecated jQuery $().bind() and $().unbind() use, replaced with the $().on() and $().off() methods.
- DataTables explicitly supports only jQuery 1.7+. `on` and `off` were
  introduced in 1.7, so this isn't a problem.
- jQuery migrate shows warnings if bind and unbind are used
- Fixes DataTables/DataTables #853
2016-12-02 17:44:02 +00:00
Allan Jardine
2cefd489fd Merge branch 'master' of https://github.com/DataTables/DataTablesSrc 2016-12-02 17:43:31 +00:00
Allan Jardine
1a174977ca Modified tests for columnDefs 2016-12-02 17:43:00 +00:00
Allan Jardine
00a4506d95 Performance: Faster row selection for multiple rows (-api rows()) by reusing the allowed row index array 2016-12-02 17:42:29 +00:00
Allan Jardine
7edd896e92 Merge branch 'master' of https://github.com/DataTables/DataTablesSrc 2016-12-02 17:41:42 +00:00
Allan Jardine
02e28fd14e Added new tests for callbacks, first pass complete.
(will need to add more tests for stateLoad/save)
2016-12-02 17:41:11 +00:00
Allan Jardine
3e88556062 Fix: Improve column selector when used with a complex jQuery selector for pseudo selectors
- Many thanks to chrisaeg for pointing this out!
2016-12-02 17:40:40 +00:00
Allan Jardine
530dd14e94 Dev: Revert 6f6b3d4b14fbba4a8818d8a24dc71763f9e92c80 - it was completely wrong! 2016-12-02 17:38:19 +00:00
Allan Jardine
5dcd176847 Dev: Correct internal parameter names - they we misleading in the code 2016-12-02 17:36:30 +00:00
Allan Jardine
e2dd3bef57 Merge branch 'master' of https://github.com/DataTables/DataTablesSrc 2016-12-02 17:34:24 +00:00
Allan Jardine
03d3f4edb9 Added new test
Callbacks- createRow.js
2016-12-02 17:34:08 +00:00
Allan Jardine
da861f3604 Merge pull request #80 from aij/master
Fix: When sorting a date column, an empty string would be incorrectly used as 1970-01-01.
2016-12-02 17:33:21 +00:00
Allan Jardine
75556f9eca Added new tests for columns options.
Includes-

columns.orderable
columns.className
columns.name
columns.orderData
columns.searchable
columns.title
columns.visible
columns.width
2016-12-02 17:32:49 +00:00
Allan Jardine
42ae4bf0c5 Fix date sorting of empty fields
Previously, date sorting of values that
failed to parse as a date were sorted as
if they were 1970-01-01 (Unix and JS epoch).

Now, they sort before other dates.

Example:
https://jsfiddle.net/qae6zjty/1/
2016-12-02 17:32:32 +00:00
Allan Jardine
8d662b2229 DataTables 1.10.12! 2016-12-02 17:22:55 +00:00
Allan Jardine
632f449467 New: $.fn.dataTable.util methods are now overridable (throttle and escapeRegex)
- It is useful to be able to replace some of the utility methods with
  your own custom ones - for example a debounce rather than tha throttle
  for filtering.
- This commit reorders the code a little to make that possible. No new
  code is present at such - its really about reordering the current code
  to make `$.fn.dataTable.util` the host for the original functions.
  Backwards compatiblity is provided by assigning the util methods to
  their old variables. With the next major update they should be removed
  and the util methods used directly.
- Other util methods should be added at the same time, escapeHtml,
  unique, etc.
- Fixes DataTables/DataTables #810
2016-12-02 17:20:34 +00:00
Allan Jardine
327d71584b Fix: dt-api order() called with an empty array would cause a JS error
- Fixes DataTables/DataTables #800
- Its safe to check for `.length` on `orders` at this point since it can
  be either a number, an array or undefined. The number and undefined
  conditions have already been checked, so it must be an array (of
  whatever length).
2016-12-02 17:18:14 +00:00
Allan Jardine
16c081d889 Dev: Fix recursion error with Responsive from last commit. Need to be
more selective about when we fire `column-visiblity`!
2016-12-02 17:17:58 +00:00
Allan Jardine
e9fc9dab2f Dev: A JS error was introduced with the column visiblity change - undefined variable.
- Need to use two iterators for the columns visible unfortunately
2016-12-02 17:17:26 +00:00
Allan Jardine
d9775c4085 Fix: Performance issue when using columns.visible() as a setter.
The column resize was being called for every column.
2016-12-02 17:16:39 +00:00
Allan Jardine
321be3bdb3 Remove prefixed -moz-box-sizing (not needed since ff 29)
https://developer.mozilla.org/en-US/Firefox/Releases/29
2016-12-02 16:46:11 +00:00
Allan Jardine
130687eeef Fix: caption tags should have the caption-side CSS value read from the caption tag itself, not the tabe tag.
- See thread 38094. Thanks _puls_!
2016-09-30 11:15:24 +01:00
Allan Jardine
0034f6c63e Fix: Using -init columns.data to access a data point which uses a backslash in its name would result in an error due to an incorrectly escaped regex.
- Fixes DataTables/DataTables #869
2016-09-29 16:22:53 +01:00
Allan Jardine
deaf51cef5 New: -api $.fn.dataTable.isDataTable() will now check for DataTable API instances as well (i.e. variables passed in)
- Thread 38053
2016-09-29 11:28:42 +01:00
Allan Jardine
62b6cb1b56 Fix: If initialising a DataTable when the window was horizontally scrolled the browser detection would incorrectly determine that rtl layout was being used (effects scrolling view).
- Issue was due to the use of `position:fixed` for the element - from
  c856d0eb232ce41c76d0c30739d33e47cc7288f4. Ironically that change just
  moved the issue that it was trying to solve!
- Fixes DataTables/DataTables #866
2016-09-21 10:57:59 +01:00
Allan Jardine
1e4dccb54d Dev: Fix no selector issue introduced by dfbf4fa23aa0952ee007bca06b791c2cd0ad48bb 2016-09-20 09:14:08 +01:00
Allan Jardine
f7d4b8a9cc Fix: Row selector would incorrectly select rows if row index 0 was passed in with a selector modifier.
- See thread 37834. Much qudos to `guyclairbois` for spotting this and
  test case!
2016-09-19 16:30:12 +01:00
Allan Jardine
ad129699b6 Merge branch 'master' of https://github.com/DataTables/DataTablesSrc 2016-09-16 14:51:45 +01:00
Allan Jardine
3987e441b8 Added modified tests for stateLoad/stateSave 2016-09-16 14:51:28 +01:00
Allan Jardine
ddec443008 Dev: 1.10.13-dev version indicator 2016-08-23 16:01:42 +01:00
Allan Jardine
19a3832792 Dev: Trigger a state save on the first draw like before
- Bug was introduced by the ordering of the code for the callback state
  loading
2016-08-23 16:01:25 +01:00
Allan Jardine
02e5dbcf7a Fix: jQuery selectors which had a comma in them were incorrectly split by DataTables causing them to be invalid or give incorrect results
- fb-87
- Forum thread 34641
2016-08-23 14:32:50 +01:00
Allan Jardine
fb708efe7e Fix: Number renderer was not correctly rounding values
- Add number renderer tests
2016-08-23 11:25:50 +01:00
Allan Jardine
55e0c4da2c Merge branch 'master' of github.com:DataTables/DataTablesSrc 2016-08-23 11:25:33 +01:00
Allan Jardine
f4d266b5c7 Added test plans for table api 2016-08-23 11:25:16 +01:00
Allan Jardine
26fb2b9524 New: -init stateLoadCallback can now use a callback function for async loading of state data, rather than requiring it to be sync.
- async is deprecated in the XHR spec and will be removed from Chrome
  (m53 I think).
2016-08-22 16:31:19 +01:00
Allan Jardine
cd3719e3a9 Merge branch 'master' of https://github.com/DataTables/DataTablesSrc 2016-08-22 16:28:29 +01:00
Allan Jardine
3d425d98b5 Fixed several typos in documentation 2016-08-22 16:28:11 +01:00
Allan Jardine
be6d4820ee Merge branch 'master' of github.com:DataTables/DataTablesSrc 2016-08-22 16:27:54 +01:00
Allan Jardine
b5ce731f1d Merge branch 'master' of https://github.com/DataTables/DataTablesSrc 2016-08-22 16:27:20 +01:00
Allan Jardine
267b8bc843 Modified tests for columnDefs 2016-08-22 16:26:46 +01:00
Allan Jardine
cb09b1871b Fix: Remove deprecated jQuery $().bind() and $().unbind() use, replaced with the $().on() and $().off() methods.
- DataTables explicitly supports only jQuery 1.7+. `on` and `off` were
  introduced in 1.7, so this isn't a problem.
- jQuery migrate shows warnings if bind and unbind are used
- Fixes DataTables/DataTables #853
2016-08-09 17:58:41 +01:00
Allan Jardine
a588b58ec3 Merge branch 'master' of https://github.com/DataTables/DataTablesSrc 2016-08-09 17:58:10 +01:00
Allan Jardine
b41e559175 Modified tests for columnDefs 2016-08-09 17:57:39 +01:00
Allan Jardine
3511506728 Performance: Faster row selection for multiple rows (-api rows()) by reusing the allowed row index array 2016-08-09 17:57:08 +01:00
Allan Jardine
3bab6dcffd Merge branch 'master' of https://github.com/DataTables/DataTablesSrc 2016-08-09 17:56:21 +01:00
Allan Jardine
e7b656d3f2 Added new tests for callbacks, first pass complete.
(will need to add more tests for stateLoad/save)
2016-08-09 17:55:50 +01:00
Allan Jardine
269bf01da0 Fix: Improve column selector when used with a complex jQuery selector for pseudo selectors
- Many thanks to chrisaeg for pointing this out!
2016-08-09 17:55:19 +01:00
Allan Jardine
15baf23757 Dev: Revert 6f6b3d4b14fbba4a8818d8a24dc71763f9e92c80 - it was completely wrong! 2016-08-09 17:52:59 +01:00
Allan Jardine
dfd7241083 Dev: Correct internal parameter names - they we misleading in the code 2016-08-09 17:51:07 +01:00
Allan Jardine
66e1e89ed7 Merge branch 'master' of https://github.com/DataTables/DataTablesSrc 2016-08-09 17:48:56 +01:00
Allan Jardine
429b623190 Added new test
Callbacks- createRow.js
2016-08-09 17:48:40 +01:00
Allan Jardine
00682a585e Merge pull request #80 from aij/master
Fix: When sorting a date column, an empty string would be incorrectly used as 1970-01-01.
2016-08-09 17:47:52 +01:00
Allan Jardine
50d14fc06c Added new tests for columns options.
Includes-

columns.orderable
columns.className
columns.name
columns.orderData
columns.searchable
columns.title
columns.visible
columns.width
2016-08-09 17:47:19 +01:00
Allan Jardine
df8192e3be Fix date sorting of empty fields
Previously, date sorting of values that
failed to parse as a date were sorted as
if they were 1970-01-01 (Unix and JS epoch).

Now, they sort before other dates.

Example:
https://jsfiddle.net/qae6zjty/1/
2016-08-09 17:47:03 +01:00
Allan Jardine
3a432c5db3 DataTables 1.10.12! 2016-05-20 14:09:02 +01:00
Allan Jardine
e25a106ecc New: $.fn.dataTable.util methods are now overridable (throttle and escapeRegex)
- It is useful to be able to replace some of the utility methods with
  your own custom ones - for example a debounce rather than tha throttle
  for filtering.
- This commit reorders the code a little to make that possible. No new
  code is present at such - its really about reordering the current code
  to make `$.fn.dataTable.util` the host for the original functions.
  Backwards compatiblity is provided by assigning the util methods to
  their old variables. With the next major update they should be removed
  and the util methods used directly.
- Other util methods should be added at the same time, escapeHtml,
  unique, etc.
- Fixes DataTables/DataTables #810
2016-05-09 15:25:20 +01:00
Allan Jardine
73abf82c1d Fix: dt-api order() called with an empty array would cause a JS error
- Fixes DataTables/DataTables #800
- Its safe to check for `.length` on `orders` at this point since it can
  be either a number, an array or undefined. The number and undefined
  conditions have already been checked, so it must be an array (of
  whatever length).
2016-04-19 17:51:22 +01:00
Allan Jardine
e6d8429987 Dev: Fix recursion error with Responsive from last commit. Need to be
more selective about when we fire `column-visiblity`!
2016-04-19 17:50:49 +01:00
Allan Jardine
938289db93 Dev: A JS error was introduced with the column visiblity change - undefined variable.
- Need to use two iterators for the columns visible unfortunately
2016-04-19 17:49:39 +01:00
Allan Jardine
1749cb2b1b Fix: Performance issue when using columns.visible() as a setter.
The column resize was being called for every column.
2016-04-18 15:09:38 +01:00
Allan Jardine
e350e155d2 Fix: Column visiblity count was only correct if the table was actually visble itself. We want to be able to count columns even when the table is not visible.
- Thread 33203
2016-02-15 15:14:16 +00:00
Allan Jardine
45ed4f3973 Dev: Version bump 2016-02-15 15:13:38 +00:00
Allan Jardine
d0163e24a0 DataTables 1.10.11 release 2016-02-11 14:30:12 +00:00
Allan Jardine
cf37b3bcfc Fix: Visible column count should take account of display:none columns as well as those removed from the DOM by DataTables core. This improves compatiblity with Responsive 2. 2016-02-10 15:05:41 +00:00
Allan Jardine
4ce6614977 Fix: Clear the cached data setter for DOM sourced tables when setting column options. This fixes issues with ColReorder and DOM sourced tables
- Fixes DataTables/ColReorder #50.
2016-02-09 15:29:26 +00:00
Allan Jardine
f734cdb672 Dev: Add example ordering information for FixedColumns
- Really must make some dynamic logic for this...
2016-02-05 12:15:50 +00:00
Allan Jardine
bc5adb493c Initial integration work for the uikit framework.
Updated the mit license with a comment on additional author Google Inc.
2016-02-05 12:15:16 +00:00
Allan Jardine
c0f3242d0d Dev: Remove trailing comma 2016-02-04 15:46:23 +00:00
Allan Jardine
e253006207 New: Greatly improve the utility of the row, column and cell selectors:
* `dt-api rows()` and `dt-api row()` can now be used with a cell from
    the table body (not limited to only the `tr` elements
  * `dt-api columns()` and `dt-api column()` can now be used with a cell
    from the table body (not just the column headers as before)
  * All three selector types can use an element with the `data-dt-row`
    and / or `data-dt-column` (as approrirate) attributes on them or a
    parent. This is useful for API integration with FixedColumns and
    Responsive. For example you can now pass a cell in a fixed column
    into the `dt-api cell()` method to select the original cell.
2016-02-04 14:44:38 +00:00
Allan Jardine
61fdeb0b9b Fix: When using data-* attributes for orthogonal data with a DOM sourced table, don't write to the DOM if the data hasn't changed.
- Fixes DataTables/DataTables #684
2016-02-03 15:40:44 +00:00
Allan Jardine
ff3bccad58 Fix: Checked radio boxes could be incorrectly unchecked if autowidth was enabled (which it is by default)
- Fix is to remove the name attribute. This would have no effect on the
  column width and means the radio element isn't in a group.
- See thread 32931
- Fixes DataTables/DataTables #569
2016-02-03 11:44:24 +00:00
Allan Jardine
c4986625c8 Fix: Improved DOM ordering for scrolling tables - colgroup, thead, tfoot
- Fixes DataTables/FixedColumns #8
2016-02-03 11:43:48 +00:00
Allan Jardine
386150893a Fix: Javascript error would occur if trying to use dt-api cells().nodes() on a cell that doesn't exisit in the DataTable
- Fixes DataTables/KeyTable #23.
2016-02-03 11:41:22 +00:00
Allan Jardine
af95119318 Dev: Version bump to dev 2016-01-07 15:33:02 +00:00
Allan Jardine
9563278a4a Fix: Potential column misalignment when scrolling with footer content that defines the width
- The scrolling body used to have the header content retained but
  hidden, while the footer was just emptied. But if the footer content
  is long enough to define the width of the column this results in
  column misalignment.
- Fix is to treat the footer in the same way as the header is.
2016-01-07 15:32:39 +00:00
Allan Jardine
f3fc3cd64e Fix: Remove redundant code in column visibility. Could cause slower performance
- Thanks sameeralikhan - thread 32212
2016-01-07 15:28:39 +00:00
Allan Jardine
344565a03d Fix: Column widths are not only applied to the DataTables detected headers when scrolling is activated. This will have no change on most tables, but for those with complex headers it prevents potentially contradictory sizes being applied which can result in column misalignment. 2016-01-07 15:28:13 +00:00
Allan Jardine
6c9c5433eb Fix: dt-api cell().data() would not return null values for cells if defaultContent was set. It should return the original data point for that cell, even if it is null. This also effects dt-api column().data() and their plural counterparts. 2016-01-07 15:26:52 +00:00
Allan Jardine
b7c671444d Fix: The number rendering helper will now automatically escape HTML entities to help prevent possible XSS attacks if using a number renderer.
Rational for this is that the number renderer expects a number
input, not HTML, but if non-numeric input is given the value is just
returned (now escaped) - for example an empty string.
2016-01-07 15:24:53 +00:00
Allan Jardine
e245645544 Version - 1.10.10 ready 2015-11-06 15:34:24 +00:00
Allan Jardine
6f67df2d21 New: $.fn.dataTable.render.text renderer method that can be used to help prevent against possible XSS attacks. It will basically encode HTML entities so they are shown in the rendered view rather than being written directly as HTML.
Update: `$.fn.dataTable.render.number` will now return the original value rather than NaN if the value cannot be parsed as a number.
2015-11-06 10:40:50 +00:00
Allan Jardine
06a6a0c429 Dev: Add a plugin-init event which is triggered immediately prior to init
- This is so that Buttons (and others) can listen for this event and
  create the buttons before the user init functions. Otherwise they
  would need a setTimeoutout to be able to access the Buttons methods
  immediately.
2015-11-04 16:33:00 +00:00
Allan Jardine
b36cbc745b Update: Allow a window to be passed in for CommonJS factory which gives DataTables the ability to be used in a headless environment (server-side rendering for example)
- Factory builder redesigned to pass in window and document to the
  factory method, mandating a small update to the AMD and Browser
  loaders
- Main change in is the CommonJS loader which can now optionally have a
  window object passed in - if it is not passed in `window` will be used
  (if this is the case in a CommonJS environment without a root object
  being passed in an error will occur).
- DataTables caches a reference to the jQuery instance so the plug-ins
  can easily reference jQuery while retaining their current return of
  the module they define. This basically means that DataTables core will
  include jQuery for the plug-ins.
- This does increase the core library size by ~160 bytes which is rather
  frustrating, but I think this is the correct way to go about it
- With thanks to Evan Carroll for input on this:
  https://github.com/DataTables/Plugins/issues/199
2015-11-03 16:32:39 +00:00
Allan Jardine
8fe17acf82 Update: A dt-init scrollX table is now allowed to collapse horizontally - simply don't specify style="width: 100%" or width="100%" for your table in the HTML and it will be allowed to collapse if the columns are smaller than the space required.
Fix: Force a column width if `dt-init scrollX` is specified and a column width is given. This can be overruled if the width given is too small for the content

- We already use the width attribute to determine if the table should
  resize dynamically to 100% width, so it makes sense to use that when
  scroll-x is enabled as well.
- This still isn't perfect as Chrome seems to change between a
  box-sizing calculation depending if scrolling is required or not so
  there can be a shift in column widths when changing between a
  scrolling state and not (column visibility) which is ugly, but is
  proving to be difficult to deal with.
2015-11-03 16:32:10 +00:00
Allan Jardine
ab982a537e New: dt-init language.aria.paginate options which can be used to specify ARIA label attributes for the pagination buttons. Particularly useful if you wish to use icons in place of the button text. 2015-10-28 11:38:01 +00:00
Allan Jardine
b9bdc5eb11 Fix: dt-api page.info() reported the page length as 10 when paging was disabled - should be -1 2015-10-28 09:03:41 +00:00