LP-173 Remove explicit calls to remaining settings objects: EKFConfiguration, HomeLocation, RevoCalibration and TakeOffLocation

flight/libraries/plans.c

@@ -80,7 +80,6 @@ static float applyExpo(float value, float expo)
  */
 void plan_initialize()
 {
-    TakeOffLocationInitialize();
     PositionStateInitialize();
     PathDesiredInitialize();
     FlightStatusInitialize();

flight/modules/CameraControl/cameracontrol.c

@@ -99,7 +99,6 @@ int32_t CameraControlInitialize(void)
         CameraControlActivityInitialize();
         CameraDesiredInitialize();
         CameraControlSettingsConnectCallback(SettingsUpdateCb);
-        HomeLocationInitialize();
         HomeLocationConnectCallback(HomeLocationUpdateCb);
         GPSTimeInitialize();
         PositionStateInitialize();

flight/modules/GPS/GPS.c

@@ -218,7 +218,6 @@ int32_t GPSInitialize(void)
     GPSVelocitySensorInitialize();
     GPSTimeInitialize();
     GPSSatellitesInitialize();
-    HomeLocationInitialize();
 #if defined(ANY_FULL_MAG_PARSER)
     AuxMagSensorInitialize();
     GPSExtendedStatusInitialize();
@@ -238,9 +237,6 @@ int32_t GPSInitialize(void)
 #if !defined(PIOS_GPS_MINIMAL)
         GPSTimeInitialize();
         GPSSatellitesInitialize();
-#endif
-#if defined(PIOS_GPS_SETS_HOMELOCATION)
-        HomeLocationInitialize();
 #endif
         // updateHwSettings() uses gpsSettings
         GPSSettingsGet(&gpsSettings);

flight/modules/ManualControl/takeofflocationhandler.c

@@ -40,10 +40,10 @@ static void SetTakeOffLocation();
 
 void takeOffLocationHandlerInit()
 {
-    TakeOffLocationInitialize();
     // check whether there is a preset/valid takeoff location
     TakeOffLocationModeOptions mode;
     TakeOffLocationStatusOptions status;
+
     TakeOffLocationModeGet(&mode);
     TakeOffLocationStatusGet(&status);
     // preset with invalid location will actually behave like FirstTakeoff

flight/modules/Osd/osdgen/osdgen.c

@@ -2426,9 +2426,6 @@ int32_t osdgenInitialize(void)
     GPSTimeInitialize();
     GPSSatellitesInitialize();
 #endif
-#ifdef PIOS_GPS_SETS_HOMELOCATION
-    HomeLocationInitialize();
-#endif
 #endif
     BaroSensorInitialize();
     FlightStatusInitialize();

flight/modules/PathFollower/pathfollower.cpp

@@ -165,7 +165,6 @@ extern "C" int32_t PathFollowerInitialize()
     StabilizationDesiredInitialize();
     AirspeedStateInitialize();
     AttitudeStateInitialize();
-    TakeOffLocationInitialize();
     PoiLocationInitialize();
     ManualControlCommandInitialize();
     StabilizationBankInitialize();
@@ -176,7 +175,6 @@ extern "C" int32_t PathFollowerInitialize()
     StatusVtolAutoTakeoffInitialize();
 
     // VtolLandFSM additional objects
-    HomeLocationInitialize();
     AccelStateInitialize();
 
     // Init references to controllers

flight/modules/Sensors/sensors.c

@@ -210,7 +210,6 @@ int32_t SensorsInitialize(void)
     AccelSensorInitialize();
     MagSensorInitialize();
     BaroSensorInitialize();
-    RevoCalibrationInitialize();
 
 #if defined(PIOS_INCLUDE_HMC5X83)
     // for auxmagsupport.c helpers

flight/modules/Sensors/simulated/Sensors/sensors.c

@@ -115,7 +115,6 @@ int32_t SensorsInitialize(void)
     GPSPositionSensorInitialize();
     GPSVelocitySensorInitialize();
     MagSensorInitialize();
-    RevoCalibrationInitialize();
 
     return 0;
 }

flight/modules/StateEstimation/filteraltitude.c

@@ -83,10 +83,9 @@ int32_t filterAltitudeInitialize(stateFilter *handle)
     handle->init      = &init;
     handle->filter    = &filter;
     handle->localdata = pios_malloc(sizeof(struct data));
-    HomeLocationInitialize();
     AttitudeStateInitialize();
     AltitudeFilterSettingsConnectCallback(&settingsUpdatedCb);
-    reloadSettings = true;
+    reloadSettings    = true;
     return STACK_REQUIRED;
 }
 

flight/modules/StateEstimation/filtercf.c

@@ -104,8 +104,6 @@ static void globalInit(void)
     if (!initialized) {
         initialized = 1;
         FlightStatusInitialize();
-        HomeLocationInitialize();
-        RevoCalibrationInitialize();
         FlightStatusConnectCallback(&flightStatusUpdatedCb);
         flightStatusUpdatedCb(NULL);
     }

flight/modules/StateEstimation/filterekf.c

@@ -93,9 +93,7 @@ static int32_t globalInit(stateFilter *handle, bool usePos, bool navOnly)
     struct data *this = (struct data *)handle->localdata;
     this->usePos      = usePos;
     this->navOnly     = navOnly;
-    EKFConfigurationInitialize();
     EKFStateVarianceInitialize();
-    HomeLocationInitialize();
     return STACK_REQUIRED;
 }
 

flight/modules/StateEstimation/filterlla.c

@@ -62,7 +62,6 @@ int32_t filterLLAInitialize(stateFilter *handle)
     handle->filter    = &filter;
     handle->localdata = pios_malloc(sizeof(struct data));
     GPSPositionSensorInitialize();
-    HomeLocationInitialize();
     return STACK_REQUIRED;
 }
 

flight/modules/StateEstimation/filtermag.c

@@ -72,7 +72,6 @@ int32_t filterMagInitialize(stateFilter *handle)
     handle->init      = &init;
     handle->filter    = &filter;
     handle->localdata = pios_malloc(sizeof(struct data));
-    HomeLocationInitialize();
     return STACK_REQUIRED;
 }
 

flight/modules/StateEstimation/stateestimation.c

@@ -334,8 +334,6 @@ int32_t StateEstimationInitialize(void)
     GPSVelocitySensorInitialize();
     GPSPositionSensorInitialize();
 
-    HomeLocationInitialize();
-
     GyroStateInitialize();
     AccelStateInitialize();
     MagStateInitialize();