From 37eabb09317aae60b1010e2bddc60f2fa094fcbc Mon Sep 17 00:00:00 2001 From: Alessio Morale Date: Sun, 19 May 2013 11:54:04 +0200 Subject: [PATCH] Pointed type is explicitly used with sizeof when dealing with struct pointers. +review OPReview-474 --- flight/pios/common/pios_com.c | 6 +++--- flight/pios/stm32f10x/pios_usart.c | 6 +++--- flight/pios/stm32f10x/pios_usb_cdc.c | 6 +++--- flight/pios/stm32f10x/pios_usb_hid.c | 6 +++--- flight/pios/stm32f4xx/pios_usart.c | 6 +++--- flight/pios/stm32f4xx/pios_usb_cdc.c | 6 +++--- flight/pios/stm32f4xx/pios_usb_hid.c | 6 +++--- 7 files changed, 21 insertions(+), 21 deletions(-) diff --git a/flight/pios/common/pios_com.c b/flight/pios/common/pios_com.c index 1e24d4cd0..d7f08489b 100644 --- a/flight/pios/common/pios_com.c +++ b/flight/pios/common/pios_com.c @@ -70,10 +70,10 @@ static struct pios_com_dev * PIOS_COM_alloc(void) { struct pios_com_dev * com_dev; - com_dev = (struct pios_com_dev *)pvPortMalloc(sizeof(*com_dev)); + com_dev = (struct pios_com_dev *)pvPortMalloc(sizeof(struct pios_com_dev)); if (!com_dev) return (NULL); - memset(com_dev, 0, sizeof(*com_dev)); + memset(com_dev, 0, sizeof(struct pios_com_dev)); com_dev->magic = PIOS_COM_DEV_MAGIC; return(com_dev); } @@ -90,7 +90,7 @@ static struct pios_com_dev * PIOS_COM_alloc(void) com_dev = &pios_com_devs[pios_com_num_devs++]; - memset(com_dev, 0, sizeof(*com_dev)); + memset(com_dev, 0, sizeof(struct pios_com_dev)); com_dev->magic = PIOS_COM_DEV_MAGIC; return (com_dev); diff --git a/flight/pios/stm32f10x/pios_usart.c b/flight/pios/stm32f10x/pios_usart.c index f6aaf3b50..c0c87d92d 100644 --- a/flight/pios/stm32f10x/pios_usart.c +++ b/flight/pios/stm32f10x/pios_usart.c @@ -75,10 +75,10 @@ static struct pios_usart_dev * PIOS_USART_alloc(void) { struct pios_usart_dev * usart_dev; - usart_dev = (struct pios_usart_dev *)pvPortMalloc(sizeof(*usart_dev)); + usart_dev = (struct pios_usart_dev *)pvPortMalloc(sizeof(struct pios_usart_dev)); if (!usart_dev) return(NULL); - memset(usart_dev, 0, sizeof(*usart_dev)); + memset(usart_dev, 0, sizeof(struct pios_usart_dev)); usart_dev->magic = PIOS_USART_DEV_MAGIC; return(usart_dev); } @@ -95,7 +95,7 @@ static struct pios_usart_dev * PIOS_USART_alloc(void) usart_dev = &pios_usart_devs[pios_usart_num_devs++]; - memset(usart_dev, 0, sizeof(*usart_dev)); + memset(usart_dev, 0, sizeof(struct pios_usart_dev)); usart_dev->magic = PIOS_USART_DEV_MAGIC; return (usart_dev); diff --git a/flight/pios/stm32f10x/pios_usb_cdc.c b/flight/pios/stm32f10x/pios_usb_cdc.c index c321afab5..26f199b39 100644 --- a/flight/pios/stm32f10x/pios_usb_cdc.c +++ b/flight/pios/stm32f10x/pios_usb_cdc.c @@ -90,10 +90,10 @@ static struct pios_usb_cdc_dev * PIOS_USB_CDC_alloc(void) { struct pios_usb_cdc_dev * usb_cdc_dev; - usb_cdc_dev = (struct pios_usb_cdc_dev *)pvPortMalloc(sizeof(*usb_cdc_dev)); + usb_cdc_dev = (struct pios_usb_cdc_dev *)pvPortMalloc(sizeof(struct pios_usb_cdc_dev)); if (!usb_cdc_dev) return(NULL); - memset(usb_cdc_dev, 0, sizeof(*usb_cdc_dev)); + memset(usb_cdc_dev, 0, sizeof(struct pios_usb_cdc_dev)); usb_cdc_dev->magic = PIOS_USB_CDC_DEV_MAGIC; return(usb_cdc_dev); } @@ -110,7 +110,7 @@ static struct pios_usb_cdc_dev * PIOS_USB_CDC_alloc(void) usb_cdc_dev = &pios_usb_cdc_devs[pios_usb_cdc_num_devs++]; - memset(usb_cdc_dev, 0, sizeof(*usb_cdc_dev)); + memset(usb_cdc_dev, 0, sizeof(struct pios_usb_cdc_dev)); usb_cdc_dev->magic = PIOS_USB_CDC_DEV_MAGIC; return (usb_cdc_dev); diff --git a/flight/pios/stm32f10x/pios_usb_hid.c b/flight/pios/stm32f10x/pios_usb_hid.c index 55e9af251..e2ec395ef 100644 --- a/flight/pios/stm32f10x/pios_usb_hid.c +++ b/flight/pios/stm32f10x/pios_usb_hid.c @@ -84,10 +84,10 @@ static struct pios_usb_hid_dev * PIOS_USB_HID_alloc(void) { struct pios_usb_hid_dev * usb_hid_dev; - usb_hid_dev = (struct pios_usb_hid_dev *)pvPortMalloc(sizeof(*usb_hid_dev)); + usb_hid_dev = (struct pios_usb_hid_dev *)pvPortMalloc(sizeof(struct pios_usb_hid_dev)); if (!usb_hid_dev) return(NULL); - memset(usb_hid_dev, 0, sizeof(*usb_hid_dev)); + memset(usb_hid_dev, 0, sizeof(struct pios_usb_hid_dev)); usb_hid_dev->magic = PIOS_USB_HID_DEV_MAGIC; return(usb_hid_dev); } @@ -104,7 +104,7 @@ static struct pios_usb_hid_dev * PIOS_USB_HID_alloc(void) usb_hid_dev = &pios_usb_hid_devs[pios_usb_hid_num_devs++]; - memset(usb_hid_dev, 0, sizeof(*usb_hid_dev)); + memset(usb_hid_dev, 0, sizeof(struct pios_usb_hid_dev)); usb_hid_dev->magic = PIOS_USB_HID_DEV_MAGIC; return (usb_hid_dev); diff --git a/flight/pios/stm32f4xx/pios_usart.c b/flight/pios/stm32f4xx/pios_usart.c index cf54b5d21..cd9cc9872 100644 --- a/flight/pios/stm32f4xx/pios_usart.c +++ b/flight/pios/stm32f4xx/pios_usart.c @@ -77,10 +77,10 @@ static struct pios_usart_dev * PIOS_USART_alloc(void) { struct pios_usart_dev * usart_dev; - usart_dev = (struct pios_usart_dev *)pvPortMalloc(sizeof(*usart_dev)); + usart_dev = (struct pios_usart_dev *)pvPortMalloc(sizeof(struct pios_usart_dev)); if (!usart_dev) return(NULL); - memset(usart_dev, 0, sizeof(*usart_dev)); + memset(usart_dev, 0, sizeof(struct pios_usart_dev)); usart_dev->magic = PIOS_USART_DEV_MAGIC; return(usart_dev); } @@ -97,7 +97,7 @@ static struct pios_usart_dev * PIOS_USART_alloc(void) usart_dev = &pios_usart_devs[pios_usart_num_devs++]; - memset(usart_dev, 0, sizeof(*usart_dev)); + memset(usart_dev, 0, sizeof(struct pios_usart_dev)); usart_dev->magic = PIOS_USART_DEV_MAGIC; return (usart_dev); diff --git a/flight/pios/stm32f4xx/pios_usb_cdc.c b/flight/pios/stm32f4xx/pios_usb_cdc.c index 048c9da59..bb1ed88f2 100644 --- a/flight/pios/stm32f4xx/pios_usb_cdc.c +++ b/flight/pios/stm32f4xx/pios_usb_cdc.c @@ -103,10 +103,10 @@ static struct pios_usb_cdc_dev * PIOS_USB_CDC_alloc(void) { struct pios_usb_cdc_dev * usb_cdc_dev; - usb_cdc_dev = (struct pios_usb_cdc_dev *)pvPortMalloc(sizeof(*usb_cdc_dev)); + usb_cdc_dev = (struct pios_usb_cdc_dev *)pvPortMalloc(sizeof(struct pios_usb_cdc_dev)); if (!usb_cdc_dev) return(NULL); - memset(usb_cdc_dev, 0, sizeof(*usb_cdc_dev)); + memset(usb_cdc_dev, 0, sizeof(struct pios_usb_cdc_dev)); usb_cdc_dev->magic = PIOS_USB_CDC_DEV_MAGIC; return(usb_cdc_dev); } @@ -123,7 +123,7 @@ static struct pios_usb_cdc_dev * PIOS_USB_CDC_alloc(void) usb_cdc_dev = &pios_usb_cdc_devs[pios_usb_cdc_num_devs++]; - memset(usb_cdc_dev, 0, sizeof(*usb_cdc_dev)); + memset(usb_cdc_dev, 0, sizeof(struct pios_usb_cdc_dev)); usb_cdc_dev->magic = PIOS_USB_CDC_DEV_MAGIC; return (usb_cdc_dev); diff --git a/flight/pios/stm32f4xx/pios_usb_hid.c b/flight/pios/stm32f4xx/pios_usb_hid.c index 120d984c4..e65e7ad4e 100644 --- a/flight/pios/stm32f4xx/pios_usb_hid.c +++ b/flight/pios/stm32f4xx/pios_usb_hid.c @@ -87,10 +87,10 @@ static struct pios_usb_hid_dev * PIOS_USB_HID_alloc(void) { struct pios_usb_hid_dev * usb_hid_dev; - usb_hid_dev = (struct pios_usb_hid_dev *)pvPortMalloc(sizeof(*usb_hid_dev)); + usb_hid_dev = (struct pios_usb_hid_dev *)pvPortMalloc(sizeof(struct pios_usb_hid_dev)); if (!usb_hid_dev) return(NULL); - memset(usb_hid_dev, 0, sizeof(*usb_hid_dev)); + memset(usb_hid_dev, 0, sizeof(struct pios_usb_hid_dev)); usb_hid_dev->magic = PIOS_USB_HID_DEV_MAGIC; return(usb_hid_dev); } @@ -107,7 +107,7 @@ static struct pios_usb_hid_dev * PIOS_USB_HID_alloc(void) usb_hid_dev = &pios_usb_hid_devs[pios_usb_hid_num_devs++]; - memset(usb_hid_dev, 0, sizeof(*usb_hid_dev)); + memset(usb_hid_dev, 0, sizeof(struct pios_usb_hid_dev)); usb_hid_dev->magic = PIOS_USB_HID_DEV_MAGIC; return (usb_hid_dev);