From 8e7e7e052a3bd39b29ff81acc524b08c54776eaf Mon Sep 17 00:00:00 2001 From: Alessio Morale Date: Tue, 21 May 2013 00:45:45 +0200 Subject: [PATCH 1/9] OP-962 Fix Stack size for ComUSBBridge +review OPReview --- flight/modules/ComUsbBridge/ComUsbBridge.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/flight/modules/ComUsbBridge/ComUsbBridge.c b/flight/modules/ComUsbBridge/ComUsbBridge.c index 09425e008..c7674ec00 100644 --- a/flight/modules/ComUsbBridge/ComUsbBridge.c +++ b/flight/modules/ComUsbBridge/ComUsbBridge.c @@ -47,7 +47,9 @@ static void updateSettings(); // **************** // Private constants -#define STACK_SIZE_BYTES 280 +#define U2C_STACK_SIZE_BYTES 260 +#define C2U_STACK_SIZE_BYTES 315 + #define TASK_PRIORITY (tskIDLE_PRIORITY + 1) #define BRIDGE_BUF_LEN 10 @@ -76,9 +78,9 @@ static int32_t comUsbBridgeStart(void) { if (bridge_enabled) { // Start tasks - xTaskCreate(com2UsbBridgeTask, (signed char *)"Com2UsbBridge", STACK_SIZE_BYTES / 4, NULL, TASK_PRIORITY, &com2UsbBridgeTaskHandle); + xTaskCreate(com2UsbBridgeTask, (signed char *)"Com2UsbBridge", C2U_STACK_SIZE_BYTES / 4, NULL, TASK_PRIORITY, &com2UsbBridgeTaskHandle); PIOS_TASK_MONITOR_RegisterTask(TASKINFO_RUNNING_COM2USBBRIDGE, com2UsbBridgeTaskHandle); - xTaskCreate(usb2ComBridgeTask, (signed char *)"Usb2ComBridge", STACK_SIZE_BYTES / 4, NULL, TASK_PRIORITY, &usb2ComBridgeTaskHandle); + xTaskCreate(usb2ComBridgeTask, (signed char *)"Usb2ComBridge", U2C_STACK_SIZE_BYTES / 4, NULL, TASK_PRIORITY, &usb2ComBridgeTaskHandle); PIOS_TASK_MONITOR_RegisterTask(TASKINFO_RUNNING_USB2COMBRIDGE, usb2ComBridgeTaskHandle); return 0; } From 81e10c9d1b65038ecf593dfd2368a087cb5a1b87 Mon Sep 17 00:00:00 2001 From: Alessio Morale Date: Tue, 21 May 2013 00:15:18 +0200 Subject: [PATCH 2/9] OP-960 Prevent a warning to appear each time an alarm not in svg is received +review OPReview --- .../systemhealth/systemhealthgadgetwidget.cpp | 46 +++++++++++-------- .../systemhealth/systemhealthgadgetwidget.h | 2 +- 2 files changed, 28 insertions(+), 20 deletions(-) diff --git a/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.cpp b/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.cpp index 38f62569d..a1e4c8908 100644 --- a/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.cpp +++ b/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.cpp @@ -48,7 +48,7 @@ SystemHealthGadgetWidget::SystemHealthGadgetWidget(QWidget *parent) : QGraphicsV background = new QGraphicsSvgItem(); foreground = new QGraphicsSvgItem(); nolink = new QGraphicsSvgItem(); - + missingElements = new QStringList(); paint(); // Now connect the widget to the SystemAlarms UAVObject @@ -100,26 +100,32 @@ void SystemHealthGadgetWidget::updateAlarms(UAVObject *systemAlarm) for (uint i = 0; i < field->getNumElements(); ++i) { QString element = field->getElementNames()[i]; QString value = field->getValue(i).toString(); - if (m_renderer->elementExists(element)) { - QMatrix blockMatrix = m_renderer->matrixForElement(element); - qreal startX = blockMatrix.mapRect(m_renderer->boundsOnElement(element)).x(); - qreal startY = blockMatrix.mapRect(m_renderer->boundsOnElement(element)).y(); - QString element2 = element + "-" + value; - if (m_renderer->elementExists(element2)) { - QGraphicsSvgItem *ind = new QGraphicsSvgItem(); - ind->setSharedRenderer(m_renderer); - ind->setElementId(element2); - ind->setParentItem(background); - QTransform matrix; - matrix.translate(startX, startY); - ind->setTransform(matrix, false); - } else { - if (value.compare("Uninitialised") != 0) { - qDebug() << "Warning: element " << element2 << " not found in SVG."; + if (!missingElements->contains(element)){ + if (m_renderer->elementExists(element)) { + QMatrix blockMatrix = m_renderer->matrixForElement(element); + qreal startX = blockMatrix.mapRect(m_renderer->boundsOnElement(element)).x(); + qreal startY = blockMatrix.mapRect(m_renderer->boundsOnElement(element)).y(); + QString element2 = element + "-" + value; + if (!missingElements->contains(element2)) { + if (m_renderer->elementExists(element2)) { + QGraphicsSvgItem *ind = new QGraphicsSvgItem(); + ind->setSharedRenderer(m_renderer); + ind->setElementId(element2); + ind->setParentItem(background); + QTransform matrix; + matrix.translate(startX, startY); + ind->setTransform(matrix, false); + } else { + if (value.compare("Uninitialised") != 0) { + missingElements->append(element2); + qDebug() << "Warning: element " << element2 << " not found in SVG."; + } + } } + } else { + missingElements->append(element); + qDebug() << "Warning: Element " << element << " not found in SVG."; } - } else { - qDebug() << "Warning: Element " << element << " not found in SVG."; } } } @@ -133,6 +139,8 @@ SystemHealthGadgetWidget::~SystemHealthGadgetWidget() void SystemHealthGadgetWidget::setSystemFile(QString dfn) { + // Clear the list of elements not found on svg + missingElements->clear(); setBackgroundBrush(QBrush(Utils::StyleHelper::baseColor())); if (QFile::exists(dfn)) { m_renderer->load(dfn); diff --git a/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.h b/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.h index a76c58e1a..c48526382 100644 --- a/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.h +++ b/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.h @@ -64,7 +64,7 @@ private: QGraphicsSvgItem *background; QGraphicsSvgItem *foreground; QGraphicsSvgItem *nolink; - + QStringList *missingElements; // Simple flag to skip rendering if the bool fgenabled; // layer does not exist. From 2e3e5be0530828d43d071018b62b33da6737c4c7 Mon Sep 17 00:00:00 2001 From: Alessio Morale Date: Tue, 21 May 2013 08:29:35 +0200 Subject: [PATCH 3/9] OP-960 Fixed spacing +review OPReview-481 --- .../src/plugins/systemhealth/systemhealthgadgetwidget.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.cpp b/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.cpp index a1e4c8908..52d6d1f80 100644 --- a/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.cpp +++ b/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.cpp @@ -100,7 +100,7 @@ void SystemHealthGadgetWidget::updateAlarms(UAVObject *systemAlarm) for (uint i = 0; i < field->getNumElements(); ++i) { QString element = field->getElementNames()[i]; QString value = field->getValue(i).toString(); - if (!missingElements->contains(element)){ + if (!missingElements->contains(element)) { if (m_renderer->elementExists(element)) { QMatrix blockMatrix = m_renderer->matrixForElement(element); qreal startX = blockMatrix.mapRect(m_renderer->boundsOnElement(element)).x(); From cfaeead5b31b1c78d63b75e5bb95aab8e0c12016 Mon Sep 17 00:00:00 2001 From: Fredrik Arvidsson Date: Thu, 23 May 2013 21:26:43 +0200 Subject: [PATCH 4/9] OP-935 Adds tool-tips for the majority of the settings in the Stabilization screen. --- .../src/plugins/config/stabilization.ui | 166 ++++++++++++------ 1 file changed, 112 insertions(+), 54 deletions(-) diff --git a/ground/openpilotgcs/src/plugins/config/stabilization.ui b/ground/openpilotgcs/src/plugins/config/stabilization.ui index 1ac337c3c..ff4943958 100644 --- a/ground/openpilotgcs/src/plugins/config/stabilization.ui +++ b/ground/openpilotgcs/src/plugins/config/stabilization.ui @@ -479,6 +479,9 @@ false + + + false @@ -622,6 +625,9 @@ + + + @@ -649,6 +655,9 @@ 0 + + Reset all values to GCS defaults + Default @@ -1229,6 +1238,9 @@ true + + This thing really can preform, it is a lot more responsive this way + false @@ -1281,6 +1293,9 @@ border-radius: 5; + + <html><head/><body><p>The Rate Mode slider can be adjusted to value ranges whose responsivness is represented by the Moderate / Snappy / Insane bar</p></body></html> + 100 @@ -1906,6 +1921,9 @@ border-radius: 5; true + + Lazy Sunday afternoon flying, fly's nice and stable + false @@ -2456,6 +2474,9 @@ border-radius: 5; true + + Damn this is insane how quick it moves. Mostly used by the Pro's + false @@ -2506,6 +2527,9 @@ border-radius: 5; + + <html><head/><body><p>The Attitude Mode slider can be adjusted to value ranges whose responsivness is represented by the Moderate / Snappy / Insane bar</p></body></html> + 10 @@ -2540,6 +2564,9 @@ border-radius: 5; + + <html><head/><body><p>The Rate mode Yaw slider can be adjusted to value ranges whose responsivness is represented by the Moderate / Snappy / Insane bar</p></body></html> + 100 @@ -2674,6 +2701,9 @@ border-radius: 5; Qt::StrongFocus + + <html><head/><body><p>Link roll &amp; pitch sliders to move together, thus giving same value for both roll &amp; pitch when setting up a symetrical vehicle that requires both to be the same</p></body></html> + @@ -4354,8 +4384,7 @@ border-radius: 5; Qt::StrongFocus - Slowly raise Proportional until you start seeing clear oscillations when you fly. -Then lower the value by 5 or so. + <html><head/><body><p>This adjusts how much leveling stability is set into Rate mode (inner loop). Too much will make your vehicle oscillate in Rate mode.</p></body></html> @@ -4472,8 +4501,7 @@ Then lower the value by 5 or so. Qt::StrongFocus - Slowly raise Proportional until you start seeing clear oscillations when you fly. -Then lower the value by 5 or so. + <html><head/><body><p>This adjusts how much leveling stability is set into Rate mode (inner loop). Too much will make your vehicle oscillate in Rate mode.</p></body></html> @@ -4523,8 +4551,7 @@ Then lower the value by 5 or so. Qt::StrongFocus - Slowly raise Proportional until you start seeing clear oscillations when you fly. -Then lower the value by 5 or so. + <html><head/><body><p>This adjusts how much leveling stability is set into Rate mode (inner loop). Too much will make your vehicle oscillate in Rate mode.</p></body></html> @@ -4652,8 +4679,7 @@ Then lower the value by 5 or so. Qt::StrongFocus - As a rule of thumb, you can set the Integral at roughly the same -value as the Kp. + <html><head/><body><p>This adjusts how much stabilty your vehicle will have when flying tilted (ie forward flight) in Rate Mode. A good starting point for Integral is the same as Proportional</p></body></html> @@ -4800,8 +4826,7 @@ value as the Kp. Qt::StrongFocus - As a rule of thumb, you can set the Integral at roughly the same -value as the Kp. + <html><head/><body><p>This adjusts how much stabilty your vehicle will have when flying tilted (ie forward flight) in Rate Mode. A good starting point for Integral is the same as Proportional</p></body></html> @@ -4851,8 +4876,7 @@ value as the Kp. Qt::StrongFocus - As a rule of thumb, you can set the Integral at roughly the same -value as the Kp. + <html><head/><body><p>This adjusts how much stabilty your vehicle will have when flying tilted (ie forward flight) in Rate Mode. A good starting point for Integral is the same as Proportional</p></body></html> @@ -6053,6 +6077,9 @@ border-radius: 5; Qt::StrongFocus + + <html><head/><body><p>Link roll &amp; pitch sliders to move together, thus giving same value for both roll &amp; pitch when setting up a symetrical vehicle that requires both to be the same.</p></body></html> + @@ -8251,6 +8278,9 @@ border-radius: 5; Qt::StrongFocus + + <html><head/><body><p>This adjusts how much leveling stability is set into Attitude mode (outer loop). Too much will make your vehicle oscillate in Attitude Mode.</p></body></html> + @@ -8333,6 +8363,9 @@ border-radius: 5; Qt::StrongFocus + + <html><head/><body><p>This adjusts how much leveling stability is set into Attitude mode (outer loop). Too much will make your vehicle oscillate in Attitude Mode.</p></body></html> + @@ -8415,6 +8448,9 @@ border-radius: 5; Qt::StrongFocus + + <html><head/><body><p>This adjusts how much leveling stability is set into Attitude mode (outer loop). Too much will make your vehicle oscillate in Attitude Mode.</p></body></html> + @@ -8592,7 +8628,7 @@ border-radius: 5; - When the throttle is low, zero the intergral term to prevent intergral wind-up + <html><head/><body><p>This function will avoid integral windup when at idle. Integral windup is an accumulation of over-correction and can make the vehicle flip during a slow takeoff.</p></body></html> @@ -8644,7 +8680,7 @@ border-radius: 5; - Enabling this feature mean that any changes made to the sliders will be instantly sent and used by the Flight Controller, useful for two person tuning where one normally flies and ones changes the GCS. + <html><head/><body><p>Enabling this feature mean that any changes made to the sliders will be instantly sent and used by the Flight Controller, useful for two person tuning where one normally flies and ones changes the GCS.</p></body></html> @@ -8765,7 +8801,7 @@ border-radius: 5; 0 - 0 + -49 936 702 @@ -9858,6 +9894,9 @@ border-radius: 5; Qt::StrongFocus + + <html><head/><body><p>Sets the maximum deg your vehicle will tilt at full stick input when in Attitude mode.</p></body></html> + @@ -9939,7 +9978,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>This sets the maximum rotation rate in degress per second on an axis.</p></body></html> @@ -10008,7 +10047,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>Sets the degress per second the your vehcle will tilt/rotate at full stick input when in all modes except Attitude.</p></body></html> @@ -10061,7 +10100,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>Sets the maximum deg your vehicle will tilt at full stick input when in Attitude mode.</p></body></html> @@ -10112,6 +10151,9 @@ border-radius: 5; Qt::StrongFocus + + <html><head/><body><p>This sets the maximum rotation rate in degress per second on an axis.</p></body></html> + @@ -11319,6 +11361,9 @@ border-radius: 5; Qt::StrongFocus + + <html><head/><body><p>Sets the degress per second the your vehcle will tilt/rotate at full stick input when in all modes except Attitude.</p></body></html> + @@ -11936,7 +11981,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>Sets the degress per second the your vehcle will tilt/rotate at full stick input when in all modes except Attitude.</p></body></html> @@ -11989,7 +12034,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>Sets the maximum deg your vehicle will tilt at full stick input when in Attitude mode.</p></body></html> @@ -12044,7 +12089,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>This sets the maximum rotation rate in degress per second on an axis.</p></body></html> @@ -12682,6 +12727,9 @@ border-radius: 5; + + <html><head/><body><p>Link roll &amp; pitch values together, thus giving the same value for each when setting up a symetrical vehicle that requires both to be the same.</p></body></html> + @@ -13202,6 +13250,9 @@ border-radius: 5; Qt::StrongFocus + + <html><head/><body><p>This makes the control output respond faster due to fast stick movements or external disturbance like wind gusts.It also acts like a dampener, thus allowing higher KP settings. Only effects Rate Mode.</p></body></html> + @@ -13819,8 +13870,7 @@ border-radius: 5; Qt::StrongFocus - As a rule of thumb, you can set the Ki at roughly the same -value as the Kp. + <html><head/><body><p>This adjusts how much stabilty your vehicle will have when flying tilted (ie forward flight) in Rate Mode. A good starting point for Integral is the same as Proportional.</p></body></html> @@ -13870,8 +13920,7 @@ value as the Kp. Qt::StrongFocus - As a rule of thumb, you can set the Ki at roughly the same -value as the Kp. + <html><head/><body><p>This adjusts how much stabilty your vehicle will have when flying tilted (ie forward flight) in Rate Mode. A good starting point for Integral is the same as Proportional.</p></body></html> @@ -13921,10 +13970,7 @@ value as the Kp. Qt::StrongFocus - Slowly raise Kp until you start seeing clear oscillations when you fly. -Then lower the value by 20% or so. - -You can usually go for higher values for Yaw factors. + <html><head/><body><p>This adjusts how much leveling stability is set into Rate mode (inner loop). Too much will make your vehicle oscillate in Rate mode.</p></body></html> @@ -13974,7 +14020,7 @@ You can usually go for higher values for Yaw factors. Qt::StrongFocus - + <html><head/><body><p>This makes the control output respond faster due to fast stick movements or external disturbance like wind gusts.It also acts like a dampener, thus allowing higher KP settings. Only effects Rate Mode.</p></body></html> @@ -15181,8 +15227,7 @@ border-radius: 5; Qt::StrongFocus - Slowly raise Kp until you start seeing clear oscillations when you fly. -Then lower the value by 20% or so. + <html><head/><body><p>This adjusts how much leveling stability is set into Rate mode (inner loop). Too much will make your vehicle oscillate in Rate mode.</p></body></html> @@ -15248,8 +15293,7 @@ Then lower the value by 20% or so. Qt::StrongFocus - As a rule of thumb, you can set the Ki at roughly the same -value as the Kp. + <html><head/><body><p>This adjusts how much stabilty your vehicle will have when flying tilted (ie forward flight) in Rate Mode. A good starting point for Integral is the same as Proportional.</p></body></html> @@ -15330,8 +15374,7 @@ value as the Kp. Qt::StrongFocus - Slowly raise Kp until you start seeing clear oscillations when you fly. -Then lower the value by 20% or so. + <html><head/><body><p>This adjusts how much leveling stability is set into Rate mode (inner loop). Too much will make your vehicle oscillate in Rate mode.</p></body></html> @@ -15381,7 +15424,7 @@ Then lower the value by 20% or so. Qt::StrongFocus - + <html><head/><body><p>This makes the control output respond faster due to fast stick movements or external disturbance like wind gusts.It also acts like a dampener, thus allowing higher KP settings. Only effects Rate Mode.</p></body></html> @@ -15997,6 +16040,9 @@ Then lower the value by 20% or so. + + <html><head/><body><p>Link roll &amp; pitch values together, thus giving the same value for each when setting up a symetrical vehicle that requires both to be the same.</p></body></html> + @@ -18222,7 +18268,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>This adjusts how much leveling stability is set into Attitude mode (outer loop). Too much will make your vehicle oscillate in Attitude Mode.</p></body></html> @@ -18271,6 +18317,9 @@ border-radius: 5; Qt::StrongFocus + + <html><head/><body><p>This adjusts how much leveling stability is set into Attitude mode (outer loop). Too much will make your vehicle oscillate in Attitude Mode.</p></body></html> + @@ -18319,7 +18368,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>This adjusts how much leveling stability is set into Attitude mode (outer loop). Too much will make your vehicle oscillate in Attitude Mode.</p></body></html> @@ -18404,7 +18453,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>This adjusts how much stabilty your vehicle will have when flying tilted (ie forward flight) in Attitude Mode. Adding Ki in Attitude when Ki is present in Rate is not recommended.</p></body></html> @@ -18469,6 +18518,9 @@ border-radius: 5; Qt::StrongFocus + + <html><head/><body><p>This adjusts how much stabilty your vehicle will have when flying tilted (ie forward flight) in Attitude Mode. Adding Ki in Attitude when Ki is present in Rate is not recommended.</p></body></html> + @@ -18533,7 +18585,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>This adjusts how much stabilty your vehicle will have when flying tilted (ie forward flight) in Attitude Mode. Adding Ki in Attitude when Ki is present in Rate is not recommended.</p></body></html> @@ -18611,7 +18663,7 @@ border-radius: 5; - Enabling this feature mean that any changes made to the sliders will be instantly sent and used by the Flight Controller, useful for two person tuning where one normally flies and ones changes the GCS. + <html><head/><body><p>Enabling this feature mean that any changes made to the sliders will be instantly sent and used by the Flight Controller, useful for two person tuning where one normally flies and ones changes the GCS.</p></body></html> @@ -21124,7 +21176,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>In Weak Leveling mode, this setting acts like Attitude Kp. If you make this setting too high, it can cause oscillations.</p></body></html> @@ -21192,7 +21244,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>In Weak Leveling mode, this is the maximum number of degrees per second that weak leveling will move the vehicle.</p></body></html> @@ -21260,7 +21312,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>In AxisLock mode, this is the maximum number of degrees of correction. If movement by outside forces (eg Wind) are less than the set value your vehicle will return to centre. More than set amount and will only move your vehicle the set amount back to centre.</p></body></html> @@ -21331,7 +21383,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>In AxisLock mode, this setting controls how many degrees per second you can request with the stick before OpenPilot stops trying to gently hold its position and goes into normal rate mode. This setting works almost like a dead band. Default value should work fine.</p></body></html> @@ -21735,6 +21787,9 @@ border-radius: 5; Qt::StrongFocus + + <html><head/><body><p>Sets the maximum value of the integral (KP) that is used in Rate Mode.</p></body></html> + @@ -21786,7 +21841,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>Sets the maximum value of the integral (KP) that is used in Rate Mode.</p></body></html> @@ -22939,7 +22994,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>Sets the maximum value of the integral (KP) that is used in AttitudeMode.</p></body></html> @@ -23019,6 +23074,9 @@ border-radius: 5; Qt::StrongFocus + + <html><head/><body><p>Sets the maximum value of the integral (KP) that is used in AttitudeMode.</p></body></html> + @@ -23127,7 +23185,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>Sets the maximum value of the integral (KP) that is used in AttitudeMode.</p></body></html> @@ -23740,7 +23798,7 @@ border-radius: 5; Qt::StrongFocus - + <html><head/><body><p>Sets the maximum value of the integral (KP) that is used in Rate Mode.</p></body></html> @@ -24915,7 +24973,7 @@ border-radius: 5; Qt::StrongFocus - The proportional term for the accelerometer, the higher this term the more weight the accel is given + <html><head/><body><p>The proportional term for the accelerometer, the higher this term the more weight the accel is given.</p></body></html> @@ -26067,7 +26125,7 @@ border-radius: 5; Qt::StrongFocus - GyroTau is a gyro filter, the higher the factor the more filtering is applied to the gyros + <html><head/><body><p>In effect, a vibrations filter for the gyro. Default 0.005 - Max .020.</p></body></html> @@ -26682,7 +26740,7 @@ border-radius: 5; Qt::StrongFocus - The intergral term for the accelerometer within the filter + <html><head/><body><p>The intergral term for the accelerometer within the filter.</p></body></html> @@ -26762,7 +26820,7 @@ border-radius: 5; - Enabling this feature mean that any changes made to the sliders will be instantly sent and used by the Flight Controller, useful for two person tuning where one normally flies and ones changes the GCS. + <html><head/><body><p>Enabling this feature mean that any changes made to the sliders will be instantly sent and used by the Flight Controller, useful for two person tuning where one normally flies and ones changes the GCS.</p></body></html> From 5fcc8a1785513add89c778384a649e7a7f2dcac7 Mon Sep 17 00:00:00 2001 From: Brian Webb Date: Thu, 23 May 2013 22:02:31 -0700 Subject: [PATCH 5/9] Changes default for RemoteMainPort in OPLinkSettings UAVObject to Disabled from Telemetry, which was not in the list of possible choices. --- shared/uavobjectdefinition/oplinksettings.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shared/uavobjectdefinition/oplinksettings.xml b/shared/uavobjectdefinition/oplinksettings.xml index 62d2b1edd..d6dfd7844 100644 --- a/shared/uavobjectdefinition/oplinksettings.xml +++ b/shared/uavobjectdefinition/oplinksettings.xml @@ -2,7 +2,7 @@ OPLink configurations options. - + From bd538703ea3ddb297a86047c1f012dd84bd179f0 Mon Sep 17 00:00:00 2001 From: "Richard Flay (Hyper)" Date: Sat, 25 May 2013 17:10:41 +0930 Subject: [PATCH 6/9] OP-962: Tweaked C2U_STACK_SIZE_BYTES to be a multiple of 4. +review OPReview-480 --- flight/modules/ComUsbBridge/ComUsbBridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flight/modules/ComUsbBridge/ComUsbBridge.c b/flight/modules/ComUsbBridge/ComUsbBridge.c index c7674ec00..95b42dc22 100644 --- a/flight/modules/ComUsbBridge/ComUsbBridge.c +++ b/flight/modules/ComUsbBridge/ComUsbBridge.c @@ -48,7 +48,7 @@ static void updateSettings(); // Private constants #define U2C_STACK_SIZE_BYTES 260 -#define C2U_STACK_SIZE_BYTES 315 +#define C2U_STACK_SIZE_BYTES 316 #define TASK_PRIORITY (tskIDLE_PRIORITY + 1) From 03a2e82ba374c12d1296ebc7548db6342d1cd62e Mon Sep 17 00:00:00 2001 From: Fredrik Arvidsson Date: Sat, 25 May 2013 09:42:26 +0200 Subject: [PATCH 7/9] OP-970 Adds antenna warning dialog when activating built in modem for Revolution. --- ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp b/ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp index f04b3b493..7c0feaad1 100644 --- a/ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp +++ b/ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp @@ -32,6 +32,7 @@ #include "hwsettings.h" #include #include +#include ConfigRevoHWWidget::ConfigRevoHWWidget(QWidget *parent) : ConfigTaskWidget(parent) @@ -93,7 +94,7 @@ void ConfigRevoHWWidget::setupCustomCombos() connect(m_ui->cbFlexi, SIGNAL(currentIndexChanged(int)), this, SLOT(flexiPortChanged(int))); connect(m_ui->cbMain, SIGNAL(currentIndexChanged(int)), this, SLOT(mainPortChanged(int))); - connect(m_ui->cbModem, SIGNAL(currentIndexChanged(int)), this, SLOT(modemPortChanged(int))); + connect(m_ui->cbModem, SIGNAL(currentIndexChanged(int)), this, SLOT(modemPortChanged(int))); } void ConfigRevoHWWidget::refreshWidgetsValues(UAVObject *obj) @@ -291,6 +292,7 @@ void ConfigRevoHWWidget::modemPortChanged(int index) m_ui->cbTxPower->setVisible(true); m_ui->lblInitFreq->setVisible(true); m_ui->leInitFreq->setVisible(true); + QMessageBox::warning(this, tr("Warning"), tr("Activating the Radio requires an antenna be attached, or modem damage will occur.")); } else { m_ui->lblTxPower->setVisible(false); m_ui->cbTxPower->setVisible(false); From 3c55485d88302748e13006978a4fff8a964e367b Mon Sep 17 00:00:00 2001 From: Fredrik Arvidsson Date: Sat, 25 May 2013 09:43:59 +0200 Subject: [PATCH 8/9] OP-970 Removes a comma. --- ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp b/ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp index 7c0feaad1..73e18ba1c 100644 --- a/ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp +++ b/ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp @@ -292,7 +292,7 @@ void ConfigRevoHWWidget::modemPortChanged(int index) m_ui->cbTxPower->setVisible(true); m_ui->lblInitFreq->setVisible(true); m_ui->leInitFreq->setVisible(true); - QMessageBox::warning(this, tr("Warning"), tr("Activating the Radio requires an antenna be attached, or modem damage will occur.")); + QMessageBox::warning(this, tr("Warning"), tr("Activating the Radio requires an antenna be attached or modem damage will occur.")); } else { m_ui->lblTxPower->setVisible(false); m_ui->cbTxPower->setVisible(false); From d492d3e14e1bbd858ab1caf193aec18486fce07a Mon Sep 17 00:00:00 2001 From: Fredrik Arvidsson Date: Sat, 25 May 2013 12:04:50 +0200 Subject: [PATCH 9/9] OP-970 Fixes a problem with the Radio/Modem warning dialog showing up on board connection. --- .../src/plugins/config/configrevohwwidget.cpp | 9 +++++++-- .../openpilotgcs/src/plugins/config/configrevohwwidget.h | 1 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp b/ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp index 73e18ba1c..c5a72f0b6 100644 --- a/ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp +++ b/ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp @@ -35,7 +35,7 @@ #include -ConfigRevoHWWidget::ConfigRevoHWWidget(QWidget *parent) : ConfigTaskWidget(parent) +ConfigRevoHWWidget::ConfigRevoHWWidget(QWidget *parent) : ConfigTaskWidget(parent), m_refreshing(true) { m_ui = new Ui_RevoHWWidget(); m_ui->setupUi(this); @@ -76,6 +76,7 @@ ConfigRevoHWWidget::ConfigRevoHWWidget(QWidget *parent) : ConfigTaskWidget(paren populateWidgets(); refreshWidgetsValues(); forceConnectedState(); + m_refreshing = false; } ConfigRevoHWWidget::~ConfigRevoHWWidget() @@ -99,12 +100,14 @@ void ConfigRevoHWWidget::setupCustomCombos() void ConfigRevoHWWidget::refreshWidgetsValues(UAVObject *obj) { + m_refreshing = true; ConfigTaskWidget::refreshWidgetsValues(obj); usbVCPPortChanged(0); mainPortChanged(0); flexiPortChanged(0); modemPortChanged(0); + m_refreshing = false; } void ConfigRevoHWWidget::updateObjectsFromWidgets() @@ -292,7 +295,9 @@ void ConfigRevoHWWidget::modemPortChanged(int index) m_ui->cbTxPower->setVisible(true); m_ui->lblInitFreq->setVisible(true); m_ui->leInitFreq->setVisible(true); - QMessageBox::warning(this, tr("Warning"), tr("Activating the Radio requires an antenna be attached or modem damage will occur.")); + if(!m_refreshing) { + QMessageBox::warning(this, tr("Warning"), tr("Activating the Radio requires an antenna be attached or modem damage will occur.")); + } } else { m_ui->lblTxPower->setVisible(false); m_ui->cbTxPower->setVisible(false); diff --git a/ground/openpilotgcs/src/plugins/config/configrevohwwidget.h b/ground/openpilotgcs/src/plugins/config/configrevohwwidget.h index bfabea5b4..d7eb30b66 100644 --- a/ground/openpilotgcs/src/plugins/config/configrevohwwidget.h +++ b/ground/openpilotgcs/src/plugins/config/configrevohwwidget.h @@ -44,6 +44,7 @@ public: ~ConfigRevoHWWidget(); private: + bool m_refreshing; Ui_RevoHWWidget *m_ui; void setupCustomCombos();